Compare commits
41 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| dbf05ead2a | |||
| a8bb038a75 | |||
| 3372149277 | |||
| c08be69618 | |||
| b42b1a193d | |||
| d8ca0d5244 | |||
| f6d85bc80f | |||
| 0457ac9063 | |||
| b2b2815954 | |||
| d992c10bc1 | |||
| 091b9053a3 | |||
| 97274a74b2 | |||
| c59fb8dcbc | |||
| 7f56cc0cf3 | |||
| 974b338b7e | |||
| d2557474e2 | |||
| 3004c642da | |||
| ae86f61dac | |||
| c221c4d112 | |||
| 185ea83d1b | |||
| f96d8e6b08 | |||
| 0fd631f107 | |||
| 27b9f8e2ff | |||
| a2150593ca | |||
| f495b00472 | |||
| ddcc8f3aad | |||
| 21a7f35345 | |||
| 0536b0e707 | |||
| 400d98d95d | |||
| 25ec8d0869 | |||
| 56b2b3a41e | |||
| a9543f22b2 | |||
| c2ee6c32a4 | |||
| d328b21e7d | |||
| cf7393cabb | |||
| b547dc4f7a | |||
| 5aa16c3052 | |||
| a0489c459c | |||
| 548a11794e | |||
| 846720a286 | |||
| d76f7b1cbc |
@@ -9,11 +9,11 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
with:
|
||||
fetch-depth: 2
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@v2
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 20.x
|
||||
- name: Set up publish access
|
||||
|
||||
@@ -9,5 +9,5 @@ jobs:
|
||||
build-docker:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
- run: docker build -t excalidraw .
|
||||
|
||||
@@ -7,10 +7,10 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@v2
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 20.x
|
||||
|
||||
|
||||
@@ -10,12 +10,12 @@ jobs:
|
||||
runs-on: ubuntu-latest
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
with:
|
||||
token: ${{ secrets.PUSH_TRANSLATIONS_COVERAGE_PAT }}
|
||||
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@v2
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 20.x
|
||||
|
||||
|
||||
@@ -11,7 +11,7 @@ jobs:
|
||||
|
||||
steps:
|
||||
- name: Checkout repository
|
||||
uses: actions/checkout@v3
|
||||
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
- name: Login to DockerHub
|
||||
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2
|
||||
with:
|
||||
|
||||
@@ -6,11 +6,97 @@ on:
|
||||
- opened
|
||||
- edited
|
||||
- synchronize
|
||||
- labeled
|
||||
- unlabeled
|
||||
|
||||
jobs:
|
||||
semantic:
|
||||
runs-on: ubuntu-latest
|
||||
permissions:
|
||||
pull-requests: read
|
||||
steps:
|
||||
- uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5
|
||||
with:
|
||||
requireScope: true
|
||||
scopes: |
|
||||
app
|
||||
editor
|
||||
packages/excalidraw
|
||||
packages/utils
|
||||
docker
|
||||
repo
|
||||
ignoreLabels: |
|
||||
skip-semantic-title
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
|
||||
label-scope:
|
||||
needs: semantic
|
||||
if: github.event.pull_request.head.repo.full_name == github.repository
|
||||
runs-on: ubuntu-latest
|
||||
permissions:
|
||||
issues: write
|
||||
pull-requests: write
|
||||
steps:
|
||||
- name: Label scoped PR
|
||||
env:
|
||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||
PR_TITLE: ${{ github.event.pull_request.title }}
|
||||
REPOSITORY: ${{ github.repository }}
|
||||
run: |
|
||||
set -euo pipefail
|
||||
|
||||
scope_labels=(s-app s-editor s-package)
|
||||
|
||||
readarray -t desired_labels < <(
|
||||
node <<'NODE'
|
||||
const title = process.env.PR_TITLE;
|
||||
const match = title.match(/^[a-z]+(?:\(([^)]+)\))?!?:/i);
|
||||
const scopes = match?.[1]?.split(",").map((scope) => scope.trim()) ?? [];
|
||||
const labels = new Set();
|
||||
|
||||
for (const scope of scopes) {
|
||||
if (scope === "app") {
|
||||
labels.add("s-app");
|
||||
} else if (scope === "editor") {
|
||||
labels.add("s-editor");
|
||||
} else if (scope.startsWith("packages/")) {
|
||||
labels.add("s-package");
|
||||
}
|
||||
}
|
||||
|
||||
process.stdout.write([...labels].join("\n"));
|
||||
NODE
|
||||
)
|
||||
|
||||
should_apply_label() {
|
||||
local label="$1"
|
||||
|
||||
for desired_label in "${desired_labels[@]}"; do
|
||||
if [[ "$desired_label" == "$label" ]]; then
|
||||
return 0
|
||||
fi
|
||||
done
|
||||
|
||||
return 1
|
||||
}
|
||||
|
||||
for label in "${scope_labels[@]}"; do
|
||||
if ! should_apply_label "$label"; then
|
||||
gh api \
|
||||
--method DELETE \
|
||||
"repos/${REPOSITORY}/issues/${PR_NUMBER}/labels/${label}" \
|
||||
--silent 2>/dev/null || true
|
||||
fi
|
||||
done
|
||||
|
||||
for label in "${desired_labels[@]}"; do
|
||||
if ! gh api \
|
||||
--method POST \
|
||||
"repos/${REPOSITORY}/issues/${PR_NUMBER}/labels" \
|
||||
--field "labels[]=${label}" \
|
||||
--silent; then
|
||||
echo "::warning::Could not apply ${label}. The workflow token likely does not have issues:write permission for this PR."
|
||||
fi
|
||||
done
|
||||
|
||||
@@ -9,9 +9,9 @@ jobs:
|
||||
sentry:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@v2
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 20.x
|
||||
- name: Install and build
|
||||
|
||||
@@ -10,9 +10,9 @@ jobs:
|
||||
CI_JOB_NUMBER: 1
|
||||
steps:
|
||||
- name: Checkout repository
|
||||
uses: actions/checkout@v3
|
||||
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@v3
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 20.x
|
||||
- name: Install in packages/excalidraw
|
||||
|
||||
@@ -10,9 +10,9 @@ jobs:
|
||||
pull-requests: write
|
||||
|
||||
steps:
|
||||
- uses: actions/checkout@v2
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
- name: "Install Node"
|
||||
uses: actions/setup-node@v2
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: "20.x"
|
||||
- name: "Install Deps"
|
||||
|
||||
@@ -8,9 +8,9 @@ jobs:
|
||||
test:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||
- name: Setup Node.js
|
||||
uses: actions/setup-node@v4
|
||||
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||
with:
|
||||
node-version: 20.x
|
||||
- name: Install and test
|
||||
|
||||
+3
-3
@@ -1,4 +1,4 @@
|
||||
FROM --platform=${BUILDPLATFORM} node:24 AS build
|
||||
FROM --platform=${BUILDPLATFORM} node:24@sha256:8530f76a96d88820d288761f022e318970dda93d01536919fbc16076b7983e63 AS build
|
||||
|
||||
WORKDIR /opt/node_app
|
||||
|
||||
@@ -7,13 +7,13 @@ COPY . .
|
||||
# do not ignore optional dependencies:
|
||||
# Error: Cannot find module @rollup/rollup-linux-x64-gnu
|
||||
RUN --mount=type=cache,target=/root/.cache/yarn \
|
||||
npm_config_target_arch=${TARGETARCH} yarn --network-timeout 600000
|
||||
npm_config_target_arch=${TARGETARCH} yarn --frozen-lockfile --network-timeout 600000
|
||||
|
||||
ARG NODE_ENV=production
|
||||
|
||||
RUN npm_config_target_arch=${TARGETARCH} yarn build:app:docker
|
||||
|
||||
FROM nginx:1.27-alpine
|
||||
FROM nginx:stable-alpine-slim@sha256:2c605dbeab79a6b2a63340474fe58119d0ef95bdc4b1f41df0aa689659b3d13b
|
||||
|
||||
COPY --from=build /opt/node_app/excalidraw-app/build /usr/share/nginx/html
|
||||
|
||||
|
||||
@@ -136,6 +136,7 @@ import { useHandleAppTheme } from "./useHandleAppTheme";
|
||||
import { getPreferredLanguage } from "./app-language/language-detector";
|
||||
import { useAppLangCode } from "./app-language/language-state";
|
||||
import DebugCanvas, {
|
||||
ConsoleLogger,
|
||||
debugRenderer,
|
||||
isVisualDebuggerEnabled,
|
||||
loadSavedDebugState,
|
||||
@@ -1261,6 +1262,7 @@ const ExcalidrawWrapper = () => {
|
||||
ref={debugCanvasRef}
|
||||
/>
|
||||
)}
|
||||
{isVisualDebuggerEnabled() && <ConsoleLogger />}
|
||||
</Excalidraw>
|
||||
</div>
|
||||
);
|
||||
|
||||
@@ -42,6 +42,7 @@ export const STORAGE_KEYS = {
|
||||
LOCAL_STORAGE_COLLAB: "excalidraw-collab",
|
||||
LOCAL_STORAGE_THEME: "excalidraw-theme",
|
||||
LOCAL_STORAGE_DEBUG: "excalidraw-debug",
|
||||
LOCAL_STORAGE_DEBUG_CONSOLE: "excalidraw-debug-console",
|
||||
VERSION_DATA_STATE: "version-dataState",
|
||||
VERSION_FILES: "version-files",
|
||||
|
||||
|
||||
@@ -355,6 +355,8 @@ class Collab extends PureComponent<CollabProps, CollabState> {
|
||||
};
|
||||
|
||||
stopCollaboration = (keepRemoteState = true) => {
|
||||
this.broadcastElements.flush();
|
||||
this.broadcastElements.cancel();
|
||||
this.queueBroadcastAllElements.cancel();
|
||||
this.queueSaveToFirebase.cancel();
|
||||
this.loadImageFiles.cancel();
|
||||
@@ -941,7 +943,9 @@ class Collab extends PureComponent<CollabProps, CollabState> {
|
||||
this.portal.broadcastIdleChange(userState);
|
||||
};
|
||||
|
||||
broadcastElements = (elements: readonly OrderedExcalidrawElement[]) => {
|
||||
private _broadcastElements = (
|
||||
elements: readonly OrderedExcalidrawElement[],
|
||||
) => {
|
||||
if (
|
||||
getSceneVersion(elements) >
|
||||
this.getLastBroadcastedOrReceivedSceneVersion()
|
||||
@@ -952,6 +956,13 @@ class Collab extends PureComponent<CollabProps, CollabState> {
|
||||
}
|
||||
};
|
||||
|
||||
broadcastElements = throttle(
|
||||
(elements: readonly OrderedExcalidrawElement[]) =>
|
||||
this._broadcastElements(elements),
|
||||
10,
|
||||
{ leading: true, trailing: true },
|
||||
);
|
||||
|
||||
syncElements = (elements: readonly OrderedExcalidrawElement[]) => {
|
||||
this.broadcastElements(elements);
|
||||
this.queueSaveToFirebase();
|
||||
|
||||
@@ -4,7 +4,8 @@ import {
|
||||
eyeIcon,
|
||||
} from "@excalidraw/excalidraw/components/icons";
|
||||
import { MainMenu } from "@excalidraw/excalidraw/index";
|
||||
import React from "react";
|
||||
import DropdownMenuItemCheckbox from "@excalidraw/excalidraw/components/dropdownMenu/DropdownMenuItemCheckbox";
|
||||
import React, { useState } from "react";
|
||||
|
||||
import { isDevEnv } from "@excalidraw/common";
|
||||
|
||||
@@ -13,7 +14,29 @@ import type { Theme } from "@excalidraw/element/types";
|
||||
import { LanguageList } from "../app-language/LanguageList";
|
||||
import { isExcalidrawPlusSignedUser } from "../app_constants";
|
||||
|
||||
import { saveDebugState } from "./DebugCanvas";
|
||||
import {
|
||||
isVisualDebuggerEnabled,
|
||||
loadConsoleLoggerState,
|
||||
saveDebugState,
|
||||
setConsoleLoggerEnabled,
|
||||
} from "./DebugCanvas";
|
||||
|
||||
const ConsoleLoggerToggle = () => {
|
||||
const [checked, setChecked] = useState(() => loadConsoleLoggerState());
|
||||
return (
|
||||
<DropdownMenuItemCheckbox
|
||||
checked={checked}
|
||||
onSelect={(event) => {
|
||||
const next = !checked;
|
||||
setChecked(next);
|
||||
setConsoleLoggerEnabled(next);
|
||||
event.preventDefault();
|
||||
}}
|
||||
>
|
||||
Show console log overlay
|
||||
</DropdownMenuItemCheckbox>
|
||||
);
|
||||
};
|
||||
|
||||
export const AppMainMenu: React.FC<{
|
||||
onCollabDialogOpen: () => any;
|
||||
@@ -77,7 +100,13 @@ export const AppMainMenu: React.FC<{
|
||||
</MainMenu.Item>
|
||||
)}
|
||||
<MainMenu.Separator />
|
||||
<MainMenu.DefaultItems.Preferences />
|
||||
<MainMenu.DefaultItems.Preferences
|
||||
additionalItems={
|
||||
isDevEnv() && isVisualDebuggerEnabled() ? (
|
||||
<ConsoleLoggerToggle />
|
||||
) : null
|
||||
}
|
||||
/>
|
||||
<MainMenu.DefaultItems.ToggleTheme
|
||||
allowSystemTheme
|
||||
theme={props.theme}
|
||||
|
||||
@@ -9,7 +9,7 @@ import {
|
||||
} from "@excalidraw/excalidraw/renderer/helpers";
|
||||
import { type AppState } from "@excalidraw/excalidraw/types";
|
||||
import { arrayToMap, throttleRAF } from "@excalidraw/common";
|
||||
import { useCallback } from "react";
|
||||
import { useCallback, useEffect, useRef, useState } from "react";
|
||||
|
||||
import {
|
||||
getGlobalFixedPointForBindableElement,
|
||||
@@ -435,6 +435,34 @@ export const loadSavedDebugState = () => {
|
||||
export const isVisualDebuggerEnabled = () =>
|
||||
Array.isArray(window.visualDebug?.data);
|
||||
|
||||
export const loadConsoleLoggerState = (): boolean => {
|
||||
try {
|
||||
const raw = localStorage.getItem(STORAGE_KEYS.LOCAL_STORAGE_DEBUG_CONSOLE);
|
||||
if (raw !== null) {
|
||||
return JSON.parse(raw) === true;
|
||||
}
|
||||
} catch {}
|
||||
return false;
|
||||
};
|
||||
|
||||
export const saveConsoleLoggerState = (enabled: boolean) => {
|
||||
try {
|
||||
localStorage.setItem(
|
||||
STORAGE_KEYS.LOCAL_STORAGE_DEBUG_CONSOLE,
|
||||
JSON.stringify(enabled),
|
||||
);
|
||||
} catch {}
|
||||
};
|
||||
|
||||
const CONSOLE_LOGGER_TOGGLE_EVENT = "excalidraw-debug-console-toggle";
|
||||
|
||||
export const setConsoleLoggerEnabled = (enabled: boolean) => {
|
||||
saveConsoleLoggerState(enabled);
|
||||
window.dispatchEvent(
|
||||
new CustomEvent<boolean>(CONSOLE_LOGGER_TOGGLE_EVENT, { detail: enabled }),
|
||||
);
|
||||
};
|
||||
|
||||
export const DebugFooter = ({ onChange }: { onChange: () => void }) => {
|
||||
const moveForward = useCallback(() => {
|
||||
if (
|
||||
@@ -459,6 +487,7 @@ export const DebugFooter = ({ onChange }: { onChange: () => void }) => {
|
||||
}, [onChange]);
|
||||
const reset = useCallback(() => {
|
||||
window.visualDebug!.currentFrame = undefined;
|
||||
_clearLogsCallback?.();
|
||||
onChange();
|
||||
}, [onChange]);
|
||||
const trashFrames = useCallback(() => {
|
||||
@@ -466,6 +495,7 @@ export const DebugFooter = ({ onChange }: { onChange: () => void }) => {
|
||||
window.visualDebug.currentFrame = undefined;
|
||||
window.visualDebug.data = [];
|
||||
}
|
||||
_clearLogsCallback?.();
|
||||
onChange();
|
||||
}, [onChange]);
|
||||
|
||||
@@ -563,4 +593,181 @@ const DebugCanvas = React.forwardRef<HTMLCanvasElement, DebugCanvasProps>(
|
||||
},
|
||||
);
|
||||
|
||||
type LogLevel = "log" | "info" | "warn" | "error";
|
||||
|
||||
interface LogEntry {
|
||||
id: number;
|
||||
level: LogLevel;
|
||||
message: string;
|
||||
timestamp: number;
|
||||
}
|
||||
|
||||
const LOG_COLORS: Record<LogLevel, string> = {
|
||||
log: "rgba(220,220,220,0.9)",
|
||||
info: "rgba(100,180,255,0.9)",
|
||||
warn: "rgba(255,200,60,0.9)",
|
||||
error: "rgba(255,90,90,0.9)",
|
||||
};
|
||||
|
||||
const MAX_LOGS = 500;
|
||||
let logIdCounter = 0;
|
||||
let _clearLogsCallback: (() => void) | null = null;
|
||||
|
||||
export const ConsoleLogger = () => {
|
||||
const [enabled, setEnabled] = useState(() => loadConsoleLoggerState());
|
||||
const [logs, setLogs] = useState<LogEntry[]>([]);
|
||||
const logsRef = useRef<LogEntry[]>([]);
|
||||
const scrollRef = useRef<HTMLDivElement>(null);
|
||||
const dragState = useRef<{ startY: number; startScrollTop: number } | null>(
|
||||
null,
|
||||
);
|
||||
const isDragging = useRef(false);
|
||||
|
||||
useEffect(() => {
|
||||
const handler = (e: Event) => {
|
||||
setEnabled((e as CustomEvent<boolean>).detail);
|
||||
};
|
||||
window.addEventListener(CONSOLE_LOGGER_TOGGLE_EVENT, handler);
|
||||
return () => {
|
||||
window.removeEventListener(CONSOLE_LOGGER_TOGGLE_EVENT, handler);
|
||||
};
|
||||
}, []);
|
||||
|
||||
useEffect(() => {
|
||||
_clearLogsCallback = () => {
|
||||
logsRef.current = [];
|
||||
setLogs([]);
|
||||
};
|
||||
return () => {
|
||||
_clearLogsCallback = null;
|
||||
};
|
||||
}, []);
|
||||
|
||||
useEffect(() => {
|
||||
const originals: Record<LogLevel, (...args: unknown[]) => void> = {
|
||||
// eslint-disable-next-line no-console
|
||||
log: console.log.bind(console),
|
||||
info: console.info.bind(console),
|
||||
warn: console.warn.bind(console),
|
||||
error: console.error.bind(console),
|
||||
};
|
||||
|
||||
const patch = (level: LogLevel) => {
|
||||
// eslint-disable-next-line no-console
|
||||
console[level] = (...args: unknown[]) => {
|
||||
originals[level](...args);
|
||||
const message = args
|
||||
.map((a) =>
|
||||
typeof a === "object" ? JSON.stringify(a, null, 0) : String(a),
|
||||
)
|
||||
.join(" ");
|
||||
const entry: LogEntry = {
|
||||
id: ++logIdCounter,
|
||||
level,
|
||||
message,
|
||||
timestamp: Date.now(),
|
||||
};
|
||||
logsRef.current = [...logsRef.current, entry].slice(-MAX_LOGS);
|
||||
setLogs([...logsRef.current]);
|
||||
if (!isDragging.current && scrollRef.current) {
|
||||
scrollRef.current.scrollTop = scrollRef.current.scrollHeight;
|
||||
}
|
||||
};
|
||||
};
|
||||
|
||||
(["log", "info", "warn", "error"] as LogLevel[]).forEach(patch);
|
||||
|
||||
return () => {
|
||||
(["log", "info", "warn", "error"] as LogLevel[]).forEach((level) => {
|
||||
// eslint-disable-next-line no-console
|
||||
console[level] = originals[level];
|
||||
});
|
||||
};
|
||||
}, []);
|
||||
|
||||
const onPointerDown = useCallback((e: React.PointerEvent<HTMLDivElement>) => {
|
||||
if (!scrollRef.current) {
|
||||
return;
|
||||
}
|
||||
dragState.current = {
|
||||
startY: e.clientY,
|
||||
startScrollTop: scrollRef.current.scrollTop,
|
||||
};
|
||||
scrollRef.current.setPointerCapture(e.pointerId);
|
||||
isDragging.current = true;
|
||||
e.preventDefault();
|
||||
}, []);
|
||||
|
||||
const onPointerMove = useCallback((e: React.PointerEvent<HTMLDivElement>) => {
|
||||
if (!dragState.current || !scrollRef.current) {
|
||||
return;
|
||||
}
|
||||
const delta = dragState.current.startY - e.clientY;
|
||||
scrollRef.current.scrollTop = dragState.current.startScrollTop + delta;
|
||||
e.preventDefault();
|
||||
}, []);
|
||||
|
||||
const onPointerUp = useCallback(() => {
|
||||
dragState.current = null;
|
||||
isDragging.current = false;
|
||||
}, []);
|
||||
|
||||
if (!enabled || logs.length === 0) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return (
|
||||
<div
|
||||
ref={scrollRef}
|
||||
onPointerDown={onPointerDown}
|
||||
onPointerMove={onPointerMove}
|
||||
onPointerUp={onPointerUp}
|
||||
onPointerCancel={onPointerUp}
|
||||
style={{
|
||||
position: "fixed",
|
||||
top: 8,
|
||||
right: 8,
|
||||
zIndex: 9999,
|
||||
maxWidth: 420,
|
||||
maxHeight: "60vh",
|
||||
overflowY: "auto",
|
||||
display: "flex",
|
||||
flexDirection: "column",
|
||||
gap: 2,
|
||||
pointerEvents: "all",
|
||||
cursor: "grab",
|
||||
userSelect: "none",
|
||||
scrollbarWidth: "none",
|
||||
}}
|
||||
>
|
||||
{logs.map((entry) => (
|
||||
<div
|
||||
key={entry.id}
|
||||
style={{
|
||||
background: "rgba(18,18,20,0.55)",
|
||||
backdropFilter: "blur(8px) saturate(1.4)",
|
||||
WebkitBackdropFilter: "blur(8px) saturate(1.4)",
|
||||
borderLeft: `3px solid ${LOG_COLORS[entry.level]}`,
|
||||
borderRadius: 4,
|
||||
padding: "2px 8px",
|
||||
fontFamily: "monospace",
|
||||
fontSize: 11,
|
||||
lineHeight: 1.5,
|
||||
color: LOG_COLORS[entry.level],
|
||||
wordBreak: "break-all",
|
||||
whiteSpace: "pre-wrap",
|
||||
opacity: 0.95,
|
||||
boxShadow: "0 1px 4px rgba(0,0,0,0.35)",
|
||||
}}
|
||||
>
|
||||
<span style={{ opacity: 0.5, marginRight: 6 }}>
|
||||
{entry.level.toUpperCase()}
|
||||
</span>
|
||||
{entry.message}
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
);
|
||||
};
|
||||
|
||||
export default DebugCanvas;
|
||||
|
||||
@@ -26,7 +26,6 @@ import {
|
||||
get,
|
||||
} from "idb-keyval";
|
||||
|
||||
import { appJotaiStore, atom } from "excalidraw-app/app-jotai";
|
||||
import { getNonDeletedElements } from "@excalidraw/element";
|
||||
|
||||
import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library";
|
||||
@@ -39,6 +38,7 @@ import type {
|
||||
} from "@excalidraw/excalidraw/types";
|
||||
import type { MaybePromise } from "@excalidraw/common/utility-types";
|
||||
|
||||
import { appJotaiStore, atom } from "../app-jotai";
|
||||
import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants";
|
||||
|
||||
import { FileManager } from "./FileManager";
|
||||
|
||||
@@ -75,6 +75,13 @@ export default defineConfig(({ mode }) => {
|
||||
find: /^@excalidraw\/utils\/(.*?)/,
|
||||
replacement: path.resolve(__dirname, "../packages/utils/src/$1"),
|
||||
},
|
||||
{
|
||||
find: /^@excalidraw\/fractional-indexing$/,
|
||||
replacement: path.resolve(
|
||||
__dirname,
|
||||
"../packages/fractional-indexing/src/index.ts",
|
||||
),
|
||||
},
|
||||
],
|
||||
},
|
||||
build: {
|
||||
|
||||
+2
-1
@@ -56,7 +56,8 @@
|
||||
"build:element": "yarn --cwd ./packages/element build:esm",
|
||||
"build:excalidraw": "yarn --cwd ./packages/excalidraw build:esm",
|
||||
"build:math": "yarn --cwd ./packages/math build:esm",
|
||||
"build:packages": "yarn build:common && yarn build:math && yarn build:element && yarn build:excalidraw",
|
||||
"build:fractional-indexing": "yarn --cwd ./packages/fractional-indexing build:esm",
|
||||
"build:packages": "yarn build:common && yarn build:fractional-indexing && yarn build:math && yarn build:element && yarn build:excalidraw",
|
||||
"build:version": "yarn --cwd ./excalidraw-app build:version",
|
||||
"build": "yarn --cwd ./excalidraw-app build",
|
||||
"build:preview": "yarn --cwd ./excalidraw-app build:preview",
|
||||
|
||||
@@ -80,7 +80,11 @@ const cssInvert = (
|
||||
return { r: invertedR, g: invertedG, b: invertedB };
|
||||
};
|
||||
|
||||
export const applyDarkModeFilter = (color: string): string => {
|
||||
export const applyDarkModeFilter = (color: string, enable = true): string => {
|
||||
if (!enable) {
|
||||
return color;
|
||||
}
|
||||
|
||||
const cached = DARK_MODE_COLORS_CACHE?.get(color);
|
||||
if (cached) {
|
||||
return cached;
|
||||
|
||||
@@ -337,9 +337,10 @@ export const MAX_DECIMALS_FOR_SVG_EXPORT = 2;
|
||||
export const EXPORT_SCALES = [1, 2, 3];
|
||||
export const DEFAULT_EXPORT_PADDING = 10; // px
|
||||
|
||||
export const DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT = 1440;
|
||||
|
||||
export const MAX_ALLOWED_FILE_BYTES = 4 * 1024 * 1024;
|
||||
export const DEFAULT_IMAGE_OPTIONS: AppProps["imageOptions"] = {
|
||||
maxWidthOrHeight: 1440,
|
||||
maxFileSizeBytes: 4 * 1024 * 1024,
|
||||
};
|
||||
|
||||
export const SVG_NS = "http://www.w3.org/2000/svg";
|
||||
export const SVG_DOCUMENT_PREAMBLE = `<?xml version="1.0" standalone="no"?>
|
||||
|
||||
@@ -64,6 +64,7 @@
|
||||
},
|
||||
"dependencies": {
|
||||
"@excalidraw/common": "0.18.0",
|
||||
"@excalidraw/math": "0.18.0"
|
||||
"@excalidraw/math": "0.18.0",
|
||||
"@excalidraw/fractional-indexing": "3.3.0"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -338,29 +338,20 @@ export class Scene {
|
||||
this.callbacks.clear();
|
||||
}
|
||||
|
||||
insertElementAtIndex(element: ExcalidrawElement, index: number) {
|
||||
if (!Number.isFinite(index) || index < 0) {
|
||||
throw new Error(
|
||||
"insertElementAtIndex can only be called with index >= 0",
|
||||
);
|
||||
}
|
||||
|
||||
const nextElements = [
|
||||
...this.elements.slice(0, index),
|
||||
element,
|
||||
...this.elements.slice(index),
|
||||
];
|
||||
|
||||
syncMovedIndices(nextElements, arrayToMap([element]));
|
||||
|
||||
this.replaceAllElements(nextElements);
|
||||
}
|
||||
|
||||
insertElementsAtIndex(elements: ExcalidrawElement[], index: number) {
|
||||
/** low-level - generally use app.insertNewElements() */
|
||||
insertElementsAtIndex(
|
||||
elements: ExcalidrawElement[],
|
||||
/** null indicates end of the array */
|
||||
index: number | null,
|
||||
) {
|
||||
if (!elements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (index === null) {
|
||||
index = this.elements.length;
|
||||
}
|
||||
|
||||
if (!Number.isFinite(index) || index < 0) {
|
||||
throw new Error(
|
||||
"insertElementAtIndex can only be called with index >= 0",
|
||||
@@ -378,24 +369,9 @@ export class Scene {
|
||||
this.replaceAllElements(nextElements);
|
||||
}
|
||||
|
||||
/** low-level - generally use app.insertNewElement() */
|
||||
insertElement = (element: ExcalidrawElement) => {
|
||||
const index = element.frameId
|
||||
? this.getElementIndex(element.frameId)
|
||||
: this.elements.length;
|
||||
|
||||
this.insertElementAtIndex(element, index);
|
||||
};
|
||||
|
||||
insertElements = (elements: ExcalidrawElement[]) => {
|
||||
if (!elements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
const index = elements[0]?.frameId
|
||||
? this.getElementIndex(elements[0].frameId)
|
||||
: this.elements.length;
|
||||
|
||||
this.insertElementsAtIndex(elements, index);
|
||||
this.insertElementsAtIndex([element], null);
|
||||
};
|
||||
|
||||
getElementIndex(elementId: string) {
|
||||
|
||||
@@ -734,12 +734,11 @@ const getBindingStrategyForDraggingBindingElementEndpoints_simple = (
|
||||
});
|
||||
|
||||
// Handle outside-outside binding to the same element
|
||||
if (otherBinding && otherBinding.elementId === hit?.id) {
|
||||
invariant(
|
||||
!opts?.newArrow || appState.selectedLinearElement?.initialState.origin,
|
||||
"appState.selectedLinearElement.initialState.origin must be defined for new arrows",
|
||||
);
|
||||
|
||||
if (
|
||||
otherBinding &&
|
||||
otherBinding.elementId === hit?.id &&
|
||||
(!opts?.newArrow || appState.selectedLinearElement?.initialState.origin)
|
||||
) {
|
||||
return {
|
||||
start: {
|
||||
mode: "inside",
|
||||
|
||||
@@ -61,6 +61,8 @@ import { distanceToElement } from "./distance";
|
||||
|
||||
import { getBindingGap } from "./binding";
|
||||
|
||||
import { hasBackground } from "./comparisons";
|
||||
|
||||
import type {
|
||||
ElementsMap,
|
||||
ExcalidrawArrowElement,
|
||||
@@ -83,7 +85,7 @@ export const shouldTestInside = (element: ExcalidrawElement) => {
|
||||
}
|
||||
|
||||
const isDraggableFromInside =
|
||||
!isTransparent(element.backgroundColor) ||
|
||||
(hasBackground(element.type) && !isTransparent(element.backgroundColor)) ||
|
||||
hasBoundTextElement(element) ||
|
||||
isIframeLikeElement(element) ||
|
||||
isTextElement(element);
|
||||
@@ -324,7 +326,10 @@ export const getAllHoveredElementAtPoint = (
|
||||
) {
|
||||
candidateElements.push(element);
|
||||
|
||||
if (!isTransparent(element.backgroundColor)) {
|
||||
if (
|
||||
hasBackground(element.type) &&
|
||||
!isTransparent(element.backgroundColor)
|
||||
) {
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -111,6 +111,9 @@ export const duplicateElements = (
|
||||
* user interaction.
|
||||
*/
|
||||
type: "everything";
|
||||
// TODO remove/review this once we add frame children order migration
|
||||
// and invariant checks
|
||||
preserveFrameChildrenOrder?: boolean;
|
||||
}
|
||||
| {
|
||||
/**
|
||||
@@ -170,6 +173,8 @@ export const duplicateElements = (
|
||||
opts.type === "in-place"
|
||||
? opts.idsOfElementsToDuplicate
|
||||
: new Map(elements.map((el) => [el.id, el]));
|
||||
const preserveFrameChildrenOrder =
|
||||
opts.type === "everything" && opts.preserveFrameChildrenOrder;
|
||||
|
||||
// For sanity
|
||||
if (opts.type === "in-place") {
|
||||
@@ -277,7 +282,7 @@ export const duplicateElements = (
|
||||
if (groupId) {
|
||||
const groupElements = getElementsInGroup(elements, groupId).flatMap(
|
||||
(element) =>
|
||||
isFrameLikeElement(element)
|
||||
isFrameLikeElement(element) && !preserveFrameChildrenOrder
|
||||
? [...getFrameChildren(elements, element.id), element]
|
||||
: [element],
|
||||
);
|
||||
@@ -293,13 +298,25 @@ export const duplicateElements = (
|
||||
// frame duplication
|
||||
// -------------------------------------------------------------------------
|
||||
|
||||
if (element.frameId && frameIdsToDuplicate.has(element.frameId)) {
|
||||
if (
|
||||
!preserveFrameChildrenOrder &&
|
||||
element.frameId &&
|
||||
frameIdsToDuplicate.has(element.frameId)
|
||||
) {
|
||||
continue;
|
||||
}
|
||||
|
||||
if (isFrameLikeElement(element)) {
|
||||
const frameId = element.id;
|
||||
|
||||
if (preserveFrameChildrenOrder) {
|
||||
insertBeforeOrAfterIndex(
|
||||
findLastIndex(elementsWithDuplicates, (el) => el.id === frameId),
|
||||
copyElements(element),
|
||||
);
|
||||
continue;
|
||||
}
|
||||
|
||||
const frameChildren = getFrameChildren(elements, frameId);
|
||||
|
||||
const targetIndex = findLastIndex(elementsWithDuplicates, (el) => {
|
||||
|
||||
@@ -1,7 +1,10 @@
|
||||
import { generateNKeysBetween } from "fractional-indexing";
|
||||
|
||||
import { arrayToMap } from "@excalidraw/common";
|
||||
|
||||
import {
|
||||
validateOrderKey,
|
||||
generateNKeysBetween,
|
||||
} from "@excalidraw/fractional-indexing";
|
||||
|
||||
import { mutateElement, newElementWith } from "./mutateElement";
|
||||
import { getBoundTextElement } from "./textElement";
|
||||
import { hasBoundTextElement } from "./typeChecks";
|
||||
@@ -382,6 +385,13 @@ const isValidFractionalIndex = (
|
||||
return false;
|
||||
}
|
||||
|
||||
try {
|
||||
// Format validation
|
||||
validateOrderKey(index);
|
||||
} catch {
|
||||
return false;
|
||||
}
|
||||
|
||||
if (predecessor && successor) {
|
||||
return predecessor < index && index < successor;
|
||||
}
|
||||
|
||||
@@ -23,6 +23,7 @@ import {
|
||||
} from "./bounds";
|
||||
import { mutateElement } from "./mutateElement";
|
||||
import { getBoundTextElement, getContainerElement } from "./textElement";
|
||||
import { syncMovedIndices } from "./fractionalIndex";
|
||||
import {
|
||||
isFrameElement,
|
||||
isFrameLikeElement,
|
||||
@@ -491,10 +492,44 @@ export const filterElementsEligibleAsFrameChildren = (
|
||||
return eligibleElements;
|
||||
};
|
||||
|
||||
export const getCommonFrameId = (elements: readonly ExcalidrawElement[]) => {
|
||||
let commonFrameId: ExcalidrawElement["frameId"] | undefined;
|
||||
|
||||
for (const element of elements) {
|
||||
if (isFrameLikeElement(element) || !element.frameId) {
|
||||
return null;
|
||||
}
|
||||
|
||||
if (commonFrameId === undefined) {
|
||||
commonFrameId = element.frameId;
|
||||
} else if (commonFrameId !== element.frameId) {
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
return commonFrameId ?? null;
|
||||
};
|
||||
|
||||
export const getFrameChildrenInsertionIndex = (
|
||||
elements: readonly ExcalidrawElement[],
|
||||
frameId: ExcalidrawFrameLikeElement["id"],
|
||||
): number | null => {
|
||||
for (let index = elements.length - 1; index >= 0; index--) {
|
||||
const element = elements[index];
|
||||
|
||||
if (element.id === frameId) {
|
||||
return index;
|
||||
} else if (element.frameId === frameId) {
|
||||
return index + 1;
|
||||
}
|
||||
}
|
||||
|
||||
return null;
|
||||
};
|
||||
|
||||
/**
|
||||
* Retains (or repairs for target frame) the ordering invriant where children
|
||||
* elements come right before the parent frame:
|
||||
* [el, el, child, child, frame, el]
|
||||
* Adds elements and their bound elements to frame. Reorders added elements to
|
||||
* be just below frame, or just above its highest child (whichever is higher).
|
||||
*
|
||||
* @returns mutated allElements (same data structure)
|
||||
*/
|
||||
@@ -502,19 +537,11 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
||||
allElements: T,
|
||||
elementsToAdd: NonDeletedExcalidrawElement[],
|
||||
frame: ExcalidrawFrameLikeElement,
|
||||
appState: AppState,
|
||||
): T => {
|
||||
const elementsMap = arrayToMap(allElements);
|
||||
const currTargetFrameChildrenMap = new Map<ExcalidrawElement["id"], true>();
|
||||
for (const element of allElements.values()) {
|
||||
if (element.frameId === frame.id) {
|
||||
currTargetFrameChildrenMap.set(element.id, true);
|
||||
}
|
||||
}
|
||||
const commonFrameId = getCommonFrameId(elementsToAdd);
|
||||
|
||||
const suppliedElementsToAddSet = new Set(elementsToAdd.map((el) => el.id));
|
||||
|
||||
const finalElementsToAdd: ExcalidrawElement[] = [];
|
||||
const finalElementsToAdd = new Set<ExcalidrawElement>();
|
||||
|
||||
const otherFrames = new Set<ExcalidrawFrameLikeElement["id"]>();
|
||||
|
||||
@@ -525,7 +552,8 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
||||
}
|
||||
|
||||
// - add bound text elements if not already in the array
|
||||
// - filter out elements that are already in the frame
|
||||
// - keep elements already in the frame so mixed selections can be reordered
|
||||
// together
|
||||
for (const element of omitGroupsContainingFrameLikes(
|
||||
allElements,
|
||||
elementsToAdd,
|
||||
@@ -538,38 +566,68 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
||||
continue;
|
||||
}
|
||||
|
||||
// if the element is already in another frame (which is also in elementsToAdd),
|
||||
// it means that frame and children are selected at the same time
|
||||
// => keep original frame membership, do not add to the target frame
|
||||
if (
|
||||
element.frameId &&
|
||||
appState.selectedElementIds[element.id] &&
|
||||
appState.selectedElementIds[element.frameId]
|
||||
) {
|
||||
if (element.frameId && element.frameId !== frame.id) {
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!currTargetFrameChildrenMap.has(element.id)) {
|
||||
finalElementsToAdd.push(element);
|
||||
}
|
||||
finalElementsToAdd.add(element);
|
||||
|
||||
const boundTextElement = getBoundTextElement(element, elementsMap);
|
||||
if (
|
||||
boundTextElement &&
|
||||
!suppliedElementsToAddSet.has(boundTextElement.id) &&
|
||||
!currTargetFrameChildrenMap.has(boundTextElement.id)
|
||||
) {
|
||||
finalElementsToAdd.push(boundTextElement);
|
||||
if (boundTextElement && !finalElementsToAdd.has(boundTextElement)) {
|
||||
finalElementsToAdd.add(boundTextElement);
|
||||
}
|
||||
}
|
||||
|
||||
for (const element of finalElementsToAdd) {
|
||||
mutateElement(element, elementsMap, {
|
||||
frameId: frame.id,
|
||||
});
|
||||
// we don't always need to update the element if it's already in the frame,
|
||||
// but we still need to accumulate in finalElementsToAdd so we potentially
|
||||
// reorder them if added together
|
||||
if (element.frameId !== frame.id) {
|
||||
mutateElement(element, elementsMap, {
|
||||
frameId: frame.id,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
return allElements;
|
||||
// (re)order elements to be just below the frame,
|
||||
// or just above the highest child if that is higher
|
||||
// (latter case is denormalized order until we migrate)
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
if (
|
||||
!finalElementsToAdd.size ||
|
||||
// if all elements to add already belong to the frame, then we don't want to
|
||||
// reorder (case: we're dragging element children within the frame)
|
||||
commonFrameId === frame.id
|
||||
) {
|
||||
return allElements;
|
||||
}
|
||||
|
||||
const otherElements = Array.from(allElements.values()).filter(
|
||||
(element) => !finalElementsToAdd.has(element),
|
||||
);
|
||||
const insertionIndex = getFrameChildrenInsertionIndex(
|
||||
otherElements,
|
||||
frame.id,
|
||||
);
|
||||
|
||||
if (insertionIndex === null) {
|
||||
return allElements;
|
||||
}
|
||||
|
||||
const reorderedElements = [
|
||||
...otherElements.slice(0, insertionIndex),
|
||||
...finalElementsToAdd,
|
||||
...otherElements.slice(insertionIndex),
|
||||
];
|
||||
|
||||
syncMovedIndices(reorderedElements, arrayToMap([...finalElementsToAdd]));
|
||||
|
||||
return (
|
||||
Array.isArray(allElements)
|
||||
? reorderedElements
|
||||
: new Map(reorderedElements.map((element) => [element.id, element]))
|
||||
) as T;
|
||||
};
|
||||
|
||||
export const removeElementsFromFrame = (
|
||||
@@ -623,13 +681,11 @@ export const replaceAllElementsInFrame = <T extends ExcalidrawElement>(
|
||||
allElements: readonly T[],
|
||||
nextElementsInFrame: ExcalidrawElement[],
|
||||
frame: ExcalidrawFrameLikeElement,
|
||||
app: AppClassProperties,
|
||||
): T[] => {
|
||||
return addElementsToFrame(
|
||||
removeAllElementsFromFrame(allElements, frame),
|
||||
nextElementsInFrame,
|
||||
frame,
|
||||
app.state,
|
||||
).slice();
|
||||
};
|
||||
|
||||
|
||||
@@ -81,6 +81,7 @@ export * from "./mutateElement";
|
||||
export * from "./newElement";
|
||||
export * from "./positionElementsOnGrid";
|
||||
export * from "./renderElement";
|
||||
export { invalidateFreeDrawIncrementalCanvas } from "./renderFreedraw";
|
||||
export * from "./resizeElements";
|
||||
export * from "./resizeTest";
|
||||
export * from "./Scene";
|
||||
|
||||
@@ -486,7 +486,7 @@ export class LinearElementEditor {
|
||||
selectedPointsIndices,
|
||||
)}) points(0..${
|
||||
element.points.length - 1
|
||||
}) lastClickedPoint(${lastClickedPoint})`,
|
||||
}) lastClickedPoint(${lastClickedPoint}) isElbowArrow: ${elbowed}`,
|
||||
);
|
||||
|
||||
// Fall back to the actual last point as a last resort.
|
||||
@@ -2139,13 +2139,13 @@ const pointDraggingUpdates = (
|
||||
} => {
|
||||
const naiveDraggingPoints = new Map(
|
||||
selectedPointsIndices.map((pointIndex) => {
|
||||
// NOTE: Avoid stale point index issue potentially caused by elbow
|
||||
// arrows unpredictably changing the number of points during dragging
|
||||
const point = element.points[pointIndex] ?? element.points.at(-1);
|
||||
return [
|
||||
pointIndex,
|
||||
{
|
||||
point: pointFrom<LocalPoint>(
|
||||
element.points[pointIndex][0] + deltaX,
|
||||
element.points[pointIndex][1] + deltaY,
|
||||
),
|
||||
point: pointFrom<LocalPoint>(point[0] + deltaX, point[1] + deltaY),
|
||||
isDragging: true,
|
||||
},
|
||||
];
|
||||
|
||||
@@ -65,8 +65,12 @@ import {
|
||||
} from "./typeChecks";
|
||||
import { getContainingFrame } from "./frame";
|
||||
import { getCornerRadius } from "./utils";
|
||||
|
||||
import { ShapeCache } from "./shape";
|
||||
import {
|
||||
drawFreeDrawSegments,
|
||||
generateOrUpdateFreeDrawIncrementalCanvas,
|
||||
getFreedrawCanvasPadding,
|
||||
} from "./renderFreedraw";
|
||||
|
||||
import type {
|
||||
ExcalidrawElement,
|
||||
@@ -92,7 +96,7 @@ const isPendingImageElement = (
|
||||
const getCanvasPadding = (element: ExcalidrawElement) => {
|
||||
switch (element.type) {
|
||||
case "freedraw":
|
||||
return element.strokeWidth * 12;
|
||||
return getFreedrawCanvasPadding(element);
|
||||
case "text":
|
||||
return element.fontSize / 2;
|
||||
case "arrow":
|
||||
@@ -144,6 +148,15 @@ export interface ExcalidrawElementWithCanvas {
|
||||
imageCrop: ExcalidrawImageElement["crop"] | null;
|
||||
containingFrameOpacity: number;
|
||||
boundTextCanvas: HTMLCanvasElement;
|
||||
canvasOriginSceneX?: number;
|
||||
canvasOriginSceneY?: number;
|
||||
/**
|
||||
* Tip canvas for incremental freedraw rendering. Contains only the last
|
||||
* unfinalised segment (whose Catmull-Rom right-hand tangent changes with
|
||||
* each new point) and is cleared + redrawn every frame. Composited on top
|
||||
* of `canvas` (the committed accumulation canvas) in drawElementFromCanvas.
|
||||
*/
|
||||
tipCanvas?: HTMLCanvasElement;
|
||||
}
|
||||
|
||||
const cappedElementCanvasSize = (
|
||||
@@ -253,7 +266,7 @@ const generateElementCanvas = (
|
||||
|
||||
const rc = rough.canvas(canvas);
|
||||
|
||||
drawElementOnCanvas(element, rc, context, renderConfig);
|
||||
drawElementOnCanvas(element, rc, context, renderConfig, scale);
|
||||
|
||||
context.restore();
|
||||
|
||||
@@ -389,6 +402,7 @@ const drawElementOnCanvas = (
|
||||
rc: RoughCanvas,
|
||||
context: CanvasRenderingContext2D,
|
||||
renderConfig: StaticCanvasRenderConfig,
|
||||
scale = 1,
|
||||
) => {
|
||||
switch (element.type) {
|
||||
case "rectangle":
|
||||
@@ -415,23 +429,8 @@ const drawElementOnCanvas = (
|
||||
break;
|
||||
}
|
||||
case "freedraw": {
|
||||
// Draw directly to canvas
|
||||
context.save();
|
||||
|
||||
const shapes = ShapeCache.generateElementShape(element, renderConfig);
|
||||
|
||||
for (const shape of shapes) {
|
||||
if (typeof shape === "string") {
|
||||
context.fillStyle =
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor;
|
||||
context.fill(new Path2D(shape));
|
||||
} else {
|
||||
rc.draw(shape);
|
||||
}
|
||||
}
|
||||
|
||||
drawFreeDrawSegments(element, context, renderConfig, 0, undefined, scale);
|
||||
context.restore();
|
||||
break;
|
||||
}
|
||||
@@ -555,10 +554,10 @@ const drawElementOnCanvas = (
|
||||
context.canvas.setAttribute("dir", rtl ? "rtl" : "ltr");
|
||||
context.save();
|
||||
context.font = getFontString(element);
|
||||
context.fillStyle =
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor;
|
||||
context.fillStyle = applyDarkModeFilter(
|
||||
element.strokeColor,
|
||||
renderConfig.theme === THEME.DARK,
|
||||
);
|
||||
context.textAlign = element.textAlign as CanvasTextAlign;
|
||||
|
||||
// Canvas does not support multiline text by default
|
||||
@@ -616,6 +615,24 @@ const generateElementWithCanvas = (
|
||||
: {
|
||||
value: 1 as NormalizedZoomValue,
|
||||
};
|
||||
|
||||
// Incremental rendering path for freedraw elements being actively drawn.
|
||||
// ShapeCache.delete() clears elementWithCanvasCache on every added point, so
|
||||
// we bypass that cache entirely and use freedrawIncrementalCache instead.
|
||||
if (
|
||||
isFreeDrawElement(element) &&
|
||||
"newElement" in appState &&
|
||||
appState.newElement?.id === element.id
|
||||
) {
|
||||
return generateOrUpdateFreeDrawIncrementalCanvas(
|
||||
element as ExcalidrawFreeDrawElement,
|
||||
elementsMap,
|
||||
zoom,
|
||||
renderConfig,
|
||||
appState,
|
||||
);
|
||||
}
|
||||
|
||||
const prevElementWithCanvas = elementWithCanvasCache.get(element);
|
||||
const shouldRegenerateBecauseZoom =
|
||||
prevElementWithCanvas &&
|
||||
@@ -718,16 +735,39 @@ const drawElementFromCanvas = (
|
||||
// revert afterwards we don't have account for it during drawing
|
||||
context.translate(-cx, -cy);
|
||||
|
||||
// For the incremental freedraw path, the canvas origin is stored explicitly
|
||||
// because the canvas is over-allocated beyond the tight element bounds.
|
||||
const destX =
|
||||
elementWithCanvas.canvasOriginSceneX !== undefined
|
||||
? (elementWithCanvas.canvasOriginSceneX + appState.scrollX) *
|
||||
window.devicePixelRatio
|
||||
: (x1 + appState.scrollX) * window.devicePixelRatio - padding;
|
||||
const destY =
|
||||
elementWithCanvas.canvasOriginSceneY !== undefined
|
||||
? (elementWithCanvas.canvasOriginSceneY + appState.scrollY) *
|
||||
window.devicePixelRatio
|
||||
: (y1 + appState.scrollY) * window.devicePixelRatio - padding;
|
||||
context.drawImage(
|
||||
elementWithCanvas.canvas!,
|
||||
(x1 + appState.scrollX) * window.devicePixelRatio -
|
||||
(padding * elementWithCanvas.scale) / elementWithCanvas.scale,
|
||||
(y1 + appState.scrollY) * window.devicePixelRatio -
|
||||
(padding * elementWithCanvas.scale) / elementWithCanvas.scale,
|
||||
destX,
|
||||
destY,
|
||||
elementWithCanvas.canvas!.width / elementWithCanvas.scale,
|
||||
elementWithCanvas.canvas!.height / elementWithCanvas.scale,
|
||||
);
|
||||
|
||||
// Composite the tip canvas (incremental freedraw path) on top. It is
|
||||
// the same size and at the same scene origin as the committed canvas, so
|
||||
// it uses identical destX / destY / dimensions.
|
||||
if (elementWithCanvas.tipCanvas) {
|
||||
context.drawImage(
|
||||
elementWithCanvas.tipCanvas,
|
||||
destX,
|
||||
destY,
|
||||
elementWithCanvas.tipCanvas.width / elementWithCanvas.scale,
|
||||
elementWithCanvas.tipCanvas.height / elementWithCanvas.scale,
|
||||
);
|
||||
}
|
||||
|
||||
if (
|
||||
import.meta.env.VITE_APP_DEBUG_ENABLE_TEXT_CONTAINER_BOUNDING_BOX ===
|
||||
"true" &&
|
||||
@@ -811,10 +851,10 @@ export const renderElement = (
|
||||
context.fillStyle = "rgba(0, 0, 200, 0.04)";
|
||||
|
||||
context.lineWidth = FRAME_STYLE.strokeWidth / appState.zoom.value;
|
||||
context.strokeStyle =
|
||||
appState.theme === THEME.DARK
|
||||
? applyDarkModeFilter(FRAME_STYLE.strokeColor)
|
||||
: FRAME_STYLE.strokeColor;
|
||||
context.strokeStyle = applyDarkModeFilter(
|
||||
FRAME_STYLE.strokeColor,
|
||||
appState.theme === THEME.DARK,
|
||||
);
|
||||
|
||||
// TODO change later to only affect AI frames
|
||||
if (isMagicFrameElement(element)) {
|
||||
@@ -867,6 +907,14 @@ export const renderElement = (
|
||||
return;
|
||||
}
|
||||
|
||||
const currentImageSmoothingStatus = context.imageSmoothingEnabled;
|
||||
if (
|
||||
!appState?.shouldCacheIgnoreZoom &&
|
||||
(!element.angle || isRightAngleRads(element.angle))
|
||||
) {
|
||||
context.imageSmoothingEnabled = false;
|
||||
}
|
||||
|
||||
drawElementFromCanvas(
|
||||
elementWithCanvas,
|
||||
context,
|
||||
@@ -874,6 +922,8 @@ export const renderElement = (
|
||||
appState,
|
||||
allElementsMap,
|
||||
);
|
||||
|
||||
context.imageSmoothingEnabled = currentImageSmoothingStatus;
|
||||
}
|
||||
|
||||
break;
|
||||
@@ -983,7 +1033,7 @@ export const renderElement = (
|
||||
}
|
||||
|
||||
context.restore();
|
||||
// not exporting → optimized rendering (cache & render from element
|
||||
// not exporting -> optimized rendering (cache & render from element
|
||||
// canvases)
|
||||
} else {
|
||||
const elementWithCanvas = generateElementWithCanvas(
|
||||
|
||||
@@ -0,0 +1,549 @@
|
||||
import { applyDarkModeFilter, THEME } from "@excalidraw/common";
|
||||
|
||||
import type { StaticCanvasRenderConfig } from "@excalidraw/excalidraw/scene/types";
|
||||
|
||||
import type {
|
||||
AppState,
|
||||
InteractiveCanvasAppState,
|
||||
StaticCanvasAppState,
|
||||
Zoom,
|
||||
} from "@excalidraw/excalidraw/types";
|
||||
|
||||
import { getElementAbsoluteCoords } from "./bounds";
|
||||
import { getContainingFrame } from "./frame";
|
||||
|
||||
import type { ExcalidrawElementWithCanvas } from "./renderElement";
|
||||
import type {
|
||||
ExcalidrawFreeDrawElement,
|
||||
NonDeletedSceneElementsMap,
|
||||
} from "./types";
|
||||
|
||||
const DEFAULT_FREEDRAW_PRESSURE = 0.5;
|
||||
|
||||
/**
|
||||
* Half-width (in samples) of the triangular smoothing kernel applied to raw
|
||||
* pressure values before computing stroke radii. A radius of R means each
|
||||
* pressure sample is averaged with R neighbours on each side, weighted
|
||||
* linearly so the centre sample has weight R+1 and the outermost weight 1.
|
||||
* Larger values produce a smoother, more uniform stroke width.
|
||||
*/
|
||||
const PRESSURE_SMOOTHING_RADIUS = 6;
|
||||
|
||||
/**
|
||||
* Draws a single stroke segment primitive for the triplet (pPrev, pCur, pNext).
|
||||
*
|
||||
* The primitive is a closed quadrilateral with curved top and bottom edges:
|
||||
* A = midpoint(pPrev, pCur) — left junction, shared with the previous primitive
|
||||
* B = midpoint(pCur, pNext) — right junction, shared with the next primitive
|
||||
* M'1/M'2 at A: ±rA perpendicular to the pPrev→pCur direction
|
||||
* M1/M2 at pCur: ±rCur along the bisector normal of the two edge directions
|
||||
* M''1/M''2 at B: ±rB perpendicular to the pCur→pNext direction
|
||||
*
|
||||
* Shape boundary (clockwise):
|
||||
* M'1 →[quadratic Bezier through M1]→ M''1 →[line]→ M''2
|
||||
* →[quadratic Bezier through M2]→ M'2 →[line]→ M'1
|
||||
*
|
||||
* Adjacent primitives share their junction points so the stroke outline is
|
||||
* geometrically continuous with no gaps or overlaps.
|
||||
*/
|
||||
const drawStrokeSegment = (
|
||||
context: CanvasRenderingContext2D,
|
||||
pPrevX: number,
|
||||
pPrevY: number,
|
||||
rPrev: number,
|
||||
pCurX: number,
|
||||
pCurY: number,
|
||||
rCur: number,
|
||||
pNextX: number,
|
||||
pNextY: number,
|
||||
rNext: number,
|
||||
) => {
|
||||
// A = midpoint(pPrev, pCur), B = midpoint(pCur, pNext)
|
||||
const ax = (pPrevX + pCurX) * 0.5;
|
||||
const ay = (pPrevY + pCurY) * 0.5;
|
||||
const rA = (rPrev + rCur) * 0.5;
|
||||
const bx = (pCurX + pNextX) * 0.5;
|
||||
const by = (pCurY + pNextY) * 0.5;
|
||||
const rB = (rCur + rNext) * 0.5;
|
||||
|
||||
// Perpendicular unit vector at A (normal to pPrev→pCur)
|
||||
const daX = pCurX - pPrevX;
|
||||
const daY = pCurY - pPrevY;
|
||||
const daLenInv = 1 / (Math.sqrt(daX * daX + daY * daY) || 1e-10);
|
||||
const nAX = -daY * daLenInv;
|
||||
const nAY = daX * daLenInv;
|
||||
|
||||
// Perpendicular unit vector at B (normal to pCur→pNext)
|
||||
const dbX = pNextX - pCurX;
|
||||
const dbY = pNextY - pCurY;
|
||||
const dbLenInv = 1 / (Math.sqrt(dbX * dbX + dbY * dbY) || 1e-10);
|
||||
const nBX = -dbY * dbLenInv;
|
||||
const nBY = dbX * dbLenInv;
|
||||
|
||||
// Bisector normal at pCur: normalised average of nA and nB
|
||||
const bisRawX = nAX + nBX;
|
||||
const bisRawY = nAY + nBY;
|
||||
const bisLen = Math.sqrt(bisRawX * bisRawX + bisRawY * bisRawY);
|
||||
const bisNX = bisLen > 1e-10 ? bisRawX / bisLen : nAX;
|
||||
const bisNY = bisLen > 1e-10 ? bisRawY / bisLen : nAY;
|
||||
|
||||
// M'1, M'2 at A
|
||||
const mp1x = ax + nAX * rA;
|
||||
const mp1y = ay + nAY * rA;
|
||||
const mp2x = ax - nAX * rA;
|
||||
const mp2y = ay - nAY * rA;
|
||||
|
||||
// M1, M2 at pCur — used directly as the quadratic Bézier control points.
|
||||
// The junction points (M'1, M''1, etc.) are midpoints between consecutive
|
||||
// control points, which is the classic midpoint quadratic B-spline scheme.
|
||||
// This guarantees C1 continuity: the shared junction is always the midpoint
|
||||
// of the two flanking CPs, so the tangent is continuous across segments.
|
||||
const m1x = pCurX + bisNX * rCur;
|
||||
const m1y = pCurY + bisNY * rCur;
|
||||
const m2x = pCurX - bisNX * rCur;
|
||||
const m2y = pCurY - bisNY * rCur;
|
||||
|
||||
// M''1, M''2 at B
|
||||
const mpp1x = bx + nBX * rB;
|
||||
const mpp1y = by + nBY * rB;
|
||||
const mpp2x = bx - nBX * rB;
|
||||
const mpp2y = by - nBY * rB;
|
||||
|
||||
context.beginPath();
|
||||
context.moveTo(mp1x, mp1y);
|
||||
// Top edge: M'1 → M''1, control point = M1 (bisector offset at pCur)
|
||||
context.quadraticCurveTo(m1x, m1y, mpp1x, mpp1y);
|
||||
// Right cap: M''1 → M''2
|
||||
context.lineTo(mpp2x, mpp2y);
|
||||
// Bottom edge: M''2 → M'2, control point = M2
|
||||
context.quadraticCurveTo(m2x, m2y, mp2x, mp2y);
|
||||
// Left cap: M'2 → M'1
|
||||
context.closePath();
|
||||
context.fill();
|
||||
|
||||
// Filled circles at the junction midpoints seal any sub-pixel anti-aliasing
|
||||
// gap where adjacent segment fills share a boundary edge.
|
||||
context.beginPath();
|
||||
context.arc(ax, ay, rA, 0, Math.PI * 2);
|
||||
context.fill();
|
||||
context.beginPath();
|
||||
context.arc(bx, by, rB, 0, Math.PI * 2);
|
||||
context.fill();
|
||||
};
|
||||
|
||||
/**
|
||||
* Draws freedraw points as pressure-aware curved stroke segment primitives.
|
||||
* For each consecutive triplet of points (i-1, i, i+1) a curved quadrilateral
|
||||
* is drawn whose side edges sit at the midpoints of the consecutive point pairs
|
||||
* and whose top/bottom edges are quadratic Bezier curves passing through the
|
||||
* stroke-width offset at the centre point. Adjacent primitives share their
|
||||
* side-edge positions, so the rendered outline is continuous with no gaps.
|
||||
*
|
||||
* @param fromIndex Draw segments starting from this point index (inclusive).
|
||||
* Pass 0 to draw from the beginning.
|
||||
* @param upToIndex Draw segments only up to (but not including) this point
|
||||
* index. Omit or pass `undefined` to draw all remaining
|
||||
* points. Used by the incremental canvas to stop short of
|
||||
* the last segment so the committed canvas only contains
|
||||
* segments whose geometry is fully determined by immutable
|
||||
* points.
|
||||
*/
|
||||
export const drawFreeDrawSegments = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
context: CanvasRenderingContext2D,
|
||||
renderConfig: StaticCanvasRenderConfig,
|
||||
fromIndex: number,
|
||||
upToIndex?: number,
|
||||
scale = 1,
|
||||
) => {
|
||||
const { points, pressures } = element;
|
||||
const N = points.length;
|
||||
const strokeColor =
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor;
|
||||
|
||||
context.fillStyle = applyDarkModeFilter(
|
||||
strokeColor,
|
||||
renderConfig.theme === THEME.DARK,
|
||||
);
|
||||
|
||||
const baseRadius = (element.strokeWidth * 1.25) / 2;
|
||||
|
||||
// Causal (one-sided) triangular-kernel weighted average of past pressure
|
||||
// samples. Only looks backward [i-R .. i], so a newly-arrived point never
|
||||
// retroactively changes the smoothed pressure of any previously rendered
|
||||
// segment. This ensures live and final renders are identical at all points.
|
||||
// When simulatePressure is true, constant pressure is used for all points.
|
||||
const getSmoothedPressure = (i: number): number => {
|
||||
if (element.simulatePressure || pressures.length === 0) {
|
||||
return DEFAULT_FREEDRAW_PRESSURE;
|
||||
}
|
||||
let sum = 0;
|
||||
let totalWeight = 0;
|
||||
for (let k = -PRESSURE_SMOOTHING_RADIUS; k <= 0; k++) {
|
||||
const idx = i + k;
|
||||
if (idx < 0) {
|
||||
continue;
|
||||
}
|
||||
const p =
|
||||
idx < pressures.length ? pressures[idx] : DEFAULT_FREEDRAW_PRESSURE;
|
||||
const w = PRESSURE_SMOOTHING_RADIUS + 1 + k; // 1 at i-R, R+1 at i
|
||||
sum += p * w;
|
||||
totalWeight += w;
|
||||
}
|
||||
return totalWeight > 0 ? sum / totalWeight : DEFAULT_FREEDRAW_PRESSURE;
|
||||
};
|
||||
|
||||
if (
|
||||
fromIndex === 0 &&
|
||||
N === 1 &&
|
||||
(upToIndex === undefined || upToIndex >= 1)
|
||||
) {
|
||||
// Single-point stroke -> filled circle (dot)
|
||||
const r = baseRadius * getSmoothedPressure(0) * 2;
|
||||
context.beginPath();
|
||||
context.arc(points[0][0], points[0][1], r, 0, Math.PI * 2);
|
||||
context.fill();
|
||||
|
||||
return;
|
||||
}
|
||||
|
||||
const end = upToIndex !== undefined ? Math.min(upToIndex, N) : N;
|
||||
const start = Math.max(fromIndex, 1);
|
||||
for (let i = start; i < end; i++) {
|
||||
const p0 = points[i - 1];
|
||||
const p1 = points[i];
|
||||
const r0 = baseRadius * getSmoothedPressure(i - 1) * 2;
|
||||
const r1 = baseRadius * getSmoothedPressure(i) * 2;
|
||||
|
||||
// Triplet: need i+1; if at the last point, mirror i-1 around i (degenerate tip).
|
||||
let p2x: number;
|
||||
let p2y: number;
|
||||
let r2: number;
|
||||
if (i < N - 1) {
|
||||
p2x = points[i + 1][0];
|
||||
p2y = points[i + 1][1];
|
||||
r2 = baseRadius * getSmoothedPressure(i + 1) * 2;
|
||||
} else {
|
||||
p2x = 2 * p1[0] - p0[0];
|
||||
p2y = 2 * p1[1] - p0[1];
|
||||
r2 = r0;
|
||||
}
|
||||
|
||||
drawStrokeSegment(
|
||||
context,
|
||||
p0[0],
|
||||
p0[1],
|
||||
r0,
|
||||
p1[0],
|
||||
p1[1],
|
||||
r1,
|
||||
p2x,
|
||||
p2y,
|
||||
r2,
|
||||
);
|
||||
}
|
||||
};
|
||||
|
||||
// ─── Incremental freedraw canvas cache ───────────────────────────────────────
|
||||
// A separate WeakMap that survives ShapeCache.delete() calls so that the raster
|
||||
// accumulates new capsule segments without full regeneration on every added
|
||||
// point.
|
||||
|
||||
// screen pixels - minimum extra lookahead space on each side
|
||||
// (divided by scale at use)
|
||||
const FREEDRAW_CANVAS_OVERSHOOT_MIN = 200;
|
||||
|
||||
// allocate current_dimension * factor extra on each side
|
||||
const FREEDRAW_CANVAS_OVERSHOOT_FACTOR = 0.5;
|
||||
|
||||
interface FreeDrawIncrementalCanvas {
|
||||
/**
|
||||
* Accumulation canvas - contains all segments whose Catmull-Rom tangents are
|
||||
* fully finalised (right-hand neighbour is known). With N points the last
|
||||
* finalised segment ends at index `committedPointCount - 1`, meaning segment
|
||||
* `[committedPointCount-2 -> committedPointCount-1]` has been drawn with the
|
||||
* correct tangent at `committedPointCount-1` (since point
|
||||
* `committedPointCount` existed when it was drawn). Never cleared; only
|
||||
* appended to (or copied when bounds grow).
|
||||
*/
|
||||
committedCanvas: HTMLCanvasElement;
|
||||
/**
|
||||
* Tip canvas - same pixel dimensions and scene origin as `committedCanvas`.
|
||||
* Cleared and redrawn every frame to contain only the last segment
|
||||
* `[committedPointCount-1 -> N-1]` whose tangent at `N-1` is still
|
||||
* provisional (no right-hand neighbour yet). Composited on top of
|
||||
* `committedCanvas` at display time.
|
||||
*/
|
||||
tipCanvas: HTMLCanvasElement;
|
||||
/**
|
||||
* Number of points that have been permanently drawn on `committedCanvas`.
|
||||
* The committed canvas contains segments through point index
|
||||
* `committedPointCount - 1` with final tangents. Always lags the current
|
||||
* point count by 1 (the tip holds the last unfinalisable segment).
|
||||
*/
|
||||
committedPointCount: number;
|
||||
canvasOriginSceneX: number;
|
||||
canvasOriginSceneY: number;
|
||||
canvasAllocX1: number;
|
||||
canvasAllocY1: number;
|
||||
canvasAllocX2: number;
|
||||
canvasAllocY2: number;
|
||||
scale: number;
|
||||
theme: AppState["theme"];
|
||||
}
|
||||
|
||||
const freedrawIncrementalCache = new WeakMap<
|
||||
ExcalidrawFreeDrawElement,
|
||||
FreeDrawIncrementalCanvas
|
||||
>();
|
||||
|
||||
export const getFreedrawCanvasPadding = (element: ExcalidrawFreeDrawElement) =>
|
||||
element.strokeWidth * 12;
|
||||
|
||||
/**
|
||||
* Generates or incrementally updates the two-canvas (committed + tip) raster
|
||||
* for a freedraw element being actively drawn.
|
||||
*
|
||||
* ## Two-canvas split
|
||||
*
|
||||
* A Catmull-Rom tangent at point `i` depends on `points[i+1]`. Until
|
||||
* `points[i+1]` arrives, the tangent at `i` uses a mirrored fallback and is
|
||||
* therefore provisional. The segment ending at the current tip `[N-2 -> N-1]`
|
||||
* is the only one with a provisional tangent.
|
||||
*
|
||||
* - **`committedCanvas`** - contains all segments whose tangents are final.
|
||||
* With N points: segments `[0->1, ..., N-3->N-2]` (`committedPointCount =
|
||||
* N-1`). This canvas is append-only; its pixels are never invalidated.
|
||||
* When a new point `N` arrives, the segment `[N-2 -> N-1]` is now
|
||||
* finalised (tangent at `N-1` uses `N` as the right-hand neighbour) and is
|
||||
* drawn onto the committed canvas. `committedPointCount` advances to `N`.
|
||||
*
|
||||
* - **`tipCanvas`** - cleared and redrawn every frame to contain only the
|
||||
* last provisional segment `[committedPointCount-1 -> N-1]`. Composited on
|
||||
* top of `committedCanvas` at display time.
|
||||
*/
|
||||
export const generateOrUpdateFreeDrawIncrementalCanvas = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
elementsMap: NonDeletedSceneElementsMap,
|
||||
zoom: Zoom,
|
||||
renderConfig: StaticCanvasRenderConfig,
|
||||
appState: StaticCanvasAppState | InteractiveCanvasAppState,
|
||||
): ExcalidrawElementWithCanvas | null => {
|
||||
const scale = zoom.value;
|
||||
const dpr = window.devicePixelRatio;
|
||||
const padding = getFreedrawCanvasPadding(element);
|
||||
const [x1, y1, x2, y2] = getElementAbsoluteCoords(element, elementsMap);
|
||||
const containingFrameOpacity =
|
||||
getContainingFrame(element, elementsMap)?.opacity || 100;
|
||||
const N = element.points.length;
|
||||
|
||||
const prevInc = freedrawIncrementalCache.get(element);
|
||||
|
||||
const boundsExceeded =
|
||||
prevInc !== undefined &&
|
||||
(x1 < prevInc.canvasAllocX1 ||
|
||||
y1 < prevInc.canvasAllocY1 ||
|
||||
x2 > prevInc.canvasAllocX2 ||
|
||||
y2 > prevInc.canvasAllocY2);
|
||||
|
||||
const needsAlloc =
|
||||
prevInc === undefined ||
|
||||
boundsExceeded ||
|
||||
prevInc.scale !== scale ||
|
||||
prevInc.theme !== appState.theme;
|
||||
|
||||
// ── Canvas allocation / reallocation ──────────────────────────────────────
|
||||
let committedCanvas: HTMLCanvasElement;
|
||||
let tipCanvas: HTMLCanvasElement;
|
||||
let canvasOriginSceneX: number;
|
||||
let canvasOriginSceneY: number;
|
||||
let canvasScale: number;
|
||||
// How many points to start the committed-canvas update from. On a full
|
||||
// regen this is 0; on a bounds-exceeded realloc it is the existing committed
|
||||
// count so we only append the new segments.
|
||||
let committedFromIndex: number;
|
||||
|
||||
if (needsAlloc) {
|
||||
// Over-allocate proportionally to the current bounding box so fast large
|
||||
// strokes trigger far fewer reallocations.
|
||||
const overshootX = Math.max(
|
||||
FREEDRAW_CANVAS_OVERSHOOT_MIN / scale,
|
||||
(x2 - x1) * FREEDRAW_CANVAS_OVERSHOOT_FACTOR,
|
||||
);
|
||||
const overshootY = Math.max(
|
||||
FREEDRAW_CANVAS_OVERSHOOT_MIN / scale,
|
||||
(y2 - y1) * FREEDRAW_CANVAS_OVERSHOOT_FACTOR,
|
||||
);
|
||||
const allocX1 = x1 - overshootX;
|
||||
const allocY1 = y1 - overshootY;
|
||||
const allocX2 = x2 + overshootX;
|
||||
const allocY2 = y2 + overshootY;
|
||||
|
||||
canvasOriginSceneX = allocX1 - padding / dpr;
|
||||
canvasOriginSceneY = allocY1 - padding / dpr;
|
||||
|
||||
const rawW = (allocX2 - allocX1) * dpr + padding * 2;
|
||||
const rawH = (allocY2 - allocY1) * dpr + padding * 2;
|
||||
|
||||
// Respect browser canvas size limits.
|
||||
const AREA_LIMIT = 16777216;
|
||||
const WIDTH_HEIGHT_LIMIT = 32767;
|
||||
canvasScale = scale;
|
||||
if (
|
||||
rawW * canvasScale > WIDTH_HEIGHT_LIMIT ||
|
||||
rawH * canvasScale > WIDTH_HEIGHT_LIMIT
|
||||
) {
|
||||
canvasScale = Math.min(
|
||||
WIDTH_HEIGHT_LIMIT / rawW,
|
||||
WIDTH_HEIGHT_LIMIT / rawH,
|
||||
);
|
||||
}
|
||||
if (rawW * rawH * canvasScale * canvasScale > AREA_LIMIT) {
|
||||
canvasScale = Math.sqrt(AREA_LIMIT / (rawW * rawH));
|
||||
}
|
||||
|
||||
const canvasWidth = Math.floor(rawW * canvasScale);
|
||||
const canvasHeight = Math.floor(rawH * canvasScale);
|
||||
if (!canvasWidth || !canvasHeight) {
|
||||
return null;
|
||||
}
|
||||
|
||||
committedCanvas = document.createElement("canvas");
|
||||
committedCanvas.width = canvasWidth;
|
||||
committedCanvas.height = canvasHeight;
|
||||
|
||||
tipCanvas = document.createElement("canvas");
|
||||
tipCanvas.width = canvasWidth;
|
||||
tipCanvas.height = canvasHeight;
|
||||
|
||||
if (
|
||||
prevInc !== undefined &&
|
||||
boundsExceeded &&
|
||||
prevInc.scale === canvasScale &&
|
||||
prevInc.theme === appState.theme
|
||||
) {
|
||||
// Bounds grew: copy committed raster to new canvas at the correct offset
|
||||
// and keep accumulating. Tip will be redrawn below.
|
||||
const copyX =
|
||||
(prevInc.canvasOriginSceneX - canvasOriginSceneX) * dpr * canvasScale;
|
||||
const copyY =
|
||||
(prevInc.canvasOriginSceneY - canvasOriginSceneY) * dpr * canvasScale;
|
||||
committedCanvas
|
||||
.getContext("2d")!
|
||||
.drawImage(prevInc.committedCanvas, copyX, copyY);
|
||||
committedFromIndex = prevInc.committedPointCount;
|
||||
} else {
|
||||
// Full regeneration: zoom/theme change or first frame.
|
||||
committedFromIndex = 0;
|
||||
}
|
||||
|
||||
freedrawIncrementalCache.set(element, {
|
||||
committedCanvas,
|
||||
tipCanvas,
|
||||
committedPointCount: committedFromIndex,
|
||||
canvasOriginSceneX,
|
||||
canvasOriginSceneY,
|
||||
canvasAllocX1: allocX1,
|
||||
canvasAllocY1: allocY1,
|
||||
canvasAllocX2: allocX2,
|
||||
canvasAllocY2: allocY2,
|
||||
scale: canvasScale,
|
||||
theme: appState.theme,
|
||||
});
|
||||
} else {
|
||||
committedCanvas = prevInc.committedCanvas;
|
||||
tipCanvas = prevInc.tipCanvas;
|
||||
canvasOriginSceneX = prevInc.canvasOriginSceneX;
|
||||
canvasOriginSceneY = prevInc.canvasOriginSceneY;
|
||||
canvasScale = prevInc.scale;
|
||||
committedFromIndex = prevInc.committedPointCount;
|
||||
}
|
||||
|
||||
const inc = freedrawIncrementalCache.get(element)!;
|
||||
|
||||
// ── Helper: draw onto a canvas with the element's scene->pixel transform ──
|
||||
const withElementContext = (
|
||||
target: HTMLCanvasElement,
|
||||
fn: (ctx: CanvasRenderingContext2D) => void,
|
||||
) => {
|
||||
const ctx = target.getContext("2d")!;
|
||||
const offsetX = (element.x - canvasOriginSceneX) * dpr * canvasScale;
|
||||
const offsetY = (element.y - canvasOriginSceneY) * dpr * canvasScale;
|
||||
ctx.save();
|
||||
ctx.translate(offsetX, offsetY);
|
||||
ctx.scale(dpr * canvasScale, dpr * canvasScale);
|
||||
fn(ctx);
|
||||
ctx.restore();
|
||||
};
|
||||
|
||||
// ── Update committed canvas ───────────────────────────────────────────────
|
||||
// With N points the last finalisable segment ends at N-2 (needs N-1 as
|
||||
// right-hand neighbour for the tangent at N-2, and N-1 is always present).
|
||||
// We draw from `committedFromIndex` up to (but not including) point N-1,
|
||||
// so the committed canvas contains segments [0->1, ..., N-3->N-2].
|
||||
const newCommittedCount = Math.max(1, N - 1);
|
||||
if (committedFromIndex < newCommittedCount) {
|
||||
withElementContext(committedCanvas, (ctx) => {
|
||||
drawFreeDrawSegments(
|
||||
element,
|
||||
ctx,
|
||||
renderConfig,
|
||||
committedFromIndex,
|
||||
newCommittedCount, // upToIndex - stop before the last provisional segment
|
||||
canvasScale,
|
||||
);
|
||||
});
|
||||
inc.committedPointCount = newCommittedCount;
|
||||
}
|
||||
|
||||
// ── Redraw tip canvas ─────────────────────────────────────────────────────
|
||||
// Always cleared and redrawn: contains the single provisional segment
|
||||
// [committedPointCount-1 -> N-1] with a predicted-point ghost if available.
|
||||
withElementContext(tipCanvas, (ctx) => {
|
||||
ctx.clearRect(
|
||||
-(element.x - canvasOriginSceneX),
|
||||
-(element.y - canvasOriginSceneY),
|
||||
tipCanvas.width / (dpr * canvasScale),
|
||||
tipCanvas.height / (dpr * canvasScale),
|
||||
);
|
||||
drawFreeDrawSegments(
|
||||
element,
|
||||
ctx,
|
||||
renderConfig,
|
||||
inc.committedPointCount,
|
||||
undefined, // draw to natural end (the tip segment)
|
||||
canvasScale,
|
||||
);
|
||||
});
|
||||
|
||||
return {
|
||||
element,
|
||||
canvas: committedCanvas,
|
||||
tipCanvas,
|
||||
theme: appState.theme,
|
||||
scale: canvasScale,
|
||||
angle: element.angle,
|
||||
zoomValue: zoom.value,
|
||||
canvasOffsetX: 0,
|
||||
canvasOffsetY: 0,
|
||||
boundTextElementVersion: null,
|
||||
imageCrop: null,
|
||||
containingFrameOpacity,
|
||||
boundTextCanvas: document.createElement("canvas"),
|
||||
canvasOriginSceneX: inc.canvasOriginSceneX,
|
||||
canvasOriginSceneY: inc.canvasOriginSceneY,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Removes the incremental freedraw canvas for the given element.
|
||||
* Call this when a freedraw stroke is finalised so the next render
|
||||
* produces a fresh tight-bounds canvas instead of the over-allocated one.
|
||||
*/
|
||||
export const invalidateFreeDrawIncrementalCanvas = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
) => {
|
||||
freedrawIncrementalCache.delete(element);
|
||||
};
|
||||
@@ -129,13 +129,24 @@ export const getElementsWithinSelection = (
|
||||
const framesInSelection = excludeElementsInFrames
|
||||
? new Set<NonDeletedExcalidrawElement["id"]>()
|
||||
: null;
|
||||
let elementsInSelection: NonDeletedExcalidrawElement[] = [];
|
||||
const groups: Record<string, NonDeletedExcalidrawElement[]> = {};
|
||||
const elementsInSelection: Set<NonDeletedExcalidrawElement> = new Set();
|
||||
|
||||
for (const element of elements) {
|
||||
if (shouldIgnoreElementFromSelection(element)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
// Track only selectable top-level group members, so ignored elements such
|
||||
// as bound text and locked elements don't affect group selection.
|
||||
const groupId = element.groupIds.at(-1);
|
||||
if (groupId) {
|
||||
if (!groups[groupId]) {
|
||||
groups[groupId] = [];
|
||||
}
|
||||
groups[groupId].push(element);
|
||||
}
|
||||
|
||||
const strokeWidth = element.strokeWidth;
|
||||
let labelAABB: Bounds | null = null;
|
||||
let elementAABB = getElementBounds(element, elementsMap);
|
||||
@@ -209,7 +220,7 @@ export const getElementsWithinSelection = (
|
||||
if (framesInSelection && isFrameLikeElement(element)) {
|
||||
framesInSelection.add(element.id);
|
||||
}
|
||||
elementsInSelection.push(element);
|
||||
elementsInSelection.add(element);
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -219,7 +230,7 @@ export const getElementsWithinSelection = (
|
||||
labelAABB &&
|
||||
doBoundsIntersect(selectionBounds, labelAABB)
|
||||
) {
|
||||
elementsInSelection.push(element);
|
||||
elementsInSelection.add(element);
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -309,7 +320,7 @@ export const getElementsWithinSelection = (
|
||||
framesInSelection.add(element.id);
|
||||
}
|
||||
|
||||
elementsInSelection.push(element);
|
||||
elementsInSelection.add(element);
|
||||
continue;
|
||||
}
|
||||
}
|
||||
@@ -318,21 +329,41 @@ export const getElementsWithinSelection = (
|
||||
// as it is separately handled in App.
|
||||
}
|
||||
|
||||
elementsInSelection = framesInSelection
|
||||
? excludeElementsFromFrames(elementsInSelection, framesInSelection)
|
||||
: elementsInSelection;
|
||||
if (framesInSelection) {
|
||||
elementsInSelection.forEach((element) => {
|
||||
if (element.frameId && framesInSelection.has(element.frameId)) {
|
||||
elementsInSelection.delete(element);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
elementsInSelection = elementsInSelection.filter((element) => {
|
||||
const containingFrame = getContainingFrame(element, elementsMap);
|
||||
if (boxSelectionMode === "overlap") {
|
||||
Array.from(elementsInSelection).forEach((element) => {
|
||||
const groupId = element.groupIds.at(-1);
|
||||
const group = groupId ? groups[groupId] : null;
|
||||
|
||||
if (containingFrame) {
|
||||
return elementOverlapsWithFrame(element, containingFrame, elementsMap);
|
||||
}
|
||||
group?.forEach((groupElement) => elementsInSelection.add(groupElement));
|
||||
});
|
||||
} else if (boxSelectionMode === "contain") {
|
||||
elementsInSelection.forEach((element) => {
|
||||
// note: currently we only support top-level group handling since
|
||||
// we don't support box selecting while editing the group/subgroup
|
||||
// see https://github.com/excalidraw/excalidraw/pull/11234#issuecomment-4387654451
|
||||
const groupId = element.groupIds.at(-1);
|
||||
|
||||
return true;
|
||||
});
|
||||
const group = groupId ? groups[groupId] : null;
|
||||
|
||||
return elementsInSelection;
|
||||
if (
|
||||
group &&
|
||||
!group.every((groupElement) => elementsInSelection.has(groupElement))
|
||||
) {
|
||||
elementsInSelection.delete(element);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
// to maintain original order elements (namely for group selection)
|
||||
return elements.filter((element) => elementsInSelection.has(element));
|
||||
};
|
||||
|
||||
export const getVisibleAndNonSelectedElements = (
|
||||
|
||||
+354
-74
@@ -1,5 +1,4 @@
|
||||
import { simplify } from "points-on-curve";
|
||||
import { getStroke } from "perfect-freehand";
|
||||
|
||||
import {
|
||||
type GeometricShape,
|
||||
@@ -28,6 +27,12 @@ import {
|
||||
|
||||
import { RoughGenerator } from "roughjs/bin/generator";
|
||||
|
||||
import type {
|
||||
ElementShape,
|
||||
ElementShapes,
|
||||
SVGPathString,
|
||||
} from "@excalidraw/excalidraw/scene/types";
|
||||
|
||||
import type { GlobalPoint } from "@excalidraw/math";
|
||||
|
||||
import type { Mutable } from "@excalidraw/common/utility-types";
|
||||
@@ -36,11 +41,6 @@ import type {
|
||||
AppState,
|
||||
EmbedsValidationStatus,
|
||||
} from "@excalidraw/excalidraw/types";
|
||||
import type {
|
||||
ElementShape,
|
||||
ElementShapes,
|
||||
SVGPathString,
|
||||
} from "@excalidraw/excalidraw/scene/types";
|
||||
|
||||
import { elementWithCanvasCache } from "./renderElement";
|
||||
|
||||
@@ -218,9 +218,7 @@ export const generateRoughOptions = (
|
||||
fillWeight: element.strokeWidth / 2,
|
||||
hachureGap: element.strokeWidth * 4,
|
||||
roughness: adjustRoughness(element),
|
||||
stroke: isDarkMode
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor,
|
||||
stroke: applyDarkModeFilter(element.strokeColor, isDarkMode),
|
||||
preserveVertices:
|
||||
continuousPath || element.roughness < ROUGHNESS.cartoonist,
|
||||
};
|
||||
@@ -234,9 +232,7 @@ export const generateRoughOptions = (
|
||||
options.fillStyle = element.fillStyle;
|
||||
options.fill = isTransparent(element.backgroundColor)
|
||||
? undefined
|
||||
: isDarkMode
|
||||
? applyDarkModeFilter(element.backgroundColor)
|
||||
: element.backgroundColor;
|
||||
: applyDarkModeFilter(element.backgroundColor, isDarkMode);
|
||||
if (element.type === "ellipse") {
|
||||
options.curveFitting = 1;
|
||||
}
|
||||
@@ -249,9 +245,7 @@ export const generateRoughOptions = (
|
||||
options.fill =
|
||||
element.backgroundColor === "transparent"
|
||||
? undefined
|
||||
: isDarkMode
|
||||
? applyDarkModeFilter(element.backgroundColor)
|
||||
: element.backgroundColor;
|
||||
: applyDarkModeFilter(element.backgroundColor, isDarkMode);
|
||||
}
|
||||
return options;
|
||||
}
|
||||
@@ -386,12 +380,11 @@ const getArrowheadShapes = (
|
||||
return [];
|
||||
}
|
||||
|
||||
const strokeColor = isDarkMode
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor;
|
||||
const backgroundFillColor = isDarkMode
|
||||
? applyDarkModeFilter(canvasBackgroundColor)
|
||||
: canvasBackgroundColor;
|
||||
const strokeColor = applyDarkModeFilter(element.strokeColor, isDarkMode);
|
||||
const backgroundFillColor = applyDarkModeFilter(
|
||||
canvasBackgroundColor,
|
||||
isDarkMode,
|
||||
);
|
||||
const cardinalityOneOrManyOffset = -0.25;
|
||||
const cardinalityZeroCircleScale = 0.8;
|
||||
|
||||
@@ -981,7 +974,7 @@ const _generateElementShape = (
|
||||
}
|
||||
|
||||
// (2) stroke
|
||||
shapes.push(getFreeDrawSvgPath(element));
|
||||
shapes.push(...getFreeDrawCapsulePaths(element));
|
||||
|
||||
return shapes;
|
||||
}
|
||||
@@ -1171,64 +1164,351 @@ export const toggleLinePolygonState = (
|
||||
// freedraw shape helper
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
// NOTE not cached (-> for SVG export)
|
||||
const getFreeDrawSvgPath = (element: ExcalidrawFreeDrawElement) => {
|
||||
return getSvgPathFromStroke(
|
||||
getFreedrawOutlinePoints(element),
|
||||
) as SVGPathString;
|
||||
};
|
||||
const FREEDRAW_DEFAULT_PRESSURE = 0.5;
|
||||
const FREEDRAW_BEZIER_SUBDIVIDE_TARGET_SPACING = 3;
|
||||
const FREEDRAW_PRESSURE_SMOOTHING_RADIUS = 6;
|
||||
|
||||
export const getFreedrawOutlinePoints = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
) => {
|
||||
// If input points are empty (should they ever be?) return a dot
|
||||
const inputPoints = element.simulatePressure
|
||||
? element.points
|
||||
: element.points.length
|
||||
? element.points.map(([x, y], i) => [x, y, element.pressures[i]])
|
||||
: [[0, 0, 0.5]];
|
||||
// Round to 2 dp — sub-pixel accuracy at SVG 96 dpi
|
||||
const r2 = (v: number) => Math.round(v * 100) / 100;
|
||||
|
||||
return getStroke(inputPoints as number[][], {
|
||||
simulatePressure: element.simulatePressure,
|
||||
size: element.strokeWidth * 4.25,
|
||||
thinning: 0.6,
|
||||
smoothing: 0.5,
|
||||
streamline: 0.5,
|
||||
easing: (t) => Math.sin((t * Math.PI) / 2), // https://easings.net/#easeOutSine
|
||||
last: true,
|
||||
}) as [number, number][];
|
||||
};
|
||||
/**
|
||||
* SVG path `d` string for a single tapered capsule. Uses clockwise arcs
|
||||
* (sweep=1) so the geometry matches the canvas 2D
|
||||
* `arc(..., anticlockwise=false)` calls.
|
||||
*/
|
||||
const freedrawTaperedCapsulePath = (
|
||||
x0: number,
|
||||
y0: number,
|
||||
r0: number,
|
||||
x1: number,
|
||||
y1: number,
|
||||
r1: number,
|
||||
): string => {
|
||||
const dx = x1 - x0;
|
||||
const dy = y1 - y0;
|
||||
const len = Math.sqrt(dx * dx + dy * dy);
|
||||
const r = Math.max(r0, r1);
|
||||
|
||||
const med = (A: number[], B: number[]) => {
|
||||
return [(A[0] + B[0]) / 2, (A[1] + B[1]) / 2];
|
||||
};
|
||||
|
||||
// Trim SVG path data so number are each two decimal points. This
|
||||
// improves SVG exports, and prevents rendering errors on points
|
||||
// with long decimals.
|
||||
const TO_FIXED_PRECISION = /(\s?[A-Z]?,?-?[0-9]*\.[0-9]{0,2})(([0-9]|e|-)*)/g;
|
||||
|
||||
const getSvgPathFromStroke = (points: number[][]): string => {
|
||||
if (!points.length) {
|
||||
return "";
|
||||
if (len < r / 2) {
|
||||
// Degenerate — full circle at midpoint via two clockwise 180° arcs.
|
||||
const cx = r2((x0 + x1) / 2);
|
||||
const cy = r2((y0 + y1) / 2);
|
||||
const rr = r2(r);
|
||||
return (
|
||||
`M ${(cx - rr).toFixed(2)} ${cy.toFixed(2)} ` +
|
||||
`A ${rr} ${rr} 0 1 1 ${(cx + rr).toFixed(2)} ${cy.toFixed(2)} ` +
|
||||
`A ${rr} ${rr} 0 1 1 ${(cx - rr).toFixed(2)} ${cy.toFixed(2)} Z`
|
||||
);
|
||||
}
|
||||
|
||||
const max = points.length - 1;
|
||||
const px = -dy / len; // perpendicular unit x
|
||||
const py = dx / len; // perpendicular unit y
|
||||
|
||||
return points
|
||||
.reduce(
|
||||
(acc, point, i, arr) => {
|
||||
if (i === max) {
|
||||
acc.push(point, med(point, arr[0]), "L", arr[0], "Z");
|
||||
} else {
|
||||
acc.push(point, med(point, arr[i + 1]));
|
||||
}
|
||||
return acc;
|
||||
},
|
||||
["M", points[0], "Q"],
|
||||
)
|
||||
.join(" ")
|
||||
.replace(TO_FIXED_PRECISION, "$1");
|
||||
// P0 +/- perp·r0 (start / back cap tangent points)
|
||||
const b0x = r2(x0 + px * r0);
|
||||
const b0y = r2(y0 + py * r0);
|
||||
const b1x = r2(x0 - px * r0);
|
||||
const b1y = r2(y0 - py * r0);
|
||||
// P1 +/- perp·r1 (end / front cap tangent points)
|
||||
const f0x = r2(x1 - px * r1);
|
||||
const f0y = r2(y1 - py * r1);
|
||||
const f1x = r2(x1 + px * r1);
|
||||
const f1y = r2(y1 + py * r1);
|
||||
const rr0 = r2(r0);
|
||||
const rr1 = r2(r1);
|
||||
|
||||
// Back cap: clockwise 180° arc from (b0) to (b1) around P0.
|
||||
// Front cap: clockwise 180° arc from (f0) to (f1) around P1.
|
||||
return (
|
||||
`M ${b0x.toFixed(2)} ${b0y.toFixed(2)} ` +
|
||||
`A ${rr0.toFixed(2)} ${rr0.toFixed(2)} 0 1 1 ${b1x.toFixed(
|
||||
2,
|
||||
)} ${b1y.toFixed(2)} ` +
|
||||
`L ${f0x.toFixed(2)} ${f0y.toFixed(2)} ` +
|
||||
`A ${rr1.toFixed(2)} ${rr1.toFixed(2)} 0 1 1 ${f1x.toFixed(
|
||||
2,
|
||||
)} ${f1y.toFixed(2)} Z`
|
||||
);
|
||||
};
|
||||
|
||||
/**
|
||||
* Catmull-Rom tangent at points[i].Identical math to `getCatmullRomTangent`
|
||||
* in renderElement.ts (predictedPoint is not needed for finalised strokes).
|
||||
*/
|
||||
const freedrawCatmullRomTangent = (
|
||||
points: readonly (readonly [number, number])[],
|
||||
i: number,
|
||||
): [number, number] => {
|
||||
const N = points.length;
|
||||
const cur = points[i];
|
||||
|
||||
let next: readonly [number, number];
|
||||
if (i < N - 1) {
|
||||
next = points[i + 1];
|
||||
} else {
|
||||
const prev2 = i > 0 ? points[i - 1] : cur;
|
||||
next = [2 * cur[0] - prev2[0], 2 * cur[1] - prev2[1]];
|
||||
}
|
||||
|
||||
let tx: number;
|
||||
let ty: number;
|
||||
if (i === 0) {
|
||||
tx = (next[0] - cur[0]) * 0.5;
|
||||
ty = (next[1] - cur[1]) * 0.5;
|
||||
} else {
|
||||
const prev = points[i - 1];
|
||||
tx = (next[0] - prev[0]) * 0.5;
|
||||
ty = (next[1] - prev[1]) * 0.5;
|
||||
}
|
||||
|
||||
// Chord-length clamping (PCHIP-style).
|
||||
const magSq = tx * tx + ty * ty;
|
||||
if (magSq > 0) {
|
||||
const dNx = next[0] - cur[0];
|
||||
const dNy = next[1] - cur[1];
|
||||
const chordNext = Math.sqrt(dNx * dNx + dNy * dNy);
|
||||
let chordPrev = chordNext;
|
||||
if (i > 0) {
|
||||
const prev = points[i - 1];
|
||||
const dPx = cur[0] - prev[0];
|
||||
const dPy = cur[1] - prev[1];
|
||||
chordPrev = Math.sqrt(dPx * dPx + dPy * dPy);
|
||||
}
|
||||
const maxMag = 3 * Math.min(chordNext, chordPrev);
|
||||
const mag = Math.sqrt(magSq);
|
||||
if (mag > maxMag) {
|
||||
const s = maxMag / mag;
|
||||
tx *= s;
|
||||
ty *= s;
|
||||
}
|
||||
}
|
||||
|
||||
return [tx, ty];
|
||||
};
|
||||
|
||||
/**
|
||||
* Triangular-kernel causal weighted pressure average (backward-only window).
|
||||
* When `simulatePressure` is true or pressures array is empty, returns the
|
||||
* default constant pressure so the geometry mirrors constant-pressure rendering.
|
||||
*/
|
||||
const getFreeDrawSmoothedPressure = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
i: number,
|
||||
): number => {
|
||||
const { pressures } = element;
|
||||
if (element.simulatePressure || pressures.length === 0) {
|
||||
return FREEDRAW_DEFAULT_PRESSURE;
|
||||
}
|
||||
let sum = 0;
|
||||
let totalWeight = 0;
|
||||
for (let k = -FREEDRAW_PRESSURE_SMOOTHING_RADIUS; k <= 0; k++) {
|
||||
const idx = i + k;
|
||||
if (idx < 0) {
|
||||
continue;
|
||||
}
|
||||
const p =
|
||||
idx < pressures.length ? pressures[idx] : FREEDRAW_DEFAULT_PRESSURE;
|
||||
const w = FREEDRAW_PRESSURE_SMOOTHING_RADIUS + 1 + k;
|
||||
sum += p * w;
|
||||
totalWeight += w;
|
||||
}
|
||||
return totalWeight > 0 ? sum / totalWeight : FREEDRAW_DEFAULT_PRESSURE;
|
||||
};
|
||||
|
||||
/**
|
||||
* Returns one SVG path `d` string per tapered-capsule sub-segment for a
|
||||
* freedraw element, using the same Catmull-Rom Bezier subdivision and pressure
|
||||
* smoothing as the canvas renderer.
|
||||
*/
|
||||
const getFreeDrawCapsulePaths = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
): SVGPathString[] => {
|
||||
const { points } = element;
|
||||
const N = points.length;
|
||||
const baseRadius = (element.strokeWidth * 1.25) / 2;
|
||||
|
||||
const getSmoothedPressure = (i: number): number =>
|
||||
getFreeDrawSmoothedPressure(element, i);
|
||||
|
||||
const paths: SVGPathString[] = [];
|
||||
|
||||
if (N === 1) {
|
||||
// Single-point stroke — filled circle.
|
||||
const rr = r2(baseRadius * getSmoothedPressure(0) * 2);
|
||||
const cx = r2(points[0][0]);
|
||||
const cy = r2(points[0][1]);
|
||||
paths.push(
|
||||
`M ${(cx - rr).toFixed(2)} ${cy.toFixed(2)} A ${rr} ${rr} 0 1 1 ${(
|
||||
cx + rr
|
||||
).toFixed(2)} ${cy.toFixed(2)} A ${rr} ${rr} 0 1 1 ${(cx - rr).toFixed(
|
||||
2,
|
||||
)} ${cy.toFixed(2)} Z` as SVGPathString,
|
||||
);
|
||||
return paths;
|
||||
}
|
||||
|
||||
for (let i = 1; i < N; i++) {
|
||||
const p0 = points[i - 1];
|
||||
const p1 = points[i];
|
||||
const r0 = baseRadius * getSmoothedPressure(i - 1) * 2;
|
||||
const r1 = baseRadius * getSmoothedPressure(i) * 2;
|
||||
|
||||
const t0 = freedrawCatmullRomTangent(points, i - 1);
|
||||
const t1 = freedrawCatmullRomTangent(points, i);
|
||||
|
||||
// Bezier subdivision.
|
||||
const segLen = Math.sqrt((p1[0] - p0[0]) ** 2 + (p1[1] - p0[1]) ** 2);
|
||||
const nSubdiv = Math.max(
|
||||
1,
|
||||
Math.ceil(segLen / FREEDRAW_BEZIER_SUBDIVIDE_TARGET_SPACING),
|
||||
);
|
||||
|
||||
const cp1x = p0[0] + t0[0] / 3;
|
||||
const cp1y = p0[1] + t0[1] / 3;
|
||||
const cp2x = p1[0] - t1[0] / 3;
|
||||
const cp2y = p1[1] - t1[1] / 3;
|
||||
|
||||
let prevX = p0[0];
|
||||
let prevY = p0[1];
|
||||
let prevR = r0;
|
||||
|
||||
for (let k = 1; k <= nSubdiv; k++) {
|
||||
const t = k / nSubdiv;
|
||||
const mt = 1 - t;
|
||||
const mt2 = mt * mt;
|
||||
const t2 = t * t;
|
||||
const mt3 = mt2 * mt;
|
||||
const t3 = t2 * t;
|
||||
|
||||
const x =
|
||||
mt3 * p0[0] + 3 * mt2 * t * cp1x + 3 * mt * t2 * cp2x + t3 * p1[0];
|
||||
const y =
|
||||
mt3 * p0[1] + 3 * mt2 * t * cp1y + 3 * mt * t2 * cp2y + t3 * p1[1];
|
||||
const r = r0 + (r1 - r0) * t;
|
||||
|
||||
paths.push(
|
||||
freedrawTaperedCapsulePath(
|
||||
prevX,
|
||||
prevY,
|
||||
prevR,
|
||||
x,
|
||||
y,
|
||||
r,
|
||||
) as SVGPathString,
|
||||
);
|
||||
prevX = x;
|
||||
prevY = y;
|
||||
prevR = r;
|
||||
}
|
||||
}
|
||||
|
||||
return paths;
|
||||
};
|
||||
|
||||
/**
|
||||
* Generates an outline polygon for a freedraw element using the same
|
||||
* Catmull-Rom Bezier subdivision and pressure smoothing as the canvas renderer.
|
||||
* Returns `[x, y]` points in element-local coordinates that form a closed
|
||||
* polygon around the stroke (left side + right side reversed), suitable for
|
||||
* hit-testing and eraser intersection.
|
||||
*/
|
||||
export const getFreedrawOutlinePoints = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
): [number, number][] => {
|
||||
const { points } = element;
|
||||
const N = points.length;
|
||||
const baseRadius = (element.strokeWidth * 1.25) / 2;
|
||||
|
||||
if (N === 0) {
|
||||
return [];
|
||||
}
|
||||
|
||||
const radius0 = baseRadius * getFreeDrawSmoothedPressure(element, 0) * 2;
|
||||
|
||||
if (N === 1) {
|
||||
// Single point case
|
||||
const cx = points[0][0];
|
||||
const cy = points[0][1];
|
||||
const result: [number, number][] = [];
|
||||
for (let i = 0; i < 8; i++) {
|
||||
const angle = (i / 8) * Math.PI * 2;
|
||||
result.push([
|
||||
cx + Math.cos(angle) * radius0,
|
||||
cy + Math.sin(angle) * radius0,
|
||||
]);
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
const leftPoints: [number, number][] = [];
|
||||
const rightPoints: [number, number][] = [];
|
||||
|
||||
for (let i = 1; i < N; i++) {
|
||||
const p0 = points[i - 1];
|
||||
const p1 = points[i];
|
||||
const r0 = baseRadius * getFreeDrawSmoothedPressure(element, i - 1) * 2;
|
||||
const r1 = baseRadius * getFreeDrawSmoothedPressure(element, i) * 2;
|
||||
|
||||
const t0 = freedrawCatmullRomTangent(points, i - 1);
|
||||
const t1 = freedrawCatmullRomTangent(points, i);
|
||||
|
||||
const segLen = Math.sqrt((p1[0] - p0[0]) ** 2 + (p1[1] - p0[1]) ** 2);
|
||||
const nSubdiv = Math.max(
|
||||
1,
|
||||
Math.ceil(segLen / FREEDRAW_BEZIER_SUBDIVIDE_TARGET_SPACING),
|
||||
);
|
||||
|
||||
const cp1x = p0[0] + t0[0] / 3;
|
||||
const cp1y = p0[1] + t0[1] / 3;
|
||||
const cp2x = p1[0] - t1[0] / 3;
|
||||
const cp2y = p1[1] - t1[1] / 3;
|
||||
|
||||
// Include the start point of the first segment.
|
||||
const kStart = i === 1 ? 0 : 1;
|
||||
|
||||
for (let k = kStart; k <= nSubdiv; k++) {
|
||||
const tParam = k / nSubdiv;
|
||||
const mt = 1 - tParam;
|
||||
const mt2 = mt * mt;
|
||||
const t2 = tParam * tParam;
|
||||
const mt3 = mt2 * mt;
|
||||
const t3 = t2 * tParam;
|
||||
|
||||
const x =
|
||||
mt3 * p0[0] + 3 * mt2 * tParam * cp1x + 3 * mt * t2 * cp2x + t3 * p1[0];
|
||||
const y =
|
||||
mt3 * p0[1] + 3 * mt2 * tParam * cp1y + 3 * mt * t2 * cp2y + t3 * p1[1];
|
||||
|
||||
// Bezier first derivative for the tangent direction.
|
||||
const dtx =
|
||||
3 *
|
||||
(mt2 * (cp1x - p0[0]) +
|
||||
2 * mt * tParam * (cp2x - cp1x) +
|
||||
t2 * (p1[0] - cp2x));
|
||||
const dty =
|
||||
3 *
|
||||
(mt2 * (cp1y - p0[1]) +
|
||||
2 * mt * tParam * (cp2y - cp1y) +
|
||||
t2 * (p1[1] - cp2y));
|
||||
|
||||
const len = Math.sqrt(dtx * dtx + dty * dty);
|
||||
if (len === 0) {
|
||||
continue;
|
||||
}
|
||||
|
||||
// Perpendicular (left = +, right = −).
|
||||
const px = -dty / len;
|
||||
const py = dtx / len;
|
||||
|
||||
const r = r0 + (r1 - r0) * tParam;
|
||||
|
||||
leftPoints.push([x + px * r, y + py * r]);
|
||||
rightPoints.push([x - px * r, y - py * r]);
|
||||
}
|
||||
}
|
||||
|
||||
// Closed polygon: left side (start -> end) + right side (end -> start).
|
||||
return [...leftPoints, ...rightPoints.reverse()];
|
||||
};
|
||||
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
@@ -392,3 +392,23 @@ export const canBecomePolygon = (
|
||||
(points.length === 3 && !pointsEqual(points[0], points[points.length - 1]))
|
||||
);
|
||||
};
|
||||
|
||||
export const isEligibleFrameChildType = (type: ElementOrToolType) => {
|
||||
switch (type) {
|
||||
case "rectangle":
|
||||
case "diamond":
|
||||
case "ellipse":
|
||||
case "arrow":
|
||||
case "line":
|
||||
case "freedraw":
|
||||
case "text":
|
||||
case "image":
|
||||
case "frame":
|
||||
case "embeddable": {
|
||||
return true;
|
||||
}
|
||||
default: {
|
||||
return false;
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
@@ -1,9 +1,8 @@
|
||||
/* eslint-disable no-lone-blocks */
|
||||
import { generateKeyBetween } from "fractional-indexing";
|
||||
|
||||
import { arrayToMap } from "@excalidraw/common";
|
||||
|
||||
import {
|
||||
InvalidFractionalIndexError,
|
||||
syncInvalidIndices,
|
||||
syncMovedIndices,
|
||||
validateFractionalIndices,
|
||||
@@ -13,13 +12,34 @@ import { deepCopyElement } from "@excalidraw/element";
|
||||
|
||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||
|
||||
import {
|
||||
generateKeyBetween,
|
||||
validateOrderKey,
|
||||
} from "@excalidraw/fractional-indexing";
|
||||
|
||||
import type {
|
||||
ElementsMap,
|
||||
ExcalidrawElement,
|
||||
FractionalIndex,
|
||||
} from "@excalidraw/element/types";
|
||||
|
||||
import { InvalidFractionalIndexError } from "../src/fractionalIndex";
|
||||
describe("fractional index format validation", () => {
|
||||
it("should reject malformed base62 order keys", () => {
|
||||
expect(() => validateOrderKey("a!")).toThrow();
|
||||
expect(() => validateOrderKey("a_")).toThrow();
|
||||
expect(() => validateOrderKey("a1!")).toThrow();
|
||||
expect(() => validateOrderKey("a1_")).toThrow();
|
||||
expect(() => validateOrderKey("zd0032")).toThrow();
|
||||
});
|
||||
|
||||
it("should accept valid base62 order keys", () => {
|
||||
expect(() => validateOrderKey("Zz")).not.toThrow();
|
||||
expect(() => validateOrderKey("a0")).not.toThrow();
|
||||
expect(() => validateOrderKey("a1")).not.toThrow();
|
||||
expect(() => validateOrderKey("a1V")).not.toThrow();
|
||||
expect(() => validateOrderKey("z".padEnd(28, "z"))).not.toThrow();
|
||||
});
|
||||
});
|
||||
|
||||
describe("sync invalid indices with array order", () => {
|
||||
describe("should NOT sync empty array", () => {
|
||||
@@ -104,6 +124,46 @@ describe("sync invalid indices with array order", () => {
|
||||
});
|
||||
});
|
||||
|
||||
describe("should sync when fractional index is malformed", () => {
|
||||
// "zd0032" has head "z" which requires length 28 per getIntegerLength,
|
||||
// but the string is far too short, so validateOrderKey throws for it
|
||||
testInvalidIndicesSync({
|
||||
elements: [{ id: "A", index: "zd0032" }],
|
||||
expect: {
|
||||
unchangedElements: [],
|
||||
},
|
||||
});
|
||||
|
||||
testInvalidIndicesSync({
|
||||
elements: [
|
||||
{ id: "A", index: "a1" },
|
||||
{ id: "B", index: "zd0032" },
|
||||
{ id: "C", index: "a3" },
|
||||
],
|
||||
expect: {
|
||||
unchangedElements: ["A", "C"],
|
||||
},
|
||||
});
|
||||
|
||||
testInvalidIndicesSync({
|
||||
elements: [{ id: "A", index: "a!" }],
|
||||
expect: {
|
||||
unchangedElements: [],
|
||||
},
|
||||
});
|
||||
|
||||
testInvalidIndicesSync({
|
||||
elements: [
|
||||
{ id: "A", index: "a1" },
|
||||
{ id: "B", index: "a!" },
|
||||
{ id: "C", index: "a2" },
|
||||
],
|
||||
expect: {
|
||||
unchangedElements: ["A", "C"],
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
describe("should sync when fractional indices are duplicated", () => {
|
||||
testInvalidIndicesSync({
|
||||
elements: [
|
||||
|
||||
@@ -5,12 +5,15 @@ import {
|
||||
import { arrayToMap } from "@excalidraw/common";
|
||||
|
||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||
import { Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
|
||||
import { Keyboard, Pointer, UI } from "@excalidraw/excalidraw/tests/helpers/ui";
|
||||
import { getTextEditor } from "@excalidraw/excalidraw/tests/queries/dom";
|
||||
import {
|
||||
getCloneByOrigId,
|
||||
render,
|
||||
} from "@excalidraw/excalidraw/tests/test-utils";
|
||||
|
||||
import { getSelectedElements } from "@excalidraw/excalidraw/scene";
|
||||
|
||||
import { elementOverlapsWithFrame } from "../src/frame";
|
||||
|
||||
import type {
|
||||
@@ -151,6 +154,230 @@ describe("adding elements to frames", () => {
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
it("should not add a newly created element to a frame behind a non-frame element", () => {
|
||||
const cover = API.createElement({
|
||||
id: "cover",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
});
|
||||
|
||||
API.setElements([frame, cover]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.downAt(20, 20);
|
||||
mouse.moveTo(40, 40);
|
||||
mouse.upAt(40, 40);
|
||||
|
||||
const createdElement = h.elements.find(
|
||||
(element) => element.id !== frame.id && element.id !== cover.id,
|
||||
);
|
||||
|
||||
expect(createdElement?.frameId).toBe(null);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frame.id,
|
||||
cover.id,
|
||||
createdElement?.id,
|
||||
]);
|
||||
});
|
||||
|
||||
it("should add a newly created element to a frame over a non-frame element", () => {
|
||||
const cover = API.createElement({
|
||||
id: "cover",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
});
|
||||
|
||||
API.setElements([cover, frame]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.downAt(20, 20);
|
||||
mouse.moveTo(40, 40);
|
||||
mouse.upAt(40, 40);
|
||||
|
||||
const createdElement = h.elements.find(
|
||||
(element) => element.id !== frame.id && element.id !== cover.id,
|
||||
);
|
||||
|
||||
expect(createdElement?.frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it("should highlight the target frame while creating a new element", () => {
|
||||
API.setElements([frame]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.downAt(20, 20);
|
||||
mouse.moveTo(40, 40);
|
||||
|
||||
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||
|
||||
mouse.upAt(40, 40);
|
||||
|
||||
expect(h.state.frameToHighlight).toBe(null);
|
||||
});
|
||||
|
||||
it("should highlight the target frame while hovering with a creation tool", () => {
|
||||
API.setElements([frame]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.moveTo(20, 20);
|
||||
|
||||
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||
|
||||
mouse.moveTo(200, 200);
|
||||
|
||||
expect(h.state.frameToHighlight).toBe(null);
|
||||
});
|
||||
|
||||
it("should not add grid-snapped text outside the frame to the clicked frame", async () => {
|
||||
const offsetFrame = API.createElement({
|
||||
id: "offsetFrame",
|
||||
type: "frame",
|
||||
x: 10,
|
||||
y: 0,
|
||||
width: 150,
|
||||
height: 150,
|
||||
});
|
||||
|
||||
API.setElements([offsetFrame]);
|
||||
API.setAppState({
|
||||
gridModeEnabled: true,
|
||||
});
|
||||
|
||||
UI.clickTool("text");
|
||||
mouse.clickAt(12, 0);
|
||||
|
||||
await getTextEditor();
|
||||
|
||||
const createdText = h.elements.find(
|
||||
(element) => element.id !== offsetFrame.id,
|
||||
);
|
||||
|
||||
expect(createdText?.x).toBe(0);
|
||||
expect(createdText?.y).toBe(0);
|
||||
expect(createdText?.frameId).toBe(null);
|
||||
});
|
||||
|
||||
it("should add a newly created element to a frame behind another frame", () => {
|
||||
const lockedFrame = API.createElement({
|
||||
id: "lockedFrame",
|
||||
type: "frame",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
locked: true,
|
||||
});
|
||||
|
||||
API.setElements([frame, lockedFrame]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.downAt(20, 20);
|
||||
mouse.moveTo(40, 40);
|
||||
mouse.upAt(40, 40);
|
||||
|
||||
const createdElement = h.elements.find(
|
||||
(element) => element.id !== frame.id && element.id !== lockedFrame.id,
|
||||
);
|
||||
|
||||
expect(createdElement?.frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it("should insert a newly created frame child just below its frame", () => {
|
||||
const frameChildUnderCursor = API.createElement({
|
||||
id: "frameChildUnderCursor",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
frameId: frame.id,
|
||||
});
|
||||
const otherFrameChild = API.createElement({
|
||||
id: "otherFrameChild",
|
||||
type: "rectangle",
|
||||
x: 100,
|
||||
y: 20,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([frameChildUnderCursor, otherFrameChild, frame]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.downAt(20, 20);
|
||||
mouse.moveTo(40, 40);
|
||||
mouse.upAt(40, 40);
|
||||
|
||||
const createdElement = h.elements.find(
|
||||
(element) =>
|
||||
element.id !== frame.id &&
|
||||
element.id !== frameChildUnderCursor.id &&
|
||||
element.id !== otherFrameChild.id,
|
||||
);
|
||||
|
||||
expect(createdElement?.frameId).toBe(frame.id);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frameChildUnderCursor.id,
|
||||
otherFrameChild.id,
|
||||
createdElement?.id,
|
||||
frame.id,
|
||||
]);
|
||||
});
|
||||
|
||||
it("should insert a newly created frame child above the highest frame child", () => {
|
||||
const frameChildUnderCursor = API.createElement({
|
||||
id: "frameChildUnderCursor",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
frameId: frame.id,
|
||||
});
|
||||
const otherFrameChild = API.createElement({
|
||||
id: "otherFrameChild",
|
||||
type: "rectangle",
|
||||
x: 100,
|
||||
y: 20,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([frame, frameChildUnderCursor, otherFrameChild]);
|
||||
|
||||
UI.clickTool("rectangle");
|
||||
mouse.downAt(20, 20);
|
||||
mouse.moveTo(40, 40);
|
||||
mouse.upAt(40, 40);
|
||||
|
||||
const createdElement = h.elements.find(
|
||||
(element) =>
|
||||
element.id !== frame.id &&
|
||||
element.id !== frameChildUnderCursor.id &&
|
||||
element.id !== otherFrameChild.id,
|
||||
);
|
||||
|
||||
expect(createdElement?.frameId).toBe(frame.id);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frame.id,
|
||||
frameChildUnderCursor.id,
|
||||
otherFrameChild.id,
|
||||
createdElement?.id,
|
||||
]);
|
||||
});
|
||||
|
||||
const commonTestCases = async (
|
||||
func: typeof resizeFrameOverElement | typeof dragElementIntoFrame,
|
||||
) => {
|
||||
@@ -457,6 +684,329 @@ describe("adding elements to frames", () => {
|
||||
expect(API.getElement(containingRect).frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it("should drag an element into a frame", () => {
|
||||
API.setElements([rect2, frame]);
|
||||
|
||||
dragElementIntoFrame(frame, rect2);
|
||||
|
||||
expect(rect2.frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it("should layer a dragged element above the highest frame child", () => {
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([frame, frameChild, rect2]);
|
||||
|
||||
dragElementIntoFrame(frame, rect2);
|
||||
|
||||
expect(rect2.frameId).toBe(frame.id);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frame.id,
|
||||
frameChild.id,
|
||||
rect2.id,
|
||||
]);
|
||||
expect(rect2.index! > frameChild.index!).toBe(true);
|
||||
expect(rect2.index! > frame.index!).toBe(true);
|
||||
});
|
||||
|
||||
it("should preview a dragged element above the highest frame child before pointerup", () => {
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([rect2, frame, frameChild]);
|
||||
API.setSelectedElements([rect2]);
|
||||
API.updateElement(rect2, {
|
||||
x: 10,
|
||||
y: 10,
|
||||
});
|
||||
|
||||
const getRenderableElementIds = (
|
||||
selectedElementsAreBeingDragged: boolean,
|
||||
) => {
|
||||
return h.app.renderer
|
||||
.getRenderableElements({
|
||||
zoom: h.state.zoom,
|
||||
offsetLeft: 0,
|
||||
offsetTop: 0,
|
||||
scrollX: 0,
|
||||
scrollY: 0,
|
||||
height: 1000,
|
||||
width: 1000,
|
||||
editingTextElement: h.state.editingTextElement,
|
||||
newElement: h.state.newElement,
|
||||
selectedElements: getSelectedElements(h.elements, h.state),
|
||||
selectedElementsAreBeingDragged,
|
||||
frameToHighlight: frame as ExcalidrawFrameLikeElement,
|
||||
})
|
||||
.visibleElements.map((element) => element.id);
|
||||
};
|
||||
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
rect2.id,
|
||||
frame.id,
|
||||
frameChild.id,
|
||||
]);
|
||||
expect(getRenderableElementIds(false)).toEqual([
|
||||
rect2.id,
|
||||
frame.id,
|
||||
frameChild.id,
|
||||
]);
|
||||
expect(getRenderableElementIds(true)).toEqual([
|
||||
frame.id,
|
||||
frameChild.id,
|
||||
rect2.id,
|
||||
]);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
rect2.id,
|
||||
frame.id,
|
||||
frameChild.id,
|
||||
]);
|
||||
expect(rect2.frameId).toBe(null);
|
||||
});
|
||||
|
||||
it("should not preview reorder dragged elements already in the highlighted frame", () => {
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const otherFrameChild = API.createElement({
|
||||
id: "otherFrameChild",
|
||||
type: "rectangle",
|
||||
x: 40,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([frameChild, frame, otherFrameChild]);
|
||||
API.setSelectedElements([frameChild]);
|
||||
|
||||
const renderableElementIds = h.app.renderer
|
||||
.getRenderableElements({
|
||||
zoom: h.state.zoom,
|
||||
offsetLeft: 0,
|
||||
offsetTop: 0,
|
||||
scrollX: 0,
|
||||
scrollY: 0,
|
||||
height: 1000,
|
||||
width: 1000,
|
||||
editingTextElement: h.state.editingTextElement,
|
||||
newElement: h.state.newElement,
|
||||
selectedElements: getSelectedElements(h.elements, h.state),
|
||||
selectedElementsAreBeingDragged: true,
|
||||
frameToHighlight: frame as ExcalidrawFrameLikeElement,
|
||||
})
|
||||
.visibleElements.map((element) => element.id);
|
||||
|
||||
expect(renderableElementIds).toEqual([
|
||||
frameChild.id,
|
||||
frame.id,
|
||||
otherFrameChild.id,
|
||||
]);
|
||||
});
|
||||
|
||||
it("should put a dragged mixed selection above the highest frame child", () => {
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 50,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
boundElements: [{ id: "boundText", type: "text" }],
|
||||
});
|
||||
const boundText = API.createElement({
|
||||
id: "boundText",
|
||||
type: "text",
|
||||
x: 50,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
containerId: frameChild.id,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const otherFrameChild = API.createElement({
|
||||
id: "otherFrameChild",
|
||||
type: "rectangle",
|
||||
x: 80,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const nonFrameElement = API.createElement({
|
||||
id: "nonFrameElement",
|
||||
type: "rectangle",
|
||||
x: 155,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
});
|
||||
|
||||
API.setElements([
|
||||
frame,
|
||||
frameChild,
|
||||
boundText,
|
||||
otherFrameChild,
|
||||
nonFrameElement,
|
||||
]);
|
||||
API.setSelectedElements([frameChild, nonFrameElement]);
|
||||
|
||||
mouse.downAt(
|
||||
nonFrameElement.x + nonFrameElement.width / 2,
|
||||
nonFrameElement.y + nonFrameElement.height / 2,
|
||||
);
|
||||
mouse.moveTo(frame.x + frame.width - 5, nonFrameElement.y + 10);
|
||||
mouse.up();
|
||||
|
||||
expect(frameChild.frameId).toBe(frame.id);
|
||||
expect(boundText.frameId).toBe(frame.id);
|
||||
expect(nonFrameElement.frameId).toBe(frame.id);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frame.id,
|
||||
otherFrameChild.id,
|
||||
frameChild.id,
|
||||
boundText.id,
|
||||
nonFrameElement.id,
|
||||
]);
|
||||
});
|
||||
|
||||
it("should not reorder dragged elements already in the highlighted frame", () => {
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 50,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const otherFrameChild = API.createElement({
|
||||
id: "otherFrameChild",
|
||||
type: "rectangle",
|
||||
x: 80,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([frame, frameChild, otherFrameChild]);
|
||||
API.setSelectedElements([frameChild]);
|
||||
|
||||
mouse.downAt(
|
||||
frameChild.x + frameChild.width / 2,
|
||||
frameChild.y + frameChild.height / 2,
|
||||
);
|
||||
mouse.moveTo(frameChild.x + frameChild.width / 2 + 5, frameChild.y + 10);
|
||||
mouse.up();
|
||||
|
||||
expect(frameChild.frameId).toBe(frame.id);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frame.id,
|
||||
frameChild.id,
|
||||
otherFrameChild.id,
|
||||
]);
|
||||
});
|
||||
|
||||
it("should not drag an element into a frame behind a non-frame element", () => {
|
||||
const cover = API.createElement({
|
||||
id: "cover",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
});
|
||||
API.setElements([frame, cover, rect2]);
|
||||
|
||||
mouse.clickAt(rect2.x, rect2.y);
|
||||
mouse.downAt(rect2.x + rect2.width / 2, rect2.y + rect2.height / 2);
|
||||
mouse.moveTo(20, 20);
|
||||
mouse.upAt(20, 20);
|
||||
|
||||
expect(rect2.frameId).toBe(null);
|
||||
});
|
||||
|
||||
it("should drag an element into a frame over a non-frame element", () => {
|
||||
const cover = API.createElement({
|
||||
id: "cover",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
});
|
||||
API.setElements([cover, rect2, frame]);
|
||||
|
||||
mouse.clickAt(rect2.x, rect2.y);
|
||||
mouse.downAt(rect2.x + rect2.width / 2, rect2.y + rect2.height / 2);
|
||||
mouse.moveTo(20, 20);
|
||||
mouse.upAt(20, 20);
|
||||
|
||||
expect(rect2.frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it("should keep dragging a frame child over a non-frame element above its frame", () => {
|
||||
const cover = API.createElement({
|
||||
id: "cover",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 80,
|
||||
height: 80,
|
||||
backgroundColor: "#ffc9c9",
|
||||
});
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 100,
|
||||
y: 20,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
API.setElements([frameChild, frame, cover]);
|
||||
API.setSelectedElements([frameChild]);
|
||||
|
||||
mouse.downAt(
|
||||
frameChild.x + frameChild.width / 2,
|
||||
frameChild.y + frameChild.height / 2,
|
||||
);
|
||||
mouse.moveTo(20, 20);
|
||||
|
||||
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||
|
||||
mouse.upAt(20, 20);
|
||||
|
||||
expect(frameChild.frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it.skip("should drag element inside, duplicate it and keep it in frame", () => {
|
||||
API.setElements([frame, rect2]);
|
||||
|
||||
|
||||
@@ -101,6 +101,7 @@ export const actionDeselect = register({
|
||||
selectionElement: null,
|
||||
showHyperlinkPopup: false,
|
||||
suggestedBinding: null,
|
||||
frameToHighlight: null,
|
||||
},
|
||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||
};
|
||||
@@ -118,6 +119,7 @@ export const actionDeselect = register({
|
||||
selectionElement: null,
|
||||
showHyperlinkPopup: false,
|
||||
suggestedBinding: null,
|
||||
frameToHighlight: null,
|
||||
},
|
||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||
};
|
||||
|
||||
@@ -14,6 +14,8 @@ import {
|
||||
isLineElement,
|
||||
} from "@excalidraw/element";
|
||||
|
||||
import { invalidateFreeDrawIncrementalCanvas } from "@excalidraw/element";
|
||||
|
||||
import {
|
||||
KEYS,
|
||||
arrayToMap,
|
||||
@@ -313,6 +315,10 @@ export const actionFinalize = register<FormData>({
|
||||
}
|
||||
: selectedLinearElement;
|
||||
|
||||
if (element && isFreeDrawElement(element)) {
|
||||
invalidateFreeDrawIncrementalCanvas(element);
|
||||
}
|
||||
|
||||
return {
|
||||
elements: newElements,
|
||||
appState: {
|
||||
@@ -330,6 +336,7 @@ export const actionFinalize = register<FormData>({
|
||||
multiElement: null,
|
||||
editingTextElement: null,
|
||||
suggestedBinding: null,
|
||||
frameToHighlight: null,
|
||||
selectedElementIds:
|
||||
element &&
|
||||
!appState.activeTool.locked &&
|
||||
|
||||
@@ -205,7 +205,6 @@ export const actionWrapSelectionInFrame = register({
|
||||
[...app.scene.getElementsIncludingDeleted(), frame],
|
||||
selectedElements,
|
||||
frame,
|
||||
appState,
|
||||
);
|
||||
|
||||
return {
|
||||
|
||||
@@ -277,7 +277,6 @@ export const actionUngroup = register({
|
||||
elementsMap,
|
||||
),
|
||||
frame,
|
||||
app,
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
import {
|
||||
isWindows,
|
||||
KEYS,
|
||||
matchKey,
|
||||
arrayToMap,
|
||||
@@ -114,7 +113,7 @@ export const createRedoAction: ActionCreator = (history) => ({
|
||||
),
|
||||
keyTest: (event) =>
|
||||
(event[KEYS.CTRL_OR_CMD] && event.shiftKey && matchKey(event, KEYS.Z)) ||
|
||||
(isWindows && event.ctrlKey && !event.shiftKey && matchKey(event, KEYS.Y)),
|
||||
(event[KEYS.CTRL_OR_CMD] && !event.shiftKey && matchKey(event, KEYS.Y)),
|
||||
PanelComponent: ({ appState, updateData, data, app }) => {
|
||||
const { isRedoStackEmpty } = useEmitter(
|
||||
history.onHistoryChangedEmitter,
|
||||
|
||||
@@ -1,3 +1,5 @@
|
||||
import clsx from "clsx";
|
||||
|
||||
import { pointFrom } from "@excalidraw/math";
|
||||
|
||||
import { useEffect, useMemo, useRef, useState } from "react";
|
||||
@@ -47,6 +49,7 @@ import {
|
||||
isArrowElement,
|
||||
isBoundToContainer,
|
||||
isElbowArrow,
|
||||
isFreeDrawElement,
|
||||
isLinearElement,
|
||||
isLineElement,
|
||||
isTextElement,
|
||||
@@ -131,6 +134,8 @@ import {
|
||||
ArrowheadCardinalityOneOrManyIcon,
|
||||
ArrowheadCardinalityZeroOrManyIcon,
|
||||
ArrowheadCardinalityZeroOrOneIcon,
|
||||
FreedrawPressureConstantIcon,
|
||||
FreedrawPressureSensitiveIcon,
|
||||
} from "../components/icons";
|
||||
|
||||
import { Fonts } from "../fonts";
|
||||
@@ -2041,3 +2046,89 @@ export const actionChangeArrowType = register<keyof typeof ARROW_TYPE>({
|
||||
);
|
||||
},
|
||||
});
|
||||
|
||||
export const actionChangeStrokeShape = register<boolean>({
|
||||
name: "changeStrokeShape",
|
||||
label: "labels.strokeShape",
|
||||
trackEvent: false,
|
||||
perform: (elements, appState, value) => {
|
||||
return {
|
||||
elements: changeProperty(elements, appState, (el) => {
|
||||
if (isFreeDrawElement(el)) {
|
||||
return newElementWith(el, {
|
||||
simulatePressure: value,
|
||||
});
|
||||
}
|
||||
return el;
|
||||
}),
|
||||
appState: { ...appState, currentItemFreedrawConstantPressure: value },
|
||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||
};
|
||||
},
|
||||
PanelComponent: ({ elements, appState, updateData, app }) => {
|
||||
const { isCompact } = getStylesPanelInfo(app);
|
||||
|
||||
const currentValue = getFormValue(
|
||||
elements,
|
||||
app,
|
||||
(element) => {
|
||||
if (isFreeDrawElement(element)) {
|
||||
return element.simulatePressure;
|
||||
}
|
||||
return null;
|
||||
},
|
||||
(element) => isFreeDrawElement(element),
|
||||
(hasSelection) =>
|
||||
hasSelection ? null : appState.currentItemFreedrawConstantPressure,
|
||||
);
|
||||
|
||||
if (isCompact) {
|
||||
const isConstantPressure = currentValue !== false;
|
||||
return (
|
||||
<button
|
||||
type="button"
|
||||
className={clsx("compact-action-button", {
|
||||
active: !isConstantPressure,
|
||||
})}
|
||||
title={
|
||||
isConstantPressure
|
||||
? t("labels.strokeShape_constant")
|
||||
: t("labels.strokeShape_pressure")
|
||||
}
|
||||
onClick={() => updateData(!isConstantPressure)}
|
||||
>
|
||||
{isConstantPressure
|
||||
? FreedrawPressureConstantIcon
|
||||
: FreedrawPressureSensitiveIcon}
|
||||
</button>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<fieldset>
|
||||
<legend>{t("labels.strokeShape")}</legend>
|
||||
<div className="buttonList">
|
||||
<RadioSelection
|
||||
group="stroke-shape"
|
||||
options={[
|
||||
{
|
||||
value: true,
|
||||
text: t("labels.strokeShape_constant"),
|
||||
icon: FreedrawPressureConstantIcon,
|
||||
testId: "strokeShape-constant",
|
||||
},
|
||||
{
|
||||
value: false,
|
||||
text: t("labels.strokeShape_pressure"),
|
||||
icon: FreedrawPressureSensitiveIcon,
|
||||
testId: "strokeShape-pressure",
|
||||
},
|
||||
]}
|
||||
value={currentValue}
|
||||
onChange={(value) => updateData(value)}
|
||||
/>
|
||||
</div>
|
||||
</fieldset>
|
||||
);
|
||||
},
|
||||
});
|
||||
|
||||
@@ -19,6 +19,7 @@ export {
|
||||
actionChangeTextAlign,
|
||||
actionChangeVerticalAlign,
|
||||
actionChangeArrowProperties,
|
||||
actionChangeStrokeShape,
|
||||
} from "./actionProperties";
|
||||
|
||||
export {
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
import { LaserPointer } from "@excalidraw/laser-pointer";
|
||||
|
||||
import {
|
||||
SVG_NS,
|
||||
getSvgPathFromStroke,
|
||||
@@ -8,7 +7,8 @@ import {
|
||||
|
||||
import type { LaserPointerOptions } from "@excalidraw/laser-pointer";
|
||||
|
||||
import type { AnimationFrameHandler } from "./animation-frame-handler";
|
||||
import { AnimationController } from "./renderer/animation";
|
||||
|
||||
import type App from "./components/App";
|
||||
import type { AppState } from "./types";
|
||||
|
||||
@@ -34,15 +34,16 @@ export class AnimatedTrail implements Trail {
|
||||
private container?: SVGSVGElement;
|
||||
private trailElement: SVGPathElement;
|
||||
private trailAnimation?: SVGAnimateElement;
|
||||
private key: string;
|
||||
|
||||
private static counter = 0;
|
||||
|
||||
constructor(
|
||||
private animationFrameHandler: AnimationFrameHandler,
|
||||
protected app: App,
|
||||
private options: Partial<LaserPointerOptions> &
|
||||
Partial<AnimatedTrailOptions>,
|
||||
) {
|
||||
this.animationFrameHandler.register(this, this.onFrame.bind(this));
|
||||
|
||||
this.key = `animated-trail-${AnimatedTrail.counter++}`;
|
||||
this.trailElement = document.createElementNS(SVG_NS, "path");
|
||||
if (this.options.animateTrail) {
|
||||
this.trailAnimation = document.createElementNS(SVG_NS, "animate");
|
||||
@@ -73,6 +74,15 @@ export class AnimatedTrail implements Trail {
|
||||
return false;
|
||||
}
|
||||
|
||||
private cleanup() {
|
||||
this.pastTrails = [];
|
||||
this.currentTrail = undefined;
|
||||
|
||||
if (this.trailElement.parentNode === this.container) {
|
||||
this.container?.removeChild(this.trailElement);
|
||||
}
|
||||
}
|
||||
|
||||
start(container?: SVGSVGElement) {
|
||||
if (container) {
|
||||
this.container = container;
|
||||
@@ -82,15 +92,23 @@ export class AnimatedTrail implements Trail {
|
||||
this.container.appendChild(this.trailElement);
|
||||
}
|
||||
|
||||
this.animationFrameHandler.start(this);
|
||||
if (!AnimationController.running(this.key)) {
|
||||
AnimationController.start(this.key, () => {
|
||||
const needsNext = this.onFrame();
|
||||
if (needsNext) {
|
||||
return { keep: true };
|
||||
}
|
||||
|
||||
this.cleanup();
|
||||
|
||||
return null;
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
stop() {
|
||||
this.animationFrameHandler.stop(this);
|
||||
|
||||
if (this.trailElement.parentNode === this.container) {
|
||||
this.container?.removeChild(this.trailElement);
|
||||
}
|
||||
AnimationController.cancel(this.key);
|
||||
this.cleanup();
|
||||
}
|
||||
|
||||
startPath(x: number, y: number) {
|
||||
@@ -145,21 +163,25 @@ export class AnimatedTrail implements Trail {
|
||||
|
||||
if (this.currentTrail) {
|
||||
const currentPath = this.drawTrail(this.currentTrail, this.app.state);
|
||||
|
||||
paths.push(currentPath);
|
||||
}
|
||||
|
||||
this.pastTrails = this.pastTrails.filter((trail) => {
|
||||
return trail.getStrokeOutline().length !== 0;
|
||||
});
|
||||
this.pastTrails = this.pastTrails.filter(
|
||||
(t) =>
|
||||
t.getStrokeOutline(t.options.size / this.app.state.zoom.value)
|
||||
.length !== 0,
|
||||
);
|
||||
|
||||
if (paths.length === 0) {
|
||||
this.stop();
|
||||
// Clean up the SVG path if there are no trails to render
|
||||
this.trailElement.setAttribute("d", "");
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
const svgPaths = paths.join(" ").trim();
|
||||
|
||||
this.trailElement.setAttribute("d", svgPaths);
|
||||
|
||||
if (this.trailAnimation) {
|
||||
this.trailElement.setAttribute(
|
||||
"fill",
|
||||
@@ -175,6 +197,8 @@ export class AnimatedTrail implements Trail {
|
||||
(this.options.fill ?? (() => "black"))(this),
|
||||
);
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
private drawTrail(trail: LaserPointer, state: AppState): string {
|
||||
@@ -1,79 +0,0 @@
|
||||
export type AnimationCallback = (timestamp: number) => void | boolean;
|
||||
|
||||
export type AnimationTarget = {
|
||||
callback: AnimationCallback;
|
||||
stopped: boolean;
|
||||
};
|
||||
|
||||
export class AnimationFrameHandler {
|
||||
private targets = new WeakMap<object, AnimationTarget>();
|
||||
private rafIds = new WeakMap<object, number>();
|
||||
|
||||
register(key: object, callback: AnimationCallback) {
|
||||
this.targets.set(key, { callback, stopped: true });
|
||||
}
|
||||
|
||||
start(key: object) {
|
||||
const target = this.targets.get(key);
|
||||
|
||||
if (!target) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (this.rafIds.has(key)) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.targets.set(key, { ...target, stopped: false });
|
||||
this.scheduleFrame(key);
|
||||
}
|
||||
|
||||
stop(key: object) {
|
||||
const target = this.targets.get(key);
|
||||
if (target && !target.stopped) {
|
||||
this.targets.set(key, { ...target, stopped: true });
|
||||
}
|
||||
|
||||
this.cancelFrame(key);
|
||||
}
|
||||
|
||||
private constructFrame(key: object): FrameRequestCallback {
|
||||
return (timestamp: number) => {
|
||||
const target = this.targets.get(key);
|
||||
|
||||
if (!target) {
|
||||
return;
|
||||
}
|
||||
|
||||
const shouldAbort = this.onFrame(target, timestamp);
|
||||
|
||||
if (!target.stopped && !shouldAbort) {
|
||||
this.scheduleFrame(key);
|
||||
} else {
|
||||
this.cancelFrame(key);
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
private scheduleFrame(key: object) {
|
||||
const rafId = requestAnimationFrame(this.constructFrame(key));
|
||||
|
||||
this.rafIds.set(key, rafId);
|
||||
}
|
||||
|
||||
private cancelFrame(key: object) {
|
||||
if (this.rafIds.has(key)) {
|
||||
const rafId = this.rafIds.get(key)!;
|
||||
|
||||
cancelAnimationFrame(rafId);
|
||||
}
|
||||
|
||||
this.rafIds.delete(key);
|
||||
}
|
||||
|
||||
private onFrame(target: AnimationTarget, timestamp: number): boolean {
|
||||
const shouldAbort = target.callback(timestamp);
|
||||
|
||||
return shouldAbort ?? false;
|
||||
}
|
||||
}
|
||||
@@ -40,6 +40,7 @@ export const getDefaultAppState = (): Omit<
|
||||
currentItemArrowType: ARROW_TYPE.round,
|
||||
currentItemStrokeStyle: DEFAULT_ELEMENT_PROPS.strokeStyle,
|
||||
currentItemStrokeWidth: DEFAULT_ELEMENT_PROPS.strokeWidth,
|
||||
currentItemFreedrawConstantPressure: true,
|
||||
currentItemTextAlign: DEFAULT_TEXT_ALIGN,
|
||||
currentHoveredFontFamily: null,
|
||||
cursorButton: "up",
|
||||
@@ -171,6 +172,11 @@ const APP_STATE_STORAGE_CONF = (<
|
||||
currentItemStrokeColor: { browser: true, export: false, server: false },
|
||||
currentItemStrokeStyle: { browser: true, export: false, server: false },
|
||||
currentItemStrokeWidth: { browser: true, export: false, server: false },
|
||||
currentItemFreedrawConstantPressure: {
|
||||
browser: true,
|
||||
export: false,
|
||||
server: false,
|
||||
},
|
||||
currentItemTextAlign: { browser: true, export: false, server: false },
|
||||
currentHoveredFontFamily: { browser: false, export: false, server: false },
|
||||
cursorButton: { browser: true, export: false, server: false },
|
||||
|
||||
@@ -834,6 +834,14 @@ export const CompactShapeActions = ({
|
||||
container={container}
|
||||
/>
|
||||
|
||||
{/* Stroke Shape Toggle (freedraw only) */}
|
||||
{(appState.activeTool.type === "freedraw" ||
|
||||
targetElements.some((element) => element.type === "freedraw")) && (
|
||||
<div className="compact-action-item">
|
||||
{renderAction("changeStrokeShape")}
|
||||
</div>
|
||||
)}
|
||||
|
||||
<CombinedArrowProperties
|
||||
appState={appState}
|
||||
renderAction={renderAction}
|
||||
@@ -969,6 +977,13 @@ export const MobileShapeActions = ({
|
||||
targetElements={targetElements}
|
||||
container={container}
|
||||
/>
|
||||
{/* Stroke Shape Toggle (freedraw only) */}
|
||||
{(appState.activeTool.type === "freedraw" ||
|
||||
targetElements.some((element) => element.type === "freedraw")) && (
|
||||
<div className="compact-action-item">
|
||||
{renderAction("changeStrokeShape")}
|
||||
</div>
|
||||
)}
|
||||
{/* Combined Arrow Properties */}
|
||||
<CombinedArrowProperties
|
||||
appState={appState}
|
||||
|
||||
@@ -28,7 +28,6 @@ import {
|
||||
APP_NAME,
|
||||
CURSOR_TYPE,
|
||||
DEFAULT_TRANSFORM_HANDLE_SPACING,
|
||||
DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT,
|
||||
DEFAULT_VERTICAL_ALIGN,
|
||||
DRAGGING_THRESHOLD,
|
||||
ELEMENT_SHIFT_TRANSLATE_AMOUNT,
|
||||
@@ -38,7 +37,6 @@ import {
|
||||
IMAGE_MIME_TYPES,
|
||||
IMAGE_RENDER_TIMEOUT,
|
||||
LINE_CONFIRM_THRESHOLD,
|
||||
MAX_ALLOWED_FILE_BYTES,
|
||||
MIME_TYPES,
|
||||
MQ_RIGHT_SIDEBAR_MIN_WIDTH,
|
||||
POINTER_BUTTON,
|
||||
@@ -176,7 +174,9 @@ import {
|
||||
isValidTextContainer,
|
||||
redrawTextBoundingBox,
|
||||
hasBoundingBox,
|
||||
getCommonFrameId,
|
||||
getFrameChildren,
|
||||
getFrameChildrenInsertionIndex,
|
||||
isCursorInFrame,
|
||||
addElementsToFrame,
|
||||
replaceAllElementsInFrame,
|
||||
@@ -259,6 +259,7 @@ import {
|
||||
maybeHandleArrowPointlikeDrag,
|
||||
getUncroppedWidthAndHeight,
|
||||
getActiveTextElement,
|
||||
isEligibleFrameChildType,
|
||||
} from "@excalidraw/element";
|
||||
|
||||
import type { GlobalPoint, LocalPoint, Radians } from "@excalidraw/math";
|
||||
@@ -342,7 +343,6 @@ import { ActionManager } from "../actions/manager";
|
||||
import { actions } from "../actions/register";
|
||||
import { getShortcutFromShortcutName } from "../actions/shortcuts";
|
||||
import { trackEvent } from "../analytics";
|
||||
import { AnimationFrameHandler } from "../animation-frame-handler";
|
||||
import {
|
||||
getDefaultAppState,
|
||||
isEraserActive,
|
||||
@@ -416,7 +416,7 @@ import {
|
||||
setCursorForShape,
|
||||
} from "../cursor";
|
||||
import { ElementCanvasButtons } from "../components/ElementCanvasButtons";
|
||||
import { LaserTrails } from "../laser-trails";
|
||||
import { LaserTrails } from "../laserTrails";
|
||||
import { withBatchedUpdates, withBatchedUpdatesThrottled } from "../reactUtils";
|
||||
import { isPointHittingTextAutoResizeHandle } from "../textAutoResizeHandle";
|
||||
import { textWysiwyg } from "../wysiwyg/textWysiwyg";
|
||||
@@ -702,11 +702,9 @@ class App extends React.Component<AppProps, AppState> {
|
||||
previousPointerMoveCoords: { x: number; y: number } | null = null;
|
||||
lastViewportPosition = { x: 0, y: 0 };
|
||||
|
||||
animationFrameHandler = new AnimationFrameHandler();
|
||||
|
||||
laserTrails = new LaserTrails(this.animationFrameHandler, this);
|
||||
eraserTrail = new EraserTrail(this.animationFrameHandler, this);
|
||||
lassoTrail = new LassoTrail(this.animationFrameHandler, this);
|
||||
laserTrails = new LaserTrails(this);
|
||||
eraserTrail = new EraserTrail(this);
|
||||
lassoTrail = new LassoTrail(this);
|
||||
|
||||
onChangeEmitter = new Emitter<
|
||||
[
|
||||
@@ -1997,9 +1995,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
}}
|
||||
style={{
|
||||
background: isDarkTheme
|
||||
? applyDarkModeFilter(this.state.viewBackgroundColor)
|
||||
: this.state.viewBackgroundColor,
|
||||
background: applyDarkModeFilter(
|
||||
this.state.viewBackgroundColor,
|
||||
isDarkTheme,
|
||||
),
|
||||
zIndex: 2,
|
||||
border: "none",
|
||||
display: "block",
|
||||
@@ -2092,20 +2091,30 @@ class App extends React.Component<AppProps, AppState> {
|
||||
const selectedElements = this.scene.getSelectedElements(this.state);
|
||||
const { renderTopRightUI, renderTopLeftUI, renderCustomStats } = this.props;
|
||||
|
||||
const sceneNonce = this.scene.getSceneNonce();
|
||||
const { elementsMap, visibleElements } =
|
||||
this.renderer.getRenderableElements({
|
||||
sceneNonce,
|
||||
zoom: this.state.zoom,
|
||||
offsetLeft: this.state.offsetLeft,
|
||||
offsetTop: this.state.offsetTop,
|
||||
scrollX: this.state.scrollX,
|
||||
scrollY: this.state.scrollY,
|
||||
height: this.state.height,
|
||||
width: this.state.width,
|
||||
editingTextElement: this.state.editingTextElement,
|
||||
newElementId: this.state.newElement?.id,
|
||||
});
|
||||
const {
|
||||
elementsMap,
|
||||
visibleElements,
|
||||
canvasNonce,
|
||||
/**
|
||||
* element to draw on the <NewElementCanvas> for optimization purposes.
|
||||
* Can be null even if this.state.newElement defined
|
||||
* (e.g. when its zIndex isn't on top) */
|
||||
newElementCanvasElement,
|
||||
} = this.renderer.getRenderableElements({
|
||||
zoom: this.state.zoom,
|
||||
offsetLeft: this.state.offsetLeft,
|
||||
offsetTop: this.state.offsetTop,
|
||||
scrollX: this.state.scrollX,
|
||||
scrollY: this.state.scrollY,
|
||||
height: this.state.height,
|
||||
width: this.state.width,
|
||||
editingTextElement: this.state.editingTextElement,
|
||||
newElement: this.state.newElement,
|
||||
selectedElements,
|
||||
selectedElementsAreBeingDragged:
|
||||
this.state.selectedElementsAreBeingDragged,
|
||||
frameToHighlight: this.state.frameToHighlight,
|
||||
});
|
||||
this.visibleElements = visibleElements;
|
||||
|
||||
const allElementsMap = this.scene.getNonDeletedElementsMap();
|
||||
@@ -2324,7 +2333,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
elementsMap={elementsMap}
|
||||
allElementsMap={allElementsMap}
|
||||
visibleElements={visibleElements}
|
||||
sceneNonce={sceneNonce}
|
||||
canvasNonce={canvasNonce}
|
||||
selectionNonce={
|
||||
this.state.selectionElement?.versionNonce
|
||||
}
|
||||
@@ -2345,9 +2354,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
theme: this.state.theme,
|
||||
}}
|
||||
/>
|
||||
{this.state.newElement && (
|
||||
{newElementCanvasElement && (
|
||||
<NewElementCanvas
|
||||
appState={this.state}
|
||||
newElement={newElementCanvasElement}
|
||||
scale={window.devicePixelRatio}
|
||||
rc={this.rc}
|
||||
elementsMap={elementsMap}
|
||||
@@ -2375,7 +2385,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
visibleElements={visibleElements}
|
||||
allElementsMap={allElementsMap}
|
||||
selectedElements={selectedElements}
|
||||
sceneNonce={sceneNonce}
|
||||
canvasNonce={canvasNonce}
|
||||
selectionNonce={
|
||||
this.state.selectionElement?.versionNonce
|
||||
}
|
||||
@@ -2687,7 +2697,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
locked: false,
|
||||
});
|
||||
|
||||
this.scene.insertElement(frame);
|
||||
this.insertNewElement(frame);
|
||||
|
||||
for (const child of selectedElements) {
|
||||
this.scene.mutateElement(child, { frameId: frame.id });
|
||||
@@ -3765,6 +3775,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
position:
|
||||
this.editorInterface.formFactor === "desktop" ? "cursor" : "center",
|
||||
retainSeed: isPlainPaste,
|
||||
preserveFrameChildrenOrder: true,
|
||||
});
|
||||
return;
|
||||
}
|
||||
@@ -3908,6 +3919,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
position: { clientX: number; clientY: number } | "cursor" | "center";
|
||||
retainSeed?: boolean;
|
||||
fitToContent?: boolean;
|
||||
preserveFrameChildrenOrder?: boolean;
|
||||
}) => {
|
||||
const elements = restoreElements(opts.elements, null, {
|
||||
deleteInvisibleElements: true,
|
||||
@@ -3949,6 +3961,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
});
|
||||
}),
|
||||
randomizeSeed: !opts.retainSeed,
|
||||
preserveFrameChildrenOrder: opts.preserveFrameChildrenOrder,
|
||||
});
|
||||
|
||||
const prevElements = this.scene.getElementsIncludingDeleted();
|
||||
@@ -3970,11 +3983,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
duplicatedElements,
|
||||
topLayerFrame,
|
||||
);
|
||||
addElementsToFrame(
|
||||
nextElements = addElementsToFrame(
|
||||
nextElements,
|
||||
eligibleElements,
|
||||
topLayerFrame,
|
||||
this.state,
|
||||
);
|
||||
}
|
||||
|
||||
@@ -4200,7 +4212,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
return;
|
||||
}
|
||||
|
||||
this.scene.insertElements(textElements);
|
||||
this.insertNewElements(textElements);
|
||||
this.store.scheduleCapture();
|
||||
this.setState({
|
||||
selectedElementIds: makeNextSelectedElementIds(
|
||||
@@ -4601,6 +4613,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
|
||||
if (collaborators) {
|
||||
this.laserTrails.updateCollabTrails(collaborators);
|
||||
this.setState({ collaborators });
|
||||
}
|
||||
},
|
||||
@@ -5456,7 +5469,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
if (!event[KEYS.CTRL_OR_CMD]) {
|
||||
if (this.flowChartCreator.isCreatingChart) {
|
||||
if (this.flowChartCreator.pendingNodes?.length) {
|
||||
this.scene.insertElements(this.flowChartCreator.pendingNodes);
|
||||
this.insertNewElements(this.flowChartCreator.pendingNodes);
|
||||
}
|
||||
|
||||
const firstNode = this.flowChartCreator.pendingNodes?.[0];
|
||||
@@ -5554,6 +5567,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
selectedLinearElement: isSelectionLikeTool(nextActiveTool.type)
|
||||
? prevState.selectedLinearElement
|
||||
: null,
|
||||
frameToHighlight: null,
|
||||
} as const;
|
||||
|
||||
if (nextActiveTool.type === "freedraw") {
|
||||
@@ -6151,6 +6165,12 @@ class App extends React.Component<AppProps, AppState> {
|
||||
hitElement = elements[index];
|
||||
break;
|
||||
} else if (x1 < x && x < x2 && y1 < y && y < y2) {
|
||||
// to allow binding to containers within frames,
|
||||
// ignore frames in hit testing
|
||||
if (isFrameLikeElement(elements[index])) {
|
||||
continue;
|
||||
}
|
||||
|
||||
hitElement = elements[index];
|
||||
break;
|
||||
}
|
||||
@@ -6240,11 +6260,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
}
|
||||
|
||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords({
|
||||
x: sceneX,
|
||||
y: sceneY,
|
||||
});
|
||||
|
||||
const textCreationGridPoint = this.getTextCreationGridPoint(sceneX, sceneY);
|
||||
|
||||
const newTextElementPosition = parentCenterPosition
|
||||
@@ -6266,6 +6281,20 @@ class App extends React.Component<AppProps, AppState> {
|
||||
y: sceneY,
|
||||
};
|
||||
|
||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords({
|
||||
x: newTextElementPosition.x,
|
||||
y: newTextElementPosition.y,
|
||||
});
|
||||
|
||||
// container has higher priority. Only add to frame if container is in the same frame.
|
||||
const frameId =
|
||||
topLayerFrame &&
|
||||
(!shouldBindToContainer ||
|
||||
!container ||
|
||||
container.frameId === topLayerFrame.id)
|
||||
? topLayerFrame.id
|
||||
: null;
|
||||
|
||||
const element =
|
||||
existingTextElement ||
|
||||
newTextElement({
|
||||
@@ -6295,7 +6324,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
? (0 as Radians)
|
||||
: container.angle
|
||||
: (0 as Radians),
|
||||
frameId: topLayerFrame ? topLayerFrame.id : null,
|
||||
frameId,
|
||||
});
|
||||
|
||||
if (!existingTextElement && shouldBindToContainer && container) {
|
||||
@@ -6311,9 +6340,12 @@ class App extends React.Component<AppProps, AppState> {
|
||||
if (!existingTextElement) {
|
||||
if (container && shouldBindToContainer) {
|
||||
const containerIndex = this.scene.getElementIndex(container.id);
|
||||
this.scene.insertElementAtIndex(element, containerIndex + 1);
|
||||
// TODO should use insertNewElement, after we update it to handle
|
||||
// elements with containerId + frameId at the same time (containerId
|
||||
// should take precedence when it comes to z-index)
|
||||
this.scene.insertElementsAtIndex([element], containerIndex + 1);
|
||||
} else {
|
||||
this.scene.insertElement(element);
|
||||
this.insertNewElement(element);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -6695,19 +6727,161 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
};
|
||||
|
||||
private getTopLayerFrameAtSceneCoords = (sceneCoords: {
|
||||
x: number;
|
||||
y: number;
|
||||
}) => {
|
||||
/**
|
||||
* finds candidate frame under cursor (when dragging frame children/elements
|
||||
* inside frames)
|
||||
*/
|
||||
private getTopLayerFrameAtSceneCoords = (
|
||||
/**
|
||||
* should be already grid aligned (basically should be what the call site
|
||||
* sets the element's coords to, if applicable)
|
||||
*/
|
||||
sceneCoords: {
|
||||
x: number;
|
||||
y: number;
|
||||
},
|
||||
opts?: {
|
||||
/** to exclude selected elements when dragging, etc. */
|
||||
excludeElementIds?: AppState["selectedElementIds"];
|
||||
currentFrameId?: ExcalidrawElement["frameId"];
|
||||
},
|
||||
) => {
|
||||
const elementsMap = this.scene.getNonDeletedElementsMap();
|
||||
const frames = this.scene
|
||||
const framesUnderCursor = this.scene
|
||||
.getNonDeletedFramesLikes()
|
||||
.filter(
|
||||
(frame): frame is ExcalidrawFrameLikeElement =>
|
||||
!frame.locked && isCursorInFrame(sceneCoords, frame, elementsMap),
|
||||
);
|
||||
|
||||
return frames.length ? frames[frames.length - 1] : null;
|
||||
if (!framesUnderCursor.length) {
|
||||
return null;
|
||||
}
|
||||
|
||||
const topLayerFrame = framesUnderCursor.at(-1)!;
|
||||
|
||||
const hitElement = this.getElementsAtPosition(
|
||||
sceneCoords.x,
|
||||
sceneCoords.y,
|
||||
{
|
||||
includeLockedElements: true,
|
||||
},
|
||||
).findLast((element) => !opts?.excludeElementIds?.[element.id]);
|
||||
|
||||
if (hitElement) {
|
||||
if (
|
||||
isFrameLikeElement(hitElement) &&
|
||||
// case: we're hitting a locked frame itself (frame's outline
|
||||
// or later its bg once implemented)
|
||||
!hitElement.locked
|
||||
) {
|
||||
return topLayerFrame;
|
||||
}
|
||||
|
||||
const hitElementIndex = this.scene.getElementIndex(hitElement.id);
|
||||
const topLayerFrameIndex = this.scene.getElementIndex(topLayerFrame.id);
|
||||
|
||||
if (
|
||||
hitElementIndex !== -1 &&
|
||||
topLayerFrameIndex !== -1 &&
|
||||
hitElementIndex <= topLayerFrameIndex
|
||||
) {
|
||||
return topLayerFrame;
|
||||
}
|
||||
|
||||
// to support a case of dragging a pre-existing frame child underneath
|
||||
// a non-frame element covering the cursor
|
||||
const currentFrame = opts?.currentFrameId
|
||||
? framesUnderCursor.find((frame) => frame.id === opts.currentFrameId) ??
|
||||
null
|
||||
: null;
|
||||
|
||||
if (currentFrame) {
|
||||
return currentFrame;
|
||||
}
|
||||
|
||||
return hitElement.frameId
|
||||
? framesUnderCursor.find((frame) => frame.id === hitElement.frameId) ??
|
||||
null
|
||||
: null;
|
||||
}
|
||||
|
||||
return topLayerFrame;
|
||||
};
|
||||
|
||||
private updateFrameToHighlight = (
|
||||
frameToHighlight: AppState["frameToHighlight"],
|
||||
) => {
|
||||
if (this.state.frameToHighlight !== frameToHighlight) {
|
||||
this.setState({ frameToHighlight });
|
||||
}
|
||||
};
|
||||
|
||||
private maybeUpdateFrameToHighlightOnPointerMove = (
|
||||
sceneCoords: { x: number; y: number },
|
||||
isOverScrollBar: boolean,
|
||||
) => {
|
||||
// currently this function is being called even during pointerdown so we
|
||||
// need to make sure we don't re-set the state when dragging and similar
|
||||
//
|
||||
// But, we still want to reset on pointermove in case the state is stale
|
||||
// so we updte even for non-eligible tool types
|
||||
if (
|
||||
this.state.newElement ||
|
||||
this.state.multiElement ||
|
||||
this.state.selectionElement ||
|
||||
this.state.selectedElementsAreBeingDragged
|
||||
) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.updateFrameToHighlight(
|
||||
!isOverScrollBar && isEligibleFrameChildType(this.state.activeTool.type)
|
||||
? this.getTopLayerFrameAtSceneCoords(sceneCoords)
|
||||
: null,
|
||||
);
|
||||
};
|
||||
|
||||
private insertNewElements = (elements: readonly ExcalidrawElement[]) => {
|
||||
if (!elements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
const chunkedElements: ExcalidrawElement[][] = [];
|
||||
|
||||
for (const element of elements) {
|
||||
const currentChunk = chunkedElements[chunkedElements.length - 1];
|
||||
|
||||
if (currentChunk?.[0].frameId === element.frameId) {
|
||||
currentChunk.push(element);
|
||||
} else {
|
||||
chunkedElements.push([element]);
|
||||
}
|
||||
}
|
||||
|
||||
for (const chunk of chunkedElements) {
|
||||
const frameId = chunk[0].frameId;
|
||||
|
||||
const insertionIndex = frameId
|
||||
? getFrameChildrenInsertionIndex(
|
||||
this.scene.getElementsIncludingDeleted(),
|
||||
frameId,
|
||||
)
|
||||
: null;
|
||||
this.scene.insertElementsAtIndex(chunk, insertionIndex);
|
||||
}
|
||||
};
|
||||
|
||||
private insertNewElement = (element: ExcalidrawElement) => {
|
||||
this.insertNewElements([element]);
|
||||
|
||||
const frame = element.frameId
|
||||
? this.scene.getNonDeletedElement(element.frameId)
|
||||
: null;
|
||||
|
||||
this.updateFrameToHighlight(
|
||||
frame && isFrameLikeElement(frame) ? frame : null,
|
||||
);
|
||||
};
|
||||
|
||||
private handleCanvasPointerMove = (
|
||||
@@ -6809,6 +6983,14 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
}
|
||||
|
||||
this.maybeUpdateFrameToHighlightOnPointerMove(
|
||||
{
|
||||
x: scenePointerX,
|
||||
y: scenePointerY,
|
||||
},
|
||||
isOverScrollBar,
|
||||
);
|
||||
|
||||
if (
|
||||
!this.state.newElement &&
|
||||
isActiveToolNonLinearSnappable(this.state.activeTool.type)
|
||||
@@ -8842,7 +9024,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
y: gridY,
|
||||
});
|
||||
|
||||
const simulatePressure = event.pressure === 0.5;
|
||||
const simulatePressure = this.state.currentItemFreedrawConstantPressure;
|
||||
|
||||
const element = newFreeDrawElement({
|
||||
type: elementType,
|
||||
@@ -8860,10 +9042,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
locked: false,
|
||||
frameId: topLayerFrame ? topLayerFrame.id : null,
|
||||
points: [pointFrom<LocalPoint>(0, 0)],
|
||||
pressures: simulatePressure ? [] : [event.pressure],
|
||||
pressures: [event.pressure],
|
||||
});
|
||||
|
||||
this.scene.insertElement(element);
|
||||
this.insertNewElement(element);
|
||||
|
||||
this.setState((prevState) => {
|
||||
const nextSelectedElementIds = {
|
||||
@@ -8920,7 +9102,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
height,
|
||||
});
|
||||
|
||||
this.scene.insertElement(element);
|
||||
this.insertNewElement(element);
|
||||
|
||||
return element;
|
||||
};
|
||||
@@ -8974,7 +9156,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
link,
|
||||
});
|
||||
|
||||
this.scene.insertElement(element);
|
||||
this.insertNewElement(element);
|
||||
|
||||
return element;
|
||||
};
|
||||
@@ -9218,7 +9400,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
points: [pointFrom<LocalPoint>(0, 0), pointFrom<LocalPoint>(0, 0)],
|
||||
});
|
||||
|
||||
this.scene.insertElement(element);
|
||||
this.insertNewElement(element);
|
||||
|
||||
if (isBindingElement(element)) {
|
||||
// Do the initial binding so the binding strategy has the initial state
|
||||
@@ -9376,7 +9558,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
selectionElement: element,
|
||||
});
|
||||
} else {
|
||||
this.scene.insertElement(element);
|
||||
this.insertNewElement(element);
|
||||
this.setState({
|
||||
multiElement: null,
|
||||
newElement: element,
|
||||
@@ -9409,7 +9591,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
? newMagicFrameElement(constructorOpts)
|
||||
: newFrameElement(constructorOpts);
|
||||
|
||||
this.scene.insertElement(frame);
|
||||
this.insertNewElement(frame);
|
||||
|
||||
this.setState({
|
||||
multiElement: null,
|
||||
@@ -9489,10 +9671,61 @@ class App extends React.Component<AppProps, AppState> {
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the timestamp of a pointer event, in milliseconds.
|
||||
* Extracted as a method so tests can spy on it and return a fixed value,
|
||||
* making the One Euro Filter in the freedraw handler deterministic.
|
||||
*/
|
||||
protected getPointerEventTimestamp(
|
||||
ev: Pick<PointerEvent, "timeStamp">,
|
||||
): number {
|
||||
return ev.timeStamp;
|
||||
}
|
||||
|
||||
private onPointerMoveFromPointerDownHandler(
|
||||
pointerDownState: PointerDownState,
|
||||
) {
|
||||
return withBatchedUpdatesThrottled((event: PointerEvent) => {
|
||||
// Per-stroke One Euro Filter state for mouse freedraw smoothing.
|
||||
// Reference: Casiez et al. 2012 "1€ Filter: A Simple Speed-based Low-pass
|
||||
// Filter for Noisy Input in Interactive Systems".
|
||||
//
|
||||
// The filter adapts its EMA alpha to the current speed of the pointer:
|
||||
// slow movement → low cutoff → heavy smoothing (removes jitter)
|
||||
// fast movement → high cutoff → near-raw tracking (minimal lag)
|
||||
//
|
||||
// State variables (reset at stroke start via null sentinel):
|
||||
let emaX: number | null = null; // smoothed position x
|
||||
let emaY: number | null = null; // smoothed position y
|
||||
let emaDx = 0; // smoothed derivative x
|
||||
let emaDy = 0; // smoothed derivative y
|
||||
let prevRawX: number | null = null; // previous raw x for derivative
|
||||
let prevRawY: number | null = null;
|
||||
let prevTs: number | null = null; // previous event timestamp (ms)
|
||||
|
||||
// Pen pressure warmup: the first few samples from a pen digitizer are
|
||||
// unreliable (often spike to ~0.5). We apply an EMA whose alpha ramps
|
||||
// from PEN_PRESSURE_INITIAL_ALPHA up to 1 over PEN_PRESSURE_WARMUP_SAMPLES
|
||||
// so the stroke gradually eases from heavy smoothing into raw pressure.
|
||||
let penPressureEma: number | null = null;
|
||||
let penPressureSampleCount = 0;
|
||||
const PEN_PRESSURE_WARMUP_SAMPLES = 20;
|
||||
const PEN_PRESSURE_INITIAL_ALPHA = 0.1;
|
||||
|
||||
// Tuning constants:
|
||||
// MIN_CUTOFF – cutoff frequency (Hz) when speed ≈ 0; smaller = more smoothing
|
||||
// BETA – rate at which cutoff grows with speed; larger = quicker adaptation
|
||||
// D_CUTOFF – fixed cutoff for the derivative pre-filter
|
||||
const MIN_CUTOFF = 0.5;
|
||||
const BETA = 0.01;
|
||||
const D_CUTOFF = 2.0;
|
||||
|
||||
/** Compute EMA alpha from cutoff frequency (Hz) and timestep (seconds). */
|
||||
const emaAlpha = (cutoff: number, dt: number): number => {
|
||||
const tau = 1 / (2 * Math.PI * cutoff);
|
||||
return 1 / (1 + tau / dt);
|
||||
};
|
||||
|
||||
const handler = (event: PointerEvent) => {
|
||||
if (this.state.openDialog?.name === "elementLinkSelector") {
|
||||
return;
|
||||
}
|
||||
@@ -9777,18 +10010,17 @@ class App extends React.Component<AppProps, AppState> {
|
||||
return;
|
||||
}
|
||||
|
||||
const selectedElementsHasAFrame = selectedElements.find((e) =>
|
||||
const selectedElementsHasAFrame = selectedElements.some((e) =>
|
||||
isFrameLikeElement(e),
|
||||
);
|
||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(pointerCoords);
|
||||
const frameToHighlight =
|
||||
topLayerFrame && !selectedElementsHasAFrame ? topLayerFrame : null;
|
||||
const frameToHighlight = selectedElementsHasAFrame
|
||||
? null
|
||||
: this.getTopLayerFrameAtSceneCoords(pointerCoords, {
|
||||
currentFrameId: getCommonFrameId(selectedElements),
|
||||
excludeElementIds: this.state.selectedElementIds,
|
||||
});
|
||||
// Only update the state if there is a difference
|
||||
if (this.state.frameToHighlight !== frameToHighlight) {
|
||||
flushSync(() => {
|
||||
this.setState({ frameToHighlight });
|
||||
});
|
||||
}
|
||||
this.updateFrameToHighlight(frameToHighlight);
|
||||
|
||||
// Marking that click was used for dragging to check
|
||||
// if elements should be deselected on pointerup
|
||||
@@ -10185,23 +10417,98 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
|
||||
if (newElement.type === "freedraw") {
|
||||
const points = newElement.points;
|
||||
const dx = pointerCoords.x - newElement.x;
|
||||
const dy = pointerCoords.y - newElement.y;
|
||||
const coalescedEvents: PointerEvent[] =
|
||||
event.getCoalescedEvents?.() ?? [];
|
||||
const allEvents =
|
||||
coalescedEvents.length > 0 ? coalescedEvents : [event];
|
||||
const newPoints: LocalPoint[] = [];
|
||||
const newPressures: number[] = [];
|
||||
|
||||
const lastPoint = points.length > 0 && points[points.length - 1];
|
||||
const discardPoint =
|
||||
lastPoint && lastPoint[0] === dx && lastPoint[1] === dy;
|
||||
let lastPoint =
|
||||
newElement.points.length > 0
|
||||
? newElement.points[newElement.points.length - 1]
|
||||
: null;
|
||||
|
||||
if (!discardPoint) {
|
||||
const pressures = newElement.simulatePressure
|
||||
? newElement.pressures
|
||||
: [...newElement.pressures, event.pressure];
|
||||
for (const ev of allEvents) {
|
||||
const coords = viewportCoordsToSceneCoords(ev, this.state);
|
||||
const rawDx = coords.x - newElement.x;
|
||||
const rawDy = coords.y - newElement.y;
|
||||
let dx = rawDx;
|
||||
let dy = rawDy;
|
||||
|
||||
if (event.pointerType === "mouse") {
|
||||
// One Euro Filter: speed-adaptive low-pass for mouse events.
|
||||
const evTs = this.getPointerEventTimestamp(ev);
|
||||
const dt = Math.max(
|
||||
prevTs !== null ? (evTs - prevTs) / 1000 : 1 / 60,
|
||||
0.001,
|
||||
); // seconds
|
||||
|
||||
// 1. Smooth the derivative (fixed D_CUTOFF pre-filter).
|
||||
const alphaD = emaAlpha(D_CUTOFF, dt);
|
||||
const rawDxDt = prevRawX !== null ? (rawDx - prevRawX) / dt : 0;
|
||||
const rawDyDt = prevRawY !== null ? (rawDy - prevRawY) / dt : 0;
|
||||
emaDx = alphaD * rawDxDt + (1 - alphaD) * emaDx;
|
||||
emaDy = alphaD * rawDyDt + (1 - alphaD) * emaDy;
|
||||
|
||||
// 2. Adaptive cutoff: higher speed → higher cutoff → less lag.
|
||||
// Normalize to screen-space pixels/sec so BETA behaves the same
|
||||
// regardless of zoom level (scene units are 1/zoom px at high zoom).
|
||||
const speed =
|
||||
Math.sqrt(emaDx * emaDx + emaDy * emaDy) *
|
||||
this.state.zoom.value;
|
||||
const cutoff = MIN_CUTOFF + BETA * speed;
|
||||
const alphaP = emaAlpha(cutoff, dt);
|
||||
|
||||
// 3. Smooth position with adaptive alpha.
|
||||
emaX =
|
||||
emaX === null ? rawDx : alphaP * rawDx + (1 - alphaP) * emaX;
|
||||
emaY =
|
||||
emaY === null ? rawDy : alphaP * rawDy + (1 - alphaP) * emaY;
|
||||
|
||||
prevRawX = rawDx;
|
||||
prevRawY = rawDy;
|
||||
prevTs = evTs;
|
||||
|
||||
dx = emaX;
|
||||
dy = emaY;
|
||||
}
|
||||
|
||||
if (!lastPoint || lastPoint[0] !== dx || lastPoint[1] !== dy) {
|
||||
const pt = pointFrom<LocalPoint>(dx, dy);
|
||||
newPoints.push(pt);
|
||||
|
||||
let pressure = ev.pressure;
|
||||
if (event.pointerType === "pen") {
|
||||
// Gradually ease from aggressive smoothing into raw pressure to
|
||||
// suppress the unreliable spike at the start of a pen stroke.
|
||||
const progress = Math.min(
|
||||
1,
|
||||
penPressureSampleCount / PEN_PRESSURE_WARMUP_SAMPLES,
|
||||
);
|
||||
const alpha =
|
||||
PEN_PRESSURE_INITIAL_ALPHA +
|
||||
progress * (1 - PEN_PRESSURE_INITIAL_ALPHA);
|
||||
penPressureEma =
|
||||
penPressureEma === null
|
||||
? pressure
|
||||
: alpha * pressure + (1 - alpha) * penPressureEma;
|
||||
pressure = penPressureEma;
|
||||
penPressureSampleCount++;
|
||||
}
|
||||
|
||||
newPressures.push(pressure);
|
||||
lastPoint = pt;
|
||||
}
|
||||
}
|
||||
|
||||
if (newPoints.length > 0) {
|
||||
const pressures = [...newElement.pressures, ...newPressures];
|
||||
|
||||
this.scene.mutateElement(
|
||||
newElement,
|
||||
{
|
||||
points: [...points, pointFrom<LocalPoint>(dx, dy)],
|
||||
points: [...newElement.points, ...newPoints],
|
||||
pressures,
|
||||
},
|
||||
{
|
||||
@@ -10224,20 +10531,38 @@ class App extends React.Component<AppProps, AppState> {
|
||||
);
|
||||
|
||||
let linearElementEditor = this.state.selectedLinearElement;
|
||||
if (!linearElementEditor) {
|
||||
|
||||
if (
|
||||
!linearElementEditor ||
|
||||
linearElementEditor.elementId !== newElement.id
|
||||
) {
|
||||
linearElementEditor = new LinearElementEditor(
|
||||
newElement,
|
||||
this.scene.getNonDeletedElementsMap(),
|
||||
);
|
||||
}
|
||||
|
||||
const lastClickedPointOutOfBounds =
|
||||
linearElementEditor &&
|
||||
(linearElementEditor.initialState.lastClickedPoint < 0 ||
|
||||
linearElementEditor.initialState.lastClickedPoint >=
|
||||
points.length);
|
||||
if (lastClickedPointOutOfBounds) {
|
||||
console.warn(
|
||||
"Last clicked point is out of bounds. Attempting to fix it.",
|
||||
);
|
||||
linearElementEditor = {
|
||||
...linearElementEditor,
|
||||
selectedPointsIndices: [1],
|
||||
selectedPointsIndices: [points.length - 1],
|
||||
initialState: {
|
||||
...linearElementEditor.initialState,
|
||||
lastClickedPoint: 1,
|
||||
prevSelectedPointsIndices: null,
|
||||
lastClickedPoint: points.length - 1,
|
||||
},
|
||||
hoverPointIndex: points.length - 1,
|
||||
};
|
||||
}
|
||||
|
||||
this.setState({
|
||||
newElement,
|
||||
...LinearElementEditor.handlePointDragging(
|
||||
@@ -10359,7 +10684,23 @@ class App extends React.Component<AppProps, AppState> {
|
||||
});
|
||||
}
|
||||
}
|
||||
});
|
||||
};
|
||||
|
||||
// For freedraw, bypass RAF throttling so every pointer event is processed
|
||||
// synchronously. This preserves coalesced pointer events and eliminates
|
||||
// stroke lag on high-frequency stylus / pointer input.
|
||||
if (this.state.activeTool.type === "freedraw") {
|
||||
const immediate = withBatchedUpdates(handler);
|
||||
const result = immediate as typeof immediate & {
|
||||
flush(): void;
|
||||
cancel(): void;
|
||||
};
|
||||
result.flush = () => {};
|
||||
result.cancel = () => {};
|
||||
return result;
|
||||
}
|
||||
|
||||
return withBatchedUpdatesThrottled(handler);
|
||||
}
|
||||
|
||||
// Returns whether the pointer move happened over either scrollbar
|
||||
@@ -10650,9 +10991,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
dx += 0.0001;
|
||||
}
|
||||
|
||||
const pressures = newElement.simulatePressure
|
||||
? []
|
||||
: [...newElement.pressures, childEvent.pressure];
|
||||
const pressures = [...newElement.pressures, childEvent.pressure];
|
||||
|
||||
this.scene.mutateElement(newElement, {
|
||||
points: [...points, pointFrom<LocalPoint>(dx, dy)],
|
||||
@@ -10817,7 +11156,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.scene.getElementsMapIncludingDeleted(),
|
||||
elementsInsideFrame,
|
||||
newElement,
|
||||
this.state,
|
||||
),
|
||||
);
|
||||
}
|
||||
@@ -10877,9 +11215,14 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
} else {
|
||||
// update the relationships between selected elements and frames
|
||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(sceneCoords);
|
||||
|
||||
const selectedElements = this.scene.getSelectedElements(this.state);
|
||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(
|
||||
sceneCoords,
|
||||
{
|
||||
currentFrameId: getCommonFrameId(selectedElements),
|
||||
excludeElementIds: this.state.selectedElementIds,
|
||||
},
|
||||
);
|
||||
let nextElements = this.scene.getElementsMapIncludingDeleted();
|
||||
|
||||
const updateGroupIdsAfterEditingGroup = (
|
||||
@@ -10928,10 +11271,8 @@ class App extends React.Component<AppProps, AppState> {
|
||||
topLayerFrame &&
|
||||
!this.state.selectedElementIds[topLayerFrame.id]
|
||||
) {
|
||||
const elementsToAdd = selectedElements.filter(
|
||||
(element) =>
|
||||
element.frameId !== topLayerFrame.id &&
|
||||
isElementInFrame(element, nextElements, this.state),
|
||||
const elementsToAdd = selectedElements.filter((element) =>
|
||||
isElementInFrame(element, nextElements, this.state),
|
||||
);
|
||||
|
||||
if (this.state.editingGroupId) {
|
||||
@@ -10942,7 +11283,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
nextElements,
|
||||
elementsToAdd,
|
||||
topLayerFrame,
|
||||
this.state,
|
||||
);
|
||||
} else if (!topLayerFrame) {
|
||||
if (this.state.editingGroupId) {
|
||||
@@ -11004,7 +11344,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
elementsMap,
|
||||
),
|
||||
frame,
|
||||
this,
|
||||
);
|
||||
}
|
||||
|
||||
@@ -11519,9 +11858,11 @@ class App extends React.Component<AppProps, AppState> {
|
||||
|
||||
const existingFileData = this.files[fileId];
|
||||
if (!existingFileData?.dataURL) {
|
||||
const { maxWidthOrHeight, maxFileSizeBytes } = this.props.imageOptions;
|
||||
|
||||
try {
|
||||
imageFile = await resizeImageFile(imageFile, {
|
||||
maxWidthOrHeight: DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT,
|
||||
maxWidthOrHeight,
|
||||
});
|
||||
} catch (error: any) {
|
||||
console.error(
|
||||
@@ -11530,10 +11871,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
);
|
||||
}
|
||||
|
||||
if (imageFile.size > MAX_ALLOWED_FILE_BYTES) {
|
||||
if (imageFile.size > maxFileSizeBytes) {
|
||||
throw new Error(
|
||||
t("errors.fileTooBig", {
|
||||
maxSize: `${Math.trunc(MAX_ALLOWED_FILE_BYTES / 1024 / 1024)}MB`,
|
||||
maxSize: `${Math.trunc(maxFileSizeBytes / 1024 / 1024)}MB`,
|
||||
}),
|
||||
);
|
||||
}
|
||||
@@ -11820,7 +12161,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
sceneY,
|
||||
gridPadding,
|
||||
);
|
||||
placeholders.forEach((el) => this.scene.insertElement(el));
|
||||
this.insertNewElements(placeholders);
|
||||
|
||||
// Create, position, insert and select initialized (replacing placeholders)
|
||||
const initialized = await Promise.all(
|
||||
@@ -11948,6 +12289,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
type: "everything",
|
||||
elements: item.elements,
|
||||
randomizeSeed: true,
|
||||
preserveFrameChildrenOrder: true,
|
||||
}).duplicatedElements,
|
||||
}));
|
||||
|
||||
|
||||
@@ -199,6 +199,7 @@ export default function LibraryMenuItems({
|
||||
type: "everything",
|
||||
elements: item.elements,
|
||||
randomizeSeed: true,
|
||||
preserveFrameChildrenOrder: true,
|
||||
}).duplicatedElements,
|
||||
};
|
||||
});
|
||||
|
||||
@@ -2,7 +2,7 @@ import { useEffect, useRef } from "react";
|
||||
|
||||
import "./SVGLayer.scss";
|
||||
|
||||
import type { Trail } from "../animated-trail";
|
||||
import type { Trail } from "../animatedTrail";
|
||||
|
||||
type SVGLayerProps = {
|
||||
trails: Trail[];
|
||||
|
||||
@@ -206,7 +206,6 @@ const handleDimensionChange: DragInputCallbackType<
|
||||
scene.getElementsIncludingDeleted(),
|
||||
nextElementsInFrame,
|
||||
latestElement,
|
||||
app,
|
||||
);
|
||||
|
||||
scene.replaceAllElements(updatedElements);
|
||||
@@ -302,7 +301,6 @@ const handleDragFinished: DragFinishedCallbackType = ({
|
||||
app.scene.getElementsIncludingDeleted(),
|
||||
nextElementsInFrame,
|
||||
latestElement,
|
||||
app,
|
||||
);
|
||||
|
||||
app.scene.replaceAllElements(updatedElements);
|
||||
|
||||
@@ -261,7 +261,6 @@ const handleDimensionChange: DragInputCallbackType<
|
||||
scene.getElementsIncludingDeleted(),
|
||||
nextElementsInFrame,
|
||||
latestElement,
|
||||
app,
|
||||
);
|
||||
|
||||
scene.replaceAllElements(updatedElements);
|
||||
@@ -416,7 +415,6 @@ const handleDragFinished: DragFinishedCallbackType = ({
|
||||
app.scene.getElementsIncludingDeleted(),
|
||||
nextElementsInFrame,
|
||||
latestElement,
|
||||
app,
|
||||
);
|
||||
|
||||
app.scene.replaceAllElements(updatedElements);
|
||||
|
||||
@@ -39,7 +39,7 @@ type InteractiveCanvasProps = {
|
||||
visibleElements: readonly NonDeletedExcalidrawElement[];
|
||||
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||
allElementsMap: NonDeletedSceneElementsMap;
|
||||
sceneNonce: number | undefined;
|
||||
canvasNonce: string;
|
||||
selectionNonce: number | undefined;
|
||||
scale: number;
|
||||
appState: InteractiveCanvasAppState;
|
||||
@@ -279,10 +279,10 @@ const areEqual = (
|
||||
// This could be further optimised if needed, as we don't have to render interactive canvas on each scene mutation
|
||||
if (
|
||||
prevProps.selectionNonce !== nextProps.selectionNonce ||
|
||||
prevProps.sceneNonce !== nextProps.sceneNonce ||
|
||||
prevProps.canvasNonce !== nextProps.canvasNonce ||
|
||||
prevProps.scale !== nextProps.scale ||
|
||||
// we need to memoize on elementsMap because they may have renewed
|
||||
// even if sceneNonce didn't change (e.g. we filter elements out based
|
||||
// even if canvasNonce didn't change (e.g. we filter elements out based
|
||||
// on appState)
|
||||
prevProps.elementsMap !== nextProps.elementsMap ||
|
||||
prevProps.visibleElements !== nextProps.visibleElements ||
|
||||
|
||||
@@ -14,6 +14,7 @@ import type { RoughCanvas } from "roughjs/bin/canvas";
|
||||
|
||||
interface NewElementCanvasProps {
|
||||
appState: AppState;
|
||||
newElement: NonNullable<AppState["newElement"]>;
|
||||
elementsMap: RenderableElementsMap;
|
||||
allElementsMap: NonDeletedSceneElementsMap;
|
||||
scale: number;
|
||||
@@ -31,7 +32,7 @@ const NewElementCanvas = (props: NewElementCanvasProps) => {
|
||||
{
|
||||
canvas: canvasRef.current,
|
||||
scale: props.scale,
|
||||
newElement: props.appState.newElement,
|
||||
newElement: props.newElement,
|
||||
elementsMap: props.elementsMap,
|
||||
allElementsMap: props.allElementsMap,
|
||||
rc: props.rc,
|
||||
|
||||
@@ -23,7 +23,7 @@ type StaticCanvasProps = {
|
||||
elementsMap: RenderableElementsMap;
|
||||
allElementsMap: NonDeletedSceneElementsMap;
|
||||
visibleElements: readonly NonDeletedExcalidrawElement[];
|
||||
sceneNonce: number | undefined;
|
||||
canvasNonce: string;
|
||||
selectionNonce: number | undefined;
|
||||
scale: number;
|
||||
appState: StaticCanvasAppState;
|
||||
@@ -110,10 +110,10 @@ const areEqual = (
|
||||
nextProps: StaticCanvasProps,
|
||||
) => {
|
||||
if (
|
||||
prevProps.sceneNonce !== nextProps.sceneNonce ||
|
||||
prevProps.canvasNonce !== nextProps.canvasNonce ||
|
||||
prevProps.scale !== nextProps.scale ||
|
||||
// we need to memoize on elementsMap because they may have renewed
|
||||
// even if sceneNonce didn't change (e.g. we filter elements out based
|
||||
// even if canvasNonce didn't change (e.g. we filter elements out based
|
||||
// on appState)
|
||||
prevProps.elementsMap !== nextProps.elementsMap ||
|
||||
prevProps.visibleElements !== nextProps.visibleElements
|
||||
|
||||
@@ -1186,6 +1186,26 @@ export const StrokeWidthExtraBoldIcon = createIcon(
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const FreedrawPressureConstantIcon = createIcon(
|
||||
<path
|
||||
d="M4 10h12"
|
||||
stroke="currentColor"
|
||||
strokeWidth="3"
|
||||
strokeLinecap="round"
|
||||
strokeLinejoin="round"
|
||||
/>,
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const FreedrawPressureSensitiveIcon = createIcon(
|
||||
<path
|
||||
d="M4 10C6 9.5 10 8 16 7L16 13C10 12 6 10.5 4 10Z"
|
||||
fill="currentColor"
|
||||
stroke="none"
|
||||
/>,
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeStyleSolidIcon = React.memo(({ theme }: { theme: Theme }) =>
|
||||
createIcon(
|
||||
<path
|
||||
|
||||
@@ -119,15 +119,12 @@ export const SHAPES = [
|
||||
export const getToolbarTools = (app: AppClassProperties) => {
|
||||
return app.state.preferredSelectionTool.type === "lasso"
|
||||
? ([
|
||||
SHAPES[0],
|
||||
{
|
||||
...SHAPES[1],
|
||||
value: "lasso",
|
||||
icon: SelectionIcon,
|
||||
key: KEYS.V,
|
||||
numericKey: KEYS["1"],
|
||||
fillable: true,
|
||||
toolbar: true,
|
||||
},
|
||||
...SHAPES.slice(1),
|
||||
...SHAPES.slice(2),
|
||||
] as const)
|
||||
: SHAPES;
|
||||
};
|
||||
|
||||
@@ -311,6 +311,48 @@ export const dataURLToString = (dataURL: DataURL) => {
|
||||
return base64ToString(dataURL.slice(dataURL.indexOf(",") + 1));
|
||||
};
|
||||
|
||||
const getImageFileDimensions = async (file: File) => {
|
||||
const browserURL = typeof window !== "undefined" ? window.URL : undefined;
|
||||
let objectURL: string | null = null;
|
||||
let imageSource: string;
|
||||
|
||||
try {
|
||||
imageSource = browserURL?.createObjectURL
|
||||
? (objectURL = browserURL.createObjectURL(file))
|
||||
: await getDataURL(file);
|
||||
} catch {
|
||||
objectURL = null;
|
||||
imageSource = await getDataURL(file);
|
||||
}
|
||||
|
||||
return new Promise<{ width: number; height: number }>((resolve, reject) => {
|
||||
const image = new Image();
|
||||
|
||||
const cleanup = () => {
|
||||
image.onload = null;
|
||||
image.onerror = null;
|
||||
|
||||
if (objectURL && browserURL?.revokeObjectURL) {
|
||||
browserURL.revokeObjectURL(objectURL);
|
||||
}
|
||||
};
|
||||
|
||||
image.onload = () => {
|
||||
cleanup();
|
||||
resolve({
|
||||
width: image.naturalWidth || image.width,
|
||||
height: image.naturalHeight || image.height,
|
||||
});
|
||||
};
|
||||
image.onerror = (error) => {
|
||||
cleanup();
|
||||
reject(error);
|
||||
};
|
||||
|
||||
image.src = imageSource;
|
||||
});
|
||||
};
|
||||
|
||||
export const resizeImageFile = async (
|
||||
file: File,
|
||||
opts: {
|
||||
@@ -324,6 +366,20 @@ export const resizeImageFile = async (
|
||||
return file;
|
||||
}
|
||||
|
||||
if (!isSupportedImageFile(file)) {
|
||||
throw new Error("Error: unsupported file type", { cause: "UNSUPPORTED" });
|
||||
}
|
||||
|
||||
if (!opts.outputType || opts.outputType === file.type) {
|
||||
const dimensions = await getImageFileDimensions(file);
|
||||
|
||||
if (
|
||||
Math.max(dimensions.width, dimensions.height) <= opts.maxWidthOrHeight
|
||||
) {
|
||||
return file;
|
||||
}
|
||||
}
|
||||
|
||||
const [pica, imageBlobReduce] = await Promise.all([
|
||||
import("pica").then((res) => res.default),
|
||||
// a wrapper for pica for better API
|
||||
@@ -347,10 +403,6 @@ export const resizeImageFile = async (
|
||||
};
|
||||
}
|
||||
|
||||
if (!isSupportedImageFile(file)) {
|
||||
throw new Error("Error: unsupported file type", { cause: "UNSUPPORTED" });
|
||||
}
|
||||
|
||||
return new File(
|
||||
[await reduce.toBlob(file, { max: opts.maxWidthOrHeight, alpha: true })],
|
||||
file.name,
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { isFiniteNumber, pointFrom } from "@excalidraw/math";
|
||||
import { isFiniteNumber, isValidPoint, pointFrom } from "@excalidraw/math";
|
||||
|
||||
import {
|
||||
type CombineBrandsIfNeeded,
|
||||
@@ -98,6 +98,67 @@ type RestoredAppState = Omit<
|
||||
|
||||
const MAX_ARROW_PX = 75_000;
|
||||
|
||||
const restoreLinearElementPoints = (
|
||||
points: unknown,
|
||||
width: unknown,
|
||||
height: unknown,
|
||||
): LocalPoint[] => {
|
||||
const restoredPoints = Array.isArray(points)
|
||||
? points.reduce<LocalPoint[]>((acc, point) => {
|
||||
if (isValidPoint(point)) {
|
||||
acc.push(pointFrom<LocalPoint>(point[0], point[1]));
|
||||
}
|
||||
return acc;
|
||||
}, [])
|
||||
: [];
|
||||
|
||||
return restoredPoints.length < 2
|
||||
? [
|
||||
pointFrom<LocalPoint>(0, 0),
|
||||
pointFrom<LocalPoint>(
|
||||
isFiniteNumber(width) ? width : 0,
|
||||
isFiniteNumber(height) ? height : 0,
|
||||
),
|
||||
]
|
||||
: restoredPoints;
|
||||
};
|
||||
|
||||
const restoreFreedrawPoints = (
|
||||
points: unknown,
|
||||
pressures: unknown,
|
||||
): {
|
||||
points: LocalPoint[];
|
||||
pressures: number[];
|
||||
} => {
|
||||
if (!Array.isArray(points)) {
|
||||
return {
|
||||
points: [],
|
||||
pressures: [],
|
||||
};
|
||||
}
|
||||
|
||||
const pressureValues: readonly unknown[] = Array.isArray(pressures)
|
||||
? pressures
|
||||
: [];
|
||||
const restoredPoints: LocalPoint[] = [];
|
||||
const restoredPressures: number[] = [];
|
||||
|
||||
points.forEach((point, index) => {
|
||||
if (isValidPoint(point)) {
|
||||
restoredPoints.push(pointFrom<LocalPoint>(point[0], point[1]));
|
||||
if (index in pressureValues) {
|
||||
const pressure = pressureValues[index];
|
||||
restoredPressures.push(isFiniteNumber(pressure) ? pressure : 0.5);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
return {
|
||||
points: restoredPoints,
|
||||
pressures: restoredPressures,
|
||||
};
|
||||
};
|
||||
|
||||
export const AllowedExcalidrawActiveTools: Record<
|
||||
AppState["activeTool"]["type"],
|
||||
boolean
|
||||
@@ -414,10 +475,15 @@ export const restoreElement = (
|
||||
|
||||
return element;
|
||||
case "freedraw": {
|
||||
const { points, pressures } = restoreFreedrawPoints(
|
||||
element.points,
|
||||
element.pressures,
|
||||
);
|
||||
|
||||
return restoreElementWithProperties(element, {
|
||||
points: element.points,
|
||||
points,
|
||||
simulatePressure: element.simulatePressure,
|
||||
pressures: element.pressures,
|
||||
pressures,
|
||||
});
|
||||
}
|
||||
case "image":
|
||||
@@ -435,14 +501,20 @@ export const restoreElement = (
|
||||
const endArrowhead = normalizeArrowhead(element.endArrowhead);
|
||||
let x = element.x;
|
||||
let y = element.y;
|
||||
let points = // migrate old arrow model to new one
|
||||
!Array.isArray(element.points) || element.points.length < 2
|
||||
? [pointFrom(0, 0), pointFrom(element.width, element.height)]
|
||||
: element.points;
|
||||
let points = restoreLinearElementPoints(
|
||||
element.points,
|
||||
element.width,
|
||||
element.height,
|
||||
);
|
||||
|
||||
if (points[0][0] !== 0 || points[0][1] !== 0) {
|
||||
({ points, x, y } =
|
||||
LinearElementEditor.getNormalizeElementPointsAndCoords(element));
|
||||
LinearElementEditor.getNormalizeElementPointsAndCoords({
|
||||
...element,
|
||||
points,
|
||||
x: x ?? 0,
|
||||
y: y ?? 0,
|
||||
} as ExcalidrawLinearElement));
|
||||
}
|
||||
|
||||
return restoreElementWithProperties(element, {
|
||||
@@ -456,7 +528,7 @@ export const restoreElement = (
|
||||
y,
|
||||
...(isLineElement(element)
|
||||
? {
|
||||
polygon: isValidPolygon(element.points)
|
||||
polygon: isValidPolygon(points)
|
||||
? element.polygon ?? false
|
||||
: false,
|
||||
}
|
||||
@@ -471,22 +543,29 @@ export const restoreElement = (
|
||||
: normalizeArrowhead(element.endArrowhead);
|
||||
const x = element.x as number | undefined;
|
||||
const y = element.y as number | undefined;
|
||||
const points: readonly LocalPoint[] | undefined = // migrate old arrow model to new one
|
||||
!Array.isArray(element.points) || element.points.length < 2
|
||||
? [pointFrom(0, 0), pointFrom(element.width, element.height)]
|
||||
: element.points;
|
||||
const points = restoreLinearElementPoints(
|
||||
element.points,
|
||||
element.width,
|
||||
element.height,
|
||||
);
|
||||
const elementWithRestoredPoints = {
|
||||
...element,
|
||||
points,
|
||||
x: x ?? 0,
|
||||
y: y ?? 0,
|
||||
} as ExcalidrawArrowElement;
|
||||
|
||||
const base = {
|
||||
type: element.type,
|
||||
startBinding: repairBinding(
|
||||
element as ExcalidrawArrowElement,
|
||||
elementWithRestoredPoints,
|
||||
element.startBinding,
|
||||
targetElementsMap,
|
||||
existingElementsMap,
|
||||
"start",
|
||||
),
|
||||
endBinding: repairBinding(
|
||||
element as ExcalidrawArrowElement,
|
||||
elementWithRestoredPoints,
|
||||
element.endBinding,
|
||||
targetElementsMap,
|
||||
existingElementsMap,
|
||||
|
||||
@@ -33,9 +33,7 @@ import type { Bounds } from "@excalidraw/common";
|
||||
import type { GlobalPoint, LineSegment } from "@excalidraw/math/types";
|
||||
import type { ElementsMap, ExcalidrawElement } from "@excalidraw/element/types";
|
||||
|
||||
import { AnimatedTrail } from "../animated-trail";
|
||||
|
||||
import type { AnimationFrameHandler } from "../animation-frame-handler";
|
||||
import { AnimatedTrail } from "../animatedTrail";
|
||||
|
||||
import type App from "../components/App";
|
||||
|
||||
@@ -43,8 +41,8 @@ export class EraserTrail extends AnimatedTrail {
|
||||
private elementsToErase: Set<ExcalidrawElement["id"]> = new Set();
|
||||
private groupsToErase: Set<ExcalidrawElement["id"]> = new Set();
|
||||
|
||||
constructor(animationFrameHandler: AnimationFrameHandler, app: App) {
|
||||
super(animationFrameHandler, app, {
|
||||
constructor(app: App) {
|
||||
super(app, {
|
||||
streamline: 0.2,
|
||||
size: 5,
|
||||
keepHead: true,
|
||||
|
||||
@@ -6,7 +6,12 @@ import React, {
|
||||
useState,
|
||||
} from "react";
|
||||
|
||||
import { DEFAULT_UI_OPTIONS, isShallowEqual } from "@excalidraw/common";
|
||||
import {
|
||||
applyDarkModeFilter,
|
||||
DEFAULT_IMAGE_OPTIONS,
|
||||
DEFAULT_UI_OPTIONS,
|
||||
isShallowEqual,
|
||||
} from "@excalidraw/common";
|
||||
|
||||
import App, {
|
||||
ExcalidrawAPIContext,
|
||||
@@ -98,6 +103,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
aiEnabled,
|
||||
showDeprecatedFonts,
|
||||
renderScrollbars,
|
||||
imageOptions,
|
||||
} = props;
|
||||
|
||||
const canvasActions = props.UIOptions?.canvasActions;
|
||||
@@ -128,6 +134,13 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
UIOptions.canvasActions.toggleTheme = true;
|
||||
}
|
||||
|
||||
const normalizedImageOptions: AppProps["imageOptions"] = {
|
||||
maxFileSizeBytes:
|
||||
imageOptions?.maxFileSizeBytes ?? DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes,
|
||||
maxWidthOrHeight:
|
||||
imageOptions?.maxWidthOrHeight ?? DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight,
|
||||
};
|
||||
|
||||
const setExcalidrawAPI = useContext(ExcalidrawAPISetContext);
|
||||
|
||||
const onExcalidrawAPIRef = useRef(onExcalidrawAPI);
|
||||
@@ -208,6 +221,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
aiEnabled={aiEnabled !== false}
|
||||
showDeprecatedFonts={showDeprecatedFonts}
|
||||
renderScrollbars={renderScrollbars}
|
||||
imageOptions={normalizedImageOptions}
|
||||
>
|
||||
{children}
|
||||
</App>
|
||||
@@ -225,11 +239,13 @@ const areEqual = (prevProps: ExcalidrawProps, nextProps: ExcalidrawProps) => {
|
||||
const {
|
||||
initialData: prevInitialData,
|
||||
UIOptions: prevUIOptions = {},
|
||||
imageOptions: prevImageOptions,
|
||||
...prev
|
||||
} = prevProps;
|
||||
const {
|
||||
initialData: nextInitialData,
|
||||
UIOptions: nextUIOptions = {},
|
||||
imageOptions: nextImageOptions,
|
||||
...next
|
||||
} = nextProps;
|
||||
|
||||
@@ -273,7 +289,17 @@ const areEqual = (prevProps: ExcalidrawProps, nextProps: ExcalidrawProps) => {
|
||||
return prevUIOptions[key] === nextUIOptions[key];
|
||||
});
|
||||
|
||||
return isUIOptionsSame && isShallowEqual(prev, next);
|
||||
const isImageOptionsSame =
|
||||
(prevImageOptions?.maxWidthOrHeight ??
|
||||
DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight) ===
|
||||
(nextImageOptions?.maxWidthOrHeight ??
|
||||
DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight) &&
|
||||
(prevImageOptions?.maxFileSizeBytes ??
|
||||
DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes) ===
|
||||
(nextImageOptions?.maxFileSizeBytes ??
|
||||
DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes);
|
||||
|
||||
return isUIOptionsSame && isImageOptionsSame && isShallowEqual(prev, next);
|
||||
};
|
||||
|
||||
export const Excalidraw = React.memo(ExcalidrawBase, areEqual);
|
||||
@@ -425,3 +451,5 @@ export function useExcalidrawStateValue(
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
export { _useOnAppStateChange as useOnExcalidrawStateChange };
|
||||
|
||||
export { applyDarkModeFilter };
|
||||
|
||||
@@ -2,27 +2,20 @@ import { DEFAULT_LASER_COLOR, easeOut } from "@excalidraw/common";
|
||||
|
||||
import type { LaserPointerOptions } from "@excalidraw/laser-pointer";
|
||||
|
||||
import { AnimatedTrail } from "./animated-trail";
|
||||
import { AnimatedTrail } from "./animatedTrail";
|
||||
import { getClientColor } from "./clients";
|
||||
|
||||
import type { Trail } from "./animated-trail";
|
||||
import type { AnimationFrameHandler } from "./animation-frame-handler";
|
||||
import type { Trail } from "./animatedTrail";
|
||||
import type App from "./components/App";
|
||||
import type { SocketId } from "./types";
|
||||
|
||||
export class LaserTrails implements Trail {
|
||||
public localTrail: AnimatedTrail;
|
||||
private collabTrails = new Map<SocketId, AnimatedTrail>();
|
||||
|
||||
private container?: SVGSVGElement;
|
||||
|
||||
constructor(
|
||||
private animationFrameHandler: AnimationFrameHandler,
|
||||
private app: App,
|
||||
) {
|
||||
this.animationFrameHandler.register(this, this.onFrame.bind(this));
|
||||
|
||||
this.localTrail = new AnimatedTrail(animationFrameHandler, app, {
|
||||
constructor(private app: App) {
|
||||
this.localTrail = new AnimatedTrail(app, {
|
||||
...this.getTrailOptions(),
|
||||
fill: () => DEFAULT_LASER_COLOR,
|
||||
});
|
||||
@@ -63,30 +56,45 @@ export class LaserTrails implements Trail {
|
||||
|
||||
start(container: SVGSVGElement) {
|
||||
this.container = container;
|
||||
|
||||
this.animationFrameHandler.start(this);
|
||||
this.localTrail.start(container);
|
||||
}
|
||||
|
||||
stop() {
|
||||
this.animationFrameHandler.stop(this);
|
||||
this.localTrail.stop();
|
||||
this.stopCollabTrails();
|
||||
this.container = undefined;
|
||||
}
|
||||
|
||||
onFrame() {
|
||||
this.updateCollabTrails();
|
||||
private stopCollabTrails(collaborators?: App["state"]["collaborators"]) {
|
||||
for (const [key, trail] of this.collabTrails) {
|
||||
const collaborator = collaborators?.get(key);
|
||||
|
||||
if (!collaborator) {
|
||||
trail.stop();
|
||||
this.collabTrails.delete(key);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
private updateCollabTrails() {
|
||||
if (!this.container || this.app.state.collaborators.size === 0) {
|
||||
updateCollabTrails(collaborators: App["state"]["collaborators"]) {
|
||||
this.stopCollabTrails(collaborators);
|
||||
|
||||
if (!this.container || collaborators.size === 0) {
|
||||
return;
|
||||
}
|
||||
|
||||
for (const [key, collaborator] of this.app.state.collaborators.entries()) {
|
||||
let trail!: AnimatedTrail;
|
||||
for (const [key, collaborator] of collaborators.entries()) {
|
||||
// Current user has their own trail drawn via localTrail
|
||||
if (collaborator.isCurrentUser) {
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!this.collabTrails.has(key)) {
|
||||
trail = new AnimatedTrail(this.animationFrameHandler, this.app, {
|
||||
// IDEA: Use the collaborator pointer coordinates to trace out the
|
||||
// laser pointer trail when 1) the selected collab tool is the laser
|
||||
// pointer and 2) the collab pointer button is in the "down" state.
|
||||
let trail = this.collabTrails.get(key);
|
||||
if (!trail) {
|
||||
trail = new AnimatedTrail(this.app, {
|
||||
...this.getTrailOptions(),
|
||||
fill: () =>
|
||||
collaborator.pointer?.laserColor ||
|
||||
@@ -95,36 +103,33 @@ export class LaserTrails implements Trail {
|
||||
trail.start(this.container);
|
||||
|
||||
this.collabTrails.set(key, trail);
|
||||
} else {
|
||||
trail = this.collabTrails.get(key)!;
|
||||
}
|
||||
|
||||
if (collaborator.pointer && collaborator.pointer.tool === "laser") {
|
||||
if (collaborator.button === "down" && !trail.hasCurrentTrail) {
|
||||
const buttonDown = collaborator.button === "down";
|
||||
const buttonUp = collaborator.button === "up";
|
||||
const hasTrail = trail.hasCurrentTrail;
|
||||
|
||||
// Initialize a new trail
|
||||
if (buttonDown && !hasTrail) {
|
||||
trail.startPath(collaborator.pointer.x, collaborator.pointer.y);
|
||||
}
|
||||
|
||||
if (
|
||||
collaborator.button === "down" &&
|
||||
trail.hasCurrentTrail &&
|
||||
!trail.hasLastPoint(collaborator.pointer.x, collaborator.pointer.y)
|
||||
) {
|
||||
// Add only original points
|
||||
const lastPointOriginal = !trail.hasLastPoint(
|
||||
collaborator.pointer.x,
|
||||
collaborator.pointer.y,
|
||||
);
|
||||
if (buttonDown && lastPointOriginal) {
|
||||
trail.addPointToPath(collaborator.pointer.x, collaborator.pointer.y);
|
||||
}
|
||||
|
||||
if (collaborator.button === "up" && trail.hasCurrentTrail) {
|
||||
// End the trail on button up
|
||||
if (buttonUp && hasTrail) {
|
||||
trail.addPointToPath(collaborator.pointer.x, collaborator.pointer.y);
|
||||
trail.endPath();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
for (const key of this.collabTrails.keys()) {
|
||||
if (!this.app.state.collaborators.has(key)) {
|
||||
const trail = this.collabTrails.get(key)!;
|
||||
trail.stop();
|
||||
this.collabTrails.delete(key);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -25,9 +25,7 @@ import type {
|
||||
NonDeleted,
|
||||
} from "@excalidraw/element/types";
|
||||
|
||||
import { type AnimationFrameHandler } from "../animation-frame-handler";
|
||||
|
||||
import { AnimatedTrail } from "../animated-trail";
|
||||
import { AnimatedTrail } from "../animatedTrail";
|
||||
|
||||
import { getLassoSelectedElementIds } from "./utils";
|
||||
|
||||
@@ -47,8 +45,8 @@ export class LassoTrail extends AnimatedTrail {
|
||||
private canvasTranslate: CanvasTranslate | null = null;
|
||||
private keepPreviousSelection: boolean = false;
|
||||
|
||||
constructor(animationFrameHandler: AnimationFrameHandler, app: App) {
|
||||
super(animationFrameHandler, app, {
|
||||
constructor(app: App) {
|
||||
super(app, {
|
||||
animateTrail: true,
|
||||
streamline: 0.4,
|
||||
sizeMapping: (c) => {
|
||||
|
||||
@@ -30,6 +30,9 @@
|
||||
"changeBackground": "Change background color",
|
||||
"fill": "Fill",
|
||||
"strokeWidth": "Stroke width",
|
||||
"strokeShape": "Pressure",
|
||||
"strokeShape_constant": "Constant pressure",
|
||||
"strokeShape_pressure": "Pressure-sensitive",
|
||||
"strokeStyle": "Stroke style",
|
||||
"strokeStyle_solid": "Solid",
|
||||
"strokeStyle_dashed": "Dashed",
|
||||
|
||||
@@ -95,7 +95,6 @@
|
||||
"clsx": "1.1.1",
|
||||
"cross-env": "7.0.3",
|
||||
"es6-promise-pool": "2.5.0",
|
||||
"fractional-indexing": "3.2.0",
|
||||
"fuzzy": "0.1.3",
|
||||
"image-blob-reduce": "3.0.1",
|
||||
"jotai": "2.11.0",
|
||||
@@ -104,7 +103,6 @@
|
||||
"lodash.throttle": "4.1.1",
|
||||
"nanoid": "3.3.3",
|
||||
"pako": "2.0.3",
|
||||
"perfect-freehand": "1.2.0",
|
||||
"pica": "7.1.1",
|
||||
"png-chunk-text": "1.0.0",
|
||||
"png-chunks-encode": "1.0.0",
|
||||
|
||||
@@ -23,6 +23,94 @@ const polyfill = () => {
|
||||
});
|
||||
}
|
||||
|
||||
if (!Array.prototype.findLast) {
|
||||
Object.defineProperty(Array.prototype, "findLast", {
|
||||
value: function <T>(
|
||||
this: T[],
|
||||
predicate: (value: T, index: number, array: T[]) => unknown,
|
||||
thisArg?: unknown,
|
||||
) {
|
||||
return this
|
||||
.slice()
|
||||
.reverse()
|
||||
.find((value, index) =>
|
||||
predicate.call(thisArg, value, this.length - index - 1, this),
|
||||
);
|
||||
},
|
||||
writable: true,
|
||||
enumerable: false,
|
||||
configurable: true,
|
||||
});
|
||||
}
|
||||
|
||||
if (!Array.prototype.findIndex) {
|
||||
Object.defineProperty(Array.prototype, "findIndex", {
|
||||
value: function <T>(
|
||||
this: T[],
|
||||
predicate: (value: T, index: number, array: T[]) => unknown,
|
||||
thisArg?: unknown,
|
||||
) {
|
||||
for (let index = 0; index < this.length; index++) {
|
||||
if (predicate.call(thisArg, this[index], index, this)) {
|
||||
return index;
|
||||
}
|
||||
}
|
||||
|
||||
return -1;
|
||||
},
|
||||
writable: true,
|
||||
enumerable: false,
|
||||
configurable: true,
|
||||
});
|
||||
}
|
||||
|
||||
if (!Array.prototype.findLastIndex) {
|
||||
Object.defineProperty(Array.prototype, "findLastIndex", {
|
||||
value: function <T>(
|
||||
this: T[],
|
||||
predicate: (value: T, index: number, array: T[]) => unknown,
|
||||
thisArg?: unknown,
|
||||
) {
|
||||
const index = this
|
||||
.slice()
|
||||
.reverse()
|
||||
.findIndex((value, index) =>
|
||||
predicate.call(thisArg, value, this.length - index - 1, this),
|
||||
);
|
||||
|
||||
return index === -1 ? -1 : this.length - index - 1;
|
||||
},
|
||||
writable: true,
|
||||
enumerable: false,
|
||||
configurable: true,
|
||||
});
|
||||
}
|
||||
|
||||
if (!Array.prototype.toReversed) {
|
||||
Object.defineProperty(Array.prototype, "toReversed", {
|
||||
value: function <T>(this: T[]) {
|
||||
return this.slice().reverse();
|
||||
},
|
||||
writable: true,
|
||||
enumerable: false,
|
||||
configurable: true,
|
||||
});
|
||||
}
|
||||
|
||||
if (!Array.prototype.toSorted) {
|
||||
Object.defineProperty(Array.prototype, "toSorted", {
|
||||
value: function <T>(
|
||||
this: T[],
|
||||
compareFn?: (a: T, b: T) => number,
|
||||
) {
|
||||
return this.slice().sort(compareFn);
|
||||
},
|
||||
writable: true,
|
||||
enumerable: false,
|
||||
configurable: true,
|
||||
});
|
||||
}
|
||||
|
||||
if (!Element.prototype.replaceChildren) {
|
||||
Element.prototype.replaceChildren = function (...nodes) {
|
||||
this.innerHTML = "";
|
||||
|
||||
@@ -6,7 +6,10 @@ export type Animation<R extends object> = (params: {
|
||||
}) => R | null | undefined;
|
||||
|
||||
export class AnimationController {
|
||||
private static isRunning = false;
|
||||
private static scheduledFrame:
|
||||
| { id: ReturnType<typeof requestAnimationFrame>; type: "raf" }
|
||||
| { id: ReturnType<typeof setTimeout>; type: "timeout" }
|
||||
| null = null;
|
||||
private static animations = new Map<
|
||||
string,
|
||||
{
|
||||
@@ -17,6 +20,10 @@ export class AnimationController {
|
||||
>();
|
||||
|
||||
static start<R extends object>(key: string, animation: Animation<R>) {
|
||||
if (AnimationController.animations.has(key)) {
|
||||
return;
|
||||
}
|
||||
|
||||
const initialState = animation({
|
||||
deltaTime: 0,
|
||||
state: undefined,
|
||||
@@ -29,19 +36,54 @@ export class AnimationController {
|
||||
state: initialState,
|
||||
});
|
||||
|
||||
if (!AnimationController.isRunning) {
|
||||
AnimationController.isRunning = true;
|
||||
|
||||
if (isRenderThrottlingEnabled()) {
|
||||
requestAnimationFrame(AnimationController.tick);
|
||||
} else {
|
||||
setTimeout(AnimationController.tick, 0);
|
||||
}
|
||||
}
|
||||
AnimationController.scheduleNextFrame();
|
||||
}
|
||||
}
|
||||
|
||||
private static scheduleNextFrame() {
|
||||
if (AnimationController.scheduledFrame) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (isRenderThrottlingEnabled()) {
|
||||
AnimationController.scheduledFrame = {
|
||||
id: requestAnimationFrame(AnimationController.tick),
|
||||
type: "raf",
|
||||
};
|
||||
} else {
|
||||
AnimationController.scheduledFrame = {
|
||||
id: setTimeout(AnimationController.tick, 0),
|
||||
type: "timeout",
|
||||
};
|
||||
}
|
||||
}
|
||||
|
||||
private static cancelScheduledFrame() {
|
||||
if (!AnimationController.scheduledFrame) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (AnimationController.scheduledFrame.type === "raf") {
|
||||
cancelAnimationFrame(AnimationController.scheduledFrame.id);
|
||||
} else {
|
||||
clearTimeout(AnimationController.scheduledFrame.id);
|
||||
}
|
||||
|
||||
AnimationController.scheduledFrame = null;
|
||||
}
|
||||
|
||||
private static cancelScheduledFrameIfIdle() {
|
||||
if (AnimationController.animations.size > 0) {
|
||||
return false;
|
||||
}
|
||||
|
||||
AnimationController.cancelScheduledFrame();
|
||||
return true;
|
||||
}
|
||||
|
||||
private static tick() {
|
||||
AnimationController.scheduledFrame = null;
|
||||
|
||||
if (AnimationController.animations.size > 0) {
|
||||
for (const [key, animation] of AnimationController.animations) {
|
||||
const now = performance.now();
|
||||
@@ -56,8 +98,7 @@ export class AnimationController {
|
||||
if (!state) {
|
||||
AnimationController.animations.delete(key);
|
||||
|
||||
if (AnimationController.animations.size === 0) {
|
||||
AnimationController.isRunning = false;
|
||||
if (AnimationController.cancelScheduledFrameIfIdle()) {
|
||||
return;
|
||||
}
|
||||
} else {
|
||||
@@ -66,11 +107,11 @@ export class AnimationController {
|
||||
}
|
||||
}
|
||||
|
||||
if (isRenderThrottlingEnabled()) {
|
||||
requestAnimationFrame(AnimationController.tick);
|
||||
} else {
|
||||
setTimeout(AnimationController.tick, 0);
|
||||
if (AnimationController.cancelScheduledFrameIfIdle()) {
|
||||
return;
|
||||
}
|
||||
|
||||
AnimationController.scheduleNextFrame();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -80,5 +121,6 @@ export class AnimationController {
|
||||
|
||||
static cancel(key: string) {
|
||||
AnimationController.animations.delete(key);
|
||||
AnimationController.cancelScheduledFrameIfIdle();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -62,10 +62,10 @@ export const bootstrapCanvas = ({
|
||||
context.clearRect(0, 0, normalizedWidth, normalizedHeight);
|
||||
}
|
||||
context.save();
|
||||
context.fillStyle =
|
||||
theme === THEME.DARK
|
||||
? applyDarkModeFilter(viewBackgroundColor)
|
||||
: viewBackgroundColor;
|
||||
context.fillStyle = applyDarkModeFilter(
|
||||
viewBackgroundColor,
|
||||
theme === THEME.DARK,
|
||||
);
|
||||
context.fillRect(0, 0, normalizedWidth, normalizedHeight);
|
||||
context.restore();
|
||||
} else {
|
||||
|
||||
@@ -19,6 +19,8 @@ export const renderSnaps = (
|
||||
}
|
||||
|
||||
// in dark mode, we need to adjust the color to account for color inversion.
|
||||
// Don't change if zen mode, because we draw only crosses, we want the
|
||||
// colors to be more visible
|
||||
const snapColor =
|
||||
appState.theme === THEME.LIGHT || appState.zenModeEnabled
|
||||
? SNAP_COLOR_LIGHT
|
||||
|
||||
@@ -377,18 +377,27 @@ const renderElementToSvg = (
|
||||
case "freedraw": {
|
||||
const wrapper = svgRoot.ownerDocument.createElementNS(SVG_NS, "g");
|
||||
|
||||
// Set fill once on the group so all capsule paths inherit it
|
||||
// instead of repeating the attribute on every child element.
|
||||
wrapper.setAttribute(
|
||||
"fill",
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor,
|
||||
);
|
||||
|
||||
const shapes = ShapeCache.generateElementShape(element, renderConfig);
|
||||
// always ordered as [background, stroke]
|
||||
for (const shape of shapes) {
|
||||
if (typeof shape === "string") {
|
||||
// stroke (SVGPathString)
|
||||
|
||||
// stroke (SVGPathString) — fill inherited from wrapper <g>
|
||||
const path = svgRoot.ownerDocument.createElementNS(SVG_NS, "path");
|
||||
path.setAttribute(
|
||||
"fill",
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor,
|
||||
applyDarkModeFilter(
|
||||
element.strokeColor,
|
||||
renderConfig.theme === THEME.DARK,
|
||||
),
|
||||
);
|
||||
path.setAttribute("d", shape);
|
||||
wrapper.appendChild(path);
|
||||
@@ -621,9 +630,10 @@ const renderElementToSvg = (
|
||||
rect.setAttribute("fill", "none");
|
||||
rect.setAttribute(
|
||||
"stroke",
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(FRAME_STYLE.strokeColor)
|
||||
: FRAME_STYLE.strokeColor,
|
||||
applyDarkModeFilter(
|
||||
FRAME_STYLE.strokeColor,
|
||||
renderConfig.theme === THEME.DARK,
|
||||
),
|
||||
);
|
||||
rect.setAttribute("stroke-width", FRAME_STYLE.strokeWidth.toString());
|
||||
|
||||
@@ -677,9 +687,10 @@ const renderElementToSvg = (
|
||||
text.setAttribute("font-size", `${element.fontSize}px`);
|
||||
text.setAttribute(
|
||||
"fill",
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor,
|
||||
applyDarkModeFilter(
|
||||
element.strokeColor,
|
||||
renderConfig.theme === THEME.DARK,
|
||||
),
|
||||
);
|
||||
text.setAttribute("text-anchor", textAnchor);
|
||||
text.setAttribute("style", "white-space: pre;");
|
||||
|
||||
@@ -1,9 +1,15 @@
|
||||
import { isElementInViewport } from "@excalidraw/element";
|
||||
import {
|
||||
getCommonFrameId,
|
||||
getFrameChildrenInsertionIndex,
|
||||
isElementInViewport,
|
||||
} from "@excalidraw/element";
|
||||
|
||||
import { memoize, toBrandedType } from "@excalidraw/common";
|
||||
import { arrayToMap, memoize, toBrandedType } from "@excalidraw/common";
|
||||
|
||||
import type {
|
||||
ExcalidrawElement,
|
||||
ExcalidrawFrameLikeElement,
|
||||
NonDeleted,
|
||||
NonDeletedElementsMap,
|
||||
NonDeletedExcalidrawElement,
|
||||
} from "@excalidraw/element/types";
|
||||
@@ -16,6 +22,21 @@ import type { RenderableElementsMap } from "./types";
|
||||
|
||||
import type { AppState } from "../types";
|
||||
|
||||
type GetRenderableElementsOpts = {
|
||||
zoom: AppState["zoom"];
|
||||
offsetLeft: AppState["offsetLeft"];
|
||||
offsetTop: AppState["offsetTop"];
|
||||
scrollX: AppState["scrollX"];
|
||||
scrollY: AppState["scrollY"];
|
||||
height: AppState["height"];
|
||||
width: AppState["width"];
|
||||
editingTextElement: AppState["editingTextElement"];
|
||||
newElement: AppState["newElement"];
|
||||
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||
selectedElementsAreBeingDragged: AppState["selectedElementsAreBeingDragged"];
|
||||
frameToHighlight: AppState["frameToHighlight"];
|
||||
};
|
||||
|
||||
export class Renderer {
|
||||
private scene: Scene;
|
||||
|
||||
@@ -23,9 +44,121 @@ export class Renderer {
|
||||
this.scene = scene;
|
||||
}
|
||||
|
||||
public getRenderableElements = (() => {
|
||||
const getVisibleCanvasElements = ({
|
||||
elementsMap,
|
||||
private getVisibleCanvasElements({
|
||||
elementsMap,
|
||||
zoom,
|
||||
offsetLeft,
|
||||
offsetTop,
|
||||
scrollX,
|
||||
scrollY,
|
||||
height,
|
||||
width,
|
||||
}: {
|
||||
elementsMap: NonDeletedElementsMap;
|
||||
zoom: AppState["zoom"];
|
||||
offsetLeft: AppState["offsetLeft"];
|
||||
offsetTop: AppState["offsetTop"];
|
||||
scrollX: AppState["scrollX"];
|
||||
scrollY: AppState["scrollY"];
|
||||
height: AppState["height"];
|
||||
width: AppState["width"];
|
||||
}): readonly NonDeletedExcalidrawElement[] {
|
||||
const visibleElements: NonDeletedExcalidrawElement[] = [];
|
||||
for (const element of elementsMap.values()) {
|
||||
if (
|
||||
isElementInViewport(
|
||||
element,
|
||||
width,
|
||||
height,
|
||||
{
|
||||
zoom,
|
||||
offsetLeft,
|
||||
offsetTop,
|
||||
scrollX,
|
||||
scrollY,
|
||||
},
|
||||
elementsMap,
|
||||
)
|
||||
) {
|
||||
visibleElements.push(element);
|
||||
}
|
||||
}
|
||||
return visibleElements;
|
||||
}
|
||||
|
||||
private getRenderableElementsMap({
|
||||
elements,
|
||||
editingTextElement,
|
||||
newElement,
|
||||
}: {
|
||||
elements: readonly NonDeletedExcalidrawElement[];
|
||||
editingTextElement: AppState["editingTextElement"];
|
||||
newElement: AppState["newElement"];
|
||||
}) {
|
||||
const elementsMap = toBrandedType<RenderableElementsMap>(new Map());
|
||||
const newElementCanvasElement = newElement?.frameId ? null : newElement;
|
||||
|
||||
for (const element of elements) {
|
||||
if (newElementCanvasElement?.id === element.id) {
|
||||
continue;
|
||||
}
|
||||
|
||||
// we don't want to render text element that's being currently edited
|
||||
// (it's rendered on remote only)
|
||||
if (
|
||||
!editingTextElement ||
|
||||
editingTextElement.type !== "text" ||
|
||||
element.id !== editingTextElement.id
|
||||
) {
|
||||
elementsMap.set(element.id, element);
|
||||
}
|
||||
}
|
||||
return { elementsMap, newElementCanvasElement };
|
||||
}
|
||||
|
||||
private sortSelectedElementsIntoHighlightedFrame<
|
||||
T extends ExcalidrawElement,
|
||||
>({
|
||||
visibleElements,
|
||||
selectedElements,
|
||||
frameToHighlight,
|
||||
}: {
|
||||
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||
visibleElements: readonly T[];
|
||||
frameToHighlight: NonDeleted<ExcalidrawFrameLikeElement>;
|
||||
}): readonly T[] {
|
||||
if (!selectedElements.length) {
|
||||
return visibleElements;
|
||||
}
|
||||
|
||||
// we assume all selected elements are eligible frame children if
|
||||
// frameToHighlight is defined
|
||||
const selectedElementsMap = arrayToMap(selectedElements);
|
||||
|
||||
// thus, all deselected elements are the ones we won't reorder
|
||||
const deselectedElements = visibleElements.filter(
|
||||
(element) => !selectedElementsMap.has(element.id),
|
||||
);
|
||||
|
||||
const insertionIndex = getFrameChildrenInsertionIndex(
|
||||
deselectedElements,
|
||||
frameToHighlight.id,
|
||||
);
|
||||
|
||||
if (insertionIndex === null) {
|
||||
return visibleElements;
|
||||
}
|
||||
|
||||
return [
|
||||
...deselectedElements.slice(0, insertionIndex),
|
||||
...selectedElements,
|
||||
...deselectedElements.slice(insertionIndex),
|
||||
] as readonly T[];
|
||||
}
|
||||
|
||||
private _getRenderableElements = memoize(
|
||||
({
|
||||
canvasNonce,
|
||||
zoom,
|
||||
offsetLeft,
|
||||
offsetTop,
|
||||
@@ -33,70 +166,27 @@ export class Renderer {
|
||||
scrollY,
|
||||
height,
|
||||
width,
|
||||
}: {
|
||||
elementsMap: NonDeletedElementsMap;
|
||||
zoom: AppState["zoom"];
|
||||
offsetLeft: AppState["offsetLeft"];
|
||||
offsetTop: AppState["offsetTop"];
|
||||
scrollX: AppState["scrollX"];
|
||||
scrollY: AppState["scrollY"];
|
||||
height: AppState["height"];
|
||||
width: AppState["width"];
|
||||
}): readonly NonDeletedExcalidrawElement[] => {
|
||||
const visibleElements: NonDeletedExcalidrawElement[] = [];
|
||||
for (const element of elementsMap.values()) {
|
||||
if (
|
||||
isElementInViewport(
|
||||
element,
|
||||
width,
|
||||
height,
|
||||
{
|
||||
zoom,
|
||||
offsetLeft,
|
||||
offsetTop,
|
||||
scrollX,
|
||||
scrollY,
|
||||
},
|
||||
elementsMap,
|
||||
)
|
||||
) {
|
||||
visibleElements.push(element);
|
||||
}
|
||||
}
|
||||
return visibleElements;
|
||||
};
|
||||
|
||||
const getRenderableElements = ({
|
||||
elements,
|
||||
editingTextElement,
|
||||
newElementId,
|
||||
}: {
|
||||
elements: readonly NonDeletedExcalidrawElement[];
|
||||
editingTextElement: AppState["editingTextElement"];
|
||||
newElementId: ExcalidrawElement["id"] | undefined;
|
||||
newElement,
|
||||
}: Omit<
|
||||
GetRenderableElementsOpts,
|
||||
| "selectedElements"
|
||||
| "selectedElementsAreBeingDragged"
|
||||
| "frameToHighlight"
|
||||
> & {
|
||||
canvasNonce: string;
|
||||
}) => {
|
||||
const elementsMap = toBrandedType<RenderableElementsMap>(new Map());
|
||||
const elements = this.scene.getNonDeletedElements();
|
||||
|
||||
for (const element of elements) {
|
||||
if (newElementId === element.id) {
|
||||
continue;
|
||||
}
|
||||
const { elementsMap, newElementCanvasElement } =
|
||||
this.getRenderableElementsMap({
|
||||
elements,
|
||||
editingTextElement,
|
||||
newElement,
|
||||
});
|
||||
|
||||
// we don't want to render text element that's being currently edited
|
||||
// (it's rendered on remote only)
|
||||
if (
|
||||
!editingTextElement ||
|
||||
editingTextElement.type !== "text" ||
|
||||
element.id !== editingTextElement.id
|
||||
) {
|
||||
elementsMap.set(element.id, element);
|
||||
}
|
||||
}
|
||||
return elementsMap;
|
||||
};
|
||||
|
||||
return memoize(
|
||||
({
|
||||
const visibleElements = this.getVisibleCanvasElements({
|
||||
elementsMap,
|
||||
zoom,
|
||||
offsetLeft,
|
||||
offsetTop,
|
||||
@@ -104,52 +194,69 @@ export class Renderer {
|
||||
scrollY,
|
||||
height,
|
||||
width,
|
||||
editingTextElement,
|
||||
newElementId,
|
||||
// cache-invalidation nonce
|
||||
sceneNonce: _sceneNonce,
|
||||
}: {
|
||||
zoom: AppState["zoom"];
|
||||
offsetLeft: AppState["offsetLeft"];
|
||||
offsetTop: AppState["offsetTop"];
|
||||
scrollX: AppState["scrollX"];
|
||||
scrollY: AppState["scrollY"];
|
||||
height: AppState["height"];
|
||||
width: AppState["width"];
|
||||
editingTextElement: AppState["editingTextElement"];
|
||||
/** note: first render of newElement will always bust the cache
|
||||
* (we'd have to prefilter elements outside of this function) */
|
||||
newElementId: ExcalidrawElement["id"] | undefined;
|
||||
sceneNonce: ReturnType<InstanceType<typeof Scene>["getSceneNonce"]>;
|
||||
}) => {
|
||||
const elements = this.scene.getNonDeletedElements();
|
||||
});
|
||||
|
||||
const elementsMap = getRenderableElements({
|
||||
elements,
|
||||
editingTextElement,
|
||||
newElementId,
|
||||
return {
|
||||
elementsMap,
|
||||
visibleElements,
|
||||
newElementCanvasElement,
|
||||
canvasNonce,
|
||||
};
|
||||
},
|
||||
);
|
||||
|
||||
public getRenderableElements = (opts: GetRenderableElementsOpts) => {
|
||||
const { newElement } = opts;
|
||||
const canvasNonce = `${this.scene.getSceneNonce()}${
|
||||
newElement?.frameId ? `:${newElement.versionNonce}` : ""
|
||||
}`;
|
||||
|
||||
const ret = this._getRenderableElements({
|
||||
canvasNonce,
|
||||
|
||||
// don't spread `opts` because we don't want to memoize on some props
|
||||
|
||||
zoom: opts.zoom,
|
||||
offsetLeft: opts.offsetLeft,
|
||||
offsetTop: opts.offsetTop,
|
||||
scrollX: opts.scrollX,
|
||||
scrollY: opts.scrollY,
|
||||
height: opts.height,
|
||||
width: opts.width,
|
||||
editingTextElement: opts.editingTextElement,
|
||||
newElement: opts.newElement,
|
||||
});
|
||||
|
||||
// if we're dragging elements over a frame, reorder the selected elements
|
||||
// inside the frame during render (we don't set the `element.frameId` until
|
||||
// pointerup else we'd have to painstainly restore the orig index if user
|
||||
// didn't end up adding elements to the frame)
|
||||
if (
|
||||
opts.frameToHighlight &&
|
||||
opts.selectedElementsAreBeingDragged &&
|
||||
// if all dragged elements are already in the frame, don't reorder
|
||||
getCommonFrameId(opts.selectedElements) !== opts.frameToHighlight.id
|
||||
) {
|
||||
const reorderedVisibleElements =
|
||||
this.sortSelectedElementsIntoHighlightedFrame({
|
||||
visibleElements: ret.visibleElements,
|
||||
selectedElements: opts.selectedElements,
|
||||
frameToHighlight: opts.frameToHighlight,
|
||||
});
|
||||
|
||||
const visibleElements = getVisibleCanvasElements({
|
||||
elementsMap,
|
||||
zoom,
|
||||
offsetLeft,
|
||||
offsetTop,
|
||||
scrollX,
|
||||
scrollY,
|
||||
height,
|
||||
width,
|
||||
});
|
||||
return {
|
||||
...ret,
|
||||
visibleElements: reorderedVisibleElements,
|
||||
};
|
||||
}
|
||||
|
||||
return { elementsMap, visibleElements };
|
||||
},
|
||||
);
|
||||
})();
|
||||
return ret;
|
||||
};
|
||||
|
||||
// NOTE Doesn't destroy everything (scene, rc, etc.) because it may not be
|
||||
// safe to break TS contract here (for upstream cases)
|
||||
public destroy() {
|
||||
renderStaticSceneThrottled.cancel();
|
||||
this.getRenderableElements.clear();
|
||||
this._getRenderableElements.clear();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -459,9 +459,7 @@ export const exportToSvg = async (
|
||||
rect.setAttribute("height", `${height}`);
|
||||
rect.setAttribute(
|
||||
"fill",
|
||||
exportWithDarkMode
|
||||
? applyDarkModeFilter(viewBackgroundColor)
|
||||
: viewBackgroundColor,
|
||||
applyDarkModeFilter(viewBackgroundColor, exportWithDarkMode),
|
||||
);
|
||||
svgRoot.appendChild(rect);
|
||||
}
|
||||
|
||||
+84
-538
@@ -39,14 +39,6 @@ import type {
|
||||
} from "./types";
|
||||
|
||||
const SNAP_DISTANCE = 8;
|
||||
// Keep snap candidates with effectively identical offsets together. This needs
|
||||
// to be wider than the 6-decimal rounding quantum to absorb JS floating-point
|
||||
// noise around values like 4 and 4.000001.
|
||||
const SNAP_OFFSET_TOLERANCE = 0.00001;
|
||||
// Point snaps can come from both nearby and distant references within snap
|
||||
// distance. If their visual distances have a large break, prefer the nearest
|
||||
// cluster before comparing offsets.
|
||||
const SNAP_REFERENCE_CLUSTER_BREAK_DISTANCE = 200;
|
||||
|
||||
// do not comput more gaps per axis than this limit
|
||||
// TODO increase or remove once we optimize
|
||||
@@ -57,51 +49,16 @@ export const getSnapDistance = (zoomValue: number) => {
|
||||
return SNAP_DISTANCE / zoomValue;
|
||||
};
|
||||
|
||||
/**
|
||||
* Keeps the cluster threshold visually stable across zoom levels.
|
||||
*/
|
||||
const getSnapReferenceClusterBreakDistance = (zoomValue: number) => {
|
||||
return SNAP_REFERENCE_CLUSTER_BREAK_DISTANCE / zoomValue;
|
||||
};
|
||||
|
||||
type Vector2D = {
|
||||
x: number;
|
||||
y: number;
|
||||
};
|
||||
|
||||
type PointPair = [GlobalPoint, GlobalPoint];
|
||||
type SnapPointType = "outer" | "center";
|
||||
type SnapSourceId = string;
|
||||
|
||||
const SELECTION_SNAP_SOURCE_ID = "selection";
|
||||
|
||||
// Snap source ids let us filter redundant snaplines only within one
|
||||
// selection-to-reference relationship, without mixing separate reference groups.
|
||||
// For example, "selection->rectA" may collapse to its outermost snaplines,
|
||||
// while "selection->rectB" still keeps its own independent snaplines.
|
||||
type SnapPoint = {
|
||||
point: GlobalPoint;
|
||||
type: SnapPointType;
|
||||
snapSourceId: SnapSourceId;
|
||||
};
|
||||
|
||||
const outerSnapPoint = (
|
||||
point: GlobalPoint,
|
||||
snapSourceId = SELECTION_SNAP_SOURCE_ID,
|
||||
): SnapPoint => ({
|
||||
point,
|
||||
type: "outer",
|
||||
snapSourceId,
|
||||
});
|
||||
|
||||
export type PointSnap = {
|
||||
type: "point";
|
||||
points: PointPair;
|
||||
pointTypes: [SnapPointType, SnapPointType];
|
||||
snapSourceIds: [SnapSourceId, SnapSourceId];
|
||||
// Distance along the rendered snapline, used to group visually nearby
|
||||
// references before choosing which point snaps should win.
|
||||
visualDistance: number;
|
||||
offset: number;
|
||||
};
|
||||
|
||||
@@ -163,14 +120,14 @@ export type SnapLine = PointSnapLine | GapSnapLine | PointerSnapLine;
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
export class SnapCache {
|
||||
private static referenceSnapPoints: SnapPoint[] | null = null;
|
||||
private static referenceSnapPoints: GlobalPoint[] | null = null;
|
||||
|
||||
private static visibleGaps: {
|
||||
verticalGaps: Gap[];
|
||||
horizontalGaps: Gap[];
|
||||
} | null = null;
|
||||
|
||||
public static setReferenceSnapPoints = (snapPoints: SnapPoint[] | null) => {
|
||||
public static setReferenceSnapPoints = (snapPoints: GlobalPoint[] | null) => {
|
||||
SnapCache.referenceSnapPoints = snapPoints;
|
||||
};
|
||||
|
||||
@@ -238,17 +195,6 @@ export const areRoughlyEqual = (a: number, b: number, precision = 0.01) => {
|
||||
return Math.abs(a - b) <= precision;
|
||||
};
|
||||
|
||||
/**
|
||||
* Keeps nearly identical snap offsets in the same winner set. This prevents
|
||||
* snapline flicker when rounded geometry differs by a tiny floating-point tail.
|
||||
*/
|
||||
const isWithinSnapOffset = (offset: number, minOffset: number) => {
|
||||
return (
|
||||
Math.abs(offset) <= minOffset ||
|
||||
areRoughlyEqual(Math.abs(offset), minOffset, SNAP_OFFSET_TOLERANCE)
|
||||
);
|
||||
};
|
||||
|
||||
export const getElementsCorners = (
|
||||
elements: ExcalidrawElement[],
|
||||
elementsMap: ElementsMap,
|
||||
@@ -366,81 +312,18 @@ export const getElementsCorners = (
|
||||
return result.map((p) => pointFrom(round(p[0]), round(p[1])));
|
||||
};
|
||||
|
||||
const getElementsSnapPoints = (
|
||||
elements: ExcalidrawElement[],
|
||||
elementsMap: ElementsMap,
|
||||
options: Parameters<typeof getElementsCorners>[2] = {},
|
||||
snapSourceId = SELECTION_SNAP_SOURCE_ID,
|
||||
): SnapPoint[] => {
|
||||
const points = getElementsCorners(elements, elementsMap, options);
|
||||
// getElementsCorners() appends the center point last unless omitCenter is set.
|
||||
const hasCenterPoint = !options.omitCenter && points.length > 0;
|
||||
|
||||
return points.map((point, index) => ({
|
||||
point,
|
||||
type: hasCenterPoint && index === points.length - 1 ? "center" : "outer",
|
||||
snapSourceId,
|
||||
}));
|
||||
};
|
||||
|
||||
/**
|
||||
* Builds a stable identity for one snap reference group. Sorting keeps grouped
|
||||
* elements represented by the same snap source id regardless of element order.
|
||||
*/
|
||||
const getSnapSourceId = (elements: ExcalidrawElement[]) => {
|
||||
return elements
|
||||
.map((element) => element.id)
|
||||
.sort()
|
||||
.join(",");
|
||||
};
|
||||
|
||||
/**
|
||||
* Finds frames that the current selection already belongs to. Their children
|
||||
* are still valid snap references; children of unrelated frames are not.
|
||||
*/
|
||||
const getSelectedFrameIdsForSnapping = (
|
||||
selectedElements: readonly ExcalidrawElement[],
|
||||
) => {
|
||||
const selectedFrameIds = new Set<ExcalidrawElement["id"]>();
|
||||
|
||||
for (const element of selectedElements) {
|
||||
if (element.frameId) {
|
||||
selectedFrameIds.add(element.frameId);
|
||||
}
|
||||
}
|
||||
|
||||
return selectedFrameIds;
|
||||
};
|
||||
|
||||
/**
|
||||
* Frame children are only snap references when the dragged selection is inside
|
||||
* the same frame. This avoids snapping external elements to internals of a
|
||||
* framed diagram.
|
||||
*/
|
||||
const canUseElementAsSnapReference = (
|
||||
element: NonDeletedExcalidrawElement,
|
||||
selectedFrameIds: Set<ExcalidrawElement["id"]>,
|
||||
) => {
|
||||
return !element.frameId || selectedFrameIds.has(element.frameId);
|
||||
};
|
||||
|
||||
const getReferenceElements = (
|
||||
elements: readonly NonDeletedExcalidrawElement[],
|
||||
selectedElements: NonDeletedExcalidrawElement[],
|
||||
appState: AppState,
|
||||
elementsMap: ElementsMap,
|
||||
) => {
|
||||
const selectedFrameIds = getSelectedFrameIdsForSnapping(selectedElements);
|
||||
|
||||
return getVisibleAndNonSelectedElements(
|
||||
) =>
|
||||
getVisibleAndNonSelectedElements(
|
||||
elements,
|
||||
selectedElements,
|
||||
appState,
|
||||
elementsMap,
|
||||
).filter((element) => {
|
||||
return canUseElementAsSnapReference(element, selectedFrameIds);
|
||||
});
|
||||
};
|
||||
);
|
||||
|
||||
export const getVisibleGaps = (
|
||||
elements: readonly NonDeletedExcalidrawElement[],
|
||||
@@ -599,10 +482,7 @@ const getGapSnaps = (
|
||||
const centerOffset = round(gapMidX - centerX);
|
||||
const gapIsLargerThanSelection = gap.length > maxX - minX;
|
||||
|
||||
if (
|
||||
gapIsLargerThanSelection &&
|
||||
isWithinSnapOffset(centerOffset, minOffset.x)
|
||||
) {
|
||||
if (gapIsLargerThanSelection && Math.abs(centerOffset) <= minOffset.x) {
|
||||
if (Math.abs(centerOffset) < minOffset.x) {
|
||||
nearestSnapsX.length = 0;
|
||||
}
|
||||
@@ -624,7 +504,7 @@ const getGapSnaps = (
|
||||
const distanceToEndElementX = minX - endMaxX;
|
||||
const sideOffsetRight = round(gap.length - distanceToEndElementX);
|
||||
|
||||
if (isWithinSnapOffset(sideOffsetRight, minOffset.x)) {
|
||||
if (Math.abs(sideOffsetRight) <= minOffset.x) {
|
||||
if (Math.abs(sideOffsetRight) < minOffset.x) {
|
||||
nearestSnapsX.length = 0;
|
||||
}
|
||||
@@ -645,7 +525,7 @@ const getGapSnaps = (
|
||||
const distanceToStartElementX = startMinX - maxX;
|
||||
const sideOffsetLeft = round(distanceToStartElementX - gap.length);
|
||||
|
||||
if (isWithinSnapOffset(sideOffsetLeft, minOffset.x)) {
|
||||
if (Math.abs(sideOffsetLeft) <= minOffset.x) {
|
||||
if (Math.abs(sideOffsetLeft) < minOffset.x) {
|
||||
nearestSnapsX.length = 0;
|
||||
}
|
||||
@@ -671,10 +551,7 @@ const getGapSnaps = (
|
||||
const centerOffset = round(gapMidY - centerY);
|
||||
const gapIsLargerThanSelection = gap.length > maxY - minY;
|
||||
|
||||
if (
|
||||
gapIsLargerThanSelection &&
|
||||
isWithinSnapOffset(centerOffset, minOffset.y)
|
||||
) {
|
||||
if (gapIsLargerThanSelection && Math.abs(centerOffset) <= minOffset.y) {
|
||||
if (Math.abs(centerOffset) < minOffset.y) {
|
||||
nearestSnapsY.length = 0;
|
||||
}
|
||||
@@ -696,7 +573,7 @@ const getGapSnaps = (
|
||||
const distanceToStartElementY = startMinY - maxY;
|
||||
const sideOffsetTop = round(distanceToStartElementY - gap.length);
|
||||
|
||||
if (isWithinSnapOffset(sideOffsetTop, minOffset.y)) {
|
||||
if (Math.abs(sideOffsetTop) <= minOffset.y) {
|
||||
if (Math.abs(sideOffsetTop) < minOffset.y) {
|
||||
nearestSnapsY.length = 0;
|
||||
}
|
||||
@@ -717,7 +594,7 @@ const getGapSnaps = (
|
||||
const distanceToEndElementY = round(minY - endMaxY);
|
||||
const sideOffsetBottom = gap.length - distanceToEndElementY;
|
||||
|
||||
if (isWithinSnapOffset(sideOffsetBottom, minOffset.y)) {
|
||||
if (Math.abs(sideOffsetBottom) <= minOffset.y) {
|
||||
if (Math.abs(sideOffsetBottom) < minOffset.y) {
|
||||
nearestSnapsY.length = 0;
|
||||
}
|
||||
@@ -736,102 +613,6 @@ const getGapSnaps = (
|
||||
}
|
||||
};
|
||||
|
||||
/**
|
||||
* Narrows point snaps to the nearest visual cluster, then keeps the best offset
|
||||
* inside that cluster. If all references look continuous, this preserves the
|
||||
* old smallest-offset behavior.
|
||||
*/
|
||||
const filterPointSnapsToNearestCluster = (
|
||||
snaps: Snaps,
|
||||
clusterBreakDistance: number,
|
||||
) => {
|
||||
const pointSnaps = snaps.filter(
|
||||
(snap): snap is PointSnap => snap.type === "point",
|
||||
);
|
||||
|
||||
if (pointSnaps.length < 2) {
|
||||
return;
|
||||
}
|
||||
|
||||
const snapsByOffset = new Map<number, PointSnap[]>();
|
||||
|
||||
for (const snap of pointSnaps) {
|
||||
const offset = round(snap.offset);
|
||||
const offsetSnaps = snapsByOffset.get(offset) ?? [];
|
||||
offsetSnaps.push(snap);
|
||||
snapsByOffset.set(offset, offsetSnaps);
|
||||
}
|
||||
|
||||
const keptPointSnaps = new Set<PointSnap>();
|
||||
const offsetGroups = Array.from(snapsByOffset.entries()).map(
|
||||
([offset, offsetSnaps]) => ({
|
||||
offset,
|
||||
snaps: offsetSnaps,
|
||||
visualDistance: Math.min(
|
||||
...offsetSnaps.map((snap) => snap.visualDistance),
|
||||
),
|
||||
}),
|
||||
);
|
||||
const sortedOffsetGroups = offsetGroups
|
||||
.slice()
|
||||
.sort((a, b) => a.visualDistance - b.visualDistance);
|
||||
let keepOffsetGroupsUntil = sortedOffsetGroups.length;
|
||||
|
||||
// Prefer a nearby reference cluster before comparing offset. If there is no
|
||||
// clear distance break, this keeps all offsets and falls back to the old
|
||||
// smallest-offset behavior.
|
||||
for (let i = 1; i < sortedOffsetGroups.length; i++) {
|
||||
const distanceGap =
|
||||
sortedOffsetGroups[i].visualDistance -
|
||||
sortedOffsetGroups[i - 1].visualDistance;
|
||||
|
||||
if (distanceGap > clusterBreakDistance) {
|
||||
keepOffsetGroupsUntil = i;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
const nearestOffsetGroups = sortedOffsetGroups.slice(
|
||||
0,
|
||||
keepOffsetGroupsUntil,
|
||||
);
|
||||
const minOffset = Math.min(
|
||||
...nearestOffsetGroups.map(({ offset }) => Math.abs(offset)),
|
||||
);
|
||||
const selectedOffsets = nearestOffsetGroups
|
||||
.filter(({ offset }) =>
|
||||
areRoughlyEqual(Math.abs(offset), minOffset, SNAP_OFFSET_TOLERANCE),
|
||||
)
|
||||
.map(({ offset }) => offset);
|
||||
|
||||
for (const offsetSnaps of snapsByOffset.values()) {
|
||||
if (
|
||||
!selectedOffsets.some((offset) =>
|
||||
areRoughlyEqual(
|
||||
round(offsetSnaps[0].offset),
|
||||
offset,
|
||||
SNAP_OFFSET_TOLERANCE,
|
||||
),
|
||||
)
|
||||
) {
|
||||
continue;
|
||||
}
|
||||
|
||||
offsetSnaps.forEach((snap) => keptPointSnaps.add(snap));
|
||||
}
|
||||
|
||||
let writeIndex = 0;
|
||||
|
||||
for (const snap of snaps) {
|
||||
if (snap.type !== "point" || keptPointSnaps.has(snap)) {
|
||||
snaps[writeIndex] = snap;
|
||||
writeIndex++;
|
||||
}
|
||||
}
|
||||
|
||||
snaps.length = writeIndex;
|
||||
};
|
||||
|
||||
export const getReferenceSnapPoints = (
|
||||
elements: readonly NonDeletedExcalidrawElement[],
|
||||
selectedElements: ExcalidrawElement[],
|
||||
@@ -849,24 +630,12 @@ export const getReferenceSnapPoints = (
|
||||
(elementsGroup) =>
|
||||
!(elementsGroup.length === 1 && isBoundToContainer(elementsGroup[0])),
|
||||
)
|
||||
.flatMap((elementGroup) =>
|
||||
getElementsSnapPoints(
|
||||
elementGroup,
|
||||
elementsMap,
|
||||
{},
|
||||
getSnapSourceId(elementGroup),
|
||||
),
|
||||
);
|
||||
.flatMap((elementGroup) => getElementsCorners(elementGroup, elementsMap));
|
||||
};
|
||||
|
||||
/**
|
||||
* Collects point snaps within snap distance. Unlike gap snaps, point snaps first
|
||||
* go through visual-cluster filtering so a nearby reference can beat a slightly
|
||||
* better offset from a far-away reference.
|
||||
*/
|
||||
const getPointSnaps = (
|
||||
selectedElements: ExcalidrawElement[],
|
||||
selectionSnapPoints: SnapPoint[],
|
||||
selectionSnapPoints: GlobalPoint[],
|
||||
app: AppClassProperties,
|
||||
event: KeyboardModifiersObject,
|
||||
nearestSnapsX: Snaps,
|
||||
@@ -885,62 +654,39 @@ const getPointSnaps = (
|
||||
if (referenceSnapPoints) {
|
||||
for (const thisSnapPoint of selectionSnapPoints) {
|
||||
for (const otherSnapPoint of referenceSnapPoints) {
|
||||
const offsetX = otherSnapPoint.point[0] - thisSnapPoint.point[0];
|
||||
const offsetY = otherSnapPoint.point[1] - thisSnapPoint.point[1];
|
||||
const offsetX = otherSnapPoint[0] - thisSnapPoint[0];
|
||||
const offsetY = otherSnapPoint[1] - thisSnapPoint[1];
|
||||
|
||||
if (Math.abs(offsetX) <= minOffset.x) {
|
||||
if (Math.abs(offsetX) < minOffset.x) {
|
||||
nearestSnapsX.length = 0;
|
||||
}
|
||||
|
||||
if (isWithinSnapOffset(offsetX, minOffset.x)) {
|
||||
nearestSnapsX.push({
|
||||
type: "point",
|
||||
points: [thisSnapPoint.point, otherSnapPoint.point],
|
||||
pointTypes: [thisSnapPoint.type, otherSnapPoint.type],
|
||||
snapSourceIds: [
|
||||
thisSnapPoint.snapSourceId,
|
||||
otherSnapPoint.snapSourceId,
|
||||
],
|
||||
visualDistance: Math.abs(
|
||||
otherSnapPoint.point[1] - thisSnapPoint.point[1],
|
||||
),
|
||||
points: [thisSnapPoint, otherSnapPoint],
|
||||
offset: offsetX,
|
||||
});
|
||||
|
||||
minOffset.x = Math.abs(offsetX);
|
||||
}
|
||||
|
||||
if (isWithinSnapOffset(offsetY, minOffset.y)) {
|
||||
if (Math.abs(offsetY) <= minOffset.y) {
|
||||
if (Math.abs(offsetY) < minOffset.y) {
|
||||
nearestSnapsY.length = 0;
|
||||
}
|
||||
|
||||
nearestSnapsY.push({
|
||||
type: "point",
|
||||
points: [thisSnapPoint.point, otherSnapPoint.point],
|
||||
pointTypes: [thisSnapPoint.type, otherSnapPoint.type],
|
||||
snapSourceIds: [
|
||||
thisSnapPoint.snapSourceId,
|
||||
otherSnapPoint.snapSourceId,
|
||||
],
|
||||
visualDistance: Math.abs(
|
||||
otherSnapPoint.point[0] - thisSnapPoint.point[0],
|
||||
),
|
||||
points: [thisSnapPoint, otherSnapPoint],
|
||||
offset: offsetY,
|
||||
});
|
||||
|
||||
minOffset.y = Math.abs(offsetY);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
const clusterBreakDistance = getSnapReferenceClusterBreakDistance(
|
||||
app.state.zoom.value,
|
||||
);
|
||||
|
||||
filterPointSnapsToNearestCluster(nearestSnapsX, clusterBreakDistance);
|
||||
filterPointSnapsToNearestCluster(nearestSnapsY, clusterBreakDistance);
|
||||
|
||||
if (nearestSnapsX.length > 0) {
|
||||
minOffset.x = Math.min(
|
||||
...nearestSnapsX.map((snap) => Math.abs(snap.offset)),
|
||||
);
|
||||
}
|
||||
|
||||
if (nearestSnapsY.length > 0) {
|
||||
minOffset.y = Math.min(
|
||||
...nearestSnapsY.map((snap) => Math.abs(snap.offset)),
|
||||
);
|
||||
}
|
||||
};
|
||||
|
||||
export const snapDraggedElements = (
|
||||
@@ -974,7 +720,7 @@ export const snapDraggedElements = (
|
||||
y: snapDistance,
|
||||
};
|
||||
|
||||
const selectionPoints = getElementsSnapPoints(selectedElements, elementsMap, {
|
||||
const selectionPoints = getElementsCorners(selectedElements, elementsMap, {
|
||||
dragOffset,
|
||||
});
|
||||
|
||||
@@ -1024,7 +770,7 @@ export const snapDraggedElements = (
|
||||
|
||||
getPointSnaps(
|
||||
selectedElements,
|
||||
getElementsSnapPoints(selectedElements, elementsMap, {
|
||||
getElementsCorners(selectedElements, elementsMap, {
|
||||
dragOffset: newDragOffset,
|
||||
}),
|
||||
app,
|
||||
@@ -1079,185 +825,12 @@ const dedupePoints = (points: GlobalPoint[]): GlobalPoint[] => {
|
||||
return Array.from(map.values());
|
||||
};
|
||||
|
||||
// Point snaplines are collected from every winning point snap first. Multiple
|
||||
// snap source pairs can collapse to the same rendered line, so candidates keep
|
||||
// source-pair metadata until redundant center and inner outer lines are removed.
|
||||
type PointSnapLineSourcePair = {
|
||||
snapSourcePairKey: string;
|
||||
pointType: SnapPointType;
|
||||
};
|
||||
|
||||
type PointSnapLineCandidate = PointSnapLine & {
|
||||
sourcePairs: PointSnapLineSourcePair[];
|
||||
};
|
||||
|
||||
type PointSnapLineBucket = {
|
||||
points: GlobalPoint[];
|
||||
sourcePairs: PointSnapLineSourcePair[];
|
||||
};
|
||||
|
||||
type OuterSnapLineCoordinateRange = {
|
||||
count: number;
|
||||
min: number;
|
||||
max: number;
|
||||
};
|
||||
|
||||
/**
|
||||
* Describes which snap source pair produced a rendered point snapline, so later
|
||||
* filtering can reason about redundancy without mixing unrelated references.
|
||||
* Only center-to-center snaps count as center snaplines; a center-to-outer snap
|
||||
* still explains an outer edge or midpoint alignment.
|
||||
*/
|
||||
const getPointSnapLineSourcePair = (
|
||||
snap: PointSnap,
|
||||
): PointSnapLineSourcePair => {
|
||||
return {
|
||||
snapSourcePairKey: snap.snapSourceIds.join("->"),
|
||||
pointType: snap.pointTypes.every((pointType) => pointType === "center")
|
||||
? "center"
|
||||
: "outer",
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Builds each snap source pair's outer coordinate range. Center snaplines use
|
||||
* this range to decide whether the surrounding outer lines already explain
|
||||
* them, and outer snaplines use it to keep only the two extremes.
|
||||
*/
|
||||
const getOuterCoordinateRangesBySnapSourcePairKey = (
|
||||
snapLines: PointSnapLineCandidate[],
|
||||
getCoordinate: (snapLine: PointSnapLine) => number,
|
||||
) => {
|
||||
const ranges = new Map<string, OuterSnapLineCoordinateRange>();
|
||||
|
||||
for (const snapLine of snapLines) {
|
||||
const coordinate = getCoordinate(snapLine);
|
||||
|
||||
for (const sourcePair of snapLine.sourcePairs) {
|
||||
if (sourcePair.pointType === "center") {
|
||||
continue;
|
||||
}
|
||||
|
||||
const range = ranges.get(sourcePair.snapSourcePairKey);
|
||||
|
||||
ranges.set(sourcePair.snapSourcePairKey, {
|
||||
count: (range?.count ?? 0) + 1,
|
||||
min: range ? Math.min(range.min, coordinate) : coordinate,
|
||||
max: range ? Math.max(range.max, coordinate) : coordinate,
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
return ranges;
|
||||
};
|
||||
|
||||
/**
|
||||
* A center snapline is redundant when outer snaplines from the same snap source
|
||||
* pair exist on both sides, because the outer lines already imply center
|
||||
* alignment.
|
||||
*/
|
||||
const isRedundantCenterSnapLine = (
|
||||
coordinate: number,
|
||||
outerCoordinateRange?: OuterSnapLineCoordinateRange,
|
||||
) => {
|
||||
if (!outerCoordinateRange) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return (
|
||||
outerCoordinateRange.min < coordinate &&
|
||||
outerCoordinateRange.max > coordinate
|
||||
);
|
||||
};
|
||||
|
||||
/**
|
||||
* When more than two outer snaplines come from the same snap source pair, the
|
||||
* inner ones are redundant; the two extremes communicate the same shape
|
||||
* alignment.
|
||||
*/
|
||||
const isRedundantOuterSnapLine = (
|
||||
coordinate: number,
|
||||
outerCoordinateRange?: OuterSnapLineCoordinateRange,
|
||||
) => {
|
||||
if (!outerCoordinateRange || outerCoordinateRange.count <= 2) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return (
|
||||
coordinate !== outerCoordinateRange.min &&
|
||||
coordinate !== outerCoordinateRange.max
|
||||
);
|
||||
};
|
||||
|
||||
/**
|
||||
* Keeps a visual snapline if at least one snap source pair represented by the
|
||||
* line still needs it. This matters when multiple snap source pairs collapse to
|
||||
* the same rendered coordinate.
|
||||
*/
|
||||
const isPointSnapLineNeededBySourcePair = (
|
||||
sourcePair: PointSnapLineSourcePair,
|
||||
coordinate: number,
|
||||
outerCoordinateRangesBySnapSourcePairKey: Map<
|
||||
string,
|
||||
OuterSnapLineCoordinateRange
|
||||
>,
|
||||
) => {
|
||||
const outerCoordinateRange = outerCoordinateRangesBySnapSourcePairKey.get(
|
||||
sourcePair.snapSourcePairKey,
|
||||
);
|
||||
|
||||
if (sourcePair.pointType === "center") {
|
||||
return !isRedundantCenterSnapLine(coordinate, outerCoordinateRange);
|
||||
}
|
||||
|
||||
return !isRedundantOuterSnapLine(coordinate, outerCoordinateRange);
|
||||
};
|
||||
|
||||
/**
|
||||
* Removes point snaplines that are visually redundant, while preserving any line
|
||||
* that is still needed by at least one snap source pair represented on that
|
||||
* line.
|
||||
*/
|
||||
const filterRedundantPointSnapLines = (
|
||||
snapLines: PointSnapLineCandidate[],
|
||||
getCoordinate: (snapLine: PointSnapLine) => number,
|
||||
): PointSnapLine[] => {
|
||||
if (snapLines.length < 3) {
|
||||
return snapLines.map(({ sourcePairs, ...snapLine }) => snapLine);
|
||||
}
|
||||
|
||||
// Track outer-line ranges per snap source pair. The same visual snapline can
|
||||
// be produced by multiple snap source pairs, so a line is removed only when
|
||||
// every pair represented by that line considers it redundant.
|
||||
const outerCoordinateRangesBySnapSourcePairKey =
|
||||
getOuterCoordinateRangesBySnapSourcePairKey(snapLines, getCoordinate);
|
||||
|
||||
return snapLines
|
||||
.filter((snapLine) => {
|
||||
const coordinate = getCoordinate(snapLine);
|
||||
|
||||
return snapLine.sourcePairs.some((sourcePair) =>
|
||||
isPointSnapLineNeededBySourcePair(
|
||||
sourcePair,
|
||||
coordinate,
|
||||
outerCoordinateRangesBySnapSourcePairKey,
|
||||
),
|
||||
);
|
||||
})
|
||||
.map(({ sourcePairs, ...snapLine }) => snapLine);
|
||||
};
|
||||
|
||||
/**
|
||||
* Merges point snaps that render on the same x/y coordinate, attaches their
|
||||
* snap source pair metadata, then removes redundant center and inner outer
|
||||
* lines.
|
||||
*/
|
||||
const createPointSnapLines = (
|
||||
nearestSnapsX: Snaps,
|
||||
nearestSnapsY: Snaps,
|
||||
): PointSnapLine[] => {
|
||||
const snapsX = {} as { [key: string]: PointSnapLineBucket };
|
||||
const snapsY = {} as { [key: string]: PointSnapLineBucket };
|
||||
const snapsX = {} as { [key: string]: GlobalPoint[] };
|
||||
const snapsY = {} as { [key: string]: GlobalPoint[] };
|
||||
|
||||
if (nearestSnapsX.length > 0) {
|
||||
for (const snap of nearestSnapsX) {
|
||||
@@ -1265,14 +838,13 @@ const createPointSnapLines = (
|
||||
// key = thisPoint.x
|
||||
const key = round(snap.points[0][0]);
|
||||
if (!snapsX[key]) {
|
||||
snapsX[key] = { points: [], sourcePairs: [] };
|
||||
snapsX[key] = [];
|
||||
}
|
||||
snapsX[key].points.push(
|
||||
snapsX[key].push(
|
||||
...snap.points.map((p) =>
|
||||
pointFrom<GlobalPoint>(round(p[0]), round(p[1])),
|
||||
),
|
||||
);
|
||||
snapsX[key].sourcePairs.push(getPointSnapLineSourcePair(snap));
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1283,55 +855,44 @@ const createPointSnapLines = (
|
||||
// key = thisPoint.y
|
||||
const key = round(snap.points[0][1]);
|
||||
if (!snapsY[key]) {
|
||||
snapsY[key] = { points: [], sourcePairs: [] };
|
||||
snapsY[key] = [];
|
||||
}
|
||||
snapsY[key].points.push(
|
||||
snapsY[key].push(
|
||||
...snap.points.map((p) =>
|
||||
pointFrom<GlobalPoint>(round(p[0]), round(p[1])),
|
||||
),
|
||||
);
|
||||
snapsY[key].sourcePairs.push(getPointSnapLineSourcePair(snap));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
const snapLinesX = Object.entries(snapsX).map(([key, snap]) => {
|
||||
return {
|
||||
type: "points",
|
||||
points: dedupePoints(
|
||||
snap.points
|
||||
.map((p) => {
|
||||
return pointFrom<GlobalPoint>(Number(key), p[1]);
|
||||
})
|
||||
.sort((a, b) => a[1] - b[1]),
|
||||
),
|
||||
sourcePairs: snap.sourcePairs,
|
||||
} as PointSnapLineCandidate;
|
||||
});
|
||||
|
||||
const snapLinesY = Object.entries(snapsY).map(([key, snap]) => {
|
||||
return {
|
||||
type: "points",
|
||||
points: dedupePoints(
|
||||
snap.points
|
||||
.map((p) => {
|
||||
return pointFrom<GlobalPoint>(p[0], Number(key));
|
||||
})
|
||||
.sort((a, b) => a[0] - b[0]),
|
||||
),
|
||||
sourcePairs: snap.sourcePairs,
|
||||
} as PointSnapLineCandidate;
|
||||
});
|
||||
|
||||
return filterRedundantPointSnapLines(
|
||||
snapLinesX,
|
||||
(snapLine) => snapLine.points[0][0],
|
||||
).concat(
|
||||
filterRedundantPointSnapLines(
|
||||
snapLinesY,
|
||||
(snapLine) => snapLine.points[0][1],
|
||||
),
|
||||
);
|
||||
return Object.entries(snapsX)
|
||||
.map(([key, points]) => {
|
||||
return {
|
||||
type: "points",
|
||||
points: dedupePoints(
|
||||
points
|
||||
.map((p) => {
|
||||
return pointFrom<GlobalPoint>(Number(key), p[1]);
|
||||
})
|
||||
.sort((a, b) => a[1] - b[1]),
|
||||
),
|
||||
} as PointSnapLine;
|
||||
})
|
||||
.concat(
|
||||
Object.entries(snapsY).map(([key, points]) => {
|
||||
return {
|
||||
type: "points",
|
||||
points: dedupePoints(
|
||||
points
|
||||
.map((p) => {
|
||||
return pointFrom<GlobalPoint>(p[0], Number(key));
|
||||
})
|
||||
.sort((a, b) => a[0] - b[0]),
|
||||
),
|
||||
} as PointSnapLine;
|
||||
}),
|
||||
);
|
||||
};
|
||||
|
||||
const dedupeGapSnapLines = (gapSnapLines: GapSnapLine[]) => {
|
||||
@@ -1356,13 +917,10 @@ const createGapSnapLines = (
|
||||
dragOffset: Vector2D,
|
||||
gapSnaps: GapSnap[],
|
||||
): GapSnapLine[] => {
|
||||
// Use the same rounded bounds as getGapSnaps(). Otherwise a gap snap can be
|
||||
// accepted during snapping but skipped here because the raw bounds miss the
|
||||
// reference gap overlap by a tiny floating-point delta.
|
||||
const [minX, minY, maxX, maxY] = getDraggedElementsBounds(
|
||||
selectedElements,
|
||||
dragOffset,
|
||||
).map((bound) => round(bound));
|
||||
);
|
||||
|
||||
const gapSnapLines: GapSnapLine[] = [];
|
||||
|
||||
@@ -1585,52 +1143,40 @@ export const snapResizingElements = (
|
||||
}
|
||||
}
|
||||
|
||||
const selectionSnapPoints: SnapPoint[] = [];
|
||||
const selectionSnapPoints: GlobalPoint[] = [];
|
||||
|
||||
if (transformHandle) {
|
||||
switch (transformHandle) {
|
||||
case "e": {
|
||||
selectionSnapPoints.push(
|
||||
outerSnapPoint(pointFrom(maxX, minY)),
|
||||
outerSnapPoint(pointFrom(maxX, maxY)),
|
||||
);
|
||||
selectionSnapPoints.push(pointFrom(maxX, minY), pointFrom(maxX, maxY));
|
||||
break;
|
||||
}
|
||||
case "w": {
|
||||
selectionSnapPoints.push(
|
||||
outerSnapPoint(pointFrom(minX, minY)),
|
||||
outerSnapPoint(pointFrom(minX, maxY)),
|
||||
);
|
||||
selectionSnapPoints.push(pointFrom(minX, minY), pointFrom(minX, maxY));
|
||||
break;
|
||||
}
|
||||
case "n": {
|
||||
selectionSnapPoints.push(
|
||||
outerSnapPoint(pointFrom(minX, minY)),
|
||||
outerSnapPoint(pointFrom(maxX, minY)),
|
||||
);
|
||||
selectionSnapPoints.push(pointFrom(minX, minY), pointFrom(maxX, minY));
|
||||
break;
|
||||
}
|
||||
case "s": {
|
||||
selectionSnapPoints.push(
|
||||
outerSnapPoint(pointFrom(minX, maxY)),
|
||||
outerSnapPoint(pointFrom(maxX, maxY)),
|
||||
);
|
||||
selectionSnapPoints.push(pointFrom(minX, maxY), pointFrom(maxX, maxY));
|
||||
break;
|
||||
}
|
||||
case "ne": {
|
||||
selectionSnapPoints.push(outerSnapPoint(pointFrom(maxX, minY)));
|
||||
selectionSnapPoints.push(pointFrom(maxX, minY));
|
||||
break;
|
||||
}
|
||||
case "nw": {
|
||||
selectionSnapPoints.push(outerSnapPoint(pointFrom(minX, minY)));
|
||||
selectionSnapPoints.push(pointFrom(minX, minY));
|
||||
break;
|
||||
}
|
||||
case "se": {
|
||||
selectionSnapPoints.push(outerSnapPoint(pointFrom(maxX, maxY)));
|
||||
selectionSnapPoints.push(pointFrom(maxX, maxY));
|
||||
break;
|
||||
}
|
||||
case "sw": {
|
||||
selectionSnapPoints.push(outerSnapPoint(pointFrom(minX, maxY)));
|
||||
selectionSnapPoints.push(pointFrom(minX, maxY));
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -1672,11 +1218,11 @@ export const snapResizingElements = (
|
||||
round(bound),
|
||||
);
|
||||
|
||||
const corners: SnapPoint[] = [
|
||||
outerSnapPoint(pointFrom(x1, y1)),
|
||||
outerSnapPoint(pointFrom(x1, y2)),
|
||||
outerSnapPoint(pointFrom(x2, y1)),
|
||||
outerSnapPoint(pointFrom(x2, y2)),
|
||||
const corners: GlobalPoint[] = [
|
||||
pointFrom(x1, y1),
|
||||
pointFrom(x1, y2),
|
||||
pointFrom(x2, y1),
|
||||
pointFrom(x2, y2),
|
||||
];
|
||||
|
||||
getPointSnaps(
|
||||
@@ -1712,8 +1258,8 @@ export const snapNewElement = (
|
||||
};
|
||||
}
|
||||
|
||||
const selectionSnapPoints: SnapPoint[] = [
|
||||
outerSnapPoint(pointFrom(origin.x + dragOffset.x, origin.y + dragOffset.y)),
|
||||
const selectionSnapPoints: GlobalPoint[] = [
|
||||
pointFrom(origin.x + dragOffset.x, origin.y + dragOffset.y),
|
||||
];
|
||||
|
||||
const snapDistance = getSnapDistance(app.state.zoom.value);
|
||||
@@ -1746,7 +1292,7 @@ export const snapNewElement = (
|
||||
nearestSnapsX.length = 0;
|
||||
nearestSnapsY.length = 0;
|
||||
|
||||
const corners = getElementsSnapPoints([newElement], elementsMap, {
|
||||
const corners = getElementsCorners([newElement], elementsMap, {
|
||||
boundingBoxCorners: true,
|
||||
omitCenter: true,
|
||||
});
|
||||
|
||||
@@ -83,6 +83,26 @@ mockMermaidToExcalidraw({
|
||||
},
|
||||
});
|
||||
|
||||
const normalizeDialogSnapshot = (dialog: Element) => {
|
||||
const dialogClone = dialog.cloneNode(true) as HTMLElement;
|
||||
|
||||
dialogClone
|
||||
.querySelectorAll<HTMLElement>(".ttd-dialog-content")
|
||||
.forEach((element) => {
|
||||
// Radix Tabs injects this during initial mount animation prevention.
|
||||
// Its presence depends on render timing and is unrelated to this test.
|
||||
if (element.style.animationDuration === "0s") {
|
||||
element.style.removeProperty("animation-duration");
|
||||
}
|
||||
|
||||
if (!element.getAttribute("style")) {
|
||||
element.removeAttribute("style");
|
||||
}
|
||||
});
|
||||
|
||||
return dialogClone.outerHTML;
|
||||
};
|
||||
|
||||
describe("Test <MermaidToExcalidraw/>", () => {
|
||||
beforeEach(async () => {
|
||||
await render(
|
||||
@@ -99,7 +119,7 @@ describe("Test <MermaidToExcalidraw/>", () => {
|
||||
it("should open mermaid popup when active tool is mermaid", async () => {
|
||||
const dialog = document.querySelector(".ttd-dialog")!;
|
||||
await waitFor(() => expect(dialog.querySelector("canvas")).not.toBeNull());
|
||||
expect(dialog.outerHTML).toMatchSnapshot();
|
||||
expect(normalizeDialogSnapshot(dialog)).toMatchSnapshot();
|
||||
});
|
||||
|
||||
it("should show error in preview when mermaid library throws error", async () => {
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
|
||||
|
||||
exports[`Test <MermaidToExcalidraw/> > should open mermaid popup when active tool is mermaid 1`] = `"<div class="Modal Dialog ttd-dialog" role="dialog" aria-modal="true" aria-labelledby="dialog-title"><div class="Modal__background"></div><div class="Modal__content" style="--max-width: 1520px;" tabindex="0"><div class="Island"><div class="Dialog__content"><div dir="ltr" data-orientation="horizontal" class="ttd-dialog-tabs-root"><p class="dialog-mermaid-title">Mermaid to Excalidraw</p><div data-state="active" data-orientation="horizontal" role="tabpanel" aria-labelledby="radix-:r4:-trigger-mermaid" id="radix-:r4:-content-mermaid" tabindex="0" class="ttd-dialog-content" style=""><div class="ttd-dialog-desc">Currently only <a href="https://mermaid.js.org/syntax/flowchart.html" target="_blank" rel="noreferrer">Flowchart</a>, <a href="https://mermaid.js.org/syntax/sequenceDiagram.html" target="_blank" rel="noreferrer">Sequence</a>, <a href="https://mermaid.js.org/syntax/classDiagram.html" target="_blank" rel="noreferrer">Class</a>, and <a href="https://mermaid.js.org/syntax/entityRelationshipDiagram.html" target="_blank" rel="noreferrer">Entity Relationship</a> Diagrams are supported. The other types will be rendered as image in Excalidraw.</div><div class="ttd-dialog-panels"><div class="ttd-dialog-panel"><div class="ttd-dialog-panel-button-container invisible" style="justify-content: flex-start;"></div></div><div class="ttd-dialog-panel"><div class="ttd-dialog-output-wrapper "><div class="ttd-dialog-output-canvas-container"><div class="ttd-dialog-output-canvas-content"><canvas width="89" height="158" dir="ltr"></canvas></div></div></div><div class="ttd-dialog-panel-button-container" style="justify-content: flex-start;"><button type="button" class="excalidraw-button ttd-dialog-panel-button"><div class="">Insert<span><svg aria-hidden="true" focusable="false" role="img" viewBox="0 0 20 20" class="" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round"><g stroke-width="1.25"><path d="M4.16602 10H15.8327"></path><path d="M12.5 13.3333L15.8333 10"></path><path d="M12.5 6.66666L15.8333 9.99999"></path></g></svg></span></div></button><div class="ttd-dialog-submit-shortcut"><div class="ttd-dialog-submit-shortcut__key">Ctrl</div><div class="ttd-dialog-submit-shortcut__key">Enter</div></div></div></div></div></div></div></div></div></div></div>"`;
|
||||
exports[`Test <MermaidToExcalidraw/> > should open mermaid popup when active tool is mermaid 1`] = `"<div class="Modal Dialog ttd-dialog" role="dialog" aria-modal="true" aria-labelledby="dialog-title"><div class="Modal__background"></div><div class="Modal__content" style="--max-width: 1520px;" tabindex="0"><div class="Island"><div class="Dialog__content"><div dir="ltr" data-orientation="horizontal" class="ttd-dialog-tabs-root"><p class="dialog-mermaid-title">Mermaid to Excalidraw</p><div data-state="active" data-orientation="horizontal" role="tabpanel" aria-labelledby="radix-:r4:-trigger-mermaid" id="radix-:r4:-content-mermaid" tabindex="0" class="ttd-dialog-content"><div class="ttd-dialog-desc">Currently only <a href="https://mermaid.js.org/syntax/flowchart.html" target="_blank" rel="noreferrer">Flowchart</a>, <a href="https://mermaid.js.org/syntax/sequenceDiagram.html" target="_blank" rel="noreferrer">Sequence</a>, <a href="https://mermaid.js.org/syntax/classDiagram.html" target="_blank" rel="noreferrer">Class</a>, and <a href="https://mermaid.js.org/syntax/entityRelationshipDiagram.html" target="_blank" rel="noreferrer">Entity Relationship</a> Diagrams are supported. The other types will be rendered as image in Excalidraw.</div><div class="ttd-dialog-panels"><div class="ttd-dialog-panel"><div class="ttd-dialog-panel-button-container invisible" style="justify-content: flex-start;"></div></div><div class="ttd-dialog-panel"><div class="ttd-dialog-output-wrapper "><div class="ttd-dialog-output-canvas-container"><div class="ttd-dialog-output-canvas-content"><canvas width="89" height="158" dir="ltr"></canvas></div></div></div><div class="ttd-dialog-panel-button-container" style="justify-content: flex-start;"><button type="button" class="excalidraw-button ttd-dialog-panel-button"><div class="">Insert<span><svg aria-hidden="true" focusable="false" role="img" viewBox="0 0 20 20" class="" fill="none" stroke="currentColor" stroke-linecap="round" stroke-linejoin="round"><g stroke-width="1.25"><path d="M4.16602 10H15.8327"></path><path d="M12.5 13.3333L15.8333 10"></path><path d="M12.5 6.66666L15.8333 9.99999"></path></g></svg></span></div></button><div class="ttd-dialog-submit-shortcut"><div class="ttd-dialog-submit-shortcut__key">Ctrl</div><div class="ttd-dialog-submit-shortcut__key">Enter</div></div></div></div></div></div></div></div></div></div></div>"`;
|
||||
|
||||
exports[`Test <MermaidToExcalidraw/> > should show error in preview when mermaid library throws error 1`] = `
|
||||
"flowchart TD
|
||||
|
||||
@@ -898,6 +898,7 @@ exports[`contextMenu element > right-clicking on a group should select whole gro
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1097,6 +1098,7 @@ exports[`contextMenu element > selecting 'Add to library' in context menu adds e
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1311,6 +1313,7 @@ exports[`contextMenu element > selecting 'Bring forward' in context menu brings
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1642,6 +1645,7 @@ exports[`contextMenu element > selecting 'Bring to front' in context menu brings
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1973,6 +1977,7 @@ exports[`contextMenu element > selecting 'Copy styles' in context menu copies st
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2187,6 +2192,7 @@ exports[`contextMenu element > selecting 'Delete' in context menu deletes elemen
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2428,6 +2434,7 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2726,6 +2733,7 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3098,6 +3106,7 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s
|
||||
"currentItemFillStyle": "cross-hatch",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 60,
|
||||
"currentItemRoughness": 2,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3591,6 +3600,7 @@ exports[`contextMenu element > selecting 'Send backward' in context menu sends e
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3914,6 +3924,7 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4237,6 +4248,7 @@ exports[`contextMenu element > selecting 'Ungroup selection' in context menu ung
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5522,6 +5534,7 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -6739,6 +6752,7 @@ exports[`contextMenu element > shows 'Ungroup selection' in context menu for gro
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7696,6 +7710,7 @@ exports[`contextMenu element > shows context menu for canvas > [end of test] app
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8696,6 +8711,7 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9687,6 +9703,7 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
|
||||
@@ -24,6 +24,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -658,6 +659,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1220,6 +1222,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1580,6 +1583,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1942,6 +1946,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2205,6 +2210,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2692,6 +2698,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2995,6 +3002,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3314,6 +3322,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3608,6 +3617,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3894,6 +3904,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4129,6 +4140,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4386,6 +4398,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4657,6 +4670,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4886,6 +4900,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5115,6 +5130,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5362,6 +5378,7 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5618,6 +5635,7 @@ exports[`history > multiplayer undo/redo > conflicts in frames and their childre
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5876,6 +5894,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -6205,6 +6224,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -6632,6 +6652,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7006,6 +7027,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7318,6 +7340,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7611,6 +7634,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7841,6 +7865,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8193,6 +8218,7 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8545,6 +8571,7 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8951,6 +8978,7 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9065,8 +9093,8 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
20,
|
||||
],
|
||||
[
|
||||
50,
|
||||
50,
|
||||
"21.04874",
|
||||
"21.04874",
|
||||
],
|
||||
[
|
||||
50,
|
||||
@@ -9081,7 +9109,7 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -9167,8 +9195,8 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
20,
|
||||
],
|
||||
[
|
||||
50,
|
||||
50,
|
||||
"21.04874",
|
||||
"21.04874",
|
||||
],
|
||||
[
|
||||
50,
|
||||
@@ -9183,7 +9211,7 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -9230,6 +9258,7 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9494,6 +9523,7 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9759,6 +9789,7 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9991,6 +10022,7 @@ exports[`history > multiplayer undo/redo > should override remotely added groups
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10288,6 +10320,7 @@ exports[`history > multiplayer undo/redo > should override remotely added points
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10606,6 +10639,7 @@ exports[`history > multiplayer undo/redo > should redistribute deltas when eleme
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10842,6 +10876,7 @@ exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end o
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -11260,489 +11295,6 @@ exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end o
|
||||
|
||||
exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end of test] undo stack 1`] = `[]`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] appState 1`] = `
|
||||
{
|
||||
"activeEmbeddable": null,
|
||||
"activeLockedId": null,
|
||||
"activeTool": {
|
||||
"customType": null,
|
||||
"fromSelection": false,
|
||||
"lastActiveTool": null,
|
||||
"locked": false,
|
||||
"type": "selection",
|
||||
},
|
||||
"bindMode": "orbit",
|
||||
"bindingPreference": "enabled",
|
||||
"collaborators": Map {},
|
||||
"contextMenu": null,
|
||||
"croppingElementId": null,
|
||||
"currentHoveredFontFamily": null,
|
||||
"currentItemArrowType": "round",
|
||||
"currentItemBackgroundColor": "transparent",
|
||||
"currentItemEndArrowhead": "arrow",
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
"currentItemStartArrowhead": null,
|
||||
"currentItemStrokeColor": "#1e1e1e",
|
||||
"currentItemStrokeStyle": "solid",
|
||||
"currentItemStrokeWidth": 2,
|
||||
"currentItemTextAlign": "left",
|
||||
"cursorButton": "up",
|
||||
"defaultSidebarDockedPreference": false,
|
||||
"editingFrame": null,
|
||||
"editingGroupId": null,
|
||||
"editingTextElement": null,
|
||||
"elementsToHighlight": null,
|
||||
"errorMessage": null,
|
||||
"exportBackground": true,
|
||||
"exportEmbedScene": false,
|
||||
"exportScale": 1,
|
||||
"exportWithDarkMode": false,
|
||||
"fileHandle": null,
|
||||
"followedBy": Set {},
|
||||
"frameRendering": {
|
||||
"clip": true,
|
||||
"enabled": true,
|
||||
"name": true,
|
||||
"outline": true,
|
||||
},
|
||||
"frameToHighlight": null,
|
||||
"gridModeEnabled": false,
|
||||
"gridSize": 20,
|
||||
"gridStep": 5,
|
||||
"height": 0,
|
||||
"hoveredElementIds": {},
|
||||
"isBindingEnabled": true,
|
||||
"isCropping": false,
|
||||
"isLoading": false,
|
||||
"isMidpointSnappingEnabled": true,
|
||||
"isResizing": false,
|
||||
"isRotating": false,
|
||||
"lastPointerDownWith": "mouse",
|
||||
"lockedMultiSelections": {},
|
||||
"multiElement": null,
|
||||
"newElement": null,
|
||||
"objectsSnapModeEnabled": false,
|
||||
"offsetLeft": 0,
|
||||
"offsetTop": 0,
|
||||
"openDialog": null,
|
||||
"openMenu": null,
|
||||
"openPopup": null,
|
||||
"openSidebar": null,
|
||||
"originSnapOffset": null,
|
||||
"penDetected": false,
|
||||
"penMode": false,
|
||||
"preferredSelectionTool": {
|
||||
"initialized": true,
|
||||
"type": "selection",
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
"selectedElementIds": {},
|
||||
"selectedElementsAreBeingDragged": false,
|
||||
"selectedGroupIds": {},
|
||||
"selectionElement": null,
|
||||
"shouldCacheIgnoreZoom": false,
|
||||
"showHyperlinkPopup": false,
|
||||
"showWelcomeScreen": true,
|
||||
"snapLines": [],
|
||||
"startBoundElement": null,
|
||||
"stats": {
|
||||
"open": false,
|
||||
"panels": 3,
|
||||
},
|
||||
"suggestedBinding": null,
|
||||
"theme": "light",
|
||||
"toast": null,
|
||||
"userToFollow": null,
|
||||
"viewBackgroundColor": "#ffffff",
|
||||
"viewModeEnabled": false,
|
||||
"width": 0,
|
||||
"zenModeEnabled": false,
|
||||
"zoom": {
|
||||
"value": 1,
|
||||
},
|
||||
}
|
||||
`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] element 0 1`] = `
|
||||
{
|
||||
"angle": 0,
|
||||
"backgroundColor": "transparent",
|
||||
"boundElements": null,
|
||||
"customData": undefined,
|
||||
"fillStyle": "solid",
|
||||
"frameId": null,
|
||||
"groupIds": [
|
||||
"inner",
|
||||
"outer",
|
||||
],
|
||||
"height": 100,
|
||||
"id": "id0",
|
||||
"index": "a0",
|
||||
"isDeleted": false,
|
||||
"link": null,
|
||||
"locked": false,
|
||||
"opacity": 100,
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
"type": "rectangle",
|
||||
"updated": 1,
|
||||
"version": 2,
|
||||
"width": 100,
|
||||
"x": 0,
|
||||
"y": 0,
|
||||
}
|
||||
`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] element 1 1`] = `
|
||||
{
|
||||
"angle": 0,
|
||||
"backgroundColor": "transparent",
|
||||
"boundElements": null,
|
||||
"customData": undefined,
|
||||
"fillStyle": "solid",
|
||||
"frameId": null,
|
||||
"groupIds": [
|
||||
"outer",
|
||||
],
|
||||
"height": 100,
|
||||
"id": "id1",
|
||||
"index": "a1",
|
||||
"isDeleted": false,
|
||||
"link": null,
|
||||
"locked": false,
|
||||
"opacity": 100,
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
"type": "rectangle",
|
||||
"updated": 1,
|
||||
"version": 2,
|
||||
"width": 100,
|
||||
"x": 100,
|
||||
"y": 100,
|
||||
}
|
||||
`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] element 2 1`] = `
|
||||
{
|
||||
"angle": 0,
|
||||
"backgroundColor": "transparent",
|
||||
"boundElements": null,
|
||||
"customData": undefined,
|
||||
"fillStyle": "solid",
|
||||
"frameId": null,
|
||||
"groupIds": [
|
||||
"inner",
|
||||
"outer",
|
||||
],
|
||||
"height": 100,
|
||||
"id": "id2",
|
||||
"index": "a2",
|
||||
"isDeleted": false,
|
||||
"link": null,
|
||||
"locked": false,
|
||||
"opacity": 100,
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
"type": "rectangle",
|
||||
"updated": 1,
|
||||
"version": 2,
|
||||
"width": 100,
|
||||
"x": 200,
|
||||
"y": 200,
|
||||
}
|
||||
`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] number of elements 1`] = `3`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] number of renders 1`] = `16`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] redo stack 1`] = `[]`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should support undo and redo when escape unwinds nested group editing > [end of test] undo stack 1`] = `
|
||||
[
|
||||
{
|
||||
"appState": AppStateDelta {
|
||||
"delta": Delta {
|
||||
"deleted": {
|
||||
"selectedElementIds": {
|
||||
"id0": true,
|
||||
"id1": true,
|
||||
"id2": true,
|
||||
},
|
||||
"selectedGroupIds": {
|
||||
"outer": true,
|
||||
},
|
||||
},
|
||||
"inserted": {
|
||||
"selectedElementIds": {},
|
||||
"selectedGroupIds": {},
|
||||
},
|
||||
},
|
||||
},
|
||||
"elements": {
|
||||
"added": {},
|
||||
"removed": {
|
||||
"id0": {
|
||||
"deleted": {
|
||||
"angle": 0,
|
||||
"backgroundColor": "transparent",
|
||||
"boundElements": null,
|
||||
"customData": undefined,
|
||||
"fillStyle": "solid",
|
||||
"frameId": null,
|
||||
"groupIds": [
|
||||
"inner",
|
||||
"outer",
|
||||
],
|
||||
"height": 100,
|
||||
"index": "a0",
|
||||
"isDeleted": false,
|
||||
"link": null,
|
||||
"locked": false,
|
||||
"opacity": 100,
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
"type": "rectangle",
|
||||
"version": 2,
|
||||
"width": 100,
|
||||
"x": 0,
|
||||
"y": 0,
|
||||
},
|
||||
"inserted": {
|
||||
"isDeleted": true,
|
||||
"version": 1,
|
||||
},
|
||||
},
|
||||
"id1": {
|
||||
"deleted": {
|
||||
"angle": 0,
|
||||
"backgroundColor": "transparent",
|
||||
"boundElements": null,
|
||||
"customData": undefined,
|
||||
"fillStyle": "solid",
|
||||
"frameId": null,
|
||||
"groupIds": [
|
||||
"outer",
|
||||
],
|
||||
"height": 100,
|
||||
"index": "a1",
|
||||
"isDeleted": false,
|
||||
"link": null,
|
||||
"locked": false,
|
||||
"opacity": 100,
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
"type": "rectangle",
|
||||
"version": 2,
|
||||
"width": 100,
|
||||
"x": 100,
|
||||
"y": 100,
|
||||
},
|
||||
"inserted": {
|
||||
"isDeleted": true,
|
||||
"version": 1,
|
||||
},
|
||||
},
|
||||
"id2": {
|
||||
"deleted": {
|
||||
"angle": 0,
|
||||
"backgroundColor": "transparent",
|
||||
"boundElements": null,
|
||||
"customData": undefined,
|
||||
"fillStyle": "solid",
|
||||
"frameId": null,
|
||||
"groupIds": [
|
||||
"inner",
|
||||
"outer",
|
||||
],
|
||||
"height": 100,
|
||||
"index": "a2",
|
||||
"isDeleted": false,
|
||||
"link": null,
|
||||
"locked": false,
|
||||
"opacity": 100,
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
"type": "rectangle",
|
||||
"version": 2,
|
||||
"width": 100,
|
||||
"x": 200,
|
||||
"y": 200,
|
||||
},
|
||||
"inserted": {
|
||||
"isDeleted": true,
|
||||
"version": 1,
|
||||
},
|
||||
},
|
||||
},
|
||||
"updated": {},
|
||||
},
|
||||
"id": "id5",
|
||||
},
|
||||
{
|
||||
"appState": AppStateDelta {
|
||||
"delta": Delta {
|
||||
"deleted": {
|
||||
"editingGroupId": "outer",
|
||||
"selectedElementIds": {},
|
||||
"selectedGroupIds": {
|
||||
"inner": true,
|
||||
},
|
||||
},
|
||||
"inserted": {
|
||||
"editingGroupId": null,
|
||||
"selectedElementIds": {
|
||||
"id1": true,
|
||||
},
|
||||
"selectedGroupIds": {
|
||||
"outer": true,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
"elements": {
|
||||
"added": {},
|
||||
"removed": {},
|
||||
"updated": {},
|
||||
},
|
||||
"id": "id7",
|
||||
},
|
||||
{
|
||||
"appState": AppStateDelta {
|
||||
"delta": Delta {
|
||||
"deleted": {
|
||||
"editingGroupId": "inner",
|
||||
"selectedElementIds": {},
|
||||
"selectedGroupIds": {},
|
||||
},
|
||||
"inserted": {
|
||||
"editingGroupId": "outer",
|
||||
"selectedElementIds": {
|
||||
"id2": true,
|
||||
},
|
||||
"selectedGroupIds": {
|
||||
"inner": true,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
"elements": {
|
||||
"added": {},
|
||||
"removed": {},
|
||||
"updated": {},
|
||||
},
|
||||
"id": "id9",
|
||||
},
|
||||
{
|
||||
"appState": AppStateDelta {
|
||||
"delta": Delta {
|
||||
"deleted": {
|
||||
"editingGroupId": "outer",
|
||||
"selectedElementIds": {
|
||||
"id2": true,
|
||||
},
|
||||
"selectedGroupIds": {
|
||||
"inner": true,
|
||||
},
|
||||
},
|
||||
"inserted": {
|
||||
"editingGroupId": "inner",
|
||||
"selectedElementIds": {},
|
||||
"selectedGroupIds": {},
|
||||
},
|
||||
},
|
||||
},
|
||||
"elements": {
|
||||
"added": {},
|
||||
"removed": {},
|
||||
"updated": {},
|
||||
},
|
||||
"id": "id19",
|
||||
},
|
||||
{
|
||||
"appState": AppStateDelta {
|
||||
"delta": Delta {
|
||||
"deleted": {
|
||||
"editingGroupId": null,
|
||||
"selectedElementIds": {
|
||||
"id1": true,
|
||||
},
|
||||
"selectedGroupIds": {
|
||||
"outer": true,
|
||||
},
|
||||
},
|
||||
"inserted": {
|
||||
"editingGroupId": "outer",
|
||||
"selectedElementIds": {},
|
||||
"selectedGroupIds": {
|
||||
"inner": true,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
"elements": {
|
||||
"added": {},
|
||||
"removed": {},
|
||||
"updated": {},
|
||||
},
|
||||
"id": "id20",
|
||||
},
|
||||
{
|
||||
"appState": AppStateDelta {
|
||||
"delta": Delta {
|
||||
"deleted": {
|
||||
"selectedElementIds": {},
|
||||
"selectedGroupIds": {},
|
||||
},
|
||||
"inserted": {
|
||||
"selectedElementIds": {
|
||||
"id0": true,
|
||||
"id1": true,
|
||||
"id2": true,
|
||||
},
|
||||
"selectedGroupIds": {
|
||||
"outer": true,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
"elements": {
|
||||
"added": {},
|
||||
"removed": {},
|
||||
"updated": {},
|
||||
},
|
||||
"id": "id21",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`history > multiplayer undo/redo > should update history entries after remote changes on the same properties > [end of test] appState 1`] = `
|
||||
{
|
||||
"activeEmbeddable": null,
|
||||
@@ -11767,6 +11319,7 @@ exports[`history > multiplayer undo/redo > should update history entries after r
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -12027,6 +11580,7 @@ exports[`history > singleplayer undo/redo > remounting undo/redo buttons should
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -12262,6 +11816,7 @@ exports[`history > singleplayer undo/redo > should clear the redo stack on eleme
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -12499,6 +12054,7 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -12654,7 +12210,7 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -12704,7 +12260,7 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#e03131",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -12843,7 +12399,7 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#e03131",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -12890,6 +12446,7 @@ exports[`history > singleplayer undo/redo > should create new history entry on e
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -13100,6 +12657,7 @@ exports[`history > singleplayer undo/redo > should create new history entry on e
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -13307,6 +12865,7 @@ exports[`history > singleplayer undo/redo > should create new history entry on i
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -13608,6 +13167,7 @@ exports[`history > singleplayer undo/redo > should create new history entry on i
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -13906,6 +13466,7 @@ exports[`history > singleplayer undo/redo > should create new history entry on s
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14151,6 +13712,7 @@ exports[`history > singleplayer undo/redo > should disable undo/redo buttons whe
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14388,6 +13950,7 @@ exports[`history > singleplayer undo/redo > should end up with no history entry
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14625,6 +14188,7 @@ exports[`history > singleplayer undo/redo > should iterate through the history w
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14872,6 +14436,7 @@ exports[`history > singleplayer undo/redo > should not clear the redo stack on s
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -15203,6 +14768,7 @@ exports[`history > singleplayer undo/redo > should not collapse when applying co
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -15373,6 +14939,7 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -15657,6 +15224,7 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -15920,6 +15488,7 @@ exports[`history > singleplayer undo/redo > should not modify anything on unrela
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -16073,6 +15642,7 @@ exports[`history > singleplayer undo/redo > should not override appstate changes
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -16355,6 +15925,7 @@ exports[`history > singleplayer undo/redo > should support appstate name or view
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -16517,6 +16088,7 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -17266,6 +16838,7 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -17913,6 +17486,7 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -18560,6 +18134,7 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -19310,6 +18885,7 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -20079,6 +19655,7 @@ exports[`history > singleplayer undo/redo > should support changes in elements'
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -20559,6 +20136,7 @@ exports[`history > singleplayer undo/redo > should support duplication of groups
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -21070,6 +20648,7 @@ exports[`history > singleplayer undo/redo > should support element creation, del
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -21529,6 +21108,7 @@ exports[`history > singleplayer undo/redo > should support linear element creati
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
|
||||
@@ -24,6 +24,7 @@ exports[`given element A and group of elements B and given both are selected whe
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -450,6 +451,7 @@ exports[`given element A and group of elements B and given both are selected whe
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -866,6 +868,7 @@ exports[`regression tests > Cmd/Ctrl-click exclusively select element under poin
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1432,6 +1435,7 @@ exports[`regression tests > Drags selected element when hitting only bounding bo
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -1639,6 +1643,7 @@ exports[`regression tests > adjusts z order when grouping > [end of test] appSta
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2023,6 +2028,7 @@ exports[`regression tests > alt-drag duplicates an element > [end of test] appSt
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2268,6 +2274,7 @@ exports[`regression tests > arrow keys > [end of test] appState 1`] = `
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2448,6 +2455,7 @@ exports[`regression tests > can drag element that covers another element, while
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -2773,6 +2781,7 @@ exports[`regression tests > change the properties of a shape > [end of test] app
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3028,6 +3037,7 @@ exports[`regression tests > click on an element and drag it > [dragged] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3269,6 +3279,7 @@ exports[`regression tests > click on an element and drag it > [end of test] appS
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3505,6 +3516,7 @@ exports[`regression tests > click to select a shape > [end of test] appState 1`]
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -3763,6 +3775,7 @@ exports[`regression tests > click-drag to select a group > [end of test] appStat
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4077,6 +4090,7 @@ exports[`regression tests > deleting last but one element in editing group shoul
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4513,6 +4527,7 @@ exports[`regression tests > deselects group of selected elements on pointer down
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -4796,6 +4811,7 @@ exports[`regression tests > deselects group of selected elements on pointer up w
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5072,6 +5088,7 @@ exports[`regression tests > deselects selected element on pointer down when poin
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5280,6 +5297,7 @@ exports[`regression tests > deselects selected element, on pointer up, when clic
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5480,6 +5498,7 @@ exports[`regression tests > double click to edit a group > [end of test] appStat
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -5873,6 +5892,7 @@ exports[`regression tests > drags selected elements from point inside common bou
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -6170,6 +6190,7 @@ exports[`regression tests > draw every type of shape > [end of test] appState 1`
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -6912,7 +6933,7 @@ exports[`regression tests > draw every type of shape > [end of test] undo stack
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -6959,6 +6980,7 @@ exports[`regression tests > given a group of selected elements with an element t
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7293,6 +7315,7 @@ exports[`regression tests > given a selected element A and a not selected elemen
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7572,6 +7595,7 @@ exports[`regression tests > given selected element A with lower z-index than uns
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -7807,6 +7831,7 @@ exports[`regression tests > given selected element A with lower z-index than uns
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8047,6 +8072,7 @@ exports[`regression tests > key 2 selects rectangle tool > [end of test] appStat
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8227,6 +8253,7 @@ exports[`regression tests > key 3 selects diamond tool > [end of test] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8407,6 +8434,7 @@ exports[`regression tests > key 4 selects ellipse tool > [end of test] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8587,6 +8615,7 @@ exports[`regression tests > key 5 selects arrow tool > [end of test] appState 1`
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -8820,6 +8849,7 @@ exports[`regression tests > key 6 selects line tool > [end of test] appState 1`]
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9051,6 +9081,7 @@ exports[`regression tests > key 7 selects freedraw tool > [end of test] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9196,7 +9227,7 @@ exports[`regression tests > key 7 selects freedraw tool > [end of test] undo sta
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -9243,6 +9274,7 @@ exports[`regression tests > key a selects arrow tool > [end of test] appState 1`
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9476,6 +9508,7 @@ exports[`regression tests > key d selects diamond tool > [end of test] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9656,6 +9689,7 @@ exports[`regression tests > key l selects line tool > [end of test] appState 1`]
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -9887,6 +9921,7 @@ exports[`regression tests > key o selects ellipse tool > [end of test] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10067,6 +10102,7 @@ exports[`regression tests > key p selects freedraw tool > [end of test] appState
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10212,7 +10248,7 @@ exports[`regression tests > key p selects freedraw tool > [end of test] undo sta
|
||||
],
|
||||
"roughness": 1,
|
||||
"roundness": null,
|
||||
"simulatePressure": false,
|
||||
"simulatePressure": true,
|
||||
"strokeColor": "#1e1e1e",
|
||||
"strokeStyle": "solid",
|
||||
"strokeWidth": 2,
|
||||
@@ -10259,6 +10295,7 @@ exports[`regression tests > key r selects rectangle tool > [end of test] appStat
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10439,6 +10476,7 @@ exports[`regression tests > make a group and duplicate it > [end of test] appSta
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -10970,6 +11008,7 @@ exports[`regression tests > noop interaction after undo shouldn't create history
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -11250,6 +11289,7 @@ exports[`regression tests > pinch-to-zoom works > [end of test] appState 1`] = `
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -11373,6 +11413,7 @@ exports[`regression tests > shift click on selected element should deselect it o
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -11573,6 +11614,7 @@ exports[`regression tests > shift-click to multiselect, then drag > [end of test
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -11892,6 +11934,7 @@ exports[`regression tests > should group elements and ungroup them > [end of tes
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -12321,6 +12364,7 @@ exports[`regression tests > single-clicking on a subgroup of a selected group sh
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -12961,6 +13005,7 @@ exports[`regression tests > spacebar + drag scrolls the canvas > [end of test] a
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -13087,6 +13132,7 @@ exports[`regression tests > supports nested groups > [end of test] appState 1`]
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -13718,6 +13764,7 @@ exports[`regression tests > switches from group of selected elements to another
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14057,6 +14104,7 @@ exports[`regression tests > switches selected element on pointer down > [end of
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14321,6 +14369,7 @@ exports[`regression tests > two-finger scroll works > [end of test] appState 1`]
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14444,6 +14493,7 @@ exports[`regression tests > undo/redo drawing an element > [end of test] appStat
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14809,6 +14859,7 @@ exports[`regression tests > updates fontSize & fontFamily appState > [end of tes
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 8,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
@@ -14932,6 +14983,7 @@ exports[`regression tests > zoom hotkeys > [end of test] appState 1`] = `
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
|
||||
@@ -0,0 +1,73 @@
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
|
||||
import { AnimationController } from "../renderer/animation";
|
||||
|
||||
const FIRST_KEY = "animation-test-first";
|
||||
const SECOND_KEY = "animation-test-second";
|
||||
|
||||
describe("AnimationController", () => {
|
||||
beforeEach(() => {
|
||||
vi.useFakeTimers();
|
||||
window.EXCALIDRAW_THROTTLE_RENDER = false;
|
||||
});
|
||||
|
||||
afterEach(() => {
|
||||
AnimationController.cancel(FIRST_KEY);
|
||||
AnimationController.cancel(SECOND_KEY);
|
||||
window.EXCALIDRAW_THROTTLE_RENDER = undefined;
|
||||
vi.useRealTimers();
|
||||
});
|
||||
|
||||
it("starts a new animation after the previous last animation was cancelled", async () => {
|
||||
let firstFrames = 0;
|
||||
AnimationController.start(FIRST_KEY, () => {
|
||||
firstFrames++;
|
||||
return { keep: true };
|
||||
});
|
||||
|
||||
expect(firstFrames).toBe(1);
|
||||
|
||||
AnimationController.cancel(FIRST_KEY);
|
||||
await vi.runOnlyPendingTimersAsync();
|
||||
|
||||
let secondFrames = 0;
|
||||
AnimationController.start(SECOND_KEY, () => {
|
||||
secondFrames++;
|
||||
return secondFrames === 1 ? { keep: true } : null;
|
||||
});
|
||||
|
||||
expect(secondFrames).toBe(1);
|
||||
|
||||
await vi.runOnlyPendingTimersAsync();
|
||||
|
||||
expect(secondFrames).toBe(2);
|
||||
expect(AnimationController.running(SECOND_KEY)).toBe(false);
|
||||
});
|
||||
|
||||
it("cancels a frame scheduled during a tick if no animations remain", async () => {
|
||||
let firstFrames = 0;
|
||||
let secondFrames = 0;
|
||||
|
||||
AnimationController.start(FIRST_KEY, ({ state }) => {
|
||||
if (!state) {
|
||||
return { keep: true };
|
||||
}
|
||||
|
||||
firstFrames++;
|
||||
|
||||
AnimationController.start(SECOND_KEY, () => {
|
||||
secondFrames++;
|
||||
return { keep: true };
|
||||
});
|
||||
AnimationController.cancel(SECOND_KEY);
|
||||
|
||||
return null;
|
||||
});
|
||||
|
||||
await vi.runOnlyPendingTimersAsync();
|
||||
|
||||
expect(firstFrames).toBe(1);
|
||||
expect(secondFrames).toBe(1);
|
||||
expect(vi.getTimerCount()).toBe(0);
|
||||
});
|
||||
});
|
||||
@@ -305,8 +305,88 @@ describe("pasting & frames", () => {
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.elements.length).toBe(2);
|
||||
expect(h.elements[0].type).toBe(rect.type);
|
||||
expect(h.elements[0].frameId).toBe(frame.id);
|
||||
expect(h.elements[1].id).toBe(frame.id);
|
||||
expect(h.elements[0].index! < frame.index!).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it("should layer pasted elements above the highest frame child", async () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
width: 100,
|
||||
height: 100,
|
||||
x: 0,
|
||||
y: 0,
|
||||
});
|
||||
const frameChild = API.createElement({
|
||||
id: "frameChild",
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const rect = API.createElement({ type: "rectangle" });
|
||||
|
||||
API.setElements([frameChild, frame]);
|
||||
|
||||
const clipboardJSON = await serializeAsClipboardJSON({
|
||||
elements: [rect],
|
||||
files: null,
|
||||
});
|
||||
|
||||
mouse.moveTo(50, 50);
|
||||
|
||||
pasteWithCtrlCmdV(clipboardJSON);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.elements.length).toBe(3);
|
||||
expect(h.elements[1].type).toBe(rect.type);
|
||||
expect(h.elements[1].frameId).toBe(frame.id);
|
||||
expect(h.elements.map((element) => element.id)).toEqual([
|
||||
frameChild.id,
|
||||
h.elements[1].id,
|
||||
frame.id,
|
||||
]);
|
||||
expect(h.elements[1].index! > frameChild.index!).toBe(true);
|
||||
expect(h.elements[1].index! < frame.index!).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
it("should preserve denormalized pasted frame child order", async () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
width: 100,
|
||||
height: 100,
|
||||
x: 0,
|
||||
y: 0,
|
||||
});
|
||||
const frameChild = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 10,
|
||||
width: 20,
|
||||
height: 20,
|
||||
frameId: frame.id,
|
||||
});
|
||||
|
||||
const clipboardJSON = await serializeAsClipboardJSON({
|
||||
elements: [frame, frameChild],
|
||||
files: null,
|
||||
});
|
||||
|
||||
mouse.moveTo(200, 200);
|
||||
|
||||
pasteWithCtrlCmdV(clipboardJSON);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.elements.length).toBe(2);
|
||||
expect(h.elements[0].type).toBe(frame.type);
|
||||
expect(h.elements[1].type).toBe(frameChild.type);
|
||||
expect(h.elements[1].frameId).toBe(h.elements[0].id);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -379,8 +459,9 @@ describe("pasting & frames", () => {
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.elements.length).toBe(3);
|
||||
expect(h.elements[1].type).toBe(rect.type);
|
||||
expect(h.elements[1].frameId).toBe(frame.id);
|
||||
expect(h.elements[0].type).toBe(rect.type);
|
||||
expect(h.elements[0].frameId).toBe(frame.id);
|
||||
expect(h.elements[1].id).toBe(frame.id);
|
||||
expect(h.elements[2].type).toBe(rect2.type);
|
||||
expect(h.elements[2].frameId).toBe(null);
|
||||
});
|
||||
@@ -422,10 +503,11 @@ describe("pasting & frames", () => {
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.elements.length).toBe(3);
|
||||
expect(h.elements[1].type).toBe(rect.type);
|
||||
expect(h.elements[0].type).toBe(rect.type);
|
||||
expect(h.elements[0].frameId).toBe(frame.id);
|
||||
expect(h.elements[1].type).toBe(rect2.type);
|
||||
expect(h.elements[1].frameId).toBe(frame.id);
|
||||
expect(h.elements[2].type).toBe(rect2.type);
|
||||
expect(h.elements[2].frameId).toBe(frame.id);
|
||||
expect(h.elements[2].id).toBe(frame.id);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -473,8 +555,9 @@ describe("pasting & frames", () => {
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.elements.length).toBe(4);
|
||||
expect(h.elements[1].type).toBe(rect.type);
|
||||
expect(h.elements[1].frameId).toBe(frame.id);
|
||||
expect(h.elements[0].type).toBe(rect.type);
|
||||
expect(h.elements[0].frameId).toBe(frame.id);
|
||||
expect(h.elements[1].id).toBe(frame.id);
|
||||
expect(h.elements[2].type).toBe(rect2.type);
|
||||
expect(h.elements[2].frameId).toBe(h.elements[3].id);
|
||||
expect(h.elements[3].type).toBe(frame2.type);
|
||||
|
||||
@@ -160,6 +160,39 @@ describe("restoreElements", () => {
|
||||
});
|
||||
});
|
||||
|
||||
it("should restore only valid freedraw points and keep pressures aligned", () => {
|
||||
const freedrawElement = API.createElement({
|
||||
type: "freedraw",
|
||||
id: "id-freedraw-invalid-points",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10)],
|
||||
});
|
||||
|
||||
const restoredFreedraw = restore.restoreElements(
|
||||
[
|
||||
{
|
||||
...freedrawElement,
|
||||
simulatePressure: false,
|
||||
points: [
|
||||
pointFrom(0, 0),
|
||||
[Infinity, 10],
|
||||
null,
|
||||
pointFrom(20, 20),
|
||||
[NaN, 30],
|
||||
[40, null],
|
||||
],
|
||||
pressures: [0.1, 0.2, 0.3, 0.4, 0.5, 0.6],
|
||||
} as any,
|
||||
],
|
||||
null,
|
||||
)[0] as ExcalidrawFreeDrawElement;
|
||||
|
||||
expect(restoredFreedraw.points).toEqual([
|
||||
pointFrom(0, 0),
|
||||
pointFrom(20, 20),
|
||||
]);
|
||||
expect(restoredFreedraw.pressures).toEqual([0.1, 0.4]);
|
||||
});
|
||||
|
||||
it("should restore line and draw elements correctly", () => {
|
||||
const lineElement = API.createElement({ type: "line", id: "id-line01" });
|
||||
|
||||
@@ -400,6 +433,52 @@ describe("restoreElements", () => {
|
||||
expect(restoredLine.points).toMatchObject(expectedLinePoints);
|
||||
});
|
||||
|
||||
it("should restore only valid linear points", () => {
|
||||
const lineElement: any = API.createElement({
|
||||
type: "line",
|
||||
x: 10,
|
||||
y: 20,
|
||||
width: 100,
|
||||
height: 200,
|
||||
});
|
||||
const arrowElement: any = API.createElement({
|
||||
type: "arrow",
|
||||
width: 100,
|
||||
height: 200,
|
||||
});
|
||||
|
||||
lineElement.points = [
|
||||
[2, 3],
|
||||
null,
|
||||
[Infinity, 4],
|
||||
[5, 7],
|
||||
[NaN, 8],
|
||||
[9, null],
|
||||
];
|
||||
arrowElement.points = [
|
||||
[null, 0],
|
||||
[Infinity, 4],
|
||||
];
|
||||
|
||||
const restoredElements = restore.restoreElements(
|
||||
[lineElement, arrowElement],
|
||||
null,
|
||||
);
|
||||
const restoredLine = restoredElements[0] as ExcalidrawLinearElement;
|
||||
const restoredArrow = restoredElements[1] as ExcalidrawArrowElement;
|
||||
|
||||
expect(restoredLine.points).toEqual([pointFrom(0, 0), pointFrom(3, 4)]);
|
||||
expect(restoredLine.x).toBe(12);
|
||||
expect(restoredLine.y).toBe(23);
|
||||
expect(restoredLine.width).toBe(3);
|
||||
expect(restoredLine.height).toBe(4);
|
||||
|
||||
expect(restoredArrow.points).toEqual([
|
||||
pointFrom(0, 0),
|
||||
pointFrom(100, 200),
|
||||
]);
|
||||
});
|
||||
|
||||
it("when the number of points of a line is greater or equal 2", () => {
|
||||
const lineElement_0 = API.createElement({
|
||||
type: "line",
|
||||
|
||||
@@ -94,3 +94,42 @@ export const testPolyfills = {
|
||||
// https://github.com/vitest-dev/vitest/pull/4164#issuecomment-2172729965
|
||||
URL,
|
||||
};
|
||||
|
||||
export const PolyfillLocalStorage = () => {
|
||||
// Node.js 25+ provides a native localStorage global that shadows jsdom's,
|
||||
// and jsdom's own localStorage also uses the native one -- both are broken
|
||||
// (empty objects without Storage methods). On older Node versions, jsdom
|
||||
// provides a working localStorage. This polyfill replaces localStorage on
|
||||
// all supported versions with a standard Storage implementation backed by
|
||||
// a Map, ensuring consistent behavior regardless of the Node.js version.
|
||||
const storage = new Map<string, string>();
|
||||
const storagePolyfill: Storage = {
|
||||
get length() {
|
||||
return storage.size;
|
||||
},
|
||||
clear() {
|
||||
storage.clear();
|
||||
},
|
||||
key(index) {
|
||||
return Array.from(storage.keys())[index] ?? null;
|
||||
},
|
||||
getItem(key) {
|
||||
return storage.get(key) ?? null;
|
||||
},
|
||||
setItem(key, value) {
|
||||
storage.set(key, value);
|
||||
},
|
||||
removeItem(key) {
|
||||
storage.delete(key);
|
||||
},
|
||||
*[Symbol.iterator]() {
|
||||
yield* storage.entries();
|
||||
},
|
||||
};
|
||||
|
||||
Object.defineProperty(window, "localStorage", {
|
||||
value: storagePolyfill,
|
||||
writable: true,
|
||||
configurable: true,
|
||||
});
|
||||
};
|
||||
|
||||
@@ -2120,6 +2120,9 @@ describe("history", () => {
|
||||
await render(
|
||||
<Excalidraw handleKeyboardGlobally={true} isCollaborating={true} />,
|
||||
);
|
||||
// Pin the One Euro Filter clock to a fixed value so the smoothed
|
||||
// intermediate freedraw point is deterministic regardless of system load.
|
||||
vi.spyOn(h.app as any, "getPointerEventTimestamp").mockReturnValue(0);
|
||||
});
|
||||
|
||||
it("should not override remote changes on different elements", async () => {
|
||||
|
||||
@@ -1,4 +1,4 @@
|
||||
import { randomId, reseed } from "@excalidraw/common";
|
||||
import { MIME_TYPES, randomId, reseed } from "@excalidraw/common";
|
||||
|
||||
import type { FileId } from "@excalidraw/element/types";
|
||||
|
||||
@@ -17,18 +17,41 @@ import {
|
||||
} from "./fixtures/constants";
|
||||
import { INITIALIZED_IMAGE_PROPS } from "./helpers/constants";
|
||||
|
||||
import type { ExcalidrawProps } from "../types";
|
||||
|
||||
const { h } = window;
|
||||
|
||||
export const setupImageTest = async (
|
||||
sizes: { width: number; height: number }[],
|
||||
props?: ExcalidrawProps,
|
||||
) => {
|
||||
await render(<Excalidraw autoFocus={true} handleKeyboardGlobally={true} />);
|
||||
await render(
|
||||
<Excalidraw autoFocus={true} handleKeyboardGlobally={true} {...props} />,
|
||||
);
|
||||
|
||||
h.state.height = 1000;
|
||||
|
||||
mockMultipleHTMLImageElements(sizes.map((size) => [size.width, size.height]));
|
||||
};
|
||||
|
||||
describe("resizeImageFile", () => {
|
||||
beforeEach(() => {
|
||||
vi.unstubAllGlobals();
|
||||
});
|
||||
|
||||
it("returns the original file when it already fits the max dimensions", async () => {
|
||||
mockMultipleHTMLImageElements([[100, 100]]);
|
||||
|
||||
const imageFile = new File([new Uint8Array([1, 2, 3])], "image.png", {
|
||||
type: MIME_TYPES.png,
|
||||
});
|
||||
|
||||
await expect(
|
||||
blobModule.resizeImageFile(imageFile, { maxWidthOrHeight: 200 }),
|
||||
).resolves.toBe(imageFile);
|
||||
});
|
||||
});
|
||||
|
||||
describe("image insertion", () => {
|
||||
beforeEach(() => {
|
||||
vi.clearAllMocks();
|
||||
@@ -112,4 +135,42 @@ describe("image insertion", () => {
|
||||
|
||||
await assert();
|
||||
});
|
||||
|
||||
it("passes host-configured max image dimensions to the resize helper", async () => {
|
||||
await setupImageTest([DEER_IMAGE_DIMENSIONS], {
|
||||
imageOptions: { maxWidthOrHeight: 2048 },
|
||||
});
|
||||
|
||||
await API.drop([
|
||||
{ kind: "file", file: await API.loadFile("./fixtures/deer.png") },
|
||||
]);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(blobModule.resizeImageFile).toHaveBeenCalledWith(
|
||||
expect.any(File),
|
||||
{ maxWidthOrHeight: 2048 },
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it("enforces host-configured max image file size", async () => {
|
||||
await setupImageTest([DEER_IMAGE_DIMENSIONS], {
|
||||
imageOptions: { maxFileSizeBytes: 1024 * 1024 },
|
||||
});
|
||||
|
||||
await API.drop([
|
||||
{
|
||||
kind: "file",
|
||||
file: new File([new Uint8Array(2 * 1024 * 1024)], "image.png", {
|
||||
type: MIME_TYPES.png,
|
||||
}),
|
||||
},
|
||||
]);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(h.state.errorMessage).toBe(
|
||||
"File is too big. Maximum allowed size is 1MB.",
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
@@ -10,7 +10,7 @@ import { API } from "./helpers/api";
|
||||
import { Pointer } from "./helpers/ui";
|
||||
import { act, GlobalTestState, render, waitFor } from "./test-utils";
|
||||
|
||||
import type { ExcalidrawProps } from "../types";
|
||||
import type { Collaborator, ExcalidrawProps, SocketId } from "../types";
|
||||
|
||||
describe("laser tool interactions", () => {
|
||||
const h = window.h;
|
||||
@@ -128,4 +128,36 @@ describe("laser tool interactions", () => {
|
||||
expect(h.state.scrollY).toBe(initialScrollY);
|
||||
expect(GlobalTestState.interactiveCanvas.style.cursor).toContain("");
|
||||
});
|
||||
|
||||
it("cleans up remote laser trails when the last collaborator leaves", async () => {
|
||||
await render(<Excalidraw />);
|
||||
|
||||
const socketId = "socket-id" as SocketId;
|
||||
const collaborators = new Map<SocketId, Collaborator>([
|
||||
[
|
||||
socketId,
|
||||
{
|
||||
pointer: {
|
||||
x: 10,
|
||||
y: 10,
|
||||
tool: "laser",
|
||||
},
|
||||
button: "down",
|
||||
},
|
||||
],
|
||||
]);
|
||||
const svgLayer = document.querySelector(".SVGLayer svg")!;
|
||||
|
||||
act(() => {
|
||||
h.app.updateScene({ collaborators });
|
||||
});
|
||||
|
||||
expect(svgLayer.querySelectorAll("path")).toHaveLength(1);
|
||||
|
||||
act(() => {
|
||||
h.app.updateScene({ collaborators: new Map() });
|
||||
});
|
||||
|
||||
expect(svgLayer.querySelectorAll("path")).toHaveLength(0);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -1,8 +1,12 @@
|
||||
import React from "react";
|
||||
import { vi } from "vitest";
|
||||
|
||||
import { KEYS, ROUNDNESS, reseed } from "@excalidraw/common";
|
||||
import { getElementBounds, getElementLineSegments } from "@excalidraw/element";
|
||||
import { KEYS, ROUNDNESS, arrayToMap, reseed } from "@excalidraw/common";
|
||||
import {
|
||||
getElementBounds,
|
||||
getElementLineSegments,
|
||||
getElementsWithinSelection,
|
||||
} from "@excalidraw/element";
|
||||
import { pointFrom, pointRotateRads, type LocalPoint } from "@excalidraw/math";
|
||||
|
||||
import { SHAPES } from "../components/shapes";
|
||||
@@ -269,6 +273,145 @@ describe("box-selection overlap mode", () => {
|
||||
assertSelectedElements([rect1.id]);
|
||||
});
|
||||
|
||||
it("should select the whole group when overlapping one group member", () => {
|
||||
const rect1 = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["A"],
|
||||
});
|
||||
const rect2 = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 100,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["A"],
|
||||
});
|
||||
|
||||
API.setElements([rect1, rect2]);
|
||||
|
||||
boxSelect(25, -20, 75, 70);
|
||||
|
||||
assertSelectedElements([rect1.id, rect2.id]);
|
||||
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||
});
|
||||
|
||||
it("should return all group elements when overlapping one group member", () => {
|
||||
const rect1 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "rect1",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["A"],
|
||||
});
|
||||
const rect2 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "rect2",
|
||||
x: 100,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["A"],
|
||||
});
|
||||
const rect3 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "rect3",
|
||||
x: 200,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
});
|
||||
const selection = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 125,
|
||||
y: -10,
|
||||
width: 10,
|
||||
height: 70,
|
||||
});
|
||||
const elements = [rect1, rect2, rect3];
|
||||
|
||||
expect(
|
||||
getElementsWithinSelection(
|
||||
elements,
|
||||
selection,
|
||||
arrayToMap([...elements, selection]),
|
||||
false,
|
||||
"overlap",
|
||||
).map((element) => element.id),
|
||||
).toEqual([rect1.id, rect2.id]);
|
||||
});
|
||||
|
||||
it("should retain nested and interleaved group element order", () => {
|
||||
const outerNested1 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "outerNested1",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["inner", "outer"],
|
||||
});
|
||||
const other1 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "other1",
|
||||
x: 70,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["other"],
|
||||
});
|
||||
const outerOnly = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "outerOnly",
|
||||
x: 140,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["outer"],
|
||||
});
|
||||
const other2 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "other2",
|
||||
x: 210,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["other"],
|
||||
});
|
||||
const outerNested2 = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "outerNested2",
|
||||
x: 280,
|
||||
y: 0,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["inner", "outer"],
|
||||
});
|
||||
const selection = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 295,
|
||||
y: -10,
|
||||
width: 10,
|
||||
height: 70,
|
||||
});
|
||||
const elements = [outerNested1, other1, outerOnly, other2, outerNested2];
|
||||
|
||||
expect(
|
||||
getElementsWithinSelection(
|
||||
elements,
|
||||
selection,
|
||||
arrayToMap([...elements, selection]),
|
||||
false,
|
||||
"overlap",
|
||||
).map((element) => element.id),
|
||||
).toEqual([outerNested1.id, outerOnly.id, outerNested2.id]);
|
||||
});
|
||||
|
||||
it("should not select a transparent rectangle when the selection box stays inside it", () => {
|
||||
const rect1 = API.createElement({
|
||||
type: "rectangle",
|
||||
@@ -716,11 +859,175 @@ describe("inner box-selection", () => {
|
||||
mouse.moveTo(rect2.x + rect2.width + 10, rect2.y + rect2.height + 10);
|
||||
mouse.up();
|
||||
|
||||
assertSelectedElements([rect1.id]);
|
||||
expect(h.state.selectedGroupIds).toEqual({});
|
||||
});
|
||||
|
||||
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||
mouse.downAt(40, 40);
|
||||
mouse.move(-1000, -1000);
|
||||
mouse.moveTo(rect3.x + rect3.width + 10, rect3.y + rect3.height + 10);
|
||||
mouse.up();
|
||||
|
||||
assertSelectedElements([rect2.id, rect3.id]);
|
||||
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||
});
|
||||
});
|
||||
|
||||
it("does not select a nested outer group until all members are contained", async () => {
|
||||
const innerRect1 = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 50,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["inner", "outer"],
|
||||
});
|
||||
const innerRect2 = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 120,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["inner", "outer"],
|
||||
});
|
||||
const outerRect = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 190,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["outer"],
|
||||
});
|
||||
API.setElements([innerRect1, innerRect2, outerRect]);
|
||||
|
||||
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||
mouse.downAt(0, 0);
|
||||
mouse.move(-1000, -1000);
|
||||
mouse.moveTo(
|
||||
innerRect2.x + innerRect2.width + 10,
|
||||
innerRect2.y + innerRect2.height + 10,
|
||||
);
|
||||
mouse.up();
|
||||
|
||||
assertSelectedElements([]);
|
||||
expect(h.state.selectedGroupIds).toEqual({});
|
||||
});
|
||||
|
||||
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||
mouse.downAt(0, 0);
|
||||
mouse.move(-1000, -1000);
|
||||
mouse.moveTo(
|
||||
outerRect.x + outerRect.width + 10,
|
||||
outerRect.y + outerRect.height + 10,
|
||||
);
|
||||
mouse.up();
|
||||
|
||||
assertSelectedElements([innerRect1.id, innerRect2.id, outerRect.id]);
|
||||
expect(h.state.selectedGroupIds).toEqual({ outer: true });
|
||||
});
|
||||
});
|
||||
|
||||
it.skip("checks nested containment against the current editing depth", async () => {
|
||||
const innerRect1 = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 50,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["inner", "outer"],
|
||||
});
|
||||
const innerRect2 = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 120,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["inner", "outer"],
|
||||
});
|
||||
const outerRect = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 190,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["outer"],
|
||||
});
|
||||
const selection = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 40,
|
||||
y: 40,
|
||||
width: 140,
|
||||
height: 70,
|
||||
});
|
||||
const elements = [innerRect1, innerRect2, outerRect];
|
||||
const elementsMap = arrayToMap([...elements, selection]);
|
||||
|
||||
expect(
|
||||
getElementsWithinSelection(
|
||||
elements,
|
||||
selection,
|
||||
elementsMap,
|
||||
false,
|
||||
"contain",
|
||||
).map((element) => element.id),
|
||||
).toEqual([]);
|
||||
|
||||
expect(
|
||||
getElementsWithinSelection(
|
||||
elements,
|
||||
selection,
|
||||
elementsMap,
|
||||
false,
|
||||
"contain",
|
||||
// "outer", /* editingGroupId - add as param once we implement nested group handling */
|
||||
).map((element) => element.id),
|
||||
).toEqual([innerRect1.id, innerRect2.id]);
|
||||
});
|
||||
|
||||
it("ignores grouped bound text when checking box-selection containment", async () => {
|
||||
const container = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "container",
|
||||
x: 50,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["A"],
|
||||
boundElements: [{ type: "text", id: "bound-text" }],
|
||||
});
|
||||
const boundText = API.createElement({
|
||||
type: "text",
|
||||
id: "bound-text",
|
||||
x: 50,
|
||||
y: 50,
|
||||
width: 50,
|
||||
height: 20,
|
||||
containerId: container.id,
|
||||
groupIds: ["A"],
|
||||
});
|
||||
const rect = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 150,
|
||||
y: 150,
|
||||
width: 50,
|
||||
height: 50,
|
||||
groupIds: ["A"],
|
||||
});
|
||||
API.setElements([container, boundText, rect]);
|
||||
|
||||
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||
mouse.downAt(40, 40);
|
||||
mouse.move(-1000, -1000);
|
||||
mouse.moveTo(rect.x + rect.width + 10, rect.y + rect.height + 10);
|
||||
mouse.up();
|
||||
|
||||
expect(h.state.selectedElementIds[container.id]).toBe(true);
|
||||
expect(h.state.selectedElementIds[rect.id]).toBe(true);
|
||||
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||
});
|
||||
});
|
||||
|
||||
it("selecting & deselecting grouped elements visually nested inside another", async () => {
|
||||
const rect1 = API.createElement({
|
||||
type: "rectangle",
|
||||
@@ -751,7 +1058,7 @@ describe("inner box-selection", () => {
|
||||
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||
mouse.downAt(rect2.x - 20, rect2.y - 20);
|
||||
mouse.move(-1000, -1000);
|
||||
mouse.moveTo(rect2.x + rect2.width + 10, rect2.y + rect2.height + 10);
|
||||
mouse.moveTo(rect3.x + rect3.width + 10, rect3.y + rect3.height + 10);
|
||||
assertSelectedElements([rect2.id, rect3.id]);
|
||||
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||
mouse.moveTo(rect2.x - 10, rect2.y - 10);
|
||||
|
||||
@@ -1,833 +0,0 @@
|
||||
import { arrayToMap } from "@excalidraw/common";
|
||||
import {
|
||||
pointFrom,
|
||||
rangeInclusive,
|
||||
type GlobalPoint,
|
||||
type Radians,
|
||||
} from "@excalidraw/math";
|
||||
|
||||
import type { ExcalidrawElement } from "@excalidraw/element/types";
|
||||
|
||||
import { getDefaultAppState } from "../appState";
|
||||
import {
|
||||
getElementsCorners,
|
||||
getVisibleGaps,
|
||||
getReferenceSnapPoints,
|
||||
SnapCache,
|
||||
snapDraggedElements,
|
||||
} from "../snapping";
|
||||
|
||||
import { API } from "./helpers/api";
|
||||
|
||||
import type {
|
||||
AppClassProperties,
|
||||
AppState,
|
||||
NormalizedZoomValue,
|
||||
} from "../types";
|
||||
|
||||
type ReferenceSnapPoints = NonNullable<
|
||||
ReturnType<typeof SnapCache.getReferenceSnapPoints>
|
||||
>;
|
||||
|
||||
const NO_MODIFIER_KEYS = {
|
||||
altKey: false,
|
||||
ctrlKey: false,
|
||||
metaKey: false,
|
||||
shiftKey: false,
|
||||
};
|
||||
|
||||
const createSnappingApp = (appState: Partial<AppState> = {}) =>
|
||||
({
|
||||
props: {},
|
||||
state: {
|
||||
...getDefaultAppState(),
|
||||
objectsSnapModeEnabled: true,
|
||||
width: 1000,
|
||||
height: 1000,
|
||||
offsetLeft: 0,
|
||||
offsetTop: 0,
|
||||
...appState,
|
||||
},
|
||||
} as AppClassProperties);
|
||||
|
||||
const getHorizontalPointSnapLineCoordinates = (
|
||||
snapLines: ReturnType<typeof snapDraggedElements>["snapLines"],
|
||||
) => {
|
||||
return snapLines
|
||||
.filter((snapLine) => snapLine.type === "points")
|
||||
.filter((snapLine) => {
|
||||
const [firstPoint, lastPoint] = snapLine.points;
|
||||
|
||||
return firstPoint[1] === lastPoint[1];
|
||||
})
|
||||
.map((snapLine) => {
|
||||
return snapLine.points[0][1];
|
||||
})
|
||||
.sort((a, b) => a - b);
|
||||
};
|
||||
|
||||
const getVerticalPointSnapLineCoordinates = (
|
||||
snapLines: ReturnType<typeof snapDraggedElements>["snapLines"],
|
||||
) => {
|
||||
return snapLines
|
||||
.filter((snapLine) => snapLine.type === "points")
|
||||
.filter((snapLine) => {
|
||||
const [firstPoint, lastPoint] = snapLine.points;
|
||||
|
||||
return firstPoint[0] === lastPoint[0];
|
||||
})
|
||||
.map((snapLine) => {
|
||||
return snapLine.points[0][0];
|
||||
})
|
||||
.sort((a, b) => a - b);
|
||||
};
|
||||
|
||||
const getHorizontalPointSnapLineMaxX = (
|
||||
snapLines: ReturnType<typeof snapDraggedElements>["snapLines"],
|
||||
) => {
|
||||
const horizontalSnapLine = snapLines
|
||||
.filter((snapLine) => snapLine.type === "points")
|
||||
.find((snapLine) => {
|
||||
const [firstPoint, lastPoint] = snapLine.points;
|
||||
|
||||
return firstPoint[1] === lastPoint[1];
|
||||
});
|
||||
|
||||
if (!horizontalSnapLine) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return horizontalSnapLine.points[horizontalSnapLine.points.length - 1][0];
|
||||
};
|
||||
|
||||
const getHorizontalPointSnapLineXRange = (
|
||||
snapLines: ReturnType<typeof snapDraggedElements>["snapLines"],
|
||||
) => {
|
||||
const horizontalSnapLine = snapLines
|
||||
.filter((snapLine) => snapLine.type === "points")
|
||||
.find((snapLine) => {
|
||||
const [firstPoint, lastPoint] = snapLine.points;
|
||||
|
||||
return firstPoint[1] === lastPoint[1];
|
||||
});
|
||||
|
||||
if (!horizontalSnapLine) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return [
|
||||
horizontalSnapLine.points[0][0],
|
||||
horizontalSnapLine.points[horizontalSnapLine.points.length - 1][0],
|
||||
] as const;
|
||||
};
|
||||
|
||||
const getHorizontalGapSnapLines = (
|
||||
snapLines: ReturnType<typeof snapDraggedElements>["snapLines"],
|
||||
) => {
|
||||
return snapLines.filter(
|
||||
(snapLine) =>
|
||||
snapLine.type === "gap" && snapLine.direction === "horizontal",
|
||||
);
|
||||
};
|
||||
|
||||
const getVerticalGapSnapLines = (
|
||||
snapLines: ReturnType<typeof snapDraggedElements>["snapLines"],
|
||||
) => {
|
||||
return snapLines.filter(
|
||||
(snapLine) => snapLine.type === "gap" && snapLine.direction === "vertical",
|
||||
);
|
||||
};
|
||||
|
||||
const getPointKeys = (points: ReturnType<typeof getElementsCorners>) => {
|
||||
return points.map((point) => point.join(","));
|
||||
};
|
||||
|
||||
const getReferenceSnapPointKeys = (
|
||||
elements: ExcalidrawElement[],
|
||||
selectedElements: ExcalidrawElement[],
|
||||
app: AppClassProperties,
|
||||
) => {
|
||||
return new Set(
|
||||
getReferenceSnapPoints(
|
||||
elements,
|
||||
selectedElements,
|
||||
app.state,
|
||||
arrayToMap(elements),
|
||||
).map((snapPoint) => snapPoint.point.join(",")),
|
||||
);
|
||||
};
|
||||
|
||||
const primeReferenceSnapPoints = (
|
||||
elements: ExcalidrawElement[],
|
||||
selectedElements: ExcalidrawElement[],
|
||||
) => {
|
||||
const selectedElementIds = new Set(
|
||||
selectedElements.map((element) => element.id),
|
||||
);
|
||||
const elementsMap = arrayToMap(elements);
|
||||
|
||||
SnapCache.setReferenceSnapPoints(
|
||||
elements
|
||||
.filter((element) => !selectedElementIds.has(element.id))
|
||||
.flatMap((element) => {
|
||||
const corners = getElementsCorners([element], elementsMap);
|
||||
|
||||
return corners.map((point, index) => ({
|
||||
point,
|
||||
type: index === corners.length - 1 ? "center" : "outer",
|
||||
snapSourceId: element.id,
|
||||
}));
|
||||
}) as Parameters<typeof SnapCache.setReferenceSnapPoints>[0],
|
||||
);
|
||||
};
|
||||
|
||||
describe("snapping", () => {
|
||||
afterEach(() => {
|
||||
SnapCache.destroy();
|
||||
});
|
||||
|
||||
it("does not use frame children as references when snapping outside elements", () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
id: "frame",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 300,
|
||||
height: 300,
|
||||
});
|
||||
const frameChild = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "frameChild",
|
||||
x: 37,
|
||||
y: 53,
|
||||
width: 71,
|
||||
height: 83,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 400,
|
||||
y: 50,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [frame, frameChild, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
const referenceSnapPointKeys = getReferenceSnapPointKeys(
|
||||
elements,
|
||||
[selected],
|
||||
app,
|
||||
);
|
||||
const frameChildPointKeys = getPointKeys(
|
||||
getElementsCorners([frameChild], arrayToMap(elements)),
|
||||
);
|
||||
|
||||
expect(
|
||||
frameChildPointKeys.some((pointKey) =>
|
||||
referenceSnapPointKeys.has(pointKey),
|
||||
),
|
||||
).toBe(false);
|
||||
});
|
||||
|
||||
it("uses frame siblings as references when snapping elements in the same frame", () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
id: "frame",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 300,
|
||||
height: 300,
|
||||
});
|
||||
const sibling = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "sibling",
|
||||
x: 37,
|
||||
y: 53,
|
||||
width: 71,
|
||||
height: 83,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 150,
|
||||
y: 50,
|
||||
width: 100,
|
||||
height: 100,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const elements = [frame, sibling, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
const referenceSnapPointKeys = getReferenceSnapPointKeys(
|
||||
elements,
|
||||
[selected],
|
||||
app,
|
||||
);
|
||||
const siblingPointKeys = getPointKeys(
|
||||
getElementsCorners([sibling], arrayToMap(elements)),
|
||||
);
|
||||
|
||||
expect(
|
||||
siblingPointKeys.some((pointKey) => referenceSnapPointKeys.has(pointKey)),
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
it("does not use frame children as references when snapping the frame itself", () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
id: "frame",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 300,
|
||||
height: 300,
|
||||
});
|
||||
const frameChild = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "frameChild",
|
||||
x: 37,
|
||||
y: 53,
|
||||
width: 71,
|
||||
height: 83,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const elements = [frame, frameChild];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [frame.id]: true },
|
||||
});
|
||||
|
||||
const referenceSnapPointKeys = getReferenceSnapPointKeys(
|
||||
elements,
|
||||
[frame],
|
||||
app,
|
||||
);
|
||||
const frameChildPointKeys = getPointKeys(
|
||||
getElementsCorners([frameChild], arrayToMap(elements)),
|
||||
);
|
||||
|
||||
expect(
|
||||
frameChildPointKeys.some((pointKey) =>
|
||||
referenceSnapPointKeys.has(pointKey),
|
||||
),
|
||||
).toBe(false);
|
||||
});
|
||||
|
||||
it("does not use frame children as visible gap references when snapping outside elements", () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
id: "frame",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 500,
|
||||
height: 300,
|
||||
});
|
||||
const frameChildA = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "frameChildA",
|
||||
x: 50,
|
||||
y: 50,
|
||||
width: 100,
|
||||
height: 100,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const frameChildB = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "frameChildB",
|
||||
x: 250,
|
||||
y: 50,
|
||||
width: 100,
|
||||
height: 100,
|
||||
frameId: frame.id,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 700,
|
||||
y: 50,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [frame, frameChildA, frameChildB, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
const visibleGaps = getVisibleGaps(
|
||||
elements,
|
||||
[selected],
|
||||
app.state,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(visibleGaps.horizontalGaps).toHaveLength(0);
|
||||
expect(visibleGaps.verticalGaps).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("filters center and inner outer point snaplines for the same reference", () => {
|
||||
const angle = 0.68 as Radians;
|
||||
const reference = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "reference",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 140,
|
||||
height: 140,
|
||||
angle,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 200,
|
||||
y: 0,
|
||||
width: 140,
|
||||
height: 140,
|
||||
angle,
|
||||
});
|
||||
const elements = [reference, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
primeReferenceSnapPoints(elements, [selected]);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getHorizontalPointSnapLineCoordinates(snapLines)).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("keeps a snapline that is redundant for one reference but needed for another", () => {
|
||||
const angle = 0.68 as Radians;
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 200,
|
||||
y: 0,
|
||||
width: 140,
|
||||
height: 140,
|
||||
angle,
|
||||
});
|
||||
const elements = [selected];
|
||||
const elementsMap = arrayToMap(elements);
|
||||
const selectedSnapPoints = getElementsCorners([selected], elementsMap);
|
||||
const outerSnapPoints = selectedSnapPoints.slice(0, -1);
|
||||
const centerSnapPoint = selectedSnapPoints[selectedSnapPoints.length - 1];
|
||||
const innerOuterSnapPoint = [...outerSnapPoints].sort(
|
||||
(a, b) => a[1] - b[1],
|
||||
)[1];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
const referenceSnapPoints: ReferenceSnapPoints = [
|
||||
...outerSnapPoints.map((point) => ({
|
||||
point: pointFrom<GlobalPoint>(point[0] - 200, point[1]),
|
||||
type: "outer" as const,
|
||||
snapSourceId: "referenceA",
|
||||
})),
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(
|
||||
centerSnapPoint[0] - 200,
|
||||
centerSnapPoint[1],
|
||||
),
|
||||
type: "center" as const,
|
||||
snapSourceId: "referenceA",
|
||||
},
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(
|
||||
innerOuterSnapPoint[0] - 300,
|
||||
innerOuterSnapPoint[1],
|
||||
),
|
||||
type: "outer" as const,
|
||||
snapSourceId: "referenceB",
|
||||
},
|
||||
];
|
||||
|
||||
SnapCache.setReferenceSnapPoints(referenceSnapPoints);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
elementsMap,
|
||||
);
|
||||
|
||||
expect(getHorizontalPointSnapLineCoordinates(snapLines)).toHaveLength(3);
|
||||
});
|
||||
|
||||
it("keeps a center snapline when no outer snaplines imply it", () => {
|
||||
const reference = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "reference",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 200,
|
||||
y: 25,
|
||||
width: 50,
|
||||
height: 50,
|
||||
});
|
||||
const elements = [reference, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
primeReferenceSnapPoints(elements, [selected]);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getHorizontalPointSnapLineCoordinates(snapLines)).toEqual([50]);
|
||||
});
|
||||
|
||||
it("filters center snaplines when matching outer offsets differ by rounding precision", () => {
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 2532.227563984471,
|
||||
y: -1553.9657067952232,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const reference = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "reference",
|
||||
x: 2532.2275640966914,
|
||||
y: -1299.4323092037737,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const elements = [reference, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
primeReferenceSnapPoints(elements, [selected]);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getVerticalPointSnapLineCoordinates(snapLines)).toEqual([
|
||||
2532.227564, 2672.329126,
|
||||
]);
|
||||
});
|
||||
|
||||
it("keeps outer snaplines stable while dragging a snapped element through rounding-equivalent offsets", () => {
|
||||
const referenceMiddle = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "referenceMiddle",
|
||||
x: 2532.22756398447,
|
||||
y: -1553.9657067952237,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const referenceAbove = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "referenceAbove",
|
||||
x: 2532.2275637826165,
|
||||
y: -1779.7363232531268,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 2532.227563096691,
|
||||
y: -1328.1950902037736,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const elements = [referenceAbove, referenceMiddle, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
primeReferenceSnapPoints(elements, [selected]);
|
||||
|
||||
for (const dragOffsetX of [-4, -1, -0.1, 0, 0.1, 1, 4]) {
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: dragOffsetX, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
const coordinates = getVerticalPointSnapLineCoordinates(snapLines);
|
||||
|
||||
expect(coordinates).toHaveLength(2);
|
||||
expect(coordinates[1] - coordinates[0]).toBeCloseTo(selected.width, 5);
|
||||
}
|
||||
});
|
||||
|
||||
it("keeps same-offset point snaps even across distant references", () => {
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
SnapCache.setReferenceSnapPoints([
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(220, 50),
|
||||
type: "center",
|
||||
snapSourceId: "near",
|
||||
},
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(900, 50),
|
||||
type: "center",
|
||||
snapSourceId: "far",
|
||||
},
|
||||
]);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getHorizontalPointSnapLineMaxX(snapLines)).toBe(900);
|
||||
});
|
||||
|
||||
it("prefers a nearby point snap over a slightly better far offset", () => {
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
SnapCache.setReferenceSnapPoints([
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(220, 54),
|
||||
type: "center",
|
||||
snapSourceId: "near",
|
||||
},
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(900, 50),
|
||||
type: "center",
|
||||
snapSourceId: "far",
|
||||
},
|
||||
]);
|
||||
|
||||
const { snapOffset, snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(snapOffset.y).toBe(4);
|
||||
expect(getHorizontalPointSnapLineMaxX(snapLines)).toBe(220);
|
||||
});
|
||||
|
||||
it("keeps same-offset point snaps when references form a continuous cluster", () => {
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
SnapCache.setReferenceSnapPoints([
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(200, 50),
|
||||
type: "center",
|
||||
snapSourceId: "referenceA",
|
||||
},
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(350, 50),
|
||||
type: "center",
|
||||
snapSourceId: "referenceB",
|
||||
},
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(500, 50),
|
||||
type: "center",
|
||||
snapSourceId: "referenceC",
|
||||
},
|
||||
]);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getHorizontalPointSnapLineMaxX(snapLines)).toBe(500);
|
||||
});
|
||||
|
||||
it("keeps same-source same-offset point snaps across zoom-scaled cluster breaks", () => {
|
||||
const reference = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "reference",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 338.608871112217,
|
||||
y: 0,
|
||||
width: 140.1015625,
|
||||
height: 140.1015625,
|
||||
});
|
||||
const elements = [reference, selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
zoom: { value: 1.5 as NormalizedZoomValue },
|
||||
});
|
||||
|
||||
primeReferenceSnapPoints(elements, [selected]);
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
const range = getHorizontalPointSnapLineXRange(snapLines);
|
||||
|
||||
expect(range).not.toBe(null);
|
||||
expect(range![0]).toBeCloseTo(reference.x, 6);
|
||||
expect(range![1]).toBeCloseTo(selected.x + selected.width, 6);
|
||||
});
|
||||
|
||||
it("renders gap snaplines when rounded bounds touch the reference gap overlap", () => {
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 0,
|
||||
y: 0.0000004,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
SnapCache.setVisibleGaps({
|
||||
horizontalGaps: [
|
||||
{
|
||||
startBounds: [200, -100, 300, 0],
|
||||
endBounds: [400, -100, 500, 0],
|
||||
startSide: [pointFrom(300, -100), pointFrom(300, 0)],
|
||||
endSide: [pointFrom(400, -100), pointFrom(400, 0)],
|
||||
overlap: rangeInclusive(-100, 0),
|
||||
length: 100,
|
||||
},
|
||||
],
|
||||
verticalGaps: [],
|
||||
});
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getHorizontalGapSnapLines(snapLines)).toHaveLength(2);
|
||||
});
|
||||
|
||||
it("renders gap snaplines when the winning gap offset only differs by rounding precision", () => {
|
||||
const selected = API.createElement({
|
||||
type: "rectangle",
|
||||
id: "selected",
|
||||
x: 0,
|
||||
y: 399.999999,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
const elements = [selected];
|
||||
const app = createSnappingApp({
|
||||
selectedElementIds: { [selected.id]: true },
|
||||
});
|
||||
|
||||
SnapCache.setReferenceSnapPoints([
|
||||
{
|
||||
point: pointFrom<GlobalPoint>(0, 399.999999),
|
||||
type: "outer",
|
||||
snapSourceId: "reference",
|
||||
},
|
||||
]);
|
||||
SnapCache.setVisibleGaps({
|
||||
horizontalGaps: [],
|
||||
verticalGaps: [
|
||||
{
|
||||
startBounds: [0, 100, 100, 200],
|
||||
endBounds: [0, 250, 100, 350],
|
||||
startSide: [pointFrom(0, 200), pointFrom(100, 200)],
|
||||
endSide: [pointFrom(0, 250), pointFrom(100, 250)],
|
||||
overlap: rangeInclusive(0, 100),
|
||||
length: 50,
|
||||
},
|
||||
],
|
||||
});
|
||||
|
||||
const { snapLines } = snapDraggedElements(
|
||||
elements,
|
||||
{ x: 0, y: 0 },
|
||||
app,
|
||||
NO_MODIFIER_KEYS,
|
||||
arrayToMap(elements),
|
||||
);
|
||||
|
||||
expect(getVerticalGapSnapLines(snapLines)).toHaveLength(2);
|
||||
});
|
||||
});
|
||||
@@ -4,10 +4,12 @@ import { resolvablePromise } from "@excalidraw/common";
|
||||
|
||||
import { Excalidraw } from "../index";
|
||||
|
||||
import { getToolbarTools } from "../components/shapes";
|
||||
|
||||
import { Pointer } from "./helpers/ui";
|
||||
import { act, render } from "./test-utils";
|
||||
|
||||
import type { ExcalidrawImperativeAPI } from "../types";
|
||||
import type { AppClassProperties, ExcalidrawImperativeAPI } from "../types";
|
||||
|
||||
describe("setActiveTool()", () => {
|
||||
const h = window.h;
|
||||
@@ -66,3 +68,27 @@ describe("setActiveTool()", () => {
|
||||
expect(h.state.activeTool.customType).toBe("comment");
|
||||
});
|
||||
});
|
||||
describe("getToolbarTools()", () => {
|
||||
const getToolValues = (preferredSelectionTool: "selection" | "lasso") =>
|
||||
getToolbarTools({
|
||||
state: {
|
||||
preferredSelectionTool: {
|
||||
type: preferredSelectionTool,
|
||||
},
|
||||
},
|
||||
} as AppClassProperties).map((tool) => tool.value);
|
||||
|
||||
it("does not include lasso when selection is preferred", () => {
|
||||
const toolValues = getToolValues("selection");
|
||||
|
||||
expect(toolValues.filter((value) => value === "selection")).toHaveLength(1);
|
||||
expect(toolValues.filter((value) => value === "lasso")).toHaveLength(0);
|
||||
});
|
||||
|
||||
it("replaces selection with lasso when lasso is preferred", () => {
|
||||
const toolValues = getToolValues("lasso");
|
||||
|
||||
expect(toolValues.filter((value) => value === "lasso")).toHaveLength(1);
|
||||
expect(toolValues.filter((value) => value === "selection")).toHaveLength(0);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -363,6 +363,7 @@ export interface AppState {
|
||||
currentItemBackgroundColor: string;
|
||||
currentItemFillStyle: ExcalidrawElement["fillStyle"];
|
||||
currentItemStrokeWidth: number;
|
||||
currentItemFreedrawConstantPressure: boolean;
|
||||
currentItemStrokeStyle: ExcalidrawElement["strokeStyle"];
|
||||
currentItemRoughness: number;
|
||||
currentItemOpacity: number;
|
||||
@@ -645,6 +646,10 @@ export interface ExcalidrawProps {
|
||||
appState: UIAppState,
|
||||
) => JSX.Element;
|
||||
UIOptions?: Partial<UIOptions>;
|
||||
/**
|
||||
* dimensions and size constraints for inserted images
|
||||
*/
|
||||
imageOptions?: ImageOptions;
|
||||
detectScroll?: boolean;
|
||||
handleKeyboardGlobally?: boolean;
|
||||
onLibraryChange?: (libraryItems: LibraryItems) => void | Promise<any>;
|
||||
@@ -731,6 +736,11 @@ export type ExportOpts = {
|
||||
) => JSX.Element;
|
||||
};
|
||||
|
||||
export type ImageOptions = Partial<{
|
||||
maxWidthOrHeight: number;
|
||||
maxFileSizeBytes: number;
|
||||
}>;
|
||||
|
||||
// NOTE at the moment, if action name corresponds to canvasAction prop, its
|
||||
// truthiness value will determine whether the action is rendered or not
|
||||
// (see manager renderAction). We also override canvasAction values in
|
||||
@@ -772,6 +782,7 @@ export type AppProps = Merge<
|
||||
canvasActions: Required<CanvasActions> & { export: ExportOpts };
|
||||
}
|
||||
>;
|
||||
imageOptions: Required<ImageOptions>;
|
||||
detectScroll: boolean;
|
||||
handleKeyboardGlobally: boolean;
|
||||
isCollaborating: boolean;
|
||||
@@ -899,7 +910,10 @@ export type PointerDownState = Readonly<{
|
||||
// We need to have these in the state so that we can unsubscribe them
|
||||
eventListeners: {
|
||||
// It's defined on the initial pointer down event
|
||||
onMove: null | ReturnType<typeof throttleRAF>;
|
||||
onMove:
|
||||
| null
|
||||
| ReturnType<typeof throttleRAF>
|
||||
| (((event: PointerEvent) => void) & { flush(): void; cancel(): void });
|
||||
// It's defined on the initial pointer down event
|
||||
onUp: null | ((event: PointerEvent) => void);
|
||||
// It's defined on the initial pointer down event
|
||||
|
||||
@@ -769,6 +769,63 @@ describe("textWysiwyg", () => {
|
||||
]);
|
||||
});
|
||||
|
||||
it("should not add bound text to a frame when its container is not a frame child", async () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 200,
|
||||
height: 200,
|
||||
});
|
||||
const rectangle = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 20,
|
||||
width: 90,
|
||||
height: 75,
|
||||
backgroundColor: "red",
|
||||
});
|
||||
API.setElements([frame, rectangle]);
|
||||
|
||||
mouse.doubleClickAt(rectangle.x + 10, rectangle.y + 10);
|
||||
|
||||
const text = h.elements[2] as ExcalidrawTextElementWithContainer;
|
||||
expect(text.type).toBe("text");
|
||||
expect(text.containerId).toBe(rectangle.id);
|
||||
expect(text.frameId).toBe(null);
|
||||
});
|
||||
|
||||
it("should bind text to a frame child container when single clicking its center", async () => {
|
||||
const frame = API.createElement({
|
||||
type: "frame",
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 200,
|
||||
height: 200,
|
||||
});
|
||||
const rectangle = API.createElement({
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
y: 20,
|
||||
width: 90,
|
||||
height: 75,
|
||||
backgroundColor: "red",
|
||||
frameId: frame.id,
|
||||
});
|
||||
API.setElements([rectangle, frame]);
|
||||
|
||||
UI.clickTool("text");
|
||||
mouse.clickAt(
|
||||
rectangle.x + rectangle.width / 2,
|
||||
rectangle.y + rectangle.height / 2,
|
||||
);
|
||||
|
||||
const text = h.elements[1] as ExcalidrawTextElementWithContainer;
|
||||
expect(text.type).toBe("text");
|
||||
expect(text.containerId).toBe(rectangle.id);
|
||||
expect(text.frameId).toBe(frame.id);
|
||||
});
|
||||
|
||||
it("should set the text element angle to same as container angle when binding to rotated container", async () => {
|
||||
const rectangle = API.createElement({
|
||||
type: "rectangle",
|
||||
|
||||
@@ -392,10 +392,10 @@ export const textWysiwyg = ({
|
||||
),
|
||||
textAlign,
|
||||
verticalAlign,
|
||||
color:
|
||||
appState.theme === THEME.DARK
|
||||
? applyDarkModeFilter(updatedTextElement.strokeColor)
|
||||
: updatedTextElement.strokeColor,
|
||||
color: applyDarkModeFilter(
|
||||
updatedTextElement.strokeColor,
|
||||
appState.theme === THEME.DARK,
|
||||
),
|
||||
opacity: updatedTextElement.opacity / 100,
|
||||
maxHeight: `${editorMaxHeight}px`,
|
||||
});
|
||||
|
||||
@@ -0,0 +1,45 @@
|
||||
{
|
||||
"name": "@excalidraw/fractional-indexing",
|
||||
"version": "3.3.0",
|
||||
"description": "Provides functions for generating ordering strings",
|
||||
"type": "module",
|
||||
"types": "./dist/types/fractional-indexing/src/index.d.ts",
|
||||
"main": "./dist/prod/index.js",
|
||||
"module": "./dist/prod/index.js",
|
||||
"engines": {
|
||||
"node": "^14.13.1 || >=16.0.0"
|
||||
},
|
||||
"scripts": {
|
||||
"gen:types": "rimraf types && tsc",
|
||||
"build:esm": "rimraf dist && node ../../scripts/buildBase.js && yarn gen:types"
|
||||
},
|
||||
"keywords": [
|
||||
"fractional",
|
||||
"indexing",
|
||||
"ordering",
|
||||
"order"
|
||||
],
|
||||
"homepage": "https://github.com/rocicorp/fractional-indexing#readme",
|
||||
"bugs": "https://github.com/excalidraw/excalidraw/issues",
|
||||
"repository": "https://github.com/excalidraw/excalidraw",
|
||||
"author": "arv@rocicorp.dev",
|
||||
"license": "CC0-1.0",
|
||||
"devDependencies": {
|
||||
"prettier": "^2.6.0",
|
||||
"typescript": "5.9.3"
|
||||
},
|
||||
"exports": {
|
||||
".": {
|
||||
"types": "./dist/types/fractional-indexing/src/index.d.ts",
|
||||
"development": "./dist/dev/index.js",
|
||||
"production": "./dist/prod/index.js",
|
||||
"default": "./dist/prod/index.js"
|
||||
}
|
||||
},
|
||||
"publishConfig": {
|
||||
"access": "public"
|
||||
},
|
||||
"files": [
|
||||
"dist/*"
|
||||
]
|
||||
}
|
||||
@@ -0,0 +1,322 @@
|
||||
// Vendored from https://www.npmjs.com/package/fractional-indexing
|
||||
// License: CC0 (no rights reserved).
|
||||
// This is based on https://observablehq.com/@dgreensp/implementing-fractional-indexing
|
||||
|
||||
export const BASE_62_DIGITS =
|
||||
"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
|
||||
|
||||
// `a` may be empty string, `b` is null or non-empty string.
|
||||
// `a < b` lexicographically if `b` is non-null.
|
||||
// no trailing zeros allowed.
|
||||
// digits is a string such as '0123456789' for base 10. Digits must be in
|
||||
// ascending character code order!
|
||||
/**
|
||||
* @param {string} a
|
||||
* @param {string | null | undefined} b
|
||||
* @param {string} digits
|
||||
* @returns {string}
|
||||
*/
|
||||
function midpoint(
|
||||
a: string,
|
||||
b: string | null | undefined,
|
||||
digits: string,
|
||||
): string {
|
||||
const zero = digits[0];
|
||||
if (b != null && a >= b) {
|
||||
throw new Error(`${a} >= ${b}`);
|
||||
}
|
||||
if (a.slice(-1) === zero || (b && b.slice(-1) === zero)) {
|
||||
throw new Error("trailing zero");
|
||||
}
|
||||
if (b) {
|
||||
// remove longest common prefix. pad `a` with 0s as we
|
||||
// go. note that we don't need to pad `b`, because it can't
|
||||
// end before `a` while traversing the common prefix.
|
||||
let n = 0;
|
||||
while ((a[n] || zero) === b[n]) {
|
||||
n++;
|
||||
}
|
||||
if (n > 0) {
|
||||
return b.slice(0, n) + midpoint(a.slice(n), b.slice(n), digits);
|
||||
}
|
||||
}
|
||||
// first digits (or lack of digit) are different
|
||||
const digitA = a ? digits.indexOf(a[0]) : 0;
|
||||
const digitB = b != null ? digits.indexOf(b[0]) : digits.length;
|
||||
if (digitB - digitA > 1) {
|
||||
const midDigit = Math.round(0.5 * (digitA + digitB));
|
||||
return digits[midDigit];
|
||||
}
|
||||
// first digits are consecutive
|
||||
if (b && b.length > 1) {
|
||||
return b.slice(0, 1);
|
||||
}
|
||||
|
||||
// `b` is null or has length 1 (a single digit).
|
||||
// the first digit of `a` is the previous digit to `b`,
|
||||
// or 9 if `b` is null.
|
||||
// given, for example, midpoint('49', '5'), return
|
||||
// '4' + midpoint('9', null), which will become
|
||||
// '4' + '9' + midpoint('', null), which is '495'
|
||||
return digits[digitA] + midpoint(a.slice(1), null, digits);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param {string} int
|
||||
* @return {void}
|
||||
*/
|
||||
|
||||
function validateInteger(int: string): void {
|
||||
if (int.length !== getIntegerLength(int[0])) {
|
||||
throw new Error(`invalid integer part of order key: ${int}`);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* @param {string} head
|
||||
* @return {number}
|
||||
*/
|
||||
|
||||
function getIntegerLength(head: string): number {
|
||||
if (head >= "a" && head <= "z") {
|
||||
return head.charCodeAt(0) - "a".charCodeAt(0) + 2;
|
||||
} else if (head >= "A" && head <= "Z") {
|
||||
return "Z".charCodeAt(0) - head.charCodeAt(0) + 2;
|
||||
}
|
||||
|
||||
throw new Error(`invalid order key head: ${head}`);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param {string} key
|
||||
* @return {string}
|
||||
*/
|
||||
|
||||
function getIntegerPart(key: string): string {
|
||||
const integerPartLength = getIntegerLength(key[0]);
|
||||
|
||||
if (integerPartLength > key.length) {
|
||||
throw new Error(`invalid order key: ${key}`);
|
||||
}
|
||||
return key.slice(0, integerPartLength);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param {string} key
|
||||
* @param {string} digits
|
||||
* @return {void}
|
||||
*/
|
||||
export function validateOrderKey(
|
||||
key: string,
|
||||
digits: string = BASE_62_DIGITS,
|
||||
): void {
|
||||
const validChars = key.split("").every((char) => digits.includes(char));
|
||||
if (key === `A${digits[0].repeat(26)}` || !validChars) {
|
||||
throw new Error(`invalid order key: ${key}`);
|
||||
}
|
||||
// getIntegerPart will throw if the first character is bad,
|
||||
// or the key is too short. we'd call it to check these things
|
||||
// even if we didn't need the result
|
||||
const i = getIntegerPart(key);
|
||||
const f = key.slice(i.length);
|
||||
if (f.slice(-1) === digits[0]) {
|
||||
throw new Error(`invalid order key: ${key}`);
|
||||
}
|
||||
}
|
||||
|
||||
// note that this may return null, as there is a largest integer
|
||||
/**
|
||||
* @param {string} x
|
||||
* @param {string} digits
|
||||
* @return {string | null}
|
||||
*/
|
||||
function incrementInteger(x: string, digits: string): string | null {
|
||||
validateInteger(x);
|
||||
const [head, ...digs] = x.split("");
|
||||
let carry = true;
|
||||
for (let i = digs.length - 1; carry && i >= 0; i--) {
|
||||
const d = digits.indexOf(digs[i]) + 1;
|
||||
if (d === digits.length) {
|
||||
digs[i] = digits[0];
|
||||
} else {
|
||||
digs[i] = digits[d];
|
||||
carry = false;
|
||||
}
|
||||
}
|
||||
if (carry) {
|
||||
if (head === "Z") {
|
||||
return `a${digits[0]}`;
|
||||
}
|
||||
if (head === "z") {
|
||||
return null;
|
||||
}
|
||||
const h = String.fromCharCode(head.charCodeAt(0) + 1);
|
||||
if (h > "a") {
|
||||
digs.push(digits[0]);
|
||||
} else {
|
||||
digs.pop();
|
||||
}
|
||||
return h + digs.join("");
|
||||
}
|
||||
return head + digs.join("");
|
||||
}
|
||||
|
||||
// note that this may return null, as there is a smallest integer
|
||||
/**
|
||||
* @param {string} x
|
||||
* @param {string} digits
|
||||
* @return {string | null}
|
||||
*/
|
||||
function decrementInteger(x: string, digits: string): string | null {
|
||||
validateInteger(x);
|
||||
const [head, ...digs] = x.split("");
|
||||
let borrow = true;
|
||||
for (let i = digs.length - 1; borrow && i >= 0; i--) {
|
||||
const d = digits.indexOf(digs[i]) - 1;
|
||||
if (d === -1) {
|
||||
digs[i] = digits.slice(-1);
|
||||
} else {
|
||||
digs[i] = digits[d];
|
||||
borrow = false;
|
||||
}
|
||||
}
|
||||
if (borrow) {
|
||||
if (head === "a") {
|
||||
return `Z${digits.slice(-1)}`;
|
||||
}
|
||||
if (head === "A") {
|
||||
return null;
|
||||
}
|
||||
const h = String.fromCharCode(head.charCodeAt(0) - 1);
|
||||
if (h < "Z") {
|
||||
digs.push(digits.slice(-1));
|
||||
} else {
|
||||
digs.pop();
|
||||
}
|
||||
return h + digs.join("");
|
||||
}
|
||||
return head + digs.join("");
|
||||
}
|
||||
|
||||
// `a` is an order key or null (START).
|
||||
// `b` is an order key or null (END).
|
||||
// `a < b` lexicographically if both are non-null.
|
||||
// digits is a string such as '0123456789' for base 10. Digits must be in
|
||||
// ascending character code order!
|
||||
/**
|
||||
* @param {string | null | undefined} a
|
||||
* @param {string | null | undefined} b
|
||||
* @param {string=} digits
|
||||
* @return {string}
|
||||
*/
|
||||
export function generateKeyBetween(
|
||||
a: string | null | undefined,
|
||||
b: string | null | undefined,
|
||||
digits = BASE_62_DIGITS,
|
||||
): string {
|
||||
if (a != null) {
|
||||
validateOrderKey(a, digits);
|
||||
}
|
||||
if (b != null) {
|
||||
validateOrderKey(b, digits);
|
||||
}
|
||||
if (a != null && b != null && a >= b) {
|
||||
throw new Error(`${a} >= ${b}`);
|
||||
}
|
||||
if (a == null) {
|
||||
if (b == null) {
|
||||
return `a${digits[0]}`;
|
||||
}
|
||||
|
||||
const ib = getIntegerPart(b);
|
||||
const fb = b.slice(ib.length);
|
||||
if (ib === `A${digits[0].repeat(26)}`) {
|
||||
return ib + midpoint("", fb, digits);
|
||||
}
|
||||
if (ib < b) {
|
||||
return ib;
|
||||
}
|
||||
const res = decrementInteger(ib, digits);
|
||||
if (res == null) {
|
||||
throw new Error("cannot decrement any more");
|
||||
}
|
||||
return res;
|
||||
}
|
||||
|
||||
if (b == null) {
|
||||
const ia = getIntegerPart(a);
|
||||
const fa = a.slice(ia.length);
|
||||
const i = incrementInteger(ia, digits);
|
||||
return i == null ? ia + midpoint(fa, null, digits) : i;
|
||||
}
|
||||
|
||||
const ia = getIntegerPart(a);
|
||||
const fa = a.slice(ia.length);
|
||||
const ib = getIntegerPart(b);
|
||||
const fb = b.slice(ib.length);
|
||||
if (ia === ib) {
|
||||
return ia + midpoint(fa, fb, digits);
|
||||
}
|
||||
const i = incrementInteger(ia, digits);
|
||||
if (i == null) {
|
||||
throw new Error("cannot increment any more");
|
||||
}
|
||||
if (i < b) {
|
||||
return i;
|
||||
}
|
||||
return ia + midpoint(fa, null, digits);
|
||||
}
|
||||
|
||||
/**
|
||||
* same preconditions as generateKeysBetween.
|
||||
* n >= 0.
|
||||
* Returns an array of n distinct keys in sorted order.
|
||||
* If a and b are both null, returns [a0, a1, ...]
|
||||
* If one or the other is null, returns consecutive "integer"
|
||||
* keys. Otherwise, returns relatively short keys between
|
||||
* a and b.
|
||||
* @param {string | null | undefined} a
|
||||
* @param {string | null | undefined} b
|
||||
* @param {number} n
|
||||
* @param {string} digits
|
||||
* @return {string[]}
|
||||
*/
|
||||
export function generateNKeysBetween(
|
||||
a: string | null | undefined,
|
||||
b: string | null | undefined,
|
||||
n: number,
|
||||
digits = BASE_62_DIGITS,
|
||||
): string[] {
|
||||
if (n === 0) {
|
||||
return [];
|
||||
}
|
||||
if (n === 1) {
|
||||
return [generateKeyBetween(a, b, digits)];
|
||||
}
|
||||
if (b == null) {
|
||||
let c = generateKeyBetween(a, b, digits);
|
||||
const result = [c];
|
||||
for (let i = 0; i < n - 1; i++) {
|
||||
c = generateKeyBetween(c, b, digits);
|
||||
result.push(c);
|
||||
}
|
||||
return result;
|
||||
}
|
||||
if (a == null) {
|
||||
let c = generateKeyBetween(a, b, digits);
|
||||
const result = [c];
|
||||
for (let i = 0; i < n - 1; i++) {
|
||||
c = generateKeyBetween(a, c, digits);
|
||||
result.push(c);
|
||||
}
|
||||
result.reverse();
|
||||
return result;
|
||||
}
|
||||
const mid = Math.floor(n / 2);
|
||||
const c = generateKeyBetween(a, b, digits);
|
||||
return [
|
||||
...generateNKeysBetween(a, c, mid, digits),
|
||||
c,
|
||||
...generateNKeysBetween(c, b, n - mid - 1, digits),
|
||||
];
|
||||
}
|
||||
@@ -0,0 +1,8 @@
|
||||
{
|
||||
"extends": "../tsconfig.base.json",
|
||||
"compilerOptions": {
|
||||
"outDir": "./dist/types"
|
||||
},
|
||||
"include": ["src/**/*", "global.d.ts"],
|
||||
"exclude": ["**/*.test.*", "tests", "types", "examples", "dist"]
|
||||
}
|
||||
@@ -1,5 +1,5 @@
|
||||
import { degreesToRadians } from "./angle";
|
||||
import { PRECISION } from "./utils";
|
||||
import { isFiniteNumber, PRECISION } from "./utils";
|
||||
import { vectorFromPoint, vectorScale } from "./vector";
|
||||
|
||||
import type {
|
||||
@@ -253,3 +253,12 @@ export const isPointWithinBounds = <P extends GlobalPoint | LocalPoint>(
|
||||
q[1] >= Math.min(p[1], r[1])
|
||||
);
|
||||
};
|
||||
|
||||
export const isValidPoint = (point: unknown): point is LocalPoint => {
|
||||
return (
|
||||
Array.isArray(point) &&
|
||||
point.length === 2 &&
|
||||
isFiniteNumber(point[0]) &&
|
||||
isFiniteNumber(point[1])
|
||||
);
|
||||
};
|
||||
|
||||
@@ -20,7 +20,9 @@
|
||||
"@excalidraw/math": ["./math/src/index.ts"],
|
||||
"@excalidraw/math/*": ["./math/src/*"],
|
||||
"@excalidraw/utils": ["./utils/src/index.ts"],
|
||||
"@excalidraw/utils/*": ["./utils/src/*"]
|
||||
"@excalidraw/utils/*": ["./utils/src/*"],
|
||||
"@excalidraw/fractional-indexing": ["./fractional-indexing/src/index.ts"],
|
||||
"@excalidraw/fractional-indexing/*": ["./fractional-indexing/src/*"]
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -52,7 +52,6 @@
|
||||
"@excalidraw/laser-pointer": "1.3.1",
|
||||
"browser-fs-access": "0.38.0",
|
||||
"pako": "2.0.3",
|
||||
"perfect-freehand": "1.2.0",
|
||||
"png-chunk-text": "1.0.0",
|
||||
"png-chunks-encode": "1.0.0",
|
||||
"png-chunks-extract": "1.0.0",
|
||||
|
||||
@@ -24,6 +24,7 @@ exports[`exportToSvg > with default arguments 1`] = `
|
||||
"currentItemFillStyle": "solid",
|
||||
"currentItemFontFamily": 5,
|
||||
"currentItemFontSize": 20,
|
||||
"currentItemFreedrawConstantPressure": true,
|
||||
"currentItemOpacity": 100,
|
||||
"currentItemRoughness": 1,
|
||||
"currentItemRoundness": "sharp",
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user