FIX #341 - when window state change, open_valve_percent should be resend

.devcontainer/configuration.yaml

@@ -168,6 +168,7 @@ climate:
       target_sensor: input_number.fake_temperature_sensor1
 
 recorder:
+    commit_interval: 1
     include:
         domains:
             - input_boolean

custom_components/versatile_thermostat/underlyings.py

@@ -758,21 +758,25 @@ class UnderlyingValve(UnderlyingEntity):
     async def turn_off(self):
         """Turn heater toggleable device off."""
         _LOGGER.debug("%s - Stopping underlying valve entity %s", self, self._entity_id)
-        self._percent_open = 0
+        # Issue 341
-        if self.is_device_active:
+        is_active = self.is_device_active
+        self._percent_open = self.cap_sent_value(0)
+        if is_active:
             await self.send_percent_open()
 
     async def turn_on(self):
         """Nothing to do for Valve because it cannot be turned off"""
+        self.set_valve_open_percent()
 
     async def set_hvac_mode(self, hvac_mode: HVACMode) -> bool:
         """Set the HVACmode. Returns true if something have change"""
 
-        if hvac_mode == HVACMode.OFF:
-            await self.turn_off()
-
         if self._hvac_mode != hvac_mode:
             self._hvac_mode = hvac_mode
+            if hvac_mode == HVACMode.OFF:
+                await self.turn_off()
+            else:
+                await self.turn_on()
             return True
         else:
             return False

tests/test_valve.py

@@ -321,9 +321,6 @@ async def test_over_valve_full_start(
             await try_condition(None)
 
             assert entity.hvac_mode is HVACMode.HEAT
-            assert (
+            assert entity.hvac_action is HVACAction.HEATING
-                entity.hvac_action is HVACAction.OFF
-                or entity.hvac_action is HVACAction.IDLE
-            )
             assert entity.target_temperature == 17.1  # eco
             assert entity.valve_open_percent == 10