Commit Graph

157 Commits

Author SHA1 Message Date
ProtoTess 149fe3a0a3 Fix nlreturn errors by adding blank lines before returns in multi-line closures 2026-01-16 06:17:16 +00:00
ProtoTess 5371705524 Fix nlreturn linting errors by adding nolint directives for inline closures and format with gofmt 2026-01-16 06:15:23 +00:00
ProtoTess 3e6dd827f7 Format cmd/onvif-diagnostics/main.go with gofmt 2026-01-16 06:13:19 +00:00
ProtoTess 08117299c1 Fix remaining nlreturn and wrapcheck linting errors 2026-01-16 06:12:27 +00:00
ProtoTess a0c79e83ee Format cmd/onvif-diagnostics/main.go with gofmt 2026-01-16 06:08:49 +00:00
ProtoTess 603b90422f Fix linting errors: exitAfterDefer, hugeParam, rangeValCopy, magic numbers, nlreturn, nolintlint 2026-01-16 06:06:37 +00:00
ProtoTess 268330840c Refactor code for improved readability and maintainability; add utility functions for score calculation and archive processing 2026-01-16 05:55:37 +00:00
ProtoTess c701115620 cleanup 2026-01-16 05:22:16 +00:00
ProtoTess 9cf30e2c41 cleanup 2026-01-16 04:58:24 +00:00
ProtoTess 19db372cdc Add ONVIF types and structures for device capabilities and configurations
- Introduced comprehensive data structures for ONVIF device information, capabilities, media profiles, and configurations.
- Added types for device services, network settings, imaging options, audio/video configurations, and user management.
- Implemented structures for handling various ONVIF features including PTZ control, event subscriptions, and analytics configurations.
- Enhanced support for network protocols, security settings, and system logging.
2026-01-16 04:37:59 +00:00
ProtoTess 66f6a4e838 Add or update .codecov copy.yml 2026-01-16 04:11:59 +00:00
ProtoTess ef340c0e5a Merge pull request #48 from 0x524a/46-feature-add-more-event-operations
46 feature add more event operations
2026-01-08 14:36:07 -05:00
0x524a 5ebd49cea8 docs: update comprehensive test summary and implementation status
- Added a note on the camera model used for testing in the Comprehensive Test Summary.
- Included the total operations count in the Implementation Complete document.
- Updated the Implementation Status to reflect the camera model used for ONVIF operations.
- Added last updated timestamps in the Media Operations Analysis and Media WSDL Operations Analysis documents.
2025-12-03 21:32:32 -05:00
0x524a 6603084ccd refactor: streamline media operations and enhance PTZ XML serialization
- Refactored media operations to consistently use the `getMediaEndpoint` method for endpoint retrieval, improving code clarity and reducing redundancy.
- Simplified the `ContinuousMove`, `AbsoluteMove`, and `RelativeMove` methods by introducing shared XML serialization types for PTZ commands, enhancing maintainability.
- Updated the `generateUUID` function to improve UUID generation efficiency by reducing redundant calls to `time.Now()`.
- Replaced manual struct definitions with dedicated XML types for better readability and organization in PTZ operations.
2025-12-03 10:37:35 -05:00
0x524a 21646af4ca feat: add benchmarks and improve XML request handling for device security operations
- Introduced benchmarks for various device security operations including GetRemoteUser, SetRemoteUser, and IP address filter management.
- Enhanced XML request handling by defining common structures for IP address filters to improve code efficiency and readability.
- Updated existing methods to utilize the new SOAP client creation method for better credential management.
- Pre-allocated slices in XML request structures to optimize performance during serialization.
2025-12-03 10:20:34 -05:00
ProtoTess 064a9f7a92 Merge pull request #47 from 0x524a/46-feature-add-more-event-operations
feat: implement Event and Device IO services with CLI integration
2025-12-03 01:06:33 -05:00
0x524a df3cdfb5ab feat: add missing Device IO operations and fix formatting
- Add GetVideoOutputConfiguration operation
- Add GetVideoOutputConfigurationOptions operation
- Add SetVideoOutputConfiguration operation
- Add GetRelayOutputOptions operation
- Add comprehensive tests for new operations
- Add CLI support for new Device IO operations
- Fix gofmt formatting issues in all files
2025-12-03 01:03:11 -05:00
0x524a 89851baa1f feat: implement Event and Device IO services with CLI integration
- Added Event and Device IO service implementations in `event.go` and `deviceio.go`.
- Created corresponding test files `event_test.go` and `deviceio_test.go` for unit testing.
- Enhanced CLI with new options for Event and Device IO operations, allowing users to interact with these services.
- Introduced example usage in `examples/test-event-deviceio/main.go` to demonstrate functionality.
- Updated golangci-lint configuration to include new files for linting checks.
2025-12-03 00:55:22 -05:00
ProtoTess 971f056b3d Merge pull request #45 from 0x524a/44-feature-add-media-wsdl-operations
44 feature add media wsdl operations
2025-12-03 00:18:08 -05:00
0x524a bfad9e910c chore: enhance golangci-lint configuration and clean up error handling
- Added new linters for the examples directory to improve code quality checks.
- Updated output formatting to direct lint results to stdout for better visibility.
- Cleaned up comments related to error handling in various files for clarity and consistency.
2025-12-03 00:14:24 -05:00
0x524a c939fb6563 chore: refine golangci-lint configuration by removing unused linters
- Removed the gosimple and stylecheck linters from the golangci-lint configuration to streamline the linter setup and focus on more relevant checks.
2025-12-02 23:40:51 -05:00
0x524a e0d62af87a chore: simplify golangci-lint configuration by removing gofmt
- Removed the gofmt linter from the golangci-lint configuration to streamline the linter setup and focus on more relevant checks.
2025-12-02 23:39:11 -05:00
0x524a 216040d7f7 chore: refine golangci-lint configuration for better clarity and focus
- Removed goimports and gosec configurations to streamline the linter setup.
- Adjusted exclusion rules for specific linters in test files and ONVIF API files to minimize false positives.
- Cleaned up unnecessary comments and settings for improved readability.
2025-12-02 23:37:29 -05:00
0x524a c528c65761 chore: update golangci-lint configuration for improved clarity and functionality
- Set default linters to none and reorganized settings for better structure.
- Enhanced exclusion rules for specific linters in test files and ONVIF API files to reduce false positives.
- Updated output formatting options for clearer linting results.
2025-12-02 23:35:28 -05:00
0x524a db641b0864 chore: remove typecheck linter from golangci-lint configuration
- Eliminated the typecheck linter from the golangci-lint configuration to streamline linting processes and focus on more relevant checks.
2025-12-02 23:33:20 -05:00
0x524a aa3465a726 chore: update golangci-lint configuration and CI workflow version
- Upgraded golangci-lint version from v1.64.8 to v2.1.6 for enhanced linting capabilities.
- Updated configuration to remove the lll linter and adjusted related settings for improved code quality checks.
- Streamlined issue exclusions to better align with current project needs.
2025-12-02 23:31:57 -05:00
0x524a 95626ffafc chore: expand SonarCloud issue exclusions and update golangci-lint version
- Added new exclusions for hardcoded IP addresses in additional Go files to enhance security analysis.
- Updated the golangci-lint action version to v1.64.8 for improved linting consistency and performance.
2025-12-02 23:28:57 -05:00
0x524a 46948acb88 chore: expand SonarCloud issue exclusions for improved security analysis
- Added new exclusions for hardcoded IP addresses in specific test files to enhance security analysis.
- Updated the issue ignore criteria to include additional rules for better management of security hotspots.
2025-12-02 23:24:46 -05:00
0x524a d13fdb0e0a chore: update Go version in CI workflows for consistency and improved compatibility
- Changed Go version from '1.24' to '1.24.x' across all CI workflows to ensure compatibility with patch releases.
- Modified arguments for the golangci-lint action to streamline configuration.
- Updated gosec and govulncheck commands to improve error handling and reporting.
2025-12-02 23:14:10 -05:00
0x524a 477a6c2927 chore: update CI workflows and SonarCloud configuration for enhanced security and coverage reporting
- Updated SonarCloud exclusions to include CLI tools and examples for better security hotspot analysis.
- Added new issue exclusions for hardcoded IP addresses and credentials in test files and CLI tools.
- Upgraded various GitHub Actions to their latest versions for improved performance and security.
- Streamlined CI workflows by ensuring consistent usage of action versions across all jobs.
2025-12-02 23:08:47 -05:00
0x524a 2c0250d29a chore: update golangci-lint configuration and improve CI workflow documentation
- Increased thresholds for funlen and lll linters to accommodate complex functions.
- Added exclusions for dupl linter in specific files and directories to reduce false positives.
- Updated CI workflow documentation to clarify triggers and requirements for SonarCloud analysis.
- Removed unnecessary linter directives in several files for improved readability.
2025-12-02 22:57:34 -05:00
0x524a 306c69ba89 chore: update CI workflows and SonarCloud configuration for improved analysis and coverage reporting
- Unified CI workflow with fail-fast behavior, streamlining stages for formatting, linting, testing, and SonarCloud analysis.
- Enhanced SonarCloud configuration to exclude test files and improve security hotspot analysis.
- Removed outdated coverage and lint workflows, consolidating functionality into the main CI pipeline.
- Updated README to reflect changes in CI structure and added details on workflow stages and requirements.
2025-12-02 22:39:42 -05:00
0x524a 02f79ea7a7 refactor: enhance code clarity and maintainability across multiple files
- Updated comments to improve clarity and adhere to best practices in ascii.go, main.go, and diagnostics.
- Removed unnecessary linter directives for improved readability in imaging.go and ptz.go.
- Reformatted function signatures and added helper calls in tests for consistency and clarity.
- Enhanced error handling and logging consistency in various server files, ensuring better maintainability.
2025-12-02 22:21:20 -05:00
0x524a c1daba5be6 refactor: introduce constants for improved maintainability in tests and server configurations
- Added constants for test endpoints, usernames, and XML headers in client_test.go and device_certificates_test.go to enhance readability and reduce hardcoded values.
- Updated various test cases to utilize these constants, ensuring consistency across tests.
- Refactored imaging settings and server configurations to use defined constants for default values, improving clarity and maintainability in server/device.go and server/imaging.go.
- Enhanced comments throughout the code to clarify functionality and adhere to best practices.
2025-12-02 21:39:54 -05:00
0x524a 31df3f8b79 refactor: improve code readability and maintainability across multiple files
- Reformatted function signatures for better clarity in media.go and onvif-quick/main.go.
- Replaced hardcoded values with constants in ascii.go and server/imaging.go for improved maintainability.
- Enhanced error handling and logging consistency in onvif-diagnostics/main.go and server/server.go.
- Updated comments to clarify functionality and ensure adherence to ONVIF specifications across various files.
2025-12-02 08:54:23 -05:00
0x524a de752f249e refactor: standardize constants and improve brightness calculations
- Replaced hardcoded values with constants for default dimensions and timeout settings in various files.
- Updated brightness calculation logic to use defined constants for maximum color value and bit shifts.
- Enhanced the ASCII image generation function to utilize new constants for improved readability and maintainability.
2025-12-02 08:53:13 -05:00
0x524a 96ac509c24 refactor: update HTTP request handling and improve documentation
- Replaced http.NewRequest with http.NewRequestWithContext in client tests for better context management.
- Updated method names and comments for clarity, including renaming GetWsdlUrl to GetWsdlURL and StorageUri to StorageURI for consistency.
- Enhanced comments across various files to provide clearer descriptions of functionality and ONVIF specifications.
2025-12-02 08:41:37 -05:00
0x524a 9e3b5e0170 feat: add comprehensive ONVIF test reports and enhance documentation
- Introduced CAMERA_TEST_REPORT.md and COMPREHENSIVE_TEST_SUMMARY.md to document testing results for the Bosch FLEXIDOME indoor 5100i IR camera.
- Added detailed analysis of ONVIF Media Service operations and implementation status in MEDIA_OPERATIONS_ANALYSIS.md and MEDIA_WSDL_OPERATIONS_ANALYSIS.md.
- Updated implementation status documentation to reflect the completion of all 79 operations in the ONVIF Media Service.
- Enhanced existing comments and documentation across various files for better clarity and consistency.
2025-12-02 02:29:51 -05:00
0x524a e530575bc1 refactor: improve error handling and code clarity in client methods
- Enhanced error messages in the client methods to provide more context on failures.
- Updated test cases to correct terminology and ensure accurate error expectations.
- Refactored function signatures in media service methods for better readability and consistency.
2025-12-02 01:38:50 -05:00
0x524a 2ea36220f7 refactor: improve media service client methods and clean up test files
- Introduced helper methods `getMediaEndpoint` and `getMediaSoapClient` in the media client for better code reuse and clarity.
- Updated various media service methods to utilize the new helper methods, enhancing maintainability.
- Cleaned up test files by standardizing formatting and removing unnecessary blank lines for improved readability.
2025-12-02 01:22:06 -05:00
0x524a 202218e24e chore: enhance media service documentation and CI workflows
- Added documentation for GetAudioOutputConfiguration method, including a note on code duplication.
- Updated coverage workflow to include an ID for coverage checks and output the coverage percentage.
- Modified release workflow to allow manual triggering and improved version handling based on event type.
2025-12-02 01:14:37 -05:00
0x524a 808498d1a0 chore: update linter configuration and enhance CI workflow
- Replaced 'exportloopref' with 'copyloopvar' in .golangci.yml for improved linting accuracy.
- Updated 'goerr113' to 'err113' for consistency in linter naming.
- Added Go setup step in the GitHub Actions workflow to specify Go version 1.23.
- Enhanced the gosec report upload process and added a step to display scan results in the CI workflow.
- Improved error handling in the unmarshalBody function to provide clearer error messages.
2025-12-02 01:06:28 -05:00
0x524a 3498b7d3a8 chore: refine .golangci.yml configuration
- Removed unnecessary skip-dirs and skip-files settings to streamline linter checks.
- Updated linters by replacing 'gomnd' with 'mnd' for better naming consistency.
- Removed the govet section to simplify configuration.
- Adjusted output formats for clearer reporting of linter results.
2025-12-02 01:01:36 -05:00
0x524a 00e2e0d46f chore: update CI/CD workflows and configuration
- Enhanced .golangci.yml with additional linters and settings for improved code quality checks.
- Updated CI workflow to include multiple branches for pull requests and improved caching strategies.
- Added new workflows for documentation checks, dependency reviews, and security scans.
- Refined coverage analysis workflow to provide detailed reports and comments on pull requests.
- Removed outdated test workflow and consolidated testing strategies into extended tests.
- Improved release workflow with better version handling and artifact management.
2025-12-02 00:53:20 -05:00
0x524a 0551d28f61 feat: add comprehensive tests for Bosch FLEXIDOME indoor 5100i IR camera
- Introduced new test files for device and media service operations using real camera responses.
- Implemented tests for GetDeviceInformation, GetMediaServiceCapabilities, and user management functions.
- Enhanced documentation with a detailed testing flow and coverage reports.
- Added JSON test reports for tracking operation success and response times.
- Updated the README and other documentation to reflect new testing capabilities and structure.
2025-12-02 00:43:17 -05:00
0x524a 08d55b4cb9 test: add concurrency test for digestAuthTransport to ensure thread safety
- Introduced a new test, TestDigestAuthTransportConcurrency, to validate concurrent access to the digestAuthTransport.
- Implemented checks to ensure the nonce count (nc) is correctly incremented and protected from race conditions using a mutex.
- Enhanced the digestAuthTransport struct to include a mutex for safe concurrent operations.
2025-12-01 23:35:15 -05:00
0x524a 1f68023dbe feat: enhance media service capabilities and add comprehensive tests
- Implemented methods to retrieve media service capabilities and video encoder configuration options.
- Added new types for media service capabilities, video encoder options, and audio configurations.
- Introduced unit tests for media service operations, including GetProfiles, GetProfile, and GetStreamURI, ensuring proper functionality and response validation.
- Improved error handling and response parsing in media-related methods.
2025-12-01 23:26:46 -05:00
ProtoTess d7f7fe966e Merge pull request #43 from 0x524a/fix/ci-workflow-permissions
ci: add explicit permissions for workflow jobs
2025-11-30 22:28:04 -05:00
ProtoTess b0ff5e5380 test: add minimal workflow to test GitHub Actions execution 2025-12-01 03:24:39 +00:00
ProtoTess a85a109c17 ci: add status check job to debug workflow execution 2025-12-01 03:24:24 +00:00