fix(webrtc): handle client connection errors gracefully (#2173)

- add deferred function to close the client connection on error
- ensure proper cleanup for all client functions

internal/webrtc/client.go

@@ -190,6 +190,12 @@ func whepClient(url string) (core.Producer, error) {
 		return nil, err
 	}
 
+	defer func() {
+		if err != nil {
+			_ = pc.Close()
+		}
+	}()
+
 	prod := webrtc.NewConn(pc)
 	prod.Mode = core.ModeActiveProducer
 	prod.Protocol = "http"

internal/webrtc/client_creality.go

@@ -20,6 +20,12 @@ func crealityClient(url string) (core.Producer, error) {
 		return nil, err
 	}
 
+	defer func() {
+		if err != nil {
+			_ = pc.Close()
+		}
+	}()
+
 	prod := webrtc.NewConn(pc)
 	prod.FormatName = "webrtc/creality"
 	prod.Mode = core.ModeActiveProducer

internal/webrtc/kinesis.go

@@ -68,6 +68,12 @@ func kinesisClient(
 		return nil, err
 	}
 
+	defer func() {
+		if err != nil {
+			_ = pc.Close()
+		}
+	}()
+
 	// protect from sending ICE candidate before Offer
 	var sendOffer core.Waiter
 

internal/webrtc/milestone.go

@@ -192,6 +192,12 @@ func milestoneClient(rawURL string, query url.Values) (core.Producer, error) {
 		return nil, err
 	}
 
+	defer func() {
+		if err != nil {
+			_ = pc.Close()
+		}
+	}()
+
 	prod := webrtc.NewConn(pc)
 	prod.FormatName = "webrtc/milestone"
 	prod.Mode = core.ModeActiveProducer

internal/webrtc/openipc.go

@@ -43,6 +43,12 @@ func openIPCClient(rawURL string, query url.Values) (core.Producer, error) {
 		return nil, err
 	}
 
+	defer func() {
+		if err != nil {
+			_ = pc.Close()
+		}
+	}()
+
 	// protect from sending ICE candidate before Offer
 	var sendAnswer core.Waiter