split strokeWidth constants into own file

packages/common/src/constants.strokeWidth.ts

@@ -0,0 +1,63 @@
+import type { ExcalidrawElement } from "@excalidraw/element/types";
+
+export type StrokeWidthKey = "thin" | "medium" | "bold";
+
+export const STROKE_WIDTH_KEYS: readonly StrokeWidthKey[] = [
+  "thin",
+  "medium",
+  "bold",
+];
+
+export const STROKE_WIDTH: Readonly<
+  Record<StrokeWidthKey | "extraBold", ExcalidrawElement["strokeWidth"]>
+> = {
+  thin: 1,
+  medium: 2,
+  bold: 4,
+  extraBold: 8, // unused (may be introduced in the future)
+};
+
+// freedraw schema 2.0 uses thinner stroke, but to maintain backwards and
+// forwards compatibility, instead of changing the shape renderer, we scale
+// the stroke width by 1/2 (previous, thin was 1, medium 2 etc.)
+//
+// note that in the UI, STROKE_WIDTH.thin == FREEDRAW_STROKE_WIDTH.thin still
+export const FREEDRAW_STROKE_WIDTH: Readonly<
+  Record<StrokeWidthKey | "extraBold", ExcalidrawElement["strokeWidth"]>
+> = {
+  thin: 0.5,
+  medium: 1,
+  bold: 2,
+  extraBold: 4, // legacy (may be used again in the future)
+};
+
+const STROKE_WIDTH_TO_KEY = {
+  generic: Object.fromEntries(
+    Object.entries(STROKE_WIDTH).map(([key, value]) => [value, key]),
+  ) as Record<ExcalidrawElement["strokeWidth"], StrokeWidthKey | undefined>,
+  freedraw: Object.fromEntries(
+    Object.entries(FREEDRAW_STROKE_WIDTH).map(([key, value]) => [value, key]),
+  ) as Record<ExcalidrawElement["strokeWidth"], StrokeWidthKey | undefined>,
+};
+
+export const getStrokeWidthKeyForElement = (
+  element: Pick<ExcalidrawElement, "type" | "strokeWidth">,
+): StrokeWidthKey | null => {
+  const strokeWidthToKey =
+    element.type === "freedraw"
+      ? STROKE_WIDTH_TO_KEY.freedraw
+      : STROKE_WIDTH_TO_KEY.generic;
+
+  return strokeWidthToKey[element.strokeWidth] ?? null;
+};
+
+export const getStrokeWidthByKey = (
+  elementType: ExcalidrawElement["type"],
+  strokeWidthKey: StrokeWidthKey,
+): ExcalidrawElement["strokeWidth"] => {
+  return elementType === "freedraw"
+    ? FREEDRAW_STROKE_WIDTH[strokeWidthKey]
+    : STROKE_WIDTH[strokeWidthKey];
+};
+
+export const DEFAULT_ELEMENT_STROKE_WIDTH_KEY: StrokeWidthKey = "medium";

packages/common/src/constants.ts

@@ -5,6 +5,10 @@ import type {
 import type { AppProps, AppState } from "@excalidraw/excalidraw/types";
 
 import { COLOR_PALETTE } from "./colors";
+import {
+  STROKE_WIDTH,
+  DEFAULT_ELEMENT_STROKE_WIDTH_KEY,
+} from "./constants.strokeWidth";
 
 export const supportsResizeObserver =
   typeof window !== "undefined" && "ResizeObserver" in window;
@@ -404,48 +408,6 @@ export const ROUGHNESS = {
   cartoonist: 2,
 } as const;
 
-export type StrokeWidthKey = "thin" | "medium" | "bold";
-
-export const STROKE_WIDTH_KEYS: readonly StrokeWidthKey[] = [
-  "thin",
-  "medium",
-  "bold",
-];
-
-export const STROKE_WIDTH: Readonly<
-  Record<StrokeWidthKey | "extraBold", ExcalidrawElement["strokeWidth"]>
-> = {
-  thin: 1,
-  medium: 2,
-  bold: 4,
-  extraBold: 8, // unused (may be introduced in the future)
-};
-
-// freedraw schema 2.0 uses thinner stroke, but to maintain backwards and
-// forwards compatibility, instead of changing the shape renderer, we scale
-// the stroke width by 1/2 (previous, thin was 1, medium 2 etc.)
-//
-// note that in the UI, STROKE_WIDTH.thin == FREEDRAW_STROKE_WIDTH.thin still
-export const FREEDRAW_STROKE_WIDTH: Readonly<
-  Record<StrokeWidthKey | "extraBold", ExcalidrawElement["strokeWidth"]>
-> = {
-  thin: 0.5,
-  medium: 1,
-  bold: 2,
-  extraBold: 4, // legacy (may be used again in the future)
-};
-
-export const getStrokeWidthByKey = (
-  elementType: ExcalidrawElement["type"],
-  strokeWidthKey: StrokeWidthKey,
-): ExcalidrawElement["strokeWidth"] => {
-  return elementType === "freedraw"
-    ? FREEDRAW_STROKE_WIDTH[strokeWidthKey]
-    : STROKE_WIDTH[strokeWidthKey];
-};
-
-export const DEFAULT_ELEMENT_STROKE_WIDTH_KEY: StrokeWidthKey = "medium";
-
 export const DEFAULT_ELEMENT_PROPS: {
   strokeColor: ExcalidrawElement["strokeColor"];
   backgroundColor: ExcalidrawElement["backgroundColor"];
@@ -552,4 +514,4 @@ export const MOBILE_ACTION_BUTTON_BG = {
 } as const;
 
 export const DEFAULT_STROKE_STREAMLINE = 0.5;
-export const DEFAULT_STROKE_STREAMLINE_PRECISE = 0.2;
+export const DEFAULT_STROKE_STREAMLINE_PRECISE = 0.3;

packages/common/src/index.ts

@@ -2,6 +2,7 @@ export * from "./binary-heap";
 export * from "./bounds";
 export * from "./colors";
 export * from "./constants";
+export * from "./constants.strokeWidth";
 export * from "./font-metadata";
 export * from "./queue";
 export * from "./keys";

packages/common/src/utils.ts

@@ -204,6 +204,135 @@ export const easeOut = (k: number) => {
   return 1 - Math.pow(1 - k, 4);
 };
 
+const easeOutInterpolate = (from: number, to: number, progress: number) => {
+  return (to - from) * easeOut(progress) + from;
+};
+
+/**
+ * Animates values from `fromValues` to `toValues` using the requestAnimationFrame API.
+ * Executes the `onStep` callback on each step with the interpolated values.
+ * Returns a function that can be called to cancel the animation.
+ *
+ * @example
+ * // Example usage:
+ * const fromValues = { x: 0, y: 0 };
+ * const toValues = { x: 100, y: 200 };
+ * const onStep = ({x, y}) => {
+ *   setState(x, y)
+ * };
+ * const onCancel = () => {
+ *   console.log("Animation canceled");
+ * };
+ *
+ * const cancelAnimation = easeToValuesRAF({
+ *   fromValues,
+ *   toValues,
+ *   onStep,
+ *   onCancel,
+ * });
+ *
+ * // To cancel the animation:
+ * cancelAnimation();
+ */
+export const easeToValuesRAF = <
+  T extends Record<keyof T, number>,
+  K extends keyof T,
+>({
+  fromValues,
+  toValues,
+  onStep,
+  duration = 250,
+  interpolateValue,
+  onStart,
+  onEnd,
+  onCancel,
+}: {
+  fromValues: T;
+  toValues: T;
+  /**
+   * Interpolate a single value.
+   * Return undefined to be handled by the default interpolator.
+   */
+  interpolateValue?: (
+    fromValue: number,
+    toValue: number,
+    /** no easing applied  */
+    progress: number,
+    key: K,
+  ) => number | undefined;
+  onStep: (values: T) => void;
+  duration?: number;
+  onStart?: () => void;
+  onEnd?: () => void;
+  onCancel?: () => void;
+}) => {
+  let canceled = false;
+  let frameId = 0;
+  let startTime: number;
+
+  function step(timestamp: number) {
+    if (canceled) {
+      return;
+    }
+    if (startTime === undefined) {
+      startTime = timestamp;
+      onStart?.();
+    }
+
+    const elapsed = Math.min(timestamp - startTime, duration);
+    const factor = easeOut(elapsed / duration);
+
+    const newValues = {} as T;
+
+    Object.keys(fromValues).forEach((key) => {
+      const _key = key as keyof T;
+      const result = ((toValues[_key] - fromValues[_key]) * factor +
+        fromValues[_key]) as T[keyof T];
+      newValues[_key] = result;
+    });
+
+    onStep(newValues);
+
+    if (elapsed < duration) {
+      const progress = elapsed / duration;
+
+      const newValues = {} as T;
+
+      Object.keys(fromValues).forEach((key) => {
+        const _key = key as K;
+        const startValue = fromValues[_key];
+        const endValue = toValues[_key];
+
+        let result;
+
+        result = interpolateValue
+          ? interpolateValue(startValue, endValue, progress, _key)
+          : easeOutInterpolate(startValue, endValue, progress);
+
+        if (result == null) {
+          result = easeOutInterpolate(startValue, endValue, progress);
+        }
+
+        newValues[_key] = result as T[K];
+      });
+      onStep(newValues);
+
+      frameId = window.requestAnimationFrame(step);
+    } else {
+      onStep(toValues);
+      onEnd?.();
+    }
+  }
+
+  frameId = window.requestAnimationFrame(step);
+
+  return () => {
+    onCancel?.();
+    canceled = true;
+    window.cancelAnimationFrame(frameId);
+  };
+};
+
 // https://github.com/lodash/lodash/blob/es/chunk.js
 export const chunk = <T extends any>(
   array: readonly T[],

packages/common/tsconfig.json

@@ -1,8 +1,7 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "./dist/types",
-    "rootDir": "../"
+    "outDir": "./dist/types"
   },
   "include": ["src/**/*", "global.d.ts"],
   "exclude": ["**/*.test.*", "tests", "types", "examples", "dist"]

packages/element/src/shape.ts

@@ -26,6 +26,7 @@ import {
   LINE_POLYGON_POINT_MERGE_DISTANCE,
   applyDarkModeFilter,
   DEFAULT_STROKE_STREAMLINE,
+  DEFAULT_STROKE_STREAMLINE_PRECISE,
 } from "@excalidraw/common";
 
 import { RoughGenerator } from "roughjs/bin/generator";
@@ -1185,15 +1186,20 @@ const VARIABLE_WIDTH_FREEDRAW = {
   SIZE_FACTOR: 4.25,
   THINNING: 0.6,
   SMOOTHING: 0.5,
+  STREAMLINE: DEFAULT_STROKE_STREAMLINE,
 } as const;
 
 const CONSTANT_WIDTH_FREEDRAW = {
   /** Stroke size relative to `strokeWidth` for uniform (laser) strokes. */
   SIZE_FACTOR: 1.4,
+  STREAMLINE: DEFAULT_STROKE_STREAMLINE_PRECISE,
 } as const;
 
 const getFreedrawStreamline = (element: ExcalidrawFreeDrawElement) =>
-  element.strokeOptions?.streamline ?? DEFAULT_STROKE_STREAMLINE;
+  element.strokeOptions?.streamline ??
+  (element.strokeOptions?.variability === "constant"
+    ? CONSTANT_WIDTH_FREEDRAW.STREAMLINE
+    : VARIABLE_WIDTH_FREEDRAW.STREAMLINE);
 
 /**
  * Pressure-sensitive (variable width) freedraw outline, rendered with

packages/element/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "rootDir": "../",
     "outDir": "./dist/types"
   },
   "include": ["src/**/*", "global.d.ts"],

packages/excalidraw/actions/actionCanvas.tsx

@@ -112,6 +112,9 @@ export const actionClearCanvas = register({
         theme: appState.theme,
         penMode: appState.penMode,
         penDetected: appState.penDetected,
+        currentItemStrokeVariability: appState.penDetected
+          ? "variable"
+          : "constant",
         exportBackground: appState.exportBackground,
         exportEmbedScene: appState.exportEmbedScene,
         gridSize: appState.gridSize,

packages/excalidraw/actions/actionProperties.tsx

@@ -12,7 +12,6 @@ import {
   DEFAULT_FONT_SIZE,
   FONT_FAMILY,
   ROUNDNESS,
-  STROKE_WIDTH_KEYS,
   VERTICAL_ALIGN,
   KEYS,
   randomInteger,
@@ -25,6 +24,7 @@ import {
   invariant,
   FONT_SIZES,
   type StrokeWidthKey,
+  getStrokeWidthKeyForElement,
 } from "@excalidraw/common";
 
 import { canBecomePolygon, getNonDeletedElements } from "@excalidraw/element";
@@ -87,7 +87,6 @@ import type { CaptureUpdateActionType } from "@excalidraw/element";
 
 import { trackEvent } from "../analytics";
 import { RadioSelection } from "../components/RadioSelection";
-import { ToolButton } from "../components/ToolButton";
 import { ColorPicker } from "../components/ColorPicker/ColorPicker";
 import { FontPicker } from "../components/FontPicker/FontPicker";
 import { IconPicker } from "../components/IconPicker";
@@ -555,23 +554,6 @@ export const actionChangeFillStyle = register<ExcalidrawElement["fillStyle"]>({
   },
 });
 
-const getStrokeWidthKeyForElement = (
-  element: ExcalidrawElement,
-): StrokeWidthKey | null => {
-  return (
-    STROKE_WIDTH_KEYS.find(
-      (key) => getStrokeWidthByKey(element.type, key) === element.strokeWidth,
-    ) ?? null
-  );
-};
-
-const getStrokeWidthForElement = (
-  element: ExcalidrawElement,
-  strokeWidthKey: StrokeWidthKey,
-): ExcalidrawElement["strokeWidth"] => {
-  return getStrokeWidthByKey(element.type, strokeWidthKey);
-};
-
 export const actionChangeStrokeWidth = register<StrokeWidthKey>({
   name: "changeStrokeWidth",
   label: "labels.strokeWidth",
@@ -582,7 +564,7 @@ export const actionChangeStrokeWidth = register<StrokeWidthKey>({
     return {
       elements: changeProperty(elements, appState, (el) =>
         newElementWith(el, {
-          strokeWidth: getStrokeWidthForElement(el, value),
+          strokeWidth: getStrokeWidthByKey(el.type, value),
         }),
       ),
       appState: { ...appState, currentItemStrokeWidthKey: value },
@@ -719,25 +701,6 @@ export const actionChangeFreedrawMode = register<StrokeVariability>({
           hasSelection ? null : appState.currentItemStrokeVariability,
       ) ?? appState.currentItemStrokeVariability;
 
-    // in the compact UI the pressure setting is rendered as a single button
-    // that cycles between the two variability modes on click
-    if (data?.cycle) {
-      const isVariable = strokeVariability === "variable";
-      return (
-        <ToolButton
-          type="button"
-          icon={
-            isVariable
-              ? strokeVariabilityVariableIcon
-              : strokeVariabilityConstantIcon
-          }
-          title={t("labels.pressure")}
-          aria-label={t("labels.pressure")}
-          onClick={() => updateData(isVariable ? "constant" : "variable")}
-        />
-      );
-    }
-
     return (
       <fieldset>
         <legend>{t("labels.pressure")}</legend>

packages/excalidraw/components/Actions.tsx

@@ -395,17 +395,11 @@ const CombinedShapeProperties = ({
                   hasStrokeWidth(element.type),
                 )) &&
                 renderAction("changeStrokeWidth")}
-              {
-                /* in compact UI the freedraw pressure setting is rendered as a
-                  standalone cycle button in the compact actions list; we render
-                  it in the combined properties popup as well for clarity
-                */
-                (hasFreedrawMode(appState.activeTool.type) ||
-                  targetElements.some((element) =>
-                    hasFreedrawMode(element.type),
-                  )) &&
-                  renderAction("changeFreedrawMode")
-              }
+              {(hasFreedrawMode(appState.activeTool.type) ||
+                targetElements.some((element) =>
+                  hasFreedrawMode(element.type),
+                )) &&
+                renderAction("changeFreedrawMode")}
               {(hasStrokeStyle(appState.activeTool.type) ||
                 targetElements.some((element) =>
                   hasStrokeStyle(element.type),
@@ -838,14 +832,6 @@ export const CompactShapeActions = ({
         </div>
       )}
 
-      {/* Freedraw pressure: standalone button cycling the variability mode */}
-      {(hasFreedrawMode(appState.activeTool.type) ||
-        targetElements.some((element) => hasFreedrawMode(element.type))) && (
-        <div className="compact-action-item">
-          {renderAction("changeFreedrawMode", { cycle: true })}
-        </div>
-      )}
-
       <CombinedShapeProperties
         appState={appState}
         renderAction={renderAction}
@@ -1074,11 +1060,6 @@ export const ShapesSwitcher = ({
   const isFullStylesPanel = stylesPanelMode === "full";
   const isCompactStylesPanel = stylesPanelMode === "compact";
 
-  // a pen detected on a tool button's pointer-down, to be applied (enabling
-  // pen mode) only after the tap's `change` has committed — see the tool
-  // button handlers below
-  const pendingPenDetectionRef = useRef(false);
-
   const SELECTION_TOOLS = [
     {
       type: "selection",
@@ -1177,13 +1158,8 @@ export const ShapesSwitcher = ({
               aria-keyshortcuts={shortcut}
               data-testid={`toolbar-${value}`}
               onPointerDown={({ pointerType }) => {
-                // Detect the pen here (pointerType is reliable on pointer-down)
-                // but DON'T enable pen mode yet: calling setState mid-gesture
-                // re-renders the controlled radio and, on iOS/iPadOS, aborts
-                // the ensuing click so the tool isn't selected on the first pen
-                // tap. Defer it until the tap's `change` has committed (below).
                 if (!app.state.penDetected && pointerType === "pen") {
-                  pendingPenDetectionRef.current = true;
+                  app.togglePenMode(true);
                 }
 
                 if (value === "selection") {
@@ -1194,21 +1170,16 @@ export const ShapesSwitcher = ({
                   }
                 }
               }}
-              onChange={() => {
+              onChange={({ pointerType }) => {
                 if (app.state.activeTool.type !== value) {
                   trackEvent("toolbar", value, "ui");
                 }
-                app.setActiveTool({ type: value });
-
-                // Apply the pen detection captured on pointer-down now that the
-                // tool is selected. rAF keeps the resulting re-render out of the
-                // `change` event itself. We rely on the pointer-down detection
-                // rather than this handler's pointerType because the latter is
-                // unreliable on iOS (its backing ref is cleared before the
-                // delayed click fires).
-                if (pendingPenDetectionRef.current) {
-                  pendingPenDetectionRef.current = false;
-                  requestAnimationFrame(() => app.togglePenMode(true));
+                if (value === "image") {
+                  app.setActiveTool({
+                    type: value,
+                  });
+                } else {
+                  app.setActiveTool({ type: value });
                 }
               }}
             />

packages/excalidraw/components/App.tsx

@@ -77,9 +77,11 @@ import {
   updateObject,
   updateActiveTool,
   isTransparent,
+  easeToValuesRAF,
   muteFSAbortError,
   isTestEnv,
   isDevEnv,
+  easeOut,
   updateStable,
   addEventListener,
   normalizeEOL,
@@ -201,6 +203,7 @@ import {
   cropElement,
   wrapText,
   isElementLink,
+  parseElementLinkFromURL,
   isMeasureTextSupported,
   normalizeText,
   measureText,
@@ -261,7 +264,6 @@ import {
   getActiveTextElement,
   isEligibleFrameChildType,
   getBindingStrategyForDraggingBindingElementEndpoints,
-  parseElementLinkFromURL,
 } from "@excalidraw/element";
 
 import type { GlobalPoint, LocalPoint, Radians } from "@excalidraw/math";
@@ -329,7 +331,7 @@ import {
   actionToggleCropEditor,
 } from "../actions";
 import { actionWrapTextInContainer } from "../actions/actionBoundText";
-import { actionToggleHandTool } from "../actions/actionCanvas";
+import { actionToggleHandTool, zoomToFit } from "../actions/actionCanvas";
 import { actionPaste } from "../actions/actionClipboard";
 import { actionCopyElementLink } from "../actions/actionElementLink";
 import { actionUnlockAllElements } from "../actions/actionElementLock";
@@ -411,11 +413,6 @@ import {
   isGridModeEnabled,
 } from "../snapping";
 import { Renderer } from "../scene/Renderer";
-import {
-  type ScrollToContentOptions,
-  SCROLL_TO_CONTENT_ANIMATION_KEY,
-  scrollToElements,
-} from "../scroll";
 import {
   setEraserCursor,
   setCursor,
@@ -428,12 +425,16 @@ import { withBatchedUpdates, withBatchedUpdatesThrottled } from "../reactUtils";
 import { isPointHittingTextAutoResizeHandle } from "../textAutoResizeHandle";
 import { textWysiwyg } from "../wysiwyg/textWysiwyg";
 import { isOverScrollBars } from "../scene/scrollbars";
+
 import { isMaybeMermaidDefinition } from "../mermaid";
+
 import { LassoTrail } from "../lasso";
+
 import { EraserTrail } from "../eraser";
+
 import { getShortcutKey } from "../shortcut";
+
 import { tryParseSpreadsheet } from "../charts";
-import { AnimationController } from "../renderer/animation";
 
 import ConvertElementTypePopup, {
   getConversionTypeFromElements,
@@ -4307,9 +4308,7 @@ class App extends React.Component<AppProps, AppState> {
       return {
         penMode: force ?? !prevState.penMode,
         penDetected: true,
-        currentItemStrokeVariability: !prevState.penDetected
-          ? "variable"
-          : prevState.currentItemStrokeVariability,
+        currentItemStrokeVariability: "variable",
       };
     });
   };
@@ -4340,60 +4339,148 @@ class App extends React.Component<AppProps, AppState> {
     });
   };
 
+  private cancelInProgressAnimation: (() => void) | null = null;
+
   scrollToContent = (
-    target?:
+    /**
+     * target to scroll to
+     *
+     * - string - id of element or group, or url containing elementLink
+     * - ExcalidrawElement | ExcalidrawElement[] - element(s) objects
+     */
+    target:
       | string
       | ExcalidrawElement
-      | readonly NonDeletedExcalidrawElement[],
-    opts?: ScrollToContentOptions,
+      | readonly ExcalidrawElement[] = this.scene.getNonDeletedElements(),
+    opts?: (
+      | {
+          fitToContent?: boolean;
+          fitToViewport?: never;
+          viewportZoomFactor?: number;
+          animate?: boolean;
+          duration?: number;
+        }
+      | {
+          fitToContent?: never;
+          fitToViewport?: boolean;
+          /** when fitToViewport=true, how much screen should the content cover,
+           * between 0.1 (10%) and 1 (100%)
+           */
+          viewportZoomFactor?: number;
+          animate?: boolean;
+          duration?: number;
+        }
+    ) & {
+      minZoom?: number;
+      maxZoom?: number;
+      canvasOffsets?: Offsets;
+    },
   ) => {
-    let elements: readonly NonDeleted<ExcalidrawElement>[];
     if (typeof target === "string") {
-      const id = isElementLink(target)
-        ? parseElementLinkFromURL(target)
-        : target;
-      elements = id ? this.scene.getElementsFromId(id) : [];
-    } else if (Array.isArray(target)) {
-      elements = target;
-    } else if (target) {
-      elements = [target as NonDeleted<ExcalidrawElement>];
-    } else {
-      elements = this.scene.getNonDeletedElements();
-    }
-
-    if (!elements.length) {
-      if (typeof target === "string" && isElementLink(target)) {
-        this.setState({
-          toast: {
-            message: t("elementLink.notFound"),
-            duration: 3000,
-            closable: true,
-          },
-        });
+      let id: string | null;
+      if (isElementLink(target)) {
+        id = parseElementLinkFromURL(target);
+      } else {
+        id = target;
       }
+      if (id) {
+        const elements = this.scene.getElementsFromId(id);
 
+        if (elements?.length) {
+          this.scrollToContent(elements, {
+            fitToContent: opts?.fitToContent ?? true,
+            animate: opts?.animate ?? true,
+          });
+        } else if (isElementLink(target)) {
+          this.setState({
+            toast: {
+              message: t("elementLink.notFound"),
+              duration: 3000,
+              closable: true,
+            },
+          });
+        }
+      }
       return;
     }
 
-    // Navigating to an element by id or element-link defaults to zooming the
-    // element into view, animated — matching the historical element-link
-    // behavior — unless the caller opts out.
-    const resolvedOpts =
-      typeof target === "string"
-        ? {
-            ...opts,
-            fitToViewport: undefined,
-            fitToContent: opts?.fitToContent ?? true,
-            animate: opts?.animate ?? true,
-          }
-        : opts;
+    this.cancelInProgressAnimation?.();
 
-    scrollToElements(
-      this.state,
-      elements,
-      this.setState.bind(this),
-      resolvedOpts,
-    );
+    // convert provided target into ExcalidrawElement[] if necessary
+    const targetElements = Array.isArray(target) ? target : [target];
+
+    let zoom = this.state.zoom;
+    let scrollX = this.state.scrollX;
+    let scrollY = this.state.scrollY;
+
+    if (opts?.fitToContent || opts?.fitToViewport) {
+      const { appState } = zoomToFit({
+        canvasOffsets: opts.canvasOffsets,
+        targetElements,
+        appState: this.state,
+        fitToViewport: !!opts?.fitToViewport,
+        viewportZoomFactor: opts?.viewportZoomFactor,
+        minZoom: opts?.minZoom,
+        maxZoom: opts?.maxZoom,
+      });
+      zoom = appState.zoom;
+      scrollX = appState.scrollX;
+      scrollY = appState.scrollY;
+    } else {
+      // compute only the viewport location, without any zoom adjustment
+      const scroll = calculateScrollCenter(targetElements, this.state);
+      scrollX = scroll.scrollX;
+      scrollY = scroll.scrollY;
+    }
+
+    // when animating, we use RequestAnimationFrame to prevent the animation
+    // from slowing down other processes
+    if (opts?.animate) {
+      const origScrollX = this.state.scrollX;
+      const origScrollY = this.state.scrollY;
+      const origZoom = this.state.zoom.value;
+
+      const cancel = easeToValuesRAF({
+        fromValues: {
+          scrollX: origScrollX,
+          scrollY: origScrollY,
+          zoom: origZoom,
+        },
+        toValues: { scrollX, scrollY, zoom: zoom.value },
+        interpolateValue: (from, to, progress, key) => {
+          // for zoom, use different easing
+          if (key === "zoom") {
+            return from * Math.pow(to / from, easeOut(progress));
+          }
+          // handle using default
+          return undefined;
+        },
+        onStep: ({ scrollX, scrollY, zoom }) => {
+          this.setState({
+            scrollX,
+            scrollY,
+            zoom: { value: zoom },
+          });
+        },
+        onStart: () => {
+          this.setState({ shouldCacheIgnoreZoom: true });
+        },
+        onEnd: () => {
+          this.setState({ shouldCacheIgnoreZoom: false });
+        },
+        onCancel: () => {
+          this.setState({ shouldCacheIgnoreZoom: false });
+        },
+        duration: opts?.duration ?? 500,
+      });
+
+      this.cancelInProgressAnimation = () => {
+        cancel();
+        this.cancelInProgressAnimation = null;
+      };
+    } else {
+      this.setState({ scrollX, scrollY, zoom });
+    }
   };
 
   private maybeUnfollowRemoteUser = () => {
@@ -4406,8 +4493,7 @@ class App extends React.Component<AppProps, AppState> {
   private translateCanvas: React.Component<any, AppState>["setState"] = (
     state,
   ) => {
-    AnimationController.cancel(SCROLL_TO_CONTENT_ANIMATION_KEY);
-    this.setState({ shouldCacheIgnoreZoom: false });
+    this.cancelInProgressAnimation?.();
     this.maybeUnfollowRemoteUser();
     this.setState(state);
   };
@@ -8929,7 +9015,7 @@ class App extends React.Component<AppProps, AppState> {
       strokeOptions: {
         variability: strokeVariability,
         streamline:
-          event.pointerType !== "mouse"
+          strokeVariability === "constant" && event.pointerType !== "mouse"
             ? DEFAULT_STROKE_STREAMLINE_PRECISE
             : DEFAULT_STROKE_STREAMLINE,
       },

packages/excalidraw/components/LayerUI.scss

@@ -120,24 +120,6 @@
     }
   }
 
-  // on tablet, the pen mode button is rendered as a separate floating button
-  // below the compact actions menu (see LayerUI.tsx)
-  .App-menu_top__left > .ToolIcon__penMode {
-    justify-self: center;
-
-    .ToolIcon__icon {
-      width: var(--lg-button-size);
-      height: var(--lg-button-size);
-      background-color: var(--island-bg-color);
-      box-shadow: var(--shadow-island);
-    }
-
-    // no shadow while pen mode is active (the active fill is enough)
-    .ToolIcon_type_checkbox:checked + .ToolIcon__icon {
-      box-shadow: none;
-    }
-  }
-
   .disable-view-mode {
     display: flex;
     justify-content: center;

packages/excalidraw/components/LayerUI.tsx

@@ -235,6 +235,8 @@ const LayerUI = ({
   );
 
   const renderSelectedShapeActions = () => {
+    const isCompactMode = isCompactStylesPanel;
+
     return (
       <Section
         heading="selectedShapeActions"
@@ -242,7 +244,7 @@ const LayerUI = ({
           "transition-left": appState.zenModeEnabled,
         })}
       >
-        {isCompactStylesPanel ? (
+        {isCompactMode ? (
           <Island
             className={clsx("compact-shape-actions-island")}
             padding={0}
@@ -310,23 +312,6 @@ const LayerUI = ({
             >
               {shouldRenderSelectedShapeActions && renderSelectedShapeActions()}
             </div>
-            {/* in compact UI the pen mode button lives outside the toolbar, as
-                a separate floating button below the compact actions menu
-                (same as we render it on mobile); shown alongside the compact
-                actions island, i.e. when a drawing tool or elements are
-                selected */}
-            {isCompactStylesPanel &&
-              !appState.viewModeEnabled &&
-              shouldRenderSelectedShapeActions && (
-                <PenModeButton
-                  zenModeEnabled={appState.zenModeEnabled}
-                  checked={appState.penMode}
-                  onChange={() => onPenModeToggle(null)}
-                  title={t("toolBar.penMode")}
-                  isMobile
-                  penDetected={appState.penDetected}
-                />
-              )}
           </Stack.Col>
           {!appState.viewModeEnabled &&
             appState.openDialog?.name !== "elementLinkSelector" && (
@@ -358,18 +343,13 @@ const LayerUI = ({
                           />
                           {heading}
                           <Stack.Row gap={spacing.toolbarInnerRowGap}>
-                            {/* in compact UI the pen mode button is rendered
-                                as a separate floating button below the compact
-                                actions menu */}
-                            {!isCompactStylesPanel && (
-                              <PenModeButton
-                                zenModeEnabled={appState.zenModeEnabled}
-                                checked={appState.penMode}
-                                onChange={() => onPenModeToggle(null)}
-                                title={t("toolBar.penMode")}
-                                penDetected={appState.penDetected}
-                              />
-                            )}
+                            <PenModeButton
+                              zenModeEnabled={appState.zenModeEnabled}
+                              checked={appState.penMode}
+                              onChange={() => onPenModeToggle(null)}
+                              title={t("toolBar.penMode")}
+                              penDetected={appState.penDetected}
+                            />
                             <LockButton
                               checked={appState.activeTool.locked}
                               onChange={onLockToggle}

packages/excalidraw/data/restore.ts

@@ -19,9 +19,8 @@ import {
   getSizeFromPoints,
   normalizeLink,
   getLineHeight,
-  STROKE_WIDTH,
   STROKE_WIDTH_KEYS,
-  type StrokeWidthKey,
+  STROKE_WIDTH,
 } from "@excalidraw/common";
 import {
   calculateFixedPointForNonElbowArrowBinding,
@@ -58,6 +57,8 @@ import { getNormalizedDimensions } from "@excalidraw/element";
 
 import { isInvisiblySmallElement } from "@excalidraw/element";
 
+import type { StrokeWidthKey } from "@excalidraw/common";
+
 import type { LocalPoint, Radians } from "@excalidraw/math";
 
 import type {
@@ -101,38 +102,7 @@ type RestoredAppState = Omit<
   "offsetTop" | "offsetLeft" | "width" | "height"
 >;
 
-const MAX_LINEAR_PX = 75_000;
-
-// Last resort fix for extremely large linear elements (lines / arrows), which
-// would otherwise freeze the editor while rendering — e.g. a dotted or dashed
-// stroke spanning a huge distance generates an enormous dash array.
-// https://github.com/excalidraw/excalidraw/issues/11497
-const handleOversizedLinearElements = <T extends ExcalidrawLinearElement>(
-  element: T,
-): T => {
-  if (element.width <= MAX_LINEAR_PX && element.height <= MAX_LINEAR_PX) {
-    return element;
-  }
-
-  const label =
-    element.type === "arrow"
-      ? `${isElbowArrow(element) ? "elbow" : "simple"} arrow`
-      : element.type;
-
-  console.error(
-    `Removing extremely large ${label} ${element.id} (width: ${element.width}, height: ${element.height}, x: ${element.x}, y: ${element.y})`,
-  );
-
-  return {
-    ...element,
-    x: 0,
-    y: 0,
-    width: 100,
-    height: 100,
-    points: [pointFrom<LocalPoint>(0, 0), pointFrom<LocalPoint>(100, 100)],
-    isDeleted: true,
-  };
-};
+const MAX_ARROW_PX = 75_000;
 
 const restoreLinearElementPoints = (
   points: unknown,
@@ -591,7 +561,7 @@ export const restoreElement = (
           } as ExcalidrawLinearElement));
       }
 
-      const restoredLine = restoreElementWithProperties(element, {
+      return restoreElementWithProperties(element, {
         type: "line",
         startBinding: null,
         endBinding: null,
@@ -609,8 +579,6 @@ export const restoreElement = (
           : {}),
         ...getSizeFromPoints(points),
       });
-
-      return handleOversizedLinearElements(restoredLine);
     case "arrow": {
       const startArrowhead = normalizeArrowhead(element.startArrowhead);
       const endArrowhead =
@@ -677,7 +645,37 @@ export const restoreElement = (
         ),
       };
 
-      return handleOversizedLinearElements(normalizedRestoredElement);
+      // Last resort fix for extremely large arrows
+      if (
+        normalizedRestoredElement.width > MAX_ARROW_PX ||
+        normalizedRestoredElement.height > MAX_ARROW_PX
+      ) {
+        console.error(
+          `Removing extremely large arrow ${
+            normalizedRestoredElement.id
+          } (type: ${
+            isElbowArrow(normalizedRestoredElement) ? "elbow" : "simple"
+          }, width: ${normalizedRestoredElement.width}, height: ${
+            normalizedRestoredElement.height
+          }, x: ${normalizedRestoredElement.x}, y: ${
+            normalizedRestoredElement.y
+          })`,
+        );
+        return {
+          ...normalizedRestoredElement,
+          x: 0,
+          y: 0,
+          width: 100,
+          height: 100,
+          points: [
+            pointFrom<LocalPoint>(0, 0),
+            pointFrom<LocalPoint>(100, 100),
+          ],
+          isDeleted: true,
+        };
+      }
+
+      return normalizedRestoredElement;
     }
 
     // generic elements

packages/excalidraw/renderer/animation.ts

@@ -123,9 +123,4 @@ export class AnimationController {
     AnimationController.animations.delete(key);
     AnimationController.cancelScheduledFrameIfIdle();
   }
-
-  static reset() {
-    AnimationController.animations.clear();
-    AnimationController.cancelScheduledFrame();
-  }
 }

packages/excalidraw/renderer/helpers.test.ts

@@ -1,90 +0,0 @@
-import { COLOR_WHITE } from "@excalidraw/common";
-
-import { bootstrapCanvas } from "./helpers";
-
-const setup = () => {
-  const canvas = document.createElement("canvas");
-  canvas.width = 200;
-  canvas.height = 100;
-  const context = canvas.getContext("2d")!;
-  const clearRect = vi.spyOn(context, "clearRect");
-  const fillRect = vi.spyOn(context, "fillRect");
-  return { canvas, context, clearRect, fillRect };
-};
-
-const run = (viewBackgroundColor: unknown) => {
-  const { canvas, context, clearRect, fillRect } = setup();
-  bootstrapCanvas({
-    canvas,
-    scale: 1,
-    normalizedWidth: 200,
-    normalizedHeight: 100,
-    viewBackgroundColor: viewBackgroundColor as string,
-  });
-  return { context, clearRect, fillRect };
-};
-
-describe("bootstrapCanvas background painting", () => {
-  it("skips clearRect for an opaque hex color (fill fully repaints)", () => {
-    const { clearRect, fillRect } = run("#ffffff");
-    expect(clearRect).not.toHaveBeenCalled();
-    expect(fillRect).toHaveBeenCalledTimes(1);
-  });
-
-  it("skips clearRect for a 3-digit opaque hex color", () => {
-    const { clearRect, fillRect } = run("#fff");
-    expect(clearRect).not.toHaveBeenCalled();
-    expect(fillRect).toHaveBeenCalledTimes(1);
-  });
-
-  it("clears for a hex color with alpha (#RGBA / #RRGGBBAA)", () => {
-    expect(run("#ffff").clearRect).toHaveBeenCalledTimes(1);
-    expect(run("#ffffff80").clearRect).toHaveBeenCalledTimes(1);
-  });
-
-  it("clears and skips fill for the transparent keyword", () => {
-    const { clearRect, fillRect } = run("transparent");
-    expect(clearRect).toHaveBeenCalledTimes(1);
-    expect(fillRect).not.toHaveBeenCalled();
-  });
-
-  it("clears for rgba()/hsla() colors and still fills", () => {
-    const rgba = run("rgba(255, 0, 0, 0.5)");
-    expect(rgba.clearRect).toHaveBeenCalledTimes(1);
-    expect(rgba.fillRect).toHaveBeenCalledTimes(1);
-  });
-
-  // the ghosting bug (#10931): a corrupted value must never leave the prior
-  // frame on screen — we always clear when we can't prove the color is opaque
-  it("clears for a corrupted color value to prevent ghosting", () => {
-    expect(run("0000").clearRect).toHaveBeenCalledTimes(1);
-    expect(run("asdfgh").clearRect).toHaveBeenCalledTimes(1);
-  });
-
-  it("falls back to white when the color is rejected by the canvas", () => {
-    const { canvas, context } = setup();
-    // simulate a stale fillStyle left over from a previous frame's drawing
-    context.fillStyle = "#ff0000";
-    let fillStyleAtFillTime = "";
-    vi.spyOn(context, "fillRect").mockImplementation(() => {
-      fillStyleAtFillTime = context.fillStyle as string;
-    });
-
-    bootstrapCanvas({
-      canvas,
-      scale: 1,
-      normalizedWidth: 200,
-      normalizedHeight: 100,
-      viewBackgroundColor: "not-a-color",
-    });
-
-    // not the stale red — the seeded default
-    expect(fillStyleAtFillTime).toBe(COLOR_WHITE);
-  });
-
-  it("clears for a non-string background", () => {
-    const { clearRect, fillRect } = run(undefined);
-    expect(clearRect).toHaveBeenCalledTimes(1);
-    expect(fillRect).not.toHaveBeenCalled();
-  });
-});

packages/excalidraw/renderer/helpers.ts

@@ -1,4 +1,4 @@
-import { COLOR_WHITE, THEME, applyDarkModeFilter } from "@excalidraw/common";
+import { THEME, applyDarkModeFilter } from "@excalidraw/common";
 
 import type { StaticCanvasRenderConfig } from "../scene/types";
 import type { AppState, StaticCanvasAppState } from "../types";
@@ -53,31 +53,21 @@ export const bootstrapCanvas = ({
 
   // Paint background
   if (typeof viewBackgroundColor === "string") {
-    // An opaque fill repaints every pixel, so clearRect would be redundant.
-    // For anything else — transparency, or a value we can't be certain about
-    // (e.g. corrupted persisted state like "0000") — clear first so the
-    // previous frame can't bleed through.
-    //
-    // We skip opaque #RRGGBB and #RGB hex colors as a quick optimization.
-    const isOpaque = /^#([0-9a-f]{3}|[0-9a-f]{6})$/i.test(viewBackgroundColor);
-
-    if (!isOpaque) {
+    const hasTransparence =
+      viewBackgroundColor === "transparent" ||
+      viewBackgroundColor.length === 5 || // #RGBA
+      viewBackgroundColor.length === 9 || // #RRGGBBA
+      /(hsla|rgba)\(/.test(viewBackgroundColor);
+    if (hasTransparence) {
       context.clearRect(0, 0, normalizedWidth, normalizedHeight);
     }
-
-    if (viewBackgroundColor !== "transparent") {
-      context.save();
-      // The canvas silently ignores an invalid fillStyle, which would leave a
-      // stale color from a previous draw. Seed a sane default so corrupted
-      // values fall back to white instead of painting garbage.
-      context.fillStyle = COLOR_WHITE;
-      context.fillStyle = applyDarkModeFilter(
-        viewBackgroundColor,
-        theme === THEME.DARK,
-      );
-      context.fillRect(0, 0, normalizedWidth, normalizedHeight);
-      context.restore();
-    }
+    context.save();
+    context.fillStyle = applyDarkModeFilter(
+      viewBackgroundColor,
+      theme === THEME.DARK,
+    );
+    context.fillRect(0, 0, normalizedWidth, normalizedHeight);
+    context.restore();
   } else {
     context.clearRect(0, 0, normalizedWidth, normalizedHeight);
   }

packages/excalidraw/renderer/staticScene.ts

@@ -1,6 +1,5 @@
 import {
   applyDarkModeFilter,
-  COLOR_WHITE,
   FRAME_STYLE,
   THEME,
   throttleRAF,
@@ -205,13 +204,7 @@ const renderLinkIcon = (
         window.devicePixelRatio * appState.zoom.value,
         window.devicePixelRatio * appState.zoom.value,
       );
-
-      // Seed a sane default so a corrupted color (silently rejected by the
-      // canvas) falls back to white instead of a stale fillStyle.
-      linkCanvasCacheContext.fillStyle = COLOR_WHITE;
-      linkCanvasCacheContext.fillStyle =
-        appState.viewBackgroundColor || COLOR_WHITE;
-
+      linkCanvasCacheContext.fillStyle = appState.viewBackgroundColor || "#fff";
       linkCanvasCacheContext.fillRect(0, 0, width, height);
 
       if (canvasKey === "elementLink") {

packages/excalidraw/scroll.ts

@@ -1,180 +0,0 @@
-import { easeOut } from "@excalidraw/common";
-import { clamp } from "@excalidraw/math";
-
-import type { ExcalidrawElement } from "@excalidraw/element/types";
-
-import { zoomToFit } from "./actions/actionCanvas";
-import { AnimationController } from "./renderer/animation";
-import { calculateScrollCenter } from "./scene/scroll";
-
-import type { AppState, NormalizedZoomValue, Offsets } from "./types";
-
-export const SCROLL_TO_CONTENT_ANIMATION_KEY = "animateScrollToContent";
-
-/** default duration of the scroll/zoom animation, in milliseconds */
-const DEFAULT_ANIMATION_DURATION = 500;
-
-export type ScrollToContentOptions = (
-  | {
-      fitToContent?: boolean;
-      fitToViewport?: never;
-      viewportZoomFactor?: number;
-      animate?: boolean;
-      duration?: number;
-    }
-  | {
-      fitToContent?: never;
-      fitToViewport?: boolean;
-      /** when fitToViewport=true, how much screen should the content cover,
-       * between 0.1 (10%) and 1 (100%) */
-      viewportZoomFactor?: number;
-      animate?: boolean;
-      duration?: number;
-    }
-) & {
-  minZoom?: number;
-  maxZoom?: number;
-  canvasOffsets?: Offsets;
-};
-
-type Viewport = Pick<AppState, "scrollX" | "scrollY" | "zoom">;
-
-/**
- * Scrolls (and optionally zooms) the viewport so that the given target is in
- * view, optionally animating the transition.
- */
-export const scrollToElements = (
-  state: AppState,
-  target: readonly ExcalidrawElement[],
-  onFrame: (
-    state: Pick<
-      AppState,
-      "scrollX" | "scrollY" | "zoom" | "shouldCacheIgnoreZoom"
-    >,
-  ) => void,
-  opts?: ScrollToContentOptions,
-) => {
-  AnimationController.cancel(SCROLL_TO_CONTENT_ANIMATION_KEY);
-
-  const viewport = getTargetViewport(state, target, opts);
-
-  if (opts?.animate) {
-    animateToViewport(
-      state,
-      viewport,
-      opts.duration ?? DEFAULT_ANIMATION_DURATION,
-      onFrame,
-    );
-  } else {
-    // no animation: jump straight to the target. Re-enable zoom caching in
-    // case we just cancelled an in-flight animation that had suppressed it.
-    onFrame({ ...viewport, shouldCacheIgnoreZoom: false });
-  }
-};
-
-/** Computes the viewport (scroll + zoom) that brings the target elements into
- * view, based on the requested fit behavior. */
-const getTargetViewport = (
-  state: AppState,
-  targetElements: readonly ExcalidrawElement[],
-  opts?: ScrollToContentOptions,
-): Viewport => {
-  if (opts?.fitToContent || opts?.fitToViewport) {
-    const { appState } = zoomToFit({
-      canvasOffsets: opts.canvasOffsets,
-      targetElements,
-      appState: state,
-      fitToViewport: !!opts.fitToViewport,
-      viewportZoomFactor: opts.viewportZoomFactor,
-      minZoom: opts.minZoom,
-      maxZoom: opts.maxZoom,
-    });
-
-    return {
-      scrollX: appState.scrollX,
-      scrollY: appState.scrollY,
-      zoom: appState.zoom,
-    };
-  }
-
-  // keep the current zoom, only recenter the viewport on the target
-  const { scrollX, scrollY } = calculateScrollCenter(targetElements, state);
-
-  return { scrollX, scrollY, zoom: state.zoom };
-};
-
-/**
- * Interpolates the viewport from `from` to `target` at the (already-eased)
- * blend amount `factor` (0 = `from`, 1 = `target`).
- *
- * Zoom is interpolated geometrically (so it feels uniform), and rather than
- * tweening scrollX/scrollY directly we tween the *focal point* — the scene
- * point under the viewport center — and derive scroll from it. Mixing a linear
- * scroll with a geometric zoom makes the focal point swoop sideways
- * mid-animation (most visible when zooming out); gliding the focal point keeps
- * it steady. `width/2/zoom - scroll` is the inverse of `centerScrollOn` without
- * offsets, so factor 0/1 land exactly on `from`/`target`.
- */
-export const interpolateViewport = ({
-  from,
-  target,
-  factor,
-}: {
-  from: Pick<AppState, "scrollX" | "scrollY" | "zoom" | "width" | "height">;
-  target: Viewport;
-  factor: number;
-}): Viewport => {
-  const zoom = (from.zoom.value *
-    Math.pow(
-      target.zoom.value / from.zoom.value,
-      factor,
-    )) as NormalizedZoomValue;
-
-  const fromCenterX = from.width / 2 / from.zoom.value - from.scrollX;
-  const fromCenterY = from.height / 2 / from.zoom.value - from.scrollY;
-  const toCenterX = from.width / 2 / target.zoom.value - target.scrollX;
-  const toCenterY = from.height / 2 / target.zoom.value - target.scrollY;
-
-  const centerX = fromCenterX + (toCenterX - fromCenterX) * factor;
-  const centerY = fromCenterY + (toCenterY - fromCenterY) * factor;
-
-  return {
-    scrollX: from.width / 2 / zoom - centerX,
-    scrollY: from.height / 2 / zoom - centerY,
-    zoom: { value: zoom },
-  };
-};
-
-/** Eases the viewport from its current position to `target` over `duration`,
- * driving the transition through the shared AnimationController so it doesn't
- * slow down other processes. */
-const animateToViewport = (
-  from: Pick<AppState, "scrollX" | "scrollY" | "zoom" | "width" | "height">,
-  target: Viewport,
-  duration: number,
-  onFrame: (
-    state: Pick<
-      AppState,
-      "scrollX" | "scrollY" | "zoom" | "shouldCacheIgnoreZoom"
-    >,
-  ) => void,
-) => {
-  AnimationController.start<{ elapsed: number }>(
-    SCROLL_TO_CONTENT_ANIMATION_KEY,
-    ({ deltaTime, state }) => {
-      const elapsed = (state?.elapsed ?? 0) + deltaTime;
-      const progress = Math.min(elapsed / duration, 1);
-      const factor = easeOut(clamp(progress, 0, 1));
-
-      onFrame({
-        ...interpolateViewport({ from, target, factor }),
-        shouldCacheIgnoreZoom: progress < 1, // ignore zoom caching while animating
-      });
-
-      // returning a falsy value signals the AnimationController to remove the
-      // animation; otherwise it would keep ticking (and calling onFrame) every
-      // frame forever after reaching the target
-      return progress < 1 ? { elapsed } : null;
-    },
-  );
-};

packages/excalidraw/tests/data/restore.test.ts

@@ -526,53 +526,6 @@ describe("restoreElements", () => {
     ]);
   });
 
-  it("should mark extremely large linear elements as deleted to avoid freezing", () => {
-    const consoleError = vi
-      .spyOn(console, "error")
-      .mockImplementation(() => {});
-
-    // a degenerate line with astronomical coordinates (see #11497)
-    const hugeLine: any = API.createElement({
-      type: "line",
-      x: 419048829414166,
-      y: 8484,
-    });
-    hugeLine.points = [
-      [0, 0],
-      [-302985021938436, 0],
-      [-838097658820234, 30],
-    ];
-
-    const hugeArrow: any = API.createElement({ type: "arrow" });
-    hugeArrow.points = [
-      [0, 0],
-      [900000, 0],
-    ];
-
-    const normalLine: any = API.createElement({ type: "line" });
-    normalLine.points = [
-      [0, 0],
-      [100, 200],
-    ];
-
-    const [restoredLine, restoredArrow, restoredNormal] =
-      restore.restoreElements([hugeLine, hugeArrow, normalLine], null);
-
-    expect(restoredLine.isDeleted).toBe(true);
-    expect(restoredLine.width).toBe(100);
-    expect(restoredLine.height).toBe(100);
-
-    expect(restoredArrow.isDeleted).toBe(true);
-    expect(restoredArrow.width).toBe(100);
-    expect(restoredArrow.height).toBe(100);
-
-    expect(restoredNormal.isDeleted).toBe(false);
-    expect(restoredNormal.width).toBe(100);
-    expect(restoredNormal.height).toBe(200);
-
-    consoleError.mockRestore();
-  });
-
   it("when the number of points of a line is greater or equal 2", () => {
     const lineElement_0 = API.createElement({
       type: "line",

packages/excalidraw/tests/fitToContent.test.tsx

@@ -1,62 +1,20 @@
 import React from "react";
+import { vi } from "vitest";
 
 import { Excalidraw } from "../index";
-import { AnimationController } from "../renderer/animation";
-import { SCROLL_TO_CONTENT_ANIMATION_KEY } from "../scroll";
 
 import { API } from "./helpers/api";
 import { act, render } from "./test-utils";
 
 const { h } = window;
 
-/**
- * The scroll/zoom animation is driven by `AnimationController`. With render
- * throttling enabled (see the `beforeEach` below) it schedules frames via
- * `requestAnimationFrame`, advancing the easing based on elapsed wall-clock
- * time. We use a very long animation `duration` (see `LONG_ANIMATION_DURATION`)
- * so it can never complete while we sample it, and let a few frames pass
- * between samples so the easing makes observable (but partial) progress.
- */
-const LONG_ANIMATION_DURATION = 1_000_000;
-
-const waitForAnimationProgress = (frames = 4) => {
+const waitForNextAnimationFrame = () => {
   return act(
     () =>
-      new Promise<void>((resolve) => {
-        let remaining = frames;
-        const step = () => {
-          if (--remaining <= 0) {
-            resolve();
-          } else {
-            requestAnimationFrame(step);
-          }
-        };
-        requestAnimationFrame(step);
-      }),
-  );
-};
-
-/**
- * Polls until the scroll/zoom animation has removed itself from the
- * `AnimationController` (i.e. it ran to completion), or until `maxFrames`
- * elapses as a safety net so a regression can't hang the suite.
- */
-const waitForAnimationToStop = (maxFrames = 200) => {
-  return act(
-    () =>
-      new Promise<void>((resolve) => {
-        let remaining = maxFrames;
-        const check = () => {
-          if (
-            !AnimationController.running(SCROLL_TO_CONTENT_ANIMATION_KEY) ||
-            --remaining <= 0
-          ) {
-            resolve();
-          } else {
-            requestAnimationFrame(check);
-          }
-        };
-        requestAnimationFrame(check);
+      new Promise((resolve) => {
+        requestAnimationFrame(() => {
+          requestAnimationFrame(resolve);
+        });
       }),
   );
 };
@@ -119,34 +77,6 @@ describe("fitToContent", () => {
     expect(h.state.zoom.value).toBeLessThanOrEqual(0.1);
   });
 
-  it("should default to fitToContent when scrolling to an element by id", async () => {
-    await render(<Excalidraw />);
-
-    h.state.width = 10;
-    h.state.height = 10;
-
-    const rectElement = API.createElement({
-      width: 50,
-      height: 100,
-      x: 50,
-      y: 100,
-    });
-
-    API.setElements([rectElement]);
-
-    expect(h.state.zoom.value).toBe(1);
-
-    act(() => {
-      // navigating by element id (a string target) should zoom-to-fit by
-      // default, even though no `fitToContent` option was passed
-      h.app.scrollToContent(rectElement.id, { animate: false });
-    });
-
-    // element is 10x taller than the viewport, so fit-to-content should
-    // drop the zoom to <= 1/10
-    expect(h.state.zoom.value).toBeLessThanOrEqual(0.1);
-  });
-
   it("should scroll the viewport to the selected element", async () => {
     await render(<Excalidraw />);
 
@@ -179,16 +109,11 @@ describe("fitToContent", () => {
 
 describe("fitToContent animated", () => {
   beforeEach(() => {
-    // pace the animation via requestAnimationFrame instead of a tight
-    // setTimeout(0) loop, which would otherwise starve the test's own timers
-    window.EXCALIDRAW_THROTTLE_RENDER = true;
+    vi.spyOn(window, "requestAnimationFrame");
   });
 
   afterEach(() => {
-    window.EXCALIDRAW_THROTTLE_RENDER = undefined;
-    // stop any in-flight scroll/zoom animation so it doesn't keep ticking on
-    // the unmounted component and leak into the next test via the singleton
-    AnimationController.reset();
+    vi.restoreAllMocks();
   });
 
   it("should ease scroll the viewport to the selected element", async () => {
@@ -205,18 +130,17 @@ describe("fitToContent animated", () => {
     });
 
     act(() => {
-      h.app.scrollToContent(rectElement, {
-        animate: true,
-        duration: LONG_ANIMATION_DURATION,
-      });
+      h.app.scrollToContent(rectElement, { animate: true });
     });
 
-    // the animation hasn't progressed yet, so we're still at the origin
+    expect(window.requestAnimationFrame).toHaveBeenCalled();
+
+    // Since this is an animation, we expect values to change through time.
+    // We'll verify that the scroll values change at 50ms and 100ms
     expect(h.state.scrollX).toBe(0);
     expect(h.state.scrollY).toBe(0);
 
-    // Since this is an animation, we expect values to change through time.
-    await waitForAnimationProgress();
+    await waitForNextAnimationFrame();
 
     const prevScrollX = h.state.scrollX;
     const prevScrollY = h.state.scrollY;
@@ -224,7 +148,7 @@ describe("fitToContent animated", () => {
     expect(h.state.scrollX).not.toBe(0);
     expect(h.state.scrollY).not.toBe(0);
 
-    await waitForAnimationProgress();
+    await waitForNextAnimationFrame();
 
     expect(h.state.scrollX).not.toBe(prevScrollX);
     expect(h.state.scrollY).not.toBe(prevScrollY);
@@ -247,14 +171,12 @@ describe("fitToContent animated", () => {
     expect(h.state.scrollY).toBe(0);
 
     act(() => {
-      h.app.scrollToContent(rectElement, {
-        animate: true,
-        fitToContent: true,
-        duration: LONG_ANIMATION_DURATION,
-      });
+      h.app.scrollToContent(rectElement, { animate: true, fitToContent: true });
     });
 
-    await waitForAnimationProgress();
+    expect(window.requestAnimationFrame).toHaveBeenCalled();
+
+    await waitForNextAnimationFrame();
 
     const prevScrollX = h.state.scrollX;
     const prevScrollY = h.state.scrollY;
@@ -262,48 +184,9 @@ describe("fitToContent animated", () => {
     expect(h.state.scrollX).not.toBe(0);
     expect(h.state.scrollY).not.toBe(0);
 
-    await waitForAnimationProgress();
+    await waitForNextAnimationFrame();
 
     expect(h.state.scrollX).not.toBe(prevScrollX);
     expect(h.state.scrollY).not.toBe(prevScrollY);
   });
-
-  it("should stop ticking and settle on the target once complete", async () => {
-    await render(<Excalidraw />);
-
-    h.state.width = 10;
-    h.state.height = 10;
-
-    const rectElement = API.createElement({
-      width: 100,
-      height: 100,
-      x: -100,
-      y: -100,
-    });
-
-    act(() => {
-      // a short duration so the animation completes within a few frames
-      h.app.scrollToContent(rectElement, { animate: true, duration: 10 });
-    });
-
-    await waitForAnimationToStop();
-
-    // the animation must remove itself from the controller rather than keep
-    // ticking forever after reaching the target
-    expect(AnimationController.running(SCROLL_TO_CONTENT_ANIMATION_KEY)).toBe(
-      false,
-    );
-
-    // it should have settled on the target viewport (moved off the origin)
-    const settledScrollX = h.state.scrollX;
-    const settledScrollY = h.state.scrollY;
-    expect(settledScrollX).not.toBe(0);
-    expect(settledScrollY).not.toBe(0);
-    expect(h.state.shouldCacheIgnoreZoom).toBe(false);
-
-    // further frames must not move the viewport (no perpetual re-rendering)
-    await waitForAnimationProgress();
-    expect(h.state.scrollX).toBe(settledScrollX);
-    expect(h.state.scrollY).toBe(settledScrollY);
-  });
 });

packages/excalidraw/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "rootDir": "../",
     "outDir": "./dist/types"
   },
   "include": ["**/*"],

packages/fractional-indexing/tsconfig.json

@@ -1,8 +1,7 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "./dist/types",
-    "rootDir": "../"
+    "outDir": "./dist/types"
   },
   "include": ["src/**/*", "global.d.ts"],
   "exclude": ["**/*.test.*", "tests", "types", "examples", "dist"]

packages/laser-pointer/package.json

@@ -3,12 +3,12 @@
   "version": "1.3.1",
   "description": "Generate outline for laser pointer tool",
   "type": "module",
-  "types": "./dist/types/laser-pointer/src/index.d.ts",
+  "types": "./dist/types/index.d.ts",
   "main": "./dist/prod/index.js",
   "module": "./dist/prod/index.js",
   "exports": {
     ".": {
-      "types": "./dist/types/laser-pointer/src/index.d.ts",
+      "types": "./dist/types/index.d.ts",
       "development": "./dist/dev/index.js",
       "production": "./dist/prod/index.js",
       "default": "./dist/prod/index.js"

packages/laser-pointer/tsconfig.json

@@ -1,8 +1,7 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "outDir": "./dist/types",
-    "rootDir": "../"
+    "outDir": "./dist/types"
   },
   "include": ["src/**/*", "global.d.ts"],
   "exclude": ["**/*.test.*", "tests", "types", "examples", "dist"]

packages/math/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "rootDir": "../",
     "outDir": "./dist/types"
   },
   "include": ["src/**/*", "global.d.ts"],

packages/tsconfig.base.json

@@ -6,7 +6,7 @@
     "declaration": true,
     "allowSyntheticDefaultImports": true,
     "module": "ESNext",
-    "moduleResolution": "bundler",
+    "moduleResolution": "Node",
     "resolveJsonModule": true,
     "jsx": "react-jsx",
     "emitDeclarationOnly": true,

packages/utils/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "rootDir": "../",
     "outDir": "./dist/types"
   },
   "include": ["src/**/*", "global.d.ts"],

tsconfig.json

@@ -12,7 +12,7 @@
     "forceConsistentCasingInFileNames": true,
     "noFallthroughCasesInSwitch": true,
     "module": "ESNext",
-    "moduleResolution": "bundler",
+    "moduleResolution": "node",
     "resolveJsonModule": true,
     "isolatedModules": true,
     "noEmit": true,