Compare commits
5 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 0256559b68 | |||
| c9d29ea600 | |||
| 90c4770a5b | |||
| e48043aef5 | |||
| 3e53dcd956 |
@@ -1,124 +0,0 @@
|
||||
- generic [ref=e1]:
|
||||
- banner:
|
||||
- heading "Excalidraw" [level=1] [ref=e2]
|
||||
- generic [active] [ref=e5]:
|
||||
- generic:
|
||||
- generic:
|
||||
- generic:
|
||||
- button [ref=e9] [cursor=pointer]:
|
||||
- img [ref=e10]
|
||||
- region "Shapes":
|
||||
- generic [ref=e16]:
|
||||
- generic:
|
||||
- generic:
|
||||
- text: To move canvas, hold
|
||||
- generic: Scroll wheel
|
||||
- text: or
|
||||
- generic: Space
|
||||
- text: while dragging, or use the hand tool
|
||||
- heading "Shapes" [level=2] [ref=e17]
|
||||
- generic [ref=e18]:
|
||||
- generic "Keep selected tool active after drawing — Q" [ref=e19] [cursor=pointer]:
|
||||
- checkbox "Keep selected tool active after drawing"
|
||||
- img [ref=e21]
|
||||
- generic "Hand (panning tool) — H or null" [ref=e29] [cursor=pointer]:
|
||||
- radio "Hand (panning tool)"
|
||||
- img [ref=e31]
|
||||
- generic "Selection — V or 1" [ref=e38] [cursor=pointer]:
|
||||
- radio "Selection" [checked]
|
||||
- generic [ref=e39]:
|
||||
- img [ref=e40]
|
||||
- generic [ref=e45]: "1"
|
||||
- generic "Rectangle — R or 2" [ref=e46] [cursor=pointer]:
|
||||
- radio "Rectangle"
|
||||
- generic [ref=e47]:
|
||||
- img [ref=e48]
|
||||
- generic [ref=e52]: "2"
|
||||
- generic "Diamond — D or 3" [ref=e53] [cursor=pointer]:
|
||||
- radio "Diamond"
|
||||
- generic [ref=e54]:
|
||||
- img [ref=e55]
|
||||
- generic [ref=e59]: "3"
|
||||
- generic "Ellipse — O or 4" [ref=e60] [cursor=pointer]:
|
||||
- radio "Ellipse"
|
||||
- generic [ref=e61]:
|
||||
- img [ref=e62]
|
||||
- generic [ref=e66]: "4"
|
||||
- generic "Arrow — A or 5" [ref=e67] [cursor=pointer]:
|
||||
- radio "Arrow"
|
||||
- generic [ref=e68]:
|
||||
- img [ref=e69]
|
||||
- generic [ref=e74]: "5"
|
||||
- generic "Line — L or 6" [ref=e75] [cursor=pointer]:
|
||||
- radio "Line"
|
||||
- generic [ref=e76]:
|
||||
- img [ref=e77]
|
||||
- generic [ref=e78]: "6"
|
||||
- generic "Draw — P or 7" [ref=e79] [cursor=pointer]:
|
||||
- radio "Draw"
|
||||
- generic [ref=e80]:
|
||||
- img [ref=e81]
|
||||
- generic [ref=e85]: "7"
|
||||
- generic "Text — T or 8" [ref=e86] [cursor=pointer]:
|
||||
- radio "Text"
|
||||
- generic [ref=e87]:
|
||||
- img [ref=e88]
|
||||
- generic [ref=e93]: "8"
|
||||
- generic "Insert image — 9" [ref=e94] [cursor=pointer]:
|
||||
- radio "Insert image"
|
||||
- generic [ref=e95]:
|
||||
- img [ref=e96]
|
||||
- generic [ref=e101]: "9"
|
||||
- generic "Eraser — E or 0" [ref=e102] [cursor=pointer]:
|
||||
- radio "Eraser"
|
||||
- generic [ref=e103]:
|
||||
- img [ref=e104]
|
||||
- generic [ref=e109]: "0"
|
||||
- button "More tools" [ref=e112] [cursor=pointer]:
|
||||
- img [ref=e113]
|
||||
- generic:
|
||||
- generic [ref=e119]:
|
||||
- link "Excalidraw+" [ref=e120] [cursor=pointer]:
|
||||
- /url: https://plus.excalidraw.com/plus?utm_source=excalidraw&utm_medium=app&utm_content=guestBanner#excalidraw-redirect
|
||||
- button "Live collaboration..." [ref=e121] [cursor=pointer]:
|
||||
- img [ref=e122]
|
||||
- generic "Library" [ref=e124]:
|
||||
- checkbox "Library"
|
||||
- img [ref=e127] [cursor=pointer]
|
||||
- contentinfo:
|
||||
- region "Canvas actions" [ref=e132]:
|
||||
- heading "Canvas actions" [level=2] [ref=e133]
|
||||
- generic [ref=e135]:
|
||||
- button "Zoom out" [ref=e136] [cursor=pointer]:
|
||||
- img [ref=e138]
|
||||
- button "Reset zoom" [ref=e140] [cursor=pointer]: 100%
|
||||
- button "Zoom in" [ref=e141] [cursor=pointer]:
|
||||
- img [ref=e143]
|
||||
- generic [ref=e145]:
|
||||
- button "Undo" [disabled] [ref=e148]:
|
||||
- img [ref=e150]
|
||||
- button "Redo" [disabled] [ref=e154]:
|
||||
- img [ref=e156]
|
||||
- generic [ref=e158]:
|
||||
- generic [ref=e159]:
|
||||
- button "lock scroll" [ref=e160] [cursor=pointer]
|
||||
- generic [ref=e161]:
|
||||
- text: overscroll
|
||||
- spinbutton "overscroll" [ref=e162]: "0.2"
|
||||
- generic [ref=e163]:
|
||||
- text: zoom factor
|
||||
- spinbutton "zoom factor" [ref=e164]: "0.2"
|
||||
- generic [ref=e165]:
|
||||
- checkbox "lock zoom" [ref=e166]
|
||||
- text: lock zoom
|
||||
- generic [ref=e167]:
|
||||
- checkbox "animate" [ref=e168]
|
||||
- text: animate
|
||||
- link "Blog post on end-to-end encryption in Excalidraw" [ref=e169] [cursor=pointer]:
|
||||
- /url: https://plus.excalidraw.com/blog/end-to-end-encryption
|
||||
- img [ref=e171]
|
||||
- button "Help" [ref=e174] [cursor=pointer]:
|
||||
- img [ref=e175]
|
||||
- generic:
|
||||
- img
|
||||
- generic [ref=e180]: Drawing canvas
|
||||
@@ -1,126 +0,0 @@
|
||||
- generic [ref=e1]:
|
||||
- banner:
|
||||
- heading "Excalidraw" [level=1] [ref=e2]
|
||||
- generic [ref=e5]:
|
||||
- generic:
|
||||
- generic:
|
||||
- generic:
|
||||
- generic:
|
||||
- img
|
||||
- img
|
||||
- generic:
|
||||
- text: Your drawings are saved in your browser's storage.
|
||||
- text: Browser storage can be cleared unexpectedly.
|
||||
- text: Save your work to a file regularly to avoid losing it.
|
||||
- generic:
|
||||
- button "Open Ctrl+O" [ref=e181] [cursor=pointer]:
|
||||
- img [ref=e183]
|
||||
- generic [ref=e185]: Open
|
||||
- generic [ref=e186]: Ctrl+O
|
||||
- button "Help ?" [ref=e187] [cursor=pointer]:
|
||||
- img [ref=e189]
|
||||
- generic [ref=e194]: Help
|
||||
- generic [ref=e195]: "?"
|
||||
- button "Live collaboration..." [ref=e196] [cursor=pointer]:
|
||||
- img [ref=e198]
|
||||
- generic [ref=e205]: Live collaboration...
|
||||
- link "Sign up" [ref=e206] [cursor=pointer]:
|
||||
- /url: https://plus.excalidraw.com/plus?utm_source=excalidraw&utm_medium=app&utm_content=welcomeScreenGuest
|
||||
- img [ref=e208]
|
||||
- generic [ref=e214]: Sign up
|
||||
- generic:
|
||||
- generic:
|
||||
- button [ref=e9] [cursor=pointer]:
|
||||
- img [ref=e10]
|
||||
- region "Shapes":
|
||||
- generic [ref=e16]:
|
||||
- generic:
|
||||
- generic:
|
||||
- text: To move canvas, hold
|
||||
- generic: Scroll wheel
|
||||
- text: or
|
||||
- generic: Space
|
||||
- text: while dragging, or use the hand tool
|
||||
- heading "Shapes" [level=2] [ref=e17]
|
||||
- generic [ref=e18]:
|
||||
- generic "Keep selected tool active after drawing — Q" [ref=e19] [cursor=pointer]:
|
||||
- checkbox "Keep selected tool active after drawing"
|
||||
- img [ref=e21]
|
||||
- generic "Hand (panning tool) — H or null" [ref=e29] [cursor=pointer]:
|
||||
- radio "Hand (panning tool)"
|
||||
- img [ref=e31]
|
||||
- generic "Selection" [ref=e215] [cursor=pointer]:
|
||||
- radio "Selection" [checked]
|
||||
- img [ref=e217]
|
||||
- generic "Rectangle — R or 2" [ref=e46] [cursor=pointer]:
|
||||
- radio "Rectangle"
|
||||
- img [ref=e48]
|
||||
- generic "Diamond — D or 3" [ref=e53] [cursor=pointer]:
|
||||
- radio "Diamond"
|
||||
- img [ref=e55]
|
||||
- generic "Ellipse — O or 4" [ref=e60] [cursor=pointer]:
|
||||
- radio "Ellipse"
|
||||
- img [ref=e62]
|
||||
- generic "Arrow — A or 5" [ref=e67] [cursor=pointer]:
|
||||
- radio "Arrow"
|
||||
- img [ref=e69]
|
||||
- generic "Line — L or 6" [ref=e75] [cursor=pointer]:
|
||||
- radio "Line"
|
||||
- img [ref=e77]
|
||||
- generic "Draw — P or 7" [ref=e79] [cursor=pointer]:
|
||||
- radio "Draw"
|
||||
- img [ref=e81]
|
||||
- generic "Text — T or 8" [ref=e86] [cursor=pointer]:
|
||||
- radio "Text"
|
||||
- img [ref=e88]
|
||||
- generic "Insert image — 9" [ref=e94] [cursor=pointer]:
|
||||
- radio "Insert image"
|
||||
- img [ref=e96]
|
||||
- generic "Eraser — E or 0" [ref=e102] [cursor=pointer]:
|
||||
- radio "Eraser"
|
||||
- img [ref=e104]
|
||||
- button "More tools" [ref=e112] [cursor=pointer]:
|
||||
- img [ref=e113]
|
||||
- generic:
|
||||
- button "Live collaboration..." [ref=e121] [cursor=pointer]:
|
||||
- img [ref=e122]
|
||||
- generic "Library" [ref=e124]:
|
||||
- checkbox "Library"
|
||||
- img [ref=e127] [cursor=pointer]
|
||||
- contentinfo:
|
||||
- region "Canvas actions" [ref=e132]:
|
||||
- heading "Canvas actions" [level=2] [ref=e133]
|
||||
- generic [ref=e135]:
|
||||
- button "Zoom out" [ref=e136] [cursor=pointer]:
|
||||
- img [ref=e138]
|
||||
- button "Reset zoom" [disabled] [ref=e140]: 100%
|
||||
- button "Zoom in" [ref=e141] [cursor=pointer]:
|
||||
- img [ref=e143]
|
||||
- generic [ref=e145]:
|
||||
- button "Undo" [disabled] [ref=e148]:
|
||||
- img [ref=e150]
|
||||
- button "Redo" [disabled] [ref=e154]:
|
||||
- img [ref=e156]
|
||||
- generic [ref=e158]:
|
||||
- generic [ref=e159]:
|
||||
- button "disable scroll lock" [active] [ref=e222] [cursor=pointer]
|
||||
- generic [ref=e161]:
|
||||
- text: overscroll
|
||||
- spinbutton "overscroll" [ref=e162]: "0.2"
|
||||
- generic [ref=e163]:
|
||||
- text: zoom factor
|
||||
- spinbutton "zoom factor" [ref=e164]: "0.2"
|
||||
- generic [ref=e165]:
|
||||
- checkbox "lock zoom" [ref=e166]
|
||||
- text: lock zoom
|
||||
- generic [ref=e167]:
|
||||
- checkbox "animate" [ref=e168]
|
||||
- text: animate
|
||||
- link "Blog post on end-to-end encryption in Excalidraw" [ref=e169] [cursor=pointer]:
|
||||
- /url: https://plus.excalidraw.com/blog/end-to-end-encryption
|
||||
- img [ref=e171]
|
||||
- button "Help" [ref=e174] [cursor=pointer]:
|
||||
- img [ref=e175]
|
||||
- generic:
|
||||
- img
|
||||
- generic [ref=e180]: Drawing canvas
|
||||
@@ -29,7 +29,7 @@
|
||||
<a href="https://docs.excalidraw.com/docs/introduction/contributing">
|
||||
<img alt="PRs welcome!" src="https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat" /></a>
|
||||
<a href="https://discord.gg/UexuTaE">
|
||||
<img alt="Chat on Discord" src="https://img.shields.io/discord/723672430744174682?color=738ad6&label=Chat%20on%20Discord&logo=discord&logoColor=ffffff&widget=false"/></a>
|
||||
<img alt="Chat on Discord" src="https://img.shields.io/discord/723672430744174682?color=738ad6&label=Chat%20on%20Discord&logo=discord&logoColor=ffffff&widge=false"/></a>
|
||||
<a href="https://deepwiki.com/excalidraw/excalidraw">
|
||||
<img alt="Ask DeepWiki" src="https://deepwiki.com/badge.svg" /></a>
|
||||
<a href="https://twitter.com/excalidraw">
|
||||
|
||||
@@ -4,20 +4,8 @@ import { Excalidraw } from "@excalidraw/excalidraw";
|
||||
|
||||
import "@excalidraw/excalidraw/index.css";
|
||||
|
||||
import type { ScrollConstraints } from "@excalidraw/excalidraw/types";
|
||||
|
||||
import App from "../../with-script-in-browser/components/ExampleApp";
|
||||
|
||||
const scrollConstraints: ScrollConstraints = {
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 850,
|
||||
height: 400,
|
||||
lockZoom: true,
|
||||
overscrollAllowance: 0,
|
||||
viewportZoomFactor: 1,
|
||||
};
|
||||
|
||||
const ExcalidrawWrapper: React.FC = () => {
|
||||
return (
|
||||
<>
|
||||
@@ -26,7 +14,7 @@ const ExcalidrawWrapper: React.FC = () => {
|
||||
useCustom={(api: any, args?: any[]) => {}}
|
||||
excalidrawLib={excalidrawLib}
|
||||
>
|
||||
<Excalidraw scrollConstraints={scrollConstraints} />
|
||||
<Excalidraw />
|
||||
</App>
|
||||
</>
|
||||
);
|
||||
|
||||
@@ -178,8 +178,7 @@ export default function ExampleApp({
|
||||
const newElement = cloneElement(
|
||||
Excalidraw,
|
||||
{
|
||||
onExcalidrawAPI: (api: ExcalidrawImperativeAPI | null) =>
|
||||
setExcalidrawAPI(api),
|
||||
excalidrawAPI: (api: ExcalidrawImperativeAPI) => setExcalidrawAPI(api),
|
||||
initialData: initialStatePromiseRef.current.promise,
|
||||
onChange: (
|
||||
elements: NonDeletedExcalidrawElement[],
|
||||
@@ -821,48 +820,6 @@ export default function ExampleApp({
|
||||
/>
|
||||
Export with embed scene
|
||||
</label>
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => {
|
||||
if (!excalidrawAPI) {
|
||||
return;
|
||||
}
|
||||
|
||||
const elements = excalidrawAPI.getSceneElements();
|
||||
excalidrawAPI.scrollToContent(elements[0], {
|
||||
animate: true,
|
||||
fitToViewport: true,
|
||||
viewportZoomFactor: 0.9,
|
||||
scrollLock: {
|
||||
lockZoom: true,
|
||||
overscrollAllowance: 0,
|
||||
},
|
||||
});
|
||||
}}
|
||||
>
|
||||
Fit and lock first element
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => {
|
||||
if (!excalidrawAPI) {
|
||||
return;
|
||||
}
|
||||
|
||||
const elements = excalidrawAPI.getSceneElements();
|
||||
excalidrawAPI.scrollToContent(elements[1], {
|
||||
animate: true,
|
||||
fitToViewport: true,
|
||||
viewportZoomFactor: 0.9,
|
||||
scrollLock: {
|
||||
lockZoom: true,
|
||||
overscrollAllowance: 0,
|
||||
},
|
||||
});
|
||||
}}
|
||||
>
|
||||
Fit and lock second element
|
||||
</button>
|
||||
<button
|
||||
onClick={async () => {
|
||||
if (!excalidrawAPI) {
|
||||
|
||||
@@ -1015,10 +1015,7 @@ const ExcalidrawWrapper = () => {
|
||||
</OverwriteConfirmDialog.Action>
|
||||
)}
|
||||
</OverwriteConfirmDialog>
|
||||
<AppFooter
|
||||
excalidrawAPI={excalidrawAPI}
|
||||
onChange={() => excalidrawAPI?.refresh()}
|
||||
/>
|
||||
<AppFooter onChange={() => excalidrawAPI?.refresh()} />
|
||||
{excalidrawAPI && <AIComponents excalidrawAPI={excalidrawAPI} />}
|
||||
|
||||
<TTDDialogTrigger />
|
||||
|
||||
@@ -1,178 +1,13 @@
|
||||
import { Footer } from "@excalidraw/excalidraw/index";
|
||||
import {
|
||||
getCommonBounds,
|
||||
getSelectedElements,
|
||||
getVisibleSceneBounds,
|
||||
} from "@excalidraw/element";
|
||||
import React, { useCallback, useState } from "react";
|
||||
|
||||
import type {
|
||||
ExcalidrawImperativeAPI,
|
||||
ScrollConstraints,
|
||||
} from "@excalidraw/excalidraw/types";
|
||||
import React from "react";
|
||||
|
||||
import { isExcalidrawPlusSignedUser } from "../app_constants";
|
||||
|
||||
import { DebugFooter, isVisualDebuggerEnabled } from "./DebugCanvas";
|
||||
import { EncryptedIcon } from "./EncryptedIcon";
|
||||
|
||||
type ScrollConstraintOptions = Pick<
|
||||
ScrollConstraints,
|
||||
"lockZoom" | "overscrollAllowance" | "viewportZoomFactor"
|
||||
>;
|
||||
|
||||
const ScrollConstraintsDebugFooter = ({
|
||||
excalidrawAPI,
|
||||
}: {
|
||||
excalidrawAPI: ExcalidrawImperativeAPI | null;
|
||||
}) => {
|
||||
const [activeLock, setActiveLock] = useState<ScrollConstraints | null>(null);
|
||||
const [options, setOptions] = useState<ScrollConstraintOptions>({
|
||||
lockZoom: false,
|
||||
overscrollAllowance: 0.2,
|
||||
viewportZoomFactor: 0.2,
|
||||
});
|
||||
|
||||
const setLock = useCallback(
|
||||
(nextLock: ScrollConstraints) => {
|
||||
excalidrawAPI?.setScrollConstraints(nextLock);
|
||||
setActiveLock(nextLock);
|
||||
},
|
||||
[excalidrawAPI],
|
||||
);
|
||||
|
||||
const toggleScrollLock = useCallback(() => {
|
||||
if (!excalidrawAPI) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (activeLock) {
|
||||
excalidrawAPI.setScrollConstraints(null);
|
||||
setActiveLock(null);
|
||||
return;
|
||||
}
|
||||
|
||||
const selectedElements = getSelectedElements(
|
||||
excalidrawAPI.getSceneElements(),
|
||||
excalidrawAPI.getAppState(),
|
||||
{
|
||||
includeBoundTextElement: true,
|
||||
includeElementsInFrames: true,
|
||||
},
|
||||
);
|
||||
const [x1, y1, x2, y2] = selectedElements.length
|
||||
? getCommonBounds(
|
||||
selectedElements,
|
||||
excalidrawAPI.getSceneElementsMapIncludingDeleted(),
|
||||
)
|
||||
: getVisibleSceneBounds(excalidrawAPI.getAppState());
|
||||
|
||||
setLock({
|
||||
x: x1,
|
||||
y: y1,
|
||||
width: x2 - x1,
|
||||
height: y2 - y1,
|
||||
...options,
|
||||
});
|
||||
}, [activeLock, excalidrawAPI, options, setLock]);
|
||||
|
||||
const updateOptions = useCallback(
|
||||
(nextOptions: ScrollConstraintOptions) => {
|
||||
setOptions(nextOptions);
|
||||
|
||||
if (activeLock) {
|
||||
setLock({ ...activeLock, ...nextOptions });
|
||||
}
|
||||
},
|
||||
[activeLock, setLock],
|
||||
);
|
||||
|
||||
const updateNumberOption = useCallback(
|
||||
(option: "overscrollAllowance" | "viewportZoomFactor", value: string) => {
|
||||
updateOptions({
|
||||
...options,
|
||||
[option]: value === "" ? undefined : Number(value),
|
||||
});
|
||||
},
|
||||
[options, updateOptions],
|
||||
);
|
||||
|
||||
const updateBooleanOption = useCallback(
|
||||
(option: "lockZoom", value: boolean) => {
|
||||
updateOptions({
|
||||
...options,
|
||||
[option]: value,
|
||||
});
|
||||
},
|
||||
[options, updateOptions],
|
||||
);
|
||||
|
||||
return (
|
||||
<div
|
||||
style={{
|
||||
display: "flex",
|
||||
gap: ".45rem",
|
||||
alignItems: "center",
|
||||
padding: "0 .35rem",
|
||||
fontSize: 12,
|
||||
}}
|
||||
>
|
||||
<button
|
||||
className="ToolIcon_type_button"
|
||||
type="button"
|
||||
onClick={toggleScrollLock}
|
||||
>
|
||||
{activeLock ? "disable scroll lock" : "lock scroll"}
|
||||
</button>
|
||||
<label style={{ display: "flex", gap: ".25rem", alignItems: "center" }}>
|
||||
overscroll
|
||||
<input
|
||||
type="number"
|
||||
min={0}
|
||||
max={1}
|
||||
step={0.05}
|
||||
value={options.overscrollAllowance ?? ""}
|
||||
onChange={(event) =>
|
||||
updateNumberOption("overscrollAllowance", event.target.value)
|
||||
}
|
||||
style={{ width: 56 }}
|
||||
/>
|
||||
</label>
|
||||
<label style={{ display: "flex", gap: ".25rem", alignItems: "center" }}>
|
||||
zoom factor
|
||||
<input
|
||||
type="number"
|
||||
min={0.1}
|
||||
step={0.1}
|
||||
value={options.viewportZoomFactor ?? ""}
|
||||
onChange={(event) =>
|
||||
updateNumberOption("viewportZoomFactor", event.target.value)
|
||||
}
|
||||
style={{ width: 56 }}
|
||||
/>
|
||||
</label>
|
||||
<label style={{ display: "flex", gap: ".2rem", alignItems: "center" }}>
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={!!options.lockZoom}
|
||||
onChange={(event) =>
|
||||
updateBooleanOption("lockZoom", event.target.checked)
|
||||
}
|
||||
/>
|
||||
lock zoom
|
||||
</label>
|
||||
</div>
|
||||
);
|
||||
};
|
||||
|
||||
export const AppFooter = React.memo(
|
||||
({
|
||||
excalidrawAPI,
|
||||
onChange,
|
||||
}: {
|
||||
excalidrawAPI: ExcalidrawImperativeAPI | null;
|
||||
onChange: () => void;
|
||||
}) => {
|
||||
({ onChange }: { onChange: () => void }) => {
|
||||
return (
|
||||
<Footer>
|
||||
<div
|
||||
@@ -182,7 +17,6 @@ export const AppFooter = React.memo(
|
||||
alignItems: "center",
|
||||
}}
|
||||
>
|
||||
<ScrollConstraintsDebugFooter excalidrawAPI={excalidrawAPI} />
|
||||
{isVisualDebuggerEnabled() && <DebugFooter onChange={onChange} />}
|
||||
{!isExcalidrawPlusSignedUser && <EncryptedIcon />}
|
||||
</div>
|
||||
|
||||
@@ -405,8 +405,9 @@ export const ROUGHNESS = {
|
||||
|
||||
export const STROKE_WIDTH = {
|
||||
thin: 1,
|
||||
bold: 2,
|
||||
extraBold: 4,
|
||||
medium: 2,
|
||||
bold: 4,
|
||||
extraBold: 8,
|
||||
} as const;
|
||||
|
||||
export const DEFAULT_ELEMENT_PROPS: {
|
||||
@@ -429,6 +430,8 @@ export const DEFAULT_ELEMENT_PROPS: {
|
||||
locked: false,
|
||||
};
|
||||
|
||||
export const DEFAULT_FREE_DRAW_STROKE_SHAPE = "variable" as const;
|
||||
|
||||
export const LIBRARY_SIDEBAR_TAB = "library";
|
||||
export const CANVAS_SEARCH_TAB = "search";
|
||||
|
||||
|
||||
@@ -168,12 +168,14 @@ export class ElementBounds {
|
||||
),
|
||||
),
|
||||
);
|
||||
const padding =
|
||||
element.strokeShape === "fixed" ? element.strokeWidth / 2 : 0;
|
||||
|
||||
return [
|
||||
minX + element.x,
|
||||
minY + element.y,
|
||||
maxX + element.x,
|
||||
maxY + element.y,
|
||||
minX + element.x - padding,
|
||||
minY + element.y - padding,
|
||||
maxX + element.x + padding,
|
||||
maxY + element.y + padding,
|
||||
];
|
||||
} else if (isLinearElement(element)) {
|
||||
bounds = getLinearElementRotatedBounds(element, cx, cy, elementsMap);
|
||||
@@ -703,10 +705,11 @@ const getFreeDrawElementAbsoluteCoords = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
): [number, number, number, number, number, number] => {
|
||||
const [minX, minY, maxX, maxY] = getBoundsFromPoints(element.points);
|
||||
const x1 = minX + element.x;
|
||||
const y1 = minY + element.y;
|
||||
const x2 = maxX + element.x;
|
||||
const y2 = maxY + element.y;
|
||||
const padding = element.strokeShape === "fixed" ? element.strokeWidth / 2 : 0;
|
||||
const x1 = minX + element.x - padding;
|
||||
const y1 = minY + element.y - padding;
|
||||
const x2 = maxX + element.x + padding;
|
||||
const y2 = maxY + element.y + padding;
|
||||
return [x1, y1, x2, y2, (x1 + x2) / 2, (y1 + y2) / 2];
|
||||
};
|
||||
|
||||
|
||||
@@ -27,6 +27,7 @@ import type {
|
||||
|
||||
import type { FrameNameBounds } from "@excalidraw/excalidraw/types";
|
||||
|
||||
import { isLoopFreeDrawElement } from "./freedraw";
|
||||
import { isPathALoop } from "./utils";
|
||||
import {
|
||||
doBoundsIntersect,
|
||||
@@ -93,7 +94,7 @@ export const shouldTestInside = (element: ExcalidrawElement) => {
|
||||
}
|
||||
|
||||
if (element.type === "freedraw") {
|
||||
return isDraggableFromInside && isPathALoop(element.points);
|
||||
return isDraggableFromInside && isLoopFreeDrawElement(element);
|
||||
}
|
||||
|
||||
return isDraggableFromInside || isImageElement(element);
|
||||
@@ -754,8 +755,8 @@ export const isPointInElement = (
|
||||
elementsMap: ElementsMap,
|
||||
) => {
|
||||
if (
|
||||
(isLinearElement(element) || isFreeDrawElement(element)) &&
|
||||
!isPathALoop(element.points)
|
||||
(isLinearElement(element) && !isPathALoop(element.points)) ||
|
||||
(isFreeDrawElement(element) && !isLoopFreeDrawElement(element))
|
||||
) {
|
||||
// There isn't any "inside" for a non-looping path
|
||||
return false;
|
||||
|
||||
@@ -0,0 +1,181 @@
|
||||
import {
|
||||
pointDistance,
|
||||
vectorCross,
|
||||
vectorDot,
|
||||
vectorFromPoint,
|
||||
} from "@excalidraw/math";
|
||||
|
||||
import type { LocalPoint } from "@excalidraw/math";
|
||||
|
||||
import { isPathALoop } from "./utils";
|
||||
|
||||
import type { ExcalidrawFreeDrawElement } from "./types";
|
||||
|
||||
type ZoomValue = NonNullable<Parameters<typeof isPathALoop>[1]>;
|
||||
|
||||
type FixedFreeDrawSimplificationProfile = {
|
||||
minPointDistancePx: number;
|
||||
maxPointDistance: number;
|
||||
strokeDistanceFactor: number;
|
||||
collinearityFactor: number;
|
||||
minAlignment: number;
|
||||
zoomScaling: "sqrt" | "none";
|
||||
};
|
||||
|
||||
const FIXED_FREEDRAW_CAPTURE_PROFILE: FixedFreeDrawSimplificationProfile = {
|
||||
minPointDistancePx: 0.35,
|
||||
maxPointDistance: 0.85,
|
||||
strokeDistanceFactor: 0.08,
|
||||
collinearityFactor: 0.3,
|
||||
minAlignment: 0.985,
|
||||
zoomScaling: "sqrt",
|
||||
};
|
||||
|
||||
const hasSyntheticLoopClosure = (
|
||||
points: readonly LocalPoint[],
|
||||
): points is readonly [LocalPoint, LocalPoint, ...LocalPoint[]] => {
|
||||
if (points.length < 3) {
|
||||
return false;
|
||||
}
|
||||
|
||||
const firstPoint = points[0];
|
||||
const lastPoint = points[points.length - 1];
|
||||
|
||||
return firstPoint[0] === lastPoint[0] && firstPoint[1] === lastPoint[1];
|
||||
};
|
||||
|
||||
const stripSyntheticLoopClosure = (points: readonly LocalPoint[]) =>
|
||||
hasSyntheticLoopClosure(points) ? points.slice(0, -1) : points;
|
||||
|
||||
export const isLoopFreeDrawElement = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
zoomValue: ZoomValue = 1 as ZoomValue,
|
||||
) => element.strokeShape !== "fixed" && isPathALoop(element.points, zoomValue);
|
||||
|
||||
export const getFixedFreeDrawPoints = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
): readonly LocalPoint[] => stripSyntheticLoopClosure(element.points);
|
||||
|
||||
export const getFixedFreeDrawPointSamplingDistance = (
|
||||
strokeWidth: number,
|
||||
zoomValue: ZoomValue = 1 as ZoomValue,
|
||||
profile: FixedFreeDrawSimplificationProfile = FIXED_FREEDRAW_CAPTURE_PROFILE,
|
||||
) =>
|
||||
Math.min(
|
||||
Math.max(
|
||||
profile.minPointDistancePx /
|
||||
(profile.zoomScaling === "sqrt"
|
||||
? Math.max(1, Math.sqrt(zoomValue))
|
||||
: 1),
|
||||
strokeWidth * profile.strokeDistanceFactor,
|
||||
),
|
||||
profile.maxPointDistance,
|
||||
);
|
||||
|
||||
const isRedundantFixedFreeDrawPoint = (
|
||||
previousPoint: LocalPoint,
|
||||
currentPoint: LocalPoint,
|
||||
nextPoint: LocalPoint,
|
||||
strokeWidth: number,
|
||||
zoomValue: ZoomValue,
|
||||
profile: FixedFreeDrawSimplificationProfile,
|
||||
) => {
|
||||
const previousSegmentLength = pointDistance(previousPoint, currentPoint);
|
||||
const nextSegmentLength = pointDistance(currentPoint, nextPoint);
|
||||
|
||||
if (!previousSegmentLength || !nextSegmentLength) {
|
||||
return true;
|
||||
}
|
||||
|
||||
const previousVector = vectorFromPoint(currentPoint, previousPoint);
|
||||
const nextVector = vectorFromPoint(nextPoint, currentPoint);
|
||||
const alignment =
|
||||
vectorDot(previousVector, nextVector) /
|
||||
(previousSegmentLength * nextSegmentLength);
|
||||
|
||||
if (alignment < profile.minAlignment) {
|
||||
return false;
|
||||
}
|
||||
|
||||
const chord = vectorFromPoint(nextPoint, previousPoint);
|
||||
const chordLength = pointDistance(previousPoint, nextPoint);
|
||||
|
||||
if (!chordLength) {
|
||||
return true;
|
||||
}
|
||||
|
||||
const distanceToChord =
|
||||
Math.abs(vectorCross(vectorFromPoint(currentPoint, previousPoint), chord)) /
|
||||
chordLength;
|
||||
|
||||
return (
|
||||
distanceToChord <=
|
||||
getFixedFreeDrawPointSamplingDistance(strokeWidth, zoomValue, profile) *
|
||||
profile.collinearityFactor
|
||||
);
|
||||
};
|
||||
|
||||
export const getFixedFreeDrawPointAction = ({
|
||||
points,
|
||||
nextPoint,
|
||||
strokeWidth,
|
||||
zoomValue,
|
||||
isFinalPoint = false,
|
||||
profile,
|
||||
}: {
|
||||
points: readonly LocalPoint[];
|
||||
nextPoint: LocalPoint;
|
||||
strokeWidth: number;
|
||||
zoomValue: ZoomValue;
|
||||
isFinalPoint?: boolean;
|
||||
profile?: FixedFreeDrawSimplificationProfile;
|
||||
}) => {
|
||||
const simplificationProfile = profile ?? FIXED_FREEDRAW_CAPTURE_PROFILE;
|
||||
const lastPoint = points[points.length - 1];
|
||||
|
||||
if (!lastPoint) {
|
||||
return "append" as const;
|
||||
}
|
||||
|
||||
if (lastPoint[0] === nextPoint[0] && lastPoint[1] === nextPoint[1]) {
|
||||
return "discard" as const;
|
||||
}
|
||||
|
||||
const samplingDistance = getFixedFreeDrawPointSamplingDistance(
|
||||
strokeWidth,
|
||||
zoomValue,
|
||||
simplificationProfile,
|
||||
);
|
||||
|
||||
if (points.length === 1) {
|
||||
return !isFinalPoint &&
|
||||
pointDistance(lastPoint, nextPoint) < samplingDistance
|
||||
? ("discard" as const)
|
||||
: ("append" as const);
|
||||
}
|
||||
|
||||
const previousPoint = points[points.length - 2];
|
||||
|
||||
if (
|
||||
isRedundantFixedFreeDrawPoint(
|
||||
previousPoint,
|
||||
lastPoint,
|
||||
nextPoint,
|
||||
strokeWidth,
|
||||
zoomValue,
|
||||
simplificationProfile,
|
||||
)
|
||||
) {
|
||||
return "replace" as const;
|
||||
}
|
||||
|
||||
if (!isFinalPoint && pointDistance(lastPoint, nextPoint) < samplingDistance) {
|
||||
return "discard" as const;
|
||||
}
|
||||
|
||||
return "append" as const;
|
||||
};
|
||||
|
||||
export const getRenderableFixedFreeDrawPoints = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
): readonly LocalPoint[] => getFixedFreeDrawPoints(element);
|
||||
@@ -69,6 +69,7 @@ export * from "./duplicate";
|
||||
export * from "./elbowArrow";
|
||||
export * from "./elementLink";
|
||||
export * from "./embeddable";
|
||||
export * from "./freedraw";
|
||||
export * from "./flowchart";
|
||||
export * from "./arrows/focus";
|
||||
export * from "./fractionalIndex";
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import {
|
||||
DEFAULT_FREE_DRAW_STROKE_SHAPE,
|
||||
getSizeFromPoints,
|
||||
randomInteger,
|
||||
getUpdatedTimestamp,
|
||||
@@ -18,6 +19,8 @@ import type {
|
||||
ElementsMap,
|
||||
ExcalidrawElbowArrowElement,
|
||||
ExcalidrawElement,
|
||||
ExcalidrawFreeDrawElement,
|
||||
FreeDrawStrokeShape,
|
||||
NonDeletedSceneElementsMap,
|
||||
} from "./types";
|
||||
|
||||
@@ -177,6 +180,30 @@ export const newElementWith = <TElement extends ExcalidrawElement>(
|
||||
};
|
||||
};
|
||||
|
||||
export const newFreeDrawElementWithStrokeShape = <
|
||||
TElement extends ExcalidrawFreeDrawElement,
|
||||
>(
|
||||
element: TElement,
|
||||
strokeShape: FreeDrawStrokeShape,
|
||||
): TElement => {
|
||||
if (strokeShape === DEFAULT_FREE_DRAW_STROKE_SHAPE) {
|
||||
if (!("strokeShape" in element)) {
|
||||
return element;
|
||||
}
|
||||
const nextElement = newElementWith(
|
||||
element,
|
||||
{} as ElementUpdate<TElement>,
|
||||
true,
|
||||
);
|
||||
delete (nextElement as Mutable<Partial<TElement>>).strokeShape;
|
||||
return nextElement;
|
||||
}
|
||||
|
||||
return newElementWith(element, {
|
||||
strokeShape,
|
||||
} as ElementUpdate<TElement>);
|
||||
};
|
||||
|
||||
/**
|
||||
* Mutates element, bumping `version`, `versionNonce`, and `updated`.
|
||||
*
|
||||
|
||||
@@ -445,6 +445,7 @@ export const newFreeDrawElement = (
|
||||
points?: ExcalidrawFreeDrawElement["points"];
|
||||
simulatePressure: boolean;
|
||||
pressures?: ExcalidrawFreeDrawElement["pressures"];
|
||||
strokeShape?: ExcalidrawFreeDrawElement["strokeShape"];
|
||||
} & ElementConstructorOpts,
|
||||
): NonDeleted<ExcalidrawFreeDrawElement> => {
|
||||
return {
|
||||
@@ -452,6 +453,7 @@ export const newFreeDrawElement = (
|
||||
points: opts.points || [],
|
||||
pressures: opts.pressures || [],
|
||||
simulatePressure: opts.simulatePressure,
|
||||
...(opts.strokeShape === "fixed" ? { strokeShape: opts.strokeShape } : {}),
|
||||
};
|
||||
};
|
||||
|
||||
|
||||
@@ -417,16 +417,27 @@ const drawElementOnCanvas = (
|
||||
case "freedraw": {
|
||||
// Draw directly to canvas
|
||||
context.save();
|
||||
context.lineJoin = "round";
|
||||
context.lineCap = "round";
|
||||
|
||||
const shapes = ShapeCache.generateElementShape(element, renderConfig);
|
||||
const isFixedStroke = element.strokeShape === "fixed";
|
||||
|
||||
for (const shape of shapes) {
|
||||
if (typeof shape === "string") {
|
||||
context.fillStyle =
|
||||
const strokeColor =
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor;
|
||||
context.fill(new Path2D(shape));
|
||||
|
||||
if (isFixedStroke) {
|
||||
context.strokeStyle = strokeColor;
|
||||
context.lineWidth = element.strokeWidth;
|
||||
context.stroke(new Path2D(shape));
|
||||
} else {
|
||||
context.fillStyle = strokeColor;
|
||||
context.fill(new Path2D(shape));
|
||||
}
|
||||
} else {
|
||||
rc.draw(shape);
|
||||
}
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { simplify } from "points-on-curve";
|
||||
import { DEFAULT_FREE_DRAW_STROKE_SHAPE } from "@excalidraw/common";
|
||||
import { getStroke } from "perfect-freehand";
|
||||
|
||||
import {
|
||||
@@ -13,6 +14,7 @@ import {
|
||||
import {
|
||||
pointFrom,
|
||||
pointDistance,
|
||||
round,
|
||||
type LocalPoint,
|
||||
pointRotateRads,
|
||||
} from "@excalidraw/math";
|
||||
@@ -52,6 +54,10 @@ import {
|
||||
isIframeLikeElement,
|
||||
isLinearElement,
|
||||
} from "./typeChecks";
|
||||
import {
|
||||
getRenderableFixedFreeDrawPoints,
|
||||
isLoopFreeDrawElement,
|
||||
} from "./freedraw";
|
||||
import { getCornerRadius, isPathALoop } from "./utils";
|
||||
import { headingForPointIsHorizontal } from "./heading";
|
||||
|
||||
@@ -244,7 +250,12 @@ export const generateRoughOptions = (
|
||||
}
|
||||
case "line":
|
||||
case "freedraw": {
|
||||
if (isPathALoop(element.points)) {
|
||||
const isLoop =
|
||||
element.type === "freedraw"
|
||||
? isLoopFreeDrawElement(element)
|
||||
: isPathALoop(element.points);
|
||||
|
||||
if (isLoop) {
|
||||
options.fillStyle = element.fillStyle;
|
||||
options.fill =
|
||||
element.backgroundColor === "transparent"
|
||||
@@ -966,7 +977,7 @@ const _generateElementShape = (
|
||||
const shapes: ElementShapes[typeof element.type] = [];
|
||||
|
||||
// (1) background fill (rc shape), optional
|
||||
if (isPathALoop(element.points)) {
|
||||
if (isLoopFreeDrawElement(element)) {
|
||||
// generate rough polygon to fill freedraw shape
|
||||
const simplifiedPoints = simplify(
|
||||
element.points as Mutable<LocalPoint[]>,
|
||||
@@ -1173,6 +1184,13 @@ export const toggleLinePolygonState = (
|
||||
|
||||
// NOTE not cached (-> for SVG export)
|
||||
const getFreeDrawSvgPath = (element: ExcalidrawFreeDrawElement) => {
|
||||
if (element.strokeShape === "fixed") {
|
||||
return getSvgPathFromFixedFreeDrawPoints(
|
||||
getRenderableFixedFreeDrawPoints(element),
|
||||
element.strokeWidth,
|
||||
) as SVGPathString;
|
||||
}
|
||||
|
||||
return getSvgPathFromStroke(
|
||||
getFreedrawOutlinePoints(element),
|
||||
) as SVGPathString;
|
||||
@@ -1181,34 +1199,243 @@ const getFreeDrawSvgPath = (element: ExcalidrawFreeDrawElement) => {
|
||||
export const getFreedrawOutlinePoints = (
|
||||
element: ExcalidrawFreeDrawElement,
|
||||
) => {
|
||||
const strokeShape = element.strokeShape ?? DEFAULT_FREE_DRAW_STROKE_SHAPE;
|
||||
const isFixedStroke = strokeShape === "fixed";
|
||||
// If input points are empty (should they ever be?) return a dot
|
||||
const inputPoints = element.simulatePressure
|
||||
const inputPoints = isFixedStroke
|
||||
? element.points.length
|
||||
? element.points
|
||||
: [[0, 0]]
|
||||
: element.simulatePressure
|
||||
? element.points
|
||||
: element.points.length
|
||||
? element.points.map(([x, y], i) => [x, y, element.pressures[i]])
|
||||
: [[0, 0, 0.5]];
|
||||
|
||||
return getStroke(inputPoints as number[][], {
|
||||
simulatePressure: element.simulatePressure,
|
||||
size: element.strokeWidth * 4.25,
|
||||
thinning: 0.6,
|
||||
simulatePressure: isFixedStroke ? false : element.simulatePressure,
|
||||
size: isFixedStroke ? element.strokeWidth : element.strokeWidth * 4.25,
|
||||
thinning: isFixedStroke ? 0 : 0.6,
|
||||
smoothing: 0.5,
|
||||
streamline: 0.5,
|
||||
easing: (t) => Math.sin((t * Math.PI) / 2), // https://easings.net/#easeOutSine
|
||||
easing: isFixedStroke ? (t) => t : (t) => Math.sin((t * Math.PI) / 2), // https://easings.net/#easeOutSine
|
||||
last: true,
|
||||
}) as [number, number][];
|
||||
};
|
||||
|
||||
const med = (A: number[], B: number[]) => {
|
||||
const med = (A: readonly number[], B: readonly number[]) => {
|
||||
return [(A[0] + B[0]) / 2, (A[1] + B[1]) / 2];
|
||||
};
|
||||
|
||||
const roundPoint = (point: readonly number[]) =>
|
||||
`${round(point[0], 2)},${round(point[1], 2)} `;
|
||||
|
||||
const averagePoint = (A: readonly number[], B: readonly number[]) =>
|
||||
`${round((A[0] + B[0]) / 2, 2)},${round((A[1] + B[1]) / 2, 2)} `;
|
||||
|
||||
const getReadonlyPointDistance = (
|
||||
pointA: readonly number[],
|
||||
pointB: readonly number[],
|
||||
) => Math.hypot(pointA[0] - pointB[0], pointA[1] - pointB[1]);
|
||||
|
||||
// Trim SVG path data so number are each two decimal points. This
|
||||
// improves SVG exports, and prevents rendering errors on points
|
||||
// with long decimals.
|
||||
const TO_FIXED_PRECISION = /(\s?[A-Z]?,?-?[0-9]*\.[0-9]{0,2})(([0-9]|e|-)*)/g;
|
||||
|
||||
const getSvgPathFromStroke = (points: number[][]): string => {
|
||||
const getSvgPathFromPoints = (
|
||||
points: ReadonlyArray<readonly number[]>,
|
||||
closed = false,
|
||||
): string => {
|
||||
const len = points.length;
|
||||
|
||||
if (len < 2) {
|
||||
return "";
|
||||
}
|
||||
|
||||
const path = points
|
||||
.slice(1)
|
||||
.map((point) => `L${roundPoint(point)}`)
|
||||
.join("");
|
||||
|
||||
return `M${roundPoint(points[0])}${path}${closed ? "Z" : ""}`;
|
||||
};
|
||||
|
||||
const FIXED_FREEDRAW_MIN_SMOOTH_ALIGNMENT = 0.6;
|
||||
const FIXED_FREEDRAW_MIN_SMOOTH_SEGMENT_LENGTH = 0.2;
|
||||
const FIXED_FREEDRAW_MIN_CORNER_ALIGNMENT = -0.25;
|
||||
const FIXED_FREEDRAW_MIN_CORNER_ROUNDING = 0.75;
|
||||
const FIXED_FREEDRAW_MAX_CORNER_ROUNDING = 6;
|
||||
const FIXED_FREEDRAW_CORNER_ROUNDING_FACTOR = 0.35;
|
||||
const FIXED_FREEDRAW_CORNER_ROUNDING_WIDTH_FACTOR = 1.5;
|
||||
const FIXED_FREEDRAW_MIN_TERMINAL_STUB = 0.75;
|
||||
const FIXED_FREEDRAW_MAX_TERMINAL_STUB = 2.5;
|
||||
const FIXED_FREEDRAW_TERMINAL_STUB_WIDTH_FACTOR = 1.5;
|
||||
|
||||
const shouldSmoothFixedFreeDrawPoint = (
|
||||
previousPoint: readonly number[],
|
||||
currentPoint: readonly number[],
|
||||
nextPoint: readonly number[],
|
||||
) => {
|
||||
const previousDeltaX = currentPoint[0] - previousPoint[0];
|
||||
const previousDeltaY = currentPoint[1] - previousPoint[1];
|
||||
const nextDeltaX = nextPoint[0] - currentPoint[0];
|
||||
const nextDeltaY = nextPoint[1] - currentPoint[1];
|
||||
const previousSegmentLength = Math.hypot(previousDeltaX, previousDeltaY);
|
||||
const nextSegmentLength = Math.hypot(nextDeltaX, nextDeltaY);
|
||||
|
||||
if (
|
||||
previousSegmentLength < FIXED_FREEDRAW_MIN_SMOOTH_SEGMENT_LENGTH ||
|
||||
nextSegmentLength < FIXED_FREEDRAW_MIN_SMOOTH_SEGMENT_LENGTH
|
||||
) {
|
||||
return false;
|
||||
}
|
||||
|
||||
const alignment =
|
||||
(previousDeltaX * nextDeltaX + previousDeltaY * nextDeltaY) /
|
||||
(previousSegmentLength * nextSegmentLength);
|
||||
|
||||
return alignment >= FIXED_FREEDRAW_MIN_SMOOTH_ALIGNMENT;
|
||||
};
|
||||
|
||||
const getFixedFreeDrawRoundedCorner = (
|
||||
previousPoint: readonly number[],
|
||||
currentPoint: readonly number[],
|
||||
nextPoint: readonly number[],
|
||||
strokeWidth: number,
|
||||
) => {
|
||||
const previousDeltaX = currentPoint[0] - previousPoint[0];
|
||||
const previousDeltaY = currentPoint[1] - previousPoint[1];
|
||||
const nextDeltaX = nextPoint[0] - currentPoint[0];
|
||||
const nextDeltaY = nextPoint[1] - currentPoint[1];
|
||||
const previousSegmentLength = Math.hypot(previousDeltaX, previousDeltaY);
|
||||
const nextSegmentLength = Math.hypot(nextDeltaX, nextDeltaY);
|
||||
|
||||
if (!previousSegmentLength || !nextSegmentLength) {
|
||||
return null;
|
||||
}
|
||||
|
||||
const alignment =
|
||||
(previousDeltaX * nextDeltaX + previousDeltaY * nextDeltaY) /
|
||||
(previousSegmentLength * nextSegmentLength);
|
||||
|
||||
if (
|
||||
alignment >= FIXED_FREEDRAW_MIN_SMOOTH_ALIGNMENT ||
|
||||
alignment <= FIXED_FREEDRAW_MIN_CORNER_ALIGNMENT
|
||||
) {
|
||||
return null;
|
||||
}
|
||||
|
||||
const cornerRounding = Math.min(
|
||||
Math.max(
|
||||
strokeWidth * FIXED_FREEDRAW_CORNER_ROUNDING_WIDTH_FACTOR,
|
||||
FIXED_FREEDRAW_MIN_CORNER_ROUNDING,
|
||||
),
|
||||
previousSegmentLength * FIXED_FREEDRAW_CORNER_ROUNDING_FACTOR,
|
||||
nextSegmentLength * FIXED_FREEDRAW_CORNER_ROUNDING_FACTOR,
|
||||
FIXED_FREEDRAW_MAX_CORNER_ROUNDING,
|
||||
);
|
||||
|
||||
if (!cornerRounding) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return {
|
||||
entryPoint: [
|
||||
currentPoint[0] - (previousDeltaX / previousSegmentLength) * cornerRounding,
|
||||
currentPoint[1] - (previousDeltaY / previousSegmentLength) * cornerRounding,
|
||||
] as const,
|
||||
exitPoint: [
|
||||
currentPoint[0] + (nextDeltaX / nextSegmentLength) * cornerRounding,
|
||||
currentPoint[1] + (nextDeltaY / nextSegmentLength) * cornerRounding,
|
||||
] as const,
|
||||
};
|
||||
};
|
||||
|
||||
const getFixedFreeDrawTerminalStubThreshold = (strokeWidth: number) =>
|
||||
Math.min(
|
||||
Math.max(
|
||||
strokeWidth * FIXED_FREEDRAW_TERMINAL_STUB_WIDTH_FACTOR,
|
||||
FIXED_FREEDRAW_MIN_TERMINAL_STUB,
|
||||
),
|
||||
FIXED_FREEDRAW_MAX_TERMINAL_STUB,
|
||||
);
|
||||
|
||||
const getSvgPathFromFixedFreeDrawPoints = (
|
||||
points: ReadonlyArray<readonly number[]>,
|
||||
strokeWidth: number,
|
||||
): string => {
|
||||
const len = points.length;
|
||||
|
||||
if (len < 2) {
|
||||
return "";
|
||||
}
|
||||
|
||||
if (len === 2) {
|
||||
return `M${roundPoint(points[0])}L${roundPoint(points[1])}`;
|
||||
}
|
||||
|
||||
let path = `M${roundPoint(points[0])}`;
|
||||
const lastPoint = points[len - 1];
|
||||
let endsAtLastPoint = false;
|
||||
|
||||
for (let index = 1; index < len - 1; index++) {
|
||||
const previousPoint = points[index - 1];
|
||||
const currentPoint = points[index];
|
||||
const nextPoint = points[index + 1];
|
||||
const isLastCurveSegment = index === len - 2;
|
||||
const terminalStubThreshold = getFixedFreeDrawTerminalStubThreshold(
|
||||
strokeWidth,
|
||||
);
|
||||
const shouldSmooth = shouldSmoothFixedFreeDrawPoint(
|
||||
previousPoint,
|
||||
currentPoint,
|
||||
nextPoint,
|
||||
);
|
||||
const roundedCorner = shouldSmooth
|
||||
? null
|
||||
: getFixedFreeDrawRoundedCorner(
|
||||
previousPoint,
|
||||
currentPoint,
|
||||
nextPoint,
|
||||
strokeWidth,
|
||||
);
|
||||
const shouldCollapseSmoothTerminalStub =
|
||||
isLastCurveSegment &&
|
||||
shouldSmooth &&
|
||||
getReadonlyPointDistance(currentPoint, nextPoint) / 2 <=
|
||||
terminalStubThreshold;
|
||||
const shouldCollapseRoundedTerminalStub =
|
||||
isLastCurveSegment &&
|
||||
!!roundedCorner &&
|
||||
getReadonlyPointDistance(roundedCorner.exitPoint, lastPoint) <=
|
||||
terminalStubThreshold;
|
||||
|
||||
path += shouldSmooth
|
||||
? `Q${roundPoint(currentPoint)}${
|
||||
shouldCollapseSmoothTerminalStub
|
||||
? roundPoint(lastPoint)
|
||||
: averagePoint(currentPoint, nextPoint)
|
||||
}`
|
||||
: roundedCorner
|
||||
? `L${roundPoint(roundedCorner.entryPoint)}Q${roundPoint(
|
||||
currentPoint,
|
||||
)}${
|
||||
shouldCollapseRoundedTerminalStub
|
||||
? roundPoint(lastPoint)
|
||||
: roundPoint(roundedCorner.exitPoint)
|
||||
}`
|
||||
: `L${roundPoint(currentPoint)}`;
|
||||
endsAtLastPoint =
|
||||
shouldCollapseSmoothTerminalStub || shouldCollapseRoundedTerminalStub;
|
||||
}
|
||||
|
||||
return endsAtLastPoint ? path : `${path}L${roundPoint(lastPoint)}`;
|
||||
};
|
||||
|
||||
const getSvgPathFromStroke = (
|
||||
points: ReadonlyArray<readonly number[]>,
|
||||
): string => {
|
||||
if (!points.length) {
|
||||
return "";
|
||||
}
|
||||
|
||||
@@ -26,6 +26,7 @@ export type PointerType = "mouse" | "pen" | "touch";
|
||||
export type StrokeRoundness = "round" | "sharp";
|
||||
export type RoundnessType = ValueOf<typeof ROUNDNESS>;
|
||||
export type StrokeStyle = "solid" | "dashed" | "dotted";
|
||||
export type FreeDrawStrokeShape = "variable" | "fixed";
|
||||
export type TextAlign = typeof TEXT_ALIGN[keyof typeof TEXT_ALIGN];
|
||||
|
||||
type VerticalAlignKeys = keyof typeof VERTICAL_ALIGN;
|
||||
@@ -390,6 +391,7 @@ export type ExcalidrawFreeDrawElement = _ExcalidrawElementBase &
|
||||
points: readonly LocalPoint[];
|
||||
pressures: readonly number[];
|
||||
simulatePressure: boolean;
|
||||
strokeShape?: FreeDrawStrokeShape;
|
||||
}>;
|
||||
|
||||
export type FileId = string & { _brand: "FileId" };
|
||||
|
||||
@@ -6,7 +6,11 @@ import type { LocalPoint } from "@excalidraw/math";
|
||||
|
||||
import { getElementAbsoluteCoords, getElementBounds } from "../src/bounds";
|
||||
|
||||
import type { ExcalidrawElement, ExcalidrawLinearElement } from "../src/types";
|
||||
import type {
|
||||
ExcalidrawElement,
|
||||
ExcalidrawFreeDrawElement,
|
||||
ExcalidrawLinearElement,
|
||||
} from "../src/types";
|
||||
|
||||
const _ce = ({
|
||||
x,
|
||||
@@ -117,6 +121,31 @@ describe("getElementBounds", () => {
|
||||
expect(y2).toEqual(42.90569415042095);
|
||||
});
|
||||
|
||||
it("fixed freedraw", () => {
|
||||
const element = {
|
||||
..._ce({
|
||||
x: 40,
|
||||
y: 30,
|
||||
w: 10,
|
||||
h: 0,
|
||||
a: 0,
|
||||
t: "freedraw",
|
||||
}),
|
||||
strokeWidth: 8,
|
||||
points: [pointFrom<LocalPoint>(0, 0), pointFrom<LocalPoint>(10, 0)],
|
||||
pressures: [],
|
||||
simulatePressure: true,
|
||||
strokeShape: "fixed",
|
||||
} as unknown as ExcalidrawFreeDrawElement;
|
||||
|
||||
const [x1, y1, x2, y2] = getElementBounds(element, arrayToMap([element]));
|
||||
|
||||
expect(x1).toEqual(36);
|
||||
expect(y1).toEqual(26);
|
||||
expect(x2).toEqual(54);
|
||||
expect(y2).toEqual(34);
|
||||
});
|
||||
|
||||
it("curved line", () => {
|
||||
const element = {
|
||||
..._ce({
|
||||
|
||||
@@ -0,0 +1,160 @@
|
||||
import { pointFrom } from "@excalidraw/math";
|
||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||
import { vi } from "vitest";
|
||||
|
||||
vi.mock("perfect-freehand", () => ({
|
||||
getStroke: vi.fn(() => []),
|
||||
}));
|
||||
|
||||
import { getStroke } from "perfect-freehand";
|
||||
|
||||
import { getFreedrawOutlinePoints, ShapeCache } from "../src/shape";
|
||||
|
||||
describe("freedraw stroke shape", () => {
|
||||
beforeEach(() => {
|
||||
vi.mocked(getStroke).mockClear();
|
||||
ShapeCache.destroy();
|
||||
});
|
||||
|
||||
it("renders fixed strokes from the centerline path", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10), pointFrom(20, 15)],
|
||||
});
|
||||
|
||||
const shapes = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(shapes).toEqual([expect.any(String)]);
|
||||
expect(shapes[0]).not.toContain("Z");
|
||||
expect(vi.mocked(getStroke)).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("rounds fixed stroke corners without flattening them", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
strokeWidth: 1,
|
||||
points: [pointFrom(0, 0), pointFrom(10, 0), pointFrom(10, 10)],
|
||||
});
|
||||
|
||||
const [path] = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(path).toBe("M0,0 L8.5,0 Q10,0 10,1.5 L10,10 ");
|
||||
});
|
||||
|
||||
it("does not round fixed stroke hairpin turns", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
strokeWidth: 1,
|
||||
points: [pointFrom(0, 0), pointFrom(10, 0), pointFrom(9, 1)],
|
||||
});
|
||||
|
||||
const [path] = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(path).toBe("M0,0 L10,0 L9,1 ");
|
||||
});
|
||||
|
||||
it("curves directly to the endpoint for tiny final smooth segments", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
strokeWidth: 1,
|
||||
points: [pointFrom(0, 0), pointFrom(0.5, 0.1), pointFrom(0.8, 0.3)],
|
||||
});
|
||||
|
||||
const [path] = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(path).toBe("M0,0 Q0.5,0.1 0.8,0.3 ");
|
||||
});
|
||||
|
||||
it("curves directly to the endpoint for tiny final rounded corners", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
strokeWidth: 1,
|
||||
points: [pointFrom(0, 0), pointFrom(10, 0), pointFrom(10, 1)],
|
||||
});
|
||||
|
||||
const [path] = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(path).toBe("M0,0 L9.65,0 Q10,0 10,1 ");
|
||||
});
|
||||
|
||||
it("smooths dense fixed stroke points without dropping them", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
points: [
|
||||
pointFrom(0, 0),
|
||||
pointFrom(0.3, 0.1),
|
||||
pointFrom(0.6, 0.35),
|
||||
pointFrom(1, 0.9),
|
||||
],
|
||||
});
|
||||
|
||||
const [path] = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(path).toContain("Q0.3,0.1 ");
|
||||
expect(path).toContain("Q0.6,0.35 ");
|
||||
});
|
||||
|
||||
it("drops synthetic loop closure for fixed strokes", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 0), pointFrom(0, 0)],
|
||||
});
|
||||
|
||||
const [path] = ShapeCache.generateElementShape(element, null);
|
||||
|
||||
expect(path).toBe("M0,0 L10,0 ");
|
||||
});
|
||||
|
||||
it("uses fixed perfect-freehand settings for fixed strokes", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
strokeWidth: 8,
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10), pointFrom(20, 15)],
|
||||
});
|
||||
|
||||
getFreedrawOutlinePoints(element);
|
||||
|
||||
expect(vi.mocked(getStroke)).toHaveBeenCalledWith(
|
||||
element.points,
|
||||
expect.objectContaining({
|
||||
simulatePressure: false,
|
||||
size: element.strokeWidth,
|
||||
thinning: 0,
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it("keeps pressure-aware perfect-freehand settings for variable strokes", () => {
|
||||
const element = API.createElement({
|
||||
type: "freedraw",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10), pointFrom(20, 15)],
|
||||
});
|
||||
|
||||
getFreedrawOutlinePoints({
|
||||
...element,
|
||||
simulatePressure: false,
|
||||
pressures: [0.2, 0.8, 0.4],
|
||||
});
|
||||
|
||||
expect(vi.mocked(getStroke)).toHaveBeenCalledWith(
|
||||
[
|
||||
[0, 0, 0.2],
|
||||
[10, 10, 0.8],
|
||||
[20, 15, 0.4],
|
||||
],
|
||||
expect.objectContaining({
|
||||
simulatePressure: false,
|
||||
size: element.strokeWidth * 4.25,
|
||||
thinning: 0.6,
|
||||
}),
|
||||
);
|
||||
});
|
||||
});
|
||||
@@ -40,7 +40,6 @@ import {
|
||||
ZoomResetIcon,
|
||||
} from "../components/icons";
|
||||
import { setCursor } from "../cursor";
|
||||
import { constrainScrollState } from "../scene/scrollConstraints";
|
||||
|
||||
import { t } from "../i18n";
|
||||
import { getNormalizedZoom } from "../scene";
|
||||
@@ -52,8 +51,6 @@ import { register } from "./register";
|
||||
|
||||
import type { AppState, Offsets } from "../types";
|
||||
|
||||
const canUseZoomActions = (appState: AppState) => !appState.scrollConstraints;
|
||||
|
||||
export const actionChangeViewBackgroundColor = register<Partial<AppState>>({
|
||||
name: "changeViewBackgroundColor",
|
||||
label: "labels.canvasBackground",
|
||||
@@ -142,7 +139,7 @@ export const actionZoomIn = register({
|
||||
trackEvent: { category: "canvas" },
|
||||
perform: (_elements, appState, _, app) => {
|
||||
return {
|
||||
appState: constrainScrollState({
|
||||
appState: {
|
||||
...appState,
|
||||
...getStateForZoom(
|
||||
{
|
||||
@@ -153,7 +150,7 @@ export const actionZoomIn = register({
|
||||
appState,
|
||||
),
|
||||
userToFollow: null,
|
||||
}),
|
||||
},
|
||||
captureUpdate: CaptureUpdateAction.EVENTUALLY,
|
||||
};
|
||||
},
|
||||
@@ -183,7 +180,7 @@ export const actionZoomOut = register({
|
||||
trackEvent: { category: "canvas" },
|
||||
perform: (_elements, appState, _, app) => {
|
||||
return {
|
||||
appState: constrainScrollState({
|
||||
appState: {
|
||||
...appState,
|
||||
...getStateForZoom(
|
||||
{
|
||||
@@ -194,7 +191,7 @@ export const actionZoomOut = register({
|
||||
appState,
|
||||
),
|
||||
userToFollow: null,
|
||||
}),
|
||||
},
|
||||
captureUpdate: CaptureUpdateAction.EVENTUALLY,
|
||||
};
|
||||
},
|
||||
@@ -246,7 +243,6 @@ export const actionResetZoom = register({
|
||||
className="reset-zoom-button zoom-button"
|
||||
title={t("buttons.resetZoom")}
|
||||
aria-label={t("buttons.resetZoom")}
|
||||
disabled={!canUseZoomActions(appState)}
|
||||
onClick={() => {
|
||||
updateData(null);
|
||||
}}
|
||||
@@ -255,7 +251,6 @@ export const actionResetZoom = register({
|
||||
</ToolButton>
|
||||
</Tooltip>
|
||||
),
|
||||
predicate: (_elements, appState) => canUseZoomActions(appState),
|
||||
keyTest: (event) =>
|
||||
(event.code === CODES.ZERO || event.code === CODES.NUM_ZERO) &&
|
||||
(event[KEYS.CTRL_OR_CMD] || event.shiftKey),
|
||||
@@ -279,7 +274,7 @@ const zoomValueToFitBoundsOnViewport = (
|
||||
return Math.min(adjustedZoomValue, 1);
|
||||
};
|
||||
|
||||
export function resolveViewportForBounds({
|
||||
export const zoomToFitBounds = ({
|
||||
bounds,
|
||||
appState,
|
||||
canvasOffsets,
|
||||
@@ -297,7 +292,7 @@ export function resolveViewportForBounds({
|
||||
viewportZoomFactor?: number;
|
||||
minZoom?: number;
|
||||
maxZoom?: number;
|
||||
}) {
|
||||
}) => {
|
||||
viewportZoomFactor = clamp(viewportZoomFactor, MIN_ZOOM, MAX_ZOOM);
|
||||
|
||||
const [x1, y1, x2, y2] = bounds;
|
||||
@@ -350,58 +345,12 @@ export function resolveViewportForBounds({
|
||||
zoom: { value: newZoomValue },
|
||||
});
|
||||
|
||||
return {
|
||||
bounds,
|
||||
scrollX: centerScroll.scrollX,
|
||||
scrollY: centerScroll.scrollY,
|
||||
zoom: { value: newZoomValue },
|
||||
viewportZoomFactor,
|
||||
viewportDimensions: {
|
||||
width: appState.width,
|
||||
height: appState.height,
|
||||
},
|
||||
effectiveViewportDimensions: {
|
||||
width: effectiveCanvasWidth,
|
||||
height: effectiveCanvasHeight,
|
||||
},
|
||||
};
|
||||
}
|
||||
|
||||
export const zoomToFitBounds = ({
|
||||
bounds,
|
||||
appState,
|
||||
canvasOffsets,
|
||||
fitToViewport = false,
|
||||
viewportZoomFactor = 1,
|
||||
minZoom = -Infinity,
|
||||
maxZoom = Infinity,
|
||||
}: {
|
||||
bounds: SceneBounds;
|
||||
canvasOffsets?: Offsets;
|
||||
appState: Readonly<AppState>;
|
||||
/** whether to fit content to viewport (beyond >100%) */
|
||||
fitToViewport: boolean;
|
||||
/** zoom content to cover X of the viewport, when fitToViewport=true */
|
||||
viewportZoomFactor?: number;
|
||||
minZoom?: number;
|
||||
maxZoom?: number;
|
||||
}) => {
|
||||
const resolvedViewport = resolveViewportForBounds({
|
||||
bounds,
|
||||
appState,
|
||||
canvasOffsets,
|
||||
fitToViewport,
|
||||
viewportZoomFactor,
|
||||
minZoom,
|
||||
maxZoom,
|
||||
});
|
||||
|
||||
return {
|
||||
appState: {
|
||||
...appState,
|
||||
scrollX: resolvedViewport.scrollX,
|
||||
scrollY: resolvedViewport.scrollY,
|
||||
zoom: resolvedViewport.zoom,
|
||||
scrollX: centerScroll.scrollX,
|
||||
scrollY: centerScroll.scrollY,
|
||||
zoom: { value: newZoomValue },
|
||||
},
|
||||
captureUpdate: CaptureUpdateAction.EVENTUALLY,
|
||||
};
|
||||
@@ -459,7 +408,6 @@ export const actionZoomToFitSelectionInViewport = register({
|
||||
canvasOffsets: app.getEditorUIOffsets(),
|
||||
});
|
||||
},
|
||||
predicate: (_elements, appState) => canUseZoomActions(appState),
|
||||
// NOTE shift-2 should have been assigned actionZoomToFitSelection.
|
||||
// TBD on how proceed
|
||||
keyTest: (event) =>
|
||||
@@ -486,7 +434,6 @@ export const actionZoomToFitSelection = register({
|
||||
canvasOffsets: app.getEditorUIOffsets(),
|
||||
});
|
||||
},
|
||||
predicate: (_elements, appState) => canUseZoomActions(appState),
|
||||
// NOTE this action should use shift-2 per figma, alas
|
||||
keyTest: (event) =>
|
||||
event.code === CODES.THREE &&
|
||||
@@ -511,7 +458,6 @@ export const actionZoomToFit = register({
|
||||
fitToViewport: false,
|
||||
canvasOffsets: app.getEditorUIOffsets(),
|
||||
}),
|
||||
predicate: (_elements, appState) => canUseZoomActions(appState),
|
||||
keyTest: (event) =>
|
||||
event.code === CODES.ONE &&
|
||||
event.shiftKey &&
|
||||
|
||||
@@ -2,6 +2,7 @@ import { pointFrom } from "@excalidraw/math";
|
||||
|
||||
import { bindOrUnbindBindingElement } from "@excalidraw/element/binding";
|
||||
import {
|
||||
isLoopFreeDrawElement,
|
||||
isValidPolygon,
|
||||
LinearElementEditor,
|
||||
newElementWith,
|
||||
@@ -242,7 +243,11 @@ export const actionFinalize = register<FormData>({
|
||||
// If the multi point line closes the loop,
|
||||
// set the last point to first point.
|
||||
// This ensures that loop remains closed at different scales.
|
||||
const isLoop = isPathALoop(element.points, appState.zoom.value);
|
||||
const isLoop = isLineElement(element)
|
||||
? isPathALoop(element.points, appState.zoom.value)
|
||||
: isFreeDrawElement(element)
|
||||
? isLoopFreeDrawElement(element, appState.zoom.value)
|
||||
: false;
|
||||
|
||||
if (isLoop && (isLineElement(element) || isFreeDrawElement(element))) {
|
||||
const linePoints = element.points;
|
||||
|
||||
@@ -49,18 +49,9 @@ import { register } from "./register";
|
||||
|
||||
import type { AppClassProperties, AppState } from "../types";
|
||||
|
||||
const allElementsInSameGroup = (
|
||||
elements: readonly ExcalidrawElement[],
|
||||
editingGroupId: AppState["editingGroupId"],
|
||||
) => {
|
||||
const allElementsInSameGroup = (elements: readonly ExcalidrawElement[]) => {
|
||||
if (elements.length >= 2) {
|
||||
const editingGroupIndex = editingGroupId
|
||||
? elements[0].groupIds.indexOf(editingGroupId)
|
||||
: -1;
|
||||
const groupIds =
|
||||
editingGroupIndex > -1
|
||||
? elements[0].groupIds.slice(0, editingGroupIndex)
|
||||
: elements[0].groupIds;
|
||||
const groupIds = elements[0].groupIds;
|
||||
for (const groupId of groupIds) {
|
||||
if (
|
||||
elements.reduce(
|
||||
@@ -87,7 +78,7 @@ const enableActionGroup = (
|
||||
|
||||
return (
|
||||
selectedElements.length >= 2 &&
|
||||
!allElementsInSameGroup(selectedElements, appState.editingGroupId) &&
|
||||
!allElementsInSameGroup(selectedElements) &&
|
||||
!frameAndChildrenSelectedTogether(selectedElements)
|
||||
);
|
||||
};
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { queryByTestId } from "@testing-library/react";
|
||||
import { pointFrom } from "@excalidraw/math";
|
||||
|
||||
import {
|
||||
COLOR_PALETTE,
|
||||
@@ -10,7 +11,7 @@ import {
|
||||
import { Excalidraw } from "../index";
|
||||
import { API } from "../tests/helpers/api";
|
||||
import { UI } from "../tests/helpers/ui";
|
||||
import { render } from "../tests/test-utils";
|
||||
import { act, render } from "../tests/test-utils";
|
||||
|
||||
describe("element locking", () => {
|
||||
beforeEach(async () => {
|
||||
@@ -80,6 +81,20 @@ describe("element locking", () => {
|
||||
const centerTextAlign = queryByTestId(document.body, `align-right`);
|
||||
expect(centerTextAlign).toBeChecked();
|
||||
});
|
||||
|
||||
it("should show the active freedraw stroke type", () => {
|
||||
UI.clickTool("freedraw");
|
||||
|
||||
API.setAppState({
|
||||
currentItemStrokeShape: "fixed",
|
||||
});
|
||||
|
||||
const fixedStrokeShape = queryByTestId(
|
||||
document.body,
|
||||
"strokeShape-fixed",
|
||||
);
|
||||
expect(fixedStrokeShape).toBeChecked();
|
||||
});
|
||||
});
|
||||
|
||||
describe("properties when elements selected", () => {
|
||||
@@ -144,6 +159,9 @@ describe("element locking", () => {
|
||||
expect(
|
||||
queryByTestId(document.body, `strokeWidth-thin`),
|
||||
).not.toBeChecked();
|
||||
expect(
|
||||
queryByTestId(document.body, `strokeWidth-medium`),
|
||||
).not.toBeChecked();
|
||||
expect(
|
||||
queryByTestId(document.body, `strokeWidth-bold`),
|
||||
).not.toBeChecked();
|
||||
@@ -159,6 +177,7 @@ describe("element locking", () => {
|
||||
});
|
||||
const text = API.createElement({
|
||||
type: "text",
|
||||
strokeWidth: STROKE_WIDTH.bold,
|
||||
fontFamily: FONT_FAMILY["Comic Shanns"],
|
||||
});
|
||||
API.setElements([rect, text]);
|
||||
@@ -169,5 +188,35 @@ describe("element locking", () => {
|
||||
"active",
|
||||
);
|
||||
});
|
||||
|
||||
it("should highlight the fixed freedraw stroke type for selected elements", () => {
|
||||
const freedraw = API.createElement({
|
||||
type: "freedraw",
|
||||
strokeShape: "fixed",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10), pointFrom(20, 15)],
|
||||
});
|
||||
API.setElements([freedraw]);
|
||||
API.setSelectedElements([freedraw]);
|
||||
|
||||
const fixedStrokeShape = queryByTestId(
|
||||
document.body,
|
||||
"strokeShape-fixed",
|
||||
);
|
||||
expect(fixedStrokeShape).toBeChecked();
|
||||
});
|
||||
|
||||
it("should apply fixed freedraw stroke type to newly drawn strokes", () => {
|
||||
UI.clickTool("freedraw");
|
||||
|
||||
act(() => {
|
||||
queryByTestId(document.body, "strokeShape-fixed")?.click();
|
||||
});
|
||||
|
||||
const freedraw = UI.createElement("freedraw", {
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10), pointFrom(20, 15)],
|
||||
});
|
||||
|
||||
expect(freedraw.strokeShape).toBe("fixed");
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
@@ -3,6 +3,7 @@ import { pointFrom } from "@excalidraw/math";
|
||||
import { useEffect, useMemo, useRef, useState } from "react";
|
||||
|
||||
import {
|
||||
DEFAULT_FREE_DRAW_STROKE_SHAPE,
|
||||
DEFAULT_ELEMENT_BACKGROUND_COLOR_PALETTE,
|
||||
DEFAULT_ELEMENT_BACKGROUND_PICKS,
|
||||
DEFAULT_ELEMENT_STROKE_COLOR_PALETTE,
|
||||
@@ -36,6 +37,7 @@ import {
|
||||
import { LinearElementEditor } from "@excalidraw/element";
|
||||
|
||||
import { newElementWith } from "@excalidraw/element";
|
||||
import { newFreeDrawElementWithStrokeShape } from "@excalidraw/element";
|
||||
import { getArrowheadForPicker } from "@excalidraw/element";
|
||||
|
||||
import {
|
||||
@@ -47,6 +49,7 @@ import {
|
||||
isArrowElement,
|
||||
isBoundToContainer,
|
||||
isElbowArrow,
|
||||
isFreeDrawElement,
|
||||
isLinearElement,
|
||||
isLineElement,
|
||||
isTextElement,
|
||||
@@ -70,6 +73,7 @@ import type {
|
||||
ElementsMap,
|
||||
ExcalidrawBindableElement,
|
||||
ExcalidrawElement,
|
||||
ExcalidrawFreeDrawElement,
|
||||
ExcalidrawLinearElement,
|
||||
ExcalidrawTextElement,
|
||||
FontFamilyValues,
|
||||
@@ -105,8 +109,11 @@ import {
|
||||
SloppinessArtistIcon,
|
||||
SloppinessCartoonistIcon,
|
||||
StrokeWidthBaseIcon,
|
||||
StrokeWidthMediumIcon,
|
||||
StrokeWidthBoldIcon,
|
||||
StrokeWidthExtraBoldIcon,
|
||||
StrokeShapeFixedIcon,
|
||||
StrokeShapeVariableIcon,
|
||||
FontSizeSmallIcon,
|
||||
FontSizeMediumIcon,
|
||||
FontSizeLargeIcon,
|
||||
@@ -187,6 +194,29 @@ export const changeProperty = (
|
||||
});
|
||||
};
|
||||
|
||||
const getFreeDrawStrokeShape = (item: {
|
||||
strokeShape?: ExcalidrawFreeDrawElement["strokeShape"];
|
||||
currentItemStrokeShape?: AppState["currentItemStrokeShape"];
|
||||
}) =>
|
||||
item.strokeShape ??
|
||||
item.currentItemStrokeShape ??
|
||||
DEFAULT_FREE_DRAW_STROKE_SHAPE;
|
||||
|
||||
const getAppStateWithCurrentItemStrokeShape = (
|
||||
appState: AppState,
|
||||
strokeShape: NonNullable<ExcalidrawFreeDrawElement["strokeShape"]>,
|
||||
) => {
|
||||
// if (strokeShape === DEFAULT_FREE_DRAW_STROKE_SHAPE) {
|
||||
// const { currentItemStrokeShape, ...nextAppState } = appState;
|
||||
// return nextAppState;
|
||||
// }
|
||||
|
||||
return {
|
||||
...appState,
|
||||
currentItemStrokeShape: strokeShape,
|
||||
};
|
||||
};
|
||||
|
||||
export const getFormValue = function <T extends Primitive>(
|
||||
elements: readonly ExcalidrawElement[],
|
||||
app: AppClassProperties,
|
||||
@@ -574,6 +604,12 @@ export const actionChangeStrokeWidth = register<
|
||||
icon: StrokeWidthBaseIcon,
|
||||
testId: "strokeWidth-thin",
|
||||
},
|
||||
{
|
||||
value: STROKE_WIDTH.medium,
|
||||
text: t("labels.medium"),
|
||||
icon: StrokeWidthMediumIcon,
|
||||
testId: "strokeWidth-medium",
|
||||
},
|
||||
{
|
||||
value: STROKE_WIDTH.bold,
|
||||
text: t("labels.bold"),
|
||||
@@ -602,6 +638,60 @@ export const actionChangeStrokeWidth = register<
|
||||
),
|
||||
});
|
||||
|
||||
export const actionChangeStrokeShape = register<
|
||||
NonNullable<ExcalidrawFreeDrawElement["strokeShape"]>
|
||||
>({
|
||||
name: "changeStrokeShape",
|
||||
label: "labels.strokeShape",
|
||||
trackEvent: false,
|
||||
perform: (elements, appState, value) => {
|
||||
invariant(value, "actionChangeStrokeShape: value must be defined");
|
||||
return {
|
||||
elements: changeProperty(elements, appState, (el) =>
|
||||
isFreeDrawElement(el)
|
||||
? newFreeDrawElementWithStrokeShape(el, value)
|
||||
: el,
|
||||
),
|
||||
appState: getAppStateWithCurrentItemStrokeShape(appState, value),
|
||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||
};
|
||||
},
|
||||
PanelComponent: ({ elements, appState, updateData, app }) => (
|
||||
<fieldset>
|
||||
<legend>{t("labels.strokeShape")}</legend>
|
||||
<div className="buttonList">
|
||||
<RadioSelection
|
||||
group="stroke-shape"
|
||||
options={[
|
||||
{
|
||||
value: "variable",
|
||||
text: t("labels.strokeShape_variable"),
|
||||
icon: StrokeShapeVariableIcon,
|
||||
testId: "strokeShape-variable",
|
||||
},
|
||||
{
|
||||
value: "fixed",
|
||||
text: t("labels.strokeShape_fixed"),
|
||||
icon: StrokeShapeFixedIcon,
|
||||
testId: "strokeShape-fixed",
|
||||
},
|
||||
]}
|
||||
value={getFormValue(
|
||||
elements,
|
||||
app,
|
||||
(element) =>
|
||||
getFreeDrawStrokeShape(element as ExcalidrawFreeDrawElement),
|
||||
isFreeDrawElement,
|
||||
(hasSelection) =>
|
||||
hasSelection ? null : getFreeDrawStrokeShape(appState),
|
||||
)}
|
||||
onChange={(value) => updateData(value)}
|
||||
/>
|
||||
</div>
|
||||
</fieldset>
|
||||
),
|
||||
});
|
||||
|
||||
export const actionChangeSloppiness = register<ExcalidrawElement["roughness"]>({
|
||||
name: "changeSloppiness",
|
||||
label: "labels.sloppiness",
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import {
|
||||
DEFAULT_FREE_DRAW_STROKE_SHAPE,
|
||||
DEFAULT_FONT_SIZE,
|
||||
DEFAULT_FONT_FAMILY,
|
||||
DEFAULT_TEXT_ALIGN,
|
||||
@@ -10,6 +11,7 @@ import {
|
||||
import { newElementWith } from "@excalidraw/element";
|
||||
|
||||
import {
|
||||
isFreeDrawElement,
|
||||
hasBoundTextElement,
|
||||
canApplyRoundnessTypeToElement,
|
||||
getDefaultRoundnessTypeForElement,
|
||||
@@ -18,6 +20,7 @@ import {
|
||||
isExcalidrawElement,
|
||||
isTextElement,
|
||||
} from "@excalidraw/element";
|
||||
import { newFreeDrawElementWithStrokeShape } from "@excalidraw/element";
|
||||
|
||||
import {
|
||||
getBoundTextElement,
|
||||
@@ -154,6 +157,17 @@ export const actionPasteStyles = register({
|
||||
});
|
||||
}
|
||||
|
||||
if (
|
||||
isFreeDrawElement(newElement) &&
|
||||
isFreeDrawElement(elementStylesToCopyFrom)
|
||||
) {
|
||||
newElement = newFreeDrawElementWithStrokeShape(
|
||||
newElement,
|
||||
elementStylesToCopyFrom.strokeShape ??
|
||||
DEFAULT_FREE_DRAW_STROKE_SHAPE,
|
||||
);
|
||||
}
|
||||
|
||||
if (isFrameLikeElement(element)) {
|
||||
newElement = newElementWith(newElement, {
|
||||
roundness: null,
|
||||
|
||||
@@ -53,5 +53,8 @@ export const actionToggleSearchMenu = register({
|
||||
};
|
||||
},
|
||||
checked: (appState: AppState) => appState.gridModeEnabled,
|
||||
predicate: (element, appState, props) => {
|
||||
return props.gridModeEnabled === undefined;
|
||||
},
|
||||
keyTest: (event) => event[KEYS.CTRL_OR_CMD] && event.key === KEYS.F,
|
||||
});
|
||||
|
||||
@@ -95,13 +95,6 @@ export class ActionManager {
|
||||
(action.name in canvasActions
|
||||
? canvasActions[action.name as keyof typeof canvasActions]
|
||||
: true) &&
|
||||
(!action.predicate ||
|
||||
action.predicate(
|
||||
this.getElementsIncludingDeleted(),
|
||||
this.getAppState(),
|
||||
this.app.props,
|
||||
this.app,
|
||||
)) &&
|
||||
action.keyTest &&
|
||||
action.keyTest(
|
||||
event,
|
||||
|
||||
@@ -122,7 +122,6 @@ export const getDefaultAppState = (): Omit<
|
||||
objectsSnapModeEnabled: false,
|
||||
userToFollow: null,
|
||||
followedBy: new Set(),
|
||||
scrollConstraints: null,
|
||||
isCropping: false,
|
||||
croppingElementId: null,
|
||||
searchMatches: null,
|
||||
@@ -173,6 +172,7 @@ const APP_STATE_STORAGE_CONF = (<
|
||||
currentItemStrokeColor: { browser: true, export: false, server: false },
|
||||
currentItemStrokeStyle: { browser: true, export: false, server: false },
|
||||
currentItemStrokeWidth: { browser: true, export: false, server: false },
|
||||
currentItemStrokeShape: { browser: true, export: false, server: false },
|
||||
currentItemTextAlign: { browser: true, export: false, server: false },
|
||||
currentHoveredFontFamily: { browser: false, export: false, server: false },
|
||||
cursorButton: { browser: true, export: false, server: false },
|
||||
@@ -251,7 +251,6 @@ const APP_STATE_STORAGE_CONF = (<
|
||||
objectsSnapModeEnabled: { browser: true, export: false, server: false },
|
||||
userToFollow: { browser: false, export: false, server: false },
|
||||
followedBy: { browser: false, export: false, server: false },
|
||||
scrollConstraints: { browser: true, export: false, server: false },
|
||||
isCropping: { browser: false, export: false, server: false },
|
||||
croppingElementId: { browser: false, export: false, server: false },
|
||||
searchMatches: { browser: false, export: false, server: false },
|
||||
|
||||
@@ -394,6 +394,11 @@ const CombinedShapeProperties = ({
|
||||
hasStrokeWidth(element.type),
|
||||
)) &&
|
||||
renderAction("changeStrokeWidth")}
|
||||
{(appState.activeTool.type === "freedraw" ||
|
||||
targetElements.some(
|
||||
(element) => element.type === "freedraw",
|
||||
)) &&
|
||||
renderAction("changeStrokeShape")}
|
||||
{(hasStrokeStyle(appState.activeTool.type) ||
|
||||
targetElements.some((element) =>
|
||||
hasStrokeStyle(element.type),
|
||||
|
||||
@@ -9,6 +9,7 @@ import {
|
||||
clamp,
|
||||
pointFrom,
|
||||
pointDistance,
|
||||
round,
|
||||
vector,
|
||||
pointRotateRads,
|
||||
vectorFromPoint,
|
||||
@@ -119,6 +120,7 @@ import {
|
||||
getElementAbsoluteCoords,
|
||||
bindOrUnbindBindingElements,
|
||||
fixBindingsAfterDeletion,
|
||||
getFixedFreeDrawPointAction,
|
||||
getHoveredElementForBinding,
|
||||
isBindingEnabled,
|
||||
updateBoundElements,
|
||||
@@ -326,10 +328,7 @@ import {
|
||||
actionToggleCropEditor,
|
||||
} from "../actions";
|
||||
import { actionWrapTextInContainer } from "../actions/actionBoundText";
|
||||
import {
|
||||
actionToggleHandTool,
|
||||
resolveViewportForBounds,
|
||||
} from "../actions/actionCanvas";
|
||||
import { actionToggleHandTool, zoomToFit } from "../actions/actionCanvas";
|
||||
import { actionPaste } from "../actions/actionClipboard";
|
||||
import { actionCopyElementLink } from "../actions/actionElementLink";
|
||||
import { actionUnlockAllElements } from "../actions/actionElementLock";
|
||||
@@ -373,7 +372,7 @@ import {
|
||||
hasBackground,
|
||||
isSomeElementSelected,
|
||||
} from "../scene";
|
||||
import { getConstrainedZoomAnchor, getStateForZoom } from "../scene/zoom";
|
||||
import { getStateForZoom } from "../scene/zoom";
|
||||
import {
|
||||
dataURLToString,
|
||||
generateIdFromFile,
|
||||
@@ -429,12 +428,6 @@ import { isMaybeMermaidDefinition } from "../mermaid";
|
||||
|
||||
import { LassoTrail } from "../lasso";
|
||||
|
||||
import {
|
||||
constrainScrollState,
|
||||
calculateConstrainedScrollCenter,
|
||||
areCanvasTranslatesClose,
|
||||
getScrollConstraintsForBounds,
|
||||
} from "../scene/scrollConstraints";
|
||||
import { EraserTrail } from "../eraser";
|
||||
|
||||
import { getShortcutKey } from "../shortcut";
|
||||
@@ -497,9 +490,6 @@ import type {
|
||||
CollaboratorPointer,
|
||||
ToolType,
|
||||
OnUserFollowedPayload,
|
||||
ScrollConstraints,
|
||||
AnimateTranslateCanvasValues,
|
||||
ScrollToContentOptions,
|
||||
UnsubscribeCallback,
|
||||
EmbedsValidationStatus,
|
||||
ElementsPendingErasure,
|
||||
@@ -552,7 +542,6 @@ const ExcalidrawAppStateContext = React.createContext<AppState>({
|
||||
height: 0,
|
||||
offsetLeft: 0,
|
||||
offsetTop: 0,
|
||||
scrollConstraints: null,
|
||||
});
|
||||
ExcalidrawAppStateContext.displayName = "ExcalidrawAppStateContext";
|
||||
|
||||
@@ -607,20 +596,6 @@ let isDraggingScrollBar: boolean = false;
|
||||
let currentScrollBars: ScrollBars = { horizontal: null, vertical: null };
|
||||
let touchTimeout = 0;
|
||||
let invalidateContextMenu = false;
|
||||
let scrollConstraintsAnimationTimeout: ReturnType<typeof setTimeout> | null =
|
||||
null;
|
||||
|
||||
const areScrollConstraintsEqual = (
|
||||
left: ScrollConstraints | null | undefined,
|
||||
right: ScrollConstraints | null | undefined,
|
||||
) => {
|
||||
return left === right || (!!left && !!right && isShallowEqual(left, right));
|
||||
};
|
||||
|
||||
const SET_SCROLL_CONSTRAINTS_CONTROLLED_WARNING =
|
||||
"Excalidraw: `setScrollConstraints()` is ignored when the `scrollConstraints` prop is controlled.";
|
||||
const SCROLL_TO_CONTENT_SCROLL_LOCK_CONTROLLED_WARNING =
|
||||
"Excalidraw: `scrollToContent()` with `scrollLock` is ignored when the `scrollConstraints` prop is controlled.";
|
||||
|
||||
/**
|
||||
* Map of youtube embed video states
|
||||
@@ -642,6 +617,19 @@ const gesture: Gesture = {
|
||||
initialScale: null,
|
||||
};
|
||||
|
||||
const FREEDRAW_POINT_DECIMALS = 2;
|
||||
const FREEDRAW_PRESSURE_DECIMALS = 3;
|
||||
const FREEDRAW_DOT_EPSILON = 1 / 10 ** FREEDRAW_POINT_DECIMALS;
|
||||
|
||||
const roundFreeDrawCoordinate = (value: number) =>
|
||||
round(value, FREEDRAW_POINT_DECIMALS);
|
||||
|
||||
const roundFreeDrawPressure = (value: number) =>
|
||||
round(value, FREEDRAW_PRESSURE_DECIMALS);
|
||||
|
||||
const getRoundedFreeDrawPoint = (x: number, y: number) =>
|
||||
pointFrom<LocalPoint>(roundFreeDrawCoordinate(x), roundFreeDrawCoordinate(y));
|
||||
|
||||
class App extends React.Component<AppProps, AppState> {
|
||||
canvas: AppClassProperties["canvas"];
|
||||
interactiveCanvas: AppClassProperties["interactiveCanvas"] = null;
|
||||
@@ -808,8 +796,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
onUserFollow: (cb) => this.onUserFollowEmitter.on(cb),
|
||||
onStateChange: this.onStateChange,
|
||||
onEvent: this.onEvent,
|
||||
app: this,
|
||||
setScrollConstraints: this.setScrollConstraints,
|
||||
};
|
||||
return api;
|
||||
}
|
||||
@@ -824,7 +810,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
objectsSnapModeEnabled = false,
|
||||
theme = defaultAppState.theme,
|
||||
name = `${t("labels.untitled")}-${getDateTime()}`,
|
||||
scrollConstraints,
|
||||
} = props;
|
||||
|
||||
this.state = {
|
||||
@@ -840,7 +825,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
name,
|
||||
width: window.innerWidth,
|
||||
height: window.innerHeight,
|
||||
scrollConstraints: scrollConstraints ?? null,
|
||||
};
|
||||
|
||||
this.refreshEditorInterface();
|
||||
@@ -2976,13 +2960,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
toast: this.state.toast,
|
||||
};
|
||||
|
||||
if (this.props.scrollConstraints) {
|
||||
restoredAppState = {
|
||||
...restoredAppState,
|
||||
scrollConstraints: this.props.scrollConstraints,
|
||||
...calculateConstrainedScrollCenter(this.state, restoredAppState),
|
||||
};
|
||||
} else if (initialData?.scrollToContent) {
|
||||
if (initialData?.scrollToContent) {
|
||||
restoredAppState = {
|
||||
...restoredAppState,
|
||||
...calculateScrollCenter(restoredElements, {
|
||||
@@ -2991,18 +2969,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
height: this.state.height,
|
||||
offsetTop: this.state.offsetTop,
|
||||
offsetLeft: this.state.offsetLeft,
|
||||
scrollConstraints: this.state.scrollConstraints,
|
||||
}),
|
||||
};
|
||||
}
|
||||
|
||||
if (initialData?.scrollX != null) {
|
||||
restoredAppState.scrollX = initialData.scrollX;
|
||||
}
|
||||
if (initialData?.scrollY != null) {
|
||||
restoredAppState.scrollY = initialData.scrollY;
|
||||
}
|
||||
|
||||
this.resetStore();
|
||||
this.resetHistory();
|
||||
this.syncActionResult({
|
||||
@@ -3253,11 +3223,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
.forEach((element) => ShapeCache.delete(element));
|
||||
this.refreshEditorInterface();
|
||||
this.updateDOMRect();
|
||||
if (this.state.scrollConstraints) {
|
||||
this.setState((state) => constrainScrollState(state));
|
||||
} else {
|
||||
this.setState({});
|
||||
}
|
||||
this.setState({});
|
||||
});
|
||||
|
||||
/** generally invoked only if fullscreen was invoked programmatically */
|
||||
@@ -3507,15 +3473,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.setState({ viewModeEnabled: !!this.props.viewModeEnabled });
|
||||
}
|
||||
|
||||
if (
|
||||
!areScrollConstraintsEqual(
|
||||
prevProps.scrollConstraints,
|
||||
this.props.scrollConstraints,
|
||||
)
|
||||
) {
|
||||
this.syncScrollConstraints(this.props.scrollConstraints ?? null);
|
||||
}
|
||||
|
||||
if (prevState.viewModeEnabled !== this.state.viewModeEnabled) {
|
||||
this.addEventListeners();
|
||||
this.deselectElements();
|
||||
@@ -3576,33 +3533,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.props.onChange?.(elements, this.state, this.files);
|
||||
this.onChangeEmitter.trigger(elements, this.state, this.files);
|
||||
}
|
||||
|
||||
if (this.state.scrollConstraints?.animateOnNextUpdate) {
|
||||
const newState = constrainScrollState(this.state, "rigid");
|
||||
const fromValues = {
|
||||
scrollX: this.state.scrollX,
|
||||
scrollY: this.state.scrollY,
|
||||
zoom: this.state.zoom.value,
|
||||
};
|
||||
const toValues = {
|
||||
scrollX: newState.scrollX,
|
||||
scrollY: newState.scrollY,
|
||||
zoom: newState.zoom.value,
|
||||
};
|
||||
|
||||
if (areCanvasTranslatesClose(fromValues, toValues)) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (scrollConstraintsAnimationTimeout) {
|
||||
clearTimeout(scrollConstraintsAnimationTimeout);
|
||||
}
|
||||
|
||||
scrollConstraintsAnimationTimeout = setTimeout(() => {
|
||||
this.cancelInProgressAnimation?.();
|
||||
this.animateToConstrainedArea(fromValues, toValues);
|
||||
}, 200);
|
||||
}
|
||||
}
|
||||
|
||||
private renderInteractiveSceneCallback = ({
|
||||
@@ -4370,8 +4300,8 @@ class App extends React.Component<AppProps, AppState> {
|
||||
*/
|
||||
value: number,
|
||||
) => {
|
||||
this.setState(
|
||||
getStateForZoom(
|
||||
this.setState({
|
||||
...getStateForZoom(
|
||||
{
|
||||
viewportX: this.state.width / 2 + this.state.offsetLeft,
|
||||
viewportY: this.state.height / 2 + this.state.offsetTop,
|
||||
@@ -4379,13 +4309,11 @@ class App extends React.Component<AppProps, AppState> {
|
||||
},
|
||||
this.state,
|
||||
),
|
||||
);
|
||||
});
|
||||
};
|
||||
|
||||
private cancelInProgressAnimation: (() => void) | null = null;
|
||||
|
||||
private scrollToContentRequestId = 0;
|
||||
|
||||
scrollToContent = (
|
||||
/**
|
||||
* target to scroll to
|
||||
@@ -4397,13 +4325,30 @@ class App extends React.Component<AppProps, AppState> {
|
||||
| string
|
||||
| ExcalidrawElement
|
||||
| readonly ExcalidrawElement[] = this.scene.getNonDeletedElements(),
|
||||
opts?: ScrollToContentOptions,
|
||||
opts?: (
|
||||
| {
|
||||
fitToContent?: boolean;
|
||||
fitToViewport?: never;
|
||||
viewportZoomFactor?: number;
|
||||
animate?: boolean;
|
||||
duration?: number;
|
||||
}
|
||||
| {
|
||||
fitToContent?: never;
|
||||
fitToViewport?: boolean;
|
||||
/** when fitToViewport=true, how much screen should the content cover,
|
||||
* between 0.1 (10%) and 1 (100%)
|
||||
*/
|
||||
viewportZoomFactor?: number;
|
||||
animate?: boolean;
|
||||
duration?: number;
|
||||
}
|
||||
) & {
|
||||
minZoom?: number;
|
||||
maxZoom?: number;
|
||||
canvasOffsets?: Offsets;
|
||||
},
|
||||
) => {
|
||||
if (opts?.scrollLock && this.props.scrollConstraints !== undefined) {
|
||||
console.warn(SCROLL_TO_CONTENT_SCROLL_LOCK_CONTROLLED_WARNING);
|
||||
opts = { ...opts, scrollLock: undefined };
|
||||
}
|
||||
|
||||
if (typeof target === "string") {
|
||||
let id: string | null;
|
||||
if (isElementLink(target)) {
|
||||
@@ -4415,29 +4360,10 @@ class App extends React.Component<AppProps, AppState> {
|
||||
const elements = this.scene.getElementsFromId(id);
|
||||
|
||||
if (elements?.length) {
|
||||
if (opts?.fitToViewport) {
|
||||
this.scrollToContent(elements, {
|
||||
fitToViewport: true,
|
||||
viewportZoomFactor: opts.viewportZoomFactor,
|
||||
animate: opts.animate ?? true,
|
||||
duration: opts.duration,
|
||||
scrollLock: opts.scrollLock,
|
||||
minZoom: opts.minZoom,
|
||||
maxZoom: opts.maxZoom,
|
||||
canvasOffsets: opts.canvasOffsets,
|
||||
});
|
||||
} else {
|
||||
this.scrollToContent(elements, {
|
||||
fitToContent: opts?.fitToContent ?? true,
|
||||
viewportZoomFactor: opts?.viewportZoomFactor,
|
||||
animate: opts?.animate ?? true,
|
||||
duration: opts?.duration,
|
||||
scrollLock: opts?.scrollLock,
|
||||
minZoom: opts?.minZoom,
|
||||
maxZoom: opts?.maxZoom,
|
||||
canvasOffsets: opts?.canvasOffsets,
|
||||
});
|
||||
}
|
||||
this.scrollToContent(elements, {
|
||||
fitToContent: opts?.fitToContent ?? true,
|
||||
animate: opts?.animate ?? true,
|
||||
});
|
||||
} else if (isElementLink(target)) {
|
||||
this.setState({
|
||||
toast: {
|
||||
@@ -4452,45 +4378,27 @@ class App extends React.Component<AppProps, AppState> {
|
||||
}
|
||||
|
||||
this.cancelInProgressAnimation?.();
|
||||
this.scrollToContentRequestId += 1;
|
||||
this.debounceConstrainScrollState.cancel();
|
||||
|
||||
if (scrollConstraintsAnimationTimeout) {
|
||||
clearTimeout(scrollConstraintsAnimationTimeout);
|
||||
scrollConstraintsAnimationTimeout = null;
|
||||
}
|
||||
|
||||
if (opts?.scrollLock != null && this.state.scrollConstraints) {
|
||||
// Clear the previous lock before starting the next locked transition so
|
||||
// stale constraint enforcement cannot snap us back mid-flight.
|
||||
this.setState({ scrollConstraints: null });
|
||||
}
|
||||
|
||||
// convert provided target into ExcalidrawElement[] if necessary
|
||||
const targetElements = Array.isArray(target) ? target : [target];
|
||||
|
||||
if (!targetElements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
let zoom = this.state.zoom;
|
||||
let scrollX = this.state.scrollX;
|
||||
let scrollY = this.state.scrollY;
|
||||
const targetBounds = getCommonBounds(targetElements);
|
||||
|
||||
if (opts?.fitToContent || opts?.fitToViewport) {
|
||||
const resolvedViewport = resolveViewportForBounds({
|
||||
bounds: targetBounds,
|
||||
const { appState } = zoomToFit({
|
||||
canvasOffsets: opts.canvasOffsets,
|
||||
targetElements,
|
||||
appState: this.state,
|
||||
fitToViewport: !!opts?.fitToViewport,
|
||||
viewportZoomFactor: opts?.viewportZoomFactor,
|
||||
minZoom: opts?.minZoom,
|
||||
maxZoom: opts?.maxZoom,
|
||||
});
|
||||
zoom = resolvedViewport.zoom;
|
||||
scrollX = resolvedViewport.scrollX;
|
||||
scrollY = resolvedViewport.scrollY;
|
||||
zoom = appState.zoom;
|
||||
scrollX = appState.scrollX;
|
||||
scrollY = appState.scrollY;
|
||||
} else {
|
||||
// compute only the viewport location, without any zoom adjustment
|
||||
const scroll = calculateScrollCenter(targetElements, this.state);
|
||||
@@ -4498,72 +4406,51 @@ class App extends React.Component<AppProps, AppState> {
|
||||
scrollY = scroll.scrollY;
|
||||
}
|
||||
|
||||
const scrollConstraints = opts?.scrollLock
|
||||
? getScrollConstraintsForBounds({
|
||||
bounds: targetBounds,
|
||||
zoom,
|
||||
viewportDimensions: {
|
||||
width: this.state.width,
|
||||
height: this.state.height,
|
||||
},
|
||||
scrollLock: opts.scrollLock,
|
||||
})
|
||||
: null;
|
||||
const requestId = this.scrollToContentRequestId;
|
||||
|
||||
const installScrollConstraints = () => {
|
||||
if (!scrollConstraints || requestId !== this.scrollToContentRequestId) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.setState({
|
||||
scrollConstraints,
|
||||
});
|
||||
};
|
||||
|
||||
// when animating, we use RequestAnimationFrame to prevent the animation
|
||||
// from slowing down other processes
|
||||
if (opts?.animate) {
|
||||
const fromValues = {
|
||||
scrollX: this.state.scrollX,
|
||||
scrollY: this.state.scrollY,
|
||||
zoom: this.state.zoom.value,
|
||||
};
|
||||
const origScrollX = this.state.scrollX;
|
||||
const origScrollY = this.state.scrollY;
|
||||
const origZoom = this.state.zoom.value;
|
||||
|
||||
const toValues = { scrollX, scrollY, zoom: zoom.value };
|
||||
|
||||
this.animateTranslateCanvas({
|
||||
fromValues,
|
||||
toValues,
|
||||
duration: opts?.duration ?? 500,
|
||||
const cancel = easeToValuesRAF({
|
||||
fromValues: {
|
||||
scrollX: origScrollX,
|
||||
scrollY: origScrollY,
|
||||
zoom: origZoom,
|
||||
},
|
||||
toValues: { scrollX, scrollY, zoom: zoom.value },
|
||||
interpolateValue: (from, to, progress, key) => {
|
||||
// for zoom, use different easing
|
||||
if (key === "zoom") {
|
||||
return from * Math.pow(to / from, easeOut(progress));
|
||||
}
|
||||
// handle using default
|
||||
return undefined;
|
||||
},
|
||||
onStep: ({ scrollX, scrollY, zoom }) => {
|
||||
this.setState({
|
||||
scrollX,
|
||||
scrollY,
|
||||
zoom: { value: zoom },
|
||||
});
|
||||
},
|
||||
onStart: () => {
|
||||
this.setState({ shouldCacheIgnoreZoom: true });
|
||||
},
|
||||
onEnd: () => {
|
||||
if (requestId !== this.scrollToContentRequestId) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.setState(
|
||||
{ shouldCacheIgnoreZoom: false },
|
||||
installScrollConstraints,
|
||||
);
|
||||
},
|
||||
onCancel: () => {
|
||||
if (requestId !== this.scrollToContentRequestId) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.setState({ shouldCacheIgnoreZoom: false });
|
||||
},
|
||||
onCancel: () => {
|
||||
this.setState({ shouldCacheIgnoreZoom: false });
|
||||
},
|
||||
duration: opts?.duration ?? 500,
|
||||
});
|
||||
} else if (scrollConstraints) {
|
||||
this.setState({
|
||||
scrollX,
|
||||
scrollY,
|
||||
zoom,
|
||||
scrollConstraints,
|
||||
});
|
||||
|
||||
this.cancelInProgressAnimation = () => {
|
||||
cancel();
|
||||
this.cancelInProgressAnimation = null;
|
||||
};
|
||||
} else {
|
||||
this.setState({ scrollX, scrollY, zoom });
|
||||
}
|
||||
@@ -4577,165 +4464,11 @@ class App extends React.Component<AppProps, AppState> {
|
||||
|
||||
/** use when changing scrollX/scrollY/zoom based on user interaction */
|
||||
private translateCanvas: React.Component<any, AppState>["setState"] = (
|
||||
stateUpdate,
|
||||
state,
|
||||
) => {
|
||||
this.cancelInProgressAnimation?.();
|
||||
this.maybeUnfollowRemoteUser();
|
||||
|
||||
if (scrollConstraintsAnimationTimeout) {
|
||||
clearTimeout(scrollConstraintsAnimationTimeout);
|
||||
}
|
||||
|
||||
const partialNewState =
|
||||
typeof stateUpdate === "function"
|
||||
? (
|
||||
stateUpdate as (
|
||||
prevState: Readonly<AppState>,
|
||||
props: Readonly<AppProps>,
|
||||
) => AppState
|
||||
)(this.state, this.props)
|
||||
: stateUpdate;
|
||||
|
||||
const newState: AppState = {
|
||||
...this.state,
|
||||
...partialNewState,
|
||||
...(this.state.scrollConstraints && {
|
||||
// manually reset if setState in onCancel wasn't committed yet
|
||||
shouldCacheIgnoreZoom: false,
|
||||
}),
|
||||
};
|
||||
|
||||
// RULE: cannot go below the minimum zoom level if zoom lock is enabled
|
||||
const constrainedState =
|
||||
newState.scrollConstraints && newState.scrollConstraints.lockZoom
|
||||
? constrainScrollState(newState, "elastic")
|
||||
: newState;
|
||||
if (constrainedState.zoom.value > newState.zoom.value) {
|
||||
newState.zoom = constrainedState.zoom;
|
||||
newState.scrollX = constrainedState.scrollX;
|
||||
newState.scrollY = constrainedState.scrollY;
|
||||
|
||||
this.debounceConstrainScrollState(newState);
|
||||
return;
|
||||
}
|
||||
|
||||
this.setState(newState);
|
||||
if (this.state.scrollConstraints) {
|
||||
if (newState.zoom.value < this.state.zoom.value) {
|
||||
// zoom-out: debounce to allow centering on user's cursor position before constraining
|
||||
this.debounceConstrainScrollState(newState);
|
||||
} else {
|
||||
// zoom-in or pan: valid range only expands on zoom-in, constrain immediately
|
||||
this.setState(constrainScrollState(newState));
|
||||
}
|
||||
}
|
||||
};
|
||||
|
||||
private debounceConstrainScrollState = debounce((state: AppState) => {
|
||||
const newState = constrainScrollState(state, "rigid");
|
||||
|
||||
const fromValues = {
|
||||
scrollX: this.state.scrollX,
|
||||
scrollY: this.state.scrollY,
|
||||
zoom: this.state.zoom.value,
|
||||
};
|
||||
const toValues = {
|
||||
scrollX: newState.scrollX,
|
||||
scrollY: newState.scrollY,
|
||||
zoom: newState.zoom.value,
|
||||
};
|
||||
|
||||
if (areCanvasTranslatesClose(fromValues, toValues)) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.cancelInProgressAnimation?.();
|
||||
this.animateToConstrainedArea(fromValues, toValues);
|
||||
}, 200);
|
||||
|
||||
private animateToConstrainedArea = (
|
||||
fromValues: AnimateTranslateCanvasValues,
|
||||
toValues: AnimateTranslateCanvasValues,
|
||||
) => {
|
||||
const cleanUp = () => {
|
||||
this.setState((state) => ({
|
||||
shouldCacheIgnoreZoom: false,
|
||||
scrollConstraints: {
|
||||
...state.scrollConstraints!,
|
||||
animateOnNextUpdate: false,
|
||||
},
|
||||
}));
|
||||
};
|
||||
|
||||
this.animateTranslateCanvas({
|
||||
fromValues,
|
||||
toValues,
|
||||
duration: 200,
|
||||
onStart: () => {
|
||||
this.setState((state) => {
|
||||
return {
|
||||
shouldCacheIgnoreZoom: true,
|
||||
scrollConstraints: {
|
||||
...state.scrollConstraints!,
|
||||
animateOnNextUpdate: false,
|
||||
},
|
||||
};
|
||||
});
|
||||
},
|
||||
onEnd: cleanUp,
|
||||
onCancel: cleanUp,
|
||||
});
|
||||
};
|
||||
|
||||
private animateTranslateCanvas = ({
|
||||
fromValues,
|
||||
toValues,
|
||||
duration,
|
||||
onStart,
|
||||
onEnd,
|
||||
onCancel,
|
||||
}: {
|
||||
fromValues: AnimateTranslateCanvasValues;
|
||||
toValues: AnimateTranslateCanvasValues;
|
||||
duration: number;
|
||||
onStart: () => void;
|
||||
onEnd: () => void;
|
||||
onCancel: () => void;
|
||||
}) => {
|
||||
const cancel = easeToValuesRAF({
|
||||
fromValues,
|
||||
toValues,
|
||||
interpolateValue: (from, to, progress, key) => {
|
||||
// for zoom, use different easing
|
||||
if (key === "zoom") {
|
||||
return from * Math.pow(to / from, easeOut(progress));
|
||||
}
|
||||
// handle using default
|
||||
return undefined;
|
||||
},
|
||||
onStep: ({ scrollX, scrollY, zoom }) => {
|
||||
this.setState({
|
||||
scrollX,
|
||||
scrollY,
|
||||
zoom: { value: zoom },
|
||||
});
|
||||
},
|
||||
onStart,
|
||||
onEnd: () => {
|
||||
this.cancelInProgressAnimation = null;
|
||||
onEnd();
|
||||
},
|
||||
onCancel: () => {
|
||||
this.cancelInProgressAnimation = null;
|
||||
onCancel();
|
||||
},
|
||||
duration,
|
||||
});
|
||||
|
||||
this.cancelInProgressAnimation = () => {
|
||||
cancel();
|
||||
this.cancelInProgressAnimation = null;
|
||||
};
|
||||
this.setState(state);
|
||||
};
|
||||
|
||||
setToast = (toast: AppState["toast"]) => {
|
||||
@@ -5916,22 +5649,16 @@ class App extends React.Component<AppProps, AppState> {
|
||||
|
||||
const initialScale = gesture.initialScale;
|
||||
if (initialScale) {
|
||||
this.setState((state) =>
|
||||
constrainScrollState(
|
||||
this.setState((state) => ({
|
||||
...getStateForZoom(
|
||||
{
|
||||
...state,
|
||||
...getStateForZoom(
|
||||
{
|
||||
viewportX: this.lastViewportPosition.x,
|
||||
viewportY: this.lastViewportPosition.y,
|
||||
nextZoom: getNormalizedZoom(initialScale * event.scale),
|
||||
},
|
||||
state,
|
||||
),
|
||||
viewportX: this.lastViewportPosition.x,
|
||||
viewportY: this.lastViewportPosition.y,
|
||||
nextZoom: getNormalizedZoom(initialScale * event.scale),
|
||||
},
|
||||
"loose",
|
||||
state,
|
||||
),
|
||||
);
|
||||
}));
|
||||
}
|
||||
});
|
||||
|
||||
@@ -8368,7 +8095,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
|
||||
setCursor(this.interactiveCanvas, CURSOR_TYPE.GRABBING);
|
||||
let { clientX: lastX, clientY: lastY } = event;
|
||||
const onPointerMove = withBatchedUpdatesThrottled((event: PointerEvent) => {
|
||||
const onPointerMove = ((event: PointerEvent) => {
|
||||
const deltaX = lastX - event.clientX;
|
||||
const deltaY = lastY - event.clientY;
|
||||
lastX = event.clientX;
|
||||
@@ -8434,7 +8161,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
window.removeEventListener(EVENT.POINTER_MOVE, onPointerMove);
|
||||
window.removeEventListener(EVENT.POINTER_UP, teardown);
|
||||
window.removeEventListener(EVENT.BLUR, teardown);
|
||||
onPointerMove.flush();
|
||||
// onPointerMove.flush();
|
||||
}),
|
||||
);
|
||||
window.addEventListener(EVENT.BLUR, teardown);
|
||||
@@ -8544,14 +8271,14 @@ class App extends React.Component<AppProps, AppState> {
|
||||
isDraggingScrollBar = true;
|
||||
pointerDownState.lastCoords.x = event.clientX;
|
||||
pointerDownState.lastCoords.y = event.clientY;
|
||||
const onPointerMove = withBatchedUpdatesThrottled((event: PointerEvent) => {
|
||||
const onPointerMove = (event: PointerEvent) => {
|
||||
const target = event.target;
|
||||
if (!(target instanceof HTMLElement)) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.handlePointerMoveOverScrollbars(event, pointerDownState);
|
||||
});
|
||||
};
|
||||
const onPointerUp = withBatchedUpdates(() => {
|
||||
lastPointerUp = null;
|
||||
isDraggingScrollBar = false;
|
||||
@@ -8562,7 +8289,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.savePointer(event.clientX, event.clientY, "up");
|
||||
window.removeEventListener(EVENT.POINTER_MOVE, onPointerMove);
|
||||
window.removeEventListener(EVENT.POINTER_UP, onPointerUp);
|
||||
onPointerMove.flush();
|
||||
// onPointerMove.flush();
|
||||
});
|
||||
|
||||
lastPointerUp = onPointerUp;
|
||||
@@ -9121,10 +8848,13 @@ class App extends React.Component<AppProps, AppState> {
|
||||
opacity: this.state.currentItemOpacity,
|
||||
roundness: null,
|
||||
simulatePressure,
|
||||
strokeShape: this.state.currentItemStrokeShape,
|
||||
locked: false,
|
||||
frameId: topLayerFrame ? topLayerFrame.id : null,
|
||||
points: [pointFrom<LocalPoint>(0, 0)],
|
||||
pressures: simulatePressure ? [] : [event.pressure],
|
||||
pressures: simulatePressure
|
||||
? []
|
||||
: [roundFreeDrawPressure(event.pressure)],
|
||||
});
|
||||
|
||||
this.scene.insertElement(element);
|
||||
@@ -9766,7 +9496,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
private onPointerMoveFromPointerDownHandler(
|
||||
pointerDownState: PointerDownState,
|
||||
) {
|
||||
return withBatchedUpdatesThrottled((event: PointerEvent) => {
|
||||
return (event: PointerEvent) => {
|
||||
if (this.state.openDialog?.name === "elementLinkSelector") {
|
||||
return;
|
||||
}
|
||||
@@ -10462,20 +10192,36 @@ class App extends React.Component<AppProps, AppState> {
|
||||
const points = newElement.points;
|
||||
const dx = pointerCoords.x - newElement.x;
|
||||
const dy = pointerCoords.y - newElement.y;
|
||||
const nextPoint = getRoundedFreeDrawPoint(dx, dy);
|
||||
const pressure = roundFreeDrawPressure(event.pressure);
|
||||
const pointAction =
|
||||
newElement.strokeShape === "fixed"
|
||||
? getFixedFreeDrawPointAction({
|
||||
points,
|
||||
nextPoint,
|
||||
strokeWidth: newElement.strokeWidth,
|
||||
zoomValue: this.state.zoom.value,
|
||||
})
|
||||
: points.length > 0 &&
|
||||
points[points.length - 1][0] === nextPoint[0] &&
|
||||
points[points.length - 1][1] === nextPoint[1]
|
||||
? "discard"
|
||||
: "append";
|
||||
|
||||
const lastPoint = points.length > 0 && points[points.length - 1];
|
||||
const discardPoint =
|
||||
lastPoint && lastPoint[0] === dx && lastPoint[1] === dy;
|
||||
|
||||
if (!discardPoint) {
|
||||
if (pointAction !== "discard") {
|
||||
const pressures = newElement.simulatePressure
|
||||
? newElement.pressures
|
||||
: [...newElement.pressures, event.pressure];
|
||||
: pointAction === "replace"
|
||||
? [...newElement.pressures.slice(0, -1), pressure]
|
||||
: [...newElement.pressures, pressure];
|
||||
|
||||
this.scene.mutateElement(
|
||||
newElement,
|
||||
{
|
||||
points: [...points, pointFrom<LocalPoint>(dx, dy)],
|
||||
points:
|
||||
pointAction === "replace"
|
||||
? [...points.slice(0, -1), nextPoint]
|
||||
: [...points, nextPoint],
|
||||
pressures,
|
||||
},
|
||||
{
|
||||
@@ -10633,7 +10379,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
});
|
||||
}
|
||||
}
|
||||
});
|
||||
};
|
||||
}
|
||||
|
||||
// Returns whether the pointer move happened over either scrollbar
|
||||
@@ -10678,7 +10424,7 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.removePointer(childEvent);
|
||||
pointerDownState.drag.blockDragging = false;
|
||||
if (pointerDownState.eventListeners.onMove) {
|
||||
pointerDownState.eventListeners.onMove.flush();
|
||||
// pointerDownState.eventListeners.onMove.flush();
|
||||
}
|
||||
const {
|
||||
newElement,
|
||||
@@ -10915,23 +10661,48 @@ class App extends React.Component<AppProps, AppState> {
|
||||
);
|
||||
|
||||
const points = newElement.points;
|
||||
let dx = pointerCoords.x - newElement.x;
|
||||
let dy = pointerCoords.y - newElement.y;
|
||||
const dx = pointerCoords.x - newElement.x;
|
||||
const dy = pointerCoords.y - newElement.y;
|
||||
let nextPoint = getRoundedFreeDrawPoint(dx, dy);
|
||||
|
||||
// Allows dots to avoid being flagged as infinitely small
|
||||
if (dx === points[0][0] && dy === points[0][1]) {
|
||||
dy += 0.0001;
|
||||
dx += 0.0001;
|
||||
if (nextPoint[0] === points[0][0] && nextPoint[1] === points[0][1]) {
|
||||
nextPoint = getRoundedFreeDrawPoint(
|
||||
dx + FREEDRAW_DOT_EPSILON,
|
||||
dy + FREEDRAW_DOT_EPSILON,
|
||||
);
|
||||
}
|
||||
|
||||
const pressures = newElement.simulatePressure
|
||||
? []
|
||||
: [...newElement.pressures, childEvent.pressure];
|
||||
const lastPoint = points[points.length - 1];
|
||||
const pressure = roundFreeDrawPressure(childEvent.pressure);
|
||||
const pointAction =
|
||||
newElement.strokeShape === "fixed"
|
||||
? getFixedFreeDrawPointAction({
|
||||
points,
|
||||
nextPoint,
|
||||
strokeWidth: newElement.strokeWidth,
|
||||
zoomValue: this.state.zoom.value,
|
||||
isFinalPoint: true,
|
||||
})
|
||||
: !lastPoint ||
|
||||
lastPoint[0] !== nextPoint[0] ||
|
||||
lastPoint[1] !== nextPoint[1]
|
||||
? "append"
|
||||
: "discard";
|
||||
|
||||
this.scene.mutateElement(newElement, {
|
||||
points: [...points, pointFrom<LocalPoint>(dx, dy)],
|
||||
pressures,
|
||||
});
|
||||
if (pointAction !== "discard") {
|
||||
this.scene.mutateElement(newElement, {
|
||||
points:
|
||||
pointAction === "replace"
|
||||
? [...points.slice(0, -1), nextPoint]
|
||||
: [...points, nextPoint],
|
||||
pressures: newElement.simulatePressure
|
||||
? []
|
||||
: pointAction === "replace"
|
||||
? [...newElement.pressures.slice(0, -1), pressure]
|
||||
: [...newElement.pressures, pressure],
|
||||
});
|
||||
}
|
||||
|
||||
this.actionManager.executeAction(actionFinalize);
|
||||
|
||||
@@ -12908,21 +12679,17 @@ class App extends React.Component<AppProps, AppState> {
|
||||
// reduced amplification for small deltas (small movements on a trackpad)
|
||||
Math.min(1, absDelta / 20);
|
||||
|
||||
this.translateCanvas((state) => {
|
||||
const nextZoom = getNormalizedZoom(newZoom);
|
||||
const anchor = getConstrainedZoomAnchor(
|
||||
this.translateCanvas((state) => ({
|
||||
...getStateForZoom(
|
||||
{
|
||||
viewportX: this.lastViewportPosition.x,
|
||||
viewportY: this.lastViewportPosition.y,
|
||||
nextZoom,
|
||||
nextZoom: getNormalizedZoom(newZoom),
|
||||
},
|
||||
state,
|
||||
);
|
||||
return {
|
||||
...getStateForZoom({ ...anchor, nextZoom }, state),
|
||||
shouldCacheIgnoreZoom: true,
|
||||
};
|
||||
});
|
||||
),
|
||||
shouldCacheIgnoreZoom: true,
|
||||
}));
|
||||
this.resetShouldCacheIgnoreZoomDebounced();
|
||||
return;
|
||||
}
|
||||
@@ -13080,71 +12847,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
await setLanguage(currentLang);
|
||||
this.setAppState({});
|
||||
}
|
||||
|
||||
/**
|
||||
* Sets the scroll constraints of the application state.
|
||||
*
|
||||
* @param scrollConstraints - The new scroll constraints.
|
||||
*/
|
||||
public setScrollConstraints = (
|
||||
scrollConstraints: ScrollConstraints | null,
|
||||
) => {
|
||||
if (this.props.scrollConstraints !== undefined) {
|
||||
console.warn(SET_SCROLL_CONSTRAINTS_CONTROLLED_WARNING);
|
||||
return;
|
||||
}
|
||||
|
||||
this.syncScrollConstraints(scrollConstraints);
|
||||
};
|
||||
|
||||
private syncScrollConstraints = (
|
||||
scrollConstraints: ScrollConstraints | null,
|
||||
) => {
|
||||
this.debounceConstrainScrollState.cancel();
|
||||
|
||||
if (scrollConstraintsAnimationTimeout) {
|
||||
clearTimeout(scrollConstraintsAnimationTimeout);
|
||||
scrollConstraintsAnimationTimeout = null;
|
||||
}
|
||||
|
||||
this.cancelInProgressAnimation?.();
|
||||
|
||||
if (scrollConstraints) {
|
||||
this.setState(
|
||||
{
|
||||
scrollConstraints,
|
||||
shouldCacheIgnoreZoom: false,
|
||||
},
|
||||
() => {
|
||||
const newState = constrainScrollState(
|
||||
{
|
||||
...this.state,
|
||||
scrollConstraints,
|
||||
},
|
||||
"rigid",
|
||||
);
|
||||
|
||||
this.animateToConstrainedArea(
|
||||
{
|
||||
scrollX: this.state.scrollX,
|
||||
scrollY: this.state.scrollY,
|
||||
zoom: this.state.zoom.value,
|
||||
},
|
||||
{
|
||||
scrollX: newState.scrollX,
|
||||
scrollY: newState.scrollY,
|
||||
zoom: newState.zoom.value,
|
||||
},
|
||||
);
|
||||
},
|
||||
);
|
||||
} else {
|
||||
this.setState({
|
||||
scrollConstraints: null,
|
||||
shouldCacheIgnoreZoom: false,
|
||||
});
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
@@ -1164,7 +1164,7 @@ export const StrokeWidthBaseIcon = createIcon(
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeWidthBoldIcon = createIcon(
|
||||
export const StrokeWidthMediumIcon = createIcon(
|
||||
<path
|
||||
d="M5 10h10"
|
||||
stroke="currentColor"
|
||||
@@ -1175,7 +1175,7 @@ export const StrokeWidthBoldIcon = createIcon(
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeWidthExtraBoldIcon = createIcon(
|
||||
export const StrokeWidthBoldIcon = createIcon(
|
||||
<path
|
||||
d="M5 10h10"
|
||||
stroke="currentColor"
|
||||
@@ -1186,6 +1186,48 @@ export const StrokeWidthExtraBoldIcon = createIcon(
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeWidthExtraBoldIcon = createIcon(
|
||||
<path
|
||||
d="M5 10h10"
|
||||
stroke="currentColor"
|
||||
strokeWidth="5"
|
||||
strokeLinecap="round"
|
||||
strokeLinejoin="round"
|
||||
/>,
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeShapeVariableIcon = createIcon(
|
||||
<>
|
||||
<path
|
||||
d="M3.5 12.5c1.8-3.5 4.1-5.2 6.8-5.2 2.4 0 4.4 1.3 6.2 3.9"
|
||||
stroke="currentColor"
|
||||
strokeWidth="1.25"
|
||||
strokeLinecap="round"
|
||||
strokeLinejoin="round"
|
||||
/>
|
||||
<path
|
||||
d="M7.75 10.8c1-.9 2-1.35 3.05-1.35 1.2 0 2.4.57 3.7 1.72"
|
||||
stroke="currentColor"
|
||||
strokeWidth="2.5"
|
||||
strokeLinecap="round"
|
||||
strokeLinejoin="round"
|
||||
/>
|
||||
</>,
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeShapeFixedIcon = createIcon(
|
||||
<path
|
||||
d="M3.5 12h13"
|
||||
stroke="currentColor"
|
||||
strokeWidth="2.5"
|
||||
strokeLinecap="round"
|
||||
strokeLinejoin="round"
|
||||
/>,
|
||||
modifiedTablerIconProps,
|
||||
);
|
||||
|
||||
export const StrokeStyleSolidIcon = React.memo(({ theme }: { theme: Theme }) =>
|
||||
createIcon(
|
||||
<path
|
||||
|
||||
@@ -96,6 +96,13 @@ type RestoredAppState = Omit<
|
||||
"offsetTop" | "offsetLeft" | "width" | "height"
|
||||
>;
|
||||
|
||||
const normalizeFreeDrawStrokeShape = (
|
||||
strokeShape: unknown,
|
||||
): AppState["currentItemStrokeShape"] =>
|
||||
strokeShape === "fixed" || strokeShape === "stable"
|
||||
? "fixed"
|
||||
: undefined;
|
||||
|
||||
export const AllowedExcalidrawActiveTools: Record<
|
||||
AppState["activeTool"]["type"],
|
||||
boolean
|
||||
@@ -412,10 +419,12 @@ export const restoreElement = (
|
||||
|
||||
return element;
|
||||
case "freedraw": {
|
||||
const strokeShape = normalizeFreeDrawStrokeShape(element.strokeShape);
|
||||
return restoreElementWithProperties(element, {
|
||||
points: element.points,
|
||||
simulatePressure: element.simulatePressure,
|
||||
pressures: element.pressures,
|
||||
...(strokeShape ? { strokeShape } : {}),
|
||||
});
|
||||
}
|
||||
case "image":
|
||||
@@ -944,6 +953,16 @@ export const restoreAppState = (
|
||||
|
||||
return {
|
||||
...nextAppState,
|
||||
...(normalizeFreeDrawStrokeShape(
|
||||
appState.currentItemStrokeShape ?? localAppState?.currentItemStrokeShape,
|
||||
)
|
||||
? {
|
||||
currentItemStrokeShape: normalizeFreeDrawStrokeShape(
|
||||
appState.currentItemStrokeShape ??
|
||||
localAppState?.currentItemStrokeShape,
|
||||
),
|
||||
}
|
||||
: {}),
|
||||
cursorButton: localAppState?.cursorButton || "up",
|
||||
// reset on fresh restore so as to hide the UI button if penMode not active
|
||||
penDetected:
|
||||
|
||||
@@ -98,7 +98,6 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
aiEnabled,
|
||||
showDeprecatedFonts,
|
||||
renderScrollbars,
|
||||
scrollConstraints,
|
||||
} = props;
|
||||
|
||||
const canvasActions = props.UIOptions?.canvasActions;
|
||||
@@ -209,7 +208,6 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
aiEnabled={aiEnabled !== false}
|
||||
showDeprecatedFonts={showDeprecatedFonts}
|
||||
renderScrollbars={renderScrollbars}
|
||||
scrollConstraints={scrollConstraints}
|
||||
>
|
||||
{children}
|
||||
</App>
|
||||
|
||||
@@ -30,6 +30,9 @@
|
||||
"changeBackground": "Change background color",
|
||||
"fill": "Fill",
|
||||
"strokeWidth": "Stroke width",
|
||||
"strokeShape": "Stroke type",
|
||||
"strokeShape_variable": "Variable",
|
||||
"strokeShape_fixed": "Fixed",
|
||||
"strokeStyle": "Stroke style",
|
||||
"strokeStyle_solid": "Solid",
|
||||
"strokeStyle_dashed": "Dashed",
|
||||
|
||||
@@ -11,10 +11,10 @@ export const withBatchedUpdates = <
|
||||
TFunction extends ((event: any) => void) | (() => void),
|
||||
>(
|
||||
func: Parameters<TFunction>["length"] extends 0 | 1 ? TFunction : never,
|
||||
) =>
|
||||
((event) => {
|
||||
unstable_batchedUpdates(func as TFunction, event);
|
||||
}) as TFunction;
|
||||
) => func;
|
||||
// ((event) => {
|
||||
// unstable_batchedUpdates(func as TFunction, event);
|
||||
// }) as TFunction;
|
||||
|
||||
/**
|
||||
* barches React state updates and throttles the calls to a single call per
|
||||
|
||||
@@ -376,6 +376,11 @@ const renderElementToSvg = (
|
||||
}
|
||||
case "freedraw": {
|
||||
const wrapper = svgRoot.ownerDocument.createElementNS(SVG_NS, "g");
|
||||
const isFixedStroke = element.strokeShape === "fixed";
|
||||
const strokeColor =
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor;
|
||||
|
||||
const shapes = ShapeCache.generateElementShape(element, renderConfig);
|
||||
// always ordered as [background, stroke]
|
||||
@@ -384,12 +389,15 @@ const renderElementToSvg = (
|
||||
// stroke (SVGPathString)
|
||||
|
||||
const path = svgRoot.ownerDocument.createElementNS(SVG_NS, "path");
|
||||
path.setAttribute(
|
||||
"fill",
|
||||
renderConfig.theme === THEME.DARK
|
||||
? applyDarkModeFilter(element.strokeColor)
|
||||
: element.strokeColor,
|
||||
);
|
||||
if (isFixedStroke) {
|
||||
path.setAttribute("fill", "none");
|
||||
path.setAttribute("stroke", strokeColor);
|
||||
path.setAttribute("stroke-width", `${element.strokeWidth}`);
|
||||
path.setAttribute("stroke-linecap", "round");
|
||||
path.setAttribute("stroke-linejoin", "round");
|
||||
} else {
|
||||
path.setAttribute("fill", strokeColor);
|
||||
}
|
||||
path.setAttribute("d", shape);
|
||||
wrapper.appendChild(path);
|
||||
} else {
|
||||
|
||||
@@ -1,590 +0,0 @@
|
||||
import { MAX_ZOOM } from "@excalidraw/common";
|
||||
|
||||
import { isShallowEqual } from "@excalidraw/common";
|
||||
|
||||
import { clamp } from "@excalidraw/math";
|
||||
|
||||
import { getNormalizedZoom } from "./normalize";
|
||||
|
||||
import type {
|
||||
AnimateTranslateCanvasValues,
|
||||
AppState,
|
||||
ScrollConstraints,
|
||||
ScrollToContentLockOptions,
|
||||
} from "../types";
|
||||
|
||||
// Constants for viewport zoom factor and overscroll allowance
|
||||
const MIN_VIEWPORT_ZOOM_FACTOR = 0.1;
|
||||
const MAX_VIEWPORT_ZOOM_FACTOR = MAX_ZOOM;
|
||||
const DEFAULT_VIEWPORT_ZOOM_FACTOR = 0.2;
|
||||
const DEFAULT_OVERSCROLL_ALLOWANCE = 0.2;
|
||||
|
||||
// Memoization variable to cache constraints for performance optimization
|
||||
let memoizedValues: {
|
||||
previousState: Pick<
|
||||
AppState,
|
||||
"zoom" | "width" | "height" | "scrollConstraints"
|
||||
>;
|
||||
constraints: ReturnType<typeof calculateConstraints>;
|
||||
allowOverscroll: boolean;
|
||||
} | null = null;
|
||||
|
||||
type CanvasTranslate = Pick<AppState, "scrollX" | "scrollY" | "zoom">;
|
||||
|
||||
export const getScrollConstraintsForBounds = ({
|
||||
bounds,
|
||||
zoom,
|
||||
viewportDimensions,
|
||||
scrollLock,
|
||||
}: {
|
||||
bounds: readonly [number, number, number, number];
|
||||
zoom: AppState["zoom"];
|
||||
viewportDimensions: Pick<AppState, "width" | "height">;
|
||||
scrollLock?: boolean | ScrollToContentLockOptions;
|
||||
}): ScrollConstraints => {
|
||||
const [x1, y1, x2, y2] = bounds;
|
||||
const width = x2 - x1;
|
||||
const height = y2 - y1;
|
||||
const baseZoom = Math.min(
|
||||
viewportDimensions.width / width,
|
||||
viewportDimensions.height / height,
|
||||
);
|
||||
const lockOptions =
|
||||
scrollLock && typeof scrollLock === "object" ? scrollLock : undefined;
|
||||
const viewportZoomFactor =
|
||||
lockOptions?.viewportZoomFactor ?? zoom.value / baseZoom;
|
||||
|
||||
return {
|
||||
x: x1,
|
||||
y: y1,
|
||||
width,
|
||||
height,
|
||||
animateOnNextUpdate: false,
|
||||
lockZoom: !!lockOptions?.lockZoom,
|
||||
overscrollAllowance: lockOptions?.overscrollAllowance,
|
||||
viewportZoomFactor,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Calculates the zoom levels necessary to fit the constrained scrollable area within the viewport on the X and Y axes.
|
||||
*
|
||||
* The function considers the dimensions of the scrollable area, the dimensions of the viewport, the viewport zoom factor,
|
||||
* and whether the zoom should be locked. It then calculates the necessary zoom levels for the X and Y axes separately.
|
||||
* If the zoom should be locked, it calculates the maximum zoom level that fits the scrollable area within the viewport,
|
||||
* factoring in the viewport zoom factor. If the zoom should not be locked, the maximum zoom level is set to null.
|
||||
*
|
||||
* @param scrollConstraints - The constraints of the scrollable area including width, height, and position.
|
||||
* @param width - The width of the viewport.
|
||||
* @param height - The height of the viewport.
|
||||
* @returns An object containing the calculated zoom levels for the X and Y axes, and the initial zoom level.
|
||||
*/
|
||||
const calculateZoomLevel = (
|
||||
scrollConstraints: ScrollConstraints,
|
||||
width: AppState["width"],
|
||||
height: AppState["height"],
|
||||
) => {
|
||||
const viewportZoomFactor = scrollConstraints.viewportZoomFactor
|
||||
? clamp(
|
||||
scrollConstraints.viewportZoomFactor,
|
||||
MIN_VIEWPORT_ZOOM_FACTOR,
|
||||
MAX_VIEWPORT_ZOOM_FACTOR,
|
||||
)
|
||||
: DEFAULT_VIEWPORT_ZOOM_FACTOR;
|
||||
|
||||
const scrollableWidth = scrollConstraints.width;
|
||||
const scrollableHeight = scrollConstraints.height;
|
||||
const zoomLevelX = width / scrollableWidth;
|
||||
const zoomLevelY = height / scrollableHeight;
|
||||
const initialZoomLevel = getNormalizedZoom(
|
||||
Math.min(zoomLevelX, zoomLevelY) * viewportZoomFactor,
|
||||
);
|
||||
return { zoomLevelX, zoomLevelY, initialZoomLevel };
|
||||
};
|
||||
|
||||
/**
|
||||
* Calculates the effective zoom level based on the scroll constraints and current zoom.
|
||||
*
|
||||
* @param params - Object containing scrollConstraints, width, height, and zoom.
|
||||
* @returns An object with the effective zoom level, initial zoom level, and zoom levels for X and Y axes.
|
||||
*/
|
||||
const calculateZoom = ({
|
||||
scrollConstraints,
|
||||
width,
|
||||
height,
|
||||
zoom,
|
||||
}: {
|
||||
scrollConstraints: ScrollConstraints;
|
||||
width: AppState["width"];
|
||||
height: AppState["height"];
|
||||
zoom: AppState["zoom"];
|
||||
}) => {
|
||||
const { zoomLevelX, zoomLevelY, initialZoomLevel } = calculateZoomLevel(
|
||||
scrollConstraints,
|
||||
width,
|
||||
height,
|
||||
);
|
||||
const effectiveZoom = scrollConstraints.lockZoom
|
||||
? Math.max(initialZoomLevel, zoom.value)
|
||||
: zoom.value;
|
||||
return {
|
||||
effectiveZoom: getNormalizedZoom(effectiveZoom),
|
||||
initialZoomLevel,
|
||||
zoomLevelX,
|
||||
zoomLevelY,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Calculates the scroll bounds (min and max scroll values) based on the scroll constraints and zoom level.
|
||||
*
|
||||
* @param params - Object containing scrollConstraints, width, height, effectiveZoom, zoomLevelX, zoomLevelY, and allowOverscroll.
|
||||
* @returns An object with min and max scroll values for X and Y axes.
|
||||
*/
|
||||
const calculateScrollBounds = ({
|
||||
scrollConstraints,
|
||||
width,
|
||||
height,
|
||||
effectiveZoom,
|
||||
zoomLevelX,
|
||||
zoomLevelY,
|
||||
allowOverscroll,
|
||||
}: {
|
||||
scrollConstraints: ScrollConstraints;
|
||||
width: AppState["width"];
|
||||
height: AppState["height"];
|
||||
effectiveZoom: number;
|
||||
zoomLevelX: number;
|
||||
zoomLevelY: number;
|
||||
allowOverscroll: boolean;
|
||||
}) => {
|
||||
const overscrollAllowance =
|
||||
scrollConstraints.overscrollAllowance ?? DEFAULT_OVERSCROLL_ALLOWANCE;
|
||||
const validatedOverscroll = clamp(overscrollAllowance, 0, 1);
|
||||
|
||||
const calculateCenter = (zoom: number) => {
|
||||
const centerX =
|
||||
scrollConstraints.x + (scrollConstraints.width - width / zoom) / -2;
|
||||
const centerY =
|
||||
scrollConstraints.y + (scrollConstraints.height - height / zoom) / -2;
|
||||
return { centerX, centerY };
|
||||
};
|
||||
|
||||
const { centerX, centerY } = calculateCenter(effectiveZoom);
|
||||
|
||||
const overscrollValue = Math.min(
|
||||
validatedOverscroll * scrollConstraints.width,
|
||||
validatedOverscroll * scrollConstraints.height,
|
||||
);
|
||||
|
||||
const fitsX = effectiveZoom <= zoomLevelX;
|
||||
const fitsY = effectiveZoom <= zoomLevelY;
|
||||
|
||||
const getScrollRange = (
|
||||
axis: "x" | "y",
|
||||
fits: boolean,
|
||||
constraint: ScrollConstraints,
|
||||
viewportSize: number,
|
||||
zoom: number,
|
||||
overscroll: number,
|
||||
) => {
|
||||
const { pos, size } =
|
||||
axis === "x"
|
||||
? { pos: constraint.x, size: constraint.width }
|
||||
: { pos: constraint.y, size: constraint.height };
|
||||
const center = axis === "x" ? centerX : centerY;
|
||||
if (allowOverscroll) {
|
||||
return fits
|
||||
? { min: center - overscroll, max: center + overscroll }
|
||||
: {
|
||||
min: pos - size + viewportSize / zoom - overscroll,
|
||||
max: pos + overscroll,
|
||||
};
|
||||
}
|
||||
return fits
|
||||
? { min: center, max: center }
|
||||
: { min: pos - size + viewportSize / zoom, max: pos };
|
||||
};
|
||||
|
||||
const xRange = getScrollRange(
|
||||
"x",
|
||||
fitsX,
|
||||
scrollConstraints,
|
||||
width,
|
||||
effectiveZoom,
|
||||
overscrollValue,
|
||||
);
|
||||
const yRange = getScrollRange(
|
||||
"y",
|
||||
fitsY,
|
||||
scrollConstraints,
|
||||
height,
|
||||
effectiveZoom,
|
||||
overscrollValue,
|
||||
);
|
||||
|
||||
return {
|
||||
minScrollX: xRange.min,
|
||||
maxScrollX: xRange.max,
|
||||
minScrollY: yRange.min,
|
||||
maxScrollY: yRange.max,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Calculates the scroll constraints including min and max scroll values and the effective zoom level.
|
||||
*
|
||||
* @param params - Object containing scrollConstraints, width, height, zoom, and allowOverscroll.
|
||||
* @returns An object with min and max scroll values, effective zoom, and initial zoom level.
|
||||
*/
|
||||
const calculateConstraints = ({
|
||||
scrollConstraints,
|
||||
width,
|
||||
height,
|
||||
zoom,
|
||||
allowOverscroll,
|
||||
}: {
|
||||
scrollConstraints: ScrollConstraints;
|
||||
width: AppState["width"];
|
||||
height: AppState["height"];
|
||||
zoom: AppState["zoom"];
|
||||
allowOverscroll: boolean;
|
||||
}) => {
|
||||
const { effectiveZoom, initialZoomLevel, zoomLevelX, zoomLevelY } =
|
||||
calculateZoom({ scrollConstraints, width, height, zoom });
|
||||
const scrollBounds = calculateScrollBounds({
|
||||
scrollConstraints,
|
||||
width,
|
||||
height,
|
||||
effectiveZoom,
|
||||
zoomLevelX,
|
||||
zoomLevelY,
|
||||
allowOverscroll,
|
||||
});
|
||||
|
||||
return {
|
||||
...scrollBounds,
|
||||
effectiveZoom: { value: effectiveZoom },
|
||||
initialZoomLevel,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Constrains the scroll values within the provided min and max bounds.
|
||||
*
|
||||
* @param params - Object containing scrollX, scrollY, minScrollX, maxScrollX, minScrollY, maxScrollY, and constrainedZoom.
|
||||
* @returns An object with constrained scrollX, scrollY, and zoom.
|
||||
*/
|
||||
const constrainScrollValues = ({
|
||||
scrollX,
|
||||
scrollY,
|
||||
minScrollX,
|
||||
maxScrollX,
|
||||
minScrollY,
|
||||
maxScrollY,
|
||||
constrainedZoom,
|
||||
}: {
|
||||
scrollX: number;
|
||||
scrollY: number;
|
||||
minScrollX: number;
|
||||
maxScrollX: number;
|
||||
minScrollY: number;
|
||||
maxScrollY: number;
|
||||
constrainedZoom: AppState["zoom"];
|
||||
}): CanvasTranslate => {
|
||||
const constrainedScrollX = clamp(scrollX, minScrollX, maxScrollX);
|
||||
const constrainedScrollY = clamp(scrollY, minScrollY, maxScrollY);
|
||||
return {
|
||||
scrollX: constrainedScrollX,
|
||||
scrollY: constrainedScrollY,
|
||||
zoom: constrainedZoom,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Inverts the scroll constraints to align with the state scrollX and scrollY values, which are inverted.
|
||||
* This is a temporary fix and should be removed once issue #5965 is resolved.
|
||||
*
|
||||
* @param originalScrollConstraints - The original scroll constraints.
|
||||
* @returns The aligned scroll constraints with inverted x and y coordinates.
|
||||
*/
|
||||
const alignScrollConstraints = (
|
||||
originalScrollConstraints: ScrollConstraints,
|
||||
): ScrollConstraints => {
|
||||
return {
|
||||
...originalScrollConstraints,
|
||||
x: originalScrollConstraints.x * -1,
|
||||
y: originalScrollConstraints.y * -1,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Determines whether the current viewport is outside the constrained area.
|
||||
*
|
||||
* @param state - The application state.
|
||||
* @returns True if the viewport is outside the constrained area, false otherwise.
|
||||
*/
|
||||
const isViewportOutsideOfConstrainedArea = (state: AppState): boolean => {
|
||||
if (!state.scrollConstraints) {
|
||||
return false;
|
||||
}
|
||||
|
||||
const {
|
||||
scrollX,
|
||||
scrollY,
|
||||
width,
|
||||
height,
|
||||
scrollConstraints: inverseScrollConstraints,
|
||||
zoom,
|
||||
} = state;
|
||||
|
||||
const scrollConstraints = alignScrollConstraints(inverseScrollConstraints);
|
||||
|
||||
const adjustedWidth = width / zoom.value;
|
||||
const adjustedHeight = height / zoom.value;
|
||||
|
||||
return (
|
||||
scrollX > scrollConstraints.x ||
|
||||
scrollX - adjustedWidth < scrollConstraints.x - scrollConstraints.width ||
|
||||
scrollY > scrollConstraints.y ||
|
||||
scrollY - adjustedHeight < scrollConstraints.y - scrollConstraints.height
|
||||
);
|
||||
};
|
||||
|
||||
/**
|
||||
* Calculates the scroll center coordinates and the optimal zoom level to fit the constrained scrollable area within the viewport.
|
||||
*
|
||||
* @param state - The application state.
|
||||
* @param scroll - Object containing current scrollX and scrollY.
|
||||
* @returns An object with the calculated scrollX, scrollY, and zoom.
|
||||
*/
|
||||
export const calculateConstrainedScrollCenter = (
|
||||
state: AppState,
|
||||
{ scrollX, scrollY }: Pick<AppState, "scrollX" | "scrollY">,
|
||||
): CanvasTranslate => {
|
||||
const { width, height, scrollConstraints } = state;
|
||||
if (!scrollConstraints) {
|
||||
return { scrollX, scrollY, zoom: state.zoom };
|
||||
}
|
||||
|
||||
const adjustedConstraints = alignScrollConstraints(scrollConstraints);
|
||||
const zoomLevels = calculateZoomLevel(adjustedConstraints, width, height);
|
||||
const initialZoom = { value: zoomLevels.initialZoomLevel };
|
||||
const constraints = calculateConstraints({
|
||||
scrollConstraints: adjustedConstraints,
|
||||
width,
|
||||
height,
|
||||
zoom: initialZoom,
|
||||
allowOverscroll: false,
|
||||
});
|
||||
|
||||
return {
|
||||
scrollX: constraints.minScrollX,
|
||||
scrollY: constraints.minScrollY,
|
||||
zoom: constraints.effectiveZoom,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Encodes scroll constraints into a compact string.
|
||||
*
|
||||
* @param constraints - The scroll constraints to encode.
|
||||
* @returns A compact encoded string representing the scroll constraints.
|
||||
*/
|
||||
export const encodeConstraints = (constraints: ScrollConstraints): string => {
|
||||
const payload = {
|
||||
x: constraints.x,
|
||||
y: constraints.y,
|
||||
w: constraints.width,
|
||||
h: constraints.height,
|
||||
a: !!constraints.animateOnNextUpdate,
|
||||
l: !!constraints.lockZoom,
|
||||
v: constraints.viewportZoomFactor ?? 1,
|
||||
oa: constraints.overscrollAllowance ?? DEFAULT_OVERSCROLL_ALLOWANCE,
|
||||
};
|
||||
const serialized = JSON.stringify(payload);
|
||||
return encodeURIComponent(window.btoa(serialized).replace(/=+/, ""));
|
||||
};
|
||||
|
||||
/**
|
||||
* Decodes a compact string back into scroll constraints.
|
||||
*
|
||||
* @param encoded - The encoded string representing the scroll constraints.
|
||||
* @returns The decoded scroll constraints object.
|
||||
*/
|
||||
export const decodeConstraints = (encoded: string): ScrollConstraints => {
|
||||
try {
|
||||
const decodedStr = window.atob(decodeURIComponent(encoded));
|
||||
const parsed = JSON.parse(decodedStr) as {
|
||||
x: number;
|
||||
y: number;
|
||||
w: number;
|
||||
h: number;
|
||||
a: boolean;
|
||||
l: boolean;
|
||||
v: number;
|
||||
oa: number;
|
||||
};
|
||||
return {
|
||||
x: parsed.x || 0,
|
||||
y: parsed.y || 0,
|
||||
width: parsed.w || 0,
|
||||
height: parsed.h || 0,
|
||||
lockZoom: parsed.l || false,
|
||||
viewportZoomFactor: parsed.v || 1,
|
||||
animateOnNextUpdate: parsed.a || false,
|
||||
overscrollAllowance: parsed.oa || DEFAULT_OVERSCROLL_ALLOWANCE,
|
||||
};
|
||||
} catch (error) {
|
||||
return {
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 0,
|
||||
height: 0,
|
||||
animateOnNextUpdate: false,
|
||||
lockZoom: false,
|
||||
viewportZoomFactor: 1,
|
||||
overscrollAllowance: DEFAULT_OVERSCROLL_ALLOWANCE,
|
||||
};
|
||||
}
|
||||
};
|
||||
|
||||
type Options = { allowOverscroll: boolean; disableAnimation: boolean };
|
||||
const DEFAULT_OPTION: Options = {
|
||||
allowOverscroll: true,
|
||||
disableAnimation: false,
|
||||
};
|
||||
|
||||
/**
|
||||
* Constrains the AppState scroll values within the defined scroll constraints.
|
||||
*
|
||||
* constraintMode can be "elastic", "rigid", or "loose":
|
||||
* - "elastic": snaps to constraints but allows overscroll
|
||||
* - "rigid": snaps to constraints without overscroll
|
||||
* - "loose": allows overscroll and disables animation/snapping to constraints
|
||||
*
|
||||
* @param state - The original AppState.
|
||||
* @param options - Options for allowing overscroll and disabling animation.
|
||||
* @returns A new AppState object with constrained scroll values.
|
||||
*/
|
||||
export const constrainScrollState = (
|
||||
state: AppState,
|
||||
constraintMode: "elastic" | "rigid" | "loose" = "elastic",
|
||||
): AppState => {
|
||||
if (!state.scrollConstraints) {
|
||||
return state;
|
||||
}
|
||||
const {
|
||||
scrollX,
|
||||
scrollY,
|
||||
width,
|
||||
height,
|
||||
scrollConstraints: inverseScrollConstraints,
|
||||
zoom,
|
||||
} = state;
|
||||
|
||||
let allowOverscroll: boolean;
|
||||
let disableAnimation: boolean;
|
||||
|
||||
switch (constraintMode) {
|
||||
case "elastic":
|
||||
({ allowOverscroll, disableAnimation } = DEFAULT_OPTION);
|
||||
break;
|
||||
case "rigid":
|
||||
allowOverscroll = false;
|
||||
disableAnimation = false;
|
||||
break;
|
||||
case "loose":
|
||||
allowOverscroll = true;
|
||||
disableAnimation = true;
|
||||
break;
|
||||
default:
|
||||
({ allowOverscroll, disableAnimation } = DEFAULT_OPTION);
|
||||
break;
|
||||
}
|
||||
|
||||
const scrollConstraints = alignScrollConstraints(inverseScrollConstraints);
|
||||
|
||||
const canUseMemoizedValues =
|
||||
memoizedValues &&
|
||||
memoizedValues.previousState.scrollConstraints &&
|
||||
memoizedValues.allowOverscroll === allowOverscroll &&
|
||||
isShallowEqual(
|
||||
state.scrollConstraints,
|
||||
memoizedValues.previousState.scrollConstraints,
|
||||
) &&
|
||||
isShallowEqual(
|
||||
{ zoom: zoom.value, width, height },
|
||||
{
|
||||
zoom: memoizedValues.previousState.zoom.value,
|
||||
width: memoizedValues.previousState.width,
|
||||
height: memoizedValues.previousState.height,
|
||||
},
|
||||
);
|
||||
|
||||
const constraints = canUseMemoizedValues
|
||||
? memoizedValues!.constraints
|
||||
: calculateConstraints({
|
||||
scrollConstraints,
|
||||
width,
|
||||
height,
|
||||
zoom,
|
||||
allowOverscroll,
|
||||
});
|
||||
|
||||
if (!canUseMemoizedValues) {
|
||||
memoizedValues = {
|
||||
previousState: {
|
||||
zoom: state.zoom,
|
||||
width: state.width,
|
||||
height: state.height,
|
||||
scrollConstraints: state.scrollConstraints,
|
||||
},
|
||||
constraints,
|
||||
allowOverscroll,
|
||||
};
|
||||
}
|
||||
|
||||
const constrainedValues =
|
||||
zoom.value >= constraints.effectiveZoom.value
|
||||
? constrainScrollValues({
|
||||
scrollX,
|
||||
scrollY,
|
||||
minScrollX: constraints.minScrollX,
|
||||
maxScrollX: constraints.maxScrollX,
|
||||
minScrollY: constraints.minScrollY,
|
||||
maxScrollY: constraints.maxScrollY,
|
||||
constrainedZoom: constraints.effectiveZoom,
|
||||
})
|
||||
: calculateConstrainedScrollCenter(state, { scrollX, scrollY });
|
||||
|
||||
return {
|
||||
...state,
|
||||
scrollConstraints: {
|
||||
...state.scrollConstraints,
|
||||
animateOnNextUpdate: disableAnimation
|
||||
? false
|
||||
: isViewportOutsideOfConstrainedArea(state),
|
||||
},
|
||||
...constrainedValues,
|
||||
};
|
||||
};
|
||||
|
||||
/**
|
||||
* Checks if two canvas translate values are close within a threshold.
|
||||
*
|
||||
* @param from - First set of canvas translate values.
|
||||
* @param to - Second set of canvas translate values.
|
||||
* @returns True if the values are close, false otherwise.
|
||||
*/
|
||||
export const areCanvasTranslatesClose = (
|
||||
from: AnimateTranslateCanvasValues,
|
||||
to: AnimateTranslateCanvasValues,
|
||||
): boolean => {
|
||||
const threshold = 0.1;
|
||||
return (
|
||||
Math.abs(from.scrollX - to.scrollX) < threshold &&
|
||||
Math.abs(from.scrollY - to.scrollY) < threshold &&
|
||||
Math.abs(from.zoom - to.zoom) < threshold
|
||||
);
|
||||
};
|
||||
@@ -1,67 +1,5 @@
|
||||
import { constrainScrollState } from "./scrollConstraints";
|
||||
|
||||
import type { AppState, NormalizedZoomValue } from "../types";
|
||||
|
||||
/**
|
||||
* When zooming out with scroll constraints active, the cursor-anchored zoom may
|
||||
* produce a scroll position outside the valid bounds, causing a snap-back.
|
||||
*
|
||||
* This function adjusts the effective zoom anchor point so the resulting scroll
|
||||
* stays within bounds — silently, without any snap. When no adjustment is needed
|
||||
* (zoom-in, no constraints, or already within bounds) it returns the original
|
||||
* viewport position unchanged.
|
||||
*/
|
||||
export const getConstrainedZoomAnchor = (
|
||||
{
|
||||
viewportX,
|
||||
viewportY,
|
||||
nextZoom,
|
||||
}: { viewportX: number; viewportY: number; nextZoom: NormalizedZoomValue },
|
||||
state: AppState,
|
||||
): { viewportX: number; viewportY: number } => {
|
||||
if (!state.scrollConstraints || nextZoom >= state.zoom.value) {
|
||||
return { viewportX, viewportY };
|
||||
}
|
||||
|
||||
const appLayerX = viewportX - state.offsetLeft;
|
||||
const appLayerY = viewportY - state.offsetTop;
|
||||
const factor = 1 / nextZoom - 1 / state.zoom.value;
|
||||
|
||||
const newScrollX = state.scrollX + appLayerX * factor;
|
||||
const newScrollY = state.scrollY + appLayerY * factor;
|
||||
|
||||
const constrained = constrainScrollState(
|
||||
{
|
||||
...state,
|
||||
scrollX: newScrollX,
|
||||
scrollY: newScrollY,
|
||||
zoom: { value: nextZoom },
|
||||
},
|
||||
"rigid",
|
||||
);
|
||||
|
||||
if (
|
||||
constrained.scrollX === newScrollX &&
|
||||
constrained.scrollY === newScrollY
|
||||
) {
|
||||
return { viewportX, viewportY };
|
||||
}
|
||||
|
||||
const adjustedAppLayerX =
|
||||
constrained.scrollX !== newScrollX
|
||||
? (constrained.scrollX - state.scrollX) / factor
|
||||
: appLayerX;
|
||||
const adjustedAppLayerY =
|
||||
constrained.scrollY !== newScrollY
|
||||
? (constrained.scrollY - state.scrollY) / factor
|
||||
: appLayerY;
|
||||
|
||||
return {
|
||||
viewportX: adjustedAppLayerX + state.offsetLeft,
|
||||
viewportY: adjustedAppLayerY + state.offsetTop,
|
||||
};
|
||||
};
|
||||
|
||||
export const getStateForZoom = (
|
||||
{
|
||||
viewportX,
|
||||
|
||||
@@ -961,7 +961,6 @@ exports[`contextMenu element > right-clicking on a group should select whole gro
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -1159,7 +1158,6 @@ exports[`contextMenu element > selecting 'Add to library' in context menu adds e
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": true,
|
||||
@@ -1375,7 +1373,6 @@ exports[`contextMenu element > selecting 'Bring forward' in context menu brings
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -1708,7 +1705,6 @@ exports[`contextMenu element > selecting 'Bring to front' in context menu brings
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2041,7 +2037,6 @@ exports[`contextMenu element > selecting 'Copy styles' in context menu copies st
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": true,
|
||||
@@ -2257,7 +2252,6 @@ exports[`contextMenu element > selecting 'Delete' in context menu deletes elemen
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2500,7 +2494,6 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2802,7 +2795,6 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3174,7 +3166,6 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3669,7 +3660,6 @@ exports[`contextMenu element > selecting 'Send backward' in context menu sends e
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3994,7 +3984,6 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -4321,7 +4310,6 @@ exports[`contextMenu element > selecting 'Ungroup selection' in context menu ung
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -5608,7 +5596,6 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -6827,7 +6814,6 @@ exports[`contextMenu element > shows 'Ungroup selection' in context menu for gro
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -7787,7 +7773,6 @@ exports[`contextMenu element > shows context menu for canvas > [end of test] app
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -8786,7 +8771,6 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": true,
|
||||
@@ -9782,7 +9766,6 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
|
||||
@@ -85,7 +85,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"id4": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -720,7 +719,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
"id4": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -1284,7 +1282,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -1646,7 +1643,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -2010,7 +2006,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -2272,7 +2267,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -2730,7 +2724,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -3035,7 +3028,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -3356,7 +3348,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -3652,7 +3643,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -3940,7 +3930,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -4177,7 +4166,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -4436,7 +4424,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -4709,7 +4696,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -4940,7 +4926,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -5171,7 +5156,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -5420,7 +5404,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -5678,7 +5661,6 @@ exports[`history > multiplayer undo/redo > conflicts in frames and their childre
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -5937,7 +5919,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"id1": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -6268,7 +6249,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"id8": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -6697,7 +6677,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
"id1": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -7074,7 +7053,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -7385,7 +7363,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -7679,7 +7656,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -7911,7 +7887,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -8265,7 +8240,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -8622,7 +8596,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -9027,7 +9000,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -9308,7 +9280,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -9574,7 +9545,6 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -9841,7 +9811,6 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -10078,7 +10047,6 @@ exports[`history > multiplayer undo/redo > should override remotely added groups
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -10374,7 +10342,6 @@ exports[`history > multiplayer undo/redo > should override remotely added points
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -10693,7 +10660,6 @@ exports[`history > multiplayer undo/redo > should redistribute deltas when eleme
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -10934,7 +10900,6 @@ exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end o
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -11858,7 +11823,6 @@ exports[`history > multiplayer undo/redo > should update history entries after r
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -12120,7 +12084,6 @@ exports[`history > singleplayer undo/redo > remounting undo/redo buttons should
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -12357,7 +12320,6 @@ exports[`history > singleplayer undo/redo > should clear the redo stack on eleme
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -12596,7 +12558,6 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -12992,7 +12953,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on e
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -13201,7 +13161,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on e
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -13413,7 +13372,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on i
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -13713,7 +13671,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on i
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -14016,7 +13973,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on s
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": -50,
|
||||
"scrollY": -50,
|
||||
"searchMatches": null,
|
||||
@@ -14260,7 +14216,6 @@ exports[`history > singleplayer undo/redo > should disable undo/redo buttons whe
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -14499,7 +14454,6 @@ exports[`history > singleplayer undo/redo > should end up with no history entry
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -14740,7 +14694,6 @@ exports[`history > singleplayer undo/redo > should iterate through the history w
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -14987,7 +14940,6 @@ exports[`history > singleplayer undo/redo > should not clear the redo stack on s
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -15323,7 +15275,6 @@ exports[`history > singleplayer undo/redo > should not collapse when applying co
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -15492,7 +15443,6 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -15781,7 +15731,6 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -16046,7 +15995,6 @@ exports[`history > singleplayer undo/redo > should not modify anything on unrela
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -16200,7 +16148,6 @@ exports[`history > singleplayer undo/redo > should not override appstate changes
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -16485,7 +16432,6 @@ exports[`history > singleplayer undo/redo > should support appstate name or view
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -16648,7 +16594,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -17398,7 +17343,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -18046,7 +17990,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -18692,7 +18635,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -19445,7 +19387,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -20215,7 +20156,6 @@ exports[`history > singleplayer undo/redo > should support changes in elements'
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -20697,7 +20637,6 @@ exports[`history > singleplayer undo/redo > should support duplication of groups
|
||||
"id1": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -21210,7 +21149,6 @@ exports[`history > singleplayer undo/redo > should support element creation, del
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
@@ -21671,7 +21609,6 @@ exports[`history > singleplayer undo/redo > should support linear element creati
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"searchMatches": null,
|
||||
|
||||
@@ -88,7 +88,6 @@ exports[`given element A and group of elements B and given both are selected whe
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -516,7 +515,6 @@ exports[`given element A and group of elements B and given both are selected whe
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -930,7 +928,6 @@ exports[`regression tests > Cmd/Ctrl-click exclusively select element under poin
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -1498,7 +1495,6 @@ exports[`regression tests > Drags selected element when hitting only bounding bo
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -1709,7 +1705,6 @@ exports[`regression tests > adjusts z order when grouping > [end of test] appSta
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2095,7 +2090,6 @@ exports[`regression tests > alt-drag duplicates an element > [end of test] appSt
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2340,7 +2334,6 @@ exports[`regression tests > arrow keys > [end of test] appState 1`] = `
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2524,7 +2517,6 @@ exports[`regression tests > can drag element that covers another element, while
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -2849,7 +2841,6 @@ exports[`regression tests > change the properties of a shape > [end of test] app
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3108,7 +3099,6 @@ exports[`regression tests > click on an element and drag it > [dragged] appState
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3351,7 +3341,6 @@ exports[`regression tests > click on an element and drag it > [end of test] appS
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3589,7 +3578,6 @@ exports[`regression tests > click to select a shape > [end of test] appState 1`]
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -3849,7 +3837,6 @@ exports[`regression tests > click-drag to select a group > [end of test] appStat
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -4163,7 +4150,6 @@ exports[`regression tests > deleting last but one element in editing group shoul
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -4604,7 +4590,6 @@ exports[`regression tests > deselects group of selected elements on pointer down
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -4889,7 +4874,6 @@ exports[`regression tests > deselects group of selected elements on pointer up w
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -5166,7 +5150,6 @@ exports[`regression tests > deselects selected element on pointer down when poin
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -5376,7 +5359,6 @@ exports[`regression tests > deselects selected element, on pointer up, when clic
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -5576,7 +5558,6 @@ exports[`regression tests > double click to edit a group > [end of test] appStat
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -5974,7 +5955,6 @@ exports[`regression tests > drags selected elements from point inside common bou
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -6270,7 +6250,6 @@ exports[`regression tests > draw every type of shape > [end of test] appState 1`
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -7063,7 +7042,6 @@ exports[`regression tests > given a group of selected elements with an element t
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -7398,7 +7376,6 @@ exports[`regression tests > given a selected element A and a not selected elemen
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -7679,7 +7656,6 @@ exports[`regression tests > given selected element A with lower z-index than uns
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -7916,7 +7892,6 @@ exports[`regression tests > given selected element A with lower z-index than uns
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -8156,7 +8131,6 @@ exports[`regression tests > key 2 selects rectangle tool > [end of test] appStat
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -8338,7 +8312,6 @@ exports[`regression tests > key 3 selects diamond tool > [end of test] appState
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -8520,7 +8493,6 @@ exports[`regression tests > key 4 selects ellipse tool > [end of test] appState
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -8702,7 +8674,6 @@ exports[`regression tests > key 5 selects arrow tool > [end of test] appState 1`
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -8936,7 +8907,6 @@ exports[`regression tests > key 6 selects line tool > [end of test] appState 1`]
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -9168,7 +9138,6 @@ exports[`regression tests > key 7 selects freedraw tool > [end of test] appState
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -9362,7 +9331,6 @@ exports[`regression tests > key a selects arrow tool > [end of test] appState 1`
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -9596,7 +9564,6 @@ exports[`regression tests > key d selects diamond tool > [end of test] appState
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -9778,7 +9745,6 @@ exports[`regression tests > key l selects line tool > [end of test] appState 1`]
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -10010,7 +9976,6 @@ exports[`regression tests > key o selects ellipse tool > [end of test] appState
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -10192,7 +10157,6 @@ exports[`regression tests > key p selects freedraw tool > [end of test] appState
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -10386,7 +10350,6 @@ exports[`regression tests > key r selects rectangle tool > [end of test] appStat
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -10572,7 +10535,6 @@ exports[`regression tests > make a group and duplicate it > [end of test] appSta
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -11103,7 +11065,6 @@ exports[`regression tests > noop interaction after undo shouldn't create history
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -11383,7 +11344,6 @@ exports[`regression tests > pinch-to-zoom works > [end of test] appState 1`] = `
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": "-6.25000",
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -11510,7 +11470,6 @@ exports[`regression tests > shift click on selected element should deselect it o
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -11713,7 +11672,6 @@ exports[`regression tests > shift-click to multiselect, then drag > [end of test
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -12035,7 +11993,6 @@ exports[`regression tests > should group elements and ungroup them > [end of tes
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -12467,7 +12424,6 @@ exports[`regression tests > single-clicking on a subgroup of a selected group sh
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -13107,7 +13063,6 @@ exports[`regression tests > spacebar + drag scrolls the canvas > [end of test] a
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 60,
|
||||
"scrollY": 60,
|
||||
"scrolledOutside": false,
|
||||
@@ -13234,7 +13189,6 @@ exports[`regression tests > supports nested groups > [end of test] appState 1`]
|
||||
"id0": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -13868,7 +13822,6 @@ exports[`regression tests > switches from group of selected elements to another
|
||||
"id6": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -14208,7 +14161,6 @@ exports[`regression tests > switches selected element on pointer down > [end of
|
||||
"id3": true,
|
||||
},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -14472,7 +14424,6 @@ exports[`regression tests > two-finger scroll works > [end of test] appState 1`]
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 20,
|
||||
"scrollY": "-18.53553",
|
||||
"scrolledOutside": false,
|
||||
@@ -14597,7 +14548,6 @@ exports[`regression tests > undo/redo drawing an element > [end of test] appStat
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -14963,7 +14913,6 @@ exports[`regression tests > updates fontSize & fontFamily appState > [end of tes
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
@@ -15091,7 +15040,6 @@ exports[`regression tests > zoom hotkeys > [end of test] appState 1`] = `
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
|
||||
@@ -160,6 +160,40 @@ describe("restoreElements", () => {
|
||||
});
|
||||
});
|
||||
|
||||
it("should restore fixed freedraw element correctly", () => {
|
||||
const freedrawElement = API.createElement({
|
||||
type: "freedraw",
|
||||
id: "id-freedraw02",
|
||||
strokeShape: "fixed",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10)],
|
||||
});
|
||||
|
||||
const restoredFreedraw = restore.restoreElements(
|
||||
[freedrawElement],
|
||||
null,
|
||||
)[0] as ExcalidrawFreeDrawElement;
|
||||
|
||||
expect(restoredFreedraw.strokeShape).toBe("fixed");
|
||||
});
|
||||
|
||||
it("should restore legacy stable freedraw element as fixed", () => {
|
||||
const restoredFreedraw = restore.restoreElements(
|
||||
[
|
||||
{
|
||||
...API.createElement({
|
||||
type: "freedraw",
|
||||
id: "id-freedraw03",
|
||||
points: [pointFrom(0, 0), pointFrom(10, 10)],
|
||||
}),
|
||||
strokeShape: "stable",
|
||||
} as any,
|
||||
],
|
||||
null,
|
||||
)[0] as ExcalidrawFreeDrawElement;
|
||||
|
||||
expect(restoredFreedraw.strokeShape).toBe("fixed");
|
||||
});
|
||||
|
||||
it("should restore line and draw elements correctly", () => {
|
||||
const lineElement = API.createElement({ type: "line", id: "id-line01" });
|
||||
|
||||
@@ -641,6 +675,26 @@ describe("restoreAppState", () => {
|
||||
expect(restoredAppState.name).toBe(stubImportedAppState.name);
|
||||
});
|
||||
|
||||
it("should restore fixed freedraw stroke type from app state", () => {
|
||||
const restoredAppState = restore.restoreAppState(
|
||||
{ currentItemStrokeShape: "fixed" } as ImportedDataState["appState"],
|
||||
null,
|
||||
);
|
||||
|
||||
expect(restoredAppState.currentItemStrokeShape).toBe("fixed");
|
||||
});
|
||||
|
||||
it("should restore legacy stable freedraw stroke type from app state as fixed", () => {
|
||||
const restoredAppState = restore.restoreAppState(
|
||||
{
|
||||
currentItemStrokeShape: "stable",
|
||||
} as unknown as ImportedDataState["appState"],
|
||||
null,
|
||||
);
|
||||
|
||||
expect(restoredAppState.currentItemStrokeShape).toBe("fixed");
|
||||
});
|
||||
|
||||
it("should return local app state when imported data state is null", () => {
|
||||
const stubLocalAppState = getDefaultAppState();
|
||||
stubLocalAppState.cursorButton = "down";
|
||||
|
||||
@@ -0,0 +1,78 @@
|
||||
import React from "react";
|
||||
|
||||
import { Excalidraw } from "../index";
|
||||
import { API } from "./helpers/api";
|
||||
import { Pointer, UI } from "./helpers/ui";
|
||||
import { render } from "./test-utils";
|
||||
|
||||
describe("freedraw", () => {
|
||||
beforeEach(async () => {
|
||||
await render(<Excalidraw />);
|
||||
});
|
||||
|
||||
it("rounds stored points and drops duplicates after rounding", () => {
|
||||
const mouse = new Pointer("mouse");
|
||||
|
||||
UI.clickTool("freedraw");
|
||||
mouse.downAt(10, 20);
|
||||
mouse.moveTo(10.1234, 20.5678);
|
||||
mouse.moveTo(10.1249, 20.5681);
|
||||
mouse.upAt(20.9999, 30.0001);
|
||||
|
||||
const freedraw = window.h.elements.at(-1);
|
||||
|
||||
expect(freedraw).toEqual(expect.objectContaining({ type: "freedraw" }));
|
||||
expect((freedraw as any).points).toEqual([
|
||||
[0, 0],
|
||||
[0.12, 0.57],
|
||||
[11, 10],
|
||||
]);
|
||||
});
|
||||
|
||||
it("does not snap fixed strokes closed when ending near the start point", () => {
|
||||
const mouse = new Pointer("mouse");
|
||||
|
||||
API.setAppState({ currentItemStrokeShape: "fixed" });
|
||||
UI.clickTool("freedraw");
|
||||
mouse.downAt(10, 10);
|
||||
mouse.moveTo(40, 10);
|
||||
mouse.moveTo(30, 30);
|
||||
mouse.upAt(12, 12);
|
||||
|
||||
const freedraw = window.h.elements.at(-1) as any;
|
||||
|
||||
expect(freedraw.points[0]).toEqual([0, 0]);
|
||||
expect(freedraw.points.at(-1)).not.toEqual([0, 0]);
|
||||
});
|
||||
|
||||
it("coalesces nearly straight fixed freedraw points at the tip", () => {
|
||||
const mouse = new Pointer("mouse");
|
||||
|
||||
API.setAppState({ currentItemStrokeShape: "fixed" });
|
||||
UI.clickTool("freedraw");
|
||||
mouse.downAt(10, 10);
|
||||
|
||||
[
|
||||
[10.2, 10.01],
|
||||
[10.4, 10.03],
|
||||
[10.6, 10.02],
|
||||
[10.8, 10.04],
|
||||
[11, 10.03],
|
||||
[11.2, 10.05],
|
||||
[11.4, 10.04],
|
||||
[11.6, 10.06],
|
||||
[11.8, 10.05],
|
||||
].forEach(([x, y]) => {
|
||||
mouse.moveTo(x, y);
|
||||
});
|
||||
mouse.upAt(12, 10.05);
|
||||
|
||||
const freedraw = window.h.elements.at(-1) as any;
|
||||
|
||||
expect(freedraw.points.length).toBeLessThan(5);
|
||||
expect(freedraw.points).toEqual([
|
||||
[0, 0],
|
||||
[2, 0.05],
|
||||
]);
|
||||
});
|
||||
});
|
||||
@@ -201,6 +201,9 @@ export class API {
|
||||
? ExcalidrawTextElement["containerId"]
|
||||
: never;
|
||||
points?: T extends "arrow" | "line" | "freedraw" ? readonly LocalPoint[] : never;
|
||||
strokeShape?: T extends "freedraw"
|
||||
? ExcalidrawFreeDrawElement["strokeShape"]
|
||||
: never;
|
||||
locked?: boolean;
|
||||
fileId?: T extends "image" ? string : never;
|
||||
scale?: T extends "image" ? ExcalidrawImageElement["scale"] : never;
|
||||
@@ -318,6 +321,7 @@ export class API {
|
||||
type: type as "freedraw",
|
||||
simulatePressure: true,
|
||||
points: rest.points,
|
||||
strokeShape: rest.strokeShape ?? appState.currentItemStrokeShape,
|
||||
...base,
|
||||
});
|
||||
break;
|
||||
|
||||
@@ -28,6 +28,7 @@ import type { GlobalPoint, LocalPoint, Radians } from "@excalidraw/math";
|
||||
import type { TransformHandleType } from "@excalidraw/element";
|
||||
import type {
|
||||
ExcalidrawElement,
|
||||
ExcalidrawFreeDrawElement,
|
||||
ExcalidrawLinearElement,
|
||||
ExcalidrawTextElement,
|
||||
ExcalidrawArrowElement,
|
||||
@@ -432,8 +433,10 @@ type DrawingToolName = Exclude<
|
||||
"lock" | "selection" | "eraser" | "lasso"
|
||||
>;
|
||||
|
||||
type Element<T extends DrawingToolName> = T extends "line" | "freedraw"
|
||||
type Element<T extends DrawingToolName> = T extends "line"
|
||||
? ExcalidrawLinearElement
|
||||
: T extends "freedraw"
|
||||
? ExcalidrawFreeDrawElement
|
||||
: T extends "arrow"
|
||||
? ExcalidrawArrowElement
|
||||
: T extends "text"
|
||||
|
||||
@@ -1,135 +0,0 @@
|
||||
import React from "react";
|
||||
import { vi } from "vitest";
|
||||
|
||||
import { resolvablePromise } from "@excalidraw/common";
|
||||
|
||||
import { Excalidraw } from "../index";
|
||||
|
||||
import { API } from "./helpers/api";
|
||||
import { act, render, waitFor } from "./test-utils";
|
||||
|
||||
import type { ExcalidrawImperativeAPI, ScrollConstraints } from "../types";
|
||||
|
||||
const FIRST_SCROLL_CONSTRAINTS: ScrollConstraints = {
|
||||
x: 0,
|
||||
y: 0,
|
||||
width: 400,
|
||||
height: 300,
|
||||
lockZoom: true,
|
||||
overscrollAllowance: 0,
|
||||
viewportZoomFactor: 1,
|
||||
animateOnNextUpdate: false,
|
||||
};
|
||||
|
||||
const SECOND_SCROLL_CONSTRAINTS: ScrollConstraints = {
|
||||
x: 100,
|
||||
y: 200,
|
||||
width: 500,
|
||||
height: 350,
|
||||
lockZoom: false,
|
||||
overscrollAllowance: 0.2,
|
||||
viewportZoomFactor: 0.8,
|
||||
animateOnNextUpdate: false,
|
||||
};
|
||||
|
||||
describe("scrollConstraints", () => {
|
||||
afterEach(() => {
|
||||
vi.restoreAllMocks();
|
||||
});
|
||||
|
||||
it("syncs prop updates after mount", async () => {
|
||||
const { rerender } = await render(<Excalidraw />);
|
||||
|
||||
expect(window.h.state.scrollConstraints).toBe(null);
|
||||
|
||||
rerender(<Excalidraw scrollConstraints={FIRST_SCROLL_CONSTRAINTS} />);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(window.h.state.scrollConstraints).toEqual(
|
||||
FIRST_SCROLL_CONSTRAINTS,
|
||||
);
|
||||
});
|
||||
|
||||
rerender(<Excalidraw scrollConstraints={SECOND_SCROLL_CONSTRAINTS} />);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(window.h.state.scrollConstraints).toEqual(
|
||||
SECOND_SCROLL_CONSTRAINTS,
|
||||
);
|
||||
});
|
||||
|
||||
rerender(<Excalidraw />);
|
||||
|
||||
await waitFor(() => {
|
||||
expect(window.h.state.scrollConstraints).toBe(null);
|
||||
});
|
||||
});
|
||||
|
||||
it("ignores setScrollConstraints() when the prop is controlled", async () => {
|
||||
const excalidrawAPIPromise = resolvablePromise<ExcalidrawImperativeAPI>();
|
||||
const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
|
||||
|
||||
await render(
|
||||
<Excalidraw
|
||||
scrollConstraints={FIRST_SCROLL_CONSTRAINTS}
|
||||
onExcalidrawAPI={(api) => {
|
||||
if (api) {
|
||||
excalidrawAPIPromise.resolve(api);
|
||||
}
|
||||
}}
|
||||
/>,
|
||||
);
|
||||
|
||||
const excalidrawAPI = await excalidrawAPIPromise;
|
||||
|
||||
act(() => {
|
||||
excalidrawAPI.setScrollConstraints(SECOND_SCROLL_CONSTRAINTS);
|
||||
});
|
||||
|
||||
expect(warn).toHaveBeenCalledWith(
|
||||
"Excalidraw: `setScrollConstraints()` is ignored when the `scrollConstraints` prop is controlled. Update the prop value instead.",
|
||||
);
|
||||
expect(window.h.state.scrollConstraints).toEqual(FIRST_SCROLL_CONSTRAINTS);
|
||||
});
|
||||
|
||||
it("ignores scrollToContent() scrollLock when the prop is controlled", async () => {
|
||||
const excalidrawAPIPromise = resolvablePromise<ExcalidrawImperativeAPI>();
|
||||
const warn = vi.spyOn(console, "warn").mockImplementation(() => {});
|
||||
|
||||
await render(
|
||||
<Excalidraw
|
||||
scrollConstraints={FIRST_SCROLL_CONSTRAINTS}
|
||||
onExcalidrawAPI={(api) => {
|
||||
if (api) {
|
||||
excalidrawAPIPromise.resolve(api);
|
||||
}
|
||||
}}
|
||||
/>,
|
||||
);
|
||||
|
||||
const excalidrawAPI = await excalidrawAPIPromise;
|
||||
const rectangle = API.createElement({
|
||||
x: 1000,
|
||||
y: 1000,
|
||||
width: 100,
|
||||
height: 100,
|
||||
});
|
||||
API.setElements([rectangle]);
|
||||
|
||||
act(() => {
|
||||
excalidrawAPI.scrollToContent(rectangle, {
|
||||
animate: false,
|
||||
fitToViewport: true,
|
||||
scrollLock: {
|
||||
lockZoom: true,
|
||||
overscrollAllowance: 0,
|
||||
},
|
||||
});
|
||||
});
|
||||
|
||||
expect(warn).toHaveBeenCalledWith(
|
||||
"Excalidraw: `scrollToContent()` with `scrollLock` is ignored when the `scrollConstraints` prop is controlled. Update the prop value instead.",
|
||||
);
|
||||
expect(window.h.state.scrollConstraints).toEqual(FIRST_SCROLL_CONSTRAINTS);
|
||||
});
|
||||
});
|
||||
@@ -33,6 +33,7 @@ import type {
|
||||
ExcalidrawNonSelectionElement,
|
||||
BindMode,
|
||||
ExcalidrawTextElement,
|
||||
FreeDrawStrokeShape,
|
||||
} from "@excalidraw/element/types";
|
||||
|
||||
import type {
|
||||
@@ -358,6 +359,7 @@ export interface AppState {
|
||||
currentItemFillStyle: ExcalidrawElement["fillStyle"];
|
||||
currentItemStrokeWidth: number;
|
||||
currentItemStrokeStyle: ExcalidrawElement["strokeStyle"];
|
||||
currentItemStrokeShape?: FreeDrawStrokeShape;
|
||||
currentItemRoughness: number;
|
||||
currentItemOpacity: number;
|
||||
currentItemFontFamily: FontFamilyValues;
|
||||
@@ -454,7 +456,6 @@ export interface AppState {
|
||||
userToFollow: UserToFollow | null;
|
||||
/** the socket ids of the users following the current user */
|
||||
followedBy: Set<SocketId>;
|
||||
scrollConstraints: ScrollConstraints | null;
|
||||
|
||||
/** image cropping */
|
||||
isCropping: boolean;
|
||||
@@ -547,8 +548,6 @@ export type ExcalidrawInitialDataState = Merge<
|
||||
ImportedDataState,
|
||||
{
|
||||
libraryItems?: MaybePromise<Required<ImportedDataState>["libraryItems"]>;
|
||||
scrollX?: number;
|
||||
scrollY?: number;
|
||||
}
|
||||
>;
|
||||
|
||||
@@ -665,7 +664,6 @@ export interface ExcalidrawProps {
|
||||
onScrollChange?: (scrollX: number, scrollY: number, zoom: Zoom) => void;
|
||||
onUserFollow?: (payload: OnUserFollowedPayload) => void;
|
||||
children?: React.ReactNode;
|
||||
scrollConstraints?: AppState["scrollConstraints"];
|
||||
validateEmbeddable?:
|
||||
| boolean
|
||||
| string[]
|
||||
@@ -892,7 +890,7 @@ export type PointerDownState = Readonly<{
|
||||
// We need to have these in the state so that we can unsubscribe them
|
||||
eventListeners: {
|
||||
// It's defined on the initial pointer down event
|
||||
onMove: null | ReturnType<typeof throttleRAF>;
|
||||
onMove: null | ((event: PointerEvent) => void);
|
||||
// It's defined on the initial pointer down event
|
||||
onUp: null | ((event: PointerEvent) => void);
|
||||
// It's defined on the initial pointer down event
|
||||
@@ -992,8 +990,6 @@ export interface ExcalidrawImperativeAPI {
|
||||
) => UnsubscribeCallback;
|
||||
onStateChange: InstanceType<typeof App>["onStateChange"];
|
||||
onEvent: InstanceType<typeof App>["onEvent"];
|
||||
app: InstanceType<typeof App>;
|
||||
setScrollConstraints: InstanceType<typeof App>["setScrollConstraints"];
|
||||
}
|
||||
|
||||
export type FrameNameBounds = {
|
||||
@@ -1060,69 +1056,3 @@ export type Offsets = Partial<{
|
||||
bottom: number;
|
||||
left: number;
|
||||
}>;
|
||||
|
||||
export type ScrollConstraints = {
|
||||
x: number;
|
||||
y: number;
|
||||
width: number;
|
||||
height: number;
|
||||
animateOnNextUpdate?: boolean;
|
||||
/**
|
||||
* A factor that determines the minimum zoom level that should fit the
|
||||
* constrained area into the viewport.
|
||||
*/
|
||||
viewportZoomFactor?: number;
|
||||
/**
|
||||
* If true, the user will not be able to zoom out beyond the scroll
|
||||
* constraints (taking into account the viewportZoomFactor).
|
||||
*/
|
||||
lockZoom?: boolean;
|
||||
/**
|
||||
* <0-1> - how much can you scroll beyond the constrained area within the
|
||||
* timeout window. Note you will still be snapped back to the constrained area
|
||||
* after the timeout.
|
||||
*/
|
||||
overscrollAllowance?: number;
|
||||
};
|
||||
|
||||
/**
|
||||
* Optional scroll constraint settings derived from the final viewport computed
|
||||
* by `scrollToContent()`.
|
||||
*/
|
||||
export type ScrollToContentLockOptions = {
|
||||
lockZoom?: boolean;
|
||||
overscrollAllowance?: number;
|
||||
viewportZoomFactor?: number;
|
||||
};
|
||||
|
||||
export type ScrollToContentOptions =
|
||||
| ({
|
||||
fitToContent?: boolean;
|
||||
fitToViewport?: never;
|
||||
viewportZoomFactor?: number;
|
||||
animate?: boolean;
|
||||
duration?: number;
|
||||
scrollLock?: boolean | ScrollToContentLockOptions;
|
||||
} & {
|
||||
minZoom?: number;
|
||||
maxZoom?: number;
|
||||
canvasOffsets?: Offsets;
|
||||
})
|
||||
| ({
|
||||
fitToContent?: never;
|
||||
fitToViewport?: boolean;
|
||||
viewportZoomFactor?: number;
|
||||
animate?: boolean;
|
||||
duration?: number;
|
||||
scrollLock?: boolean | ScrollToContentLockOptions;
|
||||
} & {
|
||||
minZoom?: number;
|
||||
maxZoom?: number;
|
||||
canvasOffsets?: Offsets;
|
||||
});
|
||||
|
||||
export type AnimateTranslateCanvasValues = {
|
||||
scrollX: AppState["scrollX"];
|
||||
scrollY: AppState["scrollY"];
|
||||
zoom: AppState["zoom"]["value"];
|
||||
};
|
||||
|
||||
@@ -85,7 +85,6 @@ exports[`exportToSvg > with default arguments 1`] = `
|
||||
},
|
||||
"previousSelectedElementIds": {},
|
||||
"resizingElement": null,
|
||||
"scrollConstraints": null,
|
||||
"scrollX": 0,
|
||||
"scrollY": 0,
|
||||
"scrolledOutside": false,
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
{
|
||||
"public": true,
|
||||
"headers": [
|
||||
{
|
||||
"source": "/(.*)",
|
||||
|
||||
Reference in New Issue
Block a user