Compare commits
12 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 9dceb40a4f | |||
| 13cbaebac9 | |||
| 964b7b7b74 | |||
| 3e69b33a28 | |||
| cc1f502a0f | |||
| eb6ab3f5b0 | |||
| 03d46aa62f | |||
| 8059518d85 | |||
| d04eef5a37 | |||
| 62aa998f9a | |||
| 53a49e71a8 | |||
| c94e05970d |
@@ -1,5 +1,4 @@
|
||||
"use client";
|
||||
|
||||
import * as excalidrawLib from "@excalidraw/excalidraw";
|
||||
import { Excalidraw } from "@excalidraw/excalidraw";
|
||||
|
||||
@@ -14,7 +13,6 @@ const ExcalidrawWrapper: React.FC = () => {
|
||||
appTitle={"Excalidraw with Nextjs Example"}
|
||||
useCustom={(api: any, args?: any[]) => {}}
|
||||
excalidrawLib={excalidrawLib}
|
||||
showFadeDemo={true}
|
||||
>
|
||||
<Excalidraw />
|
||||
</App>
|
||||
|
||||
@@ -70,7 +70,6 @@ export interface AppProps {
|
||||
customArgs?: any[];
|
||||
children: React.ReactNode;
|
||||
excalidrawLib: typeof TExcalidraw;
|
||||
showFadeDemo?: boolean;
|
||||
}
|
||||
|
||||
export default function ExampleApp({
|
||||
@@ -79,7 +78,6 @@ export default function ExampleApp({
|
||||
customArgs,
|
||||
children,
|
||||
excalidrawLib,
|
||||
showFadeDemo = false,
|
||||
}: AppProps) {
|
||||
const {
|
||||
exportToCanvas,
|
||||
@@ -118,19 +116,6 @@ export default function ExampleApp({
|
||||
{},
|
||||
);
|
||||
const [comment, setComment] = useState<Comment | null>(null);
|
||||
const [hideAllForFadeDemo, setHideAllForFadeDemo] = useState(false);
|
||||
const [fadeDemoNextIndex, setFadeDemoNextIndex] = useState(0);
|
||||
const [fadeDemoElementIds, setFadeDemoElementIds] = useState<string[]>([]);
|
||||
const [demoAnimationType, setDemoAnimationType] = useState<"fade" | "fly">(
|
||||
"fade",
|
||||
);
|
||||
const [demoAnimationDuration, setDemoAnimationDuration] = useState(500);
|
||||
const [demoFlyFrom, setDemoFlyFrom] = useState<
|
||||
"left" | "right" | "top" | "bottom"
|
||||
>("left");
|
||||
const [demoAnimationEasing, setDemoAnimationEasing] = useState<
|
||||
"linear" | "easeOut" | "easeInOut"
|
||||
>("easeOut");
|
||||
|
||||
const initialStatePromiseRef = useRef<{
|
||||
promise: ResolvablePromise<ExcalidrawInitialDataState | null>;
|
||||
@@ -193,8 +178,7 @@ export default function ExampleApp({
|
||||
const newElement = cloneElement(
|
||||
Excalidraw,
|
||||
{
|
||||
onExcalidrawAPI: (api: ExcalidrawImperativeAPI | null) =>
|
||||
setExcalidrawAPI(api),
|
||||
excalidrawAPI: (api: ExcalidrawImperativeAPI) => setExcalidrawAPI(api),
|
||||
initialData: initialStatePromiseRef.current.promise,
|
||||
onChange: (
|
||||
elements: NonDeletedExcalidrawElement[],
|
||||
@@ -224,10 +208,6 @@ export default function ExampleApp({
|
||||
onPointerDown,
|
||||
onScrollChange: rerenderCommentIcons,
|
||||
validateEmbeddable: true,
|
||||
resolveRenderOpacity: hideAllForFadeDemo
|
||||
? (element: NonDeletedExcalidrawElement) =>
|
||||
fadeDemoElementIds.includes(element.id) ? 0 : undefined
|
||||
: undefined,
|
||||
},
|
||||
<>
|
||||
{excalidrawAPI && (
|
||||
@@ -684,229 +664,6 @@ export default function ExampleApp({
|
||||
>
|
||||
Reset Scene
|
||||
</button>
|
||||
{showFadeDemo && (
|
||||
<>
|
||||
<label>
|
||||
Animation type
|
||||
<select
|
||||
value={demoAnimationType}
|
||||
onChange={(event) =>
|
||||
setDemoAnimationType(
|
||||
event.target.value as "fade" | "fly",
|
||||
)
|
||||
}
|
||||
>
|
||||
<option value="fade">fade</option>
|
||||
<option value="fly">fly</option>
|
||||
</select>
|
||||
</label>
|
||||
<label>
|
||||
Duration
|
||||
<input
|
||||
type="number"
|
||||
value={demoAnimationDuration}
|
||||
onChange={(event) =>
|
||||
setDemoAnimationDuration(Number(event.target.value) || 0)
|
||||
}
|
||||
/>
|
||||
</label>
|
||||
<label>
|
||||
Easing
|
||||
<select
|
||||
value={demoAnimationEasing}
|
||||
onChange={(event) =>
|
||||
setDemoAnimationEasing(
|
||||
event.target.value as "linear" | "easeOut" | "easeInOut",
|
||||
)
|
||||
}
|
||||
>
|
||||
<option value="linear">linear</option>
|
||||
<option value="easeOut">easeOut</option>
|
||||
<option value="easeInOut">easeInOut</option>
|
||||
</select>
|
||||
</label>
|
||||
{demoAnimationType === "fly" && (
|
||||
<label>
|
||||
Fly from
|
||||
<select
|
||||
value={demoFlyFrom}
|
||||
onChange={(event) =>
|
||||
setDemoFlyFrom(
|
||||
event.target.value as
|
||||
| "left"
|
||||
| "right"
|
||||
| "top"
|
||||
| "bottom",
|
||||
)
|
||||
}
|
||||
>
|
||||
<option value="left">left</option>
|
||||
<option value="right">right</option>
|
||||
<option value="top">top</option>
|
||||
<option value="bottom">bottom</option>
|
||||
</select>
|
||||
</label>
|
||||
)}
|
||||
<button
|
||||
onClick={() => {
|
||||
if (!excalidrawAPI) {
|
||||
return;
|
||||
}
|
||||
|
||||
setFadeDemoElementIds(
|
||||
excalidrawAPI
|
||||
.getSceneElements()
|
||||
.map((element) => element.id),
|
||||
);
|
||||
excalidrawAPI.clearElementAnimationOverrides();
|
||||
setHideAllForFadeDemo(true);
|
||||
setFadeDemoNextIndex(0);
|
||||
}}
|
||||
>
|
||||
Hide every element
|
||||
</button>
|
||||
<button
|
||||
onClick={() => {
|
||||
if (!excalidrawAPI || !hideAllForFadeDemo) {
|
||||
return;
|
||||
}
|
||||
|
||||
const elements = excalidrawAPI
|
||||
.getSceneElements()
|
||||
.filter((element) =>
|
||||
fadeDemoElementIds.includes(element.id),
|
||||
);
|
||||
|
||||
if (!elements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
const nextIndex =
|
||||
fadeDemoNextIndex >= elements.length
|
||||
? 0
|
||||
: fadeDemoNextIndex;
|
||||
|
||||
if (nextIndex === 0) {
|
||||
excalidrawAPI.clearElementAnimationOverrides();
|
||||
}
|
||||
|
||||
if (demoAnimationType === "fly") {
|
||||
excalidrawAPI.animateElements({
|
||||
elements: [elements[nextIndex].id],
|
||||
type: "fly",
|
||||
from: demoFlyFrom,
|
||||
duration: demoAnimationDuration,
|
||||
phase: "in",
|
||||
easing: demoAnimationEasing,
|
||||
});
|
||||
} else {
|
||||
excalidrawAPI.animateElements({
|
||||
elements: [elements[nextIndex].id],
|
||||
type: "fade",
|
||||
duration: demoAnimationDuration,
|
||||
phase: "in",
|
||||
easing: demoAnimationEasing,
|
||||
});
|
||||
}
|
||||
|
||||
setFadeDemoNextIndex(nextIndex + 1);
|
||||
}}
|
||||
>
|
||||
Animate in next element
|
||||
</button>
|
||||
<button
|
||||
onClick={() => {
|
||||
if (!excalidrawAPI || !hideAllForFadeDemo) {
|
||||
return;
|
||||
}
|
||||
|
||||
const elements = excalidrawAPI
|
||||
.getSceneElements()
|
||||
.filter((element) =>
|
||||
fadeDemoElementIds.includes(element.id),
|
||||
);
|
||||
|
||||
if (!elements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (demoAnimationType === "fly") {
|
||||
excalidrawAPI.animateElements({
|
||||
elements,
|
||||
type: "fly",
|
||||
from: demoFlyFrom,
|
||||
duration: demoAnimationDuration,
|
||||
stagger: 120,
|
||||
phase: "in",
|
||||
easing: demoAnimationEasing,
|
||||
});
|
||||
} else {
|
||||
excalidrawAPI.animateElements({
|
||||
elements,
|
||||
type: "fade",
|
||||
duration: demoAnimationDuration,
|
||||
stagger: 120,
|
||||
phase: "in",
|
||||
easing: demoAnimationEasing,
|
||||
});
|
||||
}
|
||||
|
||||
setFadeDemoNextIndex(elements.length);
|
||||
}}
|
||||
>
|
||||
Animate in all
|
||||
</button>
|
||||
<button
|
||||
onClick={() => {
|
||||
if (!excalidrawAPI || !hideAllForFadeDemo) {
|
||||
return;
|
||||
}
|
||||
|
||||
const elements = excalidrawAPI
|
||||
.getSceneElements()
|
||||
.filter((element) =>
|
||||
fadeDemoElementIds.includes(element.id),
|
||||
);
|
||||
|
||||
if (!elements.length) {
|
||||
return;
|
||||
}
|
||||
|
||||
const prevIndex = Math.min(
|
||||
fadeDemoNextIndex - 1,
|
||||
elements.length - 1,
|
||||
);
|
||||
|
||||
if (prevIndex < 0) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (demoAnimationType === "fly") {
|
||||
excalidrawAPI.animateElements({
|
||||
elements: [elements[prevIndex].id],
|
||||
type: "fly",
|
||||
from: demoFlyFrom,
|
||||
duration: demoAnimationDuration,
|
||||
phase: "out",
|
||||
easing: demoAnimationEasing,
|
||||
});
|
||||
} else {
|
||||
excalidrawAPI.animateElements({
|
||||
elements: [elements[prevIndex].id],
|
||||
type: "fade",
|
||||
duration: demoAnimationDuration,
|
||||
phase: "out",
|
||||
easing: demoAnimationEasing,
|
||||
});
|
||||
}
|
||||
|
||||
setFadeDemoNextIndex(prevIndex);
|
||||
}}
|
||||
>
|
||||
Animate out prev element
|
||||
</button>
|
||||
</>
|
||||
)}
|
||||
<button
|
||||
onClick={() => {
|
||||
const libraryItems: LibraryItems = [
|
||||
|
||||
@@ -2,28 +2,6 @@ import type { ExcalidrawElementSkeleton } from "@excalidraw/excalidraw/element/t
|
||||
import type { FileId } from "@excalidraw/excalidraw/element/types";
|
||||
|
||||
const elements: ExcalidrawElementSkeleton[] = [
|
||||
// {
|
||||
// type: "arrow",
|
||||
// x: 100,
|
||||
// y: 500,
|
||||
// },
|
||||
// {
|
||||
// type: "arrow",
|
||||
// x: 250,
|
||||
// y: 250,
|
||||
// label: {
|
||||
// text: "HELLO WORLD!!",
|
||||
// },
|
||||
// start: {
|
||||
// type: "rectangle",
|
||||
// // x: -100,
|
||||
// },
|
||||
// end: {
|
||||
// type: "ellipse",
|
||||
// // x: 300,
|
||||
// },
|
||||
// },
|
||||
|
||||
{
|
||||
type: "rectangle",
|
||||
x: 10,
|
||||
@@ -44,14 +22,14 @@ const elements: ExcalidrawElementSkeleton[] = [
|
||||
},
|
||||
id: "2",
|
||||
},
|
||||
// {
|
||||
// type: "arrow",
|
||||
// x: 100,
|
||||
// y: 200,
|
||||
// label: { text: "HELLO WORLD!!" },
|
||||
// start: { type: "rectangle" },
|
||||
// end: { type: "ellipse" },
|
||||
// },
|
||||
{
|
||||
type: "arrow",
|
||||
x: 100,
|
||||
y: 200,
|
||||
label: { text: "HELLO WORLD!!" },
|
||||
start: { type: "rectangle" },
|
||||
end: { type: "ellipse" },
|
||||
},
|
||||
{
|
||||
type: "image",
|
||||
x: 606.1042326312408,
|
||||
@@ -60,11 +38,11 @@ const elements: ExcalidrawElementSkeleton[] = [
|
||||
height: 230,
|
||||
fileId: "rocket" as FileId,
|
||||
},
|
||||
// {
|
||||
// type: "frame",
|
||||
// children: ["1", "2"],
|
||||
// name: "My frame",
|
||||
// },
|
||||
{
|
||||
type: "frame",
|
||||
children: ["1", "2"],
|
||||
name: "My frame",
|
||||
},
|
||||
];
|
||||
export default {
|
||||
elements,
|
||||
|
||||
@@ -1822,7 +1822,7 @@ exports[`Test Transform > should transform the elements correctly when linear el
|
||||
"versionNonce": Any<Number>,
|
||||
"verticalAlign": "middle",
|
||||
"width": 120,
|
||||
"x": 187.75450000000004,
|
||||
"x": 187.7545,
|
||||
"y": 44.5,
|
||||
}
|
||||
`;
|
||||
|
||||
@@ -790,27 +790,41 @@ export const getArrowheadPoints = (
|
||||
p0 = pointFrom(prevOp.data[4], prevOp.data[5]);
|
||||
}
|
||||
|
||||
// B(t) = p0 * (1-t)^3 + 3p1 * t * (1-t)^2 + 3p2 * t^2 * (1-t) + p3 * t^3
|
||||
const equation = (t: number, idx: number) =>
|
||||
Math.pow(1 - t, 3) * p3[idx] +
|
||||
3 * t * Math.pow(1 - t, 2) * p2[idx] +
|
||||
3 * Math.pow(t, 2) * (1 - t) * p1[idx] +
|
||||
p0[idx] * Math.pow(t, 3);
|
||||
|
||||
// Ee know the last point of the arrow (or the first, if start arrowhead).
|
||||
// We know the last point of the arrow (or the first, if start arrowhead).
|
||||
const [x2, y2] = position === "start" ? p0 : p3;
|
||||
|
||||
// By using cubic bezier equation (B(t)) and the given parameters,
|
||||
// we calculate a point that is closer to the last point.
|
||||
// The value 0.3 is chosen arbitrarily and it works best for all
|
||||
// the tested cases.
|
||||
const [x1, y1] = [equation(0.3, 0), equation(0.3, 1)];
|
||||
|
||||
// Find the normalized direction vector based on the
|
||||
// previously calculated points.
|
||||
const distance = Math.hypot(x2 - x1, y2 - y1);
|
||||
const nx = (x2 - x1) / distance;
|
||||
const ny = (y2 - y1) / distance;
|
||||
// Use the analytic tangent at the Bézier endpoint for a precise arrowhead
|
||||
// direction. For a cubic Bézier B(t) with control points p0p3:
|
||||
// B'(1): (p3 − p2) tangent at the end
|
||||
// B'(0): (p1 − p0) for start arrowhead, arrow points away: (p0 − p1)
|
||||
let dx: number;
|
||||
let dy: number;
|
||||
if (position === "end") {
|
||||
dx = p3[0] - p2[0];
|
||||
dy = p3[1] - p2[1];
|
||||
if (Math.hypot(dx, dy) < 1e-6) {
|
||||
dx = p3[0] - p1[0];
|
||||
dy = p3[1] - p1[1];
|
||||
}
|
||||
if (Math.hypot(dx, dy) < 1e-6) {
|
||||
dx = p3[0] - p0[0];
|
||||
dy = p3[1] - p0[1];
|
||||
}
|
||||
} else {
|
||||
dx = p0[0] - p1[0];
|
||||
dy = p0[1] - p1[1];
|
||||
if (Math.hypot(dx, dy) < 1e-6) {
|
||||
dx = p0[0] - p2[0];
|
||||
dy = p0[1] - p2[1];
|
||||
}
|
||||
if (Math.hypot(dx, dy) < 1e-6) {
|
||||
dx = p0[0] - p3[0];
|
||||
dy = p0[1] - p3[1];
|
||||
}
|
||||
}
|
||||
const distance = Math.hypot(dx, dy);
|
||||
const nx = dx / distance;
|
||||
const ny = dy / distance;
|
||||
|
||||
const size = getArrowheadSize(arrowhead);
|
||||
|
||||
@@ -880,30 +894,10 @@ export const getArrowheadPoints = (
|
||||
);
|
||||
|
||||
if (arrowhead === "diamond" || arrowhead === "diamond_outline") {
|
||||
// point opposite to the arrowhead point
|
||||
let ox;
|
||||
let oy;
|
||||
|
||||
if (position === "start") {
|
||||
const [px, py] = element.points.length > 1 ? element.points[1] : [0, 0];
|
||||
|
||||
[ox, oy] = pointRotateRads(
|
||||
pointFrom(tx + minSize * 2, ty),
|
||||
pointFrom(tx, ty),
|
||||
Math.atan2(py - ty, px - tx) as Radians,
|
||||
);
|
||||
} else {
|
||||
const [px, py] =
|
||||
element.points.length > 1
|
||||
? element.points[element.points.length - 2]
|
||||
: [0, 0];
|
||||
|
||||
[ox, oy] = pointRotateRads(
|
||||
pointFrom(tx - minSize * 2, ty),
|
||||
pointFrom(tx, ty),
|
||||
Math.atan2(ty - py, tx - px) as Radians,
|
||||
);
|
||||
}
|
||||
// point opposite to the arrowhead point, just mirrored across the (tx, ty)
|
||||
// point
|
||||
const ox = tx - nx * minSize * 2;
|
||||
const oy = ty - ny * minSize * 2;
|
||||
|
||||
return [tx, ty, x3, y3, ox, oy, x4, y4];
|
||||
}
|
||||
|
||||
@@ -790,9 +790,20 @@ export class LinearElementEditor {
|
||||
elementsMap,
|
||||
);
|
||||
|
||||
const [lines, segCurves] = deconstructLinearOrFreeDrawElement(
|
||||
element,
|
||||
elementsMap,
|
||||
);
|
||||
const segmentCount = lines.length + segCurves.length;
|
||||
|
||||
let index = 0;
|
||||
const midpoints: (GlobalPoint | null)[] = [];
|
||||
while (index < points.length - 1) {
|
||||
if (segmentCount > 0 && index >= segmentCount) {
|
||||
midpoints.push(null);
|
||||
index++;
|
||||
continue;
|
||||
}
|
||||
if (
|
||||
LinearElementEditor.isSegmentTooShort(
|
||||
element,
|
||||
|
||||
@@ -1,7 +1,6 @@
|
||||
import rough from "roughjs/bin/rough";
|
||||
|
||||
import {
|
||||
clamp,
|
||||
type GlobalPoint,
|
||||
isRightAngleRads,
|
||||
lineSegment,
|
||||
@@ -106,62 +105,8 @@ const getCanvasPadding = (element: ExcalidrawElement) => {
|
||||
}
|
||||
};
|
||||
|
||||
export const resolveRenderOpacity = (
|
||||
element: ExcalidrawElement,
|
||||
renderConfig: Pick<
|
||||
StaticCanvasRenderConfig,
|
||||
"elementOpacityOverrides" | "resolveRenderOpacity"
|
||||
>,
|
||||
) => {
|
||||
const override = renderConfig.elementOpacityOverrides?.get(element.id);
|
||||
|
||||
if (override !== undefined) {
|
||||
return clamp(override, 0, 100);
|
||||
}
|
||||
|
||||
const resolvedOpacity = renderConfig.resolveRenderOpacity?.(
|
||||
element as NonDeletedExcalidrawElement,
|
||||
);
|
||||
|
||||
if (resolvedOpacity !== undefined) {
|
||||
return clamp(resolvedOpacity, 0, 100);
|
||||
}
|
||||
|
||||
return element.opacity;
|
||||
};
|
||||
|
||||
export const resolveRenderPositionOffset = (
|
||||
element: ExcalidrawElement,
|
||||
renderConfig: Pick<StaticCanvasRenderConfig, "elementPositionOverrides">,
|
||||
) => {
|
||||
return renderConfig.elementPositionOverrides?.get(element.id) ?? { x: 0, y: 0 };
|
||||
};
|
||||
|
||||
export const getRenderElementWithPositionOverride = <
|
||||
TElement extends NonDeletedExcalidrawElement,
|
||||
>(
|
||||
element: TElement,
|
||||
renderConfig: Pick<StaticCanvasRenderConfig, "elementPositionOverrides">,
|
||||
): TElement => {
|
||||
const positionOffset = resolveRenderPositionOffset(element, renderConfig);
|
||||
|
||||
if (positionOffset.x === 0 && positionOffset.y === 0) {
|
||||
return element;
|
||||
}
|
||||
|
||||
return {
|
||||
...element,
|
||||
x: element.x + positionOffset.x,
|
||||
y: element.y + positionOffset.y,
|
||||
} as TElement;
|
||||
};
|
||||
|
||||
export const getRenderOpacity = (
|
||||
element: ExcalidrawElement,
|
||||
renderConfig: Pick<
|
||||
StaticCanvasRenderConfig,
|
||||
"elementOpacityOverrides" | "resolveRenderOpacity"
|
||||
>,
|
||||
containingFrame: ExcalidrawFrameLikeElement | null,
|
||||
elementsPendingErasure: ElementsPendingErasure,
|
||||
pendingNodes: Readonly<PendingExcalidrawElements> | null,
|
||||
@@ -170,8 +115,7 @@ export const getRenderOpacity = (
|
||||
// multiplying frame opacity with element opacity to combine them
|
||||
// (e.g. frame 50% and element 50% opacity should result in 25% opacity)
|
||||
let opacity =
|
||||
(((containingFrame?.opacity ?? 100) * resolveRenderOpacity(element, renderConfig)) /
|
||||
10000) *
|
||||
(((containingFrame?.opacity ?? 100) * element.opacity) / 10000) *
|
||||
globalAlpha;
|
||||
|
||||
// if pending erasure, multiply again to combine further
|
||||
@@ -847,11 +791,8 @@ export const renderElement = (
|
||||
!appState.selectedElementIds[element.id] &&
|
||||
!appState.hoveredElementIds[element.id];
|
||||
|
||||
element = getRenderElementWithPositionOverride(element, renderConfig);
|
||||
|
||||
context.globalAlpha = getRenderOpacity(
|
||||
element,
|
||||
renderConfig,
|
||||
getContainingFrame(element, elementsMap),
|
||||
renderConfig.elementsPendingErasure,
|
||||
renderConfig.pendingFlowchartNodes,
|
||||
|
||||
+306
-53
@@ -78,6 +78,18 @@ import type {
|
||||
import type { Drawable, Options } from "roughjs/bin/core";
|
||||
import type { Point as RoughPoint } from "roughjs/bin/geometry";
|
||||
|
||||
// Controls how handle distance scales with chord length.
|
||||
// At 1.0 handles are exactly h/3 (standard Hermite). Values below 1 make
|
||||
// short segments curvier and long segments more taut (sub-linear scaling).
|
||||
const CP_CHORD_POWER = 1;
|
||||
|
||||
// At curved knots the C2 spline tangent can be tilted away from the
|
||||
// bisector direction, making one side of the knot tight and the other taut.
|
||||
// This factor [0, 1] controls how far the tangent direction is pulled toward
|
||||
// the bisector (the chord-bisector normal) linearly with turn sharpness.
|
||||
// 0 = pure C2 spline; 1 = tangent fully aligned with the bisector.
|
||||
const CP_ANGLE_CORRECTION = 1;
|
||||
|
||||
export class ShapeCache {
|
||||
private static rg = new RoughGenerator();
|
||||
private static cache = new WeakMap<
|
||||
@@ -625,60 +637,144 @@ export const generateLinearCollisionShape = (
|
||||
});
|
||||
}
|
||||
|
||||
return generator
|
||||
.curve(points as unknown as RoughPoint[], options)
|
||||
.sets[0].ops.slice(0, element.points.length)
|
||||
.map((op, i) => {
|
||||
if (i === 0) {
|
||||
const p = pointRotateRads<GlobalPoint>(
|
||||
pointFrom<GlobalPoint>(
|
||||
element.x + op.data[0],
|
||||
element.y + op.data[1],
|
||||
),
|
||||
center,
|
||||
element.angle,
|
||||
);
|
||||
// Generate collision ops using the same bisector-based cubic Bézier
|
||||
// algorithm as generateRoundedSimpleArrowShape so hit-testing matches rendering.
|
||||
const rotateLocal = (lx: number, ly: number): LocalPoint => {
|
||||
const g = pointRotateRads<GlobalPoint>(
|
||||
pointFrom<GlobalPoint>(element.x + lx, element.y + ly),
|
||||
center,
|
||||
element.angle,
|
||||
);
|
||||
return pointFrom<LocalPoint>(g[0] - element.x, g[1] - element.y);
|
||||
};
|
||||
|
||||
return {
|
||||
op: "move",
|
||||
data: pointFrom<LocalPoint>(p[0] - element.x, p[1] - element.y),
|
||||
};
|
||||
}
|
||||
const collisionOps: Array<{
|
||||
op: string;
|
||||
data: number[] | LocalPoint;
|
||||
}> = [];
|
||||
collisionOps.push({
|
||||
op: "move",
|
||||
data: rotateLocal(points[0][0], points[0][1]),
|
||||
});
|
||||
|
||||
return {
|
||||
op: "bcurveTo",
|
||||
data: [
|
||||
pointRotateRads(
|
||||
pointFrom<GlobalPoint>(
|
||||
element.x + op.data[0],
|
||||
element.y + op.data[1],
|
||||
),
|
||||
center,
|
||||
element.angle,
|
||||
),
|
||||
pointRotateRads(
|
||||
pointFrom<GlobalPoint>(
|
||||
element.x + op.data[2],
|
||||
element.y + op.data[3],
|
||||
),
|
||||
center,
|
||||
element.angle,
|
||||
),
|
||||
pointRotateRads(
|
||||
pointFrom<GlobalPoint>(
|
||||
element.x + op.data[4],
|
||||
element.y + op.data[5],
|
||||
),
|
||||
center,
|
||||
element.angle,
|
||||
),
|
||||
]
|
||||
.map((p) =>
|
||||
pointFrom<LocalPoint>(p[0] - element.x, p[1] - element.y),
|
||||
)
|
||||
.flat(),
|
||||
};
|
||||
if (points.length === 2) {
|
||||
collisionOps.push({
|
||||
op: "lineTo",
|
||||
data: rotateLocal(points[1][0], points[1][1]),
|
||||
});
|
||||
} else {
|
||||
// Chord-length C2 spline. Mirrors generateRoundedSimpleArrowShape
|
||||
// exactly so hit-testing matches rendering.
|
||||
const n = points.length - 1;
|
||||
const h = new Float64Array(n);
|
||||
for (let i = 0; i < n; i++) {
|
||||
h[i] = Math.max(
|
||||
1e-10,
|
||||
Math.hypot(
|
||||
points[i + 1][0] - points[i][0],
|
||||
points[i + 1][1] - points[i][1],
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
const mx = new Float64Array(n + 1);
|
||||
const my = new Float64Array(n + 1);
|
||||
const diag = new Float64Array(n + 1);
|
||||
const rhsX = new Float64Array(n + 1);
|
||||
const rhsY = new Float64Array(n + 1);
|
||||
|
||||
diag[0] = 2;
|
||||
rhsX[0] = (3 * (points[1][0] - points[0][0])) / h[0];
|
||||
rhsY[0] = (3 * (points[1][1] - points[0][1])) / h[0];
|
||||
for (let i = 1; i < n; i++) {
|
||||
diag[i] = 2 * (h[i - 1] + h[i]);
|
||||
rhsX[i] =
|
||||
3 *
|
||||
((h[i] * (points[i][0] - points[i - 1][0])) / h[i - 1] +
|
||||
(h[i - 1] * (points[i + 1][0] - points[i][0])) / h[i]);
|
||||
rhsY[i] =
|
||||
3 *
|
||||
((h[i] * (points[i][1] - points[i - 1][1])) / h[i - 1] +
|
||||
(h[i - 1] * (points[i + 1][1] - points[i][1])) / h[i]);
|
||||
}
|
||||
diag[n] = 2;
|
||||
rhsX[n] = (3 * (points[n][0] - points[n - 1][0])) / h[n - 1];
|
||||
rhsY[n] = (3 * (points[n][1] - points[n - 1][1])) / h[n - 1];
|
||||
|
||||
for (let i = 1; i <= n; i++) {
|
||||
const sub = i < n ? h[i] : 1;
|
||||
const supPrev = i === 1 ? 1 : h[i - 2];
|
||||
const w = sub / diag[i - 1];
|
||||
diag[i] -= w * supPrev;
|
||||
rhsX[i] -= w * rhsX[i - 1];
|
||||
rhsY[i] -= w * rhsY[i - 1];
|
||||
}
|
||||
mx[n] = rhsX[n] / diag[n];
|
||||
my[n] = rhsY[n] / diag[n];
|
||||
for (let i = n - 1; i >= 0; i--) {
|
||||
const sup = i === 0 ? 1 : h[i - 1];
|
||||
mx[i] = (rhsX[i] - sup * mx[i + 1]) / diag[i];
|
||||
my[i] = (rhsY[i] - sup * my[i + 1]) / diag[i];
|
||||
}
|
||||
|
||||
// Normalised tangent directions; handle length scales sub-linearly with chord.
|
||||
const mlen = new Float64Array(n + 1);
|
||||
for (let i = 0; i <= n; i++) {
|
||||
mlen[i] = Math.max(1e-10, Math.hypot(mx[i], my[i]));
|
||||
}
|
||||
|
||||
// At interior knots, blend the C2 tangent direction toward the
|
||||
// bisector direction by a factor proportional to turn sharpness *
|
||||
// CP_ANGLE_CORRECTION
|
||||
for (let k = 1; k < n; k++) {
|
||||
const d1x = (points[k][0] - points[k - 1][0]) / h[k - 1];
|
||||
const d1y = (points[k][1] - points[k - 1][1]) / h[k - 1];
|
||||
const d2x = (points[k + 1][0] - points[k][0]) / h[k];
|
||||
const d2y = (points[k + 1][1] - points[k][1]) / h[k];
|
||||
const dot = d1x * d2x + d1y * d2y;
|
||||
const t = ((1 - dot) / 2) * CP_ANGLE_CORRECTION;
|
||||
if (t < 1e-6) {
|
||||
continue;
|
||||
}
|
||||
const bx = d1x + d2x;
|
||||
const by = d1y + d2y;
|
||||
const blen = Math.hypot(bx, by);
|
||||
if (blen < 1e-10) {
|
||||
continue;
|
||||
}
|
||||
let px = bx / blen;
|
||||
let py = by / blen;
|
||||
const tx = mx[k] / mlen[k];
|
||||
const ty = my[k] / mlen[k];
|
||||
if (tx * px + ty * py < 0) {
|
||||
px = -px;
|
||||
py = -py;
|
||||
}
|
||||
const blendX = tx + t * (px - tx);
|
||||
const blendY = ty + t * (py - ty);
|
||||
const blendLen = Math.max(1e-10, Math.hypot(blendX, blendY));
|
||||
mx[k] = (blendX / blendLen) * mlen[k];
|
||||
my[k] = (blendY / blendLen) * mlen[k];
|
||||
}
|
||||
|
||||
for (let i = 0; i < n; i++) {
|
||||
const cpDist = Math.pow(h[i], CP_CHORD_POWER) / 3;
|
||||
const cp1x = points[i][0] + (mx[i] / mlen[i]) * cpDist;
|
||||
const cp1y = points[i][1] + (my[i] / mlen[i]) * cpDist;
|
||||
const cp2x = points[i + 1][0] - (mx[i + 1] / mlen[i + 1]) * cpDist;
|
||||
const cp2y = points[i + 1][1] - (my[i + 1] / mlen[i + 1]) * cpDist;
|
||||
|
||||
const rcp1 = rotateLocal(cp1x, cp1y);
|
||||
const rcp2 = rotateLocal(cp2x, cp2y);
|
||||
const rend = rotateLocal(points[i + 1][0], points[i + 1][1]);
|
||||
|
||||
collisionOps.push({
|
||||
op: "bcurveTo",
|
||||
data: [rcp1[0], rcp1[1], rcp2[0], rcp2[1], rend[0], rend[1]],
|
||||
});
|
||||
}
|
||||
}
|
||||
return collisionOps;
|
||||
}
|
||||
case "freedraw": {
|
||||
if (element.points.length < 2) {
|
||||
@@ -920,7 +1016,12 @@ const _generateElementShape = (
|
||||
];
|
||||
}
|
||||
} else {
|
||||
shape = [generator.curve(points as unknown as RoughPoint[], options)];
|
||||
shape = [
|
||||
generator.path(
|
||||
generateRoundedSimpleArrowShape(points),
|
||||
generateRoughOptions(element, true, isDarkMode),
|
||||
),
|
||||
];
|
||||
}
|
||||
|
||||
// add lines only in arrow
|
||||
@@ -1004,10 +1105,162 @@ const _generateElementShape = (
|
||||
}
|
||||
};
|
||||
|
||||
const generateRoundedSimpleArrowShape = (
|
||||
points: readonly LocalPoint[],
|
||||
): string => {
|
||||
if (points.length < 2) {
|
||||
return "";
|
||||
}
|
||||
|
||||
if (points.length === 2) {
|
||||
return `M ${points[0][0]} ${points[0][1]} L ${points[1][0]} ${points[1][1]}`;
|
||||
}
|
||||
|
||||
// Chord-length parameterised C2 natural cubic spline (Thomas's algorithm).
|
||||
//
|
||||
// Unknowns: tangent vectors m[0..n] at each knot (n = number of segments).
|
||||
// Chord lengths h[i] = |K[i+1] − K[i]| act as the parameter intervals so
|
||||
// that tightly-spaced knots don't over-influence distant ones.
|
||||
//
|
||||
// Row 0: 2·m₀ + m₁ = 3·(K₁−K₀)/h₀
|
||||
// Row i: h[i]·mᵢ₋₁ + 2·(h[i−1]+h[i])·mᵢ + h[i−1]·mᵢ₊₁
|
||||
// = 3·(h[i]·(Kᵢ−Kᵢ₋₁)/h[i−1]
|
||||
// + h[i−1]·(Kᵢ₊₁−Kᵢ)/h[i]) 1≤i≤n−1
|
||||
// Row n: mₙ₋₁ + 2·mₙ = 3·(Kₙ−Kₙ₋₁)/h[n−1]
|
||||
//
|
||||
// Bézier control points from Hermite→Bézier identity:
|
||||
// cp1ᵢ = Kᵢ + mᵢ · h[i] / 3
|
||||
// cp2ᵢ = Kᵢ₊₁ − mᵢ₊₁ · h[i] / 3
|
||||
const n = points.length - 1; // number of segments
|
||||
const h = new Float64Array(n);
|
||||
for (let i = 0; i < n; i++) {
|
||||
h[i] = Math.max(
|
||||
1e-10,
|
||||
Math.hypot(
|
||||
points[i + 1][0] - points[i][0],
|
||||
points[i + 1][1] - points[i][1],
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
const mx = new Float64Array(n + 1);
|
||||
const my = new Float64Array(n + 1);
|
||||
const diag = new Float64Array(n + 1);
|
||||
const rhsX = new Float64Array(n + 1);
|
||||
const rhsY = new Float64Array(n + 1);
|
||||
|
||||
// Row 0 – natural BC (zero second derivative at start)
|
||||
diag[0] = 2;
|
||||
rhsX[0] = (3 * (points[1][0] - points[0][0])) / h[0];
|
||||
rhsY[0] = (3 * (points[1][1] - points[0][1])) / h[0];
|
||||
|
||||
// Interior rows
|
||||
for (let i = 1; i < n; i++) {
|
||||
diag[i] = 2 * (h[i - 1] + h[i]);
|
||||
rhsX[i] =
|
||||
3 *
|
||||
((h[i] * (points[i][0] - points[i - 1][0])) / h[i - 1] +
|
||||
(h[i - 1] * (points[i + 1][0] - points[i][0])) / h[i]);
|
||||
rhsY[i] =
|
||||
3 *
|
||||
((h[i] * (points[i][1] - points[i - 1][1])) / h[i - 1] +
|
||||
(h[i - 1] * (points[i + 1][1] - points[i][1])) / h[i]);
|
||||
}
|
||||
|
||||
// Row n – natural BC (zero second derivative at end)
|
||||
diag[n] = 2;
|
||||
rhsX[n] = (3 * (points[n][0] - points[n - 1][0])) / h[n - 1];
|
||||
rhsY[n] = (3 * (points[n][1] - points[n - 1][1])) / h[n - 1];
|
||||
|
||||
// Forward sweep
|
||||
// sub[i] = h[i] for i=1..n−1, sub[n] = 1
|
||||
// sup[i] = 1 for i=0, h[i−1] for i=1..n−1 (never modified)
|
||||
for (let i = 1; i <= n; i++) {
|
||||
const sub = i < n ? h[i] : 1;
|
||||
const supPrev = i === 1 ? 1 : h[i - 2];
|
||||
const w = sub / diag[i - 1];
|
||||
diag[i] -= w * supPrev;
|
||||
rhsX[i] -= w * rhsX[i - 1];
|
||||
rhsY[i] -= w * rhsY[i - 1];
|
||||
}
|
||||
|
||||
// Back substitution
|
||||
mx[n] = rhsX[n] / diag[n];
|
||||
my[n] = rhsY[n] / diag[n];
|
||||
for (let i = n - 1; i >= 0; i--) {
|
||||
const sup = i === 0 ? 1 : h[i - 1];
|
||||
mx[i] = (rhsX[i] - sup * mx[i + 1]) / diag[i];
|
||||
my[i] = (rhsY[i] - sup * my[i + 1]) / diag[i];
|
||||
}
|
||||
|
||||
// Normalised tangent directions; handle length scales sub-linearly with chord.
|
||||
const mlen = new Float64Array(n + 1);
|
||||
for (let i = 0; i <= n; i++) {
|
||||
mlen[i] = Math.max(1e-10, Math.hypot(mx[i], my[i]));
|
||||
}
|
||||
|
||||
// At interior knots, blend the C2 tangent direction toward the
|
||||
// perpendicular-to-bisector (the perfectly symmetric tangent) by a factor
|
||||
// proportional to turn sharpness × CP_ANGLE_CORRECTION.
|
||||
// Both cp2 (incoming) and cp1 (outgoing) at the knot share the same adjusted
|
||||
// direction, so collinear (aligned) handles are preserved.
|
||||
for (let k = 1; k < n; k++) {
|
||||
const d1x = (points[k][0] - points[k - 1][0]) / h[k - 1];
|
||||
const d1y = (points[k][1] - points[k - 1][1]) / h[k - 1];
|
||||
const d2x = (points[k + 1][0] - points[k][0]) / h[k];
|
||||
const d2y = (points[k + 1][1] - points[k][1]) / h[k];
|
||||
const dot = d1x * d2x + d1y * d2y;
|
||||
// t: 0 = straight, 1 = hairpin
|
||||
const t = ((1 - dot) / 2) * CP_ANGLE_CORRECTION;
|
||||
if (t < 1e-6) {
|
||||
continue;
|
||||
}
|
||||
// Bisector of the two chord directions as the "normal" at the knot.
|
||||
// Its perpendicular is the ideal symmetric tangent direction.
|
||||
const bx = d1x + d2x;
|
||||
const by = d1y + d2y;
|
||||
const blen = Math.hypot(bx, by);
|
||||
if (blen < 1e-10) {
|
||||
continue; // 180° hairpin – bisector undefined, skip
|
||||
}
|
||||
// Blend target: bisector direction (pick sign aligning with current tangent)
|
||||
let px = bx / blen;
|
||||
let py = by / blen;
|
||||
const tx = mx[k] / mlen[k];
|
||||
const ty = my[k] / mlen[k];
|
||||
if (tx * px + ty * py < 0) {
|
||||
px = -px;
|
||||
py = -py;
|
||||
}
|
||||
// Linear blend of unit directions, then renormalize to preserve magnitude.
|
||||
const blendX = tx + t * (px - tx);
|
||||
const blendY = ty + t * (py - ty);
|
||||
const blendLen = Math.max(1e-10, Math.hypot(blendX, blendY));
|
||||
mx[k] = (blendX / blendLen) * mlen[k];
|
||||
my[k] = (blendY / blendLen) * mlen[k];
|
||||
}
|
||||
|
||||
const path: string[] = [`M ${points[0][0]} ${points[0][1]}`];
|
||||
for (let i = 0; i < n; i++) {
|
||||
const cpDist = Math.pow(h[i], CP_CHORD_POWER) / 3;
|
||||
const cp1x = points[i][0] + (mx[i] / mlen[i]) * cpDist;
|
||||
const cp1y = points[i][1] + (my[i] / mlen[i]) * cpDist;
|
||||
const cp2x = points[i + 1][0] - (mx[i + 1] / mlen[i + 1]) * cpDist;
|
||||
const cp2y = points[i + 1][1] - (my[i + 1] / mlen[i + 1]) * cpDist;
|
||||
path.push(
|
||||
`C ${cp1x} ${cp1y} ${cp2x} ${cp2y} ${points[i + 1][0]} ${
|
||||
points[i + 1][1]
|
||||
}`,
|
||||
);
|
||||
}
|
||||
|
||||
return path.join(" ");
|
||||
};
|
||||
|
||||
const generateElbowArrowShape = (
|
||||
points: readonly LocalPoint[],
|
||||
radius: number,
|
||||
) => {
|
||||
): string => {
|
||||
const subpoints = [] as [number, number][];
|
||||
for (let i = 1; i < points.length - 1; i += 1) {
|
||||
const prev = points[i - 1];
|
||||
|
||||
@@ -135,9 +135,9 @@ describe("getElementBounds", () => {
|
||||
} as ExcalidrawLinearElement;
|
||||
|
||||
const [x1, y1, x2, y2] = getElementBounds(element, arrayToMap([element]));
|
||||
expect(x1).toEqual(360.9291017525165);
|
||||
expect(y1).toEqual(185.24770129343722);
|
||||
expect(x2).toEqual(481.4815539037601);
|
||||
expect(y2).toEqual(319.8162855827246);
|
||||
expect(x1).toEqual(366.0476290709661);
|
||||
expect(y1).toEqual(186.59818534770224);
|
||||
expect(x2).toEqual(494.6034220048372);
|
||||
expect(y2).toEqual(324.16489799221546);
|
||||
});
|
||||
});
|
||||
|
||||
@@ -30,7 +30,7 @@ describe("check rotated elements can be hit:", () => {
|
||||
] as LocalPoint[],
|
||||
});
|
||||
const hit = hitElementItself({
|
||||
point: pointFrom<GlobalPoint>(88, -68),
|
||||
point: pointFrom<GlobalPoint>(90, -70),
|
||||
element: window.h.elements[0],
|
||||
threshold: 10,
|
||||
elementsMap: window.h.scene.getNonDeletedElementsMap(),
|
||||
|
||||
@@ -434,12 +434,12 @@ describe("Test Linear Elements", () => {
|
||||
expect(midPointsWithRoundEdge).toMatchInlineSnapshot(`
|
||||
[
|
||||
[
|
||||
"54.27552",
|
||||
"46.16120",
|
||||
"51.36383",
|
||||
"54.86323",
|
||||
],
|
||||
[
|
||||
"76.95494",
|
||||
"44.56052",
|
||||
"81.64884",
|
||||
"43.04575",
|
||||
],
|
||||
]
|
||||
`);
|
||||
@@ -499,12 +499,12 @@ describe("Test Linear Elements", () => {
|
||||
expect(newMidPoints).toMatchInlineSnapshot(`
|
||||
[
|
||||
[
|
||||
"104.27552",
|
||||
"66.16120",
|
||||
"101.36383",
|
||||
"74.86323",
|
||||
],
|
||||
[
|
||||
"126.95494",
|
||||
"64.56052",
|
||||
"131.64884",
|
||||
"63.04575",
|
||||
],
|
||||
]
|
||||
`);
|
||||
@@ -707,14 +707,8 @@ describe("Test Linear Elements", () => {
|
||||
// This is the expected midpoint for line with round edge
|
||||
// hence hardcoding it so if later some bug is introduced
|
||||
// this will fail and we can fix it
|
||||
const firstSegmentMidpoint = pointFrom<GlobalPoint>(
|
||||
55.9697848965255,
|
||||
47.442326230998205,
|
||||
);
|
||||
const lastSegmentMidpoint = pointFrom<GlobalPoint>(
|
||||
76.08587175006699,
|
||||
43.294165939653226,
|
||||
);
|
||||
const firstSegmentMidpoint = pointFrom<GlobalPoint>(47.30521, 57.2734);
|
||||
const lastSegmentMidpoint = pointFrom<GlobalPoint>(83.70877, 40.46424);
|
||||
let line: ExcalidrawLinearElement;
|
||||
|
||||
beforeEach(() => {
|
||||
@@ -759,16 +753,16 @@ describe("Test Linear Elements", () => {
|
||||
0,
|
||||
],
|
||||
[
|
||||
"85.96978",
|
||||
"77.44233",
|
||||
"77.30521",
|
||||
"87.27340",
|
||||
],
|
||||
[
|
||||
70,
|
||||
50,
|
||||
],
|
||||
[
|
||||
"106.08587",
|
||||
"73.29417",
|
||||
"113.70877",
|
||||
"70.46424",
|
||||
],
|
||||
[
|
||||
40,
|
||||
@@ -815,12 +809,12 @@ describe("Test Linear Elements", () => {
|
||||
expect(newMidPoints).toMatchInlineSnapshot(`
|
||||
[
|
||||
[
|
||||
"29.28349",
|
||||
"20.91105",
|
||||
"22.32088",
|
||||
"37.43003",
|
||||
],
|
||||
[
|
||||
"78.86048",
|
||||
"46.12277",
|
||||
"81.55727",
|
||||
"43.21091",
|
||||
],
|
||||
]
|
||||
`);
|
||||
@@ -904,12 +898,12 @@ describe("Test Linear Elements", () => {
|
||||
expect(newMidPoints).toMatchInlineSnapshot(`
|
||||
[
|
||||
[
|
||||
"54.27552",
|
||||
"46.16120",
|
||||
"51.36383",
|
||||
"54.86323",
|
||||
],
|
||||
[
|
||||
"76.95494",
|
||||
"44.56052",
|
||||
"81.64884",
|
||||
"43.04575",
|
||||
],
|
||||
]
|
||||
`);
|
||||
@@ -1071,8 +1065,8 @@ describe("Test Linear Elements", () => {
|
||||
);
|
||||
expect(position).toMatchInlineSnapshot(`
|
||||
{
|
||||
"x": "86.17305",
|
||||
"y": "76.11251",
|
||||
"x": "86.53100",
|
||||
"y": "72.83556",
|
||||
}
|
||||
`);
|
||||
});
|
||||
@@ -1191,8 +1185,8 @@ describe("Test Linear Elements", () => {
|
||||
20,
|
||||
105,
|
||||
80,
|
||||
"55.45894",
|
||||
45,
|
||||
"56.68277",
|
||||
"47.27188",
|
||||
]
|
||||
`);
|
||||
|
||||
@@ -1202,7 +1196,7 @@ describe("Test Linear Elements", () => {
|
||||
.toMatchInlineSnapshot(`
|
||||
{
|
||||
"height": 130,
|
||||
"width": "366.11716",
|
||||
"width": "368.53316",
|
||||
}
|
||||
`);
|
||||
|
||||
@@ -1214,7 +1208,7 @@ describe("Test Linear Elements", () => {
|
||||
),
|
||||
).toMatchInlineSnapshot(`
|
||||
{
|
||||
"x": "271.11716",
|
||||
"x": "273.53316",
|
||||
"y": 45,
|
||||
}
|
||||
`);
|
||||
@@ -1231,10 +1225,10 @@ describe("Test Linear Elements", () => {
|
||||
[
|
||||
20,
|
||||
35,
|
||||
"501.11716",
|
||||
95,
|
||||
"205.45894",
|
||||
"52.50000",
|
||||
"503.53316",
|
||||
"119.02540",
|
||||
"204.47758",
|
||||
"77.01270",
|
||||
]
|
||||
`);
|
||||
});
|
||||
|
||||
@@ -207,12 +207,10 @@ import {
|
||||
getLineHeightInPx,
|
||||
getApproxMinLineWidth,
|
||||
getApproxMinLineHeight,
|
||||
getMinTextElementWidth,
|
||||
ShapeCache,
|
||||
getRenderOpacity,
|
||||
resolveRenderPositionOffset,
|
||||
resolveRenderOpacity,
|
||||
editGroupForSelectedElement,
|
||||
getMinTextElementWidth,
|
||||
ShapeCache,
|
||||
getRenderOpacity,
|
||||
editGroupForSelectedElement,
|
||||
getElementsInGroup,
|
||||
getSelectedGroupIdForElement,
|
||||
getSelectedGroupIds,
|
||||
@@ -452,7 +450,6 @@ import { searchItemInFocusAtom } from "./SearchMenu";
|
||||
import { isSidebarDockedAtom } from "./Sidebar/Sidebar";
|
||||
import { StaticCanvas, InteractiveCanvas } from "./canvases";
|
||||
import NewElementCanvas from "./canvases/NewElementCanvas";
|
||||
import { AnimationController } from "../renderer/animation";
|
||||
import { isPointHittingLink } from "./hyperlink/helpers";
|
||||
import { MagicIcon, copyIcon, fullscreenIcon } from "./icons";
|
||||
import { AppStateObserver, type OnStateChange } from "./AppStateObserver";
|
||||
@@ -743,235 +740,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
onRemoveEventListenersEmitter = new Emitter<[]>();
|
||||
|
||||
api: ExcalidrawImperativeAPI;
|
||||
private renderAnimationVersion = 0;
|
||||
private elementOpacityOverrides = new Map<string, number>();
|
||||
private elementPositionOverrides = new Map<string, { x: number; y: number }>();
|
||||
private elementAnimationStates = new Map<
|
||||
string,
|
||||
{
|
||||
opacityFrom: number;
|
||||
opacityTo: number;
|
||||
positionFrom: { x: number; y: number };
|
||||
positionTo: { x: number; y: number };
|
||||
easing: "linear" | "easeOut" | "easeInOut";
|
||||
duration: number;
|
||||
delay: number;
|
||||
elapsed: number;
|
||||
}
|
||||
>();
|
||||
|
||||
private getElementAnimationKey = () => `${this.id}:animate-element`;
|
||||
|
||||
private bumpRenderAnimationVersion = () => {
|
||||
this.renderAnimationVersion++;
|
||||
this.setState({});
|
||||
};
|
||||
|
||||
private getRenderOpacityConfig = () => ({
|
||||
elementOpacityOverrides: this.elementOpacityOverrides,
|
||||
elementPositionOverrides: this.elementPositionOverrides,
|
||||
resolveRenderOpacity: this.props.resolveRenderOpacity,
|
||||
});
|
||||
|
||||
private getResolvedElementOpacity = (element: NonDeletedExcalidrawElement) => {
|
||||
return resolveRenderOpacity(element, this.getRenderOpacityConfig());
|
||||
};
|
||||
|
||||
private getElementVisibleOpacity = (element: NonDeletedExcalidrawElement) => {
|
||||
return clamp(element.opacity, 0, 100);
|
||||
};
|
||||
|
||||
private applyAnimationEasing = (
|
||||
progress: number,
|
||||
easing: "linear" | "easeOut" | "easeInOut",
|
||||
) => {
|
||||
switch (easing) {
|
||||
case "linear":
|
||||
return progress;
|
||||
case "easeOut":
|
||||
return easeOut(progress);
|
||||
case "easeInOut":
|
||||
return progress < 0.5
|
||||
? 4 * progress * progress * progress
|
||||
: 1 - Math.pow(-2 * progress + 2, 3) / 2;
|
||||
}
|
||||
};
|
||||
|
||||
private getFlyPositionOffset = (
|
||||
element: NonDeletedExcalidrawElement,
|
||||
from: "left" | "right" | "top" | "bottom",
|
||||
) => {
|
||||
const [x1, y1, x2, y2] = getElementAbsoluteCoords(
|
||||
element,
|
||||
this.scene.getNonDeletedElementsMap(),
|
||||
);
|
||||
const viewportWidth = this.state.width / this.state.zoom.value;
|
||||
const viewportHeight = this.state.height / this.state.zoom.value;
|
||||
const elementWidth = x2 - x1;
|
||||
const elementHeight = y2 - y1;
|
||||
|
||||
switch (from) {
|
||||
case "left":
|
||||
return { x: -(Math.max(viewportWidth, elementWidth) + 64), y: 0 };
|
||||
case "right":
|
||||
return { x: Math.max(viewportWidth, elementWidth) + 64, y: 0 };
|
||||
case "top":
|
||||
return { x: 0, y: -(Math.max(viewportHeight, elementHeight) + 64) };
|
||||
case "bottom":
|
||||
return { x: 0, y: Math.max(viewportHeight, elementHeight) + 64 };
|
||||
}
|
||||
};
|
||||
|
||||
private animateElement = ({
|
||||
id,
|
||||
opacityFrom,
|
||||
opacityTo,
|
||||
positionFrom = { x: 0, y: 0 },
|
||||
positionTo = { x: 0, y: 0 },
|
||||
easing,
|
||||
duration,
|
||||
delay,
|
||||
}: {
|
||||
id: string;
|
||||
opacityFrom: number;
|
||||
opacityTo: number;
|
||||
positionFrom?: { x: number; y: number };
|
||||
positionTo?: { x: number; y: number };
|
||||
easing: "linear" | "easeOut" | "easeInOut";
|
||||
duration: number;
|
||||
delay: number;
|
||||
}) => {
|
||||
const normalizedOpacityFrom = clamp(opacityFrom, 0, 100);
|
||||
const normalizedOpacityTo = clamp(opacityTo, 0, 100);
|
||||
const normalizedDuration = Math.max(duration, 0);
|
||||
const normalizedDelay = Math.max(delay, 0);
|
||||
|
||||
this.elementOpacityOverrides.set(id, normalizedOpacityFrom);
|
||||
|
||||
if (positionFrom.x !== 0 || positionFrom.y !== 0) {
|
||||
this.elementPositionOverrides.set(id, positionFrom);
|
||||
} else {
|
||||
this.elementPositionOverrides.delete(id);
|
||||
}
|
||||
|
||||
if (normalizedDuration === 0 && normalizedDelay === 0) {
|
||||
this.elementAnimationStates.delete(id);
|
||||
this.elementOpacityOverrides.set(id, normalizedOpacityTo);
|
||||
|
||||
if (positionTo.x !== 0 || positionTo.y !== 0) {
|
||||
this.elementPositionOverrides.set(id, positionTo);
|
||||
} else {
|
||||
this.elementPositionOverrides.delete(id);
|
||||
}
|
||||
|
||||
this.bumpRenderAnimationVersion();
|
||||
return;
|
||||
}
|
||||
|
||||
this.elementAnimationStates.set(id, {
|
||||
opacityFrom: normalizedOpacityFrom,
|
||||
opacityTo: normalizedOpacityTo,
|
||||
positionFrom,
|
||||
positionTo,
|
||||
easing,
|
||||
duration: normalizedDuration,
|
||||
delay: normalizedDelay,
|
||||
elapsed: 0,
|
||||
});
|
||||
|
||||
this.bumpRenderAnimationVersion();
|
||||
this.syncElementAnimations();
|
||||
};
|
||||
|
||||
private syncElementAnimations = () => {
|
||||
const animationKey = this.getElementAnimationKey();
|
||||
|
||||
if (this.elementAnimationStates.size === 0) {
|
||||
AnimationController.cancel(animationKey);
|
||||
return;
|
||||
}
|
||||
|
||||
if (AnimationController.running(animationKey)) {
|
||||
return;
|
||||
}
|
||||
|
||||
AnimationController.start(animationKey, ({ deltaTime }) => {
|
||||
let shouldRerender = false;
|
||||
|
||||
for (const [id, animation] of this.elementAnimationStates) {
|
||||
const element = this.scene.getNonDeletedElement(id);
|
||||
|
||||
if (!element) {
|
||||
this.elementAnimationStates.delete(id);
|
||||
shouldRerender =
|
||||
this.elementOpacityOverrides.delete(id) || shouldRerender;
|
||||
shouldRerender =
|
||||
this.elementPositionOverrides.delete(id) || shouldRerender;
|
||||
continue;
|
||||
}
|
||||
|
||||
animation.elapsed += deltaTime;
|
||||
|
||||
const progress =
|
||||
animation.elapsed <= animation.delay
|
||||
? 0
|
||||
: animation.duration === 0
|
||||
? 1
|
||||
: Math.min(
|
||||
(animation.elapsed - animation.delay) / animation.duration,
|
||||
1,
|
||||
);
|
||||
const easedProgress = this.applyAnimationEasing(
|
||||
progress,
|
||||
animation.easing,
|
||||
);
|
||||
|
||||
const nextOpacity =
|
||||
animation.opacityFrom +
|
||||
(animation.opacityTo - animation.opacityFrom) * easedProgress;
|
||||
const nextPosition = {
|
||||
x:
|
||||
animation.positionFrom.x +
|
||||
(animation.positionTo.x - animation.positionFrom.x) * easedProgress,
|
||||
y:
|
||||
animation.positionFrom.y +
|
||||
(animation.positionTo.y - animation.positionFrom.y) * easedProgress,
|
||||
};
|
||||
|
||||
const clampedOpacity = clamp(nextOpacity, 0, 100);
|
||||
|
||||
if (this.elementOpacityOverrides.get(id) !== clampedOpacity) {
|
||||
this.elementOpacityOverrides.set(id, clampedOpacity);
|
||||
shouldRerender = true;
|
||||
}
|
||||
|
||||
const currentPositionOverride =
|
||||
this.elementPositionOverrides.get(id) ?? ({ x: 0, y: 0 } as const);
|
||||
|
||||
if (
|
||||
currentPositionOverride.x !== nextPosition.x ||
|
||||
currentPositionOverride.y !== nextPosition.y
|
||||
) {
|
||||
if (nextPosition.x === 0 && nextPosition.y === 0) {
|
||||
this.elementPositionOverrides.delete(id);
|
||||
} else {
|
||||
this.elementPositionOverrides.set(id, nextPosition);
|
||||
}
|
||||
shouldRerender = true;
|
||||
}
|
||||
|
||||
if (animation.elapsed >= animation.delay + animation.duration) {
|
||||
this.elementAnimationStates.delete(id);
|
||||
}
|
||||
}
|
||||
|
||||
if (shouldRerender) {
|
||||
this.bumpRenderAnimationVersion();
|
||||
}
|
||||
|
||||
return this.elementAnimationStates.size > 0 ? {} : undefined;
|
||||
});
|
||||
};
|
||||
|
||||
private createExcalidrawAPI(): ExcalidrawImperativeAPI {
|
||||
const api: ExcalidrawImperativeAPI = {
|
||||
@@ -989,9 +757,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
clear: this.resetHistory,
|
||||
},
|
||||
scrollToContent: this.scrollToContent,
|
||||
animateElements: this.animateElements,
|
||||
cancelElementAnimation: this.cancelElementAnimation,
|
||||
clearElementAnimationOverrides: this.clearElementAnimationOverrides,
|
||||
getSceneElements: this.getSceneElements,
|
||||
getAppState: () => this.state,
|
||||
getFiles: () => this.files,
|
||||
@@ -1969,10 +1734,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
const isHovered =
|
||||
this.state.activeEmbeddable?.element === el &&
|
||||
this.state.activeEmbeddable?.state === "hover";
|
||||
const renderPositionOffset = resolveRenderPositionOffset(
|
||||
el,
|
||||
this.getRenderOpacityConfig(),
|
||||
);
|
||||
|
||||
// scale video embeds based on zoom (capped) so that smaller embeds
|
||||
// on canvas when zoomed are still of legible quality
|
||||
@@ -1994,14 +1755,13 @@ class App extends React.Component<AppProps, AppState> {
|
||||
})}
|
||||
style={{
|
||||
transform: isVisible
|
||||
? `translate(${x + renderPositionOffset.x * this.state.zoom.value - this.state.offsetLeft}px, ${
|
||||
y + renderPositionOffset.y * this.state.zoom.value - this.state.offsetTop
|
||||
? `translate(${x - this.state.offsetLeft}px, ${
|
||||
y - this.state.offsetTop
|
||||
}px) scale(${scale})`
|
||||
: "none",
|
||||
display: isVisible ? "block" : "none",
|
||||
opacity: getRenderOpacity(
|
||||
el,
|
||||
this.getRenderOpacityConfig(),
|
||||
getContainingFrame(el, this.scene.getNonDeletedElementsMap()),
|
||||
this.elementsPendingErasure,
|
||||
null,
|
||||
@@ -2591,9 +2351,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
pendingFlowchartNodes:
|
||||
this.flowChartCreator.pendingNodes,
|
||||
theme: this.state.theme,
|
||||
...this.getRenderOpacityConfig(),
|
||||
renderAnimationVersion:
|
||||
this.renderAnimationVersion,
|
||||
}}
|
||||
/>
|
||||
{newElementCanvasElement && (
|
||||
@@ -2616,9 +2373,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.elementsPendingErasure,
|
||||
pendingFlowchartNodes: null,
|
||||
theme: this.state.theme,
|
||||
...this.getRenderOpacityConfig(),
|
||||
renderAnimationVersion:
|
||||
this.renderAnimationVersion,
|
||||
}}
|
||||
/>
|
||||
)}
|
||||
@@ -3452,7 +3206,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
this.editorLifecycleEvents.emit("editor:unmount");
|
||||
this.props.onUnmount?.();
|
||||
this.props.onExcalidrawAPI?.(null);
|
||||
AnimationController.cancel(this.getElementAnimationKey());
|
||||
|
||||
(window as any).launchQueue?.setConsumer(() => {});
|
||||
|
||||
@@ -4865,98 +4618,6 @@ class App extends React.Component<AppProps, AppState> {
|
||||
},
|
||||
);
|
||||
|
||||
public animateElements = ({
|
||||
elements,
|
||||
duration = 250,
|
||||
delay = 0,
|
||||
stagger = 0,
|
||||
phase = "in",
|
||||
easing,
|
||||
...animation
|
||||
}:
|
||||
| {
|
||||
elements: readonly (ExcalidrawElement | ExcalidrawElement["id"])[];
|
||||
type: "fade";
|
||||
duration?: number;
|
||||
delay?: number;
|
||||
stagger?: number;
|
||||
phase?: "in" | "out";
|
||||
easing?: "linear" | "easeOut" | "easeInOut";
|
||||
}
|
||||
| {
|
||||
elements: readonly (ExcalidrawElement | ExcalidrawElement["id"])[];
|
||||
type: "fly";
|
||||
from: "left" | "right" | "top" | "bottom";
|
||||
duration?: number;
|
||||
delay?: number;
|
||||
stagger?: number;
|
||||
phase?: "in" | "out";
|
||||
easing?: "linear" | "easeOut" | "easeInOut";
|
||||
}) => {
|
||||
const normalizedDelay = Math.max(delay, 0);
|
||||
const normalizedStagger = Math.max(stagger, 0);
|
||||
|
||||
elements.forEach((elementOrId, index) => {
|
||||
const id = typeof elementOrId === "string" ? elementOrId : elementOrId.id;
|
||||
const element = this.scene.getNonDeletedElement(id);
|
||||
|
||||
if (!element) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (animation.type === "fade") {
|
||||
this.animateElement({
|
||||
id,
|
||||
opacityFrom:
|
||||
phase === "in" ? 0 : this.getElementVisibleOpacity(element),
|
||||
opacityTo:
|
||||
phase === "in" ? this.getElementVisibleOpacity(element) : 0,
|
||||
easing: easing ?? "easeInOut",
|
||||
duration,
|
||||
delay: normalizedDelay + index * normalizedStagger,
|
||||
});
|
||||
return;
|
||||
}
|
||||
|
||||
const flyOffset = this.getFlyPositionOffset(element, animation.from);
|
||||
|
||||
this.animateElement({
|
||||
id,
|
||||
opacityFrom: phase === "in" ? 0 : this.getElementVisibleOpacity(element),
|
||||
opacityTo: phase === "in" ? this.getElementVisibleOpacity(element) : 0,
|
||||
positionFrom: phase === "in" ? flyOffset : { x: 0, y: 0 },
|
||||
positionTo: phase === "in" ? { x: 0, y: 0 } : flyOffset,
|
||||
easing: easing ?? "easeOut",
|
||||
duration,
|
||||
delay: normalizedDelay + index * normalizedStagger,
|
||||
});
|
||||
});
|
||||
};
|
||||
|
||||
public cancelElementAnimation = (id: string) => {
|
||||
if (!this.elementAnimationStates.delete(id)) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.syncElementAnimations();
|
||||
};
|
||||
|
||||
public clearElementAnimationOverrides = () => {
|
||||
if (
|
||||
this.elementOpacityOverrides.size === 0 &&
|
||||
this.elementPositionOverrides.size === 0 &&
|
||||
this.elementAnimationStates.size === 0
|
||||
) {
|
||||
return;
|
||||
}
|
||||
|
||||
this.elementAnimationStates.clear();
|
||||
this.elementOpacityOverrides.clear();
|
||||
this.elementPositionOverrides.clear();
|
||||
this.syncElementAnimations();
|
||||
this.bumpRenderAnimationVersion();
|
||||
};
|
||||
|
||||
public applyDeltas = (
|
||||
deltas: StoreDelta[],
|
||||
options?: ApplyToOptions,
|
||||
|
||||
@@ -99,7 +99,6 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
children,
|
||||
validateEmbeddable,
|
||||
renderEmbeddable,
|
||||
resolveRenderOpacity,
|
||||
aiEnabled,
|
||||
showDeprecatedFonts,
|
||||
renderScrollbars,
|
||||
@@ -218,7 +217,6 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
||||
onDuplicate={onDuplicate}
|
||||
validateEmbeddable={validateEmbeddable}
|
||||
renderEmbeddable={renderEmbeddable}
|
||||
resolveRenderOpacity={resolveRenderOpacity}
|
||||
aiEnabled={aiEnabled !== false}
|
||||
showDeprecatedFonts={showDeprecatedFonts}
|
||||
renderScrollbars={renderScrollbars}
|
||||
|
||||
@@ -14,16 +14,11 @@ import {
|
||||
} from "@excalidraw/element";
|
||||
import {
|
||||
elementOverlapsWithFrame,
|
||||
getContainingFrame,
|
||||
getTargetFrame,
|
||||
shouldApplyFrameClip,
|
||||
} from "@excalidraw/element";
|
||||
|
||||
import {
|
||||
getRenderElementWithPositionOverride,
|
||||
getRenderOpacity,
|
||||
renderElement,
|
||||
} from "@excalidraw/element";
|
||||
import { renderElement } from "@excalidraw/element";
|
||||
|
||||
import { getElementAbsoluteCoords } from "@excalidraw/element";
|
||||
|
||||
@@ -175,10 +170,7 @@ const renderLinkIcon = (
|
||||
context: CanvasRenderingContext2D,
|
||||
appState: StaticCanvasAppState,
|
||||
elementsMap: ElementsMap,
|
||||
renderConfig: StaticCanvasRenderConfig,
|
||||
) => {
|
||||
element = getRenderElementWithPositionOverride(element, renderConfig);
|
||||
|
||||
if (element.link && !appState.selectedElementIds[element.id]) {
|
||||
const [x1, y1, x2, y2] = getElementAbsoluteCoords(element, elementsMap);
|
||||
const [x, y, width, height] = getLinkHandleFromCoords(
|
||||
@@ -229,13 +221,7 @@ const renderLinkIcon = (
|
||||
|
||||
linkCanvasCacheContext.restore();
|
||||
}
|
||||
context.globalAlpha = getRenderOpacity(
|
||||
element,
|
||||
renderConfig,
|
||||
getContainingFrame(element, elementsMap),
|
||||
renderConfig.elementsPendingErasure,
|
||||
renderConfig.pendingFlowchartNodes,
|
||||
);
|
||||
context.globalAlpha = element.opacity / 100;
|
||||
context.drawImage(linkCanvas, x - centerX, y - centerY, width, height);
|
||||
context.restore();
|
||||
}
|
||||
@@ -384,7 +370,7 @@ const _renderStaticScene = ({
|
||||
context.restore();
|
||||
|
||||
if (!isExporting) {
|
||||
renderLinkIcon(element, context, appState, elementsMap, renderConfig);
|
||||
renderLinkIcon(element, context, appState, elementsMap);
|
||||
}
|
||||
} catch (error: any) {
|
||||
console.error(
|
||||
@@ -435,7 +421,7 @@ const _renderStaticScene = ({
|
||||
);
|
||||
}
|
||||
if (!isExporting) {
|
||||
renderLinkIcon(element, context, appState, elementsMap, renderConfig);
|
||||
renderLinkIcon(element, context, appState, elementsMap);
|
||||
}
|
||||
};
|
||||
// - when exporting the whole canvas, we DO NOT apply clipping
|
||||
|
||||
@@ -12,7 +12,6 @@ import type {
|
||||
AppClassProperties,
|
||||
AppState,
|
||||
EmbedsValidationStatus,
|
||||
RenderOpacityResolver,
|
||||
ElementsPendingErasure,
|
||||
InteractiveCanvasAppState,
|
||||
StaticCanvasAppState,
|
||||
@@ -38,13 +37,6 @@ export type StaticCanvasRenderConfig = {
|
||||
elementsPendingErasure: ElementsPendingErasure;
|
||||
pendingFlowchartNodes: PendingExcalidrawElements | null;
|
||||
theme: AppState["theme"];
|
||||
resolveRenderOpacity?: RenderOpacityResolver;
|
||||
elementOpacityOverrides?: ReadonlyMap<ExcalidrawElement["id"], number>;
|
||||
elementPositionOverrides?: ReadonlyMap<
|
||||
ExcalidrawElement["id"],
|
||||
{ x: number; y: number }
|
||||
>;
|
||||
renderAnimationVersion?: number;
|
||||
};
|
||||
|
||||
export type SVGRenderConfig = {
|
||||
|
||||
@@ -567,10 +567,6 @@ export type OnExportProgress = {
|
||||
progress?: number;
|
||||
};
|
||||
|
||||
export type RenderOpacityResolver = (
|
||||
element: NonDeletedExcalidrawElement,
|
||||
) => ExcalidrawElement["opacity"] | undefined;
|
||||
|
||||
export interface ExcalidrawProps {
|
||||
onChange?: (
|
||||
elements: readonly OrderedExcalidrawElement[],
|
||||
@@ -686,7 +682,6 @@ export interface ExcalidrawProps {
|
||||
element: NonDeleted<ExcalidrawEmbeddableElement>,
|
||||
appState: AppState,
|
||||
) => JSX.Element | null;
|
||||
resolveRenderOpacity?: RenderOpacityResolver;
|
||||
aiEnabled?: boolean;
|
||||
showDeprecatedFonts?: boolean;
|
||||
renderScrollbars?: boolean;
|
||||
@@ -967,11 +962,6 @@ export interface ExcalidrawImperativeAPI {
|
||||
getFiles: () => InstanceType<typeof App>["files"];
|
||||
getName: InstanceType<typeof App>["getName"];
|
||||
scrollToContent: InstanceType<typeof App>["scrollToContent"];
|
||||
animateElements: InstanceType<typeof App>["animateElements"];
|
||||
cancelElementAnimation: InstanceType<typeof App>["cancelElementAnimation"];
|
||||
clearElementAnimationOverrides: InstanceType<
|
||||
typeof App
|
||||
>["clearElementAnimationOverrides"];
|
||||
registerAction: (action: Action) => void;
|
||||
refresh: InstanceType<typeof App>["refresh"];
|
||||
setToast: InstanceType<typeof App>["setToast"];
|
||||
|
||||
@@ -196,7 +196,7 @@ export const getEllipseShape = <Point extends GlobalPoint | LocalPoint>(
|
||||
|
||||
export const getCurvePathOps = (shape: Drawable): Op[] => {
|
||||
// NOTE (mtolmacs): Temporary fix for extremely large elements
|
||||
if (!shape) {
|
||||
if (!shape || shape.sets.length === 0) {
|
||||
return [];
|
||||
}
|
||||
|
||||
@@ -316,26 +316,29 @@ export const getClosedCurveShape = <Point extends GlobalPoint | LocalPoint>(
|
||||
};
|
||||
}
|
||||
|
||||
const ops = getCurvePathOps(roughShape);
|
||||
// Prefer the fillPath set
|
||||
const fillPathSet = roughShape.sets.find((s) => s.type === "fillPath");
|
||||
const ops = fillPathSet ? fillPathSet.ops : getCurvePathOps(roughShape);
|
||||
|
||||
const points: Point[] = [];
|
||||
let odd = false;
|
||||
for (const operation of ops) {
|
||||
if (operation.op === "move") {
|
||||
odd = !odd;
|
||||
if (odd) {
|
||||
if (fillPathSet) {
|
||||
// fillPath is always a single run, no odd/even skipping needed
|
||||
points.push(pointFrom(operation.data[0], operation.data[1]));
|
||||
} else {
|
||||
odd = !odd;
|
||||
if (odd) {
|
||||
points.push(pointFrom(operation.data[0], operation.data[1]));
|
||||
}
|
||||
}
|
||||
} else if (operation.op === "bcurveTo") {
|
||||
if (odd) {
|
||||
if (fillPathSet || odd) {
|
||||
points.push(pointFrom(operation.data[0], operation.data[1]));
|
||||
points.push(pointFrom(operation.data[2], operation.data[3]));
|
||||
points.push(pointFrom(operation.data[4], operation.data[5]));
|
||||
}
|
||||
} else if (operation.op === "lineTo") {
|
||||
if (odd) {
|
||||
points.push(pointFrom(operation.data[0], operation.data[1]));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user