From 5625999ecaa4b12fa2abf4308306b101f5b0d36f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?well=C3=A1?= Date: Wed, 15 Jul 2020 12:26:39 +0200 Subject: [PATCH 1/5] make card-titles clickable --- components/Card.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/Card.vue b/components/Card.vue index 021cadf..b18acb5 100644 --- a/components/Card.vue +++ b/components/Card.vue @@ -2,7 +2,7 @@ .card(:class="{ cardActive: isActive }") .card--meta img.card--favicon(:src="'https://www.google.com/s2/favicons?domain=' + resource.url" aria-hidden="true") - p.card--title {{resource.title}} + p.card--title(:href="resource.url" :target='resource.title' rel='noreferrer') {{resource.title}} p.card--description {{resource.desc}} .card--links a.card--reference(@click='createCopyUrl(resource)') Copy From 5dbc3cefc3dcefa02dd032f2c14dfabe51046aa5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?well=C3=A1?= Date: Wed, 15 Jul 2020 12:30:08 +0200 Subject: [PATCH 2/5] fix link not being an anchor on cards --- components/Card.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/Card.vue b/components/Card.vue index b18acb5..80aece1 100644 --- a/components/Card.vue +++ b/components/Card.vue @@ -2,7 +2,7 @@ .card(:class="{ cardActive: isActive }") .card--meta img.card--favicon(:src="'https://www.google.com/s2/favicons?domain=' + resource.url" aria-hidden="true") - p.card--title(:href="resource.url" :target='resource.title' rel='noreferrer') {{resource.title}} + a.card--title(:href="resource.url" :target='resource.title' rel='noreferrer') {{resource.title}} p.card--description {{resource.desc}} .card--links a.card--reference(@click='createCopyUrl(resource)') Copy From c414b639fd22a8f1003cc00a5f163db13cf62f06 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?well=C3=A1?= Date: Wed, 15 Jul 2020 12:32:10 +0200 Subject: [PATCH 3/5] fix card-title styling --- components/Card.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/components/Card.vue b/components/Card.vue index 80aece1..1bee00c 100644 --- a/components/Card.vue +++ b/components/Card.vue @@ -69,6 +69,7 @@ export default { } &--title { + font-size: 16px; font-weight: 900; margin: 0; } From 35516bc93229970582ad5e3bd9859cc03e53a863 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?well=C3=A1?= Date: Wed, 15 Jul 2020 12:32:55 +0200 Subject: [PATCH 4/5] remove margin on titles --- components/Card.vue | 1 + 1 file changed, 1 insertion(+) diff --git a/components/Card.vue b/components/Card.vue index 1bee00c..6ca67b7 100644 --- a/components/Card.vue +++ b/components/Card.vue @@ -72,6 +72,7 @@ export default { font-size: 16px; font-weight: 900; margin: 0; + margin-left: 0; } &--description { From cfc42592095ed24a7a457f0817c4e4e82a9a274e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?well=C3=A1?= Date: Wed, 15 Jul 2020 12:37:24 +0200 Subject: [PATCH 5/5] add !important to fix titles, yikes --- components/Card.vue | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/components/Card.vue b/components/Card.vue index 6ca67b7..2b7cee3 100644 --- a/components/Card.vue +++ b/components/Card.vue @@ -68,11 +68,10 @@ export default { } } - &--title { - font-size: 16px; + &--title { + font-size: 16px !important; font-weight: 900; - margin: 0; - margin-left: 0; + margin: 0 !important; } &--description {