Issue #244 - make ema params configurable. Try to reproduce bug on Security mode

custom_components/versatile_thermostat/ema.py

@@ -9,19 +9,25 @@ from datetime import datetime, tzinfo
 _LOGGER = logging.getLogger(__name__)
 
 MIN_TIME_DECAY_SEC = 0
+
+# MAX_ALPHA:
 # As for the EMA calculation of irregular time series, I've seen that it might be useful to
 # have an upper limit for alpha in case the last measurement was too long ago.
 # For example when using a half life of 10 minutes a measurement that is 60 minutes ago
 # (if there's nothing inbetween) would contribute to the smoothed value with 1,5%,
 # giving the current measurement 98,5% relevance. It could be wise to limit the alpha to e.g. 4x the half life (=0.9375).
-MAX_ALPHA = 0.5
 
 
 class ExponentialMovingAverage:
     """A class that will do the Estimated Mobile Average calculation"""
 
     def __init__(
-        self, vterm_name: str, halflife: float, timezone: tzinfo, precision: int = 3
+        self,
+        vterm_name: str,
+        halflife: float,
+        timezone: tzinfo,
+        precision: int = 3,
+        max_alpha: float = 0.5,
     ):
         """The halflife is the duration in secondes of a normal cycle"""
         self._halflife: float = halflife
@@ -30,6 +36,7 @@ class ExponentialMovingAverage:
         self._last_timestamp: datetime = datetime.now(self._timezone)
         self._name = vterm_name
         self._precision = precision
+        self._max_alpha = max_alpha
 
     def __str__(self) -> str:
         return f"EMA-{self._name}"
@@ -67,7 +74,7 @@ class ExponentialMovingAverage:
 
         alpha = 1 - math.exp(math.log(0.5) * time_decay / self._halflife)
         # capping alpha to avoid gap if last measurement was long time ago
-        alpha = min(alpha, MAX_ALPHA)
+        alpha = min(alpha, self._max_alpha)
         new_ema = alpha * measurement + (1 - alpha) * self._current_ema
 
         self._last_timestamp = timestamp