Add valve change tests (ko)

2023-10-27 06:57:40 +00:00
parent 7afa67336b
commit e7c39f144b
11 changed files with 187 additions and 203 deletions
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -82,7 +82,7 @@ def skip_hass_states_get_fixture():
 def skip_control_heating_fixture():
    """Skip the control_heating of VersatileThermostat"""
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ):
        yield

--- a/tests/test_bugs.py
+++ b/tests/test_bugs.py
@@ -62,9 +62,9 @@ async def test_bug_56(
        # Should not failed
        entity.update_custom_attributes()

-        # try to call _async_control_heating
+        # try to call async_control_heating
        try:
-            ret = await entity._async_control_heating()
+            ret = await entity.async_control_heating()
            # an exception should be send
            assert ret is False
        except Exception:  # pylint: disable=broad-exception-caught
@@ -75,9 +75,9 @@ async def test_bug_56(
        "custom_components.versatile_thermostat.underlyings.UnderlyingClimate.find_underlying_climate",
        return_value=the_mock_underlying,  # dont find the underlying climate
    ):
-        # try to call _async_control_heating
+        # try to call async_control_heating
        try:
-            await entity._async_control_heating()
+            await entity.async_control_heating()
        except UnknownEntity:
            assert False
        except Exception:  # pylint: disable=broad-exception-caught
--- a/tests/test_movement.py
+++ b/tests/test_movement.py
@@ -64,7 +64,7 @@ async def test_movement_management_time_not_enough(

    # start heating, in boost mode, when someone is present. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ):
        await entity.async_set_hvac_mode(HVACMode.HEAT)
        await entity.async_set_preset_mode(PRESET_ACTIVITY)
@@ -261,7 +261,7 @@ async def test_movement_management_time_enough_and_presence(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ):
        await entity.async_set_hvac_mode(HVACMode.HEAT)
        await entity.async_set_preset_mode(PRESET_ACTIVITY)
@@ -393,7 +393,7 @@ async def test_movement_management_time_enoughand_not_presence(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ):
        await entity.async_set_hvac_mode(HVACMode.HEAT)
        await entity.async_set_preset_mode(PRESET_ACTIVITY)
@@ -527,7 +527,7 @@ async def test_movement_management_with_stop_during_condition(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ):
        await entity.async_set_hvac_mode(HVACMode.HEAT)
        await entity.async_set_preset_mode(PRESET_ACTIVITY)
--- a/tests/test_multiple_switch.py
+++ b/tests/test_multiple_switch.py
@@ -58,7 +58,7 @@ async def test_one_switch_cycle(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ):
        await entity.async_set_hvac_mode(HVACMode.HEAT)
        await entity.async_set_preset_mode(PRESET_BOOST)
@@ -75,7 +75,7 @@ async def test_one_switch_cycle(
    with patch(
        "homeassistant.core.StateMachine.is_state", return_value=False
    ) as mock_is_state:
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access

        # Should be call for the Switch
        assert mock_is_state.call_count == 1
@@ -269,7 +269,7 @@ async def test_multiple_switchs(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ), patch(
        "custom_components.versatile_thermostat.underlyings.UnderlyingSwitch.set_hvac_mode"
    ) as mock_underlying_set_hvac_mode:
@@ -285,7 +285,7 @@ async def test_multiple_switchs(
        await send_temperature_change_event(entity, 15, event_timestamp)

        # Checks that all climates are off
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access

        # Should be call for all Switch
        assert mock_underlying_set_hvac_mode.call_count == 4
@@ -405,7 +405,7 @@ async def test_multiple_climates(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ), patch(
        "custom_components.versatile_thermostat.underlyings.UnderlyingClimate.set_hvac_mode"
    ) as mock_underlying_set_hvac_mode:
@@ -427,11 +427,11 @@ async def test_multiple_climates(
                call.set_hvac_mode(HVACMode.HEAT),
            ]
        )
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access

    # Stop heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ), patch(
        "custom_components.versatile_thermostat.underlyings.UnderlyingClimate.set_hvac_mode"
    ) as mock_underlying_set_hvac_mode:
@@ -452,7 +452,7 @@ async def test_multiple_climates(
                call.set_hvac_mode(HVACMode.OFF),
            ]
        )
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access


@pytest.mark.parametrize("expected_lingering_tasks", [True])
@@ -505,7 +505,7 @@ async def test_multiple_climates_underlying_changes(

    # start heating, in boost mode. We block the control_heating to avoid running a cycle
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ), patch(
        "custom_components.versatile_thermostat.underlyings.UnderlyingClimate.set_hvac_mode"
    ) as mock_underlying_set_hvac_mode:
@@ -527,11 +527,11 @@ async def test_multiple_climates_underlying_changes(
                call.set_hvac_mode(HVACMode.HEAT),
            ]
        )
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access

    # Stop heating on one underlying climate
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ), patch(
        "custom_components.versatile_thermostat.underlyings.UnderlyingClimate.set_hvac_mode"
    ) as mock_underlying_set_hvac_mode:
@@ -554,11 +554,11 @@ async def test_multiple_climates_underlying_changes(
            ]
        )
        assert entity.hvac_mode == HVACMode.OFF
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access

    # Start heating on one underlying climate
    with patch(
-        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat._async_control_heating"
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.async_control_heating"
    ), patch(
        "custom_components.versatile_thermostat.underlyings.UnderlyingClimate.set_hvac_mode"
    ) as mock_underlying_set_hvac_mode, patch(
@@ -587,4 +587,4 @@ async def test_multiple_climates_underlying_changes(
        )
        assert entity.hvac_mode == HVACMode.HEAT
        assert entity.hvac_action == HVACAction.IDLE
-        assert entity._is_device_active is False  # pylint: disable=protected-access
+        assert entity.is_device_active is False  # pylint: disable=protected-access
--- a/tests/test_valve.py
+++ b/tests/test_valve.py
@@ -1,3 +1,5 @@
+# pylint: disable=line-too-long
+
 """ Test the normal start of a Switch AC Thermostat """
 from unittest.mock import patch, call
 from datetime import datetime, timedelta
@@ -11,7 +13,6 @@ from homeassistant.components.climate import ClimateEntity, DOMAIN as CLIMATE_DO

 from pytest_homeassistant_custom_component.common import MockConfigEntry

-from custom_components.versatile_thermostat.base_thermostat import BaseThermostat
 from custom_components.versatile_thermostat.thermostat_valve import ThermostatOverValve

 from .commons import *  # pylint: disable=wildcard-import, unused-wildcard-import
@@ -84,7 +85,7 @@ async def test_over_valve_full_start(hass: HomeAssistant, skip_hass_states_is_st
                    return entity

        # The name is in the CONF and not the title of the entry
-        entity: BaseThermostat = find_my_entity("climate.theovervalvemockname")
+        entity: ThermostatOverValve = find_my_entity("climate.theovervalvemockname")

        assert entity
        assert isinstance(entity, ThermostatOverValve)
@@ -114,7 +115,6 @@ async def test_over_valve_full_start(hass: HomeAssistant, skip_hass_states_is_st

        # should have been called with EventType.PRESET_EVENT and EventType.HVAC_MODE_EVENT
        assert mock_send_event.call_count == 2
-
        mock_send_event.assert_has_calls(
            [
                call.send_event(EventType.PRESET_EVENT, {"preset": PRESET_NONE}),
@@ -125,9 +125,73 @@ async def test_over_valve_full_start(hass: HomeAssistant, skip_hass_states_is_st
            ]
        )

+    # Set the HVACMode to HEAT, with manual preset and target_temp to 18 before receiving temperature
+    with patch(
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.send_event"
+    ) as mock_send_event:
        # Select a hvacmode, presence and preset
-        await entity.async_set_hvac_mode(HVACMode.COOL)
-        assert entity.hvac_mode is HVACMode.COOL
+        await entity.async_set_hvac_mode(HVACMode.HEAT)
+        #
+        assert entity.hvac_mode is HVACMode.HEAT
+        # No heating now
+        assert entity.valve_open_percent == 0
+        assert entity.hvac_action == HVACAction.IDLE
+        assert mock_send_event.call_count == 1
+        mock_send_event.assert_has_calls(
+            [
+                call.send_event(
+                    EventType.HVAC_MODE_EVENT,
+                    {"hvac_mode": HVACMode.HEAT},
+                ),
+            ]
+        )
+
+        # set manual target temp
+        await entity.async_set_temperature(temperature=18)
+        assert entity.preset_mode == PRESET_NONE # Manual mode
+        assert entity.target_temperature == 18
+        # Nothing have changed cause we don't have room and external temperature
+        assert mock_send_event.call_count == 1
+
+
+    # Set temperature and external temperature
+    with patch(
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.send_event"
+    ) as mock_send_event, patch(
+        "homeassistant.core.ServiceRegistry.async_call"
+    ) as mock_service_call, patch(
+        "custom_components.versatile_thermostat.underlyings.UnderlyingValve.is_device_active", return_value=True
+    ):
+        # Change temperature
+        event_timestamp = now - timedelta(minutes=10)
+        await send_temperature_change_event(entity, 15, datetime.now())
+        await send_ext_temperature_change_event(entity, 10, datetime.now())
+        # Should heating strongly now
+        assert entity.valve_open_percent == 98
+        assert entity.is_device_active is True
+        assert entity.hvac_action == HVACAction.HEATING
+
+        assert mock_service_call.call_count == 2
+        mock_service_call.assert_has_calls([
+            call.async_call(
+                HA_DOMAIN,
+                SERVICE_SET_VALUE,
+                {
+                    "value": 90
+                }
+            ),
+            call.async_call(
+                HA_DOMAIN,
+                SERVICE_SET_VALUE,
+                {
+                    "value": 98
+                }
+            )
+        ])
+
+        assert mock_send_event.call_count == 0
+
+        # ICI

        event_timestamp = now - timedelta(minutes=4)
        await send_presence_change_event(entity, True, False, event_timestamp)