gilles/versatile_thermostat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #295 - No floating point value for target temp

Browse Source
This commit is contained in:
Jean-Marc Collin
2024-01-01 16:55:41 +00:00
parent d05df021ab
commit c222feda1a
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
custom_components/versatile_thermostat/underlyings.py
View File

@@ -690,7 +690,7 @@ class UnderlyingClimate(UnderlyingEntity):
min_val = self._underlying_climate.min_temp min_val = self._underlying_climate.min_temp
max_val = self._underlying_climate.max_temp max_val = self._underlying_climate.max_temp
new_value = round(max(min_val, min(value, max_val))) new_value = max(min_val, min(value, max_val))
else: else:
_LOGGER.debug("%s - no min and max attributes on underlying", self) _LOGGER.debug("%s - no min and max attributes on underlying", self)
new_value = value new_value = value

8
tests/test_bugs.py
View File

@@ -632,7 +632,7 @@ async def test_bug_272(
await entity.async_set_hvac_mode(HVACMode.HEAT) await entity.async_set_hvac_mode(HVACMode.HEAT)
# In the accepted interval # In the accepted interval
await entity.async_set_temperature(temperature=17) await entity.async_set_temperature(temperature=17.5)
assert mock_service_call.call_count == 2 assert mock_service_call.call_count == 2
mock_service_call.assert_has_calls( mock_service_call.assert_has_calls(
[ [
@@ -646,7 +646,7 @@ async def test_bug_272(
SERVICE_SET_TEMPERATURE, SERVICE_SET_TEMPERATURE,
{ {
"entity_id": "climate.mock_climate", "entity_id": "climate.mock_climate",
"temperature": 17, "temperature": 17.5,
"target_temp_high": 30, "target_temp_high": 30,
"target_temp_low": 15, "target_temp_low": 15,
}, },
@@ -666,7 +666,7 @@ async def test_bug_272(
await send_temperature_change_event(entity, 13, event_timestamp) await send_temperature_change_event(entity, 13, event_timestamp)
await send_ext_temperature_change_event(entity, 9, event_timestamp) await send_ext_temperature_change_event(entity, 9, event_timestamp)
# In the accepted interval # Not in the accepted interval (15-19)
await entity.async_set_temperature(temperature=10) await entity.async_set_temperature(temperature=10)
assert mock_service_call.call_count == 1 assert mock_service_call.call_count == 1
mock_service_call.assert_has_calls( mock_service_call.assert_has_calls(
@@ -694,7 +694,7 @@ async def test_bug_272(
await send_ext_temperature_change_event(entity, 9, event_timestamp) await send_ext_temperature_change_event(entity, 9, event_timestamp)
# In the accepted interval # In the accepted interval
await entity.async_set_temperature(temperature=20) await entity.async_set_temperature(temperature=20.8)
assert mock_service_call.call_count == 1 assert mock_service_call.call_count == 1
mock_service_call.assert_has_calls( mock_service_call.assert_has_calls(
[ [