gilles/versatile_thermostat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

issue #733 - VTherm over_climate not following TRV device setpoint when step if < 1 (#736)

Browse Source 
Co-authored-by: Jean-Marc Collin <jean-marc.collin-extern@renault.com>
This commit is contained in:
Jean-Marc Collin
2024-12-22 16:14:33 +01:00
committed by GitHub
parent 65b4690e64
commit 8559dd144a
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
custom_components/versatile_thermostat/thermostat_climate.py
View File

@@ -709,7 +709,9 @@ class ThermostatOverClimate(BaseThermostat[UnderlyingClimate]):
under_temp_diff = ( under_temp_diff = (
(new_target_temp - last_sent_temperature) if new_target_temp else 0 (new_target_temp - last_sent_temperature) if new_target_temp else 0
) )
if -1 < under_temp_diff < 1:
step = self.target_temperature_step or 1
if -step < under_temp_diff < step:
under_temp_diff = 0 under_temp_diff = 0
# Issue 99 - some AC turn hvac_mode=cool and hvac_action=idle when sending a HVACMode_OFF command # Issue 99 - some AC turn hvac_mode=cool and hvac_action=idle when sending a HVACMode_OFF command

4
tests/test_overclimate.py
View File

@@ -323,7 +323,7 @@ async def test_underlying_change_follow(
assert entity.target_temperature == entity.min_temp + 1 assert entity.target_temperature == entity.min_temp + 1
assert entity.preset_mode is PRESET_NONE assert entity.preset_mode is PRESET_NONE
# 4. Change the target temp with < 1 value. The value should not be taken # 4. Change the target temp with < 0.1 (step) value. The value should not be taken
# Wait 11 sec # Wait 11 sec
event_timestamp = now + timedelta(seconds=11) event_timestamp = now + timedelta(seconds=11)
await send_climate_change_event_with_temperature( await send_climate_change_event_with_temperature(
@@ -333,7 +333,7 @@ async def test_underlying_change_follow(
HVACAction.OFF, HVACAction.OFF,
HVACAction.OFF, HVACAction.OFF,
event_timestamp, event_timestamp,
entity.min_temp + 1.5, entity.min_temp + 1.09,
True, True,
"climate.mock_climate", # the underlying climate entity id "climate.mock_climate", # the underlying climate entity id
) )