Test with reset of error when changing the target temperature. For @pbranly configuration

2023-11-18 11:50:51 +00:00
parent 856f47ce03
commit 7eac10ab3c
2 changed files with 5 additions and 4 deletions
--- a/custom_components/versatile_thermostat/pi_algorithm.py
+++ b/custom_components/versatile_thermostat/pi_algorithm.py
@@ -48,7 +48,8 @@ class PITemperatureRegulator:
        """Set the new target_temp"""
        self.target_temp = target_temp
        # Do not reset the accumulated error
-        # self.accumulated_error = 0
+        # Discussion #191. After a target change we should reset the accumulated error which is certainly wrong now.
+        self.accumulated_error = 0

    def calculate_regulated_temperature(
        self, internal_temp: float, external_temp: float