Feature 158 central mode (#309)

* Normal algo working and testu ok

* Fix interaction with window

* FIX complex scenario

* pylint warning

* Release

* Issue #306

* Issue #306

---------

Co-authored-by: Jean-Marc Collin <jean-marc.collin-extern@renault.com>

tests/commons.py

@@ -185,6 +185,7 @@ class MockClimate(ClimateEntity):
         hvac_mode: HVACMode = HVACMode.OFF,
         hvac_action: HVACAction = HVACAction.OFF,
         fan_modes: list[str] = None,
+        hvac_modes: list[str] = None,
     ) -> None:
         """Initialize the thermostat."""
 
@@ -200,7 +201,11 @@ class MockClimate(ClimateEntity):
             HVACAction.OFF if hvac_mode == HVACMode.OFF else HVACAction.HEATING
         )
         self._attr_hvac_mode = hvac_mode
-        self._attr_hvac_modes = [HVACMode.OFF, HVACMode.COOL, HVACMode.HEAT]
+        self._attr_hvac_modes = (
+            hvac_modes
+            if hvac_modes is not None
+            else [HVACMode.OFF, HVACMode.COOL, HVACMode.HEAT]
+        )
         self._attr_temperature_unit = UnitOfTemperature.CELSIUS
         self._attr_target_temperature = 20
         self._attr_current_temperature = 15

tests/const.py

@@ -50,7 +50,8 @@ MOCK_TH_OVER_CLIMATE_MAIN_CONFIG = {
     CONF_TEMP_SENSOR: "sensor.mock_temp_sensor",
     CONF_CYCLE_MIN: 5,
     CONF_DEVICE_POWER: 1,
-    CONF_USE_MAIN_CENTRAL_CONFIG: False
+    CONF_USE_MAIN_CENTRAL_CONFIG: False,
+    CONF_USE_CENTRAL_MODE: True
     # Keep default values which are False
 }
 

tests/test_bugs.py

@@ -358,7 +358,7 @@ async def test_bug_82(
     skip_turn_on_off_heater,
     skip_send_event,
 ):
-    """Test that when a underlying climate is not available the VTherm doesn't go into security mode"""
+    """Test that when a underlying climate is not available the VTherm doesn't go into safety mode"""
 
     tz = get_tz(hass)  # pylint: disable=invalid-name
     now: datetime = datetime.now(tz=tz)
@@ -427,7 +427,7 @@ async def test_bug_82(
         assert mock_find_climate.mock_calls[0] == call()
         mock_find_climate.assert_has_calls([call.find_underlying_entity()])
 
-        # Force security mode
+        # Force safety mode
         assert entity._last_ext_temperature_measure is not None
         assert entity._last_temperature_measure is not None
         assert (

tests/test_config_flow.py

@@ -363,6 +363,7 @@ async def test_user_config_flow_window_auto_ok(
         CONF_USE_POWER_FEATURE: False,
         CONF_USE_PRESENCE_FEATURE: False,
         CONF_WINDOW_DELAY: 30,  # the default value is added
+        CONF_USE_CENTRAL_MODE: True,  # True is the defaulf value
     } | MOCK_TH_OVER_SWITCH_TYPE_CONFIG | MOCK_TH_OVER_SWITCH_TPI_CONFIG | MOCK_WINDOW_AUTO_CONFIG | {
         CONF_USE_MAIN_CENTRAL_CONFIG: True,
         CONF_USE_TPI_CENTRAL_CONFIG: False,
@@ -510,6 +511,7 @@ async def test_user_config_flow_over_4_switches(
         CONF_USE_POWER_FEATURE: False,
         CONF_USE_PRESENCE_FEATURE: False,
         CONF_USE_MAIN_CENTRAL_CONFIG: True,
+        CONF_USE_CENTRAL_MODE: False,
     }
 
     TYPE_CONFIG = {  # pylint: disable=wildcard-import, invalid-name

tests/test_security.py

@@ -288,7 +288,7 @@ async def test_security_feature_back_on_percent(
         assert entity.security_state is False
         assert mock_send_event.call_count == 0
 
-    # 3. Set security mode with a preset change
+    # 3. Set safety mode with a preset change
     with patch(
         "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.send_event"
     ) as mock_send_event, patch(
@@ -400,7 +400,7 @@ async def test_security_over_climate(
     skip_turn_on_off_heater,
     skip_send_event,
 ):
-    """Test that when a underlying climate is not available the VTherm doesn't go into security mode"""
+    """Test that when a underlying climate is not available the VTherm doesn't go into safety mode"""
 
     tz = get_tz(hass)  # pylint: disable=invalid-name
     now: datetime = datetime.now(tz=tz)
@@ -471,7 +471,7 @@ async def test_security_over_climate(
         assert mock_find_climate.mock_calls[0] == call()
         mock_find_climate.assert_has_calls([call.find_underlying_entity()])
 
-        # Force security mode
+        # Force safety mode
         assert entity._last_ext_temperature_measure is not None
         assert entity._last_temperature_measure is not None
         assert (
@@ -505,7 +505,7 @@ async def test_security_over_climate(
             event_timestamp = now - timedelta(minutes=6)
 
             await send_temperature_change_event(entity, 15, event_timestamp)
-            # Should stay False because a climate is never in security mode
+            # Should stay False because a climate is never in safety mode
             assert entity.security_state is False
             assert entity.preset_mode == "none"
             assert entity._saved_preset_mode == "none"

tests/test_switch_ac.py

@@ -129,7 +129,7 @@ async def test_over_switch_ac_full_start(
 
             assert entity.hvac_mode is HVACMode.OFF
             assert entity.hvac_action is HVACAction.OFF
-            assert entity.target_temperature == 16  # eco_ac_away
+            assert entity.target_temperature == 27  # eco_ac_away (no change)
 
         # Close a window
         with patch("homeassistant.helpers.condition.state", return_value=True):

tests/test_valve.py

@@ -283,6 +283,18 @@ async def test_over_valve_full_start(
         assert entity.is_device_active is True
         assert entity.hvac_action == HVACAction.HEATING
 
+    # Test window open/close (with a normal min/max so that is_device_active is False when open_percent is 0)
+    expected_state = State(
+        entity_id="number.mock_valve", state="0", attributes={"min": 0, "max": 99}
+    )
+
+    with patch(
+        "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.send_event"
+    ) as mock_send_event, patch(
+        "homeassistant.core.ServiceRegistry.async_call"
+    ) as mock_service_call, patch(
+        "homeassistant.core.StateMachine.get", return_value=expected_state
+    ):
         # Open a window
         with patch("homeassistant.helpers.condition.state", return_value=True):
             event_timestamp = now - timedelta(minutes=1)

tests/test_window.py

@@ -1,4 +1,4 @@
-# pylint: disable=unused-argument, line-too-long, protected-access
+# pylint: disable=unused-argument, line-too-long, protected-access, too-many-lines
 """ Test the Window management """
 import asyncio
 import logging