gilles/versatile_thermostat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix #185 switching from HEAT to COOL or viceversa (#226)

Browse Source
This commit is contained in:
Andrea Nicotra
2023-11-25 07:16:19 +01:00
committed by GitHub
parent d5c7b2e571
commit 475cb67cf8
2 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
custom_components/versatile_thermostat/base_thermostat.py
View File

@@ -1170,11 +1170,11 @@ class BaseThermostat(ClimateEntity, RestoreEntity):
return self._power_temp return self._power_temp
else: else:
# Select _ac presets if in COOL Mode (or over_switch with _ac_mode) # Select _ac presets if in COOL Mode (or over_switch with _ac_mode)
if self._ac_mode and ( if self._ac_mode and self._hvac_mode == HVACMode.COOL:
self._hvac_mode == HVACMode.COOL or not self.is_over_climate
):
preset_mode = preset_mode + PRESET_AC_SUFFIX preset_mode = preset_mode + PRESET_AC_SUFFIX
_LOGGER.info("%s - find preset temp: %s", self, preset_mode)
if self._presence_on is False or self._presence_state in [ if self._presence_on is False or self._presence_state in [
STATE_ON, STATE_ON,
STATE_HOME, STATE_HOME,

13
tests/test_switch_ac.py
View File

@@ -123,7 +123,7 @@ async def test_over_switch_ac_full_start(hass: HomeAssistant, skip_hass_states_i
assert entity.hvac_mode is HVACMode.OFF assert entity.hvac_mode is HVACMode.OFF
assert entity.hvac_action is HVACAction.OFF assert entity.hvac_action is HVACAction.OFF
assert entity.target_temperature == 27 # eco_ac_away assert entity.target_temperature == 16 # eco_ac_away
# Close a window # Close a window
with patch( with patch(
@@ -142,11 +142,18 @@ async def test_over_switch_ac_full_start(hass: HomeAssistant, skip_hass_states_i
await entity.async_set_hvac_mode(HVACMode.HEAT) await entity.async_set_hvac_mode(HVACMode.HEAT)
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# switch to comfort
await entity.async_set_preset_mode(PRESET_COMFORT) await entity.async_set_preset_mode(PRESET_COMFORT)
assert entity.preset_mode is PRESET_COMFORT assert entity.preset_mode is PRESET_COMFORT
assert entity.target_temperature == 26 assert entity.target_temperature == 17
# switch to Eco # switch to Eco
await entity.async_set_preset_mode(PRESET_ECO) await entity.async_set_preset_mode(PRESET_ECO)
assert entity.preset_mode is PRESET_ECO assert entity.preset_mode is PRESET_ECO
assert entity.target_temperature == 27 assert entity.target_temperature == 16
# switch to boost
await entity.async_set_preset_mode(PRESET_BOOST)
assert entity.preset_mode is PRESET_BOOST
assert entity.target_temperature == 18