gilles/versatile_thermostat
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

All windows tests ok

Browse Source
This commit is contained in:
Jean-Marc Collin
2024-12-27 12:47:19 +00:00
parent c83c772901
commit 329598b95a
9 changed files with 135 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
custom_components/versatile_thermostat/base_thermostat.py
View File

@@ -854,6 +854,11 @@ class BaseThermostat(ClimateEntity, RestoreEntity, Generic[T]):
"""Get the motion manager""" """Get the motion manager"""
return self._motion_manager return self._motion_manager
@property
def window_manager(self) -> FeatureWindowManager | None:
"""Get the window manager"""
return self._window_manager
@property @property
def window_state(self) -> str | None: def window_state(self) -> str | None:
"""Get the window_state""" """Get the window_state"""

11
custom_components/versatile_thermostat/feature_window_manager.py
View File

@@ -154,7 +154,7 @@ class FeatureWindowManager(BaseFeatureManager):
"""Tries to get the last state from sensor """Tries to get the last state from sensor
Returns True if a change has been made""" Returns True if a change has been made"""
ret = False ret = False
if self._is_configured: if self._is_configured and self._window_sensor_entity_id is not None:
window_state = self.hass.states.get(self._window_sensor_entity_id) window_state = self.hass.states.get(self._window_sensor_entity_id)
if window_state and window_state.state not in ( if window_state and window_state.state not in (
@@ -200,8 +200,7 @@ class FeatureWindowManager(BaseFeatureManager):
_LOGGER.debug( _LOGGER.debug(
"Window delay condition is not satisfied. Ignore window event" "Window delay condition is not satisfied. Ignore window event"
) )
# TODO Why ? self._window_state = old_state.state or STATE_OFF
# self._window_state = old_state.state or STATE_OFF
return return
_LOGGER.debug("%s - Window delay condition is satisfied", self) _LOGGER.debug("%s - Window delay condition is satisfied", self)
@@ -215,6 +214,8 @@ class FeatureWindowManager(BaseFeatureManager):
_LOGGER.info( _LOGGER.info(
"%s - Window ByPass is activated. Ignore window event", self "%s - Window ByPass is activated. Ignore window event", self
) )
# We change tne state but we don't apply the change
self._window_state = new_state.state
else: else:
await self.update_window_state(new_state.state) await self.update_window_state(new_state.state)
@@ -353,12 +354,12 @@ class FeatureWindowManager(BaseFeatureManager):
if in_cycle: if in_cycle:
slope = self._window_auto_algo.check_age_last_measurement( slope = self._window_auto_algo.check_age_last_measurement(
temperature=self._vtherm.ema_temp, temperature=self._vtherm.ema_temperature,
datetime_now=self._vtherm.now, datetime_now=self._vtherm.now,
) )
else: else:
slope = self._window_auto_algo.add_temp_measurement( slope = self._window_auto_algo.add_temp_measurement(
temperature=self._vtherm.ema_temp, temperature=self._vtherm.ema_temperature,
datetime_measure=self._vtherm.last_temperature_measure, datetime_measure=self._vtherm.last_temperature_measure,
) )

2
tests/commons.py
View File

@@ -800,7 +800,7 @@ async def send_window_change_event(
), ),
}, },
) )
ret = await entity._async_windows_changed(window_event) ret = await entity.window_manager._window_sensor_changed(window_event)
if sleep: if sleep:
await asyncio.sleep(0.1) await asyncio.sleep(0.1)
return ret return ret

2
tests/test_binary_sensors.py
View File

@@ -241,7 +241,7 @@ async def test_window_binary_sensors(
await entity.async_set_preset_mode(PRESET_COMFORT) await entity.async_set_preset_mode(PRESET_COMFORT)
await entity.async_set_hvac_mode(HVACMode.HEAT) await entity.async_set_hvac_mode(HVACMode.HEAT)
await send_temperature_change_event(entity, 15, now) await send_temperature_change_event(entity, 15, now)
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
await window_binary_sensor.async_my_climate_changed() await window_binary_sensor.async_my_climate_changed()
assert window_binary_sensor.state is STATE_OFF assert window_binary_sensor.state is STATE_OFF

8
tests/test_central_config.py
View File

@@ -167,7 +167,7 @@ async def test_minimal_over_switch_wo_central_config(
assert entity.max_temp == 18 assert entity.max_temp == 18
assert entity.target_temperature_step == 0.3 assert entity.target_temperature_step == 0.3
assert entity.preset_modes == ["none", "frost", "eco", "comfort", "boost"] assert entity.preset_modes == ["none", "frost", "eco", "comfort", "boost"]
assert entity.is_window_auto_configured is False assert entity.window_manager.is_window_auto_configured is False
assert entity.nb_underlying_entities == 1 assert entity.nb_underlying_entities == 1
assert entity.underlying_entity_id(0) == "switch.mock_switch" assert entity.underlying_entity_id(0) == "switch.mock_switch"
assert entity.proportional_algorithm is not None assert entity.proportional_algorithm is not None
@@ -279,7 +279,9 @@ async def test_full_over_switch_wo_central_config(
assert entity._security_default_on_percent == 0.1 assert entity._security_default_on_percent == 0.1
assert entity.is_inversed is False assert entity.is_inversed is False
assert entity.is_window_auto_configured is False # we have an entity_id assert (
entity.window_manager.is_window_auto_configured is False
) # we have an entity_id
assert entity._window_sensor_entity_id == "binary_sensor.mock_window_sensor" assert entity._window_sensor_entity_id == "binary_sensor.mock_window_sensor"
assert entity._window_delay_sec == 30 assert entity._window_delay_sec == 30
assert entity._window_auto_close_threshold == 0.1 assert entity._window_auto_close_threshold == 0.1
@@ -402,7 +404,7 @@ async def test_full_over_switch_with_central_config(
assert entity.is_inversed is False assert entity.is_inversed is False
# We have an entity so window auto is not enabled # We have an entity so window auto is not enabled
assert entity.is_window_auto_configured is False assert entity.window_manager.is_window_auto_configured is False
assert entity._window_sensor_entity_id == "binary_sensor.mock_window_sensor" assert entity._window_sensor_entity_id == "binary_sensor.mock_window_sensor"
assert entity._window_delay_sec == 15 assert entity._window_delay_sec == 15
assert entity._window_auto_close_threshold == 1 assert entity._window_auto_close_threshold == 1

4
tests/test_central_mode.py
View File

@@ -816,7 +816,7 @@ async def test_switch_change_central_mode_true_with_window(
assert entity.hvac_mode == HVACMode.HEAT assert entity.hvac_mode == HVACMode.HEAT
assert entity.preset_mode == PRESET_ACTIVITY assert entity.preset_mode == PRESET_ACTIVITY
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# 2 Open the window # 2 Open the window
with patch( with patch(
@@ -973,7 +973,7 @@ async def test_switch_change_central_mode_true_with_cool_only_and_window(
assert entity.hvac_mode == HVACMode.HEAT assert entity.hvac_mode == HVACMode.HEAT
assert entity.preset_mode == PRESET_ACTIVITY assert entity.preset_mode == PRESET_ACTIVITY
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# 2 Change central_mode to COOL_ONLY # 2 Change central_mode to COOL_ONLY
with patch("homeassistant.core.ServiceRegistry.async_call"): with patch("homeassistant.core.ServiceRegistry.async_call"):

2
tests/test_multiple_switch.py
View File

@@ -69,7 +69,7 @@ async def test_one_switch_cycle(
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
assert entity.preset_mode is PRESET_BOOST assert entity.preset_mode is PRESET_BOOST
assert entity.target_temperature == 19 assert entity.target_temperature == 19
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
event_timestamp = now - timedelta(minutes=4) event_timestamp = now - timedelta(minutes=4)
await send_temperature_change_event(entity, 15, event_timestamp) await send_temperature_change_event(entity, 15, event_timestamp)

181
tests/test_window.py
View File

@@ -68,7 +68,7 @@ async def test_window_management_time_not_enough(
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 19 assert entity.target_temperature == 19
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# Open the window, but condition of time is not satisfied and check the thermostat don't turns off # Open the window, but condition of time is not satisfied and check the thermostat don't turns off
with patch( with patch(
@@ -157,7 +157,7 @@ async def test_window_management_time_enough(
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 19 assert entity.target_temperature == 19
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# change temperature to force turning on the heater # change temperature to force turning on the heater
with patch( with patch(
@@ -307,8 +307,8 @@ async def test_window_auto_fast(hass: HomeAssistant, skip_hass_states_is_state):
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 21 assert entity.target_temperature == 21
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured is True assert entity.window_manager.is_window_auto_configured is True
# Initialize the slope algo with 2 measurements # Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -337,8 +337,12 @@ async def test_window_auto_fast(hass: HomeAssistant, skip_hass_states_is_state):
assert mock_send_event.call_count == 0 assert mock_send_event.call_count == 0
assert entity.is_device_active is True assert entity.is_device_active is True
assert entity.last_temperature_slope == 0.0 assert entity.last_temperature_slope == 0.0
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is False entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# send one degre down in one minute # send one degre down in one minute
@@ -361,8 +365,10 @@ async def test_window_auto_fast(hass: HomeAssistant, skip_hass_states_is_state):
assert mock_heater_on.call_count == 0 assert mock_heater_on.call_count == 0
assert mock_heater_off.call_count >= 1 assert mock_heater_off.call_count >= 1
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
assert entity._window_auto_algo.is_window_open_detected() is True assert entity.window_manager._window_auto_algo.is_window_open_detected() is True
assert entity._window_auto_algo.is_window_close_detected() is False assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.window_auto_state == STATE_ON assert entity.window_auto_state == STATE_ON
assert entity.hvac_mode is HVACMode.OFF assert entity.hvac_mode is HVACMode.OFF
@@ -397,8 +403,10 @@ async def test_window_auto_fast(hass: HomeAssistant, skip_hass_states_is_state):
assert mock_heater_on.call_count == 0 assert mock_heater_on.call_count == 0
assert mock_heater_off.call_count == 0 assert mock_heater_off.call_count == 0
assert round(entity.last_temperature_slope, 3) == -7.49 assert round(entity.last_temperature_slope, 3) == -7.49
assert entity._window_auto_algo.is_window_open_detected() is True assert entity.window_manager._window_auto_algo.is_window_open_detected() is True
assert entity._window_auto_algo.is_window_close_detected() is False assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.window_auto_state == STATE_ON assert entity.window_auto_state == STATE_ON
assert entity.hvac_mode is HVACMode.OFF assert entity.hvac_mode is HVACMode.OFF
@@ -438,8 +446,12 @@ async def test_window_auto_fast(hass: HomeAssistant, skip_hass_states_is_state):
assert mock_heater_on.call_count == 1 assert mock_heater_on.call_count == 1
assert mock_heater_off.call_count == 0 assert mock_heater_off.call_count == 0
assert entity.last_temperature_slope == 0.42 assert entity.last_temperature_slope == 0.42
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is True entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is True
)
assert entity.window_auto_state == STATE_OFF assert entity.window_auto_state == STATE_OFF
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
@@ -481,6 +493,7 @@ async def test_window_auto_fast_and_sensor(
CONF_SECURITY_DELAY_MIN: 5, CONF_SECURITY_DELAY_MIN: 5,
CONF_SECURITY_MIN_ON_PERCENT: 0.3, CONF_SECURITY_MIN_ON_PERCENT: 0.3,
CONF_WINDOW_SENSOR: "binary_sensor.fake_window_sensor", CONF_WINDOW_SENSOR: "binary_sensor.fake_window_sensor",
CONF_WINDOW_DELAY: 10,
CONF_WINDOW_AUTO_OPEN_THRESHOLD: 0.1, CONF_WINDOW_AUTO_OPEN_THRESHOLD: 0.1,
CONF_WINDOW_AUTO_CLOSE_THRESHOLD: 0.1, CONF_WINDOW_AUTO_CLOSE_THRESHOLD: 0.1,
CONF_WINDOW_AUTO_MAX_DURATION: 10, # Should be 0 for test CONF_WINDOW_AUTO_MAX_DURATION: 10, # Should be 0 for test
@@ -504,8 +517,10 @@ async def test_window_auto_fast_and_sensor(
assert entity.preset_mode is PRESET_BOOST assert entity.preset_mode is PRESET_BOOST
assert entity.target_temperature == 21 assert entity.target_temperature == 21
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured is False assert entity.window_auto_state is STATE_UNAVAILABLE
assert entity.window_manager.is_window_auto_configured is False
assert entity.window_manager.is_configured is True
# Initialize the slope algo with 2 measurements # Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -534,8 +549,12 @@ async def test_window_auto_fast_and_sensor(
assert mock_send_event.call_count == 0 assert mock_send_event.call_count == 0
assert entity.is_device_active is True assert entity.is_device_active is True
assert entity.last_temperature_slope == 0.0 assert entity.last_temperature_slope == 0.0
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is False entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# send one degre down in one minute # send one degre down in one minute
@@ -559,9 +578,11 @@ async def test_window_auto_fast_and_sensor(
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
# The window open should be detected (but not used) # The window open should be detected (but not used)
# because we need to calculate the slope anyway, we have the algorithm running # because we need to calculate the slope anyway, we have the algorithm running
assert entity._window_auto_algo.is_window_open_detected() is True assert entity.window_manager._window_auto_algo.is_window_open_detected() is True
assert entity._window_auto_algo.is_window_close_detected() is False assert (
assert entity.window_auto_state == STATE_OFF entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.window_auto_state == STATE_UNAVAILABLE
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# Clean the entity # Clean the entity
@@ -620,8 +641,8 @@ async def test_window_auto_auto_stop(hass: HomeAssistant, skip_hass_states_is_st
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 21 assert entity.target_temperature == 21
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured is True assert entity.window_manager.is_window_auto_configured is True
# 1. Initialize the slope algo with 2 measurements # 1. Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -647,8 +668,12 @@ async def test_window_auto_auto_stop(hass: HomeAssistant, skip_hass_states_is_st
# The climate turns on but was alredy on # The climate turns on but was alredy on
assert mock_set_hvac_mode.call_count == 0 assert mock_set_hvac_mode.call_count == 0
assert entity.last_temperature_slope == 0.0 assert entity.last_temperature_slope == 0.0
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is False entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# 3. send one degre down in one minute # 3. send one degre down in one minute
@@ -665,8 +690,10 @@ async def test_window_auto_auto_stop(hass: HomeAssistant, skip_hass_states_is_st
await send_temperature_change_event(entity, 18, event_timestamp, sleep=False) await send_temperature_change_event(entity, 18, event_timestamp, sleep=False)
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
assert entity._window_auto_algo.is_window_open_detected() is True assert entity.window_manager._window_auto_algo.is_window_open_detected() is True
assert entity._window_auto_algo.is_window_close_detected() is False assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert mock_send_event.call_count == 2 assert mock_send_event.call_count == 2
# The heater turns off # The heater turns off
@@ -714,8 +741,12 @@ async def test_window_auto_auto_stop(hass: HomeAssistant, skip_hass_states_is_st
assert mock_set_hvac_mode.call_count == 1 assert mock_set_hvac_mode.call_count == 1
assert round(entity.last_temperature_slope, 3) == -0.29 assert round(entity.last_temperature_slope, 3) == -0.29
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is False entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
# Clean the entity # Clean the entity
entity.remove_thermostat() entity.remove_thermostat()
@@ -756,7 +787,7 @@ async def test_window_auto_no_on_percent(
CONF_SECURITY_MIN_ON_PERCENT: 0.3, CONF_SECURITY_MIN_ON_PERCENT: 0.3,
CONF_WINDOW_AUTO_OPEN_THRESHOLD: 6, CONF_WINDOW_AUTO_OPEN_THRESHOLD: 6,
CONF_WINDOW_AUTO_CLOSE_THRESHOLD: 6, CONF_WINDOW_AUTO_CLOSE_THRESHOLD: 6,
CONF_WINDOW_AUTO_MAX_DURATION: 0, # Should be 0 for test CONF_WINDOW_AUTO_MAX_DURATION: 1, # Should be 0 for test but 0 is not possible
}, },
) )
@@ -778,7 +809,8 @@ async def test_window_auto_no_on_percent(
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 20 assert entity.target_temperature == 20
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.window_auto_state is STATE_UNKNOWN
# Initialize the slope algo with 2 measurements # Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -806,8 +838,12 @@ async def test_window_auto_no_on_percent(
# The heater don't turns on # The heater don't turns on
assert mock_heater_on.call_count == 0 assert mock_heater_on.call_count == 0
assert entity.last_temperature_slope == 0.0 assert entity.last_temperature_slope == 0.0
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is False entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
assert entity.proportional_algorithm.on_percent == 0.0 assert entity.proportional_algorithm.on_percent == 0.0
@@ -833,10 +869,12 @@ async def test_window_auto_no_on_percent(
assert mock_heater_off.call_count == 1 assert mock_heater_off.call_count == 1
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
# The algo calculate open ... # The algo calculate open ...
assert entity._window_auto_algo.is_window_open_detected() is True assert entity.window_manager._window_auto_algo.is_window_open_detected() is True
assert entity._window_auto_algo.is_window_close_detected() is False assert (
# But the entity is still on entity.window_manager._window_auto_algo.is_window_close_detected() is False
assert entity.window_auto_state == STATE_OFF )
# But the entity is still on and window_auto is not detected
assert entity.window_auto_state == STATE_UNKNOWN
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# Clean the entity # Clean the entity
@@ -894,8 +932,8 @@ async def test_window_bypass(hass: HomeAssistant, skip_hass_states_is_state):
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 19 assert entity.target_temperature == 19
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured is False assert entity.window_manager.is_window_auto_configured is False
# change temperature to force turning on the heater # change temperature to force turning on the heater
with patch( with patch(
@@ -920,8 +958,6 @@ async def test_window_bypass(hass: HomeAssistant, skip_hass_states_is_state):
await entity.service_set_window_bypass_state(True) await entity.service_set_window_bypass_state(True)
assert entity.is_window_bypass is True assert entity.is_window_bypass is True
# entity._is_window_bypass = True
# Open the window, condition of time is satisfied, check the thermostat and heater turns off # Open the window, condition of time is satisfied, check the thermostat and heater turns off
with patch( with patch(
"custom_components.versatile_thermostat.base_thermostat.BaseThermostat.send_event" "custom_components.versatile_thermostat.base_thermostat.BaseThermostat.send_event"
@@ -936,7 +972,10 @@ async def test_window_bypass(hass: HomeAssistant, skip_hass_states_is_state):
new_callable=PropertyMock, new_callable=PropertyMock,
return_value=True, return_value=True,
): ):
await send_window_change_event(entity, True, False, datetime.now()) try_function = await send_window_change_event(
entity, True, False, datetime.now()
)
await try_function(None)
assert mock_send_event.call_count == 0 assert mock_send_event.call_count == 0
@@ -944,7 +983,7 @@ async def test_window_bypass(hass: HomeAssistant, skip_hass_states_is_state):
assert mock_heater_on.call_count == 0 assert mock_heater_on.call_count == 0
# One call in set_hvac_mode turn_off and one call in the control_heating for security # One call in set_hvac_mode turn_off and one call in the control_heating for security
assert mock_heater_off.call_count == 0 assert mock_heater_off.call_count == 0
assert mock_condition.call_count == 1 assert mock_condition.call_count > 0
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
assert entity.window_state == STATE_ON assert entity.window_state == STATE_ON
@@ -1037,8 +1076,8 @@ async def test_window_auto_bypass(hass: HomeAssistant, skip_hass_states_is_state
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 21 assert entity.target_temperature == 21
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured assert entity.window_manager.is_window_auto_configured
# Initialize the slope algo with 2 measurements # Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -1066,8 +1105,12 @@ async def test_window_auto_bypass(hass: HomeAssistant, skip_hass_states_is_state
# The heater turns on # The heater turns on
assert entity.is_device_active is True assert entity.is_device_active is True
assert entity.last_temperature_slope == 0.0 assert entity.last_temperature_slope == 0.0
assert entity._window_auto_algo.is_window_open_detected() is False assert (
assert entity._window_auto_algo.is_window_close_detected() is False entity.window_manager._window_auto_algo.is_window_open_detected() is False
)
assert (
entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# send one degre down in one minute with window bypass on # send one degre down in one minute with window bypass on
@@ -1094,9 +1137,11 @@ async def test_window_auto_bypass(hass: HomeAssistant, skip_hass_states_is_state
assert mock_heater_on.call_count == 0 assert mock_heater_on.call_count == 0
assert mock_heater_off.call_count == 0 assert mock_heater_off.call_count == 0
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
assert entity._window_auto_algo.is_window_open_detected() is True assert entity.window_manager._window_auto_algo.is_window_open_detected() is True
assert entity._window_auto_algo.is_window_close_detected() is False assert (
assert entity.window_auto_state == STATE_OFF entity.window_manager._window_auto_algo.is_window_close_detected() is False
)
assert entity.window_auto_state == STATE_UNKNOWN
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# Clean the entity # Clean the entity
@@ -1155,7 +1200,7 @@ async def test_window_bypass_reactivate(hass: HomeAssistant, skip_hass_states_is
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 19 assert entity.target_temperature == 19
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# change temperature to force turning on the heater # change temperature to force turning on the heater
with patch( with patch(
@@ -1299,7 +1344,7 @@ async def test_window_action_fan_only(hass: HomeAssistant, skip_hass_states_is_s
assert entity assert entity
assert entity.is_over_climate is True assert entity.is_over_climate is True
assert entity.window_action == CONF_WINDOW_FAN_ONLY assert entity.window_manager.window_action == CONF_WINDOW_FAN_ONLY
await entity.async_set_hvac_mode(HVACMode.HEAT) await entity.async_set_hvac_mode(HVACMode.HEAT)
assert entity.hvac_mode == HVACMode.HEAT assert entity.hvac_mode == HVACMode.HEAT
@@ -1307,7 +1352,7 @@ async def test_window_action_fan_only(hass: HomeAssistant, skip_hass_states_is_s
assert entity.preset_mode == PRESET_COMFORT assert entity.preset_mode == PRESET_COMFORT
assert entity.target_temperature == 18 assert entity.target_temperature == 18
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# 2. Open the window, condition of time is satisfied, check the thermostat and heater turns off # 2. Open the window, condition of time is satisfied, check the thermostat and heater turns off
with patch( with patch(
@@ -1456,7 +1501,7 @@ async def test_window_action_fan_only_ko(
assert entity assert entity
assert entity.is_over_climate is True assert entity.is_over_climate is True
assert entity.window_action == CONF_WINDOW_FAN_ONLY assert entity.window_manager.window_action == CONF_WINDOW_FAN_ONLY
await entity.async_set_hvac_mode(HVACMode.HEAT) await entity.async_set_hvac_mode(HVACMode.HEAT)
assert entity.hvac_mode == HVACMode.HEAT assert entity.hvac_mode == HVACMode.HEAT
@@ -1464,7 +1509,7 @@ async def test_window_action_fan_only_ko(
assert entity.preset_mode == PRESET_COMFORT assert entity.preset_mode == PRESET_COMFORT
assert entity.target_temperature == 18 assert entity.target_temperature == 18
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# 2. Open the window, condition of time is satisfied, check the thermostat and heater turns off # 2. Open the window, condition of time is satisfied, check the thermostat and heater turns off
with patch( with patch(
@@ -1594,8 +1639,8 @@ async def test_window_action_eco_temp(hass: HomeAssistant, skip_hass_states_is_s
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 21 assert entity.target_temperature == 21
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured is True assert entity.window_manager.is_window_auto_configured is True
# 1. Initialize the slope algo with 2 measurements # 1. Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -1624,8 +1669,8 @@ async def test_window_action_eco_temp(hass: HomeAssistant, skip_hass_states_is_s
assert mock_send_event.call_count == 0 assert mock_send_event.call_count == 0
assert entity.is_device_active is True assert entity.is_device_active is True
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.window_auto_state is STATE_OFF assert entity.window_auto_state is STATE_UNKNOWN
# 3. send one degre down in one minute # 3. send one degre down in one minute
with patch( with patch(
@@ -1648,7 +1693,7 @@ async def test_window_action_eco_temp(hass: HomeAssistant, skip_hass_states_is_s
assert mock_heater_off.call_count == 0 assert mock_heater_off.call_count == 0
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
assert entity.window_auto_state == STATE_ON assert entity.window_auto_state == STATE_ON
assert entity.window_state == STATE_OFF assert entity.window_state == STATE_ON
# No change on HVACMode # No change on HVACMode
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# No change on preset # No change on preset
@@ -1791,8 +1836,8 @@ async def test_window_action_frost_temp(hass: HomeAssistant, skip_hass_states_is
assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE assert entity.power_manager.overpowering_state is STATE_UNAVAILABLE
assert entity.target_temperature == 21 assert entity.target_temperature == 21
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.is_window_auto_configured is True assert entity.window_manager.is_window_auto_configured is True
# 1. Initialize the slope algo with 2 measurements # 1. Initialize the slope algo with 2 measurements
event_timestamp = now + timedelta(minutes=1) event_timestamp = now + timedelta(minutes=1)
@@ -1821,8 +1866,8 @@ async def test_window_action_frost_temp(hass: HomeAssistant, skip_hass_states_is
assert mock_send_event.call_count == 0 assert mock_send_event.call_count == 0
assert entity.is_device_active is True assert entity.is_device_active is True
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
assert entity.window_auto_state is STATE_OFF assert entity.window_auto_state is STATE_UNKNOWN
# 3. send one degre down in one minute # 3. send one degre down in one minute
with patch( with patch(
@@ -1845,7 +1890,7 @@ async def test_window_action_frost_temp(hass: HomeAssistant, skip_hass_states_is
assert mock_heater_off.call_count == 0 assert mock_heater_off.call_count == 0
assert entity.last_temperature_slope == -6.24 assert entity.last_temperature_slope == -6.24
assert entity.window_auto_state == STATE_ON assert entity.window_auto_state == STATE_ON
assert entity.window_state == STATE_OFF assert entity.window_state == STATE_ON
# No change on HVACMode # No change on HVACMode
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
# No change on preset # No change on preset
@@ -1991,7 +2036,7 @@ async def test_bug_66(
assert entity.hvac_mode is HVACMode.HEAT assert entity.hvac_mode is HVACMode.HEAT
assert entity.preset_mode is PRESET_BOOST assert entity.preset_mode is PRESET_BOOST
assert entity.target_temperature == 19 assert entity.target_temperature == 19
assert entity.window_state is STATE_OFF assert entity.window_state is STATE_UNKNOWN
# Open the window and let the thermostat shut down # Open the window and let the thermostat shut down
with patch( with patch(
@@ -2150,8 +2195,8 @@ async def test_window_action_frost_temp_preset_change(
assert vtherm.preset_mode is PRESET_BOOST assert vtherm.preset_mode is PRESET_BOOST
assert vtherm.target_temperature == 21 assert vtherm.target_temperature == 21
assert vtherm.window_state is STATE_OFF assert vtherm.window_state is STATE_UNKNOWN
assert vtherm.is_window_auto_configured is False assert vtherm.window_manager.is_window_auto_configured is False
# 1. Turn on the window sensor # 1. Turn on the window sensor
now = now + timedelta(minutes=1) now = now + timedelta(minutes=1)
@@ -2260,8 +2305,8 @@ async def test_window_action_frost_temp_temp_change(
assert vtherm.preset_mode is PRESET_BOOST assert vtherm.preset_mode is PRESET_BOOST
assert vtherm.target_temperature == 21 assert vtherm.target_temperature == 21
assert vtherm.window_state is STATE_OFF assert vtherm.window_state is STATE_UNKNOWN
assert vtherm.is_window_auto_configured is False assert vtherm.window_manager.is_window_auto_configured is False
# 1. Turn on the window sensor # 1. Turn on the window sensor
now = now + timedelta(minutes=1) now = now + timedelta(minutes=1)

2
tests/test_window_feature_manager.py
View File

@@ -678,7 +678,7 @@ async def test_window_feature_manager_window_auto(
#fmt: on #fmt: on
now = now + timedelta(minutes=10) now = now + timedelta(minutes=10)
# From 17 to new_temp in 10 minutes # From 17 to new_temp in 10 minutes
type(fake_vtherm).ema_temp = PropertyMock(return_value=new_temp) type(fake_vtherm).ema_temperature = PropertyMock(return_value=new_temp)
type(fake_vtherm).last_temperature_measure = PropertyMock(return_value=now) type(fake_vtherm).last_temperature_measure = PropertyMock(return_value=now)
type(fake_vtherm).now = PropertyMock(return_value=now) type(fake_vtherm).now = PropertyMock(return_value=now)
fake_vtherm.send_event = MagicMock() fake_vtherm.send_event = MagicMock()