rename metadata class names.

adding metadata for NVME and SCSI drives.
send back protocol specific metadata for displaying data in the UI for attributes.
UI - moved all metadata lookups into named functions (for better if/else logic)
show different columns if nvme or scsi.

webapp/backend/pkg/models/db/device.go

@@ -149,7 +149,7 @@ func (dv *Device) ApplyMetadataRules() error {
 				dv.SmartResults[0].AtaAttributes[ndx].StatusReason = "Attribute has previously failed manufacturer SMART threshold"
 			}
 
-			if smartMetadata, ok := metadata.AtaSmartAttributes[attr.AttributeId]; ok {
+			if smartMetadata, ok := metadata.AtaMetadata[attr.AttributeId]; ok {
 				dv.SmartResults[0].AtaAttributes[ndx].MetadataObservedThresholdStatus(smartMetadata)
 			}
 

webapp/backend/pkg/models/db/smart.go

@@ -70,7 +70,7 @@ func (sm *Smart) ProcessAtaSmartInfo(info collector.SmartInfo) {
 		}
 
 		//now that we've parsed the data from the smartctl response, lets match it against our metadata rules and add additional Scrutiny specific data.
-		if smartMetadata, ok := metadata.AtaSmartAttributes[collectorAttr.ID]; ok {
+		if smartMetadata, ok := metadata.AtaMetadata[collectorAttr.ID]; ok {
 			attrModel.Name = smartMetadata.DisplayName
 			if smartMetadata.Transform != nil {
 				attrModel.TransformedValue = smartMetadata.Transform(attrModel.Value, attrModel.RawValue, attrModel.RawString)

webapp/backend/pkg/models/db/smart_ata_attribute.go

@@ -32,7 +32,7 @@ type SmartAtaAttribute struct {
 }
 
 // compare the attribute (raw, normalized, transformed) value to observed thresholds, and update status if necessary
-func (sa *SmartAtaAttribute) MetadataObservedThresholdStatus(smartMetadata metadata.AtaSmartAttribute) {
+func (sa *SmartAtaAttribute) MetadataObservedThresholdStatus(smartMetadata metadata.AtaAttributeMetadata) {
 	//TODO: multiple rules
 	// try to predict the failure rates for observed thresholds that have 0 failure rate and error bars.
 	// - if the attribute is critical