adding error handling for all DB calls. Returning StatusInternalServerError whenever an error occurs. Adding additional logging to server handlers.

Make sure we "return" after a c.JSON call.

webapp/backend/pkg/web/handler/upload_device_metrics.go

@@ -5,36 +5,45 @@ import (
 	dbModels "github.com/analogj/scrutiny/webapp/backend/pkg/models/db"
 	"github.com/gin-gonic/gin"
 	"github.com/jinzhu/gorm"
-	log "github.com/sirupsen/logrus"
+	"github.com/sirupsen/logrus"
 	"net/http"
 )
 
 func UploadDeviceMetrics(c *gin.Context) {
 	db := c.MustGet("DB").(*gorm.DB)
+	logger := c.MustGet("LOGGER").(logrus.FieldLogger)
 
 	var collectorSmartData collector.SmartInfo
 	err := c.BindJSON(&collectorSmartData)
 	if err != nil {
-		//TODO: cannot parse smart data
-		log.Error("Cannot parse SMART data")
-		c.JSON(http.StatusOK, gin.H{"success": false})
-
+		logger.Errorln("Cannot parse SMART data", err)
+		c.JSON(http.StatusInternalServerError, gin.H{"success": false})
+		return
 	}
 
 	//update the device information if necessary
 	var device dbModels.Device
 	db.Where("wwn = ?", c.Param("wwn")).First(&device)
 	device.UpdateFromCollectorSmartInfo(collectorSmartData)
-	db.Model(&device).Updates(device)
+	if err := db.Model(&device).Updates(device).Error; err != nil {
+		logger.Errorln("An error occurred while updating device data from smartctl metrics", err)
+		c.JSON(http.StatusInternalServerError, gin.H{"success": false})
+		return
+	}
 
 	// insert smart info
 	deviceSmartData := dbModels.Smart{}
 	err = deviceSmartData.FromCollectorSmartInfo(c.Param("wwn"), collectorSmartData)
 	if err != nil {
-		c.JSON(http.StatusOK, gin.H{"success": false})
+		logger.Errorln("Could not process SMART metrics", err)
+		c.JSON(http.StatusInternalServerError, gin.H{"success": false})
+		return
+	}
+	if err := db.Create(&deviceSmartData).Error; err != nil {
+		logger.Errorln("An error occurred while saving smartctl metrics", err)
+		c.JSON(http.StatusInternalServerError, gin.H{"success": false})
 		return
 	}
-	db.Create(&deviceSmartData)
 
 	c.JSON(http.StatusOK, gin.H{"success": true})
 }