adding error handling for all DB calls. Returning StatusInternalServerError whenever an error occurs. Adding additional logging to server handlers.

Make sure we "return" after a c.JSON call.

webapp/backend/pkg/web/handler/get_devices_summary.go

@@ -4,20 +4,25 @@ import (
 	dbModels "github.com/analogj/scrutiny/webapp/backend/pkg/models/db"
 	"github.com/gin-gonic/gin"
 	"github.com/jinzhu/gorm"
+	"github.com/sirupsen/logrus"
 	"net/http"
 )
 
 func GetDevicesSummary(c *gin.Context) {
 	db := c.MustGet("DB").(*gorm.DB)
+	logger := c.MustGet("LOGGER").(logrus.FieldLogger)
 	devices := []dbModels.Device{}
 
 	//We need the last x (for now all) Smart objects for each Device, so that we can graph Temperature
 	//We also need the last
-	db.Debug().
-		Preload("SmartResults", func(db *gorm.DB) *gorm.DB {
-			return db.Order("smarts.created_at DESC") //OLD: .Limit(devicesCount)
-		}).
-		Find(&devices)
+	if err := db.Preload("SmartResults", func(db *gorm.DB) *gorm.DB {
+		return db.Order("smarts.created_at DESC") //OLD: .Limit(devicesCount)
+	}).
+		Find(&devices).Error; err != nil {
+		logger.Errorln("Could not get device summary from DB", err)
+		c.JSON(http.StatusInternalServerError, gin.H{"success": false})
+		return
+	}
 
 	c.JSON(http.StatusOK, gin.H{
 		"success": true,