adding tests for Detect struct in collector. Adding ability to mock out exec.Command calls.

collector/pkg/common/shell/local_shell_test.go

@@ -0,0 +1,66 @@
+package shell
+
+import (
+	"github.com/sirupsen/logrus"
+	"github.com/stretchr/testify/require"
+	"os/exec"
+	"testing"
+)
+
+func TestLocalShellCommand(t *testing.T) {
+	t.Parallel()
+
+	//setup
+	testShell := localShell{}
+	//test
+	result, err := testShell.Command(logrus.WithField("exec", "test"), "echo", []string{"hello world"}, "", nil)
+
+	//assert
+	require.NoError(t, err)
+	require.Equal(t, "hello world\n", result)
+}
+
+func TestLocalShellCommand_Date(t *testing.T) {
+	t.Parallel()
+
+	//setup
+	testShell := localShell{}
+
+	//test
+	_, err := testShell.Command(logrus.WithField("exec", "test"), "date", []string{}, "", nil)
+
+	//assert
+	require.NoError(t, err)
+}
+
+//
+//func TestExecCmd_Error(t *testing.T) {
+//	t.Parallel()
+//
+//	//setup
+//	bc := collector.BaseCollector {}
+//
+//	//test
+//	_, err := bc.ExecCmd("smartctl", []string{"-a", "/dev/doesnotexist"}, "", nil)
+//
+//	//assert
+//	exitError, castOk := err.(*exec.ExitError);
+//	require.True(t, castOk)
+//	require.Equal(t, 1, exitError.ExitCode())
+//
+//}
+//
+
+func TestLocalShellCommand_InvalidCommand(t *testing.T) {
+	t.Parallel()
+
+	//setup
+	testShell := localShell{}
+
+	//test
+	_, err := testShell.Command(logrus.WithField("exec", "test"), "invalid_binary", []string{}, "", nil)
+
+	//assert
+	_, castOk := err.(*exec.ExitError)
+	require.False(t, castOk)
+}