From 68fa42249e12c85f4166dfb1d847010637ff6806 Mon Sep 17 00:00:00 2001
From: Alex X <alexey.khit@gmail.com>
Date: Fri, 26 Jul 2024 14:01:43 +0300
Subject: [PATCH] Fix PCM audio from Hikvision cameras

---
 pkg/core/codec.go     |  7 ++++++-
 pkg/rtsp/rtsp_test.go | 32 ++++++++++++++++++++++++++++++++
 2 files changed, 38 insertions(+), 1 deletion(-)

diff --git a/pkg/core/codec.go b/pkg/core/codec.go
index 9c6c6b79..b138df28 100644
--- a/pkg/core/codec.go
+++ b/pkg/core/codec.go
@@ -157,7 +157,12 @@ func UnmarshalCodec(md *sdp.MediaDescription, payloadType string) *Codec {
 		}
 	}
 
-	if c.Name == "" {
+	switch c.Name {
+	case "PCM":
+		// https://www.reddit.com/r/Hikvision/comments/17elxex/comment/k642g2r/
+		// check pkg/rtsp/rtsp_test.go TestHikvisionPCM
+		c.Name = CodecPCML
+	case "":
 		// https://en.wikipedia.org/wiki/RTP_payload_formats
 		switch payloadType {
 		case "0":
diff --git a/pkg/rtsp/rtsp_test.go b/pkg/rtsp/rtsp_test.go
index 7eb317a7..a13341b4 100644
--- a/pkg/rtsp/rtsp_test.go
+++ b/pkg/rtsp/rtsp_test.go
@@ -3,6 +3,7 @@ package rtsp
 import (
 	"testing"
 
+	"github.com/AlexxIT/go2rtc/pkg/core"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -159,3 +160,34 @@ a=control:trackID=2
 	assert.Equal(t, "recvonly", medias[0].Direction)
 	assert.Equal(t, "recvonly", medias[1].Direction)
 }
+
+func TestHikvisionPCM(t *testing.T) {
+	s := `v=0
+o=- 1721969533379665 1721969533379665 IN IP4 192.168.1.12
+s=Media Presentation
+e=NONE
+b=AS:5100
+t=0 0
+a=control:rtsp://192.168.1.12:554/Streaming/channels/101/
+m=video 0 RTP/AVP 96
+c=IN IP4 0.0.0.0
+b=AS:5000
+a=recvonly
+a=x-dimensions:3200,1800
+a=control:rtsp://192.168.1.12:554/Streaming/channels/101/trackID=1
+a=rtpmap:96 H264/90000
+a=fmtp:96 profile-level-id=420029; packetization-mode=1; sprop-parameter-sets=Z2QAM6wVFKAyAOP5f/AAEAAWyAAAH0AAB1MAIA==,aO48sA==
+m=audio 0 RTP/AVP 11
+c=IN IP4 0.0.0.0
+b=AS:50
+a=recvonly
+a=control:rtsp://192.168.1.12:554/Streaming/channels/101/trackID=2
+a=rtpmap:11 PCM/48000
+a=Media_header:MEDIAINFO=494D4B4801030000040000010170011080BB0000007D000000000000000000000000000000000000;
+a=appversion:1.0
+`
+	medias, err := UnmarshalSDP([]byte(s))
+	assert.Nil(t, err)
+	assert.Len(t, medias, 2)
+	assert.Equal(t, core.CodecPCML, medias[1].Codecs[0].Name)
+}