David Luzar
e9cae918a7
* feat: Sidebar tabs support [wip] * tab trigger styling tweaks * add `:hover` & `:active` states * replace `@dwelle/tunnel-rat` with `tunnel-rat` * make stuff more explicit - remove `Sidebar.Header` fallback (host apps need to render manually), and stop tunneling it (render in place) - make `docked` state explicit - stop tunneling `Sidebar.TabTriggers` (render in place) * redesign sidebar / library as per latest spec * support no label on `Sidebar.Trigger` * add Sidebar `props.onStateChange` * style fixes * make `appState.isSidebarDocked` into a soft user preference * px -> rem & refactor * remove `props.renderSidebar` * update tests * remove * refactor * rename constants * tab triggers styling fixes * factor out library-related logic from generic sidebar trigger * change `props.onClose` to `onToggle` * rename `props.value` -> `props.tab` * add displayNames * allow HTMLAttributes on applicable compos * fix example App * more styling tweaks and fixes * fix not setting `dockable` * more style fixes * fix and align sidebar header button styling * make DefaultSidebar dockable on if host apps supplies `onDock` * stop `Sidebar.Trigger` hiding label on mobile this should be only the default sidebar trigger behavior, and for that we don't need to use `device` hook as we handle in CSS * fix `dockable` prop of defaultSidebar * remove extra `typescript` dep * remove `defaultTab` prop in favor of explicit `tab` value in `<Sidebar.Trigger/>` and `toggleSidebar()`, to reduce API surface area and solve inconsistency of `appState.openSidebar.tab` not reflecting actual UI value if `defaultTab` was supported (without additional syncing logic which feels like the wrong solution). * remove `onToggle` in favor of `onStateChange` reducing API surface area * fix restore * comment no longer applies * reuse `Button` component in sidebar buttons * fix tests * split Sidebar sub-components into files * remove `props.dockable` in favor of `props.onDock` only * split tests * fix sidebar showing dock button if no `props.docked` supplied & add more tests * reorder and group sidebar tests * clarify * rename classes & dedupe css * refactor tests * update changelog * update changelog --------- Co-authored-by: barnabasmolnar <barnabas@excalidraw.com>
63 lines
1.6 KiB
TypeScript
63 lines
1.6 KiB
TypeScript
import { useOutsideClick } from "../../hooks/useOutsideClick";
|
|
import { Island } from "../Island";
|
|
|
|
import { useDevice } from "../App";
|
|
import clsx from "clsx";
|
|
import Stack from "../Stack";
|
|
import React from "react";
|
|
import { DropdownMenuContentPropsContext } from "./common";
|
|
|
|
const MenuContent = ({
|
|
children,
|
|
onClickOutside,
|
|
className = "",
|
|
onSelect,
|
|
style,
|
|
}: {
|
|
children?: React.ReactNode;
|
|
onClickOutside?: () => void;
|
|
className?: string;
|
|
/**
|
|
* Called when any menu item is selected (clicked on).
|
|
*/
|
|
onSelect?: (event: Event) => void;
|
|
style?: React.CSSProperties;
|
|
}) => {
|
|
const device = useDevice();
|
|
const menuRef = useOutsideClick(() => {
|
|
onClickOutside?.();
|
|
});
|
|
|
|
const classNames = clsx(`dropdown-menu ${className}`, {
|
|
"dropdown-menu--mobile": device.isMobile,
|
|
}).trim();
|
|
|
|
return (
|
|
<DropdownMenuContentPropsContext.Provider value={{ onSelect }}>
|
|
<div
|
|
ref={menuRef}
|
|
className={classNames}
|
|
style={style}
|
|
data-testid="dropdown-menu"
|
|
>
|
|
{/* the zIndex ensures this menu has higher stacking order,
|
|
see https://github.com/excalidraw/excalidraw/pull/1445 */}
|
|
{device.isMobile ? (
|
|
<Stack.Col className="dropdown-menu-container">{children}</Stack.Col>
|
|
) : (
|
|
<Island
|
|
className="dropdown-menu-container"
|
|
padding={2}
|
|
style={{ zIndex: 1 }}
|
|
>
|
|
{children}
|
|
</Island>
|
|
)}
|
|
</div>
|
|
</DropdownMenuContentPropsContext.Provider>
|
|
);
|
|
};
|
|
MenuContent.displayName = "DropdownMenuContent";
|
|
|
|
export default MenuContent;
|