wip

dev-docs/docs/@excalidraw/excalidraw/api/props/props.mdx

@@ -23,7 +23,7 @@ All `props` are _optional_.
 | [`libraryReturnUrl`](#libraryreturnurl) | `string` | _ | What URL should [libraries.excalidraw.com](https://libraries.excalidraw.com) be installed to |
 | [`theme`](#theme) | `"light"` | `"dark"` | `"light"` | The theme of the Excalidraw component |
 | [`name`](#name) | `string` |  | Name of the drawing |
-| [`UIOptions`](/docs/@excalidraw/excalidraw/api/props/ui-options) | `object` | [DEFAULT UI OPTIONS](https://github.com/excalidraw/excalidraw/blob/master/packages/excalidraw/constants.ts#L151) | To customise UI options. Currently we support customising [`canvas actions`](/docs/@excalidraw/excalidraw/api/props/ui-options#canvasactions) |
+| [`UIOptions`](/docs/@excalidraw/excalidraw/api/props/ui-options) | `object` | [DEFAULT UI OPTIONS](https://github.com/excalidraw/excalidraw/blob/master/packages/excalidraw/constants.ts#L151) | To customise UI options. Currently we support customising [`canvas actions`](#canvasactions) |
 | [`detectScroll`](#detectscroll) | `boolean` | `true` | Indicates whether to update the offsets when nearest ancestor is scrolled. |
 | [`handleKeyboardGlobally`](#handlekeyboardglobally) | `boolean` | `false` | Indicates whether to bind the keyboard events to document. |
 | [`autoFocus`](#autofocus) | `boolean` | `false` | indicates whether to focus the Excalidraw component on page load |

excalidraw-app/collab/Collab.tsx

@@ -442,6 +442,7 @@ class Collab extends PureComponent<Props, CollabState> {
     );
 
     const fallbackInitializationHandler = () => {
+      console.log("fallbackInitializationHandler");
       this.initializeRoom({
         roomLinkData: existingRoomLinkData,
         fetchScene: true,
@@ -516,7 +517,9 @@ class Collab extends PureComponent<Props, CollabState> {
           case WS_SUBTYPES.INVALID_RESPONSE:
             return;
           case WS_SUBTYPES.INIT: {
+            console.log("INIT (1)");
             if (!this.portal.socketInitialized) {
+              console.log("INIT (2)");
               this.initializeRoom({ fetchScene: false });
               const remoteElements = decryptedData.payload.elements;
               const reconciledElements = this.reconcileElements(remoteElements);
@@ -606,6 +609,7 @@ class Collab extends PureComponent<Props, CollabState> {
     );
 
     this.portal.socket.on("first-in-room", async () => {
+      console.log("first-in-room");
       if (this.portal.socket) {
         this.portal.socket.off("first-in-room");
       }

excalidraw-app/collab/Portal.tsx

@@ -38,9 +38,17 @@ class Portal {
     this.roomId = id;
     this.roomKey = key;
 
+    this.socket.on("connect", () => {
+      console.log("connect");
+    });
+
+    console.log("subbing to init-room");
+
     // Initialize socket listeners
     this.socket.on("init-room", () => {
+      console.log("init-room (1)");
       if (this.socket) {
+        console.log("init-room (2)");
         this.socket.emit("join-room", this.roomId);
         trackEvent("share", "room joined");
       }
@@ -53,6 +61,7 @@ class Portal {
       );
     });
     this.socket.on("room-user-change", (clients: SocketId[]) => {
+      console.log("room-user-change", clients);
       this.collab.setCollaborators(clients);
     });
 

packages/excalidraw/actions/actionAlign.tsx

@@ -11,6 +11,7 @@ import { ToolButton } from "../components/ToolButton";
 import { getNonDeletedElements } from "../element";
 import { isFrameLikeElement } from "../element/typeChecks";
 import { ExcalidrawElement } from "../element/types";
+import { updateFrameMembershipOfSelectedElements } from "../frame";
 import { t } from "../i18n";
 import { KEYS } from "../keys";
 import { isSomeElementSelected } from "../scene";
@@ -44,8 +45,10 @@ const alignSelectedElements = (
 
   const updatedElementsMap = arrayToMap(updatedElements);
 
-  return elements.map(
+  return updateFrameMembershipOfSelectedElements(
-    (element) => updatedElementsMap.get(element.id) || element,
+    elements.map((element) => updatedElementsMap.get(element.id) || element),
+    appState,
+    app,
   );
 };
 

packages/excalidraw/actions/actionDistribute.tsx

@@ -7,6 +7,7 @@ import { distributeElements, Distribution } from "../distribute";
 import { getNonDeletedElements } from "../element";
 import { isFrameLikeElement } from "../element/typeChecks";
 import { ExcalidrawElement } from "../element/types";
+import { updateFrameMembershipOfSelectedElements } from "../frame";
 import { t } from "../i18n";
 import { CODES, KEYS } from "../keys";
 import { isSomeElementSelected } from "../scene";
@@ -35,8 +36,10 @@ const distributeSelectedElements = (
 
   const updatedElementsMap = arrayToMap(updatedElements);
 
-  return elements.map(
+  return updateFrameMembershipOfSelectedElements(
-    (element) => updatedElementsMap.get(element.id) || element,
+    elements.map((element) => updatedElementsMap.get(element.id) || element),
+    appState,
+    app,
   );
 };
 

packages/excalidraw/actions/actionDuplicateSelection.tsx

@@ -104,8 +104,8 @@ const duplicateElements = (
 
   const idsOfElementsToDuplicate = arrayToMap(
     getSelectedElements(sortedElements, appState, {
-      includeBoundTextElement: false,
+      includeBoundTextElement: true,
-      includeElementsInFrames: false,
+      includeElementsInFrames: true,
     }),
   );
 

packages/excalidraw/actions/actionFlip.ts

@@ -19,7 +19,11 @@ export const actionFlipHorizontal = register({
   trackEvent: { category: "element" },
   perform: (elements, appState, _, app) => {
     return {
-      elements: flipSelectedElements(elements, appState, "horizontal"),
+      elements: updateFrameMembershipOfSelectedElements(
+        flipSelectedElements(elements, appState, "horizontal"),
+        appState,
+        app,
+      ),
       appState,
       commitToHistory: true,
     };

packages/excalidraw/components/App.tsx

@@ -267,7 +267,6 @@ import {
   isTransparent,
   easeToValuesRAF,
   muteFSAbortError,
-  arrayToMap,
   isTestEnv,
   easeOut,
   updateStable,
@@ -2178,13 +2177,6 @@ class App extends React.Component<AppProps, AppState> {
           },
         );
       }
-
-      // update frame membership if needed
-      updateFrameMembershipOfSelectedElements(
-        this.scene.getElementsIncludingDeleted(),
-        this.state,
-        this,
-      );
     },
   );
 
@@ -4348,13 +4340,11 @@ class App extends React.Component<AppProps, AppState> {
                   !(isTextElement(element) && element.containerId)),
             );
 
-    const elementsMap = arrayToMap(elements);
-
     return getElementsAtPosition(elements, (element) =>
       hitTest(element, this.state, this.frameNameBoundsCache, x, y),
     ).filter((element) => {
       // hitting a frame's element from outside the frame is not considered a hit
-      const containingFrame = getContainingFrame(element, elementsMap);
+      const containingFrame = getContainingFrame(element);
       return containingFrame &&
         this.state.frameRendering.enabled &&
         this.state.frameRendering.clip
@@ -7689,10 +7679,7 @@ class App extends React.Component<AppProps, AppState> {
             );
 
             if (linearElement?.frameId) {
-              const frame = getContainingFrame(
+              const frame = getContainingFrame(linearElement);
-                linearElement,
-                arrayToMap(this.scene.getElementsIncludingDeleted()),
-              );
 
               if (frame && linearElement) {
                 if (!elementOverlapsWithFrame(linearElement, frame)) {

packages/excalidraw/scene/selection.ts

@@ -11,7 +11,6 @@ import {
   getFrameChildren,
 } from "../frame";
 import { isShallowEqual } from "../utils";
-import { arrayToMap } from "../utils";
 import { isElementInViewport } from "../element/sizeHelpers";
 
 /**
@@ -49,13 +48,11 @@ export const getElementsWithinSelection = (
   const [selectionX1, selectionY1, selectionX2, selectionY2] =
     getElementAbsoluteCoords(selection);
 
-  const elementsMap = arrayToMap(elements);
-
   let elementsInSelection = elements.filter((element) => {
     let [elementX1, elementY1, elementX2, elementY2] =
       getElementBounds(element);
 
-    const containingFrame = getContainingFrame(element, elementsMap);
+    const containingFrame = getContainingFrame(element);
     if (containingFrame) {
       const [fx1, fy1, fx2, fy2] = getElementBounds(containingFrame);
 
@@ -81,7 +78,7 @@ export const getElementsWithinSelection = (
     : elementsInSelection;
 
   elementsInSelection = elementsInSelection.filter((element) => {
-    const containingFrame = getContainingFrame(element, elementsMap);
+    const containingFrame = getContainingFrame(element);
 
     if (containingFrame) {
       return elementOverlapsWithFrame(element, containingFrame);