Compare commits
43 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 4330f3ec9d | |||
| d5aad6202d | |||
| db73e30eae | |||
| f472af04a9 | |||
| c08be69618 | |||
| b42b1a193d | |||
| f6d85bc80f | |||
| 0457ac9063 | |||
| b2b2815954 | |||
| d992c10bc1 | |||
| 091b9053a3 | |||
| 97274a74b2 | |||
| c59fb8dcbc | |||
| 7f56cc0cf3 | |||
| 974b338b7e | |||
| d2557474e2 | |||
| 3004c642da | |||
| 2dfcc6f0ce | |||
| 3f5fdec04e | |||
| 278cd35772 | |||
| 43fa4b5602 | |||
| 2e1a529c67 | |||
| b1c6bfcf40 | |||
| 1caec99b29 | |||
| e18c1dd213 | |||
| d9e8a33aa4 | |||
| 4be4cc0ed0 | |||
| 4a5c9e990c | |||
| c09e170bdd | |||
| c1082923ee | |||
| 1c292e4936 | |||
| d6f0f34fe9 | |||
| 75789f620d | |||
| a9ca16eb42 | |||
| 987173b52f | |||
| 81ab857a6f | |||
| e8b4620a96 | |||
| 2b0e4c9623 | |||
| c9ba7f839c | |||
| b4ce7c713b | |||
| 816c81c12e | |||
| 92d25446d6 | |||
| e73a5b0116 |
@@ -1,4 +1,4 @@
|
|||||||
FROM node:18-bullseye
|
FROM node:24-bullseye
|
||||||
|
|
||||||
# Vite wants to open the browser using `open`, so we
|
# Vite wants to open the browser using `open`, so we
|
||||||
# need to install those utils.
|
# need to install those utils.
|
||||||
|
|||||||
@@ -9,11 +9,11 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
with:
|
with:
|
||||||
fetch-depth: 2
|
fetch-depth: 2
|
||||||
- name: Setup Node.js
|
- name: Setup Node.js
|
||||||
uses: actions/setup-node@v2
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: 20.x
|
node-version: 20.x
|
||||||
- name: Set up publish access
|
- name: Set up publish access
|
||||||
|
|||||||
@@ -9,5 +9,5 @@ jobs:
|
|||||||
build-docker:
|
build-docker:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- run: docker build -t excalidraw .
|
- run: docker build -t excalidraw .
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
timeout-minutes: 3
|
timeout-minutes: 3
|
||||||
steps:
|
steps:
|
||||||
- uses: styfle/cancel-workflow-action@0.6.0
|
- uses: styfle/cancel-workflow-action@ce177499ccf9fd2aded3b0426c97e5434c2e8a73 # 0.6.0
|
||||||
with:
|
with:
|
||||||
workflow_id: 400555, 400556, 905313, 1451724, 1710116, 3185001, 3438604
|
workflow_id: 400555, 400556, 905313, 1451724, 1710116, 3185001, 3438604
|
||||||
access_token: ${{ secrets.GITHUB_TOKEN }}
|
access_token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -7,10 +7,10 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
|
|
||||||
- name: Setup Node.js
|
- name: Setup Node.js
|
||||||
uses: actions/setup-node@v2
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: 20.x
|
node-version: 20.x
|
||||||
|
|
||||||
|
|||||||
@@ -10,12 +10,12 @@ jobs:
|
|||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
with:
|
with:
|
||||||
token: ${{ secrets.PUSH_TRANSLATIONS_COVERAGE_PAT }}
|
token: ${{ secrets.PUSH_TRANSLATIONS_COVERAGE_PAT }}
|
||||||
|
|
||||||
- name: Setup Node.js
|
- name: Setup Node.js
|
||||||
uses: actions/setup-node@v2
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: 20.x
|
node-version: 20.x
|
||||||
|
|
||||||
@@ -40,7 +40,7 @@ jobs:
|
|||||||
echo ::set-output name=body::$body
|
echo ::set-output name=body::$body
|
||||||
|
|
||||||
- name: Update description with coverage
|
- name: Update description with coverage
|
||||||
uses: kt3k/update-pr-description@v1.0.1
|
uses: kt3k/update-pr-description@1b35a6dcd84d81aa0bc1889610efdcde7f37b0c0 # v1.0.1
|
||||||
with:
|
with:
|
||||||
pr_body: ${{ steps.getCommentBody.outputs.body }}
|
pr_body: ${{ steps.getCommentBody.outputs.body }}
|
||||||
pr_title: "chore: Update translations from Crowdin"
|
pr_title: "chore: Update translations from Crowdin"
|
||||||
|
|||||||
@@ -11,18 +11,18 @@ jobs:
|
|||||||
|
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v3
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- name: Login to DockerHub
|
- name: Login to DockerHub
|
||||||
uses: docker/login-action@v2
|
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2
|
||||||
with:
|
with:
|
||||||
username: ${{ secrets.DOCKER_USERNAME }}
|
username: ${{ secrets.DOCKER_USERNAME }}
|
||||||
password: ${{ secrets.DOCKER_PASSWORD }}
|
password: ${{ secrets.DOCKER_PASSWORD }}
|
||||||
- name: Set up QEMU
|
- name: Set up QEMU
|
||||||
uses: docker/setup-qemu-action@v3
|
uses: docker/setup-qemu-action@c7c53464625b32c7a7e944ae62b3e17d2b600130 # v3
|
||||||
- name: Set up Docker Buildx
|
- name: Set up Docker Buildx
|
||||||
uses: docker/setup-buildx-action@v3
|
uses: docker/setup-buildx-action@8d2750c68a42422c14e847fe6c8ac0403b4cbd6f # v3
|
||||||
- name: Build and push
|
- name: Build and push
|
||||||
uses: docker/build-push-action@v5
|
uses: docker/build-push-action@ca052bb54ab0790a636c9b5f226502c73d547a25 # v5
|
||||||
with:
|
with:
|
||||||
context: .
|
context: .
|
||||||
push: true
|
push: true
|
||||||
|
|||||||
@@ -6,11 +6,97 @@ on:
|
|||||||
- opened
|
- opened
|
||||||
- edited
|
- edited
|
||||||
- synchronize
|
- synchronize
|
||||||
|
- labeled
|
||||||
|
- unlabeled
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
semantic:
|
semantic:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
permissions:
|
||||||
|
pull-requests: read
|
||||||
steps:
|
steps:
|
||||||
- uses: amannn/action-semantic-pull-request@v5
|
- uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5
|
||||||
|
with:
|
||||||
|
requireScope: true
|
||||||
|
scopes: |
|
||||||
|
app
|
||||||
|
editor
|
||||||
|
packages/excalidraw
|
||||||
|
packages/utils
|
||||||
|
docker
|
||||||
|
repo
|
||||||
|
ignoreLabels: |
|
||||||
|
skip-semantic-title
|
||||||
env:
|
env:
|
||||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|
||||||
|
label-scope:
|
||||||
|
needs: semantic
|
||||||
|
if: github.event.pull_request.head.repo.full_name == github.repository
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
permissions:
|
||||||
|
issues: write
|
||||||
|
pull-requests: write
|
||||||
|
steps:
|
||||||
|
- name: Label scoped PR
|
||||||
|
env:
|
||||||
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||||
|
PR_TITLE: ${{ github.event.pull_request.title }}
|
||||||
|
REPOSITORY: ${{ github.repository }}
|
||||||
|
run: |
|
||||||
|
set -euo pipefail
|
||||||
|
|
||||||
|
scope_labels=(s-app s-editor s-package)
|
||||||
|
|
||||||
|
readarray -t desired_labels < <(
|
||||||
|
node <<'NODE'
|
||||||
|
const title = process.env.PR_TITLE;
|
||||||
|
const match = title.match(/^[a-z]+(?:\(([^)]+)\))?!?:/i);
|
||||||
|
const scopes = match?.[1]?.split(",").map((scope) => scope.trim()) ?? [];
|
||||||
|
const labels = new Set();
|
||||||
|
|
||||||
|
for (const scope of scopes) {
|
||||||
|
if (scope === "app") {
|
||||||
|
labels.add("s-app");
|
||||||
|
} else if (scope === "editor") {
|
||||||
|
labels.add("s-editor");
|
||||||
|
} else if (scope.startsWith("packages/")) {
|
||||||
|
labels.add("s-package");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
process.stdout.write([...labels].join("\n"));
|
||||||
|
NODE
|
||||||
|
)
|
||||||
|
|
||||||
|
should_apply_label() {
|
||||||
|
local label="$1"
|
||||||
|
|
||||||
|
for desired_label in "${desired_labels[@]}"; do
|
||||||
|
if [[ "$desired_label" == "$label" ]]; then
|
||||||
|
return 0
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
return 1
|
||||||
|
}
|
||||||
|
|
||||||
|
for label in "${scope_labels[@]}"; do
|
||||||
|
if ! should_apply_label "$label"; then
|
||||||
|
gh api \
|
||||||
|
--method DELETE \
|
||||||
|
"repos/${REPOSITORY}/issues/${PR_NUMBER}/labels/${label}" \
|
||||||
|
--silent 2>/dev/null || true
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
for label in "${desired_labels[@]}"; do
|
||||||
|
if ! gh api \
|
||||||
|
--method POST \
|
||||||
|
"repos/${REPOSITORY}/issues/${PR_NUMBER}/labels" \
|
||||||
|
--field "labels[]=${label}" \
|
||||||
|
--silent; then
|
||||||
|
echo "::warning::Could not apply ${label}. The workflow token likely does not have issues:write permission for this PR."
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|||||||
@@ -9,9 +9,9 @@ jobs:
|
|||||||
sentry:
|
sentry:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- name: Setup Node.js
|
- name: Setup Node.js
|
||||||
uses: actions/setup-node@v2
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: 20.x
|
node-version: 20.x
|
||||||
- name: Install and build
|
- name: Install and build
|
||||||
|
|||||||
@@ -10,9 +10,9 @@ jobs:
|
|||||||
CI_JOB_NUMBER: 1
|
CI_JOB_NUMBER: 1
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v3
|
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- name: Setup Node.js
|
- name: Setup Node.js
|
||||||
uses: actions/setup-node@v3
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: 20.x
|
node-version: 20.x
|
||||||
- name: Install in packages/excalidraw
|
- name: Install in packages/excalidraw
|
||||||
@@ -20,7 +20,7 @@ jobs:
|
|||||||
working-directory: packages/excalidraw
|
working-directory: packages/excalidraw
|
||||||
env:
|
env:
|
||||||
CI: true
|
CI: true
|
||||||
- uses: andresz1/size-limit-action@v1
|
- uses: andresz1/size-limit-action@e7493a72a44b113341c0cf6186ab49c17c4b65c1 # v1
|
||||||
with:
|
with:
|
||||||
github_token: ${{ secrets.GITHUB_TOKEN }}
|
github_token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
build_script: build:esm
|
build_script: build:esm
|
||||||
|
|||||||
@@ -10,9 +10,9 @@ jobs:
|
|||||||
pull-requests: write
|
pull-requests: write
|
||||||
|
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v2
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- name: "Install Node"
|
- name: "Install Node"
|
||||||
uses: actions/setup-node@v2
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: "20.x"
|
node-version: "20.x"
|
||||||
- name: "Install Deps"
|
- name: "Install Deps"
|
||||||
@@ -21,6 +21,6 @@ jobs:
|
|||||||
run: yarn test:coverage
|
run: yarn test:coverage
|
||||||
- name: "Report Coverage"
|
- name: "Report Coverage"
|
||||||
if: always() # Also generate the report if tests are failing
|
if: always() # Also generate the report if tests are failing
|
||||||
uses: davelosert/vitest-coverage-report-action@v2
|
uses: davelosert/vitest-coverage-report-action@2500dafcee7dd64f85ab689c0b83798a8359770e # v2
|
||||||
with:
|
with:
|
||||||
github-token: ${{ secrets.GITHUB_TOKEN }}
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|||||||
@@ -8,9 +8,9 @@ jobs:
|
|||||||
test:
|
test:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v4
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- name: Setup Node.js
|
- name: Setup Node.js
|
||||||
uses: actions/setup-node@v4
|
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
||||||
with:
|
with:
|
||||||
node-version: 20.x
|
node-version: 20.x
|
||||||
- name: Install and test
|
- name: Install and test
|
||||||
|
|||||||
+3
-3
@@ -1,4 +1,4 @@
|
|||||||
FROM --platform=${BUILDPLATFORM} node:18 AS build
|
FROM --platform=${BUILDPLATFORM} node:24@sha256:8530f76a96d88820d288761f022e318970dda93d01536919fbc16076b7983e63 AS build
|
||||||
|
|
||||||
WORKDIR /opt/node_app
|
WORKDIR /opt/node_app
|
||||||
|
|
||||||
@@ -7,13 +7,13 @@ COPY . .
|
|||||||
# do not ignore optional dependencies:
|
# do not ignore optional dependencies:
|
||||||
# Error: Cannot find module @rollup/rollup-linux-x64-gnu
|
# Error: Cannot find module @rollup/rollup-linux-x64-gnu
|
||||||
RUN --mount=type=cache,target=/root/.cache/yarn \
|
RUN --mount=type=cache,target=/root/.cache/yarn \
|
||||||
npm_config_target_arch=${TARGETARCH} yarn --network-timeout 600000
|
npm_config_target_arch=${TARGETARCH} yarn --frozen-lockfile --network-timeout 600000
|
||||||
|
|
||||||
ARG NODE_ENV=production
|
ARG NODE_ENV=production
|
||||||
|
|
||||||
RUN npm_config_target_arch=${TARGETARCH} yarn build:app:docker
|
RUN npm_config_target_arch=${TARGETARCH} yarn build:app:docker
|
||||||
|
|
||||||
FROM --platform=${TARGETPLATFORM} nginx:1.27-alpine
|
FROM nginx:stable-alpine-slim@sha256:2c605dbeab79a6b2a63340474fe58119d0ef95bdc4b1f41df0aa689659b3d13b
|
||||||
|
|
||||||
COPY --from=build /opt/node_app/excalidraw-app/build /usr/share/nginx/html
|
COPY --from=build /opt/node_app/excalidraw-app/build /usr/share/nginx/html
|
||||||
|
|
||||||
|
|||||||
@@ -29,7 +29,7 @@
|
|||||||
<a href="https://docs.excalidraw.com/docs/introduction/contributing">
|
<a href="https://docs.excalidraw.com/docs/introduction/contributing">
|
||||||
<img alt="PRs welcome!" src="https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat" /></a>
|
<img alt="PRs welcome!" src="https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat" /></a>
|
||||||
<a href="https://discord.gg/UexuTaE">
|
<a href="https://discord.gg/UexuTaE">
|
||||||
<img alt="Chat on Discord" src="https://img.shields.io/discord/723672430744174682?color=738ad6&label=Chat%20on%20Discord&logo=discord&logoColor=ffffff&widge=false"/></a>
|
<img alt="Chat on Discord" src="https://img.shields.io/discord/723672430744174682?color=738ad6&label=Chat%20on%20Discord&logo=discord&logoColor=ffffff&widget=false"/></a>
|
||||||
<a href="https://deepwiki.com/excalidraw/excalidraw">
|
<a href="https://deepwiki.com/excalidraw/excalidraw">
|
||||||
<img alt="Ask DeepWiki" src="https://deepwiki.com/badge.svg" /></a>
|
<img alt="Ask DeepWiki" src="https://deepwiki.com/badge.svg" /></a>
|
||||||
<a href="https://twitter.com/excalidraw">
|
<a href="https://twitter.com/excalidraw">
|
||||||
|
|||||||
@@ -172,7 +172,7 @@ convertToExcalidrawElements([
|
|||||||
type: "arrow",
|
type: "arrow",
|
||||||
x: 450,
|
x: 450,
|
||||||
y: 20,
|
y: 20,
|
||||||
startArrowhead: "dot",
|
startArrowhead: "circle",
|
||||||
endArrowhead: "triangle",
|
endArrowhead: "triangle",
|
||||||
strokeColor: "#1971c2",
|
strokeColor: "#1971c2",
|
||||||
strokeWidth: 2,
|
strokeWidth: 2,
|
||||||
|
|||||||
@@ -97,8 +97,8 @@ const config = {
|
|||||||
href: "https://discord.gg/UexuTaE",
|
href: "https://discord.gg/UexuTaE",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: "Twitter",
|
label: "𝕏",
|
||||||
href: "https://twitter.com/excalidraw",
|
href: "https://x.com/excalidraw",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: "Linkedin",
|
label: "Linkedin",
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
"use client";
|
"use client";
|
||||||
|
|
||||||
import * as excalidrawLib from "@excalidraw/excalidraw";
|
import * as excalidrawLib from "@excalidraw/excalidraw";
|
||||||
import { Excalidraw } from "@excalidraw/excalidraw";
|
import { Excalidraw } from "@excalidraw/excalidraw";
|
||||||
|
|
||||||
@@ -13,6 +14,7 @@ const ExcalidrawWrapper: React.FC = () => {
|
|||||||
appTitle={"Excalidraw with Nextjs Example"}
|
appTitle={"Excalidraw with Nextjs Example"}
|
||||||
useCustom={(api: any, args?: any[]) => {}}
|
useCustom={(api: any, args?: any[]) => {}}
|
||||||
excalidrawLib={excalidrawLib}
|
excalidrawLib={excalidrawLib}
|
||||||
|
showFadeDemo={true}
|
||||||
>
|
>
|
||||||
<Excalidraw />
|
<Excalidraw />
|
||||||
</App>
|
</App>
|
||||||
|
|||||||
@@ -70,6 +70,7 @@ export interface AppProps {
|
|||||||
customArgs?: any[];
|
customArgs?: any[];
|
||||||
children: React.ReactNode;
|
children: React.ReactNode;
|
||||||
excalidrawLib: typeof TExcalidraw;
|
excalidrawLib: typeof TExcalidraw;
|
||||||
|
showFadeDemo?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
export default function ExampleApp({
|
export default function ExampleApp({
|
||||||
@@ -78,6 +79,7 @@ export default function ExampleApp({
|
|||||||
customArgs,
|
customArgs,
|
||||||
children,
|
children,
|
||||||
excalidrawLib,
|
excalidrawLib,
|
||||||
|
showFadeDemo = false,
|
||||||
}: AppProps) {
|
}: AppProps) {
|
||||||
const {
|
const {
|
||||||
exportToCanvas,
|
exportToCanvas,
|
||||||
@@ -116,6 +118,19 @@ export default function ExampleApp({
|
|||||||
{},
|
{},
|
||||||
);
|
);
|
||||||
const [comment, setComment] = useState<Comment | null>(null);
|
const [comment, setComment] = useState<Comment | null>(null);
|
||||||
|
const [hideAllForFadeDemo, setHideAllForFadeDemo] = useState(false);
|
||||||
|
const [fadeDemoNextIndex, setFadeDemoNextIndex] = useState(0);
|
||||||
|
const [fadeDemoElementIds, setFadeDemoElementIds] = useState<string[]>([]);
|
||||||
|
const [demoAnimationType, setDemoAnimationType] = useState<"fade" | "fly">(
|
||||||
|
"fade",
|
||||||
|
);
|
||||||
|
const [demoAnimationDuration, setDemoAnimationDuration] = useState(500);
|
||||||
|
const [demoFlyFrom, setDemoFlyFrom] = useState<
|
||||||
|
"left" | "right" | "top" | "bottom"
|
||||||
|
>("left");
|
||||||
|
const [demoAnimationEasing, setDemoAnimationEasing] = useState<
|
||||||
|
"linear" | "easeOut" | "easeInOut"
|
||||||
|
>("easeOut");
|
||||||
|
|
||||||
const initialStatePromiseRef = useRef<{
|
const initialStatePromiseRef = useRef<{
|
||||||
promise: ResolvablePromise<ExcalidrawInitialDataState | null>;
|
promise: ResolvablePromise<ExcalidrawInitialDataState | null>;
|
||||||
@@ -178,7 +193,8 @@ export default function ExampleApp({
|
|||||||
const newElement = cloneElement(
|
const newElement = cloneElement(
|
||||||
Excalidraw,
|
Excalidraw,
|
||||||
{
|
{
|
||||||
excalidrawAPI: (api: ExcalidrawImperativeAPI) => setExcalidrawAPI(api),
|
onExcalidrawAPI: (api: ExcalidrawImperativeAPI | null) =>
|
||||||
|
setExcalidrawAPI(api),
|
||||||
initialData: initialStatePromiseRef.current.promise,
|
initialData: initialStatePromiseRef.current.promise,
|
||||||
onChange: (
|
onChange: (
|
||||||
elements: NonDeletedExcalidrawElement[],
|
elements: NonDeletedExcalidrawElement[],
|
||||||
@@ -208,6 +224,10 @@ export default function ExampleApp({
|
|||||||
onPointerDown,
|
onPointerDown,
|
||||||
onScrollChange: rerenderCommentIcons,
|
onScrollChange: rerenderCommentIcons,
|
||||||
validateEmbeddable: true,
|
validateEmbeddable: true,
|
||||||
|
resolveRenderOpacity: hideAllForFadeDemo
|
||||||
|
? (element: NonDeletedExcalidrawElement) =>
|
||||||
|
fadeDemoElementIds.includes(element.id) ? 0 : undefined
|
||||||
|
: undefined,
|
||||||
},
|
},
|
||||||
<>
|
<>
|
||||||
{excalidrawAPI && (
|
{excalidrawAPI && (
|
||||||
@@ -664,6 +684,229 @@ export default function ExampleApp({
|
|||||||
>
|
>
|
||||||
Reset Scene
|
Reset Scene
|
||||||
</button>
|
</button>
|
||||||
|
{showFadeDemo && (
|
||||||
|
<>
|
||||||
|
<label>
|
||||||
|
Animation type
|
||||||
|
<select
|
||||||
|
value={demoAnimationType}
|
||||||
|
onChange={(event) =>
|
||||||
|
setDemoAnimationType(
|
||||||
|
event.target.value as "fade" | "fly",
|
||||||
|
)
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<option value="fade">fade</option>
|
||||||
|
<option value="fly">fly</option>
|
||||||
|
</select>
|
||||||
|
</label>
|
||||||
|
<label>
|
||||||
|
Duration
|
||||||
|
<input
|
||||||
|
type="number"
|
||||||
|
value={demoAnimationDuration}
|
||||||
|
onChange={(event) =>
|
||||||
|
setDemoAnimationDuration(Number(event.target.value) || 0)
|
||||||
|
}
|
||||||
|
/>
|
||||||
|
</label>
|
||||||
|
<label>
|
||||||
|
Easing
|
||||||
|
<select
|
||||||
|
value={demoAnimationEasing}
|
||||||
|
onChange={(event) =>
|
||||||
|
setDemoAnimationEasing(
|
||||||
|
event.target.value as "linear" | "easeOut" | "easeInOut",
|
||||||
|
)
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<option value="linear">linear</option>
|
||||||
|
<option value="easeOut">easeOut</option>
|
||||||
|
<option value="easeInOut">easeInOut</option>
|
||||||
|
</select>
|
||||||
|
</label>
|
||||||
|
{demoAnimationType === "fly" && (
|
||||||
|
<label>
|
||||||
|
Fly from
|
||||||
|
<select
|
||||||
|
value={demoFlyFrom}
|
||||||
|
onChange={(event) =>
|
||||||
|
setDemoFlyFrom(
|
||||||
|
event.target.value as
|
||||||
|
| "left"
|
||||||
|
| "right"
|
||||||
|
| "top"
|
||||||
|
| "bottom",
|
||||||
|
)
|
||||||
|
}
|
||||||
|
>
|
||||||
|
<option value="left">left</option>
|
||||||
|
<option value="right">right</option>
|
||||||
|
<option value="top">top</option>
|
||||||
|
<option value="bottom">bottom</option>
|
||||||
|
</select>
|
||||||
|
</label>
|
||||||
|
)}
|
||||||
|
<button
|
||||||
|
onClick={() => {
|
||||||
|
if (!excalidrawAPI) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
setFadeDemoElementIds(
|
||||||
|
excalidrawAPI
|
||||||
|
.getSceneElements()
|
||||||
|
.map((element) => element.id),
|
||||||
|
);
|
||||||
|
excalidrawAPI.clearElementAnimationOverrides();
|
||||||
|
setHideAllForFadeDemo(true);
|
||||||
|
setFadeDemoNextIndex(0);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Hide every element
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => {
|
||||||
|
if (!excalidrawAPI || !hideAllForFadeDemo) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const elements = excalidrawAPI
|
||||||
|
.getSceneElements()
|
||||||
|
.filter((element) =>
|
||||||
|
fadeDemoElementIds.includes(element.id),
|
||||||
|
);
|
||||||
|
|
||||||
|
if (!elements.length) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const nextIndex =
|
||||||
|
fadeDemoNextIndex >= elements.length
|
||||||
|
? 0
|
||||||
|
: fadeDemoNextIndex;
|
||||||
|
|
||||||
|
if (nextIndex === 0) {
|
||||||
|
excalidrawAPI.clearElementAnimationOverrides();
|
||||||
|
}
|
||||||
|
|
||||||
|
if (demoAnimationType === "fly") {
|
||||||
|
excalidrawAPI.animateElements({
|
||||||
|
elements: [elements[nextIndex].id],
|
||||||
|
type: "fly",
|
||||||
|
from: demoFlyFrom,
|
||||||
|
duration: demoAnimationDuration,
|
||||||
|
phase: "in",
|
||||||
|
easing: demoAnimationEasing,
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
excalidrawAPI.animateElements({
|
||||||
|
elements: [elements[nextIndex].id],
|
||||||
|
type: "fade",
|
||||||
|
duration: demoAnimationDuration,
|
||||||
|
phase: "in",
|
||||||
|
easing: demoAnimationEasing,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
setFadeDemoNextIndex(nextIndex + 1);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Animate in next element
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => {
|
||||||
|
if (!excalidrawAPI || !hideAllForFadeDemo) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const elements = excalidrawAPI
|
||||||
|
.getSceneElements()
|
||||||
|
.filter((element) =>
|
||||||
|
fadeDemoElementIds.includes(element.id),
|
||||||
|
);
|
||||||
|
|
||||||
|
if (!elements.length) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (demoAnimationType === "fly") {
|
||||||
|
excalidrawAPI.animateElements({
|
||||||
|
elements,
|
||||||
|
type: "fly",
|
||||||
|
from: demoFlyFrom,
|
||||||
|
duration: demoAnimationDuration,
|
||||||
|
stagger: 120,
|
||||||
|
phase: "in",
|
||||||
|
easing: demoAnimationEasing,
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
excalidrawAPI.animateElements({
|
||||||
|
elements,
|
||||||
|
type: "fade",
|
||||||
|
duration: demoAnimationDuration,
|
||||||
|
stagger: 120,
|
||||||
|
phase: "in",
|
||||||
|
easing: demoAnimationEasing,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
setFadeDemoNextIndex(elements.length);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Animate in all
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
onClick={() => {
|
||||||
|
if (!excalidrawAPI || !hideAllForFadeDemo) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const elements = excalidrawAPI
|
||||||
|
.getSceneElements()
|
||||||
|
.filter((element) =>
|
||||||
|
fadeDemoElementIds.includes(element.id),
|
||||||
|
);
|
||||||
|
|
||||||
|
if (!elements.length) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const prevIndex = Math.min(
|
||||||
|
fadeDemoNextIndex - 1,
|
||||||
|
elements.length - 1,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (prevIndex < 0) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (demoAnimationType === "fly") {
|
||||||
|
excalidrawAPI.animateElements({
|
||||||
|
elements: [elements[prevIndex].id],
|
||||||
|
type: "fly",
|
||||||
|
from: demoFlyFrom,
|
||||||
|
duration: demoAnimationDuration,
|
||||||
|
phase: "out",
|
||||||
|
easing: demoAnimationEasing,
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
excalidrawAPI.animateElements({
|
||||||
|
elements: [elements[prevIndex].id],
|
||||||
|
type: "fade",
|
||||||
|
duration: demoAnimationDuration,
|
||||||
|
phase: "out",
|
||||||
|
easing: demoAnimationEasing,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
setFadeDemoNextIndex(prevIndex);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
Animate out prev element
|
||||||
|
</button>
|
||||||
|
</>
|
||||||
|
)}
|
||||||
<button
|
<button
|
||||||
onClick={() => {
|
onClick={() => {
|
||||||
const libraryItems: LibraryItems = [
|
const libraryItems: LibraryItems = [
|
||||||
|
|||||||
@@ -1,7 +1,29 @@
|
|||||||
import type { ExcalidrawElementSkeleton } from "@excalidraw/excalidraw/data/transform";
|
import type { ExcalidrawElementSkeleton } from "@excalidraw/excalidraw/element/transform";
|
||||||
import type { FileId } from "@excalidraw/excalidraw/element/types";
|
import type { FileId } from "@excalidraw/excalidraw/element/types";
|
||||||
|
|
||||||
const elements: ExcalidrawElementSkeleton[] = [
|
const elements: ExcalidrawElementSkeleton[] = [
|
||||||
|
// {
|
||||||
|
// type: "arrow",
|
||||||
|
// x: 100,
|
||||||
|
// y: 500,
|
||||||
|
// },
|
||||||
|
// {
|
||||||
|
// type: "arrow",
|
||||||
|
// x: 250,
|
||||||
|
// y: 250,
|
||||||
|
// label: {
|
||||||
|
// text: "HELLO WORLD!!",
|
||||||
|
// },
|
||||||
|
// start: {
|
||||||
|
// type: "rectangle",
|
||||||
|
// // x: -100,
|
||||||
|
// },
|
||||||
|
// end: {
|
||||||
|
// type: "ellipse",
|
||||||
|
// // x: 300,
|
||||||
|
// },
|
||||||
|
// },
|
||||||
|
|
||||||
{
|
{
|
||||||
type: "rectangle",
|
type: "rectangle",
|
||||||
x: 10,
|
x: 10,
|
||||||
@@ -22,14 +44,14 @@ const elements: ExcalidrawElementSkeleton[] = [
|
|||||||
},
|
},
|
||||||
id: "2",
|
id: "2",
|
||||||
},
|
},
|
||||||
{
|
// {
|
||||||
type: "arrow",
|
// type: "arrow",
|
||||||
x: 100,
|
// x: 100,
|
||||||
y: 200,
|
// y: 200,
|
||||||
label: { text: "HELLO WORLD!!" },
|
// label: { text: "HELLO WORLD!!" },
|
||||||
start: { type: "rectangle" },
|
// start: { type: "rectangle" },
|
||||||
end: { type: "ellipse" },
|
// end: { type: "ellipse" },
|
||||||
},
|
// },
|
||||||
{
|
{
|
||||||
type: "image",
|
type: "image",
|
||||||
x: 606.1042326312408,
|
x: 606.1042326312408,
|
||||||
@@ -38,11 +60,11 @@ const elements: ExcalidrawElementSkeleton[] = [
|
|||||||
height: 230,
|
height: 230,
|
||||||
fileId: "rocket" as FileId,
|
fileId: "rocket" as FileId,
|
||||||
},
|
},
|
||||||
{
|
// {
|
||||||
type: "frame",
|
// type: "frame",
|
||||||
children: ["1", "2"],
|
// children: ["1", "2"],
|
||||||
name: "My frame",
|
// name: "My frame",
|
||||||
},
|
// },
|
||||||
];
|
];
|
||||||
export default {
|
export default {
|
||||||
elements,
|
elements,
|
||||||
|
|||||||
@@ -26,7 +26,6 @@ import {
|
|||||||
get,
|
get,
|
||||||
} from "idb-keyval";
|
} from "idb-keyval";
|
||||||
|
|
||||||
import { appJotaiStore, atom } from "excalidraw-app/app-jotai";
|
|
||||||
import { getNonDeletedElements } from "@excalidraw/element";
|
import { getNonDeletedElements } from "@excalidraw/element";
|
||||||
|
|
||||||
import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library";
|
import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library";
|
||||||
@@ -39,6 +38,7 @@ import type {
|
|||||||
} from "@excalidraw/excalidraw/types";
|
} from "@excalidraw/excalidraw/types";
|
||||||
import type { MaybePromise } from "@excalidraw/common/utility-types";
|
import type { MaybePromise } from "@excalidraw/common/utility-types";
|
||||||
|
|
||||||
|
import { appJotaiStore, atom } from "../app-jotai";
|
||||||
import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants";
|
import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants";
|
||||||
|
|
||||||
import { FileManager } from "./FileManager";
|
import { FileManager } from "./FileManager";
|
||||||
|
|||||||
@@ -75,6 +75,13 @@ export default defineConfig(({ mode }) => {
|
|||||||
find: /^@excalidraw\/utils\/(.*?)/,
|
find: /^@excalidraw\/utils\/(.*?)/,
|
||||||
replacement: path.resolve(__dirname, "../packages/utils/src/$1"),
|
replacement: path.resolve(__dirname, "../packages/utils/src/$1"),
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
find: /^@excalidraw\/fractional-indexing$/,
|
||||||
|
replacement: path.resolve(
|
||||||
|
__dirname,
|
||||||
|
"../packages/fractional-indexing/src/index.ts",
|
||||||
|
),
|
||||||
|
},
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
build: {
|
build: {
|
||||||
|
|||||||
+2
-1
@@ -56,7 +56,8 @@
|
|||||||
"build:element": "yarn --cwd ./packages/element build:esm",
|
"build:element": "yarn --cwd ./packages/element build:esm",
|
||||||
"build:excalidraw": "yarn --cwd ./packages/excalidraw build:esm",
|
"build:excalidraw": "yarn --cwd ./packages/excalidraw build:esm",
|
||||||
"build:math": "yarn --cwd ./packages/math build:esm",
|
"build:math": "yarn --cwd ./packages/math build:esm",
|
||||||
"build:packages": "yarn build:common && yarn build:math && yarn build:element && yarn build:excalidraw",
|
"build:fractional-indexing": "yarn --cwd ./packages/fractional-indexing build:esm",
|
||||||
|
"build:packages": "yarn build:common && yarn build:fractional-indexing && yarn build:math && yarn build:element && yarn build:excalidraw",
|
||||||
"build:version": "yarn --cwd ./excalidraw-app build:version",
|
"build:version": "yarn --cwd ./excalidraw-app build:version",
|
||||||
"build": "yarn --cwd ./excalidraw-app build",
|
"build": "yarn --cwd ./excalidraw-app build",
|
||||||
"build:preview": "yarn --cwd ./excalidraw-app build:preview",
|
"build:preview": "yarn --cwd ./excalidraw-app build:preview",
|
||||||
|
|||||||
@@ -337,9 +337,10 @@ export const MAX_DECIMALS_FOR_SVG_EXPORT = 2;
|
|||||||
export const EXPORT_SCALES = [1, 2, 3];
|
export const EXPORT_SCALES = [1, 2, 3];
|
||||||
export const DEFAULT_EXPORT_PADDING = 10; // px
|
export const DEFAULT_EXPORT_PADDING = 10; // px
|
||||||
|
|
||||||
export const DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT = 1440;
|
export const DEFAULT_IMAGE_OPTIONS: AppProps["imageOptions"] = {
|
||||||
|
maxWidthOrHeight: 1440,
|
||||||
export const MAX_ALLOWED_FILE_BYTES = 4 * 1024 * 1024;
|
maxFileSizeBytes: 4 * 1024 * 1024,
|
||||||
|
};
|
||||||
|
|
||||||
export const SVG_NS = "http://www.w3.org/2000/svg";
|
export const SVG_NS = "http://www.w3.org/2000/svg";
|
||||||
export const SVG_DOCUMENT_PREAMBLE = `<?xml version="1.0" standalone="no"?>
|
export const SVG_DOCUMENT_PREAMBLE = `<?xml version="1.0" standalone="no"?>
|
||||||
|
|||||||
@@ -64,6 +64,7 @@
|
|||||||
},
|
},
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
"@excalidraw/common": "0.18.0",
|
"@excalidraw/common": "0.18.0",
|
||||||
"@excalidraw/math": "0.18.0"
|
"@excalidraw/math": "0.18.0",
|
||||||
|
"@excalidraw/fractional-indexing": "3.3.0"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -338,29 +338,20 @@ export class Scene {
|
|||||||
this.callbacks.clear();
|
this.callbacks.clear();
|
||||||
}
|
}
|
||||||
|
|
||||||
insertElementAtIndex(element: ExcalidrawElement, index: number) {
|
/** low-level - generally use app.insertNewElements() */
|
||||||
if (!Number.isFinite(index) || index < 0) {
|
insertElementsAtIndex(
|
||||||
throw new Error(
|
elements: ExcalidrawElement[],
|
||||||
"insertElementAtIndex can only be called with index >= 0",
|
/** null indicates end of the array */
|
||||||
);
|
index: number | null,
|
||||||
}
|
) {
|
||||||
|
|
||||||
const nextElements = [
|
|
||||||
...this.elements.slice(0, index),
|
|
||||||
element,
|
|
||||||
...this.elements.slice(index),
|
|
||||||
];
|
|
||||||
|
|
||||||
syncMovedIndices(nextElements, arrayToMap([element]));
|
|
||||||
|
|
||||||
this.replaceAllElements(nextElements);
|
|
||||||
}
|
|
||||||
|
|
||||||
insertElementsAtIndex(elements: ExcalidrawElement[], index: number) {
|
|
||||||
if (!elements.length) {
|
if (!elements.length) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (index === null) {
|
||||||
|
index = this.elements.length;
|
||||||
|
}
|
||||||
|
|
||||||
if (!Number.isFinite(index) || index < 0) {
|
if (!Number.isFinite(index) || index < 0) {
|
||||||
throw new Error(
|
throw new Error(
|
||||||
"insertElementAtIndex can only be called with index >= 0",
|
"insertElementAtIndex can only be called with index >= 0",
|
||||||
@@ -378,24 +369,9 @@ export class Scene {
|
|||||||
this.replaceAllElements(nextElements);
|
this.replaceAllElements(nextElements);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** low-level - generally use app.insertNewElement() */
|
||||||
insertElement = (element: ExcalidrawElement) => {
|
insertElement = (element: ExcalidrawElement) => {
|
||||||
const index = element.frameId
|
this.insertElementsAtIndex([element], null);
|
||||||
? this.getElementIndex(element.frameId)
|
|
||||||
: this.elements.length;
|
|
||||||
|
|
||||||
this.insertElementAtIndex(element, index);
|
|
||||||
};
|
|
||||||
|
|
||||||
insertElements = (elements: ExcalidrawElement[]) => {
|
|
||||||
if (!elements.length) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const index = elements[0]?.frameId
|
|
||||||
? this.getElementIndex(elements[0].frameId)
|
|
||||||
: this.elements.length;
|
|
||||||
|
|
||||||
this.insertElementsAtIndex(elements, index);
|
|
||||||
};
|
};
|
||||||
|
|
||||||
getElementIndex(elementId: string) {
|
getElementIndex(elementId: string) {
|
||||||
|
|||||||
@@ -0,0 +1,32 @@
|
|||||||
|
import type { Arrowhead, AnyArrowhead } from "./types";
|
||||||
|
|
||||||
|
export const normalizeArrowhead = (
|
||||||
|
arrowhead: AnyArrowhead | null | undefined,
|
||||||
|
): Arrowhead | null => {
|
||||||
|
switch (arrowhead) {
|
||||||
|
case undefined:
|
||||||
|
case null:
|
||||||
|
return null;
|
||||||
|
case "dot":
|
||||||
|
return "circle";
|
||||||
|
case "crowfoot_one":
|
||||||
|
return "cardinality_one";
|
||||||
|
case "crowfoot_many":
|
||||||
|
return "cardinality_many";
|
||||||
|
case "crowfoot_one_or_many":
|
||||||
|
return "cardinality_one_or_many";
|
||||||
|
default:
|
||||||
|
return arrowhead;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
export const getArrowheadForPicker = (
|
||||||
|
arrowhead: AnyArrowhead | null | undefined,
|
||||||
|
): Arrowhead | null => {
|
||||||
|
const normalizedArrowhead = normalizeArrowhead(arrowhead);
|
||||||
|
if (normalizedArrowhead === null) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
return normalizedArrowhead;
|
||||||
|
};
|
||||||
@@ -734,12 +734,11 @@ const getBindingStrategyForDraggingBindingElementEndpoints_simple = (
|
|||||||
});
|
});
|
||||||
|
|
||||||
// Handle outside-outside binding to the same element
|
// Handle outside-outside binding to the same element
|
||||||
if (otherBinding && otherBinding.elementId === hit?.id) {
|
if (
|
||||||
invariant(
|
otherBinding &&
|
||||||
!opts?.newArrow || appState.selectedLinearElement?.initialState.origin,
|
otherBinding.elementId === hit?.id &&
|
||||||
"appState.selectedLinearElement.initialState.origin must be defined for new arrows",
|
(!opts?.newArrow || appState.selectedLinearElement?.initialState.origin)
|
||||||
);
|
) {
|
||||||
|
|
||||||
return {
|
return {
|
||||||
start: {
|
start: {
|
||||||
mode: "inside",
|
mode: "inside",
|
||||||
@@ -1943,9 +1942,9 @@ export const calculateFixedPointForElbowArrowBinding = (
|
|||||||
return {
|
return {
|
||||||
fixedPoint: normalizeFixedPoint([
|
fixedPoint: normalizeFixedPoint([
|
||||||
(nonRotatedSnappedGlobalPoint[0] - hoveredElement.x) /
|
(nonRotatedSnappedGlobalPoint[0] - hoveredElement.x) /
|
||||||
hoveredElement.width,
|
Math.max(hoveredElement.width, PRECISION),
|
||||||
(nonRotatedSnappedGlobalPoint[1] - hoveredElement.y) /
|
(nonRotatedSnappedGlobalPoint[1] - hoveredElement.y) /
|
||||||
hoveredElement.height,
|
Math.max(hoveredElement.height, PRECISION),
|
||||||
]),
|
]),
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
@@ -1976,9 +1975,11 @@ export const calculateFixedPointForNonElbowArrowBinding = (
|
|||||||
|
|
||||||
// Calculate the ratio relative to the element's bounds
|
// Calculate the ratio relative to the element's bounds
|
||||||
const fixedPointX =
|
const fixedPointX =
|
||||||
(nonRotatedPoint[0] - hoveredElement.x) / hoveredElement.width;
|
(nonRotatedPoint[0] - hoveredElement.x) /
|
||||||
|
Math.max(hoveredElement.width, PRECISION);
|
||||||
const fixedPointY =
|
const fixedPointY =
|
||||||
(nonRotatedPoint[1] - hoveredElement.y) / hoveredElement.height;
|
(nonRotatedPoint[1] - hoveredElement.y) /
|
||||||
|
Math.max(hoveredElement.height, PRECISION);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
fixedPoint: normalizeFixedPoint([fixedPointX, fixedPointY]),
|
fixedPoint: normalizeFixedPoint([fixedPointX, fixedPointY]),
|
||||||
|
|||||||
@@ -680,8 +680,9 @@ export const getMinMaxXYFromCurvePathOps = (
|
|||||||
return [minX, minY, maxX, maxY];
|
return [minX, minY, maxX, maxY];
|
||||||
};
|
};
|
||||||
|
|
||||||
export const getBoundsFromPoints = (
|
export const getBoundsFromPoints = <P extends GlobalPoint | LocalPoint>(
|
||||||
points: ExcalidrawFreeDrawElement["points"],
|
points: readonly P[],
|
||||||
|
padding: number = 0,
|
||||||
): Bounds => {
|
): Bounds => {
|
||||||
let minX = Infinity;
|
let minX = Infinity;
|
||||||
let minY = Infinity;
|
let minY = Infinity;
|
||||||
@@ -695,7 +696,7 @@ export const getBoundsFromPoints = (
|
|||||||
maxY = Math.max(maxY, y);
|
maxY = Math.max(maxY, y);
|
||||||
}
|
}
|
||||||
|
|
||||||
return [minX, minY, maxX, maxY];
|
return [minX - padding, minY - padding, maxX + padding, maxY + padding];
|
||||||
};
|
};
|
||||||
|
|
||||||
const getFreeDrawElementAbsoluteCoords = (
|
const getFreeDrawElementAbsoluteCoords = (
|
||||||
@@ -709,6 +710,9 @@ const getFreeDrawElementAbsoluteCoords = (
|
|||||||
return [x1, y1, x2, y2, (x1 + x2) / 2, (y1 + y2) / 2];
|
return [x1, y1, x2, y2, (x1 + x2) / 2, (y1 + y2) / 2];
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const CARDINALITY_MARKER_SIZE = 20;
|
||||||
|
const CROWFOOT_ARROWHEAD_SIZE = 15;
|
||||||
|
|
||||||
/** @returns number in pixels */
|
/** @returns number in pixels */
|
||||||
export const getArrowheadSize = (arrowhead: Arrowhead): number => {
|
export const getArrowheadSize = (arrowhead: Arrowhead): number => {
|
||||||
switch (arrowhead) {
|
switch (arrowhead) {
|
||||||
@@ -717,10 +721,14 @@ export const getArrowheadSize = (arrowhead: Arrowhead): number => {
|
|||||||
case "diamond":
|
case "diamond":
|
||||||
case "diamond_outline":
|
case "diamond_outline":
|
||||||
return 12;
|
return 12;
|
||||||
case "crowfoot_many":
|
case "cardinality_many":
|
||||||
case "crowfoot_one":
|
case "cardinality_one_or_many":
|
||||||
case "crowfoot_one_or_many":
|
case "cardinality_zero_or_many":
|
||||||
return 20;
|
return CROWFOOT_ARROWHEAD_SIZE;
|
||||||
|
case "cardinality_one":
|
||||||
|
case "cardinality_exactly_one":
|
||||||
|
case "cardinality_zero_or_one":
|
||||||
|
return CARDINALITY_MARKER_SIZE;
|
||||||
default:
|
default:
|
||||||
return 15;
|
return 15;
|
||||||
}
|
}
|
||||||
@@ -743,7 +751,12 @@ export const getArrowheadPoints = (
|
|||||||
shape: Drawable[],
|
shape: Drawable[],
|
||||||
position: "start" | "end",
|
position: "start" | "end",
|
||||||
arrowhead: Arrowhead,
|
arrowhead: Arrowhead,
|
||||||
|
offsetMultiplier = 0,
|
||||||
) => {
|
) => {
|
||||||
|
if (arrowhead === null) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
if (shape.length < 1) {
|
if (shape.length < 1) {
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
@@ -824,29 +837,30 @@ export const getArrowheadPoints = (
|
|||||||
const lengthMultiplier =
|
const lengthMultiplier =
|
||||||
arrowhead === "diamond" || arrowhead === "diamond_outline" ? 0.25 : 0.5;
|
arrowhead === "diamond" || arrowhead === "diamond_outline" ? 0.25 : 0.5;
|
||||||
const minSize = Math.min(size, length * lengthMultiplier);
|
const minSize = Math.min(size, length * lengthMultiplier);
|
||||||
const xs = x2 - nx * minSize;
|
const tx = x2 - nx * minSize * offsetMultiplier;
|
||||||
const ys = y2 - ny * minSize;
|
const ty = y2 - ny * minSize * offsetMultiplier;
|
||||||
|
const xs = tx - nx * minSize;
|
||||||
|
const ys = ty - ny * minSize;
|
||||||
|
|
||||||
if (
|
if (arrowhead === "circle" || arrowhead === "circle_outline") {
|
||||||
arrowhead === "dot" ||
|
const diameter = Math.hypot(ys - ty, xs - tx) + element.strokeWidth - 2;
|
||||||
arrowhead === "circle" ||
|
return [tx, ty, diameter];
|
||||||
arrowhead === "circle_outline"
|
|
||||||
) {
|
|
||||||
const diameter = Math.hypot(ys - y2, xs - x2) + element.strokeWidth - 2;
|
|
||||||
return [x2, y2, diameter];
|
|
||||||
}
|
}
|
||||||
|
|
||||||
const angle = getArrowheadAngle(arrowhead);
|
const angle = getArrowheadAngle(arrowhead);
|
||||||
|
|
||||||
if (arrowhead === "crowfoot_many" || arrowhead === "crowfoot_one_or_many") {
|
if (
|
||||||
|
arrowhead === "cardinality_many" ||
|
||||||
|
arrowhead === "cardinality_one_or_many"
|
||||||
|
) {
|
||||||
// swap (xs, ys) with (x2, y2)
|
// swap (xs, ys) with (x2, y2)
|
||||||
const [x3, y3] = pointRotateRads(
|
const [x3, y3] = pointRotateRads(
|
||||||
pointFrom(x2, y2),
|
pointFrom(tx, ty),
|
||||||
pointFrom(xs, ys),
|
pointFrom(xs, ys),
|
||||||
degreesToRadians(-angle as Degrees),
|
degreesToRadians(-angle as Degrees),
|
||||||
);
|
);
|
||||||
const [x4, y4] = pointRotateRads(
|
const [x4, y4] = pointRotateRads(
|
||||||
pointFrom(x2, y2),
|
pointFrom(tx, ty),
|
||||||
pointFrom(xs, ys),
|
pointFrom(xs, ys),
|
||||||
degreesToRadians(angle),
|
degreesToRadians(angle),
|
||||||
);
|
);
|
||||||
@@ -856,12 +870,12 @@ export const getArrowheadPoints = (
|
|||||||
// Return points
|
// Return points
|
||||||
const [x3, y3] = pointRotateRads(
|
const [x3, y3] = pointRotateRads(
|
||||||
pointFrom(xs, ys),
|
pointFrom(xs, ys),
|
||||||
pointFrom(x2, y2),
|
pointFrom(tx, ty),
|
||||||
((-angle * Math.PI) / 180) as Radians,
|
((-angle * Math.PI) / 180) as Radians,
|
||||||
);
|
);
|
||||||
const [x4, y4] = pointRotateRads(
|
const [x4, y4] = pointRotateRads(
|
||||||
pointFrom(xs, ys),
|
pointFrom(xs, ys),
|
||||||
pointFrom(x2, y2),
|
pointFrom(tx, ty),
|
||||||
degreesToRadians(angle),
|
degreesToRadians(angle),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -874,9 +888,9 @@ export const getArrowheadPoints = (
|
|||||||
const [px, py] = element.points.length > 1 ? element.points[1] : [0, 0];
|
const [px, py] = element.points.length > 1 ? element.points[1] : [0, 0];
|
||||||
|
|
||||||
[ox, oy] = pointRotateRads(
|
[ox, oy] = pointRotateRads(
|
||||||
pointFrom(x2 + minSize * 2, y2),
|
pointFrom(tx + minSize * 2, ty),
|
||||||
pointFrom(x2, y2),
|
pointFrom(tx, ty),
|
||||||
Math.atan2(py - y2, px - x2) as Radians,
|
Math.atan2(py - ty, px - tx) as Radians,
|
||||||
);
|
);
|
||||||
} else {
|
} else {
|
||||||
const [px, py] =
|
const [px, py] =
|
||||||
@@ -885,16 +899,16 @@ export const getArrowheadPoints = (
|
|||||||
: [0, 0];
|
: [0, 0];
|
||||||
|
|
||||||
[ox, oy] = pointRotateRads(
|
[ox, oy] = pointRotateRads(
|
||||||
pointFrom(x2 - minSize * 2, y2),
|
pointFrom(tx - minSize * 2, ty),
|
||||||
pointFrom(x2, y2),
|
pointFrom(tx, ty),
|
||||||
Math.atan2(y2 - py, x2 - px) as Radians,
|
Math.atan2(ty - py, tx - px) as Radians,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
return [x2, y2, x3, y3, ox, oy, x4, y4];
|
return [tx, ty, x3, y3, ox, oy, x4, y4];
|
||||||
}
|
}
|
||||||
|
|
||||||
return [x2, y2, x3, y3, x4, y4];
|
return [tx, ty, x3, y3, x4, y4];
|
||||||
};
|
};
|
||||||
|
|
||||||
// TODO reuse shape.ts
|
// TODO reuse shape.ts
|
||||||
@@ -1248,6 +1262,17 @@ export const pointInsideBounds = <P extends GlobalPoint | LocalPoint>(
|
|||||||
): boolean =>
|
): boolean =>
|
||||||
p[0] > bounds[0] && p[0] < bounds[2] && p[1] > bounds[1] && p[1] < bounds[3];
|
p[0] > bounds[0] && p[0] < bounds[2] && p[1] > bounds[1] && p[1] < bounds[3];
|
||||||
|
|
||||||
|
// TODO make pointInsideBounds inclusive and remove this function once we
|
||||||
|
// test nothing is breaking
|
||||||
|
export const pointInsideBoundsInclusive = <P extends GlobalPoint | LocalPoint>(
|
||||||
|
p: P,
|
||||||
|
bounds: Bounds,
|
||||||
|
): boolean =>
|
||||||
|
p[0] >= bounds[0] &&
|
||||||
|
p[0] <= bounds[2] &&
|
||||||
|
p[1] >= bounds[1] &&
|
||||||
|
p[1] <= bounds[3];
|
||||||
|
|
||||||
export const doBoundsIntersect = (
|
export const doBoundsIntersect = (
|
||||||
bounds1: Bounds | null,
|
bounds1: Bounds | null,
|
||||||
bounds2: Bounds | null,
|
bounds2: Bounds | null,
|
||||||
@@ -1262,13 +1287,21 @@ export const doBoundsIntersect = (
|
|||||||
return minX1 < maxX2 && maxX1 > minX2 && minY1 < maxY2 && maxY1 > minY2;
|
return minX1 < maxX2 && maxX1 > minX2 && minY1 < maxY2 && maxY1 > minY2;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const boundsContainBounds = (outerBounds: Bounds, innerBounds: Bounds) =>
|
||||||
|
[
|
||||||
|
pointFrom<GlobalPoint>(innerBounds[0], innerBounds[1]),
|
||||||
|
pointFrom<GlobalPoint>(innerBounds[0], innerBounds[3]),
|
||||||
|
pointFrom<GlobalPoint>(innerBounds[2], innerBounds[1]),
|
||||||
|
pointFrom<GlobalPoint>(innerBounds[2], innerBounds[3]),
|
||||||
|
].every((point) => pointInsideBoundsInclusive(point, outerBounds));
|
||||||
|
|
||||||
export const elementCenterPoint = (
|
export const elementCenterPoint = (
|
||||||
element: ExcalidrawElement,
|
element: ExcalidrawElement,
|
||||||
elementsMap: ElementsMap,
|
elementsMap: ElementsMap,
|
||||||
xOffset: number = 0,
|
xOffset: number = 0,
|
||||||
yOffset: number = 0,
|
yOffset: number = 0,
|
||||||
) => {
|
) => {
|
||||||
if (isLinearElement(element)) {
|
if (isLinearElement(element) || isFreeDrawElement(element)) {
|
||||||
const [x1, y1, x2, y2] = getElementAbsoluteCoords(element, elementsMap);
|
const [x1, y1, x2, y2] = getElementAbsoluteCoords(element, elementsMap);
|
||||||
const [x, y] = pointFrom<GlobalPoint>((x1 + x2) / 2, (y1 + y2) / 2);
|
const [x, y] = pointFrom<GlobalPoint>((x1 + x2) / 2, (y1 + y2) / 2);
|
||||||
|
|
||||||
|
|||||||
@@ -61,6 +61,8 @@ import { distanceToElement } from "./distance";
|
|||||||
|
|
||||||
import { getBindingGap } from "./binding";
|
import { getBindingGap } from "./binding";
|
||||||
|
|
||||||
|
import { hasBackground } from "./comparisons";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
ElementsMap,
|
ElementsMap,
|
||||||
ExcalidrawArrowElement,
|
ExcalidrawArrowElement,
|
||||||
@@ -83,7 +85,7 @@ export const shouldTestInside = (element: ExcalidrawElement) => {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const isDraggableFromInside =
|
const isDraggableFromInside =
|
||||||
!isTransparent(element.backgroundColor) ||
|
(hasBackground(element.type) && !isTransparent(element.backgroundColor)) ||
|
||||||
hasBoundTextElement(element) ||
|
hasBoundTextElement(element) ||
|
||||||
isIframeLikeElement(element) ||
|
isIframeLikeElement(element) ||
|
||||||
isTextElement(element);
|
isTextElement(element);
|
||||||
@@ -154,14 +156,11 @@ export const hitElementItself = ({
|
|||||||
|
|
||||||
// Hit test against the extended, rotated bounding box of the element first
|
// Hit test against the extended, rotated bounding box of the element first
|
||||||
const bounds = getElementBounds(element, elementsMap, true);
|
const bounds = getElementBounds(element, elementsMap, true);
|
||||||
const hitBounds = isPointWithinBounds(
|
const hitBounds = isPointInRotatedBounds(
|
||||||
pointFrom(bounds[0] - threshold, bounds[1] - threshold),
|
point,
|
||||||
pointRotateRads(
|
bounds,
|
||||||
point,
|
element.angle,
|
||||||
getCenterForBounds(bounds),
|
threshold,
|
||||||
-element.angle as Radians,
|
|
||||||
),
|
|
||||||
pointFrom(bounds[2] + threshold, bounds[3] + threshold),
|
|
||||||
);
|
);
|
||||||
|
|
||||||
// PERF: Bail out early if the point is not even in the
|
// PERF: Bail out early if the point is not even in the
|
||||||
@@ -192,18 +191,32 @@ export const hitElementItself = ({
|
|||||||
return result;
|
return result;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const isPointInRotatedBounds = (
|
||||||
|
point: GlobalPoint,
|
||||||
|
bounds: Bounds,
|
||||||
|
angle: Radians,
|
||||||
|
tolerance = 0,
|
||||||
|
) => {
|
||||||
|
const adjustedPoint =
|
||||||
|
angle === 0
|
||||||
|
? point
|
||||||
|
: pointRotateRads(point, getCenterForBounds(bounds), -angle as Radians);
|
||||||
|
|
||||||
|
return isPointWithinBounds(
|
||||||
|
pointFrom(bounds[0] - tolerance, bounds[1] - tolerance),
|
||||||
|
adjustedPoint,
|
||||||
|
pointFrom(bounds[2] + tolerance, bounds[3] + tolerance),
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
export const hitElementBoundingBox = (
|
export const hitElementBoundingBox = (
|
||||||
point: GlobalPoint,
|
point: GlobalPoint,
|
||||||
element: ExcalidrawElement,
|
element: ExcalidrawElement,
|
||||||
elementsMap: ElementsMap,
|
elementsMap: ElementsMap,
|
||||||
tolerance = 0,
|
tolerance = 0,
|
||||||
) => {
|
) => {
|
||||||
let [x1, y1, x2, y2] = getElementBounds(element, elementsMap);
|
const bounds = getElementBounds(element, elementsMap, true);
|
||||||
x1 -= tolerance;
|
return isPointInRotatedBounds(point, bounds, element.angle, tolerance);
|
||||||
y1 -= tolerance;
|
|
||||||
x2 += tolerance;
|
|
||||||
y2 += tolerance;
|
|
||||||
return isPointWithinBounds(pointFrom(x1, y1), point, pointFrom(x2, y2));
|
|
||||||
};
|
};
|
||||||
|
|
||||||
export const hitElementBoundingBoxOnly = (
|
export const hitElementBoundingBoxOnly = (
|
||||||
@@ -313,7 +326,10 @@ export const getAllHoveredElementAtPoint = (
|
|||||||
) {
|
) {
|
||||||
candidateElements.push(element);
|
candidateElements.push(element);
|
||||||
|
|
||||||
if (!isTransparent(element.backgroundColor)) {
|
if (
|
||||||
|
hasBackground(element.type) &&
|
||||||
|
!isTransparent(element.backgroundColor)
|
||||||
|
) {
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -465,7 +481,12 @@ export const intersectElementWithLineSegment = (
|
|||||||
case "line":
|
case "line":
|
||||||
case "freedraw":
|
case "freedraw":
|
||||||
case "arrow":
|
case "arrow":
|
||||||
return intersectLinearOrFreeDrawWithLineSegment(element, line, onlyFirst);
|
return intersectLinearOrFreeDrawWithLineSegment(
|
||||||
|
element,
|
||||||
|
line,
|
||||||
|
elementsMap,
|
||||||
|
onlyFirst,
|
||||||
|
);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -532,11 +553,15 @@ const lineIntersections = (
|
|||||||
const intersectLinearOrFreeDrawWithLineSegment = (
|
const intersectLinearOrFreeDrawWithLineSegment = (
|
||||||
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
||||||
segment: LineSegment<GlobalPoint>,
|
segment: LineSegment<GlobalPoint>,
|
||||||
|
elementsMap: ElementsMap,
|
||||||
onlyFirst = false,
|
onlyFirst = false,
|
||||||
): GlobalPoint[] => {
|
): GlobalPoint[] => {
|
||||||
// NOTE: This is the only one which return the decomposed elements
|
// NOTE: This is the only one which return the decomposed elements
|
||||||
// rotated! This is due to taking advantage of roughjs definitions.
|
// rotated! This is due to taking advantage of roughjs definitions.
|
||||||
const [lines, curves] = deconstructLinearOrFreeDrawElement(element);
|
const [lines, curves] = deconstructLinearOrFreeDrawElement(
|
||||||
|
element,
|
||||||
|
elementsMap,
|
||||||
|
);
|
||||||
const intersections: GlobalPoint[] = [];
|
const intersections: GlobalPoint[] = [];
|
||||||
|
|
||||||
for (const l of lines) {
|
for (const l of lines) {
|
||||||
@@ -564,7 +589,9 @@ const intersectLinearOrFreeDrawWithLineSegment = (
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
const hits = curveIntersectLineSegment(c, segment);
|
const hits = curveIntersectLineSegment(c, segment, {
|
||||||
|
iterLimit: 10,
|
||||||
|
});
|
||||||
|
|
||||||
if (hits.length > 0) {
|
if (hits.length > 0) {
|
||||||
intersections.push(...hits);
|
intersections.push(...hits);
|
||||||
|
|||||||
@@ -48,7 +48,7 @@ export const distanceToElement = (
|
|||||||
case "line":
|
case "line":
|
||||||
case "arrow":
|
case "arrow":
|
||||||
case "freedraw":
|
case "freedraw":
|
||||||
return distanceToLinearOrFreeDraElement(element, p);
|
return distanceToLinearOrFreeDraElement(element, elementsMap, p);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -133,9 +133,13 @@ const distanceToEllipseElement = (
|
|||||||
|
|
||||||
const distanceToLinearOrFreeDraElement = (
|
const distanceToLinearOrFreeDraElement = (
|
||||||
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
||||||
|
elementsMap: ElementsMap,
|
||||||
p: GlobalPoint,
|
p: GlobalPoint,
|
||||||
) => {
|
) => {
|
||||||
const [lines, curves] = deconstructLinearOrFreeDrawElement(element);
|
const [lines, curves] = deconstructLinearOrFreeDrawElement(
|
||||||
|
element,
|
||||||
|
elementsMap,
|
||||||
|
);
|
||||||
return Math.min(
|
return Math.min(
|
||||||
...lines.map((s) => distanceToLineSegment(p, s)),
|
...lines.map((s) => distanceToLineSegment(p, s)),
|
||||||
...curves.map((a) => curvePointDistance(a, p)),
|
...curves.map((a) => curvePointDistance(a, p)),
|
||||||
|
|||||||
@@ -111,6 +111,9 @@ export const duplicateElements = (
|
|||||||
* user interaction.
|
* user interaction.
|
||||||
*/
|
*/
|
||||||
type: "everything";
|
type: "everything";
|
||||||
|
// TODO remove/review this once we add frame children order migration
|
||||||
|
// and invariant checks
|
||||||
|
preserveFrameChildrenOrder?: boolean;
|
||||||
}
|
}
|
||||||
| {
|
| {
|
||||||
/**
|
/**
|
||||||
@@ -170,6 +173,8 @@ export const duplicateElements = (
|
|||||||
opts.type === "in-place"
|
opts.type === "in-place"
|
||||||
? opts.idsOfElementsToDuplicate
|
? opts.idsOfElementsToDuplicate
|
||||||
: new Map(elements.map((el) => [el.id, el]));
|
: new Map(elements.map((el) => [el.id, el]));
|
||||||
|
const preserveFrameChildrenOrder =
|
||||||
|
opts.type === "everything" && opts.preserveFrameChildrenOrder;
|
||||||
|
|
||||||
// For sanity
|
// For sanity
|
||||||
if (opts.type === "in-place") {
|
if (opts.type === "in-place") {
|
||||||
@@ -250,6 +255,9 @@ export const duplicateElements = (
|
|||||||
elementsWithDuplicates.splice(index + 1, 0, ...castArray(elements));
|
elementsWithDuplicates.splice(index + 1, 0, ...castArray(elements));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// main
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
const frameIdsToDuplicate = new Set(
|
const frameIdsToDuplicate = new Set(
|
||||||
elements
|
elements
|
||||||
.filter(
|
.filter(
|
||||||
@@ -274,7 +282,7 @@ export const duplicateElements = (
|
|||||||
if (groupId) {
|
if (groupId) {
|
||||||
const groupElements = getElementsInGroup(elements, groupId).flatMap(
|
const groupElements = getElementsInGroup(elements, groupId).flatMap(
|
||||||
(element) =>
|
(element) =>
|
||||||
isFrameLikeElement(element)
|
isFrameLikeElement(element) && !preserveFrameChildrenOrder
|
||||||
? [...getFrameChildren(elements, element.id), element]
|
? [...getFrameChildren(elements, element.id), element]
|
||||||
: [element],
|
: [element],
|
||||||
);
|
);
|
||||||
@@ -290,13 +298,25 @@ export const duplicateElements = (
|
|||||||
// frame duplication
|
// frame duplication
|
||||||
// -------------------------------------------------------------------------
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
if (element.frameId && frameIdsToDuplicate.has(element.frameId)) {
|
if (
|
||||||
|
!preserveFrameChildrenOrder &&
|
||||||
|
element.frameId &&
|
||||||
|
frameIdsToDuplicate.has(element.frameId)
|
||||||
|
) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (isFrameLikeElement(element)) {
|
if (isFrameLikeElement(element)) {
|
||||||
const frameId = element.id;
|
const frameId = element.id;
|
||||||
|
|
||||||
|
if (preserveFrameChildrenOrder) {
|
||||||
|
insertBeforeOrAfterIndex(
|
||||||
|
findLastIndex(elementsWithDuplicates, (el) => el.id === frameId),
|
||||||
|
copyElements(element),
|
||||||
|
);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
const frameChildren = getFrameChildren(elements, frameId);
|
const frameChildren = getFrameChildren(elements, frameId);
|
||||||
|
|
||||||
const targetIndex = findLastIndex(elementsWithDuplicates, (el) => {
|
const targetIndex = findLastIndex(elementsWithDuplicates, (el) => {
|
||||||
|
|||||||
@@ -2124,8 +2124,8 @@ const normalizeArrowElementUpdate = (
|
|||||||
offsetY < -MAX_POS ||
|
offsetY < -MAX_POS ||
|
||||||
offsetY > MAX_POS ||
|
offsetY > MAX_POS ||
|
||||||
offsetX + points[points.length - 1][0] < -MAX_POS ||
|
offsetX + points[points.length - 1][0] < -MAX_POS ||
|
||||||
offsetY + points[points.length - 1][0] > MAX_POS ||
|
offsetX + points[points.length - 1][0] > MAX_POS ||
|
||||||
offsetX + points[points.length - 1][1] < -MAX_POS ||
|
offsetY + points[points.length - 1][1] < -MAX_POS ||
|
||||||
offsetY + points[points.length - 1][1] > MAX_POS
|
offsetY + points[points.length - 1][1] > MAX_POS
|
||||||
) {
|
) {
|
||||||
console.error(
|
console.error(
|
||||||
|
|||||||
@@ -1,7 +1,10 @@
|
|||||||
import { generateNKeysBetween } from "fractional-indexing";
|
|
||||||
|
|
||||||
import { arrayToMap } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
|
import {
|
||||||
|
validateOrderKey,
|
||||||
|
generateNKeysBetween,
|
||||||
|
} from "@excalidraw/fractional-indexing";
|
||||||
|
|
||||||
import { mutateElement, newElementWith } from "./mutateElement";
|
import { mutateElement, newElementWith } from "./mutateElement";
|
||||||
import { getBoundTextElement } from "./textElement";
|
import { getBoundTextElement } from "./textElement";
|
||||||
import { hasBoundTextElement } from "./typeChecks";
|
import { hasBoundTextElement } from "./typeChecks";
|
||||||
@@ -382,6 +385,13 @@ const isValidFractionalIndex = (
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
try {
|
||||||
|
// Format validation
|
||||||
|
validateOrderKey(index);
|
||||||
|
} catch {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
if (predecessor && successor) {
|
if (predecessor && successor) {
|
||||||
return predecessor < index && index < successor;
|
return predecessor < index && index < successor;
|
||||||
}
|
}
|
||||||
|
|||||||
+108
-48
@@ -1,7 +1,6 @@
|
|||||||
import { arrayToMap } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
import { isPointWithinBounds, pointFrom } from "@excalidraw/math";
|
import { isPointWithinBounds, pointFrom } from "@excalidraw/math";
|
||||||
import { doLineSegmentsIntersect } from "@excalidraw/utils/bbox";
|
import { doLineSegmentsIntersect } from "@excalidraw/utils/bbox";
|
||||||
import { elementsOverlappingBBox } from "@excalidraw/utils/withinBounds";
|
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
AppClassProperties,
|
AppClassProperties,
|
||||||
@@ -18,9 +17,13 @@ import {
|
|||||||
getElementLineSegments,
|
getElementLineSegments,
|
||||||
getCommonBounds,
|
getCommonBounds,
|
||||||
getElementAbsoluteCoords,
|
getElementAbsoluteCoords,
|
||||||
|
doBoundsIntersect,
|
||||||
|
getElementBounds,
|
||||||
|
boundsContainBounds,
|
||||||
} from "./bounds";
|
} from "./bounds";
|
||||||
import { mutateElement } from "./mutateElement";
|
import { mutateElement } from "./mutateElement";
|
||||||
import { getBoundTextElement, getContainerElement } from "./textElement";
|
import { getBoundTextElement, getContainerElement } from "./textElement";
|
||||||
|
import { syncMovedIndices } from "./fractionalIndex";
|
||||||
import {
|
import {
|
||||||
isFrameElement,
|
isFrameElement,
|
||||||
isFrameLikeElement,
|
isFrameLikeElement,
|
||||||
@@ -100,8 +103,9 @@ export const isElementContainingFrame = (
|
|||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
elementsMap: ElementsMap,
|
elementsMap: ElementsMap,
|
||||||
) => {
|
) => {
|
||||||
return getElementsWithinSelection([frame], element, elementsMap).some(
|
return boundsContainBounds(
|
||||||
(e) => e.id === frame.id,
|
getElementBounds(element, elementsMap),
|
||||||
|
getElementBounds(frame, elementsMap),
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -488,10 +492,44 @@ export const filterElementsEligibleAsFrameChildren = (
|
|||||||
return eligibleElements;
|
return eligibleElements;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const getCommonFrameId = (elements: readonly ExcalidrawElement[]) => {
|
||||||
|
let commonFrameId: ExcalidrawElement["frameId"] | undefined;
|
||||||
|
|
||||||
|
for (const element of elements) {
|
||||||
|
if (isFrameLikeElement(element) || !element.frameId) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (commonFrameId === undefined) {
|
||||||
|
commonFrameId = element.frameId;
|
||||||
|
} else if (commonFrameId !== element.frameId) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return commonFrameId ?? null;
|
||||||
|
};
|
||||||
|
|
||||||
|
export const getFrameChildrenInsertionIndex = (
|
||||||
|
elements: readonly ExcalidrawElement[],
|
||||||
|
frameId: ExcalidrawFrameLikeElement["id"],
|
||||||
|
): number | null => {
|
||||||
|
for (let index = elements.length - 1; index >= 0; index--) {
|
||||||
|
const element = elements[index];
|
||||||
|
|
||||||
|
if (element.id === frameId) {
|
||||||
|
return index;
|
||||||
|
} else if (element.frameId === frameId) {
|
||||||
|
return index + 1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Retains (or repairs for target frame) the ordering invriant where children
|
* Adds elements and their bound elements to frame. Reorders added elements to
|
||||||
* elements come right before the parent frame:
|
* be just below frame, or just above its highest child (whichever is higher).
|
||||||
* [el, el, child, child, frame, el]
|
|
||||||
*
|
*
|
||||||
* @returns mutated allElements (same data structure)
|
* @returns mutated allElements (same data structure)
|
||||||
*/
|
*/
|
||||||
@@ -499,19 +537,11 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
|||||||
allElements: T,
|
allElements: T,
|
||||||
elementsToAdd: NonDeletedExcalidrawElement[],
|
elementsToAdd: NonDeletedExcalidrawElement[],
|
||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
appState: AppState,
|
|
||||||
): T => {
|
): T => {
|
||||||
const elementsMap = arrayToMap(allElements);
|
const elementsMap = arrayToMap(allElements);
|
||||||
const currTargetFrameChildrenMap = new Map<ExcalidrawElement["id"], true>();
|
const commonFrameId = getCommonFrameId(elementsToAdd);
|
||||||
for (const element of allElements.values()) {
|
|
||||||
if (element.frameId === frame.id) {
|
|
||||||
currTargetFrameChildrenMap.set(element.id, true);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const suppliedElementsToAddSet = new Set(elementsToAdd.map((el) => el.id));
|
const finalElementsToAdd = new Set<ExcalidrawElement>();
|
||||||
|
|
||||||
const finalElementsToAdd: ExcalidrawElement[] = [];
|
|
||||||
|
|
||||||
const otherFrames = new Set<ExcalidrawFrameLikeElement["id"]>();
|
const otherFrames = new Set<ExcalidrawFrameLikeElement["id"]>();
|
||||||
|
|
||||||
@@ -522,7 +552,8 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
|||||||
}
|
}
|
||||||
|
|
||||||
// - add bound text elements if not already in the array
|
// - add bound text elements if not already in the array
|
||||||
// - filter out elements that are already in the frame
|
// - keep elements already in the frame so mixed selections can be reordered
|
||||||
|
// together
|
||||||
for (const element of omitGroupsContainingFrameLikes(
|
for (const element of omitGroupsContainingFrameLikes(
|
||||||
allElements,
|
allElements,
|
||||||
elementsToAdd,
|
elementsToAdd,
|
||||||
@@ -535,38 +566,68 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// if the element is already in another frame (which is also in elementsToAdd),
|
if (element.frameId && element.frameId !== frame.id) {
|
||||||
// it means that frame and children are selected at the same time
|
|
||||||
// => keep original frame membership, do not add to the target frame
|
|
||||||
if (
|
|
||||||
element.frameId &&
|
|
||||||
appState.selectedElementIds[element.id] &&
|
|
||||||
appState.selectedElementIds[element.frameId]
|
|
||||||
) {
|
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!currTargetFrameChildrenMap.has(element.id)) {
|
finalElementsToAdd.add(element);
|
||||||
finalElementsToAdd.push(element);
|
|
||||||
}
|
|
||||||
|
|
||||||
const boundTextElement = getBoundTextElement(element, elementsMap);
|
const boundTextElement = getBoundTextElement(element, elementsMap);
|
||||||
if (
|
if (boundTextElement && !finalElementsToAdd.has(boundTextElement)) {
|
||||||
boundTextElement &&
|
finalElementsToAdd.add(boundTextElement);
|
||||||
!suppliedElementsToAddSet.has(boundTextElement.id) &&
|
|
||||||
!currTargetFrameChildrenMap.has(boundTextElement.id)
|
|
||||||
) {
|
|
||||||
finalElementsToAdd.push(boundTextElement);
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
for (const element of finalElementsToAdd) {
|
for (const element of finalElementsToAdd) {
|
||||||
mutateElement(element, elementsMap, {
|
// we don't always need to update the element if it's already in the frame,
|
||||||
frameId: frame.id,
|
// but we still need to accumulate in finalElementsToAdd so we potentially
|
||||||
});
|
// reorder them if added together
|
||||||
|
if (element.frameId !== frame.id) {
|
||||||
|
mutateElement(element, elementsMap, {
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return allElements;
|
// (re)order elements to be just below the frame,
|
||||||
|
// or just above the highest child if that is higher
|
||||||
|
// (latter case is denormalized order until we migrate)
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
if (
|
||||||
|
!finalElementsToAdd.size ||
|
||||||
|
// if all elements to add already belong to the frame, then we don't want to
|
||||||
|
// reorder (case: we're dragging element children within the frame)
|
||||||
|
commonFrameId === frame.id
|
||||||
|
) {
|
||||||
|
return allElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
const otherElements = Array.from(allElements.values()).filter(
|
||||||
|
(element) => !finalElementsToAdd.has(element),
|
||||||
|
);
|
||||||
|
const insertionIndex = getFrameChildrenInsertionIndex(
|
||||||
|
otherElements,
|
||||||
|
frame.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (insertionIndex === null) {
|
||||||
|
return allElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
const reorderedElements = [
|
||||||
|
...otherElements.slice(0, insertionIndex),
|
||||||
|
...finalElementsToAdd,
|
||||||
|
...otherElements.slice(insertionIndex),
|
||||||
|
];
|
||||||
|
|
||||||
|
syncMovedIndices(reorderedElements, arrayToMap([...finalElementsToAdd]));
|
||||||
|
|
||||||
|
return (
|
||||||
|
Array.isArray(allElements)
|
||||||
|
? reorderedElements
|
||||||
|
: new Map(reorderedElements.map((element) => [element.id, element]))
|
||||||
|
) as T;
|
||||||
};
|
};
|
||||||
|
|
||||||
export const removeElementsFromFrame = (
|
export const removeElementsFromFrame = (
|
||||||
@@ -620,13 +681,11 @@ export const replaceAllElementsInFrame = <T extends ExcalidrawElement>(
|
|||||||
allElements: readonly T[],
|
allElements: readonly T[],
|
||||||
nextElementsInFrame: ExcalidrawElement[],
|
nextElementsInFrame: ExcalidrawElement[],
|
||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
app: AppClassProperties,
|
|
||||||
): T[] => {
|
): T[] => {
|
||||||
return addElementsToFrame(
|
return addElementsToFrame(
|
||||||
removeAllElementsFromFrame(allElements, frame),
|
removeAllElementsFromFrame(allElements, frame),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
frame,
|
frame,
|
||||||
app.state,
|
|
||||||
).slice();
|
).slice();
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -920,16 +979,17 @@ export const getFrameLikeTitle = (element: ExcalidrawFrameLikeElement) => {
|
|||||||
export const getElementsOverlappingFrame = (
|
export const getElementsOverlappingFrame = (
|
||||||
elements: readonly ExcalidrawElement[],
|
elements: readonly ExcalidrawElement[],
|
||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
|
elementsMap: ElementsMap,
|
||||||
) => {
|
) => {
|
||||||
return (
|
return elements.filter(
|
||||||
elementsOverlappingBBox({
|
(el) =>
|
||||||
elements,
|
// exclude elements which are overlapping, but are in a different frame,
|
||||||
bounds: frame,
|
|
||||||
type: "overlap",
|
|
||||||
})
|
|
||||||
// removes elements who are overlapping, but are in a different frame,
|
|
||||||
// and thus invisible in target frame
|
// and thus invisible in target frame
|
||||||
.filter((el) => !el.frameId || el.frameId === frame.id)
|
(!el.frameId || el.frameId === frame.id) &&
|
||||||
|
doBoundsIntersect(
|
||||||
|
getElementBounds(el, elementsMap),
|
||||||
|
getElementBounds(frame, elementsMap),
|
||||||
|
),
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -99,3 +99,4 @@ export * from "./typeChecks";
|
|||||||
export * from "./utils";
|
export * from "./utils";
|
||||||
export * from "./zindex";
|
export * from "./zindex";
|
||||||
export * from "./arrows/helpers";
|
export * from "./arrows/helpers";
|
||||||
|
export * from "./arrowheads";
|
||||||
|
|||||||
@@ -476,16 +476,22 @@ export class LinearElementEditor {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
invariant(
|
if (
|
||||||
lastClickedPoint > -1 &&
|
lastClickedPoint < 0 ||
|
||||||
selectedPointsIndices.includes(lastClickedPoint) &&
|
!selectedPointsIndices.includes(lastClickedPoint) ||
|
||||||
element.points[lastClickedPoint],
|
!element.points[lastClickedPoint]
|
||||||
`There must be a valid lastClickedPoint in order to drag it. selectedPointsIndices(${JSON.stringify(
|
) {
|
||||||
selectedPointsIndices,
|
console.error(
|
||||||
)}) points(0..${
|
`There must be a valid lastClickedPoint in order to drag it. selectedPointsIndices(${JSON.stringify(
|
||||||
element.points.length - 1
|
selectedPointsIndices,
|
||||||
}) lastClickedPoint(${lastClickedPoint})`,
|
)}) points(0..${
|
||||||
);
|
element.points.length - 1
|
||||||
|
}) lastClickedPoint(${lastClickedPoint}) isElbowArrow: ${elbowed}`,
|
||||||
|
);
|
||||||
|
|
||||||
|
// Fall back to the actual last point as a last resort.
|
||||||
|
lastClickedPoint = element.points.length - 1;
|
||||||
|
}
|
||||||
|
|
||||||
// point that's being dragged (out of all selected points)
|
// point that's being dragged (out of all selected points)
|
||||||
const draggingPoint = element.points[lastClickedPoint];
|
const draggingPoint = element.points[lastClickedPoint];
|
||||||
@@ -794,6 +800,7 @@ export class LinearElementEditor {
|
|||||||
element.points[index + 1],
|
element.points[index + 1],
|
||||||
index,
|
index,
|
||||||
appState.zoom,
|
appState.zoom,
|
||||||
|
elementsMap,
|
||||||
)
|
)
|
||||||
) {
|
) {
|
||||||
midpoints.push(null);
|
midpoints.push(null);
|
||||||
@@ -803,6 +810,7 @@ export class LinearElementEditor {
|
|||||||
const segmentMidPoint = LinearElementEditor.getSegmentMidPoint(
|
const segmentMidPoint = LinearElementEditor.getSegmentMidPoint(
|
||||||
element,
|
element,
|
||||||
index + 1,
|
index + 1,
|
||||||
|
elementsMap,
|
||||||
);
|
);
|
||||||
midpoints.push(segmentMidPoint);
|
midpoints.push(segmentMidPoint);
|
||||||
index++;
|
index++;
|
||||||
@@ -890,6 +898,7 @@ export class LinearElementEditor {
|
|||||||
endPoint: P,
|
endPoint: P,
|
||||||
index: number,
|
index: number,
|
||||||
zoom: Zoom,
|
zoom: Zoom,
|
||||||
|
elementsMap: ElementsMap,
|
||||||
) {
|
) {
|
||||||
if (isElbowArrow(element)) {
|
if (isElbowArrow(element)) {
|
||||||
if (index >= 0 && index < element.points.length) {
|
if (index >= 0 && index < element.points.length) {
|
||||||
@@ -904,7 +913,10 @@ export class LinearElementEditor {
|
|||||||
|
|
||||||
let distance = pointDistance(startPoint, endPoint);
|
let distance = pointDistance(startPoint, endPoint);
|
||||||
if (element.points.length > 2 && element.roundness) {
|
if (element.points.length > 2 && element.roundness) {
|
||||||
const [lines, curves] = deconstructLinearOrFreeDrawElement(element);
|
const [lines, curves] = deconstructLinearOrFreeDrawElement(
|
||||||
|
element,
|
||||||
|
elementsMap,
|
||||||
|
);
|
||||||
|
|
||||||
invariant(
|
invariant(
|
||||||
lines.length === 0 && curves.length > 0,
|
lines.length === 0 && curves.length > 0,
|
||||||
@@ -924,6 +936,7 @@ export class LinearElementEditor {
|
|||||||
static getSegmentMidPoint(
|
static getSegmentMidPoint(
|
||||||
element: NonDeleted<ExcalidrawLinearElement>,
|
element: NonDeleted<ExcalidrawLinearElement>,
|
||||||
index: number,
|
index: number,
|
||||||
|
elementsMap: ElementsMap,
|
||||||
): GlobalPoint {
|
): GlobalPoint {
|
||||||
if (isElbowArrow(element)) {
|
if (isElbowArrow(element)) {
|
||||||
invariant(
|
invariant(
|
||||||
@@ -936,7 +949,10 @@ export class LinearElementEditor {
|
|||||||
return pointFrom<GlobalPoint>(element.x + p[0], element.y + p[1]);
|
return pointFrom<GlobalPoint>(element.x + p[0], element.y + p[1]);
|
||||||
}
|
}
|
||||||
|
|
||||||
const [lines, curves] = deconstructLinearOrFreeDrawElement(element);
|
const [lines, curves] = deconstructLinearOrFreeDrawElement(
|
||||||
|
element,
|
||||||
|
elementsMap,
|
||||||
|
);
|
||||||
|
|
||||||
invariant(
|
invariant(
|
||||||
(lines.length === 0 && curves.length > 0) ||
|
(lines.length === 0 && curves.length > 0) ||
|
||||||
@@ -1851,6 +1867,7 @@ export class LinearElementEditor {
|
|||||||
const midSegmentMidpoint = LinearElementEditor.getSegmentMidPoint(
|
const midSegmentMidpoint = LinearElementEditor.getSegmentMidPoint(
|
||||||
element,
|
element,
|
||||||
index + 1,
|
index + 1,
|
||||||
|
elementsMap,
|
||||||
);
|
);
|
||||||
|
|
||||||
x = midSegmentMidpoint[0] - boundTextElement.width / 2;
|
x = midSegmentMidpoint[0] - boundTextElement.width / 2;
|
||||||
@@ -2122,13 +2139,13 @@ const pointDraggingUpdates = (
|
|||||||
} => {
|
} => {
|
||||||
const naiveDraggingPoints = new Map(
|
const naiveDraggingPoints = new Map(
|
||||||
selectedPointsIndices.map((pointIndex) => {
|
selectedPointsIndices.map((pointIndex) => {
|
||||||
|
// NOTE: Avoid stale point index issue potentially caused by elbow
|
||||||
|
// arrows unpredictably changing the number of points during dragging
|
||||||
|
const point = element.points[pointIndex] ?? element.points.at(-1);
|
||||||
return [
|
return [
|
||||||
pointIndex,
|
pointIndex,
|
||||||
{
|
{
|
||||||
point: pointFrom<LocalPoint>(
|
point: pointFrom<LocalPoint>(point[0] + deltaX, point[1] + deltaY),
|
||||||
element.points[pointIndex][0] + deltaX,
|
|
||||||
element.points[pointIndex][1] + deltaY,
|
|
||||||
),
|
|
||||||
isDragging: true,
|
isDragging: true,
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
@@ -2400,7 +2417,7 @@ const pointDraggingUpdates = (
|
|||||||
? nextArrow.points[0]
|
? nextArrow.points[0]
|
||||||
: endBindable
|
: endBindable
|
||||||
? updateBoundPoint(
|
? updateBoundPoint(
|
||||||
element,
|
nextArrow,
|
||||||
"endBinding",
|
"endBinding",
|
||||||
nextArrow.endBinding,
|
nextArrow.endBinding,
|
||||||
endBindable,
|
endBindable,
|
||||||
@@ -2431,7 +2448,7 @@ const pointDraggingUpdates = (
|
|||||||
? endLocalPoint
|
? endLocalPoint
|
||||||
: startBindable
|
: startBindable
|
||||||
? updateBoundPoint(
|
? updateBoundPoint(
|
||||||
element,
|
nextArrow,
|
||||||
"startBinding",
|
"startBinding",
|
||||||
nextArrow.startBinding,
|
nextArrow.startBinding,
|
||||||
startBindable,
|
startBindable,
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import rough from "roughjs/bin/rough";
|
import rough from "roughjs/bin/rough";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
|
clamp,
|
||||||
type GlobalPoint,
|
type GlobalPoint,
|
||||||
isRightAngleRads,
|
isRightAngleRads,
|
||||||
lineSegment,
|
lineSegment,
|
||||||
@@ -105,8 +106,62 @@ const getCanvasPadding = (element: ExcalidrawElement) => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const resolveRenderOpacity = (
|
||||||
|
element: ExcalidrawElement,
|
||||||
|
renderConfig: Pick<
|
||||||
|
StaticCanvasRenderConfig,
|
||||||
|
"elementOpacityOverrides" | "resolveRenderOpacity"
|
||||||
|
>,
|
||||||
|
) => {
|
||||||
|
const override = renderConfig.elementOpacityOverrides?.get(element.id);
|
||||||
|
|
||||||
|
if (override !== undefined) {
|
||||||
|
return clamp(override, 0, 100);
|
||||||
|
}
|
||||||
|
|
||||||
|
const resolvedOpacity = renderConfig.resolveRenderOpacity?.(
|
||||||
|
element as NonDeletedExcalidrawElement,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (resolvedOpacity !== undefined) {
|
||||||
|
return clamp(resolvedOpacity, 0, 100);
|
||||||
|
}
|
||||||
|
|
||||||
|
return element.opacity;
|
||||||
|
};
|
||||||
|
|
||||||
|
export const resolveRenderPositionOffset = (
|
||||||
|
element: ExcalidrawElement,
|
||||||
|
renderConfig: Pick<StaticCanvasRenderConfig, "elementPositionOverrides">,
|
||||||
|
) => {
|
||||||
|
return renderConfig.elementPositionOverrides?.get(element.id) ?? { x: 0, y: 0 };
|
||||||
|
};
|
||||||
|
|
||||||
|
export const getRenderElementWithPositionOverride = <
|
||||||
|
TElement extends NonDeletedExcalidrawElement,
|
||||||
|
>(
|
||||||
|
element: TElement,
|
||||||
|
renderConfig: Pick<StaticCanvasRenderConfig, "elementPositionOverrides">,
|
||||||
|
): TElement => {
|
||||||
|
const positionOffset = resolveRenderPositionOffset(element, renderConfig);
|
||||||
|
|
||||||
|
if (positionOffset.x === 0 && positionOffset.y === 0) {
|
||||||
|
return element;
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
...element,
|
||||||
|
x: element.x + positionOffset.x,
|
||||||
|
y: element.y + positionOffset.y,
|
||||||
|
} as TElement;
|
||||||
|
};
|
||||||
|
|
||||||
export const getRenderOpacity = (
|
export const getRenderOpacity = (
|
||||||
element: ExcalidrawElement,
|
element: ExcalidrawElement,
|
||||||
|
renderConfig: Pick<
|
||||||
|
StaticCanvasRenderConfig,
|
||||||
|
"elementOpacityOverrides" | "resolveRenderOpacity"
|
||||||
|
>,
|
||||||
containingFrame: ExcalidrawFrameLikeElement | null,
|
containingFrame: ExcalidrawFrameLikeElement | null,
|
||||||
elementsPendingErasure: ElementsPendingErasure,
|
elementsPendingErasure: ElementsPendingErasure,
|
||||||
pendingNodes: Readonly<PendingExcalidrawElements> | null,
|
pendingNodes: Readonly<PendingExcalidrawElements> | null,
|
||||||
@@ -115,7 +170,8 @@ export const getRenderOpacity = (
|
|||||||
// multiplying frame opacity with element opacity to combine them
|
// multiplying frame opacity with element opacity to combine them
|
||||||
// (e.g. frame 50% and element 50% opacity should result in 25% opacity)
|
// (e.g. frame 50% and element 50% opacity should result in 25% opacity)
|
||||||
let opacity =
|
let opacity =
|
||||||
(((containingFrame?.opacity ?? 100) * element.opacity) / 10000) *
|
(((containingFrame?.opacity ?? 100) * resolveRenderOpacity(element, renderConfig)) /
|
||||||
|
10000) *
|
||||||
globalAlpha;
|
globalAlpha;
|
||||||
|
|
||||||
// if pending erasure, multiply again to combine further
|
// if pending erasure, multiply again to combine further
|
||||||
@@ -791,8 +847,11 @@ export const renderElement = (
|
|||||||
!appState.selectedElementIds[element.id] &&
|
!appState.selectedElementIds[element.id] &&
|
||||||
!appState.hoveredElementIds[element.id];
|
!appState.hoveredElementIds[element.id];
|
||||||
|
|
||||||
|
element = getRenderElementWithPositionOverride(element, renderConfig);
|
||||||
|
|
||||||
context.globalAlpha = getRenderOpacity(
|
context.globalAlpha = getRenderOpacity(
|
||||||
element,
|
element,
|
||||||
|
renderConfig,
|
||||||
getContainingFrame(element, elementsMap),
|
getContainingFrame(element, elementsMap),
|
||||||
renderConfig.elementsPendingErasure,
|
renderConfig.elementsPendingErasure,
|
||||||
renderConfig.pendingFlowchartNodes,
|
renderConfig.pendingFlowchartNodes,
|
||||||
|
|||||||
@@ -1,16 +1,34 @@
|
|||||||
import { arrayToMap, isShallowEqual } from "@excalidraw/common";
|
import { arrayToMap, isShallowEqual, type Bounds } from "@excalidraw/common";
|
||||||
|
import {
|
||||||
|
lineSegment,
|
||||||
|
pointFrom,
|
||||||
|
pointRotateRads,
|
||||||
|
type GlobalPoint,
|
||||||
|
} from "@excalidraw/math";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
AppState,
|
AppState,
|
||||||
|
BoxSelectionMode,
|
||||||
InteractiveCanvasAppState,
|
InteractiveCanvasAppState,
|
||||||
} from "@excalidraw/excalidraw/types";
|
} from "@excalidraw/excalidraw/types";
|
||||||
|
|
||||||
import { getElementAbsoluteCoords, getElementBounds } from "./bounds";
|
import {
|
||||||
|
boundsContainBounds,
|
||||||
|
doBoundsIntersect,
|
||||||
|
elementCenterPoint,
|
||||||
|
getElementAbsoluteCoords,
|
||||||
|
getElementBounds,
|
||||||
|
pointInsideBounds,
|
||||||
|
} from "./bounds";
|
||||||
|
import { intersectElementWithLineSegment } from "./collision";
|
||||||
import { isElementInViewport } from "./sizeHelpers";
|
import { isElementInViewport } from "./sizeHelpers";
|
||||||
import {
|
import {
|
||||||
|
isArrowElement,
|
||||||
isBoundToContainer,
|
isBoundToContainer,
|
||||||
isFrameLikeElement,
|
isFrameLikeElement,
|
||||||
|
isFreeDrawElement,
|
||||||
isLinearElement,
|
isLinearElement,
|
||||||
|
isTextElement,
|
||||||
} from "./typeChecks";
|
} from "./typeChecks";
|
||||||
import {
|
import {
|
||||||
elementOverlapsWithFrame,
|
elementOverlapsWithFrame,
|
||||||
@@ -20,14 +38,33 @@ import {
|
|||||||
|
|
||||||
import { LinearElementEditor } from "./linearElementEditor";
|
import { LinearElementEditor } from "./linearElementEditor";
|
||||||
import { selectGroupsForSelectedElements } from "./groups";
|
import { selectGroupsForSelectedElements } from "./groups";
|
||||||
|
import { getBoundTextElement } from "./textElement";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
ElementsMap,
|
ElementsMap,
|
||||||
ElementsMapOrArray,
|
ElementsMapOrArray,
|
||||||
ExcalidrawElement,
|
ExcalidrawElement,
|
||||||
|
ExcalidrawFrameLikeElement,
|
||||||
|
NonDeleted,
|
||||||
NonDeletedExcalidrawElement,
|
NonDeletedExcalidrawElement,
|
||||||
} from "./types";
|
} from "./types";
|
||||||
|
|
||||||
|
const shouldIgnoreElementFromSelection = (
|
||||||
|
element: NonDeletedExcalidrawElement,
|
||||||
|
) => element.locked || isBoundToContainer(element);
|
||||||
|
|
||||||
|
const excludeElementsFromFrames = <T extends ExcalidrawElement>(
|
||||||
|
selectedElements: readonly T[],
|
||||||
|
framesInSelection: Set<ExcalidrawFrameLikeElement["id"]>,
|
||||||
|
) => {
|
||||||
|
return selectedElements.filter((element) => {
|
||||||
|
if (element.frameId && framesInSelection.has(element.frameId)) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Frames and their containing elements are not to be selected at the same time.
|
* Frames and their containing elements are not to be selected at the same time.
|
||||||
* Given an array of selected elements, if there are frames and their containing elements
|
* Given an array of selected elements, if there are frames and their containing elements
|
||||||
@@ -47,68 +84,286 @@ export const excludeElementsInFramesFromSelection = <
|
|||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
return selectedElements.filter((element) => {
|
return excludeElementsFromFrames(selectedElements, framesInSelection);
|
||||||
if (element.frameId && framesInSelection.has(element.frameId)) {
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
return true;
|
|
||||||
});
|
|
||||||
};
|
};
|
||||||
|
|
||||||
export const getElementsWithinSelection = (
|
export const getElementsWithinSelection = (
|
||||||
elements: readonly NonDeletedExcalidrawElement[],
|
elements: readonly NonDeletedExcalidrawElement[],
|
||||||
selection: NonDeletedExcalidrawElement,
|
selection: NonDeletedExcalidrawElement,
|
||||||
elementsMap: ElementsMap,
|
elementsMap: ElementsMap,
|
||||||
|
// TODO remove (this flag is effectively unused AFAIK)
|
||||||
excludeElementsInFrames: boolean = true,
|
excludeElementsInFrames: boolean = true,
|
||||||
) => {
|
boxSelectionMode: BoxSelectionMode = "contain",
|
||||||
const [selectionX1, selectionY1, selectionX2, selectionY2] =
|
): NonDeletedExcalidrawElement[] => {
|
||||||
|
const [selectionStartX, selectionStartY, selectionEndX, selectionEndY] =
|
||||||
getElementAbsoluteCoords(selection, elementsMap);
|
getElementAbsoluteCoords(selection, elementsMap);
|
||||||
|
const selectionX1 = Math.min(selectionStartX, selectionEndX);
|
||||||
|
const selectionY1 = Math.min(selectionStartY, selectionEndY);
|
||||||
|
const selectionX2 = Math.max(selectionStartX, selectionEndX);
|
||||||
|
const selectionY2 = Math.max(selectionStartY, selectionEndY);
|
||||||
|
const selectionBounds = [
|
||||||
|
selectionX1,
|
||||||
|
selectionY1,
|
||||||
|
selectionX2,
|
||||||
|
selectionY2,
|
||||||
|
] as Bounds;
|
||||||
|
const selectionEdges = [
|
||||||
|
lineSegment<GlobalPoint>(
|
||||||
|
pointFrom(selectionX1, selectionY1),
|
||||||
|
pointFrom(selectionX2, selectionY1),
|
||||||
|
),
|
||||||
|
lineSegment<GlobalPoint>(
|
||||||
|
pointFrom(selectionX2, selectionY1),
|
||||||
|
pointFrom(selectionX2, selectionY2),
|
||||||
|
),
|
||||||
|
lineSegment<GlobalPoint>(
|
||||||
|
pointFrom(selectionX2, selectionY2),
|
||||||
|
pointFrom(selectionX1, selectionY2),
|
||||||
|
),
|
||||||
|
lineSegment<GlobalPoint>(
|
||||||
|
pointFrom(selectionX1, selectionY2),
|
||||||
|
pointFrom(selectionX1, selectionY1),
|
||||||
|
),
|
||||||
|
];
|
||||||
|
|
||||||
let elementsInSelection = elements.filter((element) => {
|
const framesInSelection = excludeElementsInFrames
|
||||||
let [elementX1, elementY1, elementX2, elementY2] = getElementBounds(
|
? new Set<NonDeletedExcalidrawElement["id"]>()
|
||||||
element,
|
: null;
|
||||||
elementsMap,
|
const groups: Record<string, NonDeletedExcalidrawElement[]> = {};
|
||||||
);
|
const elementsInSelection: Set<NonDeletedExcalidrawElement> = new Set();
|
||||||
|
|
||||||
const containingFrame = getContainingFrame(element, elementsMap);
|
for (const element of elements) {
|
||||||
if (containingFrame) {
|
if (shouldIgnoreElementFromSelection(element)) {
|
||||||
const [fx1, fy1, fx2, fy2] = getElementBounds(
|
continue;
|
||||||
containingFrame,
|
}
|
||||||
|
|
||||||
|
// Track only selectable top-level group members, so ignored elements such
|
||||||
|
// as bound text and locked elements don't affect group selection.
|
||||||
|
const groupId = element.groupIds.at(-1);
|
||||||
|
if (groupId) {
|
||||||
|
if (!groups[groupId]) {
|
||||||
|
groups[groupId] = [];
|
||||||
|
}
|
||||||
|
groups[groupId].push(element);
|
||||||
|
}
|
||||||
|
|
||||||
|
const strokeWidth = element.strokeWidth;
|
||||||
|
let labelAABB: Bounds | null = null;
|
||||||
|
let elementAABB = getElementBounds(element, elementsMap);
|
||||||
|
|
||||||
|
elementAABB = [
|
||||||
|
elementAABB[0] - strokeWidth / 2,
|
||||||
|
elementAABB[1] - strokeWidth / 2,
|
||||||
|
elementAABB[2] + strokeWidth / 2,
|
||||||
|
elementAABB[3] + strokeWidth / 2,
|
||||||
|
] as Bounds;
|
||||||
|
|
||||||
|
// Whether the element bounds should include the bound text element bounds
|
||||||
|
const boundTextElement =
|
||||||
|
isArrowElement(element) && getBoundTextElement(element, elementsMap);
|
||||||
|
if (boundTextElement) {
|
||||||
|
const { x, y } = LinearElementEditor.getBoundTextElementPosition(
|
||||||
|
element,
|
||||||
|
boundTextElement,
|
||||||
elementsMap,
|
elementsMap,
|
||||||
);
|
);
|
||||||
|
labelAABB = [
|
||||||
elementX1 = Math.max(fx1, elementX1);
|
x,
|
||||||
elementY1 = Math.max(fy1, elementY1);
|
y,
|
||||||
elementX2 = Math.min(fx2, elementX2);
|
x + boundTextElement.width,
|
||||||
elementY2 = Math.min(fy2, elementY2);
|
y + boundTextElement.height,
|
||||||
|
] as Bounds;
|
||||||
}
|
}
|
||||||
|
|
||||||
return (
|
// Clip element bounds by its containing frame (if any), since only the
|
||||||
element.locked === false &&
|
// visible (frame-clipped) portion of the element is relevant for selection.
|
||||||
element.type !== "selection" &&
|
const associatedFrame = getContainingFrame(element, elementsMap);
|
||||||
!isBoundToContainer(element) &&
|
if (
|
||||||
selectionX1 <= elementX1 &&
|
associatedFrame &&
|
||||||
selectionY1 <= elementY1 &&
|
elementOverlapsWithFrame(element, associatedFrame, elementsMap)
|
||||||
selectionX2 >= elementX2 &&
|
) {
|
||||||
selectionY2 >= elementY2
|
const frameAABB = getElementBounds(associatedFrame, elementsMap);
|
||||||
);
|
elementAABB = [
|
||||||
});
|
Math.max(elementAABB[0], frameAABB[0]),
|
||||||
|
Math.max(elementAABB[1], frameAABB[1]),
|
||||||
|
Math.min(elementAABB[2], frameAABB[2]),
|
||||||
|
Math.min(elementAABB[3], frameAABB[3]),
|
||||||
|
] as Bounds;
|
||||||
|
|
||||||
elementsInSelection = excludeElementsInFrames
|
labelAABB = labelAABB
|
||||||
? excludeElementsInFramesFromSelection(elementsInSelection)
|
? ([
|
||||||
: elementsInSelection;
|
Math.max(labelAABB[0], frameAABB[0]),
|
||||||
|
Math.max(labelAABB[1], frameAABB[1]),
|
||||||
elementsInSelection = elementsInSelection.filter((element) => {
|
Math.min(labelAABB[2], frameAABB[2]),
|
||||||
const containingFrame = getContainingFrame(element, elementsMap);
|
Math.min(labelAABB[3], frameAABB[3]),
|
||||||
|
] as Bounds)
|
||||||
if (containingFrame) {
|
: null;
|
||||||
return elementOverlapsWithFrame(element, containingFrame, elementsMap);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return true;
|
const commonAABB = labelAABB
|
||||||
});
|
? ([
|
||||||
|
Math.min(labelAABB[0], elementAABB[0]),
|
||||||
|
Math.min(labelAABB[1], elementAABB[1]),
|
||||||
|
Math.max(labelAABB[2], elementAABB[2]),
|
||||||
|
Math.max(labelAABB[3], elementAABB[3]),
|
||||||
|
] as Bounds)
|
||||||
|
: elementAABB;
|
||||||
|
|
||||||
return elementsInSelection;
|
// ============== Evaluation ==============
|
||||||
|
|
||||||
|
// 1. If the selection box WRAPs the element's AABB, then add it to the
|
||||||
|
// selection and move on, regardless of the selection mode.
|
||||||
|
//
|
||||||
|
// PERF: This trick only works with axis-aligned box selection and the
|
||||||
|
// current convex element shapes!
|
||||||
|
if (boundsContainBounds(selectionBounds, commonAABB)) {
|
||||||
|
if (framesInSelection && isFrameLikeElement(element)) {
|
||||||
|
framesInSelection.add(element.id);
|
||||||
|
}
|
||||||
|
elementsInSelection.add(element);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
// 2. Handle the case where the label is overlapped by the selection box
|
||||||
|
if (
|
||||||
|
boxSelectionMode === "overlap" &&
|
||||||
|
labelAABB &&
|
||||||
|
doBoundsIntersect(selectionBounds, labelAABB)
|
||||||
|
) {
|
||||||
|
elementsInSelection.add(element);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
// 3. Handle the case where the selection is not wrapping the element, but
|
||||||
|
// it does intersect the element's outline (non-AABB).
|
||||||
|
if (
|
||||||
|
boxSelectionMode === "overlap" &&
|
||||||
|
doBoundsIntersect(selectionBounds, elementAABB)
|
||||||
|
) {
|
||||||
|
let hasIntersection = false;
|
||||||
|
|
||||||
|
// Preliminary check potential intersection imprecision
|
||||||
|
if (isLinearElement(element) || isFreeDrawElement(element)) {
|
||||||
|
const center = elementCenterPoint(element, elementsMap);
|
||||||
|
hasIntersection = element.points.some((point) => {
|
||||||
|
const rotatedPoint = pointRotateRads(
|
||||||
|
pointFrom<GlobalPoint>(element.x + point[0], element.y + point[1]),
|
||||||
|
center,
|
||||||
|
element.angle,
|
||||||
|
);
|
||||||
|
|
||||||
|
return pointInsideBounds(rotatedPoint, selectionBounds);
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
const nonRotatedElementBounds = getElementBounds(
|
||||||
|
element,
|
||||||
|
elementsMap,
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
const center = elementCenterPoint(element, elementsMap);
|
||||||
|
hasIntersection = [
|
||||||
|
pointRotateRads(
|
||||||
|
pointFrom<GlobalPoint>(
|
||||||
|
(nonRotatedElementBounds[0] + nonRotatedElementBounds[2]) / 2,
|
||||||
|
nonRotatedElementBounds[1],
|
||||||
|
),
|
||||||
|
center,
|
||||||
|
element.angle,
|
||||||
|
),
|
||||||
|
pointRotateRads(
|
||||||
|
pointFrom<GlobalPoint>(
|
||||||
|
nonRotatedElementBounds[2],
|
||||||
|
(nonRotatedElementBounds[1] + nonRotatedElementBounds[3]) / 2,
|
||||||
|
),
|
||||||
|
center,
|
||||||
|
element.angle,
|
||||||
|
),
|
||||||
|
pointRotateRads(
|
||||||
|
pointFrom<GlobalPoint>(
|
||||||
|
(nonRotatedElementBounds[0] + nonRotatedElementBounds[2]) / 2,
|
||||||
|
nonRotatedElementBounds[3],
|
||||||
|
),
|
||||||
|
center,
|
||||||
|
element.angle,
|
||||||
|
),
|
||||||
|
pointRotateRads(
|
||||||
|
pointFrom<GlobalPoint>(
|
||||||
|
nonRotatedElementBounds[0],
|
||||||
|
(nonRotatedElementBounds[1] + nonRotatedElementBounds[3]) / 2,
|
||||||
|
),
|
||||||
|
center,
|
||||||
|
element.angle,
|
||||||
|
),
|
||||||
|
].some((point) => {
|
||||||
|
return pointInsideBounds(
|
||||||
|
pointRotateRads(point, center, element.angle),
|
||||||
|
selectionBounds,
|
||||||
|
);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!hasIntersection) {
|
||||||
|
hasIntersection = selectionEdges.some(
|
||||||
|
(selectionEdge) =>
|
||||||
|
intersectElementWithLineSegment(
|
||||||
|
element,
|
||||||
|
elementsMap,
|
||||||
|
selectionEdge,
|
||||||
|
strokeWidth / 2,
|
||||||
|
true, // Stop at first hit for better performance
|
||||||
|
).length > 0,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (hasIntersection) {
|
||||||
|
if (framesInSelection && isFrameLikeElement(element)) {
|
||||||
|
framesInSelection.add(element.id);
|
||||||
|
}
|
||||||
|
|
||||||
|
elementsInSelection.add(element);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 4. We don't need to handle when the selection is inside the element
|
||||||
|
// as it is separately handled in App.
|
||||||
|
}
|
||||||
|
|
||||||
|
if (framesInSelection) {
|
||||||
|
elementsInSelection.forEach((element) => {
|
||||||
|
if (element.frameId && framesInSelection.has(element.frameId)) {
|
||||||
|
elementsInSelection.delete(element);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (boxSelectionMode === "overlap") {
|
||||||
|
Array.from(elementsInSelection).forEach((element) => {
|
||||||
|
const groupId = element.groupIds.at(-1);
|
||||||
|
const group = groupId ? groups[groupId] : null;
|
||||||
|
|
||||||
|
group?.forEach((groupElement) => elementsInSelection.add(groupElement));
|
||||||
|
});
|
||||||
|
} else if (boxSelectionMode === "contain") {
|
||||||
|
elementsInSelection.forEach((element) => {
|
||||||
|
// note: currently we only support top-level group handling since
|
||||||
|
// we don't support box selecting while editing the group/subgroup
|
||||||
|
// see https://github.com/excalidraw/excalidraw/pull/11234#issuecomment-4387654451
|
||||||
|
const groupId = element.groupIds.at(-1);
|
||||||
|
|
||||||
|
const group = groupId ? groups[groupId] : null;
|
||||||
|
|
||||||
|
if (
|
||||||
|
group &&
|
||||||
|
!group.every((groupElement) => elementsInSelection.has(groupElement))
|
||||||
|
) {
|
||||||
|
elementsInSelection.delete(element);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// to maintain original order elements (namely for group selection)
|
||||||
|
return elements.filter((element) => elementsInSelection.has(element));
|
||||||
};
|
};
|
||||||
|
|
||||||
export const getVisibleAndNonSelectedElements = (
|
export const getVisibleAndNonSelectedElements = (
|
||||||
@@ -288,3 +543,19 @@ export const getSelectionStateForElements = (
|
|||||||
),
|
),
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Returns editing or single-selected text element, if any.
|
||||||
|
*/
|
||||||
|
export const getActiveTextElement = (
|
||||||
|
selectedElements: readonly NonDeleted<ExcalidrawElement>[],
|
||||||
|
appState: Pick<AppState, "editingTextElement">,
|
||||||
|
) => {
|
||||||
|
const activeTextElement =
|
||||||
|
appState.editingTextElement ||
|
||||||
|
(selectedElements.length === 1 &&
|
||||||
|
isTextElement(selectedElements[0]) &&
|
||||||
|
selectedElements[0]);
|
||||||
|
|
||||||
|
return activeTextElement || null;
|
||||||
|
};
|
||||||
|
|||||||
+230
-102
@@ -57,8 +57,8 @@ import { headingForPointIsHorizontal } from "./heading";
|
|||||||
|
|
||||||
import { canChangeRoundness } from "./comparisons";
|
import { canChangeRoundness } from "./comparisons";
|
||||||
import {
|
import {
|
||||||
|
elementCenterPoint,
|
||||||
getArrowheadPoints,
|
getArrowheadPoints,
|
||||||
getCenterForBounds,
|
|
||||||
getDiamondPoints,
|
getDiamondPoints,
|
||||||
getElementAbsoluteCoords,
|
getElementAbsoluteCoords,
|
||||||
} from "./bounds";
|
} from "./bounds";
|
||||||
@@ -69,10 +69,10 @@ import type {
|
|||||||
NonDeletedExcalidrawElement,
|
NonDeletedExcalidrawElement,
|
||||||
ExcalidrawSelectionElement,
|
ExcalidrawSelectionElement,
|
||||||
ExcalidrawLinearElement,
|
ExcalidrawLinearElement,
|
||||||
Arrowhead,
|
|
||||||
ExcalidrawFreeDrawElement,
|
ExcalidrawFreeDrawElement,
|
||||||
ElementsMap,
|
ElementsMap,
|
||||||
ExcalidrawLineElement,
|
ExcalidrawLineElement,
|
||||||
|
Arrowhead,
|
||||||
} from "./types";
|
} from "./types";
|
||||||
|
|
||||||
import type { Drawable, Options } from "roughjs/bin/core";
|
import type { Drawable, Options } from "roughjs/bin/core";
|
||||||
@@ -296,6 +296,82 @@ const modifyIframeLikeForRoughOptions = (
|
|||||||
return element;
|
return element;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const generateArrowheadCardinalityOne = (
|
||||||
|
generator: RoughGenerator,
|
||||||
|
arrowheadPoints: number[] | null,
|
||||||
|
lineOptions: Options,
|
||||||
|
) => {
|
||||||
|
if (arrowheadPoints === null) {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
|
||||||
|
const [, , x3, y3, x4, y4] = arrowheadPoints;
|
||||||
|
|
||||||
|
return [generator.line(x3, y3, x4, y4, lineOptions)];
|
||||||
|
};
|
||||||
|
|
||||||
|
const generateArrowheadLinesToTip = (
|
||||||
|
generator: RoughGenerator,
|
||||||
|
arrowheadPoints: number[] | null,
|
||||||
|
lineOptions: Options,
|
||||||
|
) => {
|
||||||
|
if (arrowheadPoints === null) {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
|
||||||
|
const [x2, y2, x3, y3, x4, y4] = arrowheadPoints;
|
||||||
|
|
||||||
|
return [
|
||||||
|
generator.line(x3, y3, x2, y2, lineOptions),
|
||||||
|
generator.line(x4, y4, x2, y2, lineOptions),
|
||||||
|
];
|
||||||
|
};
|
||||||
|
|
||||||
|
const getArrowheadLineOptions = (
|
||||||
|
element: ExcalidrawLinearElement,
|
||||||
|
options: Options,
|
||||||
|
) => {
|
||||||
|
const lineOptions = { ...options };
|
||||||
|
|
||||||
|
if (element.strokeStyle === "dotted") {
|
||||||
|
// for dotted arrows caps, reduce gap to make it more legible
|
||||||
|
const dash = getDashArrayDotted(element.strokeWidth - 1);
|
||||||
|
lineOptions.strokeLineDash = [dash[0], dash[1] - 1];
|
||||||
|
} else {
|
||||||
|
// for solid/dashed, keep solid arrow cap
|
||||||
|
delete lineOptions.strokeLineDash;
|
||||||
|
}
|
||||||
|
lineOptions.roughness = Math.min(1, lineOptions.roughness || 0);
|
||||||
|
|
||||||
|
return lineOptions;
|
||||||
|
};
|
||||||
|
|
||||||
|
const generateArrowheadOutlineCircle = (
|
||||||
|
generator: RoughGenerator,
|
||||||
|
options: Options,
|
||||||
|
strokeColor: string,
|
||||||
|
arrowheadPoints: number[] | null,
|
||||||
|
fill: string,
|
||||||
|
diameterScale = 1,
|
||||||
|
) => {
|
||||||
|
if (arrowheadPoints === null) {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
|
||||||
|
const [x, y, diameter] = arrowheadPoints;
|
||||||
|
const circleOptions = {
|
||||||
|
...options,
|
||||||
|
fill,
|
||||||
|
fillStyle: "solid" as const,
|
||||||
|
stroke: strokeColor,
|
||||||
|
roughness: Math.min(0.5, options.roughness || 0),
|
||||||
|
};
|
||||||
|
|
||||||
|
delete circleOptions.strokeLineDash;
|
||||||
|
|
||||||
|
return [generator.circle(x, y, diameter * diameterScale, circleOptions)];
|
||||||
|
};
|
||||||
|
|
||||||
const getArrowheadShapes = (
|
const getArrowheadShapes = (
|
||||||
element: ExcalidrawLinearElement,
|
element: ExcalidrawLinearElement,
|
||||||
shape: Drawable[],
|
shape: Drawable[],
|
||||||
@@ -306,63 +382,54 @@ const getArrowheadShapes = (
|
|||||||
canvasBackgroundColor: string,
|
canvasBackgroundColor: string,
|
||||||
isDarkMode: boolean,
|
isDarkMode: boolean,
|
||||||
) => {
|
) => {
|
||||||
const arrowheadPoints = getArrowheadPoints(
|
if (arrowhead === null) {
|
||||||
element,
|
|
||||||
shape,
|
|
||||||
position,
|
|
||||||
arrowhead,
|
|
||||||
);
|
|
||||||
|
|
||||||
if (arrowheadPoints === null) {
|
|
||||||
return [];
|
return [];
|
||||||
}
|
}
|
||||||
|
|
||||||
const generateCrowfootOne = (
|
|
||||||
arrowheadPoints: number[] | null,
|
|
||||||
options: Options,
|
|
||||||
) => {
|
|
||||||
if (arrowheadPoints === null) {
|
|
||||||
return [];
|
|
||||||
}
|
|
||||||
|
|
||||||
const [, , x3, y3, x4, y4] = arrowheadPoints;
|
|
||||||
|
|
||||||
return [generator.line(x3, y3, x4, y4, options)];
|
|
||||||
};
|
|
||||||
|
|
||||||
const strokeColor = isDarkMode
|
const strokeColor = isDarkMode
|
||||||
? applyDarkModeFilter(element.strokeColor)
|
? applyDarkModeFilter(element.strokeColor)
|
||||||
: element.strokeColor;
|
: element.strokeColor;
|
||||||
|
const backgroundFillColor = isDarkMode
|
||||||
|
? applyDarkModeFilter(canvasBackgroundColor)
|
||||||
|
: canvasBackgroundColor;
|
||||||
|
const cardinalityOneOrManyOffset = -0.25;
|
||||||
|
const cardinalityZeroCircleScale = 0.8;
|
||||||
|
|
||||||
switch (arrowhead) {
|
switch (arrowhead) {
|
||||||
case "dot":
|
|
||||||
case "circle":
|
case "circle":
|
||||||
case "circle_outline": {
|
case "circle_outline": {
|
||||||
const [x, y, diameter] = arrowheadPoints;
|
return generateArrowheadOutlineCircle(
|
||||||
|
generator,
|
||||||
// always use solid stroke for arrowhead
|
options,
|
||||||
delete options.strokeLineDash;
|
strokeColor,
|
||||||
|
getArrowheadPoints(element, shape, position, arrowhead),
|
||||||
return [
|
arrowhead === "circle_outline" ? backgroundFillColor : strokeColor,
|
||||||
generator.circle(x, y, diameter, {
|
);
|
||||||
...options,
|
|
||||||
fill:
|
|
||||||
arrowhead === "circle_outline"
|
|
||||||
? canvasBackgroundColor
|
|
||||||
: strokeColor,
|
|
||||||
|
|
||||||
fillStyle: "solid",
|
|
||||||
stroke: strokeColor,
|
|
||||||
roughness: Math.min(0.5, options.roughness || 0),
|
|
||||||
}),
|
|
||||||
];
|
|
||||||
}
|
}
|
||||||
case "triangle":
|
case "triangle":
|
||||||
case "triangle_outline": {
|
case "triangle_outline": {
|
||||||
|
const arrowheadPoints = getArrowheadPoints(
|
||||||
|
element,
|
||||||
|
shape,
|
||||||
|
position,
|
||||||
|
arrowhead,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (arrowheadPoints === null) {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
|
||||||
const [x, y, x2, y2, x3, y3] = arrowheadPoints;
|
const [x, y, x2, y2, x3, y3] = arrowheadPoints;
|
||||||
|
const triangleOptions = {
|
||||||
|
...options,
|
||||||
|
fill:
|
||||||
|
arrowhead === "triangle_outline" ? backgroundFillColor : strokeColor,
|
||||||
|
fillStyle: "solid" as const,
|
||||||
|
roughness: Math.min(1, options.roughness || 0),
|
||||||
|
};
|
||||||
|
|
||||||
// always use solid stroke for arrowhead
|
// always use solid stroke for arrowhead
|
||||||
delete options.strokeLineDash;
|
delete triangleOptions.strokeLineDash;
|
||||||
|
|
||||||
return [
|
return [
|
||||||
generator.polygon(
|
generator.polygon(
|
||||||
@@ -372,24 +439,34 @@ const getArrowheadShapes = (
|
|||||||
[x3, y3],
|
[x3, y3],
|
||||||
[x, y],
|
[x, y],
|
||||||
],
|
],
|
||||||
{
|
triangleOptions,
|
||||||
...options,
|
|
||||||
fill:
|
|
||||||
arrowhead === "triangle_outline"
|
|
||||||
? canvasBackgroundColor
|
|
||||||
: strokeColor,
|
|
||||||
fillStyle: "solid",
|
|
||||||
roughness: Math.min(1, options.roughness || 0),
|
|
||||||
},
|
|
||||||
),
|
),
|
||||||
];
|
];
|
||||||
}
|
}
|
||||||
case "diamond":
|
case "diamond":
|
||||||
case "diamond_outline": {
|
case "diamond_outline": {
|
||||||
|
const arrowheadPoints = getArrowheadPoints(
|
||||||
|
element,
|
||||||
|
shape,
|
||||||
|
position,
|
||||||
|
arrowhead,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (arrowheadPoints === null) {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
|
||||||
const [x, y, x2, y2, x3, y3, x4, y4] = arrowheadPoints;
|
const [x, y, x2, y2, x3, y3, x4, y4] = arrowheadPoints;
|
||||||
|
const diamondOptions = {
|
||||||
|
...options,
|
||||||
|
fill:
|
||||||
|
arrowhead === "diamond_outline" ? backgroundFillColor : strokeColor,
|
||||||
|
fillStyle: "solid" as const,
|
||||||
|
roughness: Math.min(1, options.roughness || 0),
|
||||||
|
};
|
||||||
|
|
||||||
// always use solid stroke for arrowhead
|
// always use solid stroke for arrowhead
|
||||||
delete options.strokeLineDash;
|
delete diamondOptions.strokeLineDash;
|
||||||
|
|
||||||
return [
|
return [
|
||||||
generator.polygon(
|
generator.polygon(
|
||||||
@@ -400,53 +477,117 @@ const getArrowheadShapes = (
|
|||||||
[x4, y4],
|
[x4, y4],
|
||||||
[x, y],
|
[x, y],
|
||||||
],
|
],
|
||||||
{
|
diamondOptions,
|
||||||
...options,
|
),
|
||||||
fill:
|
];
|
||||||
arrowhead === "diamond_outline"
|
}
|
||||||
? canvasBackgroundColor
|
case "cardinality_one":
|
||||||
: strokeColor,
|
return generateArrowheadCardinalityOne(
|
||||||
fillStyle: "solid",
|
generator,
|
||||||
roughness: Math.min(1, options.roughness || 0),
|
getArrowheadPoints(element, shape, position, arrowhead),
|
||||||
},
|
getArrowheadLineOptions(element, options),
|
||||||
|
);
|
||||||
|
case "cardinality_many":
|
||||||
|
return generateArrowheadLinesToTip(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(element, shape, position, arrowhead),
|
||||||
|
getArrowheadLineOptions(element, options),
|
||||||
|
);
|
||||||
|
case "cardinality_one_or_many": {
|
||||||
|
const lineOptions = getArrowheadLineOptions(element, options);
|
||||||
|
|
||||||
|
return [
|
||||||
|
...generateArrowheadLinesToTip(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(element, shape, position, "cardinality_many"),
|
||||||
|
lineOptions,
|
||||||
|
),
|
||||||
|
...generateArrowheadCardinalityOne(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(
|
||||||
|
element,
|
||||||
|
shape,
|
||||||
|
position,
|
||||||
|
"cardinality_one",
|
||||||
|
cardinalityOneOrManyOffset,
|
||||||
|
),
|
||||||
|
lineOptions,
|
||||||
|
),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
case "cardinality_exactly_one": {
|
||||||
|
const lineOptions = getArrowheadLineOptions(element, options);
|
||||||
|
|
||||||
|
return [
|
||||||
|
...generateArrowheadCardinalityOne(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(element, shape, position, "cardinality_one", -0.5),
|
||||||
|
lineOptions,
|
||||||
|
),
|
||||||
|
...generateArrowheadCardinalityOne(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(element, shape, position, "cardinality_one"),
|
||||||
|
lineOptions,
|
||||||
|
),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
case "cardinality_zero_or_one": {
|
||||||
|
const lineOptions = getArrowheadLineOptions(element, options);
|
||||||
|
|
||||||
|
return [
|
||||||
|
...generateArrowheadOutlineCircle(
|
||||||
|
generator,
|
||||||
|
options,
|
||||||
|
strokeColor,
|
||||||
|
getArrowheadPoints(element, shape, position, "circle_outline", 1.5),
|
||||||
|
backgroundFillColor,
|
||||||
|
cardinalityZeroCircleScale,
|
||||||
|
),
|
||||||
|
...generateArrowheadCardinalityOne(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(element, shape, position, "cardinality_one", -0.5),
|
||||||
|
lineOptions,
|
||||||
|
),
|
||||||
|
];
|
||||||
|
}
|
||||||
|
case "cardinality_zero_or_many": {
|
||||||
|
const lineOptions = getArrowheadLineOptions(element, options);
|
||||||
|
|
||||||
|
return [
|
||||||
|
...generateArrowheadLinesToTip(
|
||||||
|
generator,
|
||||||
|
getArrowheadPoints(element, shape, position, "cardinality_many"),
|
||||||
|
lineOptions,
|
||||||
|
),
|
||||||
|
...generateArrowheadOutlineCircle(
|
||||||
|
generator,
|
||||||
|
options,
|
||||||
|
strokeColor,
|
||||||
|
getArrowheadPoints(element, shape, position, "circle_outline", 1.5),
|
||||||
|
backgroundFillColor,
|
||||||
|
cardinalityZeroCircleScale,
|
||||||
),
|
),
|
||||||
];
|
];
|
||||||
}
|
}
|
||||||
case "crowfoot_one":
|
|
||||||
return generateCrowfootOne(arrowheadPoints, options);
|
|
||||||
case "bar":
|
case "bar":
|
||||||
case "arrow":
|
case "arrow":
|
||||||
case "crowfoot_many":
|
|
||||||
case "crowfoot_one_or_many":
|
|
||||||
default: {
|
default: {
|
||||||
const [x2, y2, x3, y3, x4, y4] = arrowheadPoints;
|
return generateArrowheadLinesToTip(
|
||||||
|
generator,
|
||||||
if (element.strokeStyle === "dotted") {
|
getArrowheadPoints(element, shape, position, arrowhead),
|
||||||
// for dotted arrows caps, reduce gap to make it more legible
|
getArrowheadLineOptions(element, options),
|
||||||
const dash = getDashArrayDotted(element.strokeWidth - 1);
|
);
|
||||||
options.strokeLineDash = [dash[0], dash[1] - 1];
|
|
||||||
} else {
|
|
||||||
// for solid/dashed, keep solid arrow cap
|
|
||||||
delete options.strokeLineDash;
|
|
||||||
}
|
|
||||||
options.roughness = Math.min(1, options.roughness || 0);
|
|
||||||
return [
|
|
||||||
generator.line(x3, y3, x2, y2, options),
|
|
||||||
generator.line(x4, y4, x2, y2, options),
|
|
||||||
...(arrowhead === "crowfoot_one_or_many"
|
|
||||||
? generateCrowfootOne(
|
|
||||||
getArrowheadPoints(element, shape, position, "crowfoot_one"),
|
|
||||||
options,
|
|
||||||
)
|
|
||||||
: []),
|
|
||||||
];
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
export const generateLinearCollisionShape = (
|
export const generateLinearCollisionShape = (
|
||||||
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
||||||
) => {
|
elementsMap: ElementsMap,
|
||||||
|
): {
|
||||||
|
op: string;
|
||||||
|
data: number[];
|
||||||
|
}[] => {
|
||||||
const generator = new RoughGenerator();
|
const generator = new RoughGenerator();
|
||||||
const options: Options = {
|
const options: Options = {
|
||||||
seed: element.seed,
|
seed: element.seed,
|
||||||
@@ -455,20 +596,7 @@ export const generateLinearCollisionShape = (
|
|||||||
roughness: 0,
|
roughness: 0,
|
||||||
preserveVertices: true,
|
preserveVertices: true,
|
||||||
};
|
};
|
||||||
const center = getCenterForBounds(
|
const center = elementCenterPoint(element, elementsMap);
|
||||||
// Need a non-rotated center point
|
|
||||||
element.points.reduce(
|
|
||||||
(acc, point) => {
|
|
||||||
return [
|
|
||||||
Math.min(element.x + point[0], acc[0]),
|
|
||||||
Math.min(element.y + point[1], acc[1]),
|
|
||||||
Math.max(element.x + point[0], acc[2]),
|
|
||||||
Math.max(element.y + point[1], acc[3]),
|
|
||||||
];
|
|
||||||
},
|
|
||||||
[Infinity, Infinity, -Infinity, -Infinity],
|
|
||||||
),
|
|
||||||
);
|
|
||||||
|
|
||||||
switch (element.type) {
|
switch (element.type) {
|
||||||
case "line":
|
case "line":
|
||||||
|
|||||||
@@ -1,59 +1,56 @@
|
|||||||
import { arrayToMapWithIndex } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
import type { ExcalidrawElement } from "./types";
|
import type { ExcalidrawElement } from "./types";
|
||||||
|
|
||||||
const normalizeGroupElementOrder = (elements: readonly ExcalidrawElement[]) => {
|
const defragmentGroups = (elements: readonly ExcalidrawElement[]) => {
|
||||||
const origElements: ExcalidrawElement[] = elements.slice();
|
const groupIdAtLevel = (element: ExcalidrawElement, level: number) => {
|
||||||
const sortedElements = new Set<ExcalidrawElement>();
|
return element.groupIds[element.groupIds.length - level - 1];
|
||||||
|
|
||||||
const orderInnerGroups = (
|
|
||||||
elements: readonly ExcalidrawElement[],
|
|
||||||
): ExcalidrawElement[] => {
|
|
||||||
const firstGroupSig = elements[0]?.groupIds?.join("");
|
|
||||||
const aGroup: ExcalidrawElement[] = [elements[0]];
|
|
||||||
const bGroup: ExcalidrawElement[] = [];
|
|
||||||
for (const element of elements.slice(1)) {
|
|
||||||
if (element.groupIds?.join("") === firstGroupSig) {
|
|
||||||
aGroup.push(element);
|
|
||||||
} else {
|
|
||||||
bGroup.push(element);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return bGroup.length ? [...aGroup, ...orderInnerGroups(bGroup)] : aGroup;
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const groupHandledElements = new Map<string, true>();
|
const orderLevel = (
|
||||||
|
levelElements: readonly ExcalidrawElement[],
|
||||||
|
level: number,
|
||||||
|
): ExcalidrawElement[] => {
|
||||||
|
const buckets = new Map<string, ExcalidrawElement[]>();
|
||||||
|
// Slots preserve first-occurrence order: a groupId reserves its slot
|
||||||
|
// the first time one of its members is seen; loose elements occupy
|
||||||
|
// their own slot. Groups are then expanded (and recursed into) in place.
|
||||||
|
const slots: (ExcalidrawElement | string)[] = [];
|
||||||
|
|
||||||
origElements.forEach((element, idx) => {
|
for (const element of levelElements) {
|
||||||
if (groupHandledElements.has(element.id)) {
|
const groupId = groupIdAtLevel(element, level);
|
||||||
return;
|
if (groupId === undefined) {
|
||||||
}
|
slots.push(element);
|
||||||
if (element.groupIds?.length) {
|
continue;
|
||||||
const topGroup = element.groupIds[element.groupIds.length - 1];
|
|
||||||
const groupElements = origElements.slice(idx).filter((element) => {
|
|
||||||
const ret = element?.groupIds?.some((id) => id === topGroup);
|
|
||||||
if (ret) {
|
|
||||||
groupHandledElements.set(element!.id, true);
|
|
||||||
}
|
|
||||||
return ret;
|
|
||||||
});
|
|
||||||
|
|
||||||
for (const elem of orderInnerGroups(groupElements)) {
|
|
||||||
sortedElements.add(elem);
|
|
||||||
}
|
}
|
||||||
} else {
|
let bucket = buckets.get(groupId);
|
||||||
sortedElements.add(element);
|
if (!bucket) {
|
||||||
|
bucket = [];
|
||||||
|
buckets.set(groupId, bucket);
|
||||||
|
slots.push(groupId);
|
||||||
|
}
|
||||||
|
bucket.push(element);
|
||||||
}
|
}
|
||||||
});
|
|
||||||
|
return slots.flatMap((slot) =>
|
||||||
|
typeof slot === "string"
|
||||||
|
? orderLevel(buckets.get(slot)!, level + 1)
|
||||||
|
: [slot],
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
// `groupIds` is stored innermost-first, so the outermost group is the
|
||||||
|
// last entry. We recurse from level 0 (outermost) inward.
|
||||||
|
const sortedElements = orderLevel(elements, 0);
|
||||||
|
|
||||||
// if there's a bug which resulted in losing some of the elements, return
|
// if there's a bug which resulted in losing some of the elements, return
|
||||||
// original instead as that's better than losing data
|
// original instead as that's better than losing data
|
||||||
if (sortedElements.size !== elements.length) {
|
if (sortedElements.length !== elements.length) {
|
||||||
console.error("normalizeGroupElementOrder: lost some elements... bailing!");
|
console.error("defragmentGroups: lost some elements... bailing!");
|
||||||
return elements;
|
return elements;
|
||||||
}
|
}
|
||||||
|
|
||||||
return [...sortedElements];
|
return sortedElements;
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -68,39 +65,40 @@ const normalizeGroupElementOrder = (elements: readonly ExcalidrawElement[]) => {
|
|||||||
const normalizeBoundElementsOrder = (
|
const normalizeBoundElementsOrder = (
|
||||||
elements: readonly ExcalidrawElement[],
|
elements: readonly ExcalidrawElement[],
|
||||||
) => {
|
) => {
|
||||||
const elementsMap = arrayToMapWithIndex(elements);
|
const elementsMap = arrayToMap(elements);
|
||||||
|
|
||||||
const origElements: (ExcalidrawElement | null)[] = elements.slice();
|
|
||||||
const sortedElements = new Set<ExcalidrawElement>();
|
const sortedElements = new Set<ExcalidrawElement>();
|
||||||
|
|
||||||
origElements.forEach((element, idx) => {
|
for (const element of elements) {
|
||||||
if (!element) {
|
if (sortedElements.has(element)) {
|
||||||
return;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (element.boundElements?.length) {
|
if (element.boundElements?.length) {
|
||||||
sortedElements.add(element);
|
sortedElements.add(element);
|
||||||
origElements[idx] = null;
|
for (const boundElement of element.boundElements) {
|
||||||
element.boundElements.forEach((boundElement) => {
|
|
||||||
const child = elementsMap.get(boundElement.id);
|
const child = elementsMap.get(boundElement.id);
|
||||||
if (child && boundElement.type === "text") {
|
if (child && boundElement.type === "text") {
|
||||||
sortedElements.add(child[0]);
|
sortedElements.add(child);
|
||||||
origElements[child[1]] = null;
|
|
||||||
}
|
}
|
||||||
});
|
|
||||||
} else if (element.type === "text" && element.containerId) {
|
|
||||||
const parent = elementsMap.get(element.containerId);
|
|
||||||
if (!parent?.[0].boundElements?.find((x) => x.id === element.id)) {
|
|
||||||
sortedElements.add(element);
|
|
||||||
origElements[idx] = null;
|
|
||||||
|
|
||||||
// if element has a container and container lists it, skip this element
|
|
||||||
// as it'll be taken care of by the container
|
|
||||||
}
|
}
|
||||||
} else {
|
continue;
|
||||||
sortedElements.add(element);
|
|
||||||
origElements[idx] = null;
|
|
||||||
}
|
}
|
||||||
});
|
|
||||||
|
// if element has a container and container lists it, skip this element
|
||||||
|
// as it'll be taken care of by the container
|
||||||
|
if (
|
||||||
|
element.type === "text" &&
|
||||||
|
element.containerId &&
|
||||||
|
elementsMap
|
||||||
|
.get(element.containerId)
|
||||||
|
?.boundElements?.some((el) => el.id === element.id)
|
||||||
|
) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
sortedElements.add(element);
|
||||||
|
}
|
||||||
|
|
||||||
// if there's a bug which resulted in losing some of the elements, return
|
// if there's a bug which resulted in losing some of the elements, return
|
||||||
// original instead as that's better than losing data
|
// original instead as that's better than losing data
|
||||||
@@ -117,5 +115,5 @@ const normalizeBoundElementsOrder = (
|
|||||||
export const normalizeElementOrder = (
|
export const normalizeElementOrder = (
|
||||||
elements: readonly ExcalidrawElement[],
|
elements: readonly ExcalidrawElement[],
|
||||||
) => {
|
) => {
|
||||||
return normalizeBoundElementsOrder(normalizeGroupElementOrder(elements));
|
return normalizeBoundElementsOrder(defragmentGroups(elements));
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -347,6 +347,7 @@ export const getContainerCenter = (
|
|||||||
midSegmentMidpoint = LinearElementEditor.getSegmentMidPoint(
|
midSegmentMidpoint = LinearElementEditor.getSegmentMidPoint(
|
||||||
container,
|
container,
|
||||||
index + 1,
|
index + 1,
|
||||||
|
elementsMap,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
return { x: midSegmentMidpoint[0], y: midSegmentMidpoint[1] };
|
return { x: midSegmentMidpoint[0], y: midSegmentMidpoint[1] };
|
||||||
@@ -441,7 +442,8 @@ const VALID_CONTAINER_TYPES = new Set([
|
|||||||
|
|
||||||
export const isValidTextContainer = (element: {
|
export const isValidTextContainer = (element: {
|
||||||
type: ExcalidrawElementType;
|
type: ExcalidrawElementType;
|
||||||
}) => VALID_CONTAINER_TYPES.has(element.type);
|
}): element is ExcalidrawTextContainer =>
|
||||||
|
VALID_CONTAINER_TYPES.has(element.type);
|
||||||
|
|
||||||
export const computeContainerDimensionForBoundText = (
|
export const computeContainerDimensionForBoundText = (
|
||||||
dimension: number,
|
dimension: number,
|
||||||
|
|||||||
@@ -4,6 +4,22 @@ import { charWidth, getLineWidth } from "./textMeasurements";
|
|||||||
|
|
||||||
import type { FontString } from "./types";
|
import type { FontString } from "./types";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* This module approximates browser-like soft wrapping for Excalidraw text.
|
||||||
|
*
|
||||||
|
* The flow is:
|
||||||
|
* 1. `parseTokens()` splits a hard line into breakable tokens using a unicode-aware regex.
|
||||||
|
* 2. `getWrappedTextLines()` reflows each hard line into one or more visual lines and
|
||||||
|
* records where each visual line came from in the source text.
|
||||||
|
* 3. `wrapLine()` assembles tokens into lines, and `wrapWord()` handles a single token
|
||||||
|
* that is wider than the available width.
|
||||||
|
* 4. `trimLine()` / `trimLineEndAtSoftBreak()` mirror browser behavior around trailing
|
||||||
|
* whitespace so the rendered text stays consistent with what users see on canvas.
|
||||||
|
*
|
||||||
|
* Mostly, you'll want to use wrapText(). getWrappedTextLines() is for callers
|
||||||
|
* that need metadata such as mapping visual lines back to `originalText`
|
||||||
|
* for caret placement or future editor features.
|
||||||
|
*/
|
||||||
let cachedCjkRegex: RegExp | undefined;
|
let cachedCjkRegex: RegExp | undefined;
|
||||||
let cachedLineBreakRegex: RegExp | undefined;
|
let cachedLineBreakRegex: RegExp | undefined;
|
||||||
let cachedEmojiRegex: RegExp | undefined;
|
let cachedEmojiRegex: RegExp | undefined;
|
||||||
@@ -358,6 +374,10 @@ const Break = {
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* Breaks the line into the tokens based on the found line break opporutnities.
|
* Breaks the line into the tokens based on the found line break opporutnities.
|
||||||
|
*
|
||||||
|
* Note: tokenization normalizes to NFC first so decomposed graphemes are treated as
|
||||||
|
* their composed variants for wrapping. Any code that needs exact source offsets should
|
||||||
|
* keep in mind that this assumes the input text is already NFC-normalized.
|
||||||
*/
|
*/
|
||||||
export const parseTokens = (line: string) => {
|
export const parseTokens = (line: string) => {
|
||||||
const breakLineRegex = getLineBreakRegex();
|
const breakLineRegex = getLineBreakRegex();
|
||||||
@@ -370,56 +390,120 @@ export const parseTokens = (line: string) => {
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* Wraps the original text into the lines based on the given width.
|
* Wraps the original text into the lines based on the given width.
|
||||||
|
*
|
||||||
|
* This is a convenience adapter over `getWrappedTextLines()` for call sites
|
||||||
|
* that only need the rendered wrapped string and not the source offsets.
|
||||||
*/
|
*/
|
||||||
export const wrapText = (
|
export const wrapText = (
|
||||||
text: string,
|
text: string,
|
||||||
font: FontString,
|
font: FontString,
|
||||||
maxWidth: number,
|
maxWidth: number,
|
||||||
): string => {
|
): string => {
|
||||||
|
return getWrappedTextLines(text, font, maxWidth)
|
||||||
|
.map((line) => line.text)
|
||||||
|
.join("\n");
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A single rendered visual line produced from the original text.
|
||||||
|
*
|
||||||
|
* `start` and `end` are end-exclusive code-unit offsets into the original text, and do
|
||||||
|
* not include synthetic soft line breaks inserted by this module. If trailing whitespace
|
||||||
|
* was trimmed away at a wrap boundary, `end` points to the last rendered character.
|
||||||
|
*/
|
||||||
|
export type WrappedTextLine = {
|
||||||
|
text: string;
|
||||||
|
start: number;
|
||||||
|
end: number;
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Splits only on existing hard line breaks and preserves original offsets.
|
||||||
|
*/
|
||||||
|
const getHardLineBreaks = (text: string): WrappedTextLine[] => {
|
||||||
|
let offset = 0;
|
||||||
|
|
||||||
|
return text.split("\n").map((line) => {
|
||||||
|
const start = offset;
|
||||||
|
const end = start + line.length;
|
||||||
|
|
||||||
|
offset = end + 1;
|
||||||
|
|
||||||
|
return {
|
||||||
|
text: line,
|
||||||
|
start,
|
||||||
|
end,
|
||||||
|
};
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Returns the rendered visual lines together with their source offsets.
|
||||||
|
*
|
||||||
|
* This is the source-of-truth wrapping pipeline for callers that need more than the
|
||||||
|
* final wrapped string, for example caret placement or future editor/rich-text mapping.
|
||||||
|
*/
|
||||||
|
export const getWrappedTextLines = (
|
||||||
|
text: string,
|
||||||
|
font: FontString,
|
||||||
|
maxWidth: number,
|
||||||
|
): WrappedTextLine[] => {
|
||||||
// if maxWidth is not finite or NaN which can happen in case of bugs in
|
// if maxWidth is not finite or NaN which can happen in case of bugs in
|
||||||
// computation, we need to make sure we don't continue as we'll end up
|
// computation, we need to make sure we don't continue as we'll end up
|
||||||
// in an infinite loop
|
// in an infinite loop
|
||||||
if (!Number.isFinite(maxWidth) || maxWidth < 0) {
|
if (!Number.isFinite(maxWidth) || maxWidth < 0) {
|
||||||
return text;
|
return getHardLineBreaks(text);
|
||||||
}
|
}
|
||||||
|
|
||||||
const lines: Array<string> = [];
|
const lines: WrappedTextLine[] = [];
|
||||||
const originalLines = text.split("\n");
|
let offset = 0;
|
||||||
|
|
||||||
for (const originalLine of originalLines) {
|
for (const originalLine of text.split("\n")) {
|
||||||
const currentLineWidth = getLineWidth(originalLine, font);
|
const originalLineWidth = getLineWidth(originalLine, font);
|
||||||
|
|
||||||
if (currentLineWidth <= maxWidth) {
|
if (originalLineWidth <= maxWidth) {
|
||||||
lines.push(originalLine);
|
lines.push({
|
||||||
continue;
|
text: originalLine,
|
||||||
|
start: offset,
|
||||||
|
end: offset + originalLine.length,
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
lines.push(...wrapLine(originalLine, font, maxWidth, offset));
|
||||||
}
|
}
|
||||||
|
|
||||||
const wrappedLine = wrapLine(originalLine, font, maxWidth);
|
offset += originalLine.length + 1;
|
||||||
lines.push(...wrappedLine);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return lines.join("\n");
|
return lines;
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Wraps the original line into the lines based on the given width.
|
* Wraps a single hard line into one or more visual lines.
|
||||||
|
*
|
||||||
|
* The line-local offsets are tracked in original-text code units so
|
||||||
|
* we can map the visual line back to the source.
|
||||||
*/
|
*/
|
||||||
const wrapLine = (
|
const wrapLine = (
|
||||||
line: string,
|
line: string,
|
||||||
font: FontString,
|
font: FontString,
|
||||||
maxWidth: number,
|
maxWidth: number,
|
||||||
): string[] => {
|
lineStart: number,
|
||||||
const lines: Array<string> = [];
|
): WrappedTextLine[] => {
|
||||||
|
const lines: WrappedTextLine[] = [];
|
||||||
const tokens = parseTokens(line);
|
const tokens = parseTokens(line);
|
||||||
const tokenIterator = tokens[Symbol.iterator]();
|
|
||||||
|
|
||||||
let currentLine = "";
|
let currentLine = "";
|
||||||
|
let currentLineStart = lineStart;
|
||||||
|
let currentLineEnd = lineStart;
|
||||||
let currentLineWidth = 0;
|
let currentLineWidth = 0;
|
||||||
|
// Tracks the next token's code-unit position in the original source string.
|
||||||
|
let tokenOffset = lineStart;
|
||||||
|
let tokenIndex = 0;
|
||||||
|
|
||||||
let iterator = tokenIterator.next();
|
while (tokenIndex < tokens.length) {
|
||||||
|
const token = tokens[tokenIndex];
|
||||||
while (!iterator.done) {
|
const tokenStart = tokenOffset;
|
||||||
const token = iterator.value;
|
const tokenEnd = tokenStart + token.length;
|
||||||
const testLine = currentLine + token;
|
const testLine = currentLine + token;
|
||||||
|
|
||||||
// cache single codepoint whitespace, CJK or emoji width calc. as kerning should not apply here
|
// cache single codepoint whitespace, CJK or emoji width calc. as kerning should not apply here
|
||||||
@@ -429,37 +513,59 @@ const wrapLine = (
|
|||||||
|
|
||||||
// build up the current line, skipping length check for possibly trailing whitespaces
|
// build up the current line, skipping length check for possibly trailing whitespaces
|
||||||
if (/\s/.test(token) || testLineWidth <= maxWidth) {
|
if (/\s/.test(token) || testLineWidth <= maxWidth) {
|
||||||
|
if (!currentLine) {
|
||||||
|
currentLineStart = tokenStart;
|
||||||
|
}
|
||||||
currentLine = testLine;
|
currentLine = testLine;
|
||||||
|
currentLineEnd = tokenEnd;
|
||||||
currentLineWidth = testLineWidth;
|
currentLineWidth = testLineWidth;
|
||||||
iterator = tokenIterator.next();
|
tokenOffset = tokenEnd;
|
||||||
|
tokenIndex++;
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// current line is empty => just the token (word) is longer than `maxWidth` and needs to be wrapped
|
// current line is empty => just the token (word) is longer than `maxWidth` and needs to be wrapped
|
||||||
if (!currentLine) {
|
if (!currentLine) {
|
||||||
const wrappedWord = wrapWord(token, font, maxWidth);
|
const wrappedWord = wrapWord(token, font, maxWidth, tokenStart);
|
||||||
const trailingLine = wrappedWord[wrappedWord.length - 1] ?? "";
|
const trailingLine = wrappedWord[wrappedWord.length - 1] ?? {
|
||||||
|
text: "",
|
||||||
|
start: tokenStart,
|
||||||
|
end: tokenStart,
|
||||||
|
};
|
||||||
const precedingLines = wrappedWord.slice(0, -1);
|
const precedingLines = wrappedWord.slice(0, -1);
|
||||||
|
|
||||||
lines.push(...precedingLines);
|
lines.push(...precedingLines);
|
||||||
|
|
||||||
// trailing line of the wrapped word might still be joined with next token/s
|
// trailing line of the wrapped word might still be joined with next token/s
|
||||||
currentLine = trailingLine;
|
currentLine = trailingLine.text;
|
||||||
currentLineWidth = getLineWidth(trailingLine, font);
|
currentLineStart = trailingLine.start;
|
||||||
iterator = tokenIterator.next();
|
currentLineEnd = trailingLine.end;
|
||||||
|
currentLineWidth = getLineWidth(trailingLine.text, font);
|
||||||
|
tokenOffset = tokenEnd;
|
||||||
|
tokenIndex++;
|
||||||
} else {
|
} else {
|
||||||
// push & reset, but don't iterate on the next token, as we didn't use it yet!
|
// push & reset, but don't iterate on the next token, as we didn't use it yet!
|
||||||
lines.push(currentLine.trimEnd());
|
lines.push(
|
||||||
|
trimLineEndAtSoftBreak(currentLine, currentLineStart, currentLineEnd),
|
||||||
|
);
|
||||||
|
|
||||||
// purposefully not iterating and not setting `currentLine` to `token`, so that we could use a simple !currentLine check above
|
// purposefully not iterating and not setting `currentLine` to `token`, so that we could use a simple !currentLine check above
|
||||||
currentLine = "";
|
currentLine = "";
|
||||||
|
currentLineStart = tokenStart;
|
||||||
|
currentLineEnd = tokenStart;
|
||||||
currentLineWidth = 0;
|
currentLineWidth = 0;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// iterator done, push the trailing line if exists
|
// iterator done, push the trailing line if exists
|
||||||
if (currentLine) {
|
if (currentLine) {
|
||||||
const trailingLine = trimLine(currentLine, font, maxWidth);
|
const trailingLine = trimLine(
|
||||||
|
currentLine,
|
||||||
|
currentLineStart,
|
||||||
|
currentLineEnd,
|
||||||
|
font,
|
||||||
|
maxWidth,
|
||||||
|
);
|
||||||
lines.push(trailingLine);
|
lines.push(trailingLine);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -467,59 +573,100 @@ const wrapLine = (
|
|||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Wraps the word into the lines based on the given width.
|
* Wraps a single word that could not be placed on an empty line as-is.
|
||||||
*/
|
*/
|
||||||
const wrapWord = (
|
const wrapWord = (
|
||||||
word: string,
|
word: string,
|
||||||
font: FontString,
|
font: FontString,
|
||||||
maxWidth: number,
|
maxWidth: number,
|
||||||
): Array<string> => {
|
wordStart: number,
|
||||||
|
): WrappedTextLine[] => {
|
||||||
// multi-codepoint emojis are already broken apart and shouldn't be broken further
|
// multi-codepoint emojis are already broken apart and shouldn't be broken further
|
||||||
if (getEmojiRegex().test(word)) {
|
if (getEmojiRegex().test(word)) {
|
||||||
return [word];
|
return [
|
||||||
|
{
|
||||||
|
text: word,
|
||||||
|
start: wordStart,
|
||||||
|
end: wordStart + word.length,
|
||||||
|
},
|
||||||
|
];
|
||||||
}
|
}
|
||||||
|
|
||||||
satisfiesWordInvariant(word);
|
satisfiesWordInvariant(word);
|
||||||
|
|
||||||
const lines: Array<string> = [];
|
const lines: WrappedTextLine[] = [];
|
||||||
const chars = Array.from(word);
|
const chars = Array.from(word);
|
||||||
|
|
||||||
let currentLine = "";
|
let currentLine = "";
|
||||||
|
let currentLineStart = wordStart;
|
||||||
|
let currentLineEnd = wordStart;
|
||||||
let currentLineWidth = 0;
|
let currentLineWidth = 0;
|
||||||
|
let offset = wordStart;
|
||||||
|
|
||||||
for (const char of chars) {
|
for (const char of chars) {
|
||||||
|
const charStart = offset;
|
||||||
|
const charEnd = charStart + char.length;
|
||||||
const _charWidth = charWidth.calculate(char, font);
|
const _charWidth = charWidth.calculate(char, font);
|
||||||
const testLineWidth = currentLineWidth + _charWidth;
|
const testLineWidth = currentLineWidth + _charWidth;
|
||||||
|
|
||||||
if (testLineWidth <= maxWidth) {
|
if (testLineWidth <= maxWidth) {
|
||||||
|
if (!currentLine) {
|
||||||
|
currentLineStart = charStart;
|
||||||
|
}
|
||||||
currentLine = currentLine + char;
|
currentLine = currentLine + char;
|
||||||
|
currentLineEnd = charEnd;
|
||||||
currentLineWidth = testLineWidth;
|
currentLineWidth = testLineWidth;
|
||||||
|
offset = charEnd;
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (currentLine) {
|
if (currentLine) {
|
||||||
lines.push(currentLine);
|
lines.push({
|
||||||
|
text: currentLine,
|
||||||
|
start: currentLineStart,
|
||||||
|
end: currentLineEnd,
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
currentLine = char;
|
currentLine = char;
|
||||||
|
currentLineStart = charStart;
|
||||||
|
currentLineEnd = charEnd;
|
||||||
currentLineWidth = _charWidth;
|
currentLineWidth = _charWidth;
|
||||||
|
offset = charEnd;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (currentLine) {
|
if (currentLine) {
|
||||||
lines.push(currentLine);
|
lines.push({
|
||||||
|
text: currentLine,
|
||||||
|
start: currentLineStart,
|
||||||
|
end: currentLineEnd,
|
||||||
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
return lines;
|
return lines;
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Similarly to browsers, does not trim all trailing whitespaces, but only those exceeding the `maxWidth`.
|
* Trims trailing whitespace that is exceeding the `maxWidth`.
|
||||||
|
*
|
||||||
|
* Used for the trailing visual line of a hard line, where some trailing
|
||||||
|
* whitespace may still be visible if it fits into the available width.
|
||||||
*/
|
*/
|
||||||
const trimLine = (line: string, font: FontString, maxWidth: number) => {
|
const trimLine = (
|
||||||
|
line: string,
|
||||||
|
start: number,
|
||||||
|
end: number,
|
||||||
|
font: FontString,
|
||||||
|
maxWidth: number,
|
||||||
|
): WrappedTextLine => {
|
||||||
const shouldTrimWhitespaces = getLineWidth(line, font) > maxWidth;
|
const shouldTrimWhitespaces = getLineWidth(line, font) > maxWidth;
|
||||||
|
|
||||||
if (!shouldTrimWhitespaces) {
|
if (!shouldTrimWhitespaces) {
|
||||||
return line;
|
return {
|
||||||
|
text: line,
|
||||||
|
start,
|
||||||
|
end,
|
||||||
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
// defensively default to `trimeEnd` in case the regex does not match
|
// defensively default to `trimeEnd` in case the regex does not match
|
||||||
@@ -543,7 +690,30 @@ const trimLine = (line: string, font: FontString, maxWidth: number) => {
|
|||||||
trimmedLineWidth = testLineWidth;
|
trimmedLineWidth = testLineWidth;
|
||||||
}
|
}
|
||||||
|
|
||||||
return trimmedLine;
|
return {
|
||||||
|
text: trimmedLine,
|
||||||
|
start,
|
||||||
|
end: end - (line.length - trimmedLine.length),
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Used for internal soft-wrap boundaries, where trailing whitespace should not
|
||||||
|
* survive into the rendered line even though it still exists in the original
|
||||||
|
* text.
|
||||||
|
*/
|
||||||
|
const trimLineEndAtSoftBreak = (
|
||||||
|
line: string,
|
||||||
|
start: number,
|
||||||
|
end: number,
|
||||||
|
): WrappedTextLine => {
|
||||||
|
const trimmedLine = line.trimEnd();
|
||||||
|
|
||||||
|
return {
|
||||||
|
text: trimmedLine,
|
||||||
|
start,
|
||||||
|
end: end - (line.length - trimmedLine.length),
|
||||||
|
};
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
@@ -392,3 +392,23 @@ export const canBecomePolygon = (
|
|||||||
(points.length === 3 && !pointsEqual(points[0], points[points.length - 1]))
|
(points.length === 3 && !pointsEqual(points[0], points[points.length - 1]))
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const isEligibleFrameChildType = (type: ElementOrToolType) => {
|
||||||
|
switch (type) {
|
||||||
|
case "rectangle":
|
||||||
|
case "diamond":
|
||||||
|
case "ellipse":
|
||||||
|
case "arrow":
|
||||||
|
case "line":
|
||||||
|
case "freedraw":
|
||||||
|
case "text":
|
||||||
|
case "image":
|
||||||
|
case "frame":
|
||||||
|
case "embeddable": {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
default: {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|||||||
@@ -303,19 +303,32 @@ export type PointsPositionUpdates = Map<
|
|||||||
{ point: LocalPoint; isDragging?: boolean }
|
{ point: LocalPoint; isDragging?: boolean }
|
||||||
>;
|
>;
|
||||||
|
|
||||||
|
export type CardinalityArrowhead =
|
||||||
|
| "cardinality_one"
|
||||||
|
| "cardinality_many"
|
||||||
|
| "cardinality_one_or_many"
|
||||||
|
| "cardinality_exactly_one"
|
||||||
|
| "cardinality_zero_or_one"
|
||||||
|
| "cardinality_zero_or_many";
|
||||||
|
|
||||||
|
export type ArrowheadLegacy =
|
||||||
|
| "dot"
|
||||||
|
| "crowfoot_one"
|
||||||
|
| "crowfoot_many"
|
||||||
|
| "crowfoot_one_or_many";
|
||||||
|
|
||||||
export type Arrowhead =
|
export type Arrowhead =
|
||||||
| "arrow"
|
| "arrow"
|
||||||
| "bar"
|
| "bar"
|
||||||
| "dot" // legacy. Do not use for new elements.
|
|
||||||
| "circle"
|
| "circle"
|
||||||
| "circle_outline"
|
| "circle_outline"
|
||||||
| "triangle"
|
| "triangle"
|
||||||
| "triangle_outline"
|
| "triangle_outline"
|
||||||
| "diamond"
|
| "diamond"
|
||||||
| "diamond_outline"
|
| "diamond_outline"
|
||||||
| "crowfoot_one"
|
| CardinalityArrowhead;
|
||||||
| "crowfoot_many"
|
|
||||||
| "crowfoot_one_or_many";
|
export type AnyArrowhead = Arrowhead | ArrowheadLegacy;
|
||||||
|
|
||||||
export type ExcalidrawLinearElement = _ExcalidrawElementBase &
|
export type ExcalidrawLinearElement = _ExcalidrawElementBase &
|
||||||
Readonly<{
|
Readonly<{
|
||||||
|
|||||||
@@ -124,6 +124,7 @@ const setElementShapesCacheEntry = <T extends ExcalidrawElement>(
|
|||||||
*/
|
*/
|
||||||
export function deconstructLinearOrFreeDrawElement(
|
export function deconstructLinearOrFreeDrawElement(
|
||||||
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
element: ExcalidrawLinearElement | ExcalidrawFreeDrawElement,
|
||||||
|
elementsMap: ElementsMap,
|
||||||
): [LineSegment<GlobalPoint>[], Curve<GlobalPoint>[]] {
|
): [LineSegment<GlobalPoint>[], Curve<GlobalPoint>[]] {
|
||||||
const cachedShape = getElementShapesCacheEntry(element, 0);
|
const cachedShape = getElementShapesCacheEntry(element, 0);
|
||||||
|
|
||||||
@@ -131,10 +132,7 @@ export function deconstructLinearOrFreeDrawElement(
|
|||||||
return cachedShape;
|
return cachedShape;
|
||||||
}
|
}
|
||||||
|
|
||||||
const ops = generateLinearCollisionShape(element) as {
|
const ops = generateLinearCollisionShape(element, elementsMap);
|
||||||
op: string;
|
|
||||||
data: number[];
|
|
||||||
}[];
|
|
||||||
const lines = [];
|
const lines = [];
|
||||||
const curves = [];
|
const curves = [];
|
||||||
|
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { arrayToMap } from "@excalidraw/common";
|
import { arrayToMap, reseed } from "@excalidraw/common";
|
||||||
import { type GlobalPoint, type LocalPoint, pointFrom } from "@excalidraw/math";
|
import { type GlobalPoint, type LocalPoint, pointFrom } from "@excalidraw/math";
|
||||||
import { Excalidraw } from "@excalidraw/excalidraw";
|
import { Excalidraw } from "@excalidraw/excalidraw";
|
||||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||||
@@ -12,6 +12,7 @@ import { hitElementItself } from "../src/collision";
|
|||||||
describe("check rotated elements can be hit:", () => {
|
describe("check rotated elements can be hit:", () => {
|
||||||
beforeEach(async () => {
|
beforeEach(async () => {
|
||||||
localStorage.clear();
|
localStorage.clear();
|
||||||
|
reseed(7);
|
||||||
await render(<Excalidraw handleKeyboardGlobally={true} />);
|
await render(<Excalidraw handleKeyboardGlobally={true} />);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -56,6 +57,7 @@ describe("hitElementItself cache", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
localStorage.clear();
|
localStorage.clear();
|
||||||
|
reseed(7);
|
||||||
await render(<Excalidraw handleKeyboardGlobally={true} />);
|
await render(<Excalidraw handleKeyboardGlobally={true} />);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -1,9 +1,8 @@
|
|||||||
/* eslint-disable no-lone-blocks */
|
/* eslint-disable no-lone-blocks */
|
||||||
import { generateKeyBetween } from "fractional-indexing";
|
|
||||||
|
|
||||||
import { arrayToMap } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
|
InvalidFractionalIndexError,
|
||||||
syncInvalidIndices,
|
syncInvalidIndices,
|
||||||
syncMovedIndices,
|
syncMovedIndices,
|
||||||
validateFractionalIndices,
|
validateFractionalIndices,
|
||||||
@@ -13,13 +12,34 @@ import { deepCopyElement } from "@excalidraw/element";
|
|||||||
|
|
||||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||||
|
|
||||||
|
import {
|
||||||
|
generateKeyBetween,
|
||||||
|
validateOrderKey,
|
||||||
|
} from "@excalidraw/fractional-indexing";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
ElementsMap,
|
ElementsMap,
|
||||||
ExcalidrawElement,
|
ExcalidrawElement,
|
||||||
FractionalIndex,
|
FractionalIndex,
|
||||||
} from "@excalidraw/element/types";
|
} from "@excalidraw/element/types";
|
||||||
|
|
||||||
import { InvalidFractionalIndexError } from "../src/fractionalIndex";
|
describe("fractional index format validation", () => {
|
||||||
|
it("should reject malformed base62 order keys", () => {
|
||||||
|
expect(() => validateOrderKey("a!")).toThrow();
|
||||||
|
expect(() => validateOrderKey("a_")).toThrow();
|
||||||
|
expect(() => validateOrderKey("a1!")).toThrow();
|
||||||
|
expect(() => validateOrderKey("a1_")).toThrow();
|
||||||
|
expect(() => validateOrderKey("zd0032")).toThrow();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should accept valid base62 order keys", () => {
|
||||||
|
expect(() => validateOrderKey("Zz")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("a0")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("a1")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("a1V")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("z".padEnd(28, "z"))).not.toThrow();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe("sync invalid indices with array order", () => {
|
describe("sync invalid indices with array order", () => {
|
||||||
describe("should NOT sync empty array", () => {
|
describe("should NOT sync empty array", () => {
|
||||||
@@ -104,6 +124,46 @@ describe("sync invalid indices with array order", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("should sync when fractional index is malformed", () => {
|
||||||
|
// "zd0032" has head "z" which requires length 28 per getIntegerLength,
|
||||||
|
// but the string is far too short, so validateOrderKey throws for it
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [{ id: "A", index: "zd0032" }],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: [],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [
|
||||||
|
{ id: "A", index: "a1" },
|
||||||
|
{ id: "B", index: "zd0032" },
|
||||||
|
{ id: "C", index: "a3" },
|
||||||
|
],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: ["A", "C"],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [{ id: "A", index: "a!" }],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: [],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [
|
||||||
|
{ id: "A", index: "a1" },
|
||||||
|
{ id: "B", index: "a!" },
|
||||||
|
{ id: "C", index: "a2" },
|
||||||
|
],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: ["A", "C"],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe("should sync when fractional indices are duplicated", () => {
|
describe("should sync when fractional indices are duplicated", () => {
|
||||||
testInvalidIndicesSync({
|
testInvalidIndicesSync({
|
||||||
elements: [
|
elements: [
|
||||||
|
|||||||
@@ -2,15 +2,24 @@ import {
|
|||||||
convertToExcalidrawElements,
|
convertToExcalidrawElements,
|
||||||
Excalidraw,
|
Excalidraw,
|
||||||
} from "@excalidraw/excalidraw";
|
} from "@excalidraw/excalidraw";
|
||||||
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||||
import { Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
|
import { Keyboard, Pointer, UI } from "@excalidraw/excalidraw/tests/helpers/ui";
|
||||||
|
import { getTextEditor } from "@excalidraw/excalidraw/tests/queries/dom";
|
||||||
import {
|
import {
|
||||||
getCloneByOrigId,
|
getCloneByOrigId,
|
||||||
render,
|
render,
|
||||||
} from "@excalidraw/excalidraw/tests/test-utils";
|
} from "@excalidraw/excalidraw/tests/test-utils";
|
||||||
|
|
||||||
import type { ExcalidrawElement } from "../src/types";
|
import { getSelectedElements } from "@excalidraw/excalidraw/scene";
|
||||||
|
|
||||||
|
import { elementOverlapsWithFrame } from "../src/frame";
|
||||||
|
|
||||||
|
import type {
|
||||||
|
ExcalidrawElement,
|
||||||
|
ExcalidrawFrameLikeElement,
|
||||||
|
} from "../src/types";
|
||||||
|
|
||||||
const { h } = window;
|
const { h } = window;
|
||||||
const mouse = new Pointer("mouse");
|
const mouse = new Pointer("mouse");
|
||||||
@@ -125,6 +134,250 @@ describe("adding elements to frames", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should treat an element fully containing a frame as overlapping the frame", () => {
|
||||||
|
const containingRect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: -50,
|
||||||
|
y: -50,
|
||||||
|
width: 250,
|
||||||
|
height: 250,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([containingRect, frame]);
|
||||||
|
|
||||||
|
expect(
|
||||||
|
elementOverlapsWithFrame(
|
||||||
|
containingRect,
|
||||||
|
frame as ExcalidrawFrameLikeElement,
|
||||||
|
arrayToMap(h.elements),
|
||||||
|
),
|
||||||
|
).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not add a newly created element to a frame behind a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, cover]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) => element.id !== frame.id && element.id !== cover.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(null);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
cover.id,
|
||||||
|
createdElement?.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should add a newly created element to a frame over a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([cover, frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) => element.id !== frame.id && element.id !== cover.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should highlight the target frame while creating a new element", () => {
|
||||||
|
API.setElements([frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||||
|
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should highlight the target frame while hovering with a creation tool", () => {
|
||||||
|
API.setElements([frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||||
|
|
||||||
|
mouse.moveTo(200, 200);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not add grid-snapped text outside the frame to the clicked frame", async () => {
|
||||||
|
const offsetFrame = API.createElement({
|
||||||
|
id: "offsetFrame",
|
||||||
|
type: "frame",
|
||||||
|
x: 10,
|
||||||
|
y: 0,
|
||||||
|
width: 150,
|
||||||
|
height: 150,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([offsetFrame]);
|
||||||
|
API.setAppState({
|
||||||
|
gridModeEnabled: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
UI.clickTool("text");
|
||||||
|
mouse.clickAt(12, 0);
|
||||||
|
|
||||||
|
await getTextEditor();
|
||||||
|
|
||||||
|
const createdText = h.elements.find(
|
||||||
|
(element) => element.id !== offsetFrame.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdText?.x).toBe(0);
|
||||||
|
expect(createdText?.y).toBe(0);
|
||||||
|
expect(createdText?.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should add a newly created element to a frame behind another frame", () => {
|
||||||
|
const lockedFrame = API.createElement({
|
||||||
|
id: "lockedFrame",
|
||||||
|
type: "frame",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
locked: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, lockedFrame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) => element.id !== frame.id && element.id !== lockedFrame.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should insert a newly created frame child just below its frame", () => {
|
||||||
|
const frameChildUnderCursor = API.createElement({
|
||||||
|
id: "frameChildUnderCursor",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 20,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frameChildUnderCursor, otherFrameChild, frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) =>
|
||||||
|
element.id !== frame.id &&
|
||||||
|
element.id !== frameChildUnderCursor.id &&
|
||||||
|
element.id !== otherFrameChild.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frameChildUnderCursor.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
createdElement?.id,
|
||||||
|
frame.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should insert a newly created frame child above the highest frame child", () => {
|
||||||
|
const frameChildUnderCursor = API.createElement({
|
||||||
|
id: "frameChildUnderCursor",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 20,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, frameChildUnderCursor, otherFrameChild]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) =>
|
||||||
|
element.id !== frame.id &&
|
||||||
|
element.id !== frameChildUnderCursor.id &&
|
||||||
|
element.id !== otherFrameChild.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChildUnderCursor.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
createdElement?.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
const commonTestCases = async (
|
const commonTestCases = async (
|
||||||
func: typeof resizeFrameOverElement | typeof dragElementIntoFrame,
|
func: typeof resizeFrameOverElement | typeof dragElementIntoFrame,
|
||||||
) => {
|
) => {
|
||||||
@@ -415,6 +668,345 @@ describe("adding elements to frames", () => {
|
|||||||
describe("dragging elements into the frame", async () => {
|
describe("dragging elements into the frame", async () => {
|
||||||
await commonTestCases(dragElementIntoFrame);
|
await commonTestCases(dragElementIntoFrame);
|
||||||
|
|
||||||
|
it("should add a dragged element fully containing the frame", () => {
|
||||||
|
const containingRect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 220,
|
||||||
|
y: 20,
|
||||||
|
width: 300,
|
||||||
|
height: 300,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, containingRect]);
|
||||||
|
|
||||||
|
dragElementIntoFrame(frame, containingRect);
|
||||||
|
|
||||||
|
expect(API.getElement(containingRect).frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should drag an element into a frame", () => {
|
||||||
|
API.setElements([rect2, frame]);
|
||||||
|
|
||||||
|
dragElementIntoFrame(frame, rect2);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should layer a dragged element above the highest frame child", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, frameChild, rect2]);
|
||||||
|
|
||||||
|
dragElementIntoFrame(frame, rect2);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
rect2.id,
|
||||||
|
]);
|
||||||
|
expect(rect2.index! > frameChild.index!).toBe(true);
|
||||||
|
expect(rect2.index! > frame.index!).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should preview a dragged element above the highest frame child before pointerup", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([rect2, frame, frameChild]);
|
||||||
|
API.setSelectedElements([rect2]);
|
||||||
|
API.updateElement(rect2, {
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
});
|
||||||
|
|
||||||
|
const getRenderableElementIds = (
|
||||||
|
selectedElementsAreBeingDragged: boolean,
|
||||||
|
) => {
|
||||||
|
return h.app.renderer
|
||||||
|
.getRenderableElements({
|
||||||
|
zoom: h.state.zoom,
|
||||||
|
offsetLeft: 0,
|
||||||
|
offsetTop: 0,
|
||||||
|
scrollX: 0,
|
||||||
|
scrollY: 0,
|
||||||
|
height: 1000,
|
||||||
|
width: 1000,
|
||||||
|
editingTextElement: h.state.editingTextElement,
|
||||||
|
newElement: h.state.newElement,
|
||||||
|
selectedElements: getSelectedElements(h.elements, h.state),
|
||||||
|
selectedElementsAreBeingDragged,
|
||||||
|
frameToHighlight: frame as ExcalidrawFrameLikeElement,
|
||||||
|
})
|
||||||
|
.visibleElements.map((element) => element.id);
|
||||||
|
};
|
||||||
|
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
rect2.id,
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
]);
|
||||||
|
expect(getRenderableElementIds(false)).toEqual([
|
||||||
|
rect2.id,
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
]);
|
||||||
|
expect(getRenderableElementIds(true)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
rect2.id,
|
||||||
|
]);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
rect2.id,
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
]);
|
||||||
|
expect(rect2.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not preview reorder dragged elements already in the highlighted frame", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 40,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frameChild, frame, otherFrameChild]);
|
||||||
|
API.setSelectedElements([frameChild]);
|
||||||
|
|
||||||
|
const renderableElementIds = h.app.renderer
|
||||||
|
.getRenderableElements({
|
||||||
|
zoom: h.state.zoom,
|
||||||
|
offsetLeft: 0,
|
||||||
|
offsetTop: 0,
|
||||||
|
scrollX: 0,
|
||||||
|
scrollY: 0,
|
||||||
|
height: 1000,
|
||||||
|
width: 1000,
|
||||||
|
editingTextElement: h.state.editingTextElement,
|
||||||
|
newElement: h.state.newElement,
|
||||||
|
selectedElements: getSelectedElements(h.elements, h.state),
|
||||||
|
selectedElementsAreBeingDragged: true,
|
||||||
|
frameToHighlight: frame as ExcalidrawFrameLikeElement,
|
||||||
|
})
|
||||||
|
.visibleElements.map((element) => element.id);
|
||||||
|
|
||||||
|
expect(renderableElementIds).toEqual([
|
||||||
|
frameChild.id,
|
||||||
|
frame.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should put a dragged mixed selection above the highest frame child", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
boundElements: [{ id: "boundText", type: "text" }],
|
||||||
|
});
|
||||||
|
const boundText = API.createElement({
|
||||||
|
id: "boundText",
|
||||||
|
type: "text",
|
||||||
|
x: 50,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
containerId: frameChild.id,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 80,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const nonFrameElement = API.createElement({
|
||||||
|
id: "nonFrameElement",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 155,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([
|
||||||
|
frame,
|
||||||
|
frameChild,
|
||||||
|
boundText,
|
||||||
|
otherFrameChild,
|
||||||
|
nonFrameElement,
|
||||||
|
]);
|
||||||
|
API.setSelectedElements([frameChild, nonFrameElement]);
|
||||||
|
|
||||||
|
mouse.downAt(
|
||||||
|
nonFrameElement.x + nonFrameElement.width / 2,
|
||||||
|
nonFrameElement.y + nonFrameElement.height / 2,
|
||||||
|
);
|
||||||
|
mouse.moveTo(frame.x + frame.width - 5, nonFrameElement.y + 10);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
expect(frameChild.frameId).toBe(frame.id);
|
||||||
|
expect(boundText.frameId).toBe(frame.id);
|
||||||
|
expect(nonFrameElement.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
frameChild.id,
|
||||||
|
boundText.id,
|
||||||
|
nonFrameElement.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not reorder dragged elements already in the highlighted frame", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 80,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, frameChild, otherFrameChild]);
|
||||||
|
API.setSelectedElements([frameChild]);
|
||||||
|
|
||||||
|
mouse.downAt(
|
||||||
|
frameChild.x + frameChild.width / 2,
|
||||||
|
frameChild.y + frameChild.height / 2,
|
||||||
|
);
|
||||||
|
mouse.moveTo(frameChild.x + frameChild.width / 2 + 5, frameChild.y + 10);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
expect(frameChild.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not drag an element into a frame behind a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
API.setElements([frame, cover, rect2]);
|
||||||
|
|
||||||
|
mouse.clickAt(rect2.x, rect2.y);
|
||||||
|
mouse.downAt(rect2.x + rect2.width / 2, rect2.y + rect2.height / 2);
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
mouse.upAt(20, 20);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should drag an element into a frame over a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
API.setElements([cover, rect2, frame]);
|
||||||
|
|
||||||
|
mouse.clickAt(rect2.x, rect2.y);
|
||||||
|
mouse.downAt(rect2.x + rect2.width / 2, rect2.y + rect2.height / 2);
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
mouse.upAt(20, 20);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should keep dragging a frame child over a non-frame element above its frame", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 20,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frameChild, frame, cover]);
|
||||||
|
API.setSelectedElements([frameChild]);
|
||||||
|
|
||||||
|
mouse.downAt(
|
||||||
|
frameChild.x + frameChild.width / 2,
|
||||||
|
frameChild.y + frameChild.height / 2,
|
||||||
|
);
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||||
|
|
||||||
|
mouse.upAt(20, 20);
|
||||||
|
|
||||||
|
expect(frameChild.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
it.skip("should drag element inside, duplicate it and keep it in frame", () => {
|
it.skip("should drag element inside, duplicate it and keep it in frame", () => {
|
||||||
API.setElements([frame, rect2]);
|
API.setElements([frame, rect2]);
|
||||||
|
|
||||||
|
|||||||
@@ -326,19 +326,59 @@ describe("normalizeElementsOrder", () => {
|
|||||||
]),
|
]),
|
||||||
[
|
[
|
||||||
"BA_rect1",
|
"BA_rect1",
|
||||||
|
"CBA_rect3",
|
||||||
|
"CBA_rect7",
|
||||||
"BA_rect5",
|
"BA_rect5",
|
||||||
"BA_rect6",
|
"BA_rect6",
|
||||||
"A_rect2",
|
"A_rect2",
|
||||||
"A_rect5",
|
"A_rect5",
|
||||||
"CBA_rect3",
|
|
||||||
"CBA_rect7",
|
|
||||||
"rect4",
|
"rect4",
|
||||||
"X_rect8",
|
"X_rect8",
|
||||||
"X_rect11",
|
|
||||||
"YX_rect10",
|
"YX_rect10",
|
||||||
|
"X_rect11",
|
||||||
"rect9",
|
"rect9",
|
||||||
],
|
],
|
||||||
);
|
);
|
||||||
|
assertOrder(
|
||||||
|
normalizeElementOrder([
|
||||||
|
API.createElement({
|
||||||
|
id: "A_rect1",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["A"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "CBA_rect2",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["C", "B", "A"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "A_rect3",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["A"],
|
||||||
|
}),
|
||||||
|
]),
|
||||||
|
["A_rect1", "CBA_rect2", "A_rect3"],
|
||||||
|
);
|
||||||
|
assertOrder(
|
||||||
|
normalizeElementOrder([
|
||||||
|
API.createElement({
|
||||||
|
id: "abcT_rect1",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["ab", "c", "T"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "abcT_rect2",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["a", "bc", "T"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "abcT_rect3",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["ab", "c", "T"],
|
||||||
|
}),
|
||||||
|
]),
|
||||||
|
["abcT_rect1", "abcT_rect3", "abcT_rect2"],
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
// TODO
|
// TODO
|
||||||
|
|||||||
@@ -1,4 +1,8 @@
|
|||||||
import { wrapText, parseTokens } from "../src/textWrapping";
|
import {
|
||||||
|
getWrappedTextLines,
|
||||||
|
parseTokens,
|
||||||
|
wrapText,
|
||||||
|
} from "../src/textWrapping";
|
||||||
|
|
||||||
import type { FontString } from "../src/types";
|
import type { FontString } from "../src/types";
|
||||||
|
|
||||||
@@ -102,6 +106,71 @@ describe("Test wrapText", () => {
|
|||||||
expect(res2).toBe(`\tA)\none\ntab\n- two\ntabs\n- 8\nspace\ns`);
|
expect(res2).toBe(`\tA)\none\ntab\n- two\ntabs\n- 8\nspace\ns`);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should retain original text offsets for wrapped lines", () => {
|
||||||
|
expect(getWrappedTextLines("Hello World!", font, 60)).toEqual([
|
||||||
|
{
|
||||||
|
text: "Hello",
|
||||||
|
start: 0,
|
||||||
|
end: 5,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
text: "World!",
|
||||||
|
start: 6,
|
||||||
|
end: 12,
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should exclude whitespace trimmed away at soft-wrap boundaries from line offsets", () => {
|
||||||
|
expect(getWrappedTextLines(" Hello World", font, 90)).toEqual([
|
||||||
|
{
|
||||||
|
text: " Hello",
|
||||||
|
start: 0,
|
||||||
|
end: 7,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
text: "World",
|
||||||
|
start: 9,
|
||||||
|
end: 14,
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should retain offsets when wrapping a single long token", () => {
|
||||||
|
expect(getWrappedTextLines("Excalidraw", font, 50)).toEqual([
|
||||||
|
{
|
||||||
|
text: "Excal",
|
||||||
|
start: 0,
|
||||||
|
end: 5,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
text: "idraw",
|
||||||
|
start: 5,
|
||||||
|
end: 10,
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should preserve empty hard lines in metadata", () => {
|
||||||
|
expect(getWrappedTextLines("A\n\nB", font, 100)).toEqual([
|
||||||
|
{
|
||||||
|
text: "A",
|
||||||
|
start: 0,
|
||||||
|
end: 1,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
text: "",
|
||||||
|
start: 2,
|
||||||
|
end: 2,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
text: "B",
|
||||||
|
start: 3,
|
||||||
|
end: 4,
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
describe("When text is CJK", () => {
|
describe("When text is CJK", () => {
|
||||||
it("should break each CJK character when width is very small", () => {
|
it("should break each CJK character when width is very small", () => {
|
||||||
// "안녕하세요" (Hangul) + "こんにちは世界" (Hiragana, Kanji) + "コンニチハ" (Katakana) + "你好" (Han) = "Hello Hello World Hello Hi"
|
// "안녕하세요" (Hangul) + "こんにちは世界" (Hiragana, Kanji) + "コンニチハ" (Katakana) + "你好" (Han) = "Hello Hello World Hello Hi"
|
||||||
|
|||||||
@@ -18,22 +18,13 @@ Please add the latest change on the top under the correct section.
|
|||||||
### Breaking changes
|
### Breaking changes
|
||||||
|
|
||||||
- Renamed the `excalidrawAPI` prop to `onExcalidrawAPI`.
|
- Renamed the `excalidrawAPI` prop to `onExcalidrawAPI`.
|
||||||
|
- `onExcalidrawAPI` is now called on mount (instead of during constructor), and later on unmount (with `null` value). The API may be removed altogether in the future (you can use `onMount` & `onUmount` to manage the `ExcalidrawAPI` object (e.g. to cache it to a global state), already).
|
||||||
|
|
||||||
### Features
|
### Features
|
||||||
|
|
||||||
- Added `onMount` and `onInitialize` props. `onMount` receives `{ excalidrawAPI, container }` once the editor root is mounted, and `onInitialize` fires once the initial scene has loaded.
|
- Added `ExcalidrawAPI.isDestroyed` flag. Set to `true` once the editor unmounts. Calling any `get*` method, `onStateChange`, or `onEvent` on a destroyed API instance will throw in development and `console.error` in production. The `ExcalidrawAPI` will be reset to `null` on umount, but to be extra safe, you should check `ExcalidrawAPI.isDestroyed` before calling these methods to guard against subtle race conditions in your code.
|
||||||
|
|
||||||
```tsx
|
- Added `onMount`, `onInitialize`, and `onUnmount` props. `onMount` receives `{ excalidrawAPI, container }` once the editor root is mounted. `onInitialize` fires once the initial scene has loaded. `onUnmount` fires just before unmounting.
|
||||||
<Excalidraw
|
|
||||||
onMount={({ excalidrawAPI, container }) => {
|
|
||||||
console.log(container);
|
|
||||||
excalidrawAPI.scrollToContent();
|
|
||||||
}}
|
|
||||||
onInitialize={(api) => {
|
|
||||||
api.refresh();
|
|
||||||
}}
|
|
||||||
/>
|
|
||||||
```
|
|
||||||
|
|
||||||
- Same events are also accessible imperatively through `api.onEvent(...)`.
|
- Same events are also accessible imperatively through `api.onEvent(...)`.
|
||||||
|
|
||||||
@@ -41,7 +32,6 @@ Please add the latest change on the top under the correct section.
|
|||||||
<Excalidraw
|
<Excalidraw
|
||||||
onExcalidrawAPI={(api) => {
|
onExcalidrawAPI={(api) => {
|
||||||
api.onEvent("editor:mount", ({ excalidrawAPI, container }) => {
|
api.onEvent("editor:mount", ({ excalidrawAPI, container }) => {
|
||||||
excalidrawAPI.scrollToContent();
|
|
||||||
console.log(container);
|
console.log(container);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -54,7 +44,9 @@ Please add the latest change on the top under the correct section.
|
|||||||
|
|
||||||
Note that in future releases, most, if not all, `excalidrawAPI.on*` subscriptions will be removed in favor of `excalidrawAPI.onEvent(name)`.
|
Note that in future releases, most, if not all, `excalidrawAPI.on*` subscriptions will be removed in favor of `excalidrawAPI.onEvent(name)`.
|
||||||
|
|
||||||
- Exported `ExcalidrawAPIProvider`, `useExcalidrawAPI`, and `useAppStateValue` from the package entrypoint. The imperative API also now exposes `onStateChange`.
|
- Also added `"editor:unmount"` lifecycle event, only accessible via `api.onEvent("editor:unmount")`.
|
||||||
|
|
||||||
|
- Exported `<ExcalidrawAPIProvider/>`, `useExcalidrawAPI()`, `useAppStateValue(prop | props | selectorFunction)`, and `useOnExcalidrawStateChange(prop | props | selectorFunction, callback)` from the package. The imperative API also now exposes `onStateChange(prop | props | selectorFunction, callback?)`, and `onEvent(name, callback)`.
|
||||||
|
|
||||||
```tsx
|
```tsx
|
||||||
<ExcalidrawAPIProvider>
|
<ExcalidrawAPIProvider>
|
||||||
@@ -63,6 +55,9 @@ Please add the latest change on the top under the correct section.
|
|||||||
</ExcalidrawAPIProvider>;
|
</ExcalidrawAPIProvider>;
|
||||||
|
|
||||||
function Logger() {
|
function Logger() {
|
||||||
|
// initially null before the ExcalidrawAPIProvider initializes ater
|
||||||
|
// <Excalidraw/> renders
|
||||||
|
// When <Excalidraw/> unmounts, is reset back to null
|
||||||
const api = useExcalidrawAPI();
|
const api = useExcalidrawAPI();
|
||||||
|
|
||||||
useAppStateValue("viewModeEnabled", (viewModeEnabled) => {
|
useAppStateValue("viewModeEnabled", (viewModeEnabled) => {
|
||||||
|
|||||||
+111
-14
@@ -1,10 +1,10 @@
|
|||||||
# Excalidraw
|
# Excalidraw
|
||||||
|
|
||||||
**Excalidraw** is exported as a component to be directly embedded in your project.
|
**Excalidraw** is exported as a React component that you can embed directly in your app.
|
||||||
|
|
||||||
## Installation
|
## Installation
|
||||||
|
|
||||||
Use `npm` or `yarn` to install the package.
|
Install the package together with its React peer dependencies.
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
npm install react react-dom @excalidraw/excalidraw
|
npm install react react-dom @excalidraw/excalidraw
|
||||||
@@ -12,34 +12,131 @@ npm install react react-dom @excalidraw/excalidraw
|
|||||||
yarn add react react-dom @excalidraw/excalidraw
|
yarn add react react-dom @excalidraw/excalidraw
|
||||||
```
|
```
|
||||||
|
|
||||||
> **Note**: If you don't want to wait for the next stable release and try out the unreleased changes, use `@excalidraw/excalidraw@next`.
|
> **Note**: If you want to try unreleased changes, use `@excalidraw/excalidraw@next`.
|
||||||
|
|
||||||
#### Self-hosting fonts
|
## Quick start
|
||||||
|
|
||||||
By default, Excalidraw will try to download all the used fonts from the [CDN](https://esm.run/@excalidraw/excalidraw/dist/prod).
|
The minimum working setup has two easy-to-miss requirements:
|
||||||
|
|
||||||
For self-hosting purposes, you'll have to copy the content of the folder `node_modules/@excalidraw/excalidraw/dist/prod/fonts` to the path where your assets should be served from (i.e. `public/` directory in your project). In that case, you should also set `window.EXCALIDRAW_ASSET_PATH` to the very same path, i.e. `/` in case it's in the root:
|
1. Import the package CSS:
|
||||||
|
|
||||||
```js
|
```ts
|
||||||
<script>window.EXCALIDRAW_ASSET_PATH = "/";</script>
|
import "@excalidraw/excalidraw/index.css";
|
||||||
```
|
```
|
||||||
|
|
||||||
### Dimensions of Excalidraw
|
2. Render Excalidraw inside a container with a non-zero height.
|
||||||
|
|
||||||
Excalidraw takes _100%_ of `width` and `height` of the containing block so make sure the container in which you render Excalidraw has non zero dimensions.
|
```tsx
|
||||||
|
import { Excalidraw } from "@excalidraw/excalidraw";
|
||||||
|
import "@excalidraw/excalidraw/index.css";
|
||||||
|
|
||||||
|
export default function App() {
|
||||||
|
return (
|
||||||
|
<div style={{ height: "100vh" }}>
|
||||||
|
<Excalidraw />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Excalidraw fills `100%` of the width and height of its parent. If the parent has no height, the canvas will not be visible.
|
||||||
|
|
||||||
|
## Next.js / SSR frameworks
|
||||||
|
|
||||||
|
Excalidraw should be rendered on the client. In SSR frameworks such as Next.js, use a client component and load it dynamically with SSR disabled.
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
// app/components/ExcalidrawClient.tsx
|
||||||
|
"use client";
|
||||||
|
|
||||||
|
import { Excalidraw } from "@excalidraw/excalidraw";
|
||||||
|
import "@excalidraw/excalidraw/index.css";
|
||||||
|
|
||||||
|
export default function ExcalidrawClient() {
|
||||||
|
return (
|
||||||
|
<div style={{ height: "100vh" }}>
|
||||||
|
<Excalidraw />
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
// app/page.tsx
|
||||||
|
import dynamic from "next/dynamic";
|
||||||
|
|
||||||
|
const ExcalidrawClient = dynamic(
|
||||||
|
() => import("./components/ExcalidrawClient"),
|
||||||
|
{ ssr: false },
|
||||||
|
);
|
||||||
|
|
||||||
|
export default function Page() {
|
||||||
|
return <ExcalidrawClient />;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
See the local examples for complete setups:
|
||||||
|
|
||||||
|
- [examples/with-nextjs](https://github.com/excalidraw/excalidraw/tree/master/examples/with-nextjs)
|
||||||
|
- [examples/with-script-in-browser](https://github.com/excalidraw/excalidraw/tree/master/examples/with-script-in-browser)
|
||||||
|
|
||||||
|
## LLM / agent tips
|
||||||
|
|
||||||
|
If an LLM or coding agent is setting up Excalidraw, these shortcuts usually save more time than re-prompting:
|
||||||
|
|
||||||
|
- Start with a plain `<Excalidraw />` in a `100vh` container. Add refs, `initialData`, persistence, or custom UI only after the base embed works.
|
||||||
|
- If the canvas is blank, check the CSS import and parent height first. Those are the two most common integration failures.
|
||||||
|
- In Next.js or other SSR frameworks, assume client-only rendering first. Use `"use client"` and `dynamic(..., { ssr: false })` before debugging hydration or `window is not defined` errors.
|
||||||
|
- If imports or entrypoints are unclear, inspect `node_modules/@excalidraw/excalidraw/package.json`. The installed package exports are the source of truth.
|
||||||
|
- Do not set `window.EXCALIDRAW_ASSET_PATH` unless you are intentionally self-hosting fonts/assets.
|
||||||
|
- When docs and generated code drift, copy the nearest working example from this repo, especially `examples/with-nextjs` or `examples/with-script-in-browser`.
|
||||||
|
|
||||||
|
## Migrating to `@excalidraw/excalidraw@0.18.x`
|
||||||
|
|
||||||
|
Version `0.18.x` removes the old `types/`-prefixed deep import paths. If you were importing types from `@excalidraw/excalidraw/types/...`, switch to the new type-only subpaths below.
|
||||||
|
|
||||||
|
| Old path | New path |
|
||||||
|
| --- | --- |
|
||||||
|
| `@excalidraw/excalidraw/types/data/transform.js` | `@excalidraw/excalidraw/element/transform` |
|
||||||
|
| `@excalidraw/excalidraw/types/data/types.js` | `@excalidraw/excalidraw/data/types` |
|
||||||
|
| `@excalidraw/excalidraw/types/element/types.js` | `@excalidraw/excalidraw/element/types` |
|
||||||
|
| `@excalidraw/excalidraw/types/utility-types.js` | `@excalidraw/excalidraw/common/utility-types` |
|
||||||
|
| `@excalidraw/excalidraw/types/types.js` | `@excalidraw/excalidraw/types` |
|
||||||
|
|
||||||
|
Drop the `.js` extension. The new package `exports` map resolves these paths without it.
|
||||||
|
|
||||||
|
These deep subpaths are for `import type` only. Runtime imports should come from the package root, plus `@excalidraw/excalidraw/index.css` for styles.
|
||||||
|
|
||||||
|
For example:
|
||||||
|
|
||||||
|
```ts
|
||||||
|
import { exportToSvg } from "@excalidraw/excalidraw";
|
||||||
|
```
|
||||||
|
|
||||||
|
## Self-hosting fonts
|
||||||
|
|
||||||
|
By default, Excalidraw downloads the fonts it needs from the [CDN](https://esm.run/@excalidraw/excalidraw/dist/prod).
|
||||||
|
|
||||||
|
For self-hosting, copy the contents of `node_modules/@excalidraw/excalidraw/dist/prod/fonts` into the path where your app serves static assets, for example `public/`. Then set `window.EXCALIDRAW_ASSET_PATH` to that same path:
|
||||||
|
|
||||||
|
```html
|
||||||
|
<script>
|
||||||
|
window.EXCALIDRAW_ASSET_PATH = "/";
|
||||||
|
</script>
|
||||||
|
```
|
||||||
|
|
||||||
## Demo
|
## Demo
|
||||||
|
|
||||||
Go to [CodeSandbox](https://codesandbox.io/p/sandbox/github/excalidraw/excalidraw/tree/master/examples/with-script-in-browser) example.
|
Try the [CodeSandbox example](https://codesandbox.io/p/sandbox/github/excalidraw/excalidraw/tree/master/examples/with-script-in-browser).
|
||||||
|
|
||||||
## Integration
|
## Integration
|
||||||
|
|
||||||
Head over to the [docs](https://docs.excalidraw.com/docs/@excalidraw/excalidraw/integration).
|
Read the [integration docs](https://docs.excalidraw.com/docs/@excalidraw/excalidraw/integration).
|
||||||
|
|
||||||
## API
|
## API
|
||||||
|
|
||||||
Head over to the [docs](https://docs.excalidraw.com/docs/@excalidraw/excalidraw/api).
|
Read the [API docs](https://docs.excalidraw.com/docs/@excalidraw/excalidraw/api).
|
||||||
|
|
||||||
## Contributing
|
## Contributing
|
||||||
|
|
||||||
Head over to the [docs](https://docs.excalidraw.com/docs/@excalidraw/excalidraw/contributing).
|
Read the [contributing docs](https://docs.excalidraw.com/docs/@excalidraw/excalidraw/contributing).
|
||||||
|
|||||||
@@ -0,0 +1,147 @@
|
|||||||
|
import {
|
||||||
|
getElementsInGroup,
|
||||||
|
isSomeElementSelected,
|
||||||
|
makeNextSelectedElementIds,
|
||||||
|
selectGroupsForSelectedElements,
|
||||||
|
} from "@excalidraw/element";
|
||||||
|
import { CaptureUpdateAction } from "@excalidraw/element";
|
||||||
|
import { KEYS, isWritableElement, updateActiveTool } from "@excalidraw/common";
|
||||||
|
|
||||||
|
import type { GroupId } from "@excalidraw/element/types";
|
||||||
|
|
||||||
|
import { register } from "./register";
|
||||||
|
|
||||||
|
import type { AppClassProperties, AppState } from "../types";
|
||||||
|
|
||||||
|
const getNextActiveTool = (
|
||||||
|
appState: Readonly<AppState>,
|
||||||
|
app: AppClassProperties,
|
||||||
|
) => {
|
||||||
|
if (appState.activeTool.type === "eraser") {
|
||||||
|
return updateActiveTool(appState, {
|
||||||
|
...(appState.activeTool.lastActiveTool || {
|
||||||
|
type: app.state.preferredSelectionTool.type,
|
||||||
|
}),
|
||||||
|
lastActiveToolBeforeEraser: null,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
return updateActiveTool(appState, {
|
||||||
|
type: app.state.preferredSelectionTool.type,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
|
const getParentEditingGroupId = (
|
||||||
|
appState: Readonly<AppState>,
|
||||||
|
app: AppClassProperties,
|
||||||
|
selectedElementIds: AppState["selectedElementIds"],
|
||||||
|
): GroupId | null => {
|
||||||
|
if (!appState.editingGroupId) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
const nonDeletedElements = app.scene.getNonDeletedElements();
|
||||||
|
const selectedElements = app.scene.getSelectedElements({
|
||||||
|
selectedElementIds,
|
||||||
|
elements: nonDeletedElements,
|
||||||
|
});
|
||||||
|
const candidateElements = selectedElements.length
|
||||||
|
? selectedElements
|
||||||
|
: getElementsInGroup(nonDeletedElements, appState.editingGroupId);
|
||||||
|
|
||||||
|
for (const element of candidateElements) {
|
||||||
|
const editingGroupIndex = element.groupIds.indexOf(appState.editingGroupId);
|
||||||
|
if (editingGroupIndex !== -1 && element.groupIds[editingGroupIndex + 1]) {
|
||||||
|
return element.groupIds[editingGroupIndex + 1] as GroupId;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
export const actionDeselect = register({
|
||||||
|
name: "deselect",
|
||||||
|
label: "",
|
||||||
|
trackEvent: false,
|
||||||
|
perform: (_elements, appState, _, app) => {
|
||||||
|
const activeTool = getNextActiveTool(appState, app);
|
||||||
|
|
||||||
|
if (appState.editingGroupId) {
|
||||||
|
const nonDeletedElements = app.scene.getNonDeletedElements();
|
||||||
|
const selectedElementIds =
|
||||||
|
Object.keys(appState.selectedElementIds).length > 0
|
||||||
|
? appState.selectedElementIds
|
||||||
|
: getElementsInGroup(
|
||||||
|
nonDeletedElements,
|
||||||
|
appState.editingGroupId,
|
||||||
|
).reduce((acc, element) => {
|
||||||
|
acc[element.id] = true;
|
||||||
|
return acc;
|
||||||
|
}, {} as Record<string, true>);
|
||||||
|
|
||||||
|
return {
|
||||||
|
appState: {
|
||||||
|
...appState,
|
||||||
|
...selectGroupsForSelectedElements(
|
||||||
|
{
|
||||||
|
editingGroupId: getParentEditingGroupId(
|
||||||
|
appState,
|
||||||
|
app,
|
||||||
|
selectedElementIds,
|
||||||
|
),
|
||||||
|
selectedElementIds,
|
||||||
|
},
|
||||||
|
nonDeletedElements,
|
||||||
|
appState,
|
||||||
|
app,
|
||||||
|
),
|
||||||
|
activeEmbeddable: null,
|
||||||
|
activeTool,
|
||||||
|
selectedLinearElement: null,
|
||||||
|
selectionElement: null,
|
||||||
|
showHyperlinkPopup: false,
|
||||||
|
suggestedBinding: null,
|
||||||
|
frameToHighlight: null,
|
||||||
|
},
|
||||||
|
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
appState: {
|
||||||
|
...appState,
|
||||||
|
activeEmbeddable: null,
|
||||||
|
activeTool,
|
||||||
|
editingGroupId: null,
|
||||||
|
selectedElementIds: makeNextSelectedElementIds({}, appState),
|
||||||
|
selectedGroupIds: {},
|
||||||
|
selectedLinearElement: null,
|
||||||
|
selectionElement: null,
|
||||||
|
showHyperlinkPopup: false,
|
||||||
|
suggestedBinding: null,
|
||||||
|
frameToHighlight: null,
|
||||||
|
},
|
||||||
|
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
keyTest: (event, appState, _, app) => {
|
||||||
|
if (event.key !== KEYS.ESCAPE) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (isWritableElement(event.target)) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
return (
|
||||||
|
!appState.newElement &&
|
||||||
|
appState.multiElement === null &&
|
||||||
|
!appState.selectedLinearElement?.isEditing &&
|
||||||
|
(appState.activeEmbeddable !== null ||
|
||||||
|
appState.activeTool.type !== app.state.preferredSelectionTool.type ||
|
||||||
|
!!appState.editingGroupId ||
|
||||||
|
!!appState.selectedLinearElement ||
|
||||||
|
isSomeElementSelected(app.scene.getNonDeletedElements(), appState))
|
||||||
|
);
|
||||||
|
},
|
||||||
|
});
|
||||||
@@ -399,7 +399,7 @@ export const actionSaveFileToDisk = register({
|
|||||||
appState: {
|
appState: {
|
||||||
openDialog: null,
|
openDialog: null,
|
||||||
fileHandle: savedFileHandle,
|
fileHandle: savedFileHandle,
|
||||||
toast: { message: t("toast.fileSaved") },
|
toast: { message: t("toast.fileSaved"), duration: 3000 },
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
} catch (error: any) {
|
} catch (error: any) {
|
||||||
|
|||||||
@@ -329,8 +329,8 @@ export const actionFinalize = register<FormData>({
|
|||||||
selectionElement: null,
|
selectionElement: null,
|
||||||
multiElement: null,
|
multiElement: null,
|
||||||
editingTextElement: null,
|
editingTextElement: null,
|
||||||
startBoundElement: null,
|
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
|
frameToHighlight: null,
|
||||||
selectedElementIds:
|
selectedElementIds:
|
||||||
element &&
|
element &&
|
||||||
!appState.activeTool.locked &&
|
!appState.activeTool.locked &&
|
||||||
@@ -348,9 +348,7 @@ export const actionFinalize = register<FormData>({
|
|||||||
};
|
};
|
||||||
},
|
},
|
||||||
keyTest: (event, appState) =>
|
keyTest: (event, appState) =>
|
||||||
(event.key === KEYS.ESCAPE &&
|
(event.key === KEYS.ESCAPE && appState.selectedLinearElement?.isEditing) ||
|
||||||
(appState.selectedLinearElement?.isEditing ||
|
|
||||||
(!appState.newElement && appState.multiElement === null))) ||
|
|
||||||
((event.key === KEYS.ESCAPE || event.key === KEYS.ENTER) &&
|
((event.key === KEYS.ESCAPE || event.key === KEYS.ENTER) &&
|
||||||
appState.multiElement !== null),
|
appState.multiElement !== null),
|
||||||
PanelComponent: ({ appState, updateData, data }) => (
|
PanelComponent: ({ appState, updateData, data }) => (
|
||||||
|
|||||||
@@ -205,7 +205,6 @@ export const actionWrapSelectionInFrame = register({
|
|||||||
[...app.scene.getElementsIncludingDeleted(), frame],
|
[...app.scene.getElementsIncludingDeleted(), frame],
|
||||||
selectedElements,
|
selectedElements,
|
||||||
frame,
|
frame,
|
||||||
appState,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
|
|||||||
@@ -277,7 +277,6 @@ export const actionUngroup = register({
|
|||||||
elementsMap,
|
elementsMap,
|
||||||
),
|
),
|
||||||
frame,
|
frame,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
import {
|
import {
|
||||||
isWindows,
|
|
||||||
KEYS,
|
KEYS,
|
||||||
matchKey,
|
matchKey,
|
||||||
arrayToMap,
|
arrayToMap,
|
||||||
@@ -114,7 +113,7 @@ export const createRedoAction: ActionCreator = (history) => ({
|
|||||||
),
|
),
|
||||||
keyTest: (event) =>
|
keyTest: (event) =>
|
||||||
(event[KEYS.CTRL_OR_CMD] && event.shiftKey && matchKey(event, KEYS.Z)) ||
|
(event[KEYS.CTRL_OR_CMD] && event.shiftKey && matchKey(event, KEYS.Z)) ||
|
||||||
(isWindows && event.ctrlKey && !event.shiftKey && matchKey(event, KEYS.Y)),
|
(event[KEYS.CTRL_OR_CMD] && !event.shiftKey && matchKey(event, KEYS.Y)),
|
||||||
PanelComponent: ({ appState, updateData, data, app }) => {
|
PanelComponent: ({ appState, updateData, data, app }) => {
|
||||||
const { isRedoStackEmpty } = useEmitter(
|
const { isRedoStackEmpty } = useEmitter(
|
||||||
history.onHistoryChangedEmitter,
|
history.onHistoryChangedEmitter,
|
||||||
|
|||||||
@@ -36,6 +36,7 @@ import {
|
|||||||
import { LinearElementEditor } from "@excalidraw/element";
|
import { LinearElementEditor } from "@excalidraw/element";
|
||||||
|
|
||||||
import { newElementWith } from "@excalidraw/element";
|
import { newElementWith } from "@excalidraw/element";
|
||||||
|
import { getArrowheadForPicker } from "@excalidraw/element";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
getBoundTextElement,
|
getBoundTextElement,
|
||||||
@@ -124,9 +125,12 @@ import {
|
|||||||
sharpArrowIcon,
|
sharpArrowIcon,
|
||||||
roundArrowIcon,
|
roundArrowIcon,
|
||||||
elbowArrowIcon,
|
elbowArrowIcon,
|
||||||
ArrowheadCrowfootIcon,
|
ArrowheadCardinalityExactlyOneIcon,
|
||||||
ArrowheadCrowfootOneIcon,
|
ArrowheadCardinalityManyIcon,
|
||||||
ArrowheadCrowfootOneOrManyIcon,
|
ArrowheadCardinalityOneIcon,
|
||||||
|
ArrowheadCardinalityOneOrManyIcon,
|
||||||
|
ArrowheadCardinalityZeroOrManyIcon,
|
||||||
|
ArrowheadCardinalityZeroOrOneIcon,
|
||||||
} from "../components/icons";
|
} from "../components/icons";
|
||||||
|
|
||||||
import { Fonts } from "../fonts";
|
import { Fonts } from "../fonts";
|
||||||
@@ -187,7 +191,7 @@ export const getFormValue = function <T extends Primitive>(
|
|||||||
elements: readonly ExcalidrawElement[],
|
elements: readonly ExcalidrawElement[],
|
||||||
app: AppClassProperties,
|
app: AppClassProperties,
|
||||||
getAttribute: (element: ExcalidrawElement) => T,
|
getAttribute: (element: ExcalidrawElement) => T,
|
||||||
isRelevantElement: true | ((element: ExcalidrawElement) => boolean),
|
elementPredicate: true | ((element: ExcalidrawElement) => boolean),
|
||||||
defaultValue: T | ((isSomeElementSelected: boolean) => T),
|
defaultValue: T | ((isSomeElementSelected: boolean) => T),
|
||||||
): T {
|
): T {
|
||||||
const editingTextElement = app.state.editingTextElement;
|
const editingTextElement = app.state.editingTextElement;
|
||||||
@@ -205,9 +209,9 @@ export const getFormValue = function <T extends Primitive>(
|
|||||||
if (hasSelection) {
|
if (hasSelection) {
|
||||||
const selectedElements = app.scene.getSelectedElements(app.state);
|
const selectedElements = app.scene.getSelectedElements(app.state);
|
||||||
const targetElements =
|
const targetElements =
|
||||||
isRelevantElement === true
|
elementPredicate === true
|
||||||
? selectedElements
|
? selectedElements
|
||||||
: selectedElements.filter((el) => isRelevantElement(el));
|
: selectedElements.filter((el) => elementPredicate(el));
|
||||||
|
|
||||||
ret =
|
ret =
|
||||||
reduceToCommonValue(targetElements, getAttribute) ??
|
reduceToCommonValue(targetElements, getAttribute) ??
|
||||||
@@ -726,9 +730,28 @@ export const actionChangeOpacity = register<ExcalidrawElement["opacity"]>({
|
|||||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||||
};
|
};
|
||||||
},
|
},
|
||||||
PanelComponent: ({ app, updateData }) => (
|
PanelComponent: ({ elements, appState, app, updateData }) => {
|
||||||
<Range updateData={updateData} app={app} testId="opacity" />
|
const opacity = getFormValue(
|
||||||
),
|
elements,
|
||||||
|
app,
|
||||||
|
(element) => element.opacity,
|
||||||
|
true,
|
||||||
|
(hasSelection) => (hasSelection ? null : appState.currentItemOpacity),
|
||||||
|
);
|
||||||
|
|
||||||
|
return (
|
||||||
|
<Range
|
||||||
|
label={t("labels.opacity")}
|
||||||
|
value={opacity ?? appState.currentItemOpacity}
|
||||||
|
hasCommonValue={opacity !== null}
|
||||||
|
onChange={updateData}
|
||||||
|
min={0}
|
||||||
|
max={100}
|
||||||
|
step={10}
|
||||||
|
testId="opacity"
|
||||||
|
/>
|
||||||
|
);
|
||||||
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
export const actionChangeFontSize = register<ExcalidrawTextElement["fontSize"]>(
|
export const actionChangeFontSize = register<ExcalidrawTextElement["fontSize"]>(
|
||||||
@@ -1550,80 +1573,117 @@ export const actionChangeRoundness = register<"sharp" | "round">({
|
|||||||
});
|
});
|
||||||
|
|
||||||
const getArrowheadOptions = (flip: boolean) => {
|
const getArrowheadOptions = (flip: boolean) => {
|
||||||
return [
|
return {
|
||||||
{
|
visibleSections: [
|
||||||
value: null,
|
{
|
||||||
text: t("labels.arrowhead_none"),
|
name: "default",
|
||||||
keyBinding: "q",
|
options: [
|
||||||
icon: <ArrowheadNoneIcon flip={flip} />,
|
{
|
||||||
},
|
value: null,
|
||||||
{
|
text: t("labels.arrowhead_none"),
|
||||||
value: "arrow",
|
keyBinding: "q",
|
||||||
text: t("labels.arrowhead_arrow"),
|
icon: <ArrowheadNoneIcon flip={flip} />,
|
||||||
keyBinding: "w",
|
},
|
||||||
icon: <ArrowheadArrowIcon flip={flip} />,
|
{
|
||||||
},
|
value: "arrow",
|
||||||
{
|
text: t("labels.arrowhead_arrow"),
|
||||||
value: "triangle",
|
keyBinding: "w",
|
||||||
text: t("labels.arrowhead_triangle"),
|
icon: <ArrowheadArrowIcon flip={flip} />,
|
||||||
icon: <ArrowheadTriangleIcon flip={flip} />,
|
},
|
||||||
keyBinding: "e",
|
{
|
||||||
},
|
value: "triangle",
|
||||||
{
|
text: t("labels.arrowhead_triangle"),
|
||||||
value: "triangle_outline",
|
icon: <ArrowheadTriangleIcon flip={flip} />,
|
||||||
text: t("labels.arrowhead_triangle_outline"),
|
keyBinding: "e",
|
||||||
icon: <ArrowheadTriangleOutlineIcon flip={flip} />,
|
},
|
||||||
keyBinding: "r",
|
{
|
||||||
},
|
value: "triangle_outline",
|
||||||
{
|
text: t("labels.arrowhead_triangle_outline"),
|
||||||
value: "circle",
|
icon: <ArrowheadTriangleOutlineIcon flip={flip} />,
|
||||||
text: t("labels.arrowhead_circle"),
|
keyBinding: "r",
|
||||||
keyBinding: "a",
|
},
|
||||||
icon: <ArrowheadCircleIcon flip={flip} />,
|
],
|
||||||
},
|
},
|
||||||
{
|
],
|
||||||
value: "circle_outline",
|
hiddenSections: [
|
||||||
text: t("labels.arrowhead_circle_outline"),
|
{
|
||||||
keyBinding: "s",
|
name: "default",
|
||||||
icon: <ArrowheadCircleOutlineIcon flip={flip} />,
|
options: [
|
||||||
},
|
{
|
||||||
{
|
value: "circle",
|
||||||
value: "diamond",
|
text: t("labels.arrowhead_circle"),
|
||||||
text: t("labels.arrowhead_diamond"),
|
keyBinding: "a",
|
||||||
icon: <ArrowheadDiamondIcon flip={flip} />,
|
icon: <ArrowheadCircleIcon flip={flip} />,
|
||||||
keyBinding: "d",
|
},
|
||||||
},
|
{
|
||||||
{
|
value: "circle_outline",
|
||||||
value: "diamond_outline",
|
text: t("labels.arrowhead_circle_outline"),
|
||||||
text: t("labels.arrowhead_diamond_outline"),
|
keyBinding: "s",
|
||||||
icon: <ArrowheadDiamondOutlineIcon flip={flip} />,
|
icon: <ArrowheadCircleOutlineIcon flip={flip} />,
|
||||||
keyBinding: "f",
|
},
|
||||||
},
|
{
|
||||||
{
|
value: "diamond",
|
||||||
value: "bar",
|
text: t("labels.arrowhead_diamond"),
|
||||||
text: t("labels.arrowhead_bar"),
|
icon: <ArrowheadDiamondIcon flip={flip} />,
|
||||||
keyBinding: "z",
|
keyBinding: "d",
|
||||||
icon: <ArrowheadBarIcon flip={flip} />,
|
},
|
||||||
},
|
{
|
||||||
{
|
value: "diamond_outline",
|
||||||
value: "crowfoot_one",
|
text: t("labels.arrowhead_diamond_outline"),
|
||||||
text: t("labels.arrowhead_crowfoot_one"),
|
icon: <ArrowheadDiamondOutlineIcon flip={flip} />,
|
||||||
icon: <ArrowheadCrowfootOneIcon flip={flip} />,
|
keyBinding: "f",
|
||||||
keyBinding: "x",
|
},
|
||||||
},
|
{
|
||||||
{
|
value: "bar",
|
||||||
value: "crowfoot_many",
|
text: t("labels.arrowhead_bar"),
|
||||||
text: t("labels.arrowhead_crowfoot_many"),
|
keyBinding: "z",
|
||||||
icon: <ArrowheadCrowfootIcon flip={flip} />,
|
icon: <ArrowheadBarIcon flip={flip} />,
|
||||||
keyBinding: "c",
|
},
|
||||||
},
|
],
|
||||||
{
|
},
|
||||||
value: "crowfoot_one_or_many",
|
{
|
||||||
text: t("labels.arrowhead_crowfoot_one_or_many"),
|
name: t("labels.cardinality"),
|
||||||
icon: <ArrowheadCrowfootOneOrManyIcon flip={flip} />,
|
options: [
|
||||||
keyBinding: "v",
|
{
|
||||||
},
|
value: "cardinality_one",
|
||||||
] as const;
|
text: t("labels.arrowhead_cardinality_one"),
|
||||||
|
icon: <ArrowheadCardinalityOneIcon flip={flip} />,
|
||||||
|
keyBinding: "x",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
value: "cardinality_many",
|
||||||
|
text: t("labels.arrowhead_cardinality_many"),
|
||||||
|
icon: <ArrowheadCardinalityManyIcon flip={flip} />,
|
||||||
|
keyBinding: "c",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
value: "cardinality_one_or_many",
|
||||||
|
text: t("labels.arrowhead_cardinality_one_or_many"),
|
||||||
|
icon: <ArrowheadCardinalityOneOrManyIcon flip={flip} />,
|
||||||
|
keyBinding: "v",
|
||||||
|
},
|
||||||
|
{
|
||||||
|
value: "cardinality_exactly_one",
|
||||||
|
text: t("labels.arrowhead_cardinality_exactly_one"),
|
||||||
|
icon: <ArrowheadCardinalityExactlyOneIcon flip={flip} />,
|
||||||
|
keyBinding: null,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
value: "cardinality_zero_or_one",
|
||||||
|
text: t("labels.arrowhead_cardinality_zero_or_one"),
|
||||||
|
icon: <ArrowheadCardinalityZeroOrOneIcon flip={flip} />,
|
||||||
|
keyBinding: null,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
value: "cardinality_zero_or_many",
|
||||||
|
text: t("labels.arrowhead_cardinality_zero_or_many"),
|
||||||
|
icon: <ArrowheadCardinalityZeroOrManyIcon flip={flip} />,
|
||||||
|
keyBinding: null,
|
||||||
|
},
|
||||||
|
],
|
||||||
|
},
|
||||||
|
],
|
||||||
|
} as const;
|
||||||
};
|
};
|
||||||
|
|
||||||
export const actionChangeArrowhead = register<{
|
export const actionChangeArrowhead = register<{
|
||||||
@@ -1667,45 +1727,52 @@ export const actionChangeArrowhead = register<{
|
|||||||
},
|
},
|
||||||
PanelComponent: ({ elements, appState, updateData, app }) => {
|
PanelComponent: ({ elements, appState, updateData, app }) => {
|
||||||
const isRTL = getLanguage().rtl;
|
const isRTL = getLanguage().rtl;
|
||||||
|
const startArrowheadOptions = useMemo(
|
||||||
|
() => getArrowheadOptions(!isRTL),
|
||||||
|
[isRTL],
|
||||||
|
);
|
||||||
|
const endArrowheadOptions = useMemo(
|
||||||
|
() => getArrowheadOptions(!!isRTL),
|
||||||
|
[isRTL],
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<fieldset>
|
<fieldset>
|
||||||
<legend>{t("labels.arrowheads")}</legend>
|
<legend>{t("labels.arrowheads")}</legend>
|
||||||
<div className="iconSelectList buttonList">
|
<div className="iconSelectList buttonList">
|
||||||
<IconPicker
|
<IconPicker
|
||||||
|
visibleSections={startArrowheadOptions.visibleSections}
|
||||||
|
hiddenSections={startArrowheadOptions.hiddenSections}
|
||||||
label="arrowhead_start"
|
label="arrowhead_start"
|
||||||
options={getArrowheadOptions(!isRTL)}
|
|
||||||
value={getFormValue<Arrowhead | null>(
|
value={getFormValue<Arrowhead | null>(
|
||||||
elements,
|
elements,
|
||||||
app,
|
app,
|
||||||
(element) =>
|
(element) =>
|
||||||
isLinearElement(element) && canHaveArrowheads(element.type)
|
isLinearElement(element) && canHaveArrowheads(element.type)
|
||||||
? element.startArrowhead
|
? getArrowheadForPicker(element.startArrowhead)
|
||||||
: appState.currentItemStartArrowhead,
|
: appState.currentItemStartArrowhead,
|
||||||
true,
|
true,
|
||||||
(hasSelection) =>
|
(hasSelection) =>
|
||||||
hasSelection ? null : appState.currentItemStartArrowhead,
|
hasSelection ? null : appState.currentItemStartArrowhead,
|
||||||
)}
|
)}
|
||||||
onChange={(value) => updateData({ position: "start", type: value })}
|
onChange={(value) => updateData({ position: "start", type: value })}
|
||||||
numberOfOptionsToAlwaysShow={4}
|
|
||||||
/>
|
/>
|
||||||
<IconPicker
|
<IconPicker
|
||||||
|
visibleSections={endArrowheadOptions.visibleSections}
|
||||||
|
hiddenSections={endArrowheadOptions.hiddenSections}
|
||||||
label="arrowhead_end"
|
label="arrowhead_end"
|
||||||
group="arrowheads"
|
|
||||||
options={getArrowheadOptions(!!isRTL)}
|
|
||||||
value={getFormValue<Arrowhead | null>(
|
value={getFormValue<Arrowhead | null>(
|
||||||
elements,
|
elements,
|
||||||
app,
|
app,
|
||||||
(element) =>
|
(element) =>
|
||||||
isLinearElement(element) && canHaveArrowheads(element.type)
|
isLinearElement(element) && canHaveArrowheads(element.type)
|
||||||
? element.endArrowhead
|
? getArrowheadForPicker(element.endArrowhead)
|
||||||
: appState.currentItemEndArrowhead,
|
: appState.currentItemEndArrowhead,
|
||||||
true,
|
true,
|
||||||
(hasSelection) =>
|
(hasSelection) =>
|
||||||
hasSelection ? null : appState.currentItemEndArrowhead,
|
hasSelection ? null : appState.currentItemEndArrowhead,
|
||||||
)}
|
)}
|
||||||
onChange={(value) => updateData({ position: "end", type: value })}
|
onChange={(value) => updateData({ position: "end", type: value })}
|
||||||
numberOfOptionsToAlwaysShow={4}
|
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
</fieldset>
|
</fieldset>
|
||||||
|
|||||||
@@ -1,24 +1,24 @@
|
|||||||
import { getFontString } from "@excalidraw/common";
|
import { getFontString } from "@excalidraw/common";
|
||||||
|
|
||||||
import { newElementWith } from "@excalidraw/element";
|
import { isExcalidrawElement, newElementWith } from "@excalidraw/element";
|
||||||
import { measureText } from "@excalidraw/element";
|
import { measureText } from "@excalidraw/element";
|
||||||
|
|
||||||
import { isTextElement } from "@excalidraw/element";
|
import { isTextElement } from "@excalidraw/element";
|
||||||
|
|
||||||
import { CaptureUpdateAction } from "@excalidraw/element";
|
import { CaptureUpdateAction } from "@excalidraw/element";
|
||||||
|
|
||||||
|
import type { ExcalidrawElement } from "@excalidraw/element/types";
|
||||||
|
|
||||||
import { getSelectedElements } from "../scene";
|
import { getSelectedElements } from "../scene";
|
||||||
|
|
||||||
import { register } from "./register";
|
import { register } from "./register";
|
||||||
|
|
||||||
import type { AppClassProperties } from "../types";
|
|
||||||
|
|
||||||
export const actionTextAutoResize = register({
|
export const actionTextAutoResize = register({
|
||||||
name: "autoResize",
|
name: "autoResize",
|
||||||
label: "labels.autoResize",
|
label: "labels.autoResize",
|
||||||
icon: null,
|
icon: null,
|
||||||
trackEvent: { category: "element" },
|
trackEvent: { category: "element" },
|
||||||
predicate: (elements, appState, _: unknown, app: AppClassProperties) => {
|
predicate: (elements, appState, _: unknown) => {
|
||||||
const selectedElements = getSelectedElements(elements, appState);
|
const selectedElements = getSelectedElements(elements, appState);
|
||||||
return (
|
return (
|
||||||
selectedElements.length === 1 &&
|
selectedElements.length === 1 &&
|
||||||
@@ -26,13 +26,18 @@ export const actionTextAutoResize = register({
|
|||||||
!selectedElements[0].autoResize
|
!selectedElements[0].autoResize
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
perform: (elements, appState, _, app) => {
|
perform: (elements, appState, targetElement) => {
|
||||||
const selectedElements = getSelectedElements(elements, appState);
|
const selectedElements = getSelectedElements(elements, appState);
|
||||||
|
|
||||||
|
const targetTextElement =
|
||||||
|
isExcalidrawElement(targetElement) && isTextElement(targetElement)
|
||||||
|
? targetElement
|
||||||
|
: (selectedElements[0] as ExcalidrawElement | undefined);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
appState,
|
appState,
|
||||||
elements: elements.map((element) => {
|
elements: elements.map((element) => {
|
||||||
if (element.id === selectedElements[0].id && isTextElement(element)) {
|
if (element.id === targetTextElement?.id && isTextElement(element)) {
|
||||||
const metrics = measureText(
|
const metrics = measureText(
|
||||||
element.originalText,
|
element.originalText,
|
||||||
getFontString(element),
|
getFontString(element),
|
||||||
|
|||||||
@@ -34,6 +34,7 @@ export {
|
|||||||
export { actionSetEmbeddableAsActiveTool } from "./actionEmbeddable";
|
export { actionSetEmbeddableAsActiveTool } from "./actionEmbeddable";
|
||||||
|
|
||||||
export { actionFinalize } from "./actionFinalize";
|
export { actionFinalize } from "./actionFinalize";
|
||||||
|
export { actionDeselect } from "./actionDeselect";
|
||||||
|
|
||||||
export {
|
export {
|
||||||
actionChangeProjectName,
|
actionChangeProjectName,
|
||||||
|
|||||||
@@ -114,6 +114,7 @@ export type ActionName =
|
|||||||
| "distributeVertically"
|
| "distributeVertically"
|
||||||
| "flipHorizontal"
|
| "flipHorizontal"
|
||||||
| "flipVertical"
|
| "flipVertical"
|
||||||
|
| "deselect"
|
||||||
| "viewMode"
|
| "viewMode"
|
||||||
| "exportWithDarkMode"
|
| "exportWithDarkMode"
|
||||||
| "toggleTheme"
|
| "toggleTheme"
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
import { LaserPointer } from "@excalidraw/laser-pointer";
|
import { LaserPointer } from "@excalidraw/laser-pointer";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
SVG_NS,
|
SVG_NS,
|
||||||
getSvgPathFromStroke,
|
getSvgPathFromStroke,
|
||||||
@@ -8,7 +7,8 @@ import {
|
|||||||
|
|
||||||
import type { LaserPointerOptions } from "@excalidraw/laser-pointer";
|
import type { LaserPointerOptions } from "@excalidraw/laser-pointer";
|
||||||
|
|
||||||
import type { AnimationFrameHandler } from "./animation-frame-handler";
|
import { AnimationController } from "./renderer/animation";
|
||||||
|
|
||||||
import type App from "./components/App";
|
import type App from "./components/App";
|
||||||
import type { AppState } from "./types";
|
import type { AppState } from "./types";
|
||||||
|
|
||||||
@@ -34,15 +34,16 @@ export class AnimatedTrail implements Trail {
|
|||||||
private container?: SVGSVGElement;
|
private container?: SVGSVGElement;
|
||||||
private trailElement: SVGPathElement;
|
private trailElement: SVGPathElement;
|
||||||
private trailAnimation?: SVGAnimateElement;
|
private trailAnimation?: SVGAnimateElement;
|
||||||
|
private key: string;
|
||||||
|
|
||||||
|
private static counter = 0;
|
||||||
|
|
||||||
constructor(
|
constructor(
|
||||||
private animationFrameHandler: AnimationFrameHandler,
|
|
||||||
protected app: App,
|
protected app: App,
|
||||||
private options: Partial<LaserPointerOptions> &
|
private options: Partial<LaserPointerOptions> &
|
||||||
Partial<AnimatedTrailOptions>,
|
Partial<AnimatedTrailOptions>,
|
||||||
) {
|
) {
|
||||||
this.animationFrameHandler.register(this, this.onFrame.bind(this));
|
this.key = `animated-trail-${AnimatedTrail.counter++}`;
|
||||||
|
|
||||||
this.trailElement = document.createElementNS(SVG_NS, "path");
|
this.trailElement = document.createElementNS(SVG_NS, "path");
|
||||||
if (this.options.animateTrail) {
|
if (this.options.animateTrail) {
|
||||||
this.trailAnimation = document.createElementNS(SVG_NS, "animate");
|
this.trailAnimation = document.createElementNS(SVG_NS, "animate");
|
||||||
@@ -73,6 +74,15 @@ export class AnimatedTrail implements Trail {
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private cleanup() {
|
||||||
|
this.pastTrails = [];
|
||||||
|
this.currentTrail = undefined;
|
||||||
|
|
||||||
|
if (this.trailElement.parentNode === this.container) {
|
||||||
|
this.container?.removeChild(this.trailElement);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
start(container?: SVGSVGElement) {
|
start(container?: SVGSVGElement) {
|
||||||
if (container) {
|
if (container) {
|
||||||
this.container = container;
|
this.container = container;
|
||||||
@@ -82,15 +92,23 @@ export class AnimatedTrail implements Trail {
|
|||||||
this.container.appendChild(this.trailElement);
|
this.container.appendChild(this.trailElement);
|
||||||
}
|
}
|
||||||
|
|
||||||
this.animationFrameHandler.start(this);
|
if (!AnimationController.running(this.key)) {
|
||||||
|
AnimationController.start(this.key, () => {
|
||||||
|
const needsNext = this.onFrame();
|
||||||
|
if (needsNext) {
|
||||||
|
return { keep: true };
|
||||||
|
}
|
||||||
|
|
||||||
|
this.cleanup();
|
||||||
|
|
||||||
|
return null;
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
stop() {
|
stop() {
|
||||||
this.animationFrameHandler.stop(this);
|
AnimationController.cancel(this.key);
|
||||||
|
this.cleanup();
|
||||||
if (this.trailElement.parentNode === this.container) {
|
|
||||||
this.container?.removeChild(this.trailElement);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
startPath(x: number, y: number) {
|
startPath(x: number, y: number) {
|
||||||
@@ -145,21 +163,25 @@ export class AnimatedTrail implements Trail {
|
|||||||
|
|
||||||
if (this.currentTrail) {
|
if (this.currentTrail) {
|
||||||
const currentPath = this.drawTrail(this.currentTrail, this.app.state);
|
const currentPath = this.drawTrail(this.currentTrail, this.app.state);
|
||||||
|
|
||||||
paths.push(currentPath);
|
paths.push(currentPath);
|
||||||
}
|
}
|
||||||
|
|
||||||
this.pastTrails = this.pastTrails.filter((trail) => {
|
this.pastTrails = this.pastTrails.filter(
|
||||||
return trail.getStrokeOutline().length !== 0;
|
(t) =>
|
||||||
});
|
t.getStrokeOutline(t.options.size / this.app.state.zoom.value)
|
||||||
|
.length !== 0,
|
||||||
|
);
|
||||||
|
|
||||||
if (paths.length === 0) {
|
if (paths.length === 0) {
|
||||||
this.stop();
|
// Clean up the SVG path if there are no trails to render
|
||||||
|
this.trailElement.setAttribute("d", "");
|
||||||
|
|
||||||
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
const svgPaths = paths.join(" ").trim();
|
const svgPaths = paths.join(" ").trim();
|
||||||
|
|
||||||
this.trailElement.setAttribute("d", svgPaths);
|
this.trailElement.setAttribute("d", svgPaths);
|
||||||
|
|
||||||
if (this.trailAnimation) {
|
if (this.trailAnimation) {
|
||||||
this.trailElement.setAttribute(
|
this.trailElement.setAttribute(
|
||||||
"fill",
|
"fill",
|
||||||
@@ -175,6 +197,8 @@ export class AnimatedTrail implements Trail {
|
|||||||
(this.options.fill ?? (() => "black"))(this),
|
(this.options.fill ?? (() => "black"))(this),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
private drawTrail(trail: LaserPointer, state: AppState): string {
|
private drawTrail(trail: LaserPointer, state: AppState): string {
|
||||||
@@ -1,79 +0,0 @@
|
|||||||
export type AnimationCallback = (timestamp: number) => void | boolean;
|
|
||||||
|
|
||||||
export type AnimationTarget = {
|
|
||||||
callback: AnimationCallback;
|
|
||||||
stopped: boolean;
|
|
||||||
};
|
|
||||||
|
|
||||||
export class AnimationFrameHandler {
|
|
||||||
private targets = new WeakMap<object, AnimationTarget>();
|
|
||||||
private rafIds = new WeakMap<object, number>();
|
|
||||||
|
|
||||||
register(key: object, callback: AnimationCallback) {
|
|
||||||
this.targets.set(key, { callback, stopped: true });
|
|
||||||
}
|
|
||||||
|
|
||||||
start(key: object) {
|
|
||||||
const target = this.targets.get(key);
|
|
||||||
|
|
||||||
if (!target) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (this.rafIds.has(key)) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
this.targets.set(key, { ...target, stopped: false });
|
|
||||||
this.scheduleFrame(key);
|
|
||||||
}
|
|
||||||
|
|
||||||
stop(key: object) {
|
|
||||||
const target = this.targets.get(key);
|
|
||||||
if (target && !target.stopped) {
|
|
||||||
this.targets.set(key, { ...target, stopped: true });
|
|
||||||
}
|
|
||||||
|
|
||||||
this.cancelFrame(key);
|
|
||||||
}
|
|
||||||
|
|
||||||
private constructFrame(key: object): FrameRequestCallback {
|
|
||||||
return (timestamp: number) => {
|
|
||||||
const target = this.targets.get(key);
|
|
||||||
|
|
||||||
if (!target) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const shouldAbort = this.onFrame(target, timestamp);
|
|
||||||
|
|
||||||
if (!target.stopped && !shouldAbort) {
|
|
||||||
this.scheduleFrame(key);
|
|
||||||
} else {
|
|
||||||
this.cancelFrame(key);
|
|
||||||
}
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
private scheduleFrame(key: object) {
|
|
||||||
const rafId = requestAnimationFrame(this.constructFrame(key));
|
|
||||||
|
|
||||||
this.rafIds.set(key, rafId);
|
|
||||||
}
|
|
||||||
|
|
||||||
private cancelFrame(key: object) {
|
|
||||||
if (this.rafIds.has(key)) {
|
|
||||||
const rafId = this.rafIds.get(key)!;
|
|
||||||
|
|
||||||
cancelAnimationFrame(rafId);
|
|
||||||
}
|
|
||||||
|
|
||||||
this.rafIds.delete(key);
|
|
||||||
}
|
|
||||||
|
|
||||||
private onFrame(target: AnimationTarget, timestamp: number): boolean {
|
|
||||||
const shouldAbort = target.callback(timestamp);
|
|
||||||
|
|
||||||
return shouldAbort ?? false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -99,7 +99,6 @@ export const getDefaultAppState = (): Omit<
|
|||||||
open: false,
|
open: false,
|
||||||
panels: STATS_PANELS.generalStats | STATS_PANELS.elementProperties,
|
panels: STATS_PANELS.generalStats | STATS_PANELS.elementProperties,
|
||||||
},
|
},
|
||||||
startBoundElement: null,
|
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
frameRendering: { enabled: true, clip: true, name: true, outline: true },
|
frameRendering: { enabled: true, clip: true, name: true, outline: true },
|
||||||
frameToHighlight: null,
|
frameToHighlight: null,
|
||||||
@@ -128,6 +127,7 @@ export const getDefaultAppState = (): Omit<
|
|||||||
lockedMultiSelections: {},
|
lockedMultiSelections: {},
|
||||||
activeLockedId: null,
|
activeLockedId: null,
|
||||||
bindMode: "orbit",
|
bindMode: "orbit",
|
||||||
|
boxSelectionMode: "contain",
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -193,6 +193,7 @@ const APP_STATE_STORAGE_CONF = (<
|
|||||||
gridModeEnabled: { browser: true, export: true, server: true },
|
gridModeEnabled: { browser: true, export: true, server: true },
|
||||||
height: { browser: false, export: false, server: false },
|
height: { browser: false, export: false, server: false },
|
||||||
isBindingEnabled: { browser: true, export: false, server: false },
|
isBindingEnabled: { browser: true, export: false, server: false },
|
||||||
|
boxSelectionMode: { browser: true, export: false, server: false },
|
||||||
bindingPreference: { browser: true, export: false, server: false },
|
bindingPreference: { browser: true, export: false, server: false },
|
||||||
isMidpointSnappingEnabled: { browser: true, export: false, server: false },
|
isMidpointSnappingEnabled: { browser: true, export: false, server: false },
|
||||||
defaultSidebarDockedPreference: {
|
defaultSidebarDockedPreference: {
|
||||||
@@ -229,7 +230,6 @@ const APP_STATE_STORAGE_CONF = (<
|
|||||||
selectionElement: { browser: false, export: false, server: false },
|
selectionElement: { browser: false, export: false, server: false },
|
||||||
shouldCacheIgnoreZoom: { browser: true, export: false, server: false },
|
shouldCacheIgnoreZoom: { browser: true, export: false, server: false },
|
||||||
stats: { browser: true, export: false, server: false },
|
stats: { browser: true, export: false, server: false },
|
||||||
startBoundElement: { browser: false, export: false, server: false },
|
|
||||||
suggestedBinding: { browser: false, export: false, server: false },
|
suggestedBinding: { browser: false, export: false, server: false },
|
||||||
frameRendering: { browser: false, export: false, server: false },
|
frameRendering: { browser: false, export: false, server: false },
|
||||||
frameToHighlight: { browser: false, export: false, server: false },
|
frameToHighlight: { browser: false, export: false, server: false },
|
||||||
|
|||||||
+1113
-220
File diff suppressed because it is too large
Load Diff
@@ -46,6 +46,7 @@ import {
|
|||||||
import { fontPickerKeyHandler } from "./keyboardNavHandlers";
|
import { fontPickerKeyHandler } from "./keyboardNavHandlers";
|
||||||
|
|
||||||
import type { JSX } from "react";
|
import type { JSX } from "react";
|
||||||
|
import type { ExcalidrawFontFace } from "../../fonts/ExcalidrawFontFace";
|
||||||
|
|
||||||
export interface FontDescriptor {
|
export interface FontDescriptor {
|
||||||
value: number;
|
value: number;
|
||||||
@@ -86,6 +87,15 @@ const getFontFamilyIcon = (fontFamily: FontFamilyValues): JSX.Element => {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const getFontFamilyLabel = (
|
||||||
|
fontFamily: FontFamilyValues,
|
||||||
|
fontFaces: ExcalidrawFontFace[],
|
||||||
|
) =>
|
||||||
|
// prefer our config as the browser resolved names may be wrapped in quotes and such
|
||||||
|
Object.entries(FONT_FAMILY).find(([, id]) => id === fontFamily)?.[0] ??
|
||||||
|
fontFaces[0]?.fontFace?.family ??
|
||||||
|
"Unknown";
|
||||||
|
|
||||||
export const FontPickerList = React.memo(
|
export const FontPickerList = React.memo(
|
||||||
({
|
({
|
||||||
selectedFontFamily,
|
selectedFontFamily,
|
||||||
@@ -114,7 +124,7 @@ export const FontPickerList = React.memo(
|
|||||||
const fontDescriptor = {
|
const fontDescriptor = {
|
||||||
value: familyId,
|
value: familyId,
|
||||||
icon: getFontFamilyIcon(familyId),
|
icon: getFontFamilyIcon(familyId),
|
||||||
text: fontFaces[0]?.fontFace?.family ?? "Unknown",
|
text: getFontFamilyLabel(familyId, fontFaces),
|
||||||
};
|
};
|
||||||
|
|
||||||
if (metadata.deprecated) {
|
if (metadata.deprecated) {
|
||||||
|
|||||||
@@ -6,14 +6,20 @@
|
|||||||
padding: 0.5rem;
|
padding: 0.5rem;
|
||||||
background: var(--popup-bg-color);
|
background: var(--popup-bg-color);
|
||||||
border: 0 solid color.adjust(#fff, $alpha: -0.75);
|
border: 0 solid color.adjust(#fff, $alpha: -0.75);
|
||||||
box-shadow: var(--shadow-island);
|
box-shadow: var(--shadow-island-stronger);
|
||||||
border-radius: 4px;
|
border-radius: 4px;
|
||||||
position: absolute;
|
|
||||||
:root[dir="rtl"] & {
|
:root[dir="rtl"] & {
|
||||||
padding: 0.4rem;
|
padding: 0.4rem;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.picker-sections,
|
||||||
|
.picker-section {
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
gap: 0.5rem;
|
||||||
|
}
|
||||||
|
|
||||||
.picker-container button,
|
.picker-container button,
|
||||||
.picker button {
|
.picker button {
|
||||||
position: relative;
|
position: relative;
|
||||||
@@ -62,7 +68,13 @@
|
|||||||
|
|
||||||
.picker-collapsible {
|
.picker-collapsible {
|
||||||
font-size: 0.75rem;
|
font-size: 0.75rem;
|
||||||
padding: 0.5rem 0;
|
padding: 0;
|
||||||
|
color: var(--text-primary-color);
|
||||||
|
}
|
||||||
|
|
||||||
|
.picker-section-label {
|
||||||
|
font-size: 0.75rem;
|
||||||
|
color: var(--text-primary-color);
|
||||||
}
|
}
|
||||||
|
|
||||||
.picker-keybinding {
|
.picker-keybinding {
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
import { Popover } from "radix-ui";
|
import { Popover } from "radix-ui";
|
||||||
import clsx from "clsx";
|
import clsx from "clsx";
|
||||||
import React, { useEffect } from "react";
|
import React, { useEffect, useMemo } from "react";
|
||||||
|
|
||||||
import { isArrowKey, KEYS } from "@excalidraw/common";
|
import { isArrowKey, KEYS } from "@excalidraw/common";
|
||||||
|
|
||||||
@@ -8,13 +8,15 @@ import { atom, useAtom } from "../editor-jotai";
|
|||||||
import { getLanguage, t } from "../i18n";
|
import { getLanguage, t } from "../i18n";
|
||||||
|
|
||||||
import Collapsible from "./Stats/Collapsible";
|
import Collapsible from "./Stats/Collapsible";
|
||||||
import { useEditorInterface, useExcalidrawContainer } from "./App";
|
import { useExcalidrawContainer } from "./App";
|
||||||
|
|
||||||
import "./IconPicker.scss";
|
import "./IconPicker.scss";
|
||||||
|
|
||||||
import type { JSX } from "react";
|
import type { JSX } from "react";
|
||||||
|
|
||||||
const moreOptionsAtom = atom(false);
|
const moreOptionsAtom = atom(false);
|
||||||
|
const PICKER_COLUMNS = 4;
|
||||||
|
const DEFAULT_SECTION_NAME = "default";
|
||||||
|
|
||||||
type Option<T> = {
|
type Option<T> = {
|
||||||
value: T;
|
value: T;
|
||||||
@@ -23,28 +25,73 @@ type Option<T> = {
|
|||||||
keyBinding: string | null;
|
keyBinding: string | null;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
type PickerSection<T> = {
|
||||||
|
name: string;
|
||||||
|
options: readonly Option<T>[];
|
||||||
|
};
|
||||||
|
|
||||||
|
const flattenOptions = <T,>(sections: readonly PickerSection<T>[]) =>
|
||||||
|
sections.flatMap((section) => section.options);
|
||||||
|
|
||||||
|
const findOption = <T,>(
|
||||||
|
sections: readonly PickerSection<T>[],
|
||||||
|
predicate: (option: Option<T>) => boolean,
|
||||||
|
) => {
|
||||||
|
for (const section of sections) {
|
||||||
|
const option = section.options.find(predicate);
|
||||||
|
if (option) {
|
||||||
|
return option;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
|
const hasOption = <T,>(
|
||||||
|
sections: readonly PickerSection<T>[],
|
||||||
|
predicate: (option: Option<T>) => boolean,
|
||||||
|
) => sections.some((section) => section.options.some(predicate));
|
||||||
|
|
||||||
|
const getNavigationRows = <T,>(sections: readonly PickerSection<T>[]) =>
|
||||||
|
sections.flatMap((section) =>
|
||||||
|
Array.from(
|
||||||
|
{ length: Math.ceil(section.options.length / PICKER_COLUMNS) },
|
||||||
|
(_, index) =>
|
||||||
|
section.options.slice(
|
||||||
|
index * PICKER_COLUMNS,
|
||||||
|
index * PICKER_COLUMNS + PICKER_COLUMNS,
|
||||||
|
),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
function Picker<T>({
|
function Picker<T>({
|
||||||
options,
|
visibleSections,
|
||||||
|
hiddenSections = [],
|
||||||
value,
|
value,
|
||||||
label,
|
label,
|
||||||
onChange,
|
onChange,
|
||||||
onClose,
|
onClose,
|
||||||
numberOfOptionsToAlwaysShow = options.length,
|
|
||||||
}: {
|
}: {
|
||||||
label: string;
|
label: string;
|
||||||
value: T;
|
value: T;
|
||||||
options: readonly Option<T>[];
|
visibleSections: readonly PickerSection<T>[];
|
||||||
|
hiddenSections?: readonly PickerSection<T>[];
|
||||||
onChange: (value: T) => void;
|
onChange: (value: T) => void;
|
||||||
onClose: () => void;
|
onClose: () => void;
|
||||||
numberOfOptionsToAlwaysShow?: number;
|
|
||||||
}) {
|
}) {
|
||||||
const editorInterface = useEditorInterface();
|
|
||||||
const { container } = useExcalidrawContainer();
|
const { container } = useExcalidrawContainer();
|
||||||
|
const [showMoreOptions, setShowMoreOptions] = useAtom(moreOptionsAtom);
|
||||||
|
const allSections = [...visibleSections, ...hiddenSections];
|
||||||
|
const allOptions = flattenOptions(allSections);
|
||||||
|
const navigationRows = getNavigationRows([
|
||||||
|
...visibleSections,
|
||||||
|
...(showMoreOptions ? hiddenSections : []),
|
||||||
|
]);
|
||||||
|
|
||||||
const handleKeyDown = (event: React.KeyboardEvent) => {
|
const handleKeyDown = (event: React.KeyboardEvent) => {
|
||||||
const pressedOption = options.find(
|
const pressedOption = allOptions.find(
|
||||||
(option) => option.keyBinding === event.key.toLowerCase(),
|
(option) => option.keyBinding === event.key.toLowerCase(),
|
||||||
)!;
|
);
|
||||||
|
|
||||||
if (!(event.metaKey || event.altKey || event.ctrlKey) && pressedOption) {
|
if (!(event.metaKey || event.altKey || event.ctrlKey) && pressedOption) {
|
||||||
// Keybinding navigation
|
// Keybinding navigation
|
||||||
@@ -52,17 +99,17 @@ function Picker<T>({
|
|||||||
|
|
||||||
event.preventDefault();
|
event.preventDefault();
|
||||||
} else if (event.key === KEYS.TAB) {
|
} else if (event.key === KEYS.TAB) {
|
||||||
const index = options.findIndex((option) => option.value === value);
|
const index = allOptions.findIndex((option) => option.value === value);
|
||||||
const nextIndex = event.shiftKey
|
const nextIndex = event.shiftKey
|
||||||
? (options.length + index - 1) % options.length
|
? (allOptions.length + index - 1) % allOptions.length
|
||||||
: (index + 1) % options.length;
|
: (index + 1) % allOptions.length;
|
||||||
onChange(options[nextIndex].value);
|
onChange(allOptions[nextIndex].value);
|
||||||
} else if (isArrowKey(event.key)) {
|
} else if (isArrowKey(event.key)) {
|
||||||
// Arrow navigation
|
// Arrow navigation
|
||||||
const isRTL = getLanguage().rtl;
|
const isRTL = getLanguage().rtl;
|
||||||
const index = options.findIndex((option) => option.value === value);
|
const index = allOptions.findIndex((option) => option.value === value);
|
||||||
if (index !== -1) {
|
if (index !== -1) {
|
||||||
const length = options.length;
|
const length = allOptions.length;
|
||||||
let nextIndex = index;
|
let nextIndex = index;
|
||||||
|
|
||||||
switch (event.key) {
|
switch (event.key) {
|
||||||
@@ -76,18 +123,60 @@ function Picker<T>({
|
|||||||
break;
|
break;
|
||||||
// Go the next row
|
// Go the next row
|
||||||
case KEYS.ARROW_DOWN: {
|
case KEYS.ARROW_DOWN: {
|
||||||
nextIndex = (index + (numberOfOptionsToAlwaysShow ?? 1)) % length;
|
const currentRowIndex = navigationRows.findIndex((row) =>
|
||||||
|
row.some((option) => option.value === value),
|
||||||
|
);
|
||||||
|
const currentRow = navigationRows[currentRowIndex];
|
||||||
|
|
||||||
|
if (currentRowIndex !== -1 && currentRow) {
|
||||||
|
const column = currentRow.findIndex(
|
||||||
|
(option) => option.value === value,
|
||||||
|
);
|
||||||
|
const nextRow =
|
||||||
|
navigationRows[(currentRowIndex + 1) % navigationRows.length];
|
||||||
|
const nextOption =
|
||||||
|
nextRow[Math.min(column, nextRow.length - 1)] ??
|
||||||
|
allOptions[index];
|
||||||
|
|
||||||
|
onChange(nextOption.value);
|
||||||
|
event.preventDefault();
|
||||||
|
event.nativeEvent.stopImmediatePropagation();
|
||||||
|
event.stopPropagation();
|
||||||
|
return;
|
||||||
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
// Go the previous row
|
// Go the previous row
|
||||||
case KEYS.ARROW_UP: {
|
case KEYS.ARROW_UP: {
|
||||||
nextIndex =
|
const currentRowIndex = navigationRows.findIndex((row) =>
|
||||||
(length + index - (numberOfOptionsToAlwaysShow ?? 1)) % length;
|
row.some((option) => option.value === value),
|
||||||
|
);
|
||||||
|
const currentRow = navigationRows[currentRowIndex];
|
||||||
|
|
||||||
|
if (currentRowIndex !== -1 && currentRow) {
|
||||||
|
const column = currentRow.findIndex(
|
||||||
|
(option) => option.value === value,
|
||||||
|
);
|
||||||
|
const previousRow =
|
||||||
|
navigationRows[
|
||||||
|
(navigationRows.length + currentRowIndex - 1) %
|
||||||
|
navigationRows.length
|
||||||
|
];
|
||||||
|
const previousOption =
|
||||||
|
previousRow[Math.min(column, previousRow.length - 1)] ??
|
||||||
|
allOptions[index];
|
||||||
|
|
||||||
|
onChange(previousOption.value);
|
||||||
|
event.preventDefault();
|
||||||
|
event.nativeEvent.stopImmediatePropagation();
|
||||||
|
event.stopPropagation();
|
||||||
|
return;
|
||||||
|
}
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
onChange(options[nextIndex].value);
|
onChange(allOptions[nextIndex].value);
|
||||||
}
|
}
|
||||||
event.preventDefault();
|
event.preventDefault();
|
||||||
} else if (event.key === KEYS.ESCAPE || event.key === KEYS.ENTER) {
|
} else if (event.key === KEYS.ESCAPE || event.key === KEYS.ENTER) {
|
||||||
@@ -99,38 +188,29 @@ function Picker<T>({
|
|||||||
event.stopPropagation();
|
event.stopPropagation();
|
||||||
};
|
};
|
||||||
|
|
||||||
const [showMoreOptions, setShowMoreOptions] = useAtom(moreOptionsAtom);
|
|
||||||
|
|
||||||
const alwaysVisibleOptions = React.useMemo(
|
|
||||||
() => options.slice(0, numberOfOptionsToAlwaysShow),
|
|
||||||
[options, numberOfOptionsToAlwaysShow],
|
|
||||||
);
|
|
||||||
const moreOptions = React.useMemo(
|
|
||||||
() => options.slice(numberOfOptionsToAlwaysShow),
|
|
||||||
[options, numberOfOptionsToAlwaysShow],
|
|
||||||
);
|
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!alwaysVisibleOptions.some((option) => option.value === value)) {
|
if (hasOption(hiddenSections, (option) => option.value === value)) {
|
||||||
setShowMoreOptions(true);
|
setShowMoreOptions(true);
|
||||||
}
|
}
|
||||||
}, [value, alwaysVisibleOptions, setShowMoreOptions]);
|
}, [value, hiddenSections, setShowMoreOptions]);
|
||||||
|
|
||||||
const renderOptions = (options: Option<T>[]) => {
|
const renderOptions = (options: readonly Option<T>[]) => {
|
||||||
return (
|
return (
|
||||||
<div className="picker-content">
|
<div className="picker-content">
|
||||||
{options.map((option, i) => (
|
{options.map((option) => (
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
className={clsx("picker-option", {
|
className={clsx("picker-option", {
|
||||||
active: value === option.value,
|
active: value === option.value,
|
||||||
})}
|
})}
|
||||||
onClick={(event) => {
|
onClick={() => {
|
||||||
onChange(option.value);
|
onChange(option.value);
|
||||||
}}
|
}}
|
||||||
title={`${option.text} ${
|
title={
|
||||||
option.keyBinding && `— ${option.keyBinding.toUpperCase()}`
|
option.keyBinding
|
||||||
}`}
|
? `${option.text} — ${option.keyBinding.toUpperCase()}`
|
||||||
|
: option.text
|
||||||
|
}
|
||||||
aria-label={option.text || "none"}
|
aria-label={option.text || "none"}
|
||||||
aria-keyshortcuts={option.keyBinding || undefined}
|
aria-keyshortcuts={option.keyBinding || undefined}
|
||||||
key={option.text}
|
key={option.text}
|
||||||
@@ -153,26 +233,38 @@ function Picker<T>({
|
|||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
const isMobile = editorInterface.formFactor === "phone";
|
const renderSections = (sections: readonly PickerSection<T>[]) =>
|
||||||
|
sections.map((section, index) =>
|
||||||
|
section.name === DEFAULT_SECTION_NAME ? (
|
||||||
|
<React.Fragment key={`${section.name}-${index}`}>
|
||||||
|
{renderOptions(section.options)}
|
||||||
|
</React.Fragment>
|
||||||
|
) : (
|
||||||
|
<div className="picker-section" key={`${section.name}-${index}`}>
|
||||||
|
<div className="picker-section-label">{section.name}</div>
|
||||||
|
{renderOptions(section.options)}
|
||||||
|
</div>
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Popover.Content
|
<Popover.Content
|
||||||
side={isMobile ? "right" : "bottom"}
|
className="picker"
|
||||||
|
role="dialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-label={label}
|
||||||
|
side={"bottom"}
|
||||||
align="start"
|
align="start"
|
||||||
sideOffset={isMobile ? 8 : 12}
|
sideOffset={12}
|
||||||
|
alignOffset={12}
|
||||||
style={{ zIndex: "var(--zIndex-ui-styles-popup)" }}
|
style={{ zIndex: "var(--zIndex-ui-styles-popup)" }}
|
||||||
onKeyDown={handleKeyDown}
|
onKeyDown={handleKeyDown}
|
||||||
collisionBoundary={container ?? undefined}
|
collisionBoundary={container ?? undefined}
|
||||||
>
|
>
|
||||||
<div
|
<div className="picker-sections">
|
||||||
className={`picker`}
|
{renderSections(visibleSections)}
|
||||||
role="dialog"
|
|
||||||
aria-modal="true"
|
|
||||||
aria-label={label}
|
|
||||||
>
|
|
||||||
{renderOptions(alwaysVisibleOptions)}
|
|
||||||
|
|
||||||
{moreOptions.length > 0 && (
|
{hiddenSections.length > 0 && (
|
||||||
<Collapsible
|
<Collapsible
|
||||||
label={t("labels.more_options")}
|
label={t("labels.more_options")}
|
||||||
open={showMoreOptions}
|
open={showMoreOptions}
|
||||||
@@ -181,7 +273,9 @@ function Picker<T>({
|
|||||||
}}
|
}}
|
||||||
className="picker-collapsible"
|
className="picker-collapsible"
|
||||||
>
|
>
|
||||||
{renderOptions(moreOptions)}
|
<div className="picker-sections">
|
||||||
|
{renderSections(hiddenSections)}
|
||||||
|
</div>
|
||||||
</Collapsible>
|
</Collapsible>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
@@ -192,49 +286,45 @@ function Picker<T>({
|
|||||||
export function IconPicker<T>({
|
export function IconPicker<T>({
|
||||||
value,
|
value,
|
||||||
label,
|
label,
|
||||||
options,
|
visibleSections,
|
||||||
|
hiddenSections,
|
||||||
onChange,
|
onChange,
|
||||||
group = "",
|
|
||||||
numberOfOptionsToAlwaysShow,
|
|
||||||
}: {
|
}: {
|
||||||
label: string;
|
label: string;
|
||||||
value: T;
|
value: T;
|
||||||
options: readonly {
|
visibleSections: readonly PickerSection<T>[];
|
||||||
value: T;
|
hiddenSections?: readonly PickerSection<T>[];
|
||||||
text: string;
|
|
||||||
icon: JSX.Element;
|
|
||||||
keyBinding: string | null;
|
|
||||||
}[];
|
|
||||||
onChange: (value: T) => void;
|
onChange: (value: T) => void;
|
||||||
numberOfOptionsToAlwaysShow?: number;
|
|
||||||
group?: string;
|
|
||||||
}) {
|
}) {
|
||||||
const [isActive, setActive] = React.useState(false);
|
const [isActive, setActive] = React.useState(false);
|
||||||
const rPickerButton = React.useRef<any>(null);
|
const selectedOption = useMemo(
|
||||||
|
() =>
|
||||||
|
findOption(visibleSections, (option) => option.value === value) ??
|
||||||
|
findOption(hiddenSections ?? [], (option) => option.value === value),
|
||||||
|
[visibleSections, hiddenSections, value],
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div>
|
<div>
|
||||||
<Popover.Root open={isActive} onOpenChange={(open) => setActive(open)}>
|
<Popover.Root open={isActive} onOpenChange={(open) => setActive(open)}>
|
||||||
<Popover.Trigger
|
<Popover.Trigger
|
||||||
name={group}
|
|
||||||
type="button"
|
type="button"
|
||||||
aria-label={label}
|
aria-label={label}
|
||||||
onClick={() => setActive(!isActive)}
|
onClick={() => setActive(!isActive)}
|
||||||
ref={rPickerButton}
|
|
||||||
className={isActive ? "active" : ""}
|
className={isActive ? "active" : ""}
|
||||||
>
|
>
|
||||||
{options.find((option) => option.value === value)?.icon}
|
{selectedOption?.icon}
|
||||||
</Popover.Trigger>
|
</Popover.Trigger>
|
||||||
{isActive && (
|
{isActive && (
|
||||||
<Picker
|
<Picker
|
||||||
options={options}
|
visibleSections={visibleSections}
|
||||||
|
hiddenSections={hiddenSections}
|
||||||
value={value}
|
value={value}
|
||||||
label={label}
|
label={label}
|
||||||
onChange={onChange}
|
onChange={onChange}
|
||||||
onClose={() => {
|
onClose={() => {
|
||||||
setActive(false);
|
setActive(false);
|
||||||
}}
|
}}
|
||||||
numberOfOptionsToAlwaysShow={numberOfOptionsToAlwaysShow}
|
|
||||||
/>
|
/>
|
||||||
)}
|
)}
|
||||||
</Popover.Root>
|
</Popover.Root>
|
||||||
|
|||||||
@@ -650,8 +650,7 @@ const LayerUI = ({
|
|||||||
};
|
};
|
||||||
|
|
||||||
const stripIrrelevantAppStateProps = (appState: AppState): UIAppState => {
|
const stripIrrelevantAppStateProps = (appState: AppState): UIAppState => {
|
||||||
const { startBoundElement, cursorButton, scrollX, scrollY, ...ret } =
|
const { cursorButton, scrollX, scrollY, ...ret } = appState;
|
||||||
appState;
|
|
||||||
return ret;
|
return ret;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -199,6 +199,7 @@ export default function LibraryMenuItems({
|
|||||||
type: "everything",
|
type: "everything",
|
||||||
elements: item.elements,
|
elements: item.elements,
|
||||||
randomizeSeed: true,
|
randomizeSeed: true,
|
||||||
|
preserveFrameChildrenOrder: true,
|
||||||
}).duplicatedElements,
|
}).duplicatedElements,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -26,13 +26,16 @@
|
|||||||
background: var(--RadioGroup-background);
|
background: var(--RadioGroup-background);
|
||||||
border: 1px solid var(--RadioGroup-border);
|
border: 1px solid var(--RadioGroup-border);
|
||||||
|
|
||||||
|
gap: 2px;
|
||||||
|
|
||||||
&__choice {
|
&__choice {
|
||||||
position: relative;
|
position: relative;
|
||||||
display: flex;
|
display: flex;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
justify-content: center;
|
justify-content: center;
|
||||||
width: 32px;
|
min-width: 20px;
|
||||||
height: 24px;
|
height: 24px;
|
||||||
|
padding: 0 0.375rem;
|
||||||
|
|
||||||
color: var(--RadioGroup-choice-color-off);
|
color: var(--RadioGroup-choice-color-off);
|
||||||
background: var(--RadioGroup-choice-background-off);
|
background: var(--RadioGroup-choice-background-off);
|
||||||
|
|||||||
@@ -1,74 +1,78 @@
|
|||||||
import React, { useEffect } from "react";
|
import React, { useEffect } from "react";
|
||||||
|
|
||||||
import { t } from "../i18n";
|
|
||||||
|
|
||||||
import "./Range.scss";
|
import "./Range.scss";
|
||||||
|
|
||||||
import type { AppClassProperties } from "../types";
|
|
||||||
|
|
||||||
export type RangeProps = {
|
export type RangeProps = {
|
||||||
updateData: (value: number) => void;
|
label: React.ReactNode;
|
||||||
app: AppClassProperties;
|
value: number;
|
||||||
|
onChange: (value: number) => void;
|
||||||
|
min?: number;
|
||||||
|
max?: number;
|
||||||
|
step?: number;
|
||||||
|
minLabel?: React.ReactNode;
|
||||||
|
hasCommonValue?: boolean;
|
||||||
testId?: string;
|
testId?: string;
|
||||||
};
|
};
|
||||||
|
|
||||||
export const Range = ({ updateData, app, testId }: RangeProps) => {
|
export const Range = ({
|
||||||
|
label,
|
||||||
|
value,
|
||||||
|
onChange,
|
||||||
|
min = 0,
|
||||||
|
max = 100,
|
||||||
|
step = 10,
|
||||||
|
minLabel = min,
|
||||||
|
hasCommonValue = true,
|
||||||
|
testId,
|
||||||
|
}: RangeProps) => {
|
||||||
const rangeRef = React.useRef<HTMLInputElement>(null);
|
const rangeRef = React.useRef<HTMLInputElement>(null);
|
||||||
const valueRef = React.useRef<HTMLDivElement>(null);
|
const valueRef = React.useRef<HTMLDivElement>(null);
|
||||||
const selectedElements = app.scene.getSelectedElements(app.state);
|
|
||||||
let hasCommonOpacity = true;
|
|
||||||
const firstElement = selectedElements.at(0);
|
|
||||||
const leastCommonOpacity = selectedElements.reduce((acc, element) => {
|
|
||||||
if (acc != null && acc !== element.opacity) {
|
|
||||||
hasCommonOpacity = false;
|
|
||||||
}
|
|
||||||
if (acc == null || acc > element.opacity) {
|
|
||||||
return element.opacity;
|
|
||||||
}
|
|
||||||
return acc;
|
|
||||||
}, firstElement?.opacity ?? null);
|
|
||||||
|
|
||||||
const value = leastCommonOpacity ?? app.state.currentItemOpacity;
|
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (rangeRef.current && valueRef.current) {
|
if (rangeRef.current && valueRef.current) {
|
||||||
const rangeElement = rangeRef.current;
|
const rangeElement = rangeRef.current;
|
||||||
const valueElement = valueRef.current;
|
const valueElement = valueRef.current;
|
||||||
const inputWidth = rangeElement.offsetWidth;
|
const inputWidth = rangeElement.offsetWidth;
|
||||||
const thumbWidth = 15; // 15 is the width of the thumb
|
const thumbWidth =
|
||||||
|
parseFloat(
|
||||||
|
getComputedStyle(rangeElement).getPropertyValue(
|
||||||
|
"--slider-thumb-size",
|
||||||
|
),
|
||||||
|
) || 16;
|
||||||
|
const progress = ((value - min) / (max - min || 1)) * 100;
|
||||||
const position =
|
const position =
|
||||||
(value / 100) * (inputWidth - thumbWidth) + thumbWidth / 2;
|
(progress / 100) * (inputWidth - thumbWidth) + thumbWidth / 2;
|
||||||
valueElement.style.left = `${position}px`;
|
valueElement.style.left = `${position}px`;
|
||||||
rangeElement.style.background = `linear-gradient(to right, var(--color-slider-track) 0%, var(--color-slider-track) ${value}%, var(--button-bg) ${value}%, var(--button-bg) 100%)`;
|
rangeElement.style.background = `linear-gradient(to right, var(--color-slider-track) 0%, var(--color-slider-track) ${progress}%, var(--button-bg) ${progress}%, var(--button-bg) 100%)`;
|
||||||
}
|
}
|
||||||
}, [value]);
|
}, [max, min, value]);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<label className="control-label">
|
<label className="control-label">
|
||||||
{t("labels.opacity")}
|
{label}
|
||||||
<div className="range-wrapper">
|
<div className="range-wrapper">
|
||||||
<input
|
<input
|
||||||
style={{
|
style={{
|
||||||
["--color-slider-track" as string]: hasCommonOpacity
|
["--color-slider-track" as string]: hasCommonValue
|
||||||
? undefined
|
? undefined
|
||||||
: "var(--button-bg)",
|
: "var(--button-bg)",
|
||||||
}}
|
}}
|
||||||
ref={rangeRef}
|
ref={rangeRef}
|
||||||
type="range"
|
type="range"
|
||||||
min="0"
|
min={min}
|
||||||
max="100"
|
max={max}
|
||||||
step="10"
|
step={step}
|
||||||
onChange={(event) => {
|
onChange={(event) => {
|
||||||
updateData(+event.target.value);
|
onChange(+event.target.value);
|
||||||
}}
|
}}
|
||||||
value={value}
|
value={value}
|
||||||
className="range-input"
|
className="range-input"
|
||||||
data-testid={testId}
|
data-testid={testId}
|
||||||
/>
|
/>
|
||||||
<div className="value-bubble" ref={valueRef}>
|
<div className="value-bubble" ref={valueRef}>
|
||||||
{value !== 0 ? value : null}
|
{value !== min ? value : null}
|
||||||
</div>
|
</div>
|
||||||
<div className="zero-label">0</div>
|
<div className="zero-label">{minLabel}</div>
|
||||||
</div>
|
</div>
|
||||||
</label>
|
</label>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ import { useEffect, useRef } from "react";
|
|||||||
|
|
||||||
import "./SVGLayer.scss";
|
import "./SVGLayer.scss";
|
||||||
|
|
||||||
import type { Trail } from "../animated-trail";
|
import type { Trail } from "../animatedTrail";
|
||||||
|
|
||||||
type SVGLayerProps = {
|
type SVGLayerProps = {
|
||||||
trails: Trail[];
|
trails: Trail[];
|
||||||
|
|||||||
@@ -206,7 +206,6 @@ const handleDimensionChange: DragInputCallbackType<
|
|||||||
scene.getElementsIncludingDeleted(),
|
scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
scene.replaceAllElements(updatedElements);
|
scene.replaceAllElements(updatedElements);
|
||||||
@@ -302,7 +301,6 @@ const handleDragFinished: DragFinishedCallbackType = ({
|
|||||||
app.scene.getElementsIncludingDeleted(),
|
app.scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
app.scene.replaceAllElements(updatedElements);
|
app.scene.replaceAllElements(updatedElements);
|
||||||
|
|||||||
@@ -261,7 +261,6 @@ const handleDimensionChange: DragInputCallbackType<
|
|||||||
scene.getElementsIncludingDeleted(),
|
scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
scene.replaceAllElements(updatedElements);
|
scene.replaceAllElements(updatedElements);
|
||||||
@@ -416,7 +415,6 @@ const handleDragFinished: DragFinishedCallbackType = ({
|
|||||||
app.scene.getElementsIncludingDeleted(),
|
app.scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
app.scene.replaceAllElements(updatedElements);
|
app.scene.replaceAllElements(updatedElements);
|
||||||
|
|||||||
@@ -361,12 +361,10 @@ describe("stats for a non-generic element", () => {
|
|||||||
mouse.clickAt(20, 30);
|
mouse.clickAt(20, 30);
|
||||||
const editor = await getTextEditor();
|
const editor = await getTextEditor();
|
||||||
updateTextEditor(editor, "Hello!");
|
updateTextEditor(editor, "Hello!");
|
||||||
act(() => {
|
Keyboard.exitTextEditor(editor);
|
||||||
editor.blur();
|
|
||||||
});
|
|
||||||
|
|
||||||
const text = h.elements[0] as ExcalidrawTextElement;
|
const text = h.elements[0] as ExcalidrawTextElement;
|
||||||
mouse.clickOn(text);
|
API.setSelectedElements([text]);
|
||||||
|
|
||||||
elementStats = stats?.querySelector("#elementStats");
|
elementStats = stats?.querySelector("#elementStats");
|
||||||
|
|
||||||
@@ -752,7 +750,7 @@ describe("frame resizing behavior", () => {
|
|||||||
x: 0,
|
x: 0,
|
||||||
y: 0,
|
y: 0,
|
||||||
width: 100,
|
width: 100,
|
||||||
height: 100,
|
height: 103,
|
||||||
});
|
});
|
||||||
|
|
||||||
// Create a rectangle outside the frame
|
// Create a rectangle outside the frame
|
||||||
|
|||||||
@@ -236,15 +236,40 @@ const MermaidToExcalidraw = ({
|
|||||||
<Trans
|
<Trans
|
||||||
i18nKey="mermaid.description"
|
i18nKey="mermaid.description"
|
||||||
flowchartLink={(el) => (
|
flowchartLink={(el) => (
|
||||||
<a href="https://mermaid.js.org/syntax/flowchart.html">{el}</a>
|
<a
|
||||||
|
href="https://mermaid.js.org/syntax/flowchart.html"
|
||||||
|
target="_blank"
|
||||||
|
rel="noreferrer"
|
||||||
|
>
|
||||||
|
{el}
|
||||||
|
</a>
|
||||||
)}
|
)}
|
||||||
sequenceLink={(el) => (
|
sequenceLink={(el) => (
|
||||||
<a href="https://mermaid.js.org/syntax/sequenceDiagram.html">
|
<a
|
||||||
|
href="https://mermaid.js.org/syntax/sequenceDiagram.html"
|
||||||
|
target="_blank"
|
||||||
|
rel="noreferrer"
|
||||||
|
>
|
||||||
{el}
|
{el}
|
||||||
</a>
|
</a>
|
||||||
)}
|
)}
|
||||||
classLink={(el) => (
|
classLink={(el) => (
|
||||||
<a href="https://mermaid.js.org/syntax/classDiagram.html">{el}</a>
|
<a
|
||||||
|
href="https://mermaid.js.org/syntax/classDiagram.html"
|
||||||
|
target="_blank"
|
||||||
|
rel="noreferrer"
|
||||||
|
>
|
||||||
|
{el}
|
||||||
|
</a>
|
||||||
|
)}
|
||||||
|
erdLink={(el) => (
|
||||||
|
<a
|
||||||
|
href="https://mermaid.js.org/syntax/entityRelationshipDiagram.html"
|
||||||
|
target="_blank"
|
||||||
|
rel="noreferrer"
|
||||||
|
>
|
||||||
|
{el}
|
||||||
|
</a>
|
||||||
)}
|
)}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -94,7 +94,7 @@ export const convertMermaidToExcalidraw = async ({
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const { elements, files } = ret;
|
const { elements, files = {} } = ret;
|
||||||
setError(null);
|
setError(null);
|
||||||
|
|
||||||
data.current = {
|
data.current = {
|
||||||
|
|||||||
@@ -39,7 +39,7 @@ type InteractiveCanvasProps = {
|
|||||||
visibleElements: readonly NonDeletedExcalidrawElement[];
|
visibleElements: readonly NonDeletedExcalidrawElement[];
|
||||||
selectedElements: readonly NonDeletedExcalidrawElement[];
|
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||||
allElementsMap: NonDeletedSceneElementsMap;
|
allElementsMap: NonDeletedSceneElementsMap;
|
||||||
sceneNonce: number | undefined;
|
canvasNonce: string;
|
||||||
selectionNonce: number | undefined;
|
selectionNonce: number | undefined;
|
||||||
scale: number;
|
scale: number;
|
||||||
appState: InteractiveCanvasAppState;
|
appState: InteractiveCanvasAppState;
|
||||||
@@ -54,6 +54,7 @@ type InteractiveCanvasProps = {
|
|||||||
DOMAttributes<HTMLCanvasElement | HTMLDivElement>["onContextMenu"],
|
DOMAttributes<HTMLCanvasElement | HTMLDivElement>["onContextMenu"],
|
||||||
undefined
|
undefined
|
||||||
>;
|
>;
|
||||||
|
onClick: Exclude<DOMAttributes<HTMLCanvasElement>["onClick"], undefined>;
|
||||||
onPointerMove: Exclude<
|
onPointerMove: Exclude<
|
||||||
DOMAttributes<HTMLCanvasElement>["onPointerMove"],
|
DOMAttributes<HTMLCanvasElement>["onPointerMove"],
|
||||||
undefined
|
undefined
|
||||||
@@ -213,6 +214,7 @@ const InteractiveCanvas = (props: InteractiveCanvasProps) => {
|
|||||||
height={props.appState.height * props.scale}
|
height={props.appState.height * props.scale}
|
||||||
ref={props.handleCanvasRef}
|
ref={props.handleCanvasRef}
|
||||||
onContextMenu={props.onContextMenu}
|
onContextMenu={props.onContextMenu}
|
||||||
|
onClick={props.onClick}
|
||||||
onPointerMove={props.onPointerMove}
|
onPointerMove={props.onPointerMove}
|
||||||
onPointerUp={props.onPointerUp}
|
onPointerUp={props.onPointerUp}
|
||||||
onPointerCancel={props.onPointerCancel}
|
onPointerCancel={props.onPointerCancel}
|
||||||
@@ -277,10 +279,10 @@ const areEqual = (
|
|||||||
// This could be further optimised if needed, as we don't have to render interactive canvas on each scene mutation
|
// This could be further optimised if needed, as we don't have to render interactive canvas on each scene mutation
|
||||||
if (
|
if (
|
||||||
prevProps.selectionNonce !== nextProps.selectionNonce ||
|
prevProps.selectionNonce !== nextProps.selectionNonce ||
|
||||||
prevProps.sceneNonce !== nextProps.sceneNonce ||
|
prevProps.canvasNonce !== nextProps.canvasNonce ||
|
||||||
prevProps.scale !== nextProps.scale ||
|
prevProps.scale !== nextProps.scale ||
|
||||||
// we need to memoize on elementsMap because they may have renewed
|
// we need to memoize on elementsMap because they may have renewed
|
||||||
// even if sceneNonce didn't change (e.g. we filter elements out based
|
// even if canvasNonce didn't change (e.g. we filter elements out based
|
||||||
// on appState)
|
// on appState)
|
||||||
prevProps.elementsMap !== nextProps.elementsMap ||
|
prevProps.elementsMap !== nextProps.elementsMap ||
|
||||||
prevProps.visibleElements !== nextProps.visibleElements ||
|
prevProps.visibleElements !== nextProps.visibleElements ||
|
||||||
|
|||||||
@@ -14,6 +14,7 @@ import type { RoughCanvas } from "roughjs/bin/canvas";
|
|||||||
|
|
||||||
interface NewElementCanvasProps {
|
interface NewElementCanvasProps {
|
||||||
appState: AppState;
|
appState: AppState;
|
||||||
|
newElement: NonNullable<AppState["newElement"]>;
|
||||||
elementsMap: RenderableElementsMap;
|
elementsMap: RenderableElementsMap;
|
||||||
allElementsMap: NonDeletedSceneElementsMap;
|
allElementsMap: NonDeletedSceneElementsMap;
|
||||||
scale: number;
|
scale: number;
|
||||||
@@ -31,7 +32,7 @@ const NewElementCanvas = (props: NewElementCanvasProps) => {
|
|||||||
{
|
{
|
||||||
canvas: canvasRef.current,
|
canvas: canvasRef.current,
|
||||||
scale: props.scale,
|
scale: props.scale,
|
||||||
newElement: props.appState.newElement,
|
newElement: props.newElement,
|
||||||
elementsMap: props.elementsMap,
|
elementsMap: props.elementsMap,
|
||||||
allElementsMap: props.allElementsMap,
|
allElementsMap: props.allElementsMap,
|
||||||
rc: props.rc,
|
rc: props.rc,
|
||||||
|
|||||||
@@ -23,7 +23,7 @@ type StaticCanvasProps = {
|
|||||||
elementsMap: RenderableElementsMap;
|
elementsMap: RenderableElementsMap;
|
||||||
allElementsMap: NonDeletedSceneElementsMap;
|
allElementsMap: NonDeletedSceneElementsMap;
|
||||||
visibleElements: readonly NonDeletedExcalidrawElement[];
|
visibleElements: readonly NonDeletedExcalidrawElement[];
|
||||||
sceneNonce: number | undefined;
|
canvasNonce: string;
|
||||||
selectionNonce: number | undefined;
|
selectionNonce: number | undefined;
|
||||||
scale: number;
|
scale: number;
|
||||||
appState: StaticCanvasAppState;
|
appState: StaticCanvasAppState;
|
||||||
@@ -110,10 +110,10 @@ const areEqual = (
|
|||||||
nextProps: StaticCanvasProps,
|
nextProps: StaticCanvasProps,
|
||||||
) => {
|
) => {
|
||||||
if (
|
if (
|
||||||
prevProps.sceneNonce !== nextProps.sceneNonce ||
|
prevProps.canvasNonce !== nextProps.canvasNonce ||
|
||||||
prevProps.scale !== nextProps.scale ||
|
prevProps.scale !== nextProps.scale ||
|
||||||
// we need to memoize on elementsMap because they may have renewed
|
// we need to memoize on elementsMap because they may have renewed
|
||||||
// even if sceneNonce didn't change (e.g. we filter elements out based
|
// even if canvasNonce didn't change (e.g. we filter elements out based
|
||||||
// on appState)
|
// on appState)
|
||||||
prevProps.elementsMap !== nextProps.elementsMap ||
|
prevProps.elementsMap !== nextProps.elementsMap ||
|
||||||
prevProps.visibleElements !== nextProps.visibleElements
|
prevProps.visibleElements !== nextProps.visibleElements
|
||||||
|
|||||||
@@ -2,7 +2,7 @@
|
|||||||
|
|
||||||
.excalidraw {
|
.excalidraw {
|
||||||
.dropdown-menu {
|
.dropdown-menu {
|
||||||
max-width: 16rem;
|
max-width: 20rem;
|
||||||
z-index: 1;
|
z-index: 1;
|
||||||
|
|
||||||
&--placement-top {
|
&--placement-top {
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import { useEditorInterface } from "../App";
|
import { useEditorInterface } from "../App";
|
||||||
|
import { Ellipsify } from "../Ellipsify";
|
||||||
import { RadioGroup } from "../RadioGroup";
|
import { RadioGroup } from "../RadioGroup";
|
||||||
|
|
||||||
type Props<T> = {
|
type Props<T> = {
|
||||||
@@ -12,6 +13,7 @@ type Props<T> = {
|
|||||||
onChange: (value: T) => void;
|
onChange: (value: T) => void;
|
||||||
children: React.ReactNode;
|
children: React.ReactNode;
|
||||||
name: string;
|
name: string;
|
||||||
|
icon?: React.ReactNode;
|
||||||
};
|
};
|
||||||
|
|
||||||
const DropdownMenuItemContentRadio = <T,>({
|
const DropdownMenuItemContentRadio = <T,>({
|
||||||
@@ -21,13 +23,17 @@ const DropdownMenuItemContentRadio = <T,>({
|
|||||||
choices,
|
choices,
|
||||||
children,
|
children,
|
||||||
name,
|
name,
|
||||||
|
icon,
|
||||||
}: Props<T>) => {
|
}: Props<T>) => {
|
||||||
const editorInterface = useEditorInterface();
|
const editorInterface = useEditorInterface();
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
<div className="dropdown-menu-item-base dropdown-menu-item-bare">
|
<div className="dropdown-menu-item-base dropdown-menu-item-bare">
|
||||||
<label className="dropdown-menu-item__text">{children}</label>
|
{icon && <div className="dropdown-menu-item__icon">{icon}</div>}
|
||||||
|
<label className="dropdown-menu-item__text">
|
||||||
|
<Ellipsify>{children}</Ellipsify>
|
||||||
|
</label>
|
||||||
<RadioGroup
|
<RadioGroup
|
||||||
name={name}
|
name={name}
|
||||||
value={value}
|
value={value}
|
||||||
|
|||||||
@@ -69,6 +69,11 @@ const modifiedTablerIconProps: Opts = {
|
|||||||
strokeLinejoin: "round",
|
strokeLinejoin: "round",
|
||||||
} as const;
|
} as const;
|
||||||
|
|
||||||
|
const arrowheadPreviewIconProps: Opts = {
|
||||||
|
width: 40,
|
||||||
|
height: 20,
|
||||||
|
} as const;
|
||||||
|
|
||||||
// -----------------------------------------------------------------------------
|
// -----------------------------------------------------------------------------
|
||||||
|
|
||||||
// tabler-icons: present
|
// tabler-icons: present
|
||||||
@@ -1291,16 +1296,17 @@ export const ArrowheadNoneIcon = React.memo(
|
|||||||
({ flip = false }: { flip?: boolean }) =>
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
createIcon(
|
createIcon(
|
||||||
<g
|
<g
|
||||||
transform={flip ? "translate(24, 0) scale(-1, 1)" : ""}
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
stroke="currentColor"
|
stroke="currentColor"
|
||||||
opacity={0.3}
|
opacity={0.3}
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
|
fill="none"
|
||||||
|
strokeLinecap="round"
|
||||||
>
|
>
|
||||||
<path d="M12 12l-9 0" />
|
<path d="M7,11 H19" />
|
||||||
<path d="M21 9l-6 6" />
|
<path d="M25,6 L33,16 M33,6 L25,16" />
|
||||||
<path d="M21 15l-6 -6" />
|
|
||||||
</g>,
|
</g>,
|
||||||
tablerIconProps,
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -1312,57 +1318,12 @@ export const ArrowheadArrowIcon = React.memo(
|
|||||||
stroke="currentColor"
|
stroke="currentColor"
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
fill="none"
|
fill="none"
|
||||||
|
strokeLinecap="round"
|
||||||
|
strokeLinejoin="round"
|
||||||
>
|
>
|
||||||
<path d="M34 10H6M34 10L27 5M34 10L27 15" />
|
<path d="M7,11 H33 M23,5 L33,11 L23,17" />
|
||||||
<path d="M27.5 5L34.5 10L27.5 15" />
|
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
),
|
|
||||||
);
|
|
||||||
|
|
||||||
export const ArrowheadCircleIcon = React.memo(
|
|
||||||
({ flip = false }: { flip?: boolean }) =>
|
|
||||||
createIcon(
|
|
||||||
<g
|
|
||||||
stroke="currentColor"
|
|
||||||
fill="currentColor"
|
|
||||||
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
|
||||||
>
|
|
||||||
<path d="M32 10L6 10" strokeWidth={2} />
|
|
||||||
<circle r="4" transform="matrix(-1 0 0 1 30 10)" />
|
|
||||||
</g>,
|
|
||||||
{ width: 40, height: 20 },
|
|
||||||
),
|
|
||||||
);
|
|
||||||
|
|
||||||
export const ArrowheadCircleOutlineIcon = React.memo(
|
|
||||||
({ flip = false }: { flip?: boolean }) =>
|
|
||||||
createIcon(
|
|
||||||
<g
|
|
||||||
stroke="currentColor"
|
|
||||||
fill="none"
|
|
||||||
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
|
||||||
strokeWidth={2}
|
|
||||||
>
|
|
||||||
<path d="M26 10L6 10" />
|
|
||||||
<circle r="4" transform="matrix(-1 0 0 1 30 10)" />
|
|
||||||
</g>,
|
|
||||||
{ width: 40, height: 20 },
|
|
||||||
),
|
|
||||||
);
|
|
||||||
|
|
||||||
export const ArrowheadBarIcon = React.memo(
|
|
||||||
({ flip = false }: { flip?: boolean }) =>
|
|
||||||
createIcon(
|
|
||||||
<g transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}>
|
|
||||||
<path
|
|
||||||
d="M34 10H5.99996M34 10L34 5M34 10L34 15"
|
|
||||||
stroke="currentColor"
|
|
||||||
strokeWidth={2}
|
|
||||||
fill="none"
|
|
||||||
/>
|
|
||||||
</g>,
|
|
||||||
{ width: 40, height: 20 },
|
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -1373,11 +1334,12 @@ export const ArrowheadTriangleIcon = React.memo(
|
|||||||
stroke="currentColor"
|
stroke="currentColor"
|
||||||
fill="currentColor"
|
fill="currentColor"
|
||||||
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
|
strokeLinejoin="round"
|
||||||
>
|
>
|
||||||
<path d="M32 10L6 10" strokeWidth={2} />
|
<path d="M7,11 H23" strokeWidth={2} strokeLinecap="round" />
|
||||||
<path d="M27.5 5.5L34.5 10L27.5 14.5L27.5 5.5" />
|
<path d="M23,5 L35,11 L23,17 Z" />
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -1390,12 +1352,43 @@ export const ArrowheadTriangleOutlineIcon = React.memo(
|
|||||||
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
strokeLinejoin="round"
|
strokeLinejoin="round"
|
||||||
|
strokeLinecap="round"
|
||||||
>
|
>
|
||||||
<path d="M6,9.5H27" />
|
<path d="M7,11 H23" />
|
||||||
<path d="M27,5L34,10L27,14Z" fill="none" />
|
<path d="M23,5 L35,11 L23,17 Z" />
|
||||||
</g>,
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
{ width: 40, height: 20 },
|
export const ArrowheadCircleIcon = React.memo(
|
||||||
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
|
createIcon(
|
||||||
|
<g
|
||||||
|
stroke="currentColor"
|
||||||
|
fill="currentColor"
|
||||||
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
|
>
|
||||||
|
<path d="M7,11 H25" strokeWidth={2} strokeLinecap="round" />
|
||||||
|
<circle cx="29" cy="11" r="4" />
|
||||||
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
export const ArrowheadCircleOutlineIcon = React.memo(
|
||||||
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
|
createIcon(
|
||||||
|
<g
|
||||||
|
stroke="currentColor"
|
||||||
|
fill="none"
|
||||||
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
|
strokeWidth={2}
|
||||||
|
>
|
||||||
|
<path d="M7,11 H25" strokeLinecap="round" />
|
||||||
|
<circle cx="29" cy="11" r="4" />
|
||||||
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -1407,12 +1400,11 @@ export const ArrowheadDiamondIcon = React.memo(
|
|||||||
fill="currentColor"
|
fill="currentColor"
|
||||||
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
strokeLinejoin="round"
|
strokeLinejoin="round"
|
||||||
strokeWidth={2}
|
|
||||||
>
|
>
|
||||||
<path d="M6,9.5H20" />
|
<path d="M7,11 H21" strokeWidth={2} strokeLinecap="round" />
|
||||||
<path d="M27,5L34,10L27,14L20,9.5Z" />
|
<path d="M21,11 L28,5 L35,11 L28,17 Z" />
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -1425,15 +1417,32 @@ export const ArrowheadDiamondOutlineIcon = React.memo(
|
|||||||
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
strokeLinejoin="round"
|
strokeLinejoin="round"
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
|
strokeLinecap="round"
|
||||||
>
|
>
|
||||||
<path d="M6,9.5H20" />
|
<path d="M7,11 H21" />
|
||||||
<path d="M27,5L34,10L27,14L20,9.5Z" />
|
<path d="M21,11 L28,5 L35,11 L28,17 Z" />
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
export const ArrowheadCrowfootIcon = React.memo(
|
export const ArrowheadBarIcon = React.memo(
|
||||||
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
|
createIcon(
|
||||||
|
<g
|
||||||
|
transform={flip ? "translate(40, 0) scale(-1, 1)" : ""}
|
||||||
|
stroke="currentColor"
|
||||||
|
strokeWidth={2}
|
||||||
|
fill="none"
|
||||||
|
strokeLinecap="round"
|
||||||
|
>
|
||||||
|
<path d="M11,11 H31 M31,5 V17" />
|
||||||
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
export const ArrowheadCardinalityOneIcon = React.memo(
|
||||||
({ flip = false }: { flip?: boolean }) =>
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
createIcon(
|
createIcon(
|
||||||
<g
|
<g
|
||||||
@@ -1443,13 +1452,13 @@ export const ArrowheadCrowfootIcon = React.memo(
|
|||||||
strokeLinejoin="round"
|
strokeLinejoin="round"
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
>
|
>
|
||||||
<path d="M34,10 H6 M15,10 L7,5 M15,10 L7,15" />
|
<path d="M35,11 H7 M15,5 V17" />
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
export const ArrowheadCrowfootOneIcon = React.memo(
|
export const ArrowheadCardinalityManyIcon = React.memo(
|
||||||
({ flip = false }: { flip?: boolean }) =>
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
createIcon(
|
createIcon(
|
||||||
<g
|
<g
|
||||||
@@ -1459,13 +1468,13 @@ export const ArrowheadCrowfootOneIcon = React.memo(
|
|||||||
strokeLinejoin="round"
|
strokeLinejoin="round"
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
>
|
>
|
||||||
<path d="M34,10 H6 M15,10 L15,15 L15,5" />
|
<path d="M35,11 H7 M15,11 L7,5 M15,11 L7,17" />
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
export const ArrowheadCrowfootOneOrManyIcon = React.memo(
|
export const ArrowheadCardinalityOneOrManyIcon = React.memo(
|
||||||
({ flip = false }: { flip?: boolean }) =>
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
createIcon(
|
createIcon(
|
||||||
<g
|
<g
|
||||||
@@ -1475,9 +1484,59 @@ export const ArrowheadCrowfootOneOrManyIcon = React.memo(
|
|||||||
strokeLinejoin="round"
|
strokeLinejoin="round"
|
||||||
strokeWidth={2}
|
strokeWidth={2}
|
||||||
>
|
>
|
||||||
<path d="M34,10 H6 M15,10 L15,16 L15,4 M15,10 L7,5 M15,10 L7,15" />
|
<path d="M35,11 H7 M23,5 V17 M15,11 L7,5 M15,11 L7,17" />
|
||||||
</g>,
|
</g>,
|
||||||
{ width: 40, height: 20 },
|
arrowheadPreviewIconProps,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
export const ArrowheadCardinalityExactlyOneIcon = React.memo(
|
||||||
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
|
createIcon(
|
||||||
|
<g
|
||||||
|
stroke="currentColor"
|
||||||
|
fill="none"
|
||||||
|
transform={flip ? "" : "translate(40, 0) scale(-1, 1)"}
|
||||||
|
strokeLinejoin="round"
|
||||||
|
strokeWidth={2}
|
||||||
|
>
|
||||||
|
<path d="M35,11 H7 M15,5 V17 M7,5 V17" />
|
||||||
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
export const ArrowheadCardinalityZeroOrOneIcon = React.memo(
|
||||||
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
|
createIcon(
|
||||||
|
<g
|
||||||
|
stroke="currentColor"
|
||||||
|
fill="none"
|
||||||
|
transform={flip ? "" : "translate(40, 0) scale(-1, 1)"}
|
||||||
|
strokeLinejoin="round"
|
||||||
|
strokeWidth={2}
|
||||||
|
>
|
||||||
|
<path d="M35,11 H19 M11,11 H7 M7,5 V17" />
|
||||||
|
<circle cx="15" cy="11" r="4" />
|
||||||
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
export const ArrowheadCardinalityZeroOrManyIcon = React.memo(
|
||||||
|
({ flip = false }: { flip?: boolean }) =>
|
||||||
|
createIcon(
|
||||||
|
<g
|
||||||
|
stroke="currentColor"
|
||||||
|
fill="none"
|
||||||
|
transform={flip ? "" : "translate(40, 0) scale(-1, 1)"}
|
||||||
|
strokeLinejoin="round"
|
||||||
|
strokeWidth={2}
|
||||||
|
>
|
||||||
|
<path d="M35,11 H27 M19,11 H7 M15,11 L7,5 M15,11 L7,17" />
|
||||||
|
<circle cx="23" cy="11" r="4" />
|
||||||
|
</g>,
|
||||||
|
arrowheadPreviewIconProps,
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -39,7 +39,13 @@ import DropdownMenuItemCheckbox from "../dropdownMenu/DropdownMenuItemCheckbox";
|
|||||||
import DropdownMenuItemContentRadio from "../dropdownMenu/DropdownMenuItemContentRadio";
|
import DropdownMenuItemContentRadio from "../dropdownMenu/DropdownMenuItemContentRadio";
|
||||||
import DropdownMenuItemLink from "../dropdownMenu/DropdownMenuItemLink";
|
import DropdownMenuItemLink from "../dropdownMenu/DropdownMenuItemLink";
|
||||||
import DropdownMenuSub from "../dropdownMenu/DropdownMenuSub";
|
import DropdownMenuSub from "../dropdownMenu/DropdownMenuSub";
|
||||||
import { GithubIcon, DiscordIcon, XBrandIcon, settingsIcon } from "../icons";
|
import {
|
||||||
|
GithubIcon,
|
||||||
|
DiscordIcon,
|
||||||
|
XBrandIcon,
|
||||||
|
settingsIcon,
|
||||||
|
emptyIcon,
|
||||||
|
} from "../icons";
|
||||||
import {
|
import {
|
||||||
boltIcon,
|
boltIcon,
|
||||||
DeviceDesktopIcon,
|
DeviceDesktopIcon,
|
||||||
@@ -427,6 +433,39 @@ const PreferencesToggleToolLockItem = () => {
|
|||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const PreferencesBoxSelectionModeItem = () => {
|
||||||
|
const { t } = useI18n();
|
||||||
|
const appState = useUIAppState();
|
||||||
|
const setAppState = useExcalidrawSetAppState();
|
||||||
|
|
||||||
|
return (
|
||||||
|
<DropdownMenuItemContentRadio<"contain" | "overlap">
|
||||||
|
name="boxSelectionMode"
|
||||||
|
icon={emptyIcon}
|
||||||
|
value={appState.boxSelectionMode}
|
||||||
|
onChange={(value) => {
|
||||||
|
setAppState({
|
||||||
|
boxSelectionMode: value,
|
||||||
|
});
|
||||||
|
}}
|
||||||
|
choices={[
|
||||||
|
{
|
||||||
|
value: "contain",
|
||||||
|
label: t("labels.boxSelectionContain"),
|
||||||
|
ariaLabel: t("labels.boxSelectionContain"),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
value: "overlap",
|
||||||
|
label: t("labels.boxSelectionOverlap"),
|
||||||
|
ariaLabel: t("labels.boxSelectionOverlap"),
|
||||||
|
},
|
||||||
|
]}
|
||||||
|
>
|
||||||
|
{t("labels.boxSelectionMode")}
|
||||||
|
</DropdownMenuItemContentRadio>
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
const PreferencesToggleSnapModeItem = () => {
|
const PreferencesToggleSnapModeItem = () => {
|
||||||
const { t } = useI18n();
|
const { t } = useI18n();
|
||||||
const actionManager = useExcalidrawActionManager();
|
const actionManager = useExcalidrawActionManager();
|
||||||
@@ -568,6 +607,7 @@ export const Preferences = ({
|
|||||||
<DropdownMenuSub.Content className="excalidraw-main-menu-preferences-submenu">
|
<DropdownMenuSub.Content className="excalidraw-main-menu-preferences-submenu">
|
||||||
{children || (
|
{children || (
|
||||||
<>
|
<>
|
||||||
|
<PreferencesBoxSelectionModeItem />
|
||||||
<PreferencesToggleToolLockItem />
|
<PreferencesToggleToolLockItem />
|
||||||
<PreferencesToggleSnapModeItem />
|
<PreferencesToggleSnapModeItem />
|
||||||
<PreferencesToggleGridModeItem />
|
<PreferencesToggleGridModeItem />
|
||||||
@@ -585,6 +625,7 @@ export const Preferences = ({
|
|||||||
};
|
};
|
||||||
|
|
||||||
Preferences.ToggleToolLock = PreferencesToggleToolLockItem;
|
Preferences.ToggleToolLock = PreferencesToggleToolLockItem;
|
||||||
|
Preferences.BoxSelectionMode = PreferencesBoxSelectionModeItem;
|
||||||
Preferences.ToggleSnapMode = PreferencesToggleSnapModeItem;
|
Preferences.ToggleSnapMode = PreferencesToggleSnapModeItem;
|
||||||
Preferences.ToggleArrowBinding = PreferencesToggleArrowBindingItem;
|
Preferences.ToggleArrowBinding = PreferencesToggleArrowBindingItem;
|
||||||
Preferences.ToggleMidpointSnapping = PreferencesToggleMidpointSnappingItem;
|
Preferences.ToggleMidpointSnapping = PreferencesToggleMidpointSnappingItem;
|
||||||
|
|||||||
@@ -119,15 +119,12 @@ export const SHAPES = [
|
|||||||
export const getToolbarTools = (app: AppClassProperties) => {
|
export const getToolbarTools = (app: AppClassProperties) => {
|
||||||
return app.state.preferredSelectionTool.type === "lasso"
|
return app.state.preferredSelectionTool.type === "lasso"
|
||||||
? ([
|
? ([
|
||||||
|
SHAPES[0],
|
||||||
{
|
{
|
||||||
|
...SHAPES[1],
|
||||||
value: "lasso",
|
value: "lasso",
|
||||||
icon: SelectionIcon,
|
|
||||||
key: KEYS.V,
|
|
||||||
numericKey: KEYS["1"],
|
|
||||||
fillable: true,
|
|
||||||
toolbar: true,
|
|
||||||
},
|
},
|
||||||
...SHAPES.slice(1),
|
...SHAPES.slice(2),
|
||||||
] as const)
|
] as const)
|
||||||
: SHAPES;
|
: SHAPES;
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -814,6 +814,14 @@ body.excalidraw-cursor-resize * {
|
|||||||
.excalidraw__embeddable__outer {
|
.excalidraw__embeddable__outer {
|
||||||
width: 100%;
|
width: 100%;
|
||||||
height: 100%;
|
height: 100%;
|
||||||
|
}
|
||||||
|
|
||||||
|
.excalidraw__embeddable__content {
|
||||||
|
width: 100%;
|
||||||
|
height: 100%;
|
||||||
|
transform-origin: top left;
|
||||||
|
|
||||||
|
&,
|
||||||
& > * {
|
& > * {
|
||||||
border-radius: var(--embeddable-radius);
|
border-radius: var(--embeddable-radius);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -34,9 +34,10 @@
|
|||||||
--popup-text-color: #000;
|
--popup-text-color: #000;
|
||||||
--popup-text-inverted-color: #fff;
|
--popup-text-inverted-color: #fff;
|
||||||
--select-highlight-color: #{$color-blue-5};
|
--select-highlight-color: #{$color-blue-5};
|
||||||
--shadow-island: 0px 0px 0.9310142993927002px 0px rgba(0, 0, 0, 0.17),
|
--shadow-island: 0px 0px 1px 0px rgba(0, 0, 0, 0.17),
|
||||||
0px 0px 3.1270833015441895px 0px rgba(0, 0, 0, 0.08),
|
0px 0px 3px 0px rgba(0, 0, 0, 0.08), 0px 7px 14px 0px rgba(0, 0, 0, 0.05);
|
||||||
0px 7px 14px 0px rgba(0, 0, 0, 0.05);
|
--shadow-island-stronger: 0px 0px 1px 0px rgba(0, 0, 0, 0.17),
|
||||||
|
0px 0px 3px 0px rgba(0, 0, 0, 0.08), 0px 7px 14px 0px rgb(0 0 0 / 18%);
|
||||||
|
|
||||||
--button-hover-bg: var(--color-surface-high);
|
--button-hover-bg: var(--color-surface-high);
|
||||||
--button-active-bg: var(--color-surface-high);
|
--button-active-bg: var(--color-surface-high);
|
||||||
@@ -210,9 +211,6 @@
|
|||||||
--popup-text-color: #{$color-gray-4};
|
--popup-text-color: #{$color-gray-4};
|
||||||
--popup-text-inverted-color: #2c2c2c;
|
--popup-text-inverted-color: #2c2c2c;
|
||||||
--select-highlight-color: #{$color-blue-4};
|
--select-highlight-color: #{$color-blue-4};
|
||||||
--shadow-island: 0px 0px 0.9310142993927002px 0px rgba(0, 0, 0, 0.17),
|
|
||||||
0px 0px 3.1270833015441895px 0px rgba(0, 0, 0, 0.08),
|
|
||||||
0px 7px 14px 0px rgba(0, 0, 0, 0.05);
|
|
||||||
|
|
||||||
--modal-shadow: 0px 100px 80px rgba(0, 0, 0, 0.07),
|
--modal-shadow: 0px 100px 80px rgba(0, 0, 0, 0.07),
|
||||||
0px 41.7776px 33.4221px rgba(0, 0, 0, 0.0503198),
|
0px 41.7776px 33.4221px rgba(0, 0, 0, 0.0503198),
|
||||||
|
|||||||
@@ -311,6 +311,48 @@ export const dataURLToString = (dataURL: DataURL) => {
|
|||||||
return base64ToString(dataURL.slice(dataURL.indexOf(",") + 1));
|
return base64ToString(dataURL.slice(dataURL.indexOf(",") + 1));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const getImageFileDimensions = async (file: File) => {
|
||||||
|
const browserURL = typeof window !== "undefined" ? window.URL : undefined;
|
||||||
|
let objectURL: string | null = null;
|
||||||
|
let imageSource: string;
|
||||||
|
|
||||||
|
try {
|
||||||
|
imageSource = browserURL?.createObjectURL
|
||||||
|
? (objectURL = browserURL.createObjectURL(file))
|
||||||
|
: await getDataURL(file);
|
||||||
|
} catch {
|
||||||
|
objectURL = null;
|
||||||
|
imageSource = await getDataURL(file);
|
||||||
|
}
|
||||||
|
|
||||||
|
return new Promise<{ width: number; height: number }>((resolve, reject) => {
|
||||||
|
const image = new Image();
|
||||||
|
|
||||||
|
const cleanup = () => {
|
||||||
|
image.onload = null;
|
||||||
|
image.onerror = null;
|
||||||
|
|
||||||
|
if (objectURL && browserURL?.revokeObjectURL) {
|
||||||
|
browserURL.revokeObjectURL(objectURL);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
image.onload = () => {
|
||||||
|
cleanup();
|
||||||
|
resolve({
|
||||||
|
width: image.naturalWidth || image.width,
|
||||||
|
height: image.naturalHeight || image.height,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
image.onerror = (error) => {
|
||||||
|
cleanup();
|
||||||
|
reject(error);
|
||||||
|
};
|
||||||
|
|
||||||
|
image.src = imageSource;
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
export const resizeImageFile = async (
|
export const resizeImageFile = async (
|
||||||
file: File,
|
file: File,
|
||||||
opts: {
|
opts: {
|
||||||
@@ -324,6 +366,20 @@ export const resizeImageFile = async (
|
|||||||
return file;
|
return file;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!isSupportedImageFile(file)) {
|
||||||
|
throw new Error("Error: unsupported file type", { cause: "UNSUPPORTED" });
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!opts.outputType || opts.outputType === file.type) {
|
||||||
|
const dimensions = await getImageFileDimensions(file);
|
||||||
|
|
||||||
|
if (
|
||||||
|
Math.max(dimensions.width, dimensions.height) <= opts.maxWidthOrHeight
|
||||||
|
) {
|
||||||
|
return file;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
const [pica, imageBlobReduce] = await Promise.all([
|
const [pica, imageBlobReduce] = await Promise.all([
|
||||||
import("pica").then((res) => res.default),
|
import("pica").then((res) => res.default),
|
||||||
// a wrapper for pica for better API
|
// a wrapper for pica for better API
|
||||||
@@ -347,10 +403,6 @@ export const resizeImageFile = async (
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!isSupportedImageFile(file)) {
|
|
||||||
throw new Error("Error: unsupported file type", { cause: "UNSUPPORTED" });
|
|
||||||
}
|
|
||||||
|
|
||||||
return new File(
|
return new File(
|
||||||
[await reduce.toBlob(file, { max: opts.maxWidthOrHeight, alpha: true })],
|
[await reduce.toBlob(file, { max: opts.maxWidthOrHeight, alpha: true })],
|
||||||
file.name,
|
file.name,
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ import {
|
|||||||
MIME_TYPES,
|
MIME_TYPES,
|
||||||
cloneJSON,
|
cloneJSON,
|
||||||
SVG_DOCUMENT_PREAMBLE,
|
SVG_DOCUMENT_PREAMBLE,
|
||||||
|
arrayToMap,
|
||||||
} from "@excalidraw/common";
|
} from "@excalidraw/common";
|
||||||
|
|
||||||
import { getNonDeletedElements } from "@excalidraw/element";
|
import { getNonDeletedElements } from "@excalidraw/element";
|
||||||
@@ -49,6 +50,7 @@ export const prepareElementsForExport = (
|
|||||||
exportSelectionOnly: boolean,
|
exportSelectionOnly: boolean,
|
||||||
) => {
|
) => {
|
||||||
elements = getNonDeletedElements(elements);
|
elements = getNonDeletedElements(elements);
|
||||||
|
const elementsMap = arrayToMap(elements);
|
||||||
|
|
||||||
const isExportingSelection =
|
const isExportingSelection =
|
||||||
exportSelectionOnly &&
|
exportSelectionOnly &&
|
||||||
@@ -71,7 +73,11 @@ export const prepareElementsForExport = (
|
|||||||
isFrameLikeElement(exportedElements[0])
|
isFrameLikeElement(exportedElements[0])
|
||||||
) {
|
) {
|
||||||
exportingFrame = exportedElements[0];
|
exportingFrame = exportedElements[0];
|
||||||
exportedElements = getElementsOverlappingFrame(elements, exportingFrame);
|
exportedElements = getElementsOverlappingFrame(
|
||||||
|
elements,
|
||||||
|
exportingFrame,
|
||||||
|
elementsMap,
|
||||||
|
);
|
||||||
} else if (exportedElements.length > 1) {
|
} else if (exportedElements.length > 1) {
|
||||||
exportedElements = getSelectedElements(
|
exportedElements = getSelectedElements(
|
||||||
elements,
|
elements,
|
||||||
|
|||||||
@@ -20,10 +20,6 @@ export const resaveAsImageWithScene = async (
|
|||||||
) => {
|
) => {
|
||||||
const fileHandleType = getFileHandleType(fileHandle);
|
const fileHandleType = getFileHandleType(fileHandle);
|
||||||
|
|
||||||
if (Math.random() < 1) {
|
|
||||||
throw new Error("OLALALALA");
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!isImageFileHandleType(fileHandleType)) {
|
if (!isImageFileHandleType(fileHandleType)) {
|
||||||
throw new Error(
|
throw new Error(
|
||||||
"fileHandle should exist and should be of type svg or png when resaving",
|
"fileHandle should exist and should be of type svg or png when resaving",
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { isFiniteNumber, pointFrom } from "@excalidraw/math";
|
import { isFiniteNumber, isValidPoint, pointFrom } from "@excalidraw/math";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
type CombineBrandsIfNeeded,
|
type CombineBrandsIfNeeded,
|
||||||
@@ -22,6 +22,7 @@ import {
|
|||||||
import {
|
import {
|
||||||
calculateFixedPointForNonElbowArrowBinding,
|
calculateFixedPointForNonElbowArrowBinding,
|
||||||
getNonDeletedElements,
|
getNonDeletedElements,
|
||||||
|
normalizeArrowhead,
|
||||||
isPointInElement,
|
isPointInElement,
|
||||||
isValidPolygon,
|
isValidPolygon,
|
||||||
projectFixedPointOntoDiagonal,
|
projectFixedPointOntoDiagonal,
|
||||||
@@ -95,6 +96,69 @@ type RestoredAppState = Omit<
|
|||||||
"offsetTop" | "offsetLeft" | "width" | "height"
|
"offsetTop" | "offsetLeft" | "width" | "height"
|
||||||
>;
|
>;
|
||||||
|
|
||||||
|
const MAX_ARROW_PX = 75_000;
|
||||||
|
|
||||||
|
const restoreLinearElementPoints = (
|
||||||
|
points: unknown,
|
||||||
|
width: unknown,
|
||||||
|
height: unknown,
|
||||||
|
): LocalPoint[] => {
|
||||||
|
const restoredPoints = Array.isArray(points)
|
||||||
|
? points.reduce<LocalPoint[]>((acc, point) => {
|
||||||
|
if (isValidPoint(point)) {
|
||||||
|
acc.push(pointFrom<LocalPoint>(point[0], point[1]));
|
||||||
|
}
|
||||||
|
return acc;
|
||||||
|
}, [])
|
||||||
|
: [];
|
||||||
|
|
||||||
|
return restoredPoints.length < 2
|
||||||
|
? [
|
||||||
|
pointFrom<LocalPoint>(0, 0),
|
||||||
|
pointFrom<LocalPoint>(
|
||||||
|
isFiniteNumber(width) ? width : 0,
|
||||||
|
isFiniteNumber(height) ? height : 0,
|
||||||
|
),
|
||||||
|
]
|
||||||
|
: restoredPoints;
|
||||||
|
};
|
||||||
|
|
||||||
|
const restoreFreedrawPoints = (
|
||||||
|
points: unknown,
|
||||||
|
pressures: unknown,
|
||||||
|
): {
|
||||||
|
points: LocalPoint[];
|
||||||
|
pressures: number[];
|
||||||
|
} => {
|
||||||
|
if (!Array.isArray(points)) {
|
||||||
|
return {
|
||||||
|
points: [],
|
||||||
|
pressures: [],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const pressureValues: readonly unknown[] = Array.isArray(pressures)
|
||||||
|
? pressures
|
||||||
|
: [];
|
||||||
|
const restoredPoints: LocalPoint[] = [];
|
||||||
|
const restoredPressures: number[] = [];
|
||||||
|
|
||||||
|
points.forEach((point, index) => {
|
||||||
|
if (isValidPoint(point)) {
|
||||||
|
restoredPoints.push(pointFrom<LocalPoint>(point[0], point[1]));
|
||||||
|
if (index in pressureValues) {
|
||||||
|
const pressure = pressureValues[index];
|
||||||
|
restoredPressures.push(isFiniteNumber(pressure) ? pressure : 0.5);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
return {
|
||||||
|
points: restoredPoints,
|
||||||
|
pressures: restoredPressures,
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
export const AllowedExcalidrawActiveTools: Record<
|
export const AllowedExcalidrawActiveTools: Record<
|
||||||
AppState["activeTool"]["type"],
|
AppState["activeTool"]["type"],
|
||||||
boolean
|
boolean
|
||||||
@@ -250,7 +314,9 @@ const repairBinding = <T extends ExcalidrawArrowElement>(
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
console.error(`could not repair binding for element`);
|
console.error(
|
||||||
|
`Could not repair binding for element "${boundElement?.id}" out of (${elementsMap?.size}) elements`,
|
||||||
|
);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error("Error repairing binding:", error);
|
console.error("Error repairing binding:", error);
|
||||||
}
|
}
|
||||||
@@ -409,10 +475,15 @@ export const restoreElement = (
|
|||||||
|
|
||||||
return element;
|
return element;
|
||||||
case "freedraw": {
|
case "freedraw": {
|
||||||
|
const { points, pressures } = restoreFreedrawPoints(
|
||||||
|
element.points,
|
||||||
|
element.pressures,
|
||||||
|
);
|
||||||
|
|
||||||
return restoreElementWithProperties(element, {
|
return restoreElementWithProperties(element, {
|
||||||
points: element.points,
|
points,
|
||||||
simulatePressure: element.simulatePressure,
|
simulatePressure: element.simulatePressure,
|
||||||
pressures: element.pressures,
|
pressures,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
case "image":
|
case "image":
|
||||||
@@ -426,17 +497,24 @@ export const restoreElement = (
|
|||||||
// @ts-ignore LEGACY type
|
// @ts-ignore LEGACY type
|
||||||
// eslint-disable-next-line no-fallthrough
|
// eslint-disable-next-line no-fallthrough
|
||||||
case "draw":
|
case "draw":
|
||||||
const { startArrowhead = null, endArrowhead = null } = element;
|
const startArrowhead = normalizeArrowhead(element.startArrowhead);
|
||||||
|
const endArrowhead = normalizeArrowhead(element.endArrowhead);
|
||||||
let x = element.x;
|
let x = element.x;
|
||||||
let y = element.y;
|
let y = element.y;
|
||||||
let points = // migrate old arrow model to new one
|
let points = restoreLinearElementPoints(
|
||||||
!Array.isArray(element.points) || element.points.length < 2
|
element.points,
|
||||||
? [pointFrom(0, 0), pointFrom(element.width, element.height)]
|
element.width,
|
||||||
: element.points;
|
element.height,
|
||||||
|
);
|
||||||
|
|
||||||
if (points[0][0] !== 0 || points[0][1] !== 0) {
|
if (points[0][0] !== 0 || points[0][1] !== 0) {
|
||||||
({ points, x, y } =
|
({ points, x, y } =
|
||||||
LinearElementEditor.getNormalizeElementPointsAndCoords(element));
|
LinearElementEditor.getNormalizeElementPointsAndCoords({
|
||||||
|
...element,
|
||||||
|
points,
|
||||||
|
x: x ?? 0,
|
||||||
|
y: y ?? 0,
|
||||||
|
} as ExcalidrawLinearElement));
|
||||||
}
|
}
|
||||||
|
|
||||||
return restoreElementWithProperties(element, {
|
return restoreElementWithProperties(element, {
|
||||||
@@ -450,7 +528,7 @@ export const restoreElement = (
|
|||||||
y,
|
y,
|
||||||
...(isLineElement(element)
|
...(isLineElement(element)
|
||||||
? {
|
? {
|
||||||
polygon: isValidPolygon(element.points)
|
polygon: isValidPolygon(points)
|
||||||
? element.polygon ?? false
|
? element.polygon ?? false
|
||||||
: false,
|
: false,
|
||||||
}
|
}
|
||||||
@@ -458,25 +536,36 @@ export const restoreElement = (
|
|||||||
...getSizeFromPoints(points),
|
...getSizeFromPoints(points),
|
||||||
});
|
});
|
||||||
case "arrow": {
|
case "arrow": {
|
||||||
const { startArrowhead = null, endArrowhead = "arrow" } = element;
|
const startArrowhead = normalizeArrowhead(element.startArrowhead);
|
||||||
const x: number | undefined = element.x;
|
const endArrowhead =
|
||||||
const y: number | undefined = element.y;
|
element.endArrowhead === undefined
|
||||||
const points: readonly LocalPoint[] | undefined = // migrate old arrow model to new one
|
? "arrow"
|
||||||
!Array.isArray(element.points) || element.points.length < 2
|
: normalizeArrowhead(element.endArrowhead);
|
||||||
? [pointFrom(0, 0), pointFrom(element.width, element.height)]
|
const x = element.x as number | undefined;
|
||||||
: element.points;
|
const y = element.y as number | undefined;
|
||||||
|
const points = restoreLinearElementPoints(
|
||||||
|
element.points,
|
||||||
|
element.width,
|
||||||
|
element.height,
|
||||||
|
);
|
||||||
|
const elementWithRestoredPoints = {
|
||||||
|
...element,
|
||||||
|
points,
|
||||||
|
x: x ?? 0,
|
||||||
|
y: y ?? 0,
|
||||||
|
} as ExcalidrawArrowElement;
|
||||||
|
|
||||||
const base = {
|
const base = {
|
||||||
type: element.type,
|
type: element.type,
|
||||||
startBinding: repairBinding(
|
startBinding: repairBinding(
|
||||||
element as ExcalidrawArrowElement,
|
elementWithRestoredPoints,
|
||||||
element.startBinding,
|
element.startBinding,
|
||||||
targetElementsMap,
|
targetElementsMap,
|
||||||
existingElementsMap,
|
existingElementsMap,
|
||||||
"start",
|
"start",
|
||||||
),
|
),
|
||||||
endBinding: repairBinding(
|
endBinding: repairBinding(
|
||||||
element as ExcalidrawArrowElement,
|
elementWithRestoredPoints,
|
||||||
element.endBinding,
|
element.endBinding,
|
||||||
targetElementsMap,
|
targetElementsMap,
|
||||||
existingElementsMap,
|
existingElementsMap,
|
||||||
@@ -485,8 +574,8 @@ export const restoreElement = (
|
|||||||
startArrowhead,
|
startArrowhead,
|
||||||
endArrowhead,
|
endArrowhead,
|
||||||
points,
|
points,
|
||||||
x,
|
x: x ?? 0,
|
||||||
y,
|
y: y ?? 0,
|
||||||
elbowed: (element as ExcalidrawArrowElement).elbowed,
|
elbowed: (element as ExcalidrawArrowElement).elbowed,
|
||||||
...getSizeFromPoints(points),
|
...getSizeFromPoints(points),
|
||||||
};
|
};
|
||||||
@@ -505,12 +594,44 @@ export const restoreElement = (
|
|||||||
})
|
})
|
||||||
: restoreElementWithProperties(element as ExcalidrawArrowElement, base);
|
: restoreElementWithProperties(element as ExcalidrawArrowElement, base);
|
||||||
|
|
||||||
return {
|
const normalizedRestoredElement = {
|
||||||
...restoredElement,
|
...restoredElement,
|
||||||
...LinearElementEditor.getNormalizeElementPointsAndCoords(
|
...LinearElementEditor.getNormalizeElementPointsAndCoords(
|
||||||
restoredElement,
|
restoredElement,
|
||||||
),
|
),
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Last resort fix for extremely large arrows
|
||||||
|
if (
|
||||||
|
normalizedRestoredElement.width > MAX_ARROW_PX ||
|
||||||
|
normalizedRestoredElement.height > MAX_ARROW_PX
|
||||||
|
) {
|
||||||
|
console.error(
|
||||||
|
`Removing extremely large arrow ${
|
||||||
|
normalizedRestoredElement.id
|
||||||
|
} (type: ${
|
||||||
|
isElbowArrow(normalizedRestoredElement) ? "elbow" : "simple"
|
||||||
|
}, width: ${normalizedRestoredElement.width}, height: ${
|
||||||
|
normalizedRestoredElement.height
|
||||||
|
}, x: ${normalizedRestoredElement.x}, y: ${
|
||||||
|
normalizedRestoredElement.y
|
||||||
|
})`,
|
||||||
|
);
|
||||||
|
return {
|
||||||
|
...normalizedRestoredElement,
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 100,
|
||||||
|
height: 100,
|
||||||
|
points: [
|
||||||
|
pointFrom<LocalPoint>(0, 0),
|
||||||
|
pointFrom<LocalPoint>(100, 100),
|
||||||
|
],
|
||||||
|
isDeleted: true,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return normalizedRestoredElement;
|
||||||
}
|
}
|
||||||
|
|
||||||
// generic elements
|
// generic elements
|
||||||
@@ -658,6 +779,7 @@ export const restoreElements = <T extends ExcalidrawElement>(
|
|||||||
const existingElementsMap = existingElements
|
const existingElementsMap = existingElements
|
||||||
? arrayToMap(existingElements)
|
? arrayToMap(existingElements)
|
||||||
: null;
|
: null;
|
||||||
|
|
||||||
const restoredElements = syncInvalidIndices(
|
const restoredElements = syncInvalidIndices(
|
||||||
(targetElements || []).reduce((elements, element) => {
|
(targetElements || []).reduce((elements, element) => {
|
||||||
// filtering out selection, which is legacy, no longer kept in elements,
|
// filtering out selection, which is legacy, no longer kept in elements,
|
||||||
@@ -754,7 +876,7 @@ export const restoreElements = <T extends ExcalidrawElement>(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// NOTE (mtolmacs): Temporary fix for extremely large arrows
|
// NOTE (mtolmacs): Temporary fix for invalid/self-bound elbow arrows
|
||||||
// Need to iterate again so we have attached text nodes in elementsMap
|
// Need to iterate again so we have attached text nodes in elementsMap
|
||||||
return restoredElements.map((element) => {
|
return restoredElements.map((element) => {
|
||||||
if (
|
if (
|
||||||
@@ -928,6 +1050,12 @@ export const restoreAppState = (
|
|||||||
: defaultValue;
|
: defaultValue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const boxSelectionMode =
|
||||||
|
appState.boxSelectionMode ?? localAppState?.boxSelectionMode;
|
||||||
|
if (boxSelectionMode !== undefined) {
|
||||||
|
nextAppState.boxSelectionMode = boxSelectionMode;
|
||||||
|
}
|
||||||
|
|
||||||
return {
|
return {
|
||||||
...nextAppState,
|
...nextAppState,
|
||||||
cursorButton: localAppState?.cursorButton || "up",
|
cursorButton: localAppState?.cursorButton || "up",
|
||||||
|
|||||||
@@ -33,9 +33,7 @@ import type { Bounds } from "@excalidraw/common";
|
|||||||
import type { GlobalPoint, LineSegment } from "@excalidraw/math/types";
|
import type { GlobalPoint, LineSegment } from "@excalidraw/math/types";
|
||||||
import type { ElementsMap, ExcalidrawElement } from "@excalidraw/element/types";
|
import type { ElementsMap, ExcalidrawElement } from "@excalidraw/element/types";
|
||||||
|
|
||||||
import { AnimatedTrail } from "../animated-trail";
|
import { AnimatedTrail } from "../animatedTrail";
|
||||||
|
|
||||||
import type { AnimationFrameHandler } from "../animation-frame-handler";
|
|
||||||
|
|
||||||
import type App from "../components/App";
|
import type App from "../components/App";
|
||||||
|
|
||||||
@@ -43,8 +41,8 @@ export class EraserTrail extends AnimatedTrail {
|
|||||||
private elementsToErase: Set<ExcalidrawElement["id"]> = new Set();
|
private elementsToErase: Set<ExcalidrawElement["id"]> = new Set();
|
||||||
private groupsToErase: Set<ExcalidrawElement["id"]> = new Set();
|
private groupsToErase: Set<ExcalidrawElement["id"]> = new Set();
|
||||||
|
|
||||||
constructor(animationFrameHandler: AnimationFrameHandler, app: App) {
|
constructor(app: App) {
|
||||||
super(animationFrameHandler, app, {
|
super(app, {
|
||||||
streamline: 0.2,
|
streamline: 0.2,
|
||||||
size: 5,
|
size: 5,
|
||||||
keepHead: true,
|
keepHead: true,
|
||||||
|
|||||||
@@ -6,6 +6,51 @@ import { getDefaultAppState } from "../appState";
|
|||||||
|
|
||||||
import type { AppState } from "../types";
|
import type { AppState } from "../types";
|
||||||
|
|
||||||
|
type AppStateSelector =
|
||||||
|
| keyof AppState
|
||||||
|
| (keyof AppState)[]
|
||||||
|
| ((appState: AppState) => unknown);
|
||||||
|
|
||||||
|
const getSelectedValue = (appState: AppState, selector: AppStateSelector) => {
|
||||||
|
if (typeof selector === "function") {
|
||||||
|
return selector(appState);
|
||||||
|
}
|
||||||
|
if (Array.isArray(selector)) {
|
||||||
|
return appState;
|
||||||
|
}
|
||||||
|
return appState[selector];
|
||||||
|
};
|
||||||
|
|
||||||
|
const getLatestValue = (
|
||||||
|
api: ReturnType<typeof useExcalidrawAPI>,
|
||||||
|
selector: AppStateSelector,
|
||||||
|
_internal: boolean,
|
||||||
|
) => {
|
||||||
|
if (api?.isDestroyed) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
let appState = api?.getAppState();
|
||||||
|
if (!appState) {
|
||||||
|
if (!_internal) {
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
console.warn(
|
||||||
|
"useAppStateValue: excalidrawAPI not defined yet for internal component while it should always be defined. Are you sure you're rendering inside of <Excalidraw/> component tree?",
|
||||||
|
);
|
||||||
|
// fall back in case there's a bug so we don't break the app
|
||||||
|
// (internal components using this internal useAppStateValue expect
|
||||||
|
// non-undefined values on init)
|
||||||
|
appState = Object.assign(
|
||||||
|
{ width: 0, height: 0, offsetLeft: 0, offsetTop: 0 },
|
||||||
|
getDefaultAppState(),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
return getSelectedValue(appState, selector);
|
||||||
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Subscribes to specific appState changes. The component re-renders
|
* Subscribes to specific appState changes. The component re-renders
|
||||||
* only when the specified prop(s) change — not on every appState update.
|
* only when the specified prop(s) change — not on every appState update.
|
||||||
@@ -19,92 +64,109 @@ import type { AppState } from "../types";
|
|||||||
* - `(keyof AppState)[]` → whole `AppState`
|
* - `(keyof AppState)[]` → whole `AppState`
|
||||||
* - selector function → selector's return type `T`
|
* - selector function → selector's return type `T`
|
||||||
*
|
*
|
||||||
* Calls the optional callback with the latest value on every change (not called
|
|
||||||
* on initial render).
|
|
||||||
*
|
|
||||||
* If excalidrawAPI is not ready yet (host apps), hook is rerendered with latest
|
* If excalidrawAPI is not ready yet (host apps), hook is rerendered with latest
|
||||||
* value once available.
|
* value once available.
|
||||||
*/
|
*/
|
||||||
export function useAppStateValue<K extends keyof AppState>(
|
export function useAppStateValue<K extends keyof AppState>(
|
||||||
prop: K,
|
prop: K,
|
||||||
callback?: (value: AppState[K], appState: AppState) => void,
|
|
||||||
_internal?: boolean,
|
_internal?: boolean,
|
||||||
): AppState[K];
|
): AppState[K];
|
||||||
export function useAppStateValue(
|
export function useAppStateValue(
|
||||||
props: (keyof AppState)[],
|
props: (keyof AppState)[],
|
||||||
callback?: (props: AppState, appState: AppState) => void,
|
|
||||||
_internal?: boolean,
|
_internal?: boolean,
|
||||||
): AppState;
|
): AppState;
|
||||||
export function useAppStateValue<T>(
|
export function useAppStateValue<T>(
|
||||||
selector: (appState: AppState) => T,
|
selector: (appState: AppState) => T,
|
||||||
callback?: (value: T, appState: AppState) => void,
|
|
||||||
_internal?: boolean,
|
_internal?: boolean,
|
||||||
): T;
|
): T;
|
||||||
export function useAppStateValue(
|
export function useAppStateValue(
|
||||||
selector:
|
selector: AppStateSelector,
|
||||||
| keyof AppState
|
|
||||||
| (keyof AppState)[]
|
|
||||||
| ((appState: AppState) => unknown),
|
|
||||||
callback?: (value: any, appState: AppState) => void,
|
|
||||||
_internal: boolean = true,
|
_internal: boolean = true,
|
||||||
): unknown {
|
): unknown {
|
||||||
const api = useExcalidrawAPI();
|
const api = useExcalidrawAPI();
|
||||||
|
const [, rerender] = useState(0);
|
||||||
|
|
||||||
const getLatestValue = () => {
|
const stateRef = useRef<{
|
||||||
let appState = api?.getAppState();
|
selector: AppStateSelector;
|
||||||
if (!appState) {
|
isInitialized: boolean;
|
||||||
if (!_internal) {
|
latestValue: unknown;
|
||||||
return undefined;
|
} | null>(null);
|
||||||
}
|
if (!stateRef.current) {
|
||||||
console.warn(
|
stateRef.current = {
|
||||||
"useAppStateValue: excalidrawAPI not defined yet for internal component in which case it should always be defined. Are you sure you're rendering inside of <Excalidraw/> component tree?",
|
selector,
|
||||||
);
|
isInitialized: !!api,
|
||||||
// fall back in case there's a bug so we don't break the app
|
latestValue: getLatestValue(api, selector, _internal),
|
||||||
// (internal components using this internal useAppStateValue expect
|
};
|
||||||
// non-undefined values on init)
|
}
|
||||||
appState = Object.assign(
|
|
||||||
{ width: 0, height: 0, offsetLeft: 0, offsetTop: 0 },
|
|
||||||
getDefaultAppState(),
|
|
||||||
);
|
|
||||||
}
|
|
||||||
if (typeof selector === "function") {
|
|
||||||
return selector(appState);
|
|
||||||
}
|
|
||||||
if (Array.isArray(selector)) {
|
|
||||||
return appState;
|
|
||||||
}
|
|
||||||
return appState[selector];
|
|
||||||
};
|
|
||||||
|
|
||||||
const [value, setValue] = useState<unknown>(getLatestValue);
|
|
||||||
|
|
||||||
const stateRef = useRef({
|
|
||||||
selector,
|
|
||||||
callback,
|
|
||||||
isInitialized: !!api,
|
|
||||||
latestValue: value,
|
|
||||||
});
|
|
||||||
stateRef.current.selector = selector;
|
stateRef.current.selector = selector;
|
||||||
stateRef.current.callback = callback;
|
if (!stateRef.current.isInitialized && api && !api.isDestroyed) {
|
||||||
if (!stateRef.current.isInitialized && api) {
|
|
||||||
stateRef.current.isInitialized = true;
|
stateRef.current.isInitialized = true;
|
||||||
stateRef.current.latestValue = getLatestValue();
|
stateRef.current.latestValue = getLatestValue(api, selector, _internal);
|
||||||
}
|
}
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (!api) {
|
const currentStateRef = stateRef.current;
|
||||||
|
if (!api || api.isDestroyed || !currentStateRef) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
return api.onStateChange(
|
return api.onStateChange(currentStateRef.selector, (newValue: any) => {
|
||||||
stateRef.current.selector,
|
currentStateRef.latestValue = newValue;
|
||||||
(newValue: any, state: AppState) => {
|
rerender((value) => value + 1);
|
||||||
stateRef.current.latestValue = newValue;
|
});
|
||||||
stateRef.current.callback?.(newValue, state);
|
|
||||||
setValue(newValue);
|
|
||||||
},
|
|
||||||
);
|
|
||||||
}, [api]);
|
}, [api]);
|
||||||
|
|
||||||
return stateRef.current.latestValue;
|
return stateRef.current.latestValue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Subscribes to specific appState changes without causing component rerenders.
|
||||||
|
*
|
||||||
|
* The callback is called on every matching change, but also on initial render
|
||||||
|
* so you can initialize your state.
|
||||||
|
*/
|
||||||
|
export function useOnAppStateChange<K extends keyof AppState>(
|
||||||
|
prop: K,
|
||||||
|
callback: (value: AppState[K], appState: AppState) => void,
|
||||||
|
): undefined;
|
||||||
|
export function useOnAppStateChange(
|
||||||
|
props: (keyof AppState)[],
|
||||||
|
callback: (props: AppState, appState: AppState) => void,
|
||||||
|
): undefined;
|
||||||
|
export function useOnAppStateChange<T>(
|
||||||
|
selector: (appState: AppState) => T,
|
||||||
|
callback: (value: T, appState: AppState) => void,
|
||||||
|
): undefined;
|
||||||
|
export function useOnAppStateChange(
|
||||||
|
selector: AppStateSelector,
|
||||||
|
callback: (value: any, appState: AppState) => void,
|
||||||
|
): undefined {
|
||||||
|
const api = useExcalidrawAPI();
|
||||||
|
|
||||||
|
const stateRef = useRef({
|
||||||
|
selector,
|
||||||
|
callback,
|
||||||
|
});
|
||||||
|
stateRef.current.selector = selector;
|
||||||
|
stateRef.current.callback = callback;
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!api || api.isDestroyed) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
stateRef.current.callback(
|
||||||
|
getLatestValue(api, stateRef.current.selector, true),
|
||||||
|
api.getAppState(),
|
||||||
|
);
|
||||||
|
|
||||||
|
return api.onStateChange(
|
||||||
|
stateRef.current.selector,
|
||||||
|
(newValue: any, state: AppState) => {
|
||||||
|
stateRef.current.callback(newValue, state);
|
||||||
|
},
|
||||||
|
);
|
||||||
|
}, [api]);
|
||||||
|
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|||||||
@@ -1,6 +1,16 @@
|
|||||||
import React, { useCallback, useContext, useEffect, useState } from "react";
|
import React, {
|
||||||
|
useCallback,
|
||||||
|
useContext,
|
||||||
|
useEffect,
|
||||||
|
useRef,
|
||||||
|
useState,
|
||||||
|
} from "react";
|
||||||
|
|
||||||
import { DEFAULT_UI_OPTIONS, isShallowEqual } from "@excalidraw/common";
|
import {
|
||||||
|
DEFAULT_IMAGE_OPTIONS,
|
||||||
|
DEFAULT_UI_OPTIONS,
|
||||||
|
isShallowEqual,
|
||||||
|
} from "@excalidraw/common";
|
||||||
|
|
||||||
import App, {
|
import App, {
|
||||||
ExcalidrawAPIContext,
|
ExcalidrawAPIContext,
|
||||||
@@ -12,7 +22,10 @@ import LiveCollaborationTrigger from "./components/live-collaboration/LiveCollab
|
|||||||
import MainMenu from "./components/main-menu/MainMenu";
|
import MainMenu from "./components/main-menu/MainMenu";
|
||||||
import WelcomeScreen from "./components/welcome-screen/WelcomeScreen";
|
import WelcomeScreen from "./components/welcome-screen/WelcomeScreen";
|
||||||
import { defaultLang } from "./i18n";
|
import { defaultLang } from "./i18n";
|
||||||
import { useAppStateValue as _useAppStateValue } from "./hooks/useAppStateValue";
|
import {
|
||||||
|
useAppStateValue as _useAppStateValue,
|
||||||
|
useOnAppStateChange as _useOnAppStateChange,
|
||||||
|
} from "./hooks/useAppStateValue";
|
||||||
import { EditorJotaiProvider, editorJotaiStore } from "./editor-jotai";
|
import { EditorJotaiProvider, editorJotaiStore } from "./editor-jotai";
|
||||||
import polyfill from "./polyfill";
|
import polyfill from "./polyfill";
|
||||||
|
|
||||||
@@ -31,8 +44,8 @@ polyfill();
|
|||||||
|
|
||||||
/**
|
/**
|
||||||
* Stateless provider that allows `useExcalidrawAPI()` (and hooks built
|
* Stateless provider that allows `useExcalidrawAPI()` (and hooks built
|
||||||
* on it, such as `useAppStateValue()`) to work outside the <Excalidraw>
|
* on it, such as `useAppStateValue()` and `useOnAppStateChange()`) to work
|
||||||
* component tree.
|
* outside the <Excalidraw> component tree.
|
||||||
*/
|
*/
|
||||||
export const ExcalidrawAPIProvider = ({
|
export const ExcalidrawAPIProvider = ({
|
||||||
children,
|
children,
|
||||||
@@ -57,6 +70,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
initialData,
|
initialData,
|
||||||
onExcalidrawAPI,
|
onExcalidrawAPI,
|
||||||
onMount,
|
onMount,
|
||||||
|
onUnmount,
|
||||||
onInitialize,
|
onInitialize,
|
||||||
isCollaborating = false,
|
isCollaborating = false,
|
||||||
onPointerUpdate,
|
onPointerUpdate,
|
||||||
@@ -85,9 +99,11 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
children,
|
children,
|
||||||
validateEmbeddable,
|
validateEmbeddable,
|
||||||
renderEmbeddable,
|
renderEmbeddable,
|
||||||
|
resolveRenderOpacity,
|
||||||
aiEnabled,
|
aiEnabled,
|
||||||
showDeprecatedFonts,
|
showDeprecatedFonts,
|
||||||
renderScrollbars,
|
renderScrollbars,
|
||||||
|
imageOptions,
|
||||||
} = props;
|
} = props;
|
||||||
|
|
||||||
const canvasActions = props.UIOptions?.canvasActions;
|
const canvasActions = props.UIOptions?.canvasActions;
|
||||||
@@ -118,13 +134,24 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
UIOptions.canvasActions.toggleTheme = true;
|
UIOptions.canvasActions.toggleTheme = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const normalizedImageOptions: AppProps["imageOptions"] = {
|
||||||
|
maxFileSizeBytes:
|
||||||
|
imageOptions?.maxFileSizeBytes ?? DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes,
|
||||||
|
maxWidthOrHeight:
|
||||||
|
imageOptions?.maxWidthOrHeight ?? DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight,
|
||||||
|
};
|
||||||
|
|
||||||
const setExcalidrawAPI = useContext(ExcalidrawAPISetContext);
|
const setExcalidrawAPI = useContext(ExcalidrawAPISetContext);
|
||||||
|
|
||||||
|
const onExcalidrawAPIRef = useRef(onExcalidrawAPI);
|
||||||
|
onExcalidrawAPIRef.current = onExcalidrawAPI;
|
||||||
|
|
||||||
const handleExcalidrawAPI = useCallback(
|
const handleExcalidrawAPI = useCallback(
|
||||||
(api: ExcalidrawImperativeAPI) => {
|
(api: ExcalidrawImperativeAPI | null) => {
|
||||||
setExcalidrawAPI?.(api);
|
setExcalidrawAPI?.(api);
|
||||||
onExcalidrawAPI?.(api);
|
onExcalidrawAPIRef.current?.(api);
|
||||||
},
|
},
|
||||||
[onExcalidrawAPI, setExcalidrawAPI],
|
[setExcalidrawAPI],
|
||||||
);
|
);
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -162,6 +189,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
initialData={initialData}
|
initialData={initialData}
|
||||||
onExcalidrawAPI={handleExcalidrawAPI}
|
onExcalidrawAPI={handleExcalidrawAPI}
|
||||||
onMount={onMount}
|
onMount={onMount}
|
||||||
|
onUnmount={onUnmount}
|
||||||
onInitialize={onInitialize}
|
onInitialize={onInitialize}
|
||||||
isCollaborating={isCollaborating}
|
isCollaborating={isCollaborating}
|
||||||
onPointerUpdate={onPointerUpdate}
|
onPointerUpdate={onPointerUpdate}
|
||||||
@@ -190,9 +218,11 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
onDuplicate={onDuplicate}
|
onDuplicate={onDuplicate}
|
||||||
validateEmbeddable={validateEmbeddable}
|
validateEmbeddable={validateEmbeddable}
|
||||||
renderEmbeddable={renderEmbeddable}
|
renderEmbeddable={renderEmbeddable}
|
||||||
|
resolveRenderOpacity={resolveRenderOpacity}
|
||||||
aiEnabled={aiEnabled !== false}
|
aiEnabled={aiEnabled !== false}
|
||||||
showDeprecatedFonts={showDeprecatedFonts}
|
showDeprecatedFonts={showDeprecatedFonts}
|
||||||
renderScrollbars={renderScrollbars}
|
renderScrollbars={renderScrollbars}
|
||||||
|
imageOptions={normalizedImageOptions}
|
||||||
>
|
>
|
||||||
{children}
|
{children}
|
||||||
</App>
|
</App>
|
||||||
@@ -210,11 +240,13 @@ const areEqual = (prevProps: ExcalidrawProps, nextProps: ExcalidrawProps) => {
|
|||||||
const {
|
const {
|
||||||
initialData: prevInitialData,
|
initialData: prevInitialData,
|
||||||
UIOptions: prevUIOptions = {},
|
UIOptions: prevUIOptions = {},
|
||||||
|
imageOptions: prevImageOptions,
|
||||||
...prev
|
...prev
|
||||||
} = prevProps;
|
} = prevProps;
|
||||||
const {
|
const {
|
||||||
initialData: nextInitialData,
|
initialData: nextInitialData,
|
||||||
UIOptions: nextUIOptions = {},
|
UIOptions: nextUIOptions = {},
|
||||||
|
imageOptions: nextImageOptions,
|
||||||
...next
|
...next
|
||||||
} = nextProps;
|
} = nextProps;
|
||||||
|
|
||||||
@@ -258,7 +290,17 @@ const areEqual = (prevProps: ExcalidrawProps, nextProps: ExcalidrawProps) => {
|
|||||||
return prevUIOptions[key] === nextUIOptions[key];
|
return prevUIOptions[key] === nextUIOptions[key];
|
||||||
});
|
});
|
||||||
|
|
||||||
return isUIOptionsSame && isShallowEqual(prev, next);
|
const isImageOptionsSame =
|
||||||
|
(prevImageOptions?.maxWidthOrHeight ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight) ===
|
||||||
|
(nextImageOptions?.maxWidthOrHeight ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight) &&
|
||||||
|
(prevImageOptions?.maxFileSizeBytes ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes) ===
|
||||||
|
(nextImageOptions?.maxFileSizeBytes ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes);
|
||||||
|
|
||||||
|
return isUIOptionsSame && isImageOptionsSame && isShallowEqual(prev, next);
|
||||||
};
|
};
|
||||||
|
|
||||||
export const Excalidraw = React.memo(ExcalidrawBase, areEqual);
|
export const Excalidraw = React.memo(ExcalidrawBase, areEqual);
|
||||||
@@ -367,6 +409,8 @@ export { DiagramToCodePlugin } from "./components/DiagramToCodePlugin/DiagramToC
|
|||||||
export { getDataURL } from "./data/blob";
|
export { getDataURL } from "./data/blob";
|
||||||
export { isElementLink } from "@excalidraw/element";
|
export { isElementLink } from "@excalidraw/element";
|
||||||
|
|
||||||
|
export { Fonts } from "./fonts/Fonts";
|
||||||
|
|
||||||
export { setCustomTextMetricsProvider } from "@excalidraw/element";
|
export { setCustomTextMetricsProvider } from "@excalidraw/element";
|
||||||
|
|
||||||
export { CommandPalette } from "./components/CommandPalette/CommandPalette";
|
export { CommandPalette } from "./components/CommandPalette/CommandPalette";
|
||||||
@@ -378,7 +422,7 @@ export {
|
|||||||
} from "./charts";
|
} from "./charts";
|
||||||
|
|
||||||
// -----------------------------------------------------------------------------
|
// -----------------------------------------------------------------------------
|
||||||
// useAppStateValue() wrapper for host apps for the return type to reflect the
|
// useExcalidrawStateValue() wrapper for host apps for the return type to reflect the
|
||||||
// the potentially `undefined` value for initial render before the excalidrawAPI
|
// the potentially `undefined` value for initial render before the excalidrawAPI
|
||||||
// is ready.
|
// is ready.
|
||||||
//
|
//
|
||||||
@@ -388,25 +432,23 @@ export {
|
|||||||
* @param prop - appState prop(s) to subscribe to, or a selector function.
|
* @param prop - appState prop(s) to subscribe to, or a selector function.
|
||||||
* NOTE `prop/selector` is memoized and will not change after initial render
|
* NOTE `prop/selector` is memoized and will not change after initial render
|
||||||
*/
|
*/
|
||||||
export function useAppStateValue<K extends keyof AppState>(
|
export function useExcalidrawStateValue<K extends keyof AppState>(
|
||||||
prop: K,
|
prop: K,
|
||||||
callback?: (value: AppState[K], appState: AppState) => void,
|
|
||||||
): AppState[K] | undefined;
|
): AppState[K] | undefined;
|
||||||
export function useAppStateValue<T extends keyof AppState>(
|
export function useExcalidrawStateValue<T extends keyof AppState>(
|
||||||
props: T[],
|
props: T[],
|
||||||
callback?: (values: AppState, appState: AppState) => void,
|
|
||||||
): AppState | undefined;
|
): AppState | undefined;
|
||||||
export function useAppStateValue<T>(
|
export function useExcalidrawStateValue<T>(
|
||||||
selector: (appState: AppState) => T,
|
selector: (appState: AppState) => T,
|
||||||
callback?: (value: T, appState: AppState) => void,
|
|
||||||
): T | undefined;
|
): T | undefined;
|
||||||
export function useAppStateValue(
|
export function useExcalidrawStateValue(
|
||||||
selector:
|
selector:
|
||||||
| keyof AppState
|
| keyof AppState
|
||||||
| (keyof AppState)[]
|
| (keyof AppState)[]
|
||||||
| ((appState: AppState) => unknown),
|
| ((appState: AppState) => unknown),
|
||||||
callback?: (value: any, appState: AppState) => void,
|
|
||||||
) {
|
) {
|
||||||
return _useAppStateValue(selector as any, callback, false);
|
return _useAppStateValue(selector as any, false);
|
||||||
}
|
}
|
||||||
// -----------------------------------------------------------------------------
|
// -----------------------------------------------------------------------------
|
||||||
|
|
||||||
|
export { _useOnAppStateChange as useOnExcalidrawStateChange };
|
||||||
|
|||||||
@@ -2,27 +2,20 @@ import { DEFAULT_LASER_COLOR, easeOut } from "@excalidraw/common";
|
|||||||
|
|
||||||
import type { LaserPointerOptions } from "@excalidraw/laser-pointer";
|
import type { LaserPointerOptions } from "@excalidraw/laser-pointer";
|
||||||
|
|
||||||
import { AnimatedTrail } from "./animated-trail";
|
import { AnimatedTrail } from "./animatedTrail";
|
||||||
import { getClientColor } from "./clients";
|
import { getClientColor } from "./clients";
|
||||||
|
|
||||||
import type { Trail } from "./animated-trail";
|
import type { Trail } from "./animatedTrail";
|
||||||
import type { AnimationFrameHandler } from "./animation-frame-handler";
|
|
||||||
import type App from "./components/App";
|
import type App from "./components/App";
|
||||||
import type { SocketId } from "./types";
|
import type { SocketId } from "./types";
|
||||||
|
|
||||||
export class LaserTrails implements Trail {
|
export class LaserTrails implements Trail {
|
||||||
public localTrail: AnimatedTrail;
|
public localTrail: AnimatedTrail;
|
||||||
private collabTrails = new Map<SocketId, AnimatedTrail>();
|
private collabTrails = new Map<SocketId, AnimatedTrail>();
|
||||||
|
|
||||||
private container?: SVGSVGElement;
|
private container?: SVGSVGElement;
|
||||||
|
|
||||||
constructor(
|
constructor(private app: App) {
|
||||||
private animationFrameHandler: AnimationFrameHandler,
|
this.localTrail = new AnimatedTrail(app, {
|
||||||
private app: App,
|
|
||||||
) {
|
|
||||||
this.animationFrameHandler.register(this, this.onFrame.bind(this));
|
|
||||||
|
|
||||||
this.localTrail = new AnimatedTrail(animationFrameHandler, app, {
|
|
||||||
...this.getTrailOptions(),
|
...this.getTrailOptions(),
|
||||||
fill: () => DEFAULT_LASER_COLOR,
|
fill: () => DEFAULT_LASER_COLOR,
|
||||||
});
|
});
|
||||||
@@ -63,30 +56,45 @@ export class LaserTrails implements Trail {
|
|||||||
|
|
||||||
start(container: SVGSVGElement) {
|
start(container: SVGSVGElement) {
|
||||||
this.container = container;
|
this.container = container;
|
||||||
|
|
||||||
this.animationFrameHandler.start(this);
|
|
||||||
this.localTrail.start(container);
|
this.localTrail.start(container);
|
||||||
}
|
}
|
||||||
|
|
||||||
stop() {
|
stop() {
|
||||||
this.animationFrameHandler.stop(this);
|
|
||||||
this.localTrail.stop();
|
this.localTrail.stop();
|
||||||
|
this.stopCollabTrails();
|
||||||
|
this.container = undefined;
|
||||||
}
|
}
|
||||||
|
|
||||||
onFrame() {
|
private stopCollabTrails(collaborators?: App["state"]["collaborators"]) {
|
||||||
this.updateCollabTrails();
|
for (const [key, trail] of this.collabTrails) {
|
||||||
|
const collaborator = collaborators?.get(key);
|
||||||
|
|
||||||
|
if (!collaborator) {
|
||||||
|
trail.stop();
|
||||||
|
this.collabTrails.delete(key);
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private updateCollabTrails() {
|
updateCollabTrails(collaborators: App["state"]["collaborators"]) {
|
||||||
if (!this.container || this.app.state.collaborators.size === 0) {
|
this.stopCollabTrails(collaborators);
|
||||||
|
|
||||||
|
if (!this.container || collaborators.size === 0) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
for (const [key, collaborator] of this.app.state.collaborators.entries()) {
|
for (const [key, collaborator] of collaborators.entries()) {
|
||||||
let trail!: AnimatedTrail;
|
// Current user has their own trail drawn via localTrail
|
||||||
|
if (collaborator.isCurrentUser) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
if (!this.collabTrails.has(key)) {
|
// IDEA: Use the collaborator pointer coordinates to trace out the
|
||||||
trail = new AnimatedTrail(this.animationFrameHandler, this.app, {
|
// laser pointer trail when 1) the selected collab tool is the laser
|
||||||
|
// pointer and 2) the collab pointer button is in the "down" state.
|
||||||
|
let trail = this.collabTrails.get(key);
|
||||||
|
if (!trail) {
|
||||||
|
trail = new AnimatedTrail(this.app, {
|
||||||
...this.getTrailOptions(),
|
...this.getTrailOptions(),
|
||||||
fill: () =>
|
fill: () =>
|
||||||
collaborator.pointer?.laserColor ||
|
collaborator.pointer?.laserColor ||
|
||||||
@@ -95,36 +103,33 @@ export class LaserTrails implements Trail {
|
|||||||
trail.start(this.container);
|
trail.start(this.container);
|
||||||
|
|
||||||
this.collabTrails.set(key, trail);
|
this.collabTrails.set(key, trail);
|
||||||
} else {
|
|
||||||
trail = this.collabTrails.get(key)!;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if (collaborator.pointer && collaborator.pointer.tool === "laser") {
|
if (collaborator.pointer && collaborator.pointer.tool === "laser") {
|
||||||
if (collaborator.button === "down" && !trail.hasCurrentTrail) {
|
const buttonDown = collaborator.button === "down";
|
||||||
|
const buttonUp = collaborator.button === "up";
|
||||||
|
const hasTrail = trail.hasCurrentTrail;
|
||||||
|
|
||||||
|
// Initialize a new trail
|
||||||
|
if (buttonDown && !hasTrail) {
|
||||||
trail.startPath(collaborator.pointer.x, collaborator.pointer.y);
|
trail.startPath(collaborator.pointer.x, collaborator.pointer.y);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (
|
// Add only original points
|
||||||
collaborator.button === "down" &&
|
const lastPointOriginal = !trail.hasLastPoint(
|
||||||
trail.hasCurrentTrail &&
|
collaborator.pointer.x,
|
||||||
!trail.hasLastPoint(collaborator.pointer.x, collaborator.pointer.y)
|
collaborator.pointer.y,
|
||||||
) {
|
);
|
||||||
|
if (buttonDown && lastPointOriginal) {
|
||||||
trail.addPointToPath(collaborator.pointer.x, collaborator.pointer.y);
|
trail.addPointToPath(collaborator.pointer.x, collaborator.pointer.y);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (collaborator.button === "up" && trail.hasCurrentTrail) {
|
// End the trail on button up
|
||||||
|
if (buttonUp && hasTrail) {
|
||||||
trail.addPointToPath(collaborator.pointer.x, collaborator.pointer.y);
|
trail.addPointToPath(collaborator.pointer.x, collaborator.pointer.y);
|
||||||
trail.endPath();
|
trail.endPath();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
for (const key of this.collabTrails.keys()) {
|
|
||||||
if (!this.app.state.collaborators.has(key)) {
|
|
||||||
const trail = this.collabTrails.get(key)!;
|
|
||||||
trail.stop();
|
|
||||||
this.collabTrails.delete(key);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -25,9 +25,7 @@ import type {
|
|||||||
NonDeleted,
|
NonDeleted,
|
||||||
} from "@excalidraw/element/types";
|
} from "@excalidraw/element/types";
|
||||||
|
|
||||||
import { type AnimationFrameHandler } from "../animation-frame-handler";
|
import { AnimatedTrail } from "../animatedTrail";
|
||||||
|
|
||||||
import { AnimatedTrail } from "../animated-trail";
|
|
||||||
|
|
||||||
import { getLassoSelectedElementIds } from "./utils";
|
import { getLassoSelectedElementIds } from "./utils";
|
||||||
|
|
||||||
@@ -47,8 +45,8 @@ export class LassoTrail extends AnimatedTrail {
|
|||||||
private canvasTranslate: CanvasTranslate | null = null;
|
private canvasTranslate: CanvasTranslate | null = null;
|
||||||
private keepPreviousSelection: boolean = false;
|
private keepPreviousSelection: boolean = false;
|
||||||
|
|
||||||
constructor(animationFrameHandler: AnimationFrameHandler, app: App) {
|
constructor(app: App) {
|
||||||
super(animationFrameHandler, app, {
|
super(app, {
|
||||||
animateTrail: true,
|
animateTrail: true,
|
||||||
streamline: 0.4,
|
streamline: 0.4,
|
||||||
sizeMapping: (c) => {
|
sizeMapping: (c) => {
|
||||||
|
|||||||
@@ -53,7 +53,14 @@
|
|||||||
"arrowhead_crowfoot_many": "Crow's foot (many)",
|
"arrowhead_crowfoot_many": "Crow's foot (many)",
|
||||||
"arrowhead_crowfoot_one": "Crow's foot (one)",
|
"arrowhead_crowfoot_one": "Crow's foot (one)",
|
||||||
"arrowhead_crowfoot_one_or_many": "Crow's foot (one or many)",
|
"arrowhead_crowfoot_one_or_many": "Crow's foot (one or many)",
|
||||||
|
"arrowhead_cardinality_one": "Cardinality (one)",
|
||||||
|
"arrowhead_cardinality_many": "Cardinality (many)",
|
||||||
|
"arrowhead_cardinality_one_or_many": "Cardinality (one or many)",
|
||||||
|
"arrowhead_cardinality_exactly_one": "Cardinality (exactly one)",
|
||||||
|
"arrowhead_cardinality_zero_or_one": "Cardinality (zero or one)",
|
||||||
|
"arrowhead_cardinality_zero_or_many": "Cardinality (zero or many)",
|
||||||
"more_options": "More options",
|
"more_options": "More options",
|
||||||
|
"cardinality": "Cardinality",
|
||||||
"arrowtypes": "Arrow type",
|
"arrowtypes": "Arrow type",
|
||||||
"arrowtype_sharp": "Sharp arrow",
|
"arrowtype_sharp": "Sharp arrow",
|
||||||
"arrowtype_round": "Curved arrow",
|
"arrowtype_round": "Curved arrow",
|
||||||
@@ -178,6 +185,9 @@
|
|||||||
"shapeSwitch": "Switch shape",
|
"shapeSwitch": "Switch shape",
|
||||||
"preferences": "Preferences",
|
"preferences": "Preferences",
|
||||||
"preferences_toolLock": "Tool lock",
|
"preferences_toolLock": "Tool lock",
|
||||||
|
"boxSelectionMode": "Select on",
|
||||||
|
"boxSelectionContain": "Wrap",
|
||||||
|
"boxSelectionOverlap": "Overlap",
|
||||||
"arrowBinding": "Arrow binding",
|
"arrowBinding": "Arrow binding",
|
||||||
"midpointSnapping": "Snap to midpoints"
|
"midpointSnapping": "Snap to midpoints"
|
||||||
},
|
},
|
||||||
@@ -624,7 +634,7 @@
|
|||||||
"mermaid": {
|
"mermaid": {
|
||||||
"title": "Mermaid to Excalidraw",
|
"title": "Mermaid to Excalidraw",
|
||||||
"button": "Insert",
|
"button": "Insert",
|
||||||
"description": "Currently only <flowchartLink>Flowchart</flowchartLink>,<sequenceLink> Sequence, </sequenceLink> and <classLink>Class </classLink>Diagrams are supported. The other types will be rendered as image in Excalidraw.",
|
"description": "Currently only <flowchartLink>Flowchart</flowchartLink>, <sequenceLink>Sequence</sequenceLink>, <classLink>Class</classLink>, and <erdLink>Entity Relationship</erdLink> Diagrams are supported. The other types will be rendered as image in Excalidraw.",
|
||||||
"syntax": "Mermaid Syntax",
|
"syntax": "Mermaid Syntax",
|
||||||
"preview": "Preview",
|
"preview": "Preview",
|
||||||
"label": "Mermaid",
|
"label": "Mermaid",
|
||||||
@@ -654,7 +664,7 @@
|
|||||||
"placeholder": {
|
"placeholder": {
|
||||||
"title": "Let's design your diagram",
|
"title": "Let's design your diagram",
|
||||||
"description": "Describe the diagram you want to create, and we'll generate it for you.",
|
"description": "Describe the diagram you want to create, and we'll generate it for you.",
|
||||||
"hint": "At the moment we know Flowchart, Sequence, and Class diagrams."
|
"hint": "At the moment we know Flowchart, Sequence, Class, State, and Entity Relationship diagrams."
|
||||||
},
|
},
|
||||||
"preview": "Preview",
|
"preview": "Preview",
|
||||||
"insert": "Insert",
|
"insert": "Insert",
|
||||||
|
|||||||
@@ -88,14 +88,13 @@
|
|||||||
"@excalidraw/element": "0.18.0",
|
"@excalidraw/element": "0.18.0",
|
||||||
"@excalidraw/laser-pointer": "1.3.1",
|
"@excalidraw/laser-pointer": "1.3.1",
|
||||||
"@excalidraw/math": "0.18.0",
|
"@excalidraw/math": "0.18.0",
|
||||||
"@excalidraw/mermaid-to-excalidraw": "2.0.0-rc4",
|
"@excalidraw/mermaid-to-excalidraw": "2.2.2",
|
||||||
"@excalidraw/random-username": "1.1.0",
|
"@excalidraw/random-username": "1.1.0",
|
||||||
"browser-fs-access": "0.38.0",
|
"browser-fs-access": "0.38.0",
|
||||||
"canvas-roundrect-polyfill": "0.0.1",
|
"canvas-roundrect-polyfill": "0.0.1",
|
||||||
"clsx": "1.1.1",
|
"clsx": "1.1.1",
|
||||||
"cross-env": "7.0.3",
|
"cross-env": "7.0.3",
|
||||||
"es6-promise-pool": "2.5.0",
|
"es6-promise-pool": "2.5.0",
|
||||||
"fractional-indexing": "3.2.0",
|
|
||||||
"fuzzy": "0.1.3",
|
"fuzzy": "0.1.3",
|
||||||
"image-blob-reduce": "3.0.1",
|
"image-blob-reduce": "3.0.1",
|
||||||
"jotai": "2.11.0",
|
"jotai": "2.11.0",
|
||||||
|
|||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user