Merge branch 'master' into mtolmacs/feat/freedraw-research-1
This commit is contained in:
@@ -1,4 +1,4 @@
|
|||||||
FROM node:18-bullseye
|
FROM node:24-bullseye
|
||||||
|
|
||||||
# Vite wants to open the browser using `open`, so we
|
# Vite wants to open the browser using `open`, so we
|
||||||
# need to install those utils.
|
# need to install those utils.
|
||||||
|
|||||||
@@ -6,11 +6,97 @@ on:
|
|||||||
- opened
|
- opened
|
||||||
- edited
|
- edited
|
||||||
- synchronize
|
- synchronize
|
||||||
|
- labeled
|
||||||
|
- unlabeled
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
semantic:
|
semantic:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
|
permissions:
|
||||||
|
pull-requests: read
|
||||||
steps:
|
steps:
|
||||||
- uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5
|
- uses: amannn/action-semantic-pull-request@e32d7e603df1aa1ba07e981f2a23455dee596825 # v5
|
||||||
|
with:
|
||||||
|
requireScope: true
|
||||||
|
scopes: |
|
||||||
|
app
|
||||||
|
editor
|
||||||
|
packages/excalidraw
|
||||||
|
packages/utils
|
||||||
|
docker
|
||||||
|
repo
|
||||||
|
ignoreLabels: |
|
||||||
|
skip-semantic-title
|
||||||
env:
|
env:
|
||||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
|
||||||
|
label-scope:
|
||||||
|
needs: semantic
|
||||||
|
if: github.event.pull_request.head.repo.full_name == github.repository
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
permissions:
|
||||||
|
issues: write
|
||||||
|
pull-requests: write
|
||||||
|
steps:
|
||||||
|
- name: Label scoped PR
|
||||||
|
env:
|
||||||
|
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
PR_NUMBER: ${{ github.event.pull_request.number }}
|
||||||
|
PR_TITLE: ${{ github.event.pull_request.title }}
|
||||||
|
REPOSITORY: ${{ github.repository }}
|
||||||
|
run: |
|
||||||
|
set -euo pipefail
|
||||||
|
|
||||||
|
scope_labels=(s-app s-editor s-package)
|
||||||
|
|
||||||
|
readarray -t desired_labels < <(
|
||||||
|
node <<'NODE'
|
||||||
|
const title = process.env.PR_TITLE;
|
||||||
|
const match = title.match(/^[a-z]+(?:\(([^)]+)\))?!?:/i);
|
||||||
|
const scopes = match?.[1]?.split(",").map((scope) => scope.trim()) ?? [];
|
||||||
|
const labels = new Set();
|
||||||
|
|
||||||
|
for (const scope of scopes) {
|
||||||
|
if (scope === "app") {
|
||||||
|
labels.add("s-app");
|
||||||
|
} else if (scope === "editor") {
|
||||||
|
labels.add("s-editor");
|
||||||
|
} else if (scope.startsWith("packages/")) {
|
||||||
|
labels.add("s-package");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
process.stdout.write([...labels].join("\n"));
|
||||||
|
NODE
|
||||||
|
)
|
||||||
|
|
||||||
|
should_apply_label() {
|
||||||
|
local label="$1"
|
||||||
|
|
||||||
|
for desired_label in "${desired_labels[@]}"; do
|
||||||
|
if [[ "$desired_label" == "$label" ]]; then
|
||||||
|
return 0
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
return 1
|
||||||
|
}
|
||||||
|
|
||||||
|
for label in "${scope_labels[@]}"; do
|
||||||
|
if ! should_apply_label "$label"; then
|
||||||
|
gh api \
|
||||||
|
--method DELETE \
|
||||||
|
"repos/${REPOSITORY}/issues/${PR_NUMBER}/labels/${label}" \
|
||||||
|
--silent 2>/dev/null || true
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
for label in "${desired_labels[@]}"; do
|
||||||
|
if ! gh api \
|
||||||
|
--method POST \
|
||||||
|
"repos/${REPOSITORY}/issues/${PR_NUMBER}/labels" \
|
||||||
|
--field "labels[]=${label}" \
|
||||||
|
--silent; then
|
||||||
|
echo "::warning::Could not apply ${label}. The workflow token likely does not have issues:write permission for this PR."
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|||||||
+2
-2
@@ -1,4 +1,4 @@
|
|||||||
FROM --platform=${BUILDPLATFORM} node:18 AS build
|
FROM --platform=${BUILDPLATFORM} node:24 AS build
|
||||||
|
|
||||||
WORKDIR /opt/node_app
|
WORKDIR /opt/node_app
|
||||||
|
|
||||||
@@ -13,7 +13,7 @@ ARG NODE_ENV=production
|
|||||||
|
|
||||||
RUN npm_config_target_arch=${TARGETARCH} yarn build:app:docker
|
RUN npm_config_target_arch=${TARGETARCH} yarn build:app:docker
|
||||||
|
|
||||||
FROM --platform=${TARGETPLATFORM} nginx:1.27-alpine
|
FROM nginx:1.27-alpine
|
||||||
|
|
||||||
COPY --from=build /opt/node_app/excalidraw-app/build /usr/share/nginx/html
|
COPY --from=build /opt/node_app/excalidraw-app/build /usr/share/nginx/html
|
||||||
|
|
||||||
|
|||||||
@@ -26,7 +26,6 @@ import {
|
|||||||
get,
|
get,
|
||||||
} from "idb-keyval";
|
} from "idb-keyval";
|
||||||
|
|
||||||
import { appJotaiStore, atom } from "excalidraw-app/app-jotai";
|
|
||||||
import { getNonDeletedElements } from "@excalidraw/element";
|
import { getNonDeletedElements } from "@excalidraw/element";
|
||||||
|
|
||||||
import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library";
|
import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library";
|
||||||
@@ -39,6 +38,7 @@ import type {
|
|||||||
} from "@excalidraw/excalidraw/types";
|
} from "@excalidraw/excalidraw/types";
|
||||||
import type { MaybePromise } from "@excalidraw/common/utility-types";
|
import type { MaybePromise } from "@excalidraw/common/utility-types";
|
||||||
|
|
||||||
|
import { appJotaiStore, atom } from "../app-jotai";
|
||||||
import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants";
|
import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants";
|
||||||
|
|
||||||
import { FileManager } from "./FileManager";
|
import { FileManager } from "./FileManager";
|
||||||
|
|||||||
@@ -75,6 +75,13 @@ export default defineConfig(({ mode }) => {
|
|||||||
find: /^@excalidraw\/utils\/(.*?)/,
|
find: /^@excalidraw\/utils\/(.*?)/,
|
||||||
replacement: path.resolve(__dirname, "../packages/utils/src/$1"),
|
replacement: path.resolve(__dirname, "../packages/utils/src/$1"),
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
find: /^@excalidraw\/fractional-indexing$/,
|
||||||
|
replacement: path.resolve(
|
||||||
|
__dirname,
|
||||||
|
"../packages/fractional-indexing/src/index.ts",
|
||||||
|
),
|
||||||
|
},
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
build: {
|
build: {
|
||||||
|
|||||||
+2
-1
@@ -56,7 +56,8 @@
|
|||||||
"build:element": "yarn --cwd ./packages/element build:esm",
|
"build:element": "yarn --cwd ./packages/element build:esm",
|
||||||
"build:excalidraw": "yarn --cwd ./packages/excalidraw build:esm",
|
"build:excalidraw": "yarn --cwd ./packages/excalidraw build:esm",
|
||||||
"build:math": "yarn --cwd ./packages/math build:esm",
|
"build:math": "yarn --cwd ./packages/math build:esm",
|
||||||
"build:packages": "yarn build:common && yarn build:math && yarn build:element && yarn build:excalidraw",
|
"build:fractional-indexing": "yarn --cwd ./packages/fractional-indexing build:esm",
|
||||||
|
"build:packages": "yarn build:common && yarn build:fractional-indexing && yarn build:math && yarn build:element && yarn build:excalidraw",
|
||||||
"build:version": "yarn --cwd ./excalidraw-app build:version",
|
"build:version": "yarn --cwd ./excalidraw-app build:version",
|
||||||
"build": "yarn --cwd ./excalidraw-app build",
|
"build": "yarn --cwd ./excalidraw-app build",
|
||||||
"build:preview": "yarn --cwd ./excalidraw-app build:preview",
|
"build:preview": "yarn --cwd ./excalidraw-app build:preview",
|
||||||
|
|||||||
@@ -337,9 +337,10 @@ export const MAX_DECIMALS_FOR_SVG_EXPORT = 2;
|
|||||||
export const EXPORT_SCALES = [1, 2, 3];
|
export const EXPORT_SCALES = [1, 2, 3];
|
||||||
export const DEFAULT_EXPORT_PADDING = 10; // px
|
export const DEFAULT_EXPORT_PADDING = 10; // px
|
||||||
|
|
||||||
export const DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT = 1440;
|
export const DEFAULT_IMAGE_OPTIONS: AppProps["imageOptions"] = {
|
||||||
|
maxWidthOrHeight: 1440,
|
||||||
export const MAX_ALLOWED_FILE_BYTES = 4 * 1024 * 1024;
|
maxFileSizeBytes: 4 * 1024 * 1024,
|
||||||
|
};
|
||||||
|
|
||||||
export const SVG_NS = "http://www.w3.org/2000/svg";
|
export const SVG_NS = "http://www.w3.org/2000/svg";
|
||||||
export const SVG_DOCUMENT_PREAMBLE = `<?xml version="1.0" standalone="no"?>
|
export const SVG_DOCUMENT_PREAMBLE = `<?xml version="1.0" standalone="no"?>
|
||||||
|
|||||||
@@ -64,6 +64,7 @@
|
|||||||
},
|
},
|
||||||
"dependencies": {
|
"dependencies": {
|
||||||
"@excalidraw/common": "0.18.0",
|
"@excalidraw/common": "0.18.0",
|
||||||
"@excalidraw/math": "0.18.0"
|
"@excalidraw/math": "0.18.0",
|
||||||
|
"@excalidraw/fractional-indexing": "3.3.0"
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -338,29 +338,20 @@ export class Scene {
|
|||||||
this.callbacks.clear();
|
this.callbacks.clear();
|
||||||
}
|
}
|
||||||
|
|
||||||
insertElementAtIndex(element: ExcalidrawElement, index: number) {
|
/** low-level - generally use app.insertNewElements() */
|
||||||
if (!Number.isFinite(index) || index < 0) {
|
insertElementsAtIndex(
|
||||||
throw new Error(
|
elements: ExcalidrawElement[],
|
||||||
"insertElementAtIndex can only be called with index >= 0",
|
/** null indicates end of the array */
|
||||||
);
|
index: number | null,
|
||||||
}
|
) {
|
||||||
|
|
||||||
const nextElements = [
|
|
||||||
...this.elements.slice(0, index),
|
|
||||||
element,
|
|
||||||
...this.elements.slice(index),
|
|
||||||
];
|
|
||||||
|
|
||||||
syncMovedIndices(nextElements, arrayToMap([element]));
|
|
||||||
|
|
||||||
this.replaceAllElements(nextElements);
|
|
||||||
}
|
|
||||||
|
|
||||||
insertElementsAtIndex(elements: ExcalidrawElement[], index: number) {
|
|
||||||
if (!elements.length) {
|
if (!elements.length) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (index === null) {
|
||||||
|
index = this.elements.length;
|
||||||
|
}
|
||||||
|
|
||||||
if (!Number.isFinite(index) || index < 0) {
|
if (!Number.isFinite(index) || index < 0) {
|
||||||
throw new Error(
|
throw new Error(
|
||||||
"insertElementAtIndex can only be called with index >= 0",
|
"insertElementAtIndex can only be called with index >= 0",
|
||||||
@@ -378,24 +369,9 @@ export class Scene {
|
|||||||
this.replaceAllElements(nextElements);
|
this.replaceAllElements(nextElements);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** low-level - generally use app.insertNewElement() */
|
||||||
insertElement = (element: ExcalidrawElement) => {
|
insertElement = (element: ExcalidrawElement) => {
|
||||||
const index = element.frameId
|
this.insertElementsAtIndex([element], null);
|
||||||
? this.getElementIndex(element.frameId)
|
|
||||||
: this.elements.length;
|
|
||||||
|
|
||||||
this.insertElementAtIndex(element, index);
|
|
||||||
};
|
|
||||||
|
|
||||||
insertElements = (elements: ExcalidrawElement[]) => {
|
|
||||||
if (!elements.length) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
const index = elements[0]?.frameId
|
|
||||||
? this.getElementIndex(elements[0].frameId)
|
|
||||||
: this.elements.length;
|
|
||||||
|
|
||||||
this.insertElementsAtIndex(elements, index);
|
|
||||||
};
|
};
|
||||||
|
|
||||||
getElementIndex(elementId: string) {
|
getElementIndex(elementId: string) {
|
||||||
|
|||||||
@@ -734,12 +734,11 @@ const getBindingStrategyForDraggingBindingElementEndpoints_simple = (
|
|||||||
});
|
});
|
||||||
|
|
||||||
// Handle outside-outside binding to the same element
|
// Handle outside-outside binding to the same element
|
||||||
if (otherBinding && otherBinding.elementId === hit?.id) {
|
if (
|
||||||
invariant(
|
otherBinding &&
|
||||||
!opts?.newArrow || appState.selectedLinearElement?.initialState.origin,
|
otherBinding.elementId === hit?.id &&
|
||||||
"appState.selectedLinearElement.initialState.origin must be defined for new arrows",
|
(!opts?.newArrow || appState.selectedLinearElement?.initialState.origin)
|
||||||
);
|
) {
|
||||||
|
|
||||||
return {
|
return {
|
||||||
start: {
|
start: {
|
||||||
mode: "inside",
|
mode: "inside",
|
||||||
@@ -1943,9 +1942,9 @@ export const calculateFixedPointForElbowArrowBinding = (
|
|||||||
return {
|
return {
|
||||||
fixedPoint: normalizeFixedPoint([
|
fixedPoint: normalizeFixedPoint([
|
||||||
(nonRotatedSnappedGlobalPoint[0] - hoveredElement.x) /
|
(nonRotatedSnappedGlobalPoint[0] - hoveredElement.x) /
|
||||||
hoveredElement.width,
|
Math.max(hoveredElement.width, PRECISION),
|
||||||
(nonRotatedSnappedGlobalPoint[1] - hoveredElement.y) /
|
(nonRotatedSnappedGlobalPoint[1] - hoveredElement.y) /
|
||||||
hoveredElement.height,
|
Math.max(hoveredElement.height, PRECISION),
|
||||||
]),
|
]),
|
||||||
};
|
};
|
||||||
};
|
};
|
||||||
@@ -1976,9 +1975,11 @@ export const calculateFixedPointForNonElbowArrowBinding = (
|
|||||||
|
|
||||||
// Calculate the ratio relative to the element's bounds
|
// Calculate the ratio relative to the element's bounds
|
||||||
const fixedPointX =
|
const fixedPointX =
|
||||||
(nonRotatedPoint[0] - hoveredElement.x) / hoveredElement.width;
|
(nonRotatedPoint[0] - hoveredElement.x) /
|
||||||
|
Math.max(hoveredElement.width, PRECISION);
|
||||||
const fixedPointY =
|
const fixedPointY =
|
||||||
(nonRotatedPoint[1] - hoveredElement.y) / hoveredElement.height;
|
(nonRotatedPoint[1] - hoveredElement.y) /
|
||||||
|
Math.max(hoveredElement.height, PRECISION);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
fixedPoint: normalizeFixedPoint([fixedPointX, fixedPointY]),
|
fixedPoint: normalizeFixedPoint([fixedPointX, fixedPointY]),
|
||||||
|
|||||||
@@ -61,6 +61,8 @@ import { distanceToElement } from "./distance";
|
|||||||
|
|
||||||
import { getBindingGap } from "./binding";
|
import { getBindingGap } from "./binding";
|
||||||
|
|
||||||
|
import { hasBackground } from "./comparisons";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
ElementsMap,
|
ElementsMap,
|
||||||
ExcalidrawArrowElement,
|
ExcalidrawArrowElement,
|
||||||
@@ -83,7 +85,7 @@ export const shouldTestInside = (element: ExcalidrawElement) => {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const isDraggableFromInside =
|
const isDraggableFromInside =
|
||||||
!isTransparent(element.backgroundColor) ||
|
(hasBackground(element.type) && !isTransparent(element.backgroundColor)) ||
|
||||||
hasBoundTextElement(element) ||
|
hasBoundTextElement(element) ||
|
||||||
isIframeLikeElement(element) ||
|
isIframeLikeElement(element) ||
|
||||||
isTextElement(element);
|
isTextElement(element);
|
||||||
@@ -324,7 +326,10 @@ export const getAllHoveredElementAtPoint = (
|
|||||||
) {
|
) {
|
||||||
candidateElements.push(element);
|
candidateElements.push(element);
|
||||||
|
|
||||||
if (!isTransparent(element.backgroundColor)) {
|
if (
|
||||||
|
hasBackground(element.type) &&
|
||||||
|
!isTransparent(element.backgroundColor)
|
||||||
|
) {
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -111,6 +111,9 @@ export const duplicateElements = (
|
|||||||
* user interaction.
|
* user interaction.
|
||||||
*/
|
*/
|
||||||
type: "everything";
|
type: "everything";
|
||||||
|
// TODO remove/review this once we add frame children order migration
|
||||||
|
// and invariant checks
|
||||||
|
preserveFrameChildrenOrder?: boolean;
|
||||||
}
|
}
|
||||||
| {
|
| {
|
||||||
/**
|
/**
|
||||||
@@ -170,6 +173,8 @@ export const duplicateElements = (
|
|||||||
opts.type === "in-place"
|
opts.type === "in-place"
|
||||||
? opts.idsOfElementsToDuplicate
|
? opts.idsOfElementsToDuplicate
|
||||||
: new Map(elements.map((el) => [el.id, el]));
|
: new Map(elements.map((el) => [el.id, el]));
|
||||||
|
const preserveFrameChildrenOrder =
|
||||||
|
opts.type === "everything" && opts.preserveFrameChildrenOrder;
|
||||||
|
|
||||||
// For sanity
|
// For sanity
|
||||||
if (opts.type === "in-place") {
|
if (opts.type === "in-place") {
|
||||||
@@ -250,6 +255,9 @@ export const duplicateElements = (
|
|||||||
elementsWithDuplicates.splice(index + 1, 0, ...castArray(elements));
|
elementsWithDuplicates.splice(index + 1, 0, ...castArray(elements));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// main
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
const frameIdsToDuplicate = new Set(
|
const frameIdsToDuplicate = new Set(
|
||||||
elements
|
elements
|
||||||
.filter(
|
.filter(
|
||||||
@@ -274,7 +282,7 @@ export const duplicateElements = (
|
|||||||
if (groupId) {
|
if (groupId) {
|
||||||
const groupElements = getElementsInGroup(elements, groupId).flatMap(
|
const groupElements = getElementsInGroup(elements, groupId).flatMap(
|
||||||
(element) =>
|
(element) =>
|
||||||
isFrameLikeElement(element)
|
isFrameLikeElement(element) && !preserveFrameChildrenOrder
|
||||||
? [...getFrameChildren(elements, element.id), element]
|
? [...getFrameChildren(elements, element.id), element]
|
||||||
: [element],
|
: [element],
|
||||||
);
|
);
|
||||||
@@ -290,13 +298,25 @@ export const duplicateElements = (
|
|||||||
// frame duplication
|
// frame duplication
|
||||||
// -------------------------------------------------------------------------
|
// -------------------------------------------------------------------------
|
||||||
|
|
||||||
if (element.frameId && frameIdsToDuplicate.has(element.frameId)) {
|
if (
|
||||||
|
!preserveFrameChildrenOrder &&
|
||||||
|
element.frameId &&
|
||||||
|
frameIdsToDuplicate.has(element.frameId)
|
||||||
|
) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (isFrameLikeElement(element)) {
|
if (isFrameLikeElement(element)) {
|
||||||
const frameId = element.id;
|
const frameId = element.id;
|
||||||
|
|
||||||
|
if (preserveFrameChildrenOrder) {
|
||||||
|
insertBeforeOrAfterIndex(
|
||||||
|
findLastIndex(elementsWithDuplicates, (el) => el.id === frameId),
|
||||||
|
copyElements(element),
|
||||||
|
);
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
const frameChildren = getFrameChildren(elements, frameId);
|
const frameChildren = getFrameChildren(elements, frameId);
|
||||||
|
|
||||||
const targetIndex = findLastIndex(elementsWithDuplicates, (el) => {
|
const targetIndex = findLastIndex(elementsWithDuplicates, (el) => {
|
||||||
|
|||||||
@@ -2124,8 +2124,8 @@ const normalizeArrowElementUpdate = (
|
|||||||
offsetY < -MAX_POS ||
|
offsetY < -MAX_POS ||
|
||||||
offsetY > MAX_POS ||
|
offsetY > MAX_POS ||
|
||||||
offsetX + points[points.length - 1][0] < -MAX_POS ||
|
offsetX + points[points.length - 1][0] < -MAX_POS ||
|
||||||
offsetY + points[points.length - 1][0] > MAX_POS ||
|
offsetX + points[points.length - 1][0] > MAX_POS ||
|
||||||
offsetX + points[points.length - 1][1] < -MAX_POS ||
|
offsetY + points[points.length - 1][1] < -MAX_POS ||
|
||||||
offsetY + points[points.length - 1][1] > MAX_POS
|
offsetY + points[points.length - 1][1] > MAX_POS
|
||||||
) {
|
) {
|
||||||
console.error(
|
console.error(
|
||||||
|
|||||||
@@ -1,7 +1,10 @@
|
|||||||
import { generateNKeysBetween } from "fractional-indexing";
|
|
||||||
|
|
||||||
import { arrayToMap } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
|
import {
|
||||||
|
validateOrderKey,
|
||||||
|
generateNKeysBetween,
|
||||||
|
} from "@excalidraw/fractional-indexing";
|
||||||
|
|
||||||
import { mutateElement, newElementWith } from "./mutateElement";
|
import { mutateElement, newElementWith } from "./mutateElement";
|
||||||
import { getBoundTextElement } from "./textElement";
|
import { getBoundTextElement } from "./textElement";
|
||||||
import { hasBoundTextElement } from "./typeChecks";
|
import { hasBoundTextElement } from "./typeChecks";
|
||||||
@@ -382,6 +385,13 @@ const isValidFractionalIndex = (
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
try {
|
||||||
|
// Format validation
|
||||||
|
validateOrderKey(index);
|
||||||
|
} catch {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
if (predecessor && successor) {
|
if (predecessor && successor) {
|
||||||
return predecessor < index && index < successor;
|
return predecessor < index && index < successor;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -19,9 +19,11 @@ import {
|
|||||||
getElementAbsoluteCoords,
|
getElementAbsoluteCoords,
|
||||||
doBoundsIntersect,
|
doBoundsIntersect,
|
||||||
getElementBounds,
|
getElementBounds,
|
||||||
|
boundsContainBounds,
|
||||||
} from "./bounds";
|
} from "./bounds";
|
||||||
import { mutateElement } from "./mutateElement";
|
import { mutateElement } from "./mutateElement";
|
||||||
import { getBoundTextElement, getContainerElement } from "./textElement";
|
import { getBoundTextElement, getContainerElement } from "./textElement";
|
||||||
|
import { syncMovedIndices } from "./fractionalIndex";
|
||||||
import {
|
import {
|
||||||
isFrameElement,
|
isFrameElement,
|
||||||
isFrameLikeElement,
|
isFrameLikeElement,
|
||||||
@@ -101,8 +103,9 @@ export const isElementContainingFrame = (
|
|||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
elementsMap: ElementsMap,
|
elementsMap: ElementsMap,
|
||||||
) => {
|
) => {
|
||||||
return getElementsWithinSelection([frame], element, elementsMap).some(
|
return boundsContainBounds(
|
||||||
(e) => e.id === frame.id,
|
getElementBounds(element, elementsMap),
|
||||||
|
getElementBounds(frame, elementsMap),
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -489,10 +492,44 @@ export const filterElementsEligibleAsFrameChildren = (
|
|||||||
return eligibleElements;
|
return eligibleElements;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const getCommonFrameId = (elements: readonly ExcalidrawElement[]) => {
|
||||||
|
let commonFrameId: ExcalidrawElement["frameId"] | undefined;
|
||||||
|
|
||||||
|
for (const element of elements) {
|
||||||
|
if (isFrameLikeElement(element) || !element.frameId) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (commonFrameId === undefined) {
|
||||||
|
commonFrameId = element.frameId;
|
||||||
|
} else if (commonFrameId !== element.frameId) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return commonFrameId ?? null;
|
||||||
|
};
|
||||||
|
|
||||||
|
export const getFrameChildrenInsertionIndex = (
|
||||||
|
elements: readonly ExcalidrawElement[],
|
||||||
|
frameId: ExcalidrawFrameLikeElement["id"],
|
||||||
|
): number | null => {
|
||||||
|
for (let index = elements.length - 1; index >= 0; index--) {
|
||||||
|
const element = elements[index];
|
||||||
|
|
||||||
|
if (element.id === frameId) {
|
||||||
|
return index;
|
||||||
|
} else if (element.frameId === frameId) {
|
||||||
|
return index + 1;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return null;
|
||||||
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Retains (or repairs for target frame) the ordering invriant where children
|
* Adds elements and their bound elements to frame. Reorders added elements to
|
||||||
* elements come right before the parent frame:
|
* be just below frame, or just above its highest child (whichever is higher).
|
||||||
* [el, el, child, child, frame, el]
|
|
||||||
*
|
*
|
||||||
* @returns mutated allElements (same data structure)
|
* @returns mutated allElements (same data structure)
|
||||||
*/
|
*/
|
||||||
@@ -500,19 +537,11 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
|||||||
allElements: T,
|
allElements: T,
|
||||||
elementsToAdd: NonDeletedExcalidrawElement[],
|
elementsToAdd: NonDeletedExcalidrawElement[],
|
||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
appState: AppState,
|
|
||||||
): T => {
|
): T => {
|
||||||
const elementsMap = arrayToMap(allElements);
|
const elementsMap = arrayToMap(allElements);
|
||||||
const currTargetFrameChildrenMap = new Map<ExcalidrawElement["id"], true>();
|
const commonFrameId = getCommonFrameId(elementsToAdd);
|
||||||
for (const element of allElements.values()) {
|
|
||||||
if (element.frameId === frame.id) {
|
|
||||||
currTargetFrameChildrenMap.set(element.id, true);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
const suppliedElementsToAddSet = new Set(elementsToAdd.map((el) => el.id));
|
const finalElementsToAdd = new Set<ExcalidrawElement>();
|
||||||
|
|
||||||
const finalElementsToAdd: ExcalidrawElement[] = [];
|
|
||||||
|
|
||||||
const otherFrames = new Set<ExcalidrawFrameLikeElement["id"]>();
|
const otherFrames = new Set<ExcalidrawFrameLikeElement["id"]>();
|
||||||
|
|
||||||
@@ -523,7 +552,8 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
|||||||
}
|
}
|
||||||
|
|
||||||
// - add bound text elements if not already in the array
|
// - add bound text elements if not already in the array
|
||||||
// - filter out elements that are already in the frame
|
// - keep elements already in the frame so mixed selections can be reordered
|
||||||
|
// together
|
||||||
for (const element of omitGroupsContainingFrameLikes(
|
for (const element of omitGroupsContainingFrameLikes(
|
||||||
allElements,
|
allElements,
|
||||||
elementsToAdd,
|
elementsToAdd,
|
||||||
@@ -536,38 +566,68 @@ export const addElementsToFrame = <T extends ElementsMapOrArray>(
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// if the element is already in another frame (which is also in elementsToAdd),
|
if (element.frameId && element.frameId !== frame.id) {
|
||||||
// it means that frame and children are selected at the same time
|
|
||||||
// => keep original frame membership, do not add to the target frame
|
|
||||||
if (
|
|
||||||
element.frameId &&
|
|
||||||
appState.selectedElementIds[element.id] &&
|
|
||||||
appState.selectedElementIds[element.frameId]
|
|
||||||
) {
|
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!currTargetFrameChildrenMap.has(element.id)) {
|
finalElementsToAdd.add(element);
|
||||||
finalElementsToAdd.push(element);
|
|
||||||
}
|
|
||||||
|
|
||||||
const boundTextElement = getBoundTextElement(element, elementsMap);
|
const boundTextElement = getBoundTextElement(element, elementsMap);
|
||||||
if (
|
if (boundTextElement && !finalElementsToAdd.has(boundTextElement)) {
|
||||||
boundTextElement &&
|
finalElementsToAdd.add(boundTextElement);
|
||||||
!suppliedElementsToAddSet.has(boundTextElement.id) &&
|
|
||||||
!currTargetFrameChildrenMap.has(boundTextElement.id)
|
|
||||||
) {
|
|
||||||
finalElementsToAdd.push(boundTextElement);
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
for (const element of finalElementsToAdd) {
|
for (const element of finalElementsToAdd) {
|
||||||
mutateElement(element, elementsMap, {
|
// we don't always need to update the element if it's already in the frame,
|
||||||
frameId: frame.id,
|
// but we still need to accumulate in finalElementsToAdd so we potentially
|
||||||
});
|
// reorder them if added together
|
||||||
|
if (element.frameId !== frame.id) {
|
||||||
|
mutateElement(element, elementsMap, {
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return allElements;
|
// (re)order elements to be just below the frame,
|
||||||
|
// or just above the highest child if that is higher
|
||||||
|
// (latter case is denormalized order until we migrate)
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
if (
|
||||||
|
!finalElementsToAdd.size ||
|
||||||
|
// if all elements to add already belong to the frame, then we don't want to
|
||||||
|
// reorder (case: we're dragging element children within the frame)
|
||||||
|
commonFrameId === frame.id
|
||||||
|
) {
|
||||||
|
return allElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
const otherElements = Array.from(allElements.values()).filter(
|
||||||
|
(element) => !finalElementsToAdd.has(element),
|
||||||
|
);
|
||||||
|
const insertionIndex = getFrameChildrenInsertionIndex(
|
||||||
|
otherElements,
|
||||||
|
frame.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (insertionIndex === null) {
|
||||||
|
return allElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
const reorderedElements = [
|
||||||
|
...otherElements.slice(0, insertionIndex),
|
||||||
|
...finalElementsToAdd,
|
||||||
|
...otherElements.slice(insertionIndex),
|
||||||
|
];
|
||||||
|
|
||||||
|
syncMovedIndices(reorderedElements, arrayToMap([...finalElementsToAdd]));
|
||||||
|
|
||||||
|
return (
|
||||||
|
Array.isArray(allElements)
|
||||||
|
? reorderedElements
|
||||||
|
: new Map(reorderedElements.map((element) => [element.id, element]))
|
||||||
|
) as T;
|
||||||
};
|
};
|
||||||
|
|
||||||
export const removeElementsFromFrame = (
|
export const removeElementsFromFrame = (
|
||||||
@@ -621,13 +681,11 @@ export const replaceAllElementsInFrame = <T extends ExcalidrawElement>(
|
|||||||
allElements: readonly T[],
|
allElements: readonly T[],
|
||||||
nextElementsInFrame: ExcalidrawElement[],
|
nextElementsInFrame: ExcalidrawElement[],
|
||||||
frame: ExcalidrawFrameLikeElement,
|
frame: ExcalidrawFrameLikeElement,
|
||||||
app: AppClassProperties,
|
|
||||||
): T[] => {
|
): T[] => {
|
||||||
return addElementsToFrame(
|
return addElementsToFrame(
|
||||||
removeAllElementsFromFrame(allElements, frame),
|
removeAllElementsFromFrame(allElements, frame),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
frame,
|
frame,
|
||||||
app.state,
|
|
||||||
).slice();
|
).slice();
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -486,7 +486,7 @@ export class LinearElementEditor {
|
|||||||
selectedPointsIndices,
|
selectedPointsIndices,
|
||||||
)}) points(0..${
|
)}) points(0..${
|
||||||
element.points.length - 1
|
element.points.length - 1
|
||||||
}) lastClickedPoint(${lastClickedPoint})`,
|
}) lastClickedPoint(${lastClickedPoint}) isElbowArrow: ${elbowed}`,
|
||||||
);
|
);
|
||||||
|
|
||||||
// Fall back to the actual last point as a last resort.
|
// Fall back to the actual last point as a last resort.
|
||||||
@@ -2139,13 +2139,13 @@ const pointDraggingUpdates = (
|
|||||||
} => {
|
} => {
|
||||||
const naiveDraggingPoints = new Map(
|
const naiveDraggingPoints = new Map(
|
||||||
selectedPointsIndices.map((pointIndex) => {
|
selectedPointsIndices.map((pointIndex) => {
|
||||||
|
// NOTE: Avoid stale point index issue potentially caused by elbow
|
||||||
|
// arrows unpredictably changing the number of points during dragging
|
||||||
|
const point = element.points[pointIndex] ?? element.points.at(-1);
|
||||||
return [
|
return [
|
||||||
pointIndex,
|
pointIndex,
|
||||||
{
|
{
|
||||||
point: pointFrom<LocalPoint>(
|
point: pointFrom<LocalPoint>(point[0] + deltaX, point[1] + deltaY),
|
||||||
element.points[pointIndex][0] + deltaX,
|
|
||||||
element.points[pointIndex][1] + deltaY,
|
|
||||||
),
|
|
||||||
isDragging: true,
|
isDragging: true,
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
|
|||||||
@@ -34,7 +34,6 @@ import {
|
|||||||
elementOverlapsWithFrame,
|
elementOverlapsWithFrame,
|
||||||
getContainingFrame,
|
getContainingFrame,
|
||||||
getFrameChildren,
|
getFrameChildren,
|
||||||
isElementIntersectingFrame,
|
|
||||||
} from "./frame";
|
} from "./frame";
|
||||||
|
|
||||||
import { LinearElementEditor } from "./linearElementEditor";
|
import { LinearElementEditor } from "./linearElementEditor";
|
||||||
@@ -130,13 +129,24 @@ export const getElementsWithinSelection = (
|
|||||||
const framesInSelection = excludeElementsInFrames
|
const framesInSelection = excludeElementsInFrames
|
||||||
? new Set<NonDeletedExcalidrawElement["id"]>()
|
? new Set<NonDeletedExcalidrawElement["id"]>()
|
||||||
: null;
|
: null;
|
||||||
let elementsInSelection: NonDeletedExcalidrawElement[] = [];
|
const groups: Record<string, NonDeletedExcalidrawElement[]> = {};
|
||||||
|
const elementsInSelection: Set<NonDeletedExcalidrawElement> = new Set();
|
||||||
|
|
||||||
for (const element of elements) {
|
for (const element of elements) {
|
||||||
if (shouldIgnoreElementFromSelection(element)) {
|
if (shouldIgnoreElementFromSelection(element)) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Track only selectable top-level group members, so ignored elements such
|
||||||
|
// as bound text and locked elements don't affect group selection.
|
||||||
|
const groupId = element.groupIds.at(-1);
|
||||||
|
if (groupId) {
|
||||||
|
if (!groups[groupId]) {
|
||||||
|
groups[groupId] = [];
|
||||||
|
}
|
||||||
|
groups[groupId].push(element);
|
||||||
|
}
|
||||||
|
|
||||||
const strokeWidth = element.strokeWidth;
|
const strokeWidth = element.strokeWidth;
|
||||||
let labelAABB: Bounds | null = null;
|
let labelAABB: Bounds | null = null;
|
||||||
let elementAABB = getElementBounds(element, elementsMap);
|
let elementAABB = getElementBounds(element, elementsMap);
|
||||||
@@ -170,7 +180,7 @@ export const getElementsWithinSelection = (
|
|||||||
const associatedFrame = getContainingFrame(element, elementsMap);
|
const associatedFrame = getContainingFrame(element, elementsMap);
|
||||||
if (
|
if (
|
||||||
associatedFrame &&
|
associatedFrame &&
|
||||||
isElementIntersectingFrame(element, associatedFrame, elementsMap)
|
elementOverlapsWithFrame(element, associatedFrame, elementsMap)
|
||||||
) {
|
) {
|
||||||
const frameAABB = getElementBounds(associatedFrame, elementsMap);
|
const frameAABB = getElementBounds(associatedFrame, elementsMap);
|
||||||
elementAABB = [
|
elementAABB = [
|
||||||
@@ -209,10 +219,9 @@ export const getElementsWithinSelection = (
|
|||||||
if (boundsContainBounds(selectionBounds, commonAABB)) {
|
if (boundsContainBounds(selectionBounds, commonAABB)) {
|
||||||
if (framesInSelection && isFrameLikeElement(element)) {
|
if (framesInSelection && isFrameLikeElement(element)) {
|
||||||
framesInSelection.add(element.id);
|
framesInSelection.add(element.id);
|
||||||
} else {
|
|
||||||
elementsInSelection.push(element);
|
|
||||||
continue;
|
|
||||||
}
|
}
|
||||||
|
elementsInSelection.add(element);
|
||||||
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// 2. Handle the case where the label is overlapped by the selection box
|
// 2. Handle the case where the label is overlapped by the selection box
|
||||||
@@ -221,7 +230,7 @@ export const getElementsWithinSelection = (
|
|||||||
labelAABB &&
|
labelAABB &&
|
||||||
doBoundsIntersect(selectionBounds, labelAABB)
|
doBoundsIntersect(selectionBounds, labelAABB)
|
||||||
) {
|
) {
|
||||||
elementsInSelection.push(element);
|
elementsInSelection.add(element);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -311,7 +320,7 @@ export const getElementsWithinSelection = (
|
|||||||
framesInSelection.add(element.id);
|
framesInSelection.add(element.id);
|
||||||
}
|
}
|
||||||
|
|
||||||
elementsInSelection.push(element);
|
elementsInSelection.add(element);
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -320,21 +329,41 @@ export const getElementsWithinSelection = (
|
|||||||
// as it is separately handled in App.
|
// as it is separately handled in App.
|
||||||
}
|
}
|
||||||
|
|
||||||
elementsInSelection = framesInSelection
|
if (framesInSelection) {
|
||||||
? excludeElementsFromFrames(elementsInSelection, framesInSelection)
|
elementsInSelection.forEach((element) => {
|
||||||
: elementsInSelection;
|
if (element.frameId && framesInSelection.has(element.frameId)) {
|
||||||
|
elementsInSelection.delete(element);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
elementsInSelection = elementsInSelection.filter((element) => {
|
if (boxSelectionMode === "overlap") {
|
||||||
const containingFrame = getContainingFrame(element, elementsMap);
|
Array.from(elementsInSelection).forEach((element) => {
|
||||||
|
const groupId = element.groupIds.at(-1);
|
||||||
|
const group = groupId ? groups[groupId] : null;
|
||||||
|
|
||||||
if (containingFrame) {
|
group?.forEach((groupElement) => elementsInSelection.add(groupElement));
|
||||||
return elementOverlapsWithFrame(element, containingFrame, elementsMap);
|
});
|
||||||
}
|
} else if (boxSelectionMode === "contain") {
|
||||||
|
elementsInSelection.forEach((element) => {
|
||||||
|
// note: currently we only support top-level group handling since
|
||||||
|
// we don't support box selecting while editing the group/subgroup
|
||||||
|
// see https://github.com/excalidraw/excalidraw/pull/11234#issuecomment-4387654451
|
||||||
|
const groupId = element.groupIds.at(-1);
|
||||||
|
|
||||||
return true;
|
const group = groupId ? groups[groupId] : null;
|
||||||
});
|
|
||||||
|
|
||||||
return elementsInSelection;
|
if (
|
||||||
|
group &&
|
||||||
|
!group.every((groupElement) => elementsInSelection.has(groupElement))
|
||||||
|
) {
|
||||||
|
elementsInSelection.delete(element);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
// to maintain original order elements (namely for group selection)
|
||||||
|
return elements.filter((element) => elementsInSelection.has(element));
|
||||||
};
|
};
|
||||||
|
|
||||||
export const getVisibleAndNonSelectedElements = (
|
export const getVisibleAndNonSelectedElements = (
|
||||||
|
|||||||
@@ -1,59 +1,56 @@
|
|||||||
import { arrayToMapWithIndex } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
import type { ExcalidrawElement } from "./types";
|
import type { ExcalidrawElement } from "./types";
|
||||||
|
|
||||||
const normalizeGroupElementOrder = (elements: readonly ExcalidrawElement[]) => {
|
const defragmentGroups = (elements: readonly ExcalidrawElement[]) => {
|
||||||
const origElements: ExcalidrawElement[] = elements.slice();
|
const groupIdAtLevel = (element: ExcalidrawElement, level: number) => {
|
||||||
const sortedElements = new Set<ExcalidrawElement>();
|
return element.groupIds[element.groupIds.length - level - 1];
|
||||||
|
|
||||||
const orderInnerGroups = (
|
|
||||||
elements: readonly ExcalidrawElement[],
|
|
||||||
): ExcalidrawElement[] => {
|
|
||||||
const firstGroupSig = elements[0]?.groupIds?.join("");
|
|
||||||
const aGroup: ExcalidrawElement[] = [elements[0]];
|
|
||||||
const bGroup: ExcalidrawElement[] = [];
|
|
||||||
for (const element of elements.slice(1)) {
|
|
||||||
if (element.groupIds?.join("") === firstGroupSig) {
|
|
||||||
aGroup.push(element);
|
|
||||||
} else {
|
|
||||||
bGroup.push(element);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return bGroup.length ? [...aGroup, ...orderInnerGroups(bGroup)] : aGroup;
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const groupHandledElements = new Map<string, true>();
|
const orderLevel = (
|
||||||
|
levelElements: readonly ExcalidrawElement[],
|
||||||
|
level: number,
|
||||||
|
): ExcalidrawElement[] => {
|
||||||
|
const buckets = new Map<string, ExcalidrawElement[]>();
|
||||||
|
// Slots preserve first-occurrence order: a groupId reserves its slot
|
||||||
|
// the first time one of its members is seen; loose elements occupy
|
||||||
|
// their own slot. Groups are then expanded (and recursed into) in place.
|
||||||
|
const slots: (ExcalidrawElement | string)[] = [];
|
||||||
|
|
||||||
origElements.forEach((element, idx) => {
|
for (const element of levelElements) {
|
||||||
if (groupHandledElements.has(element.id)) {
|
const groupId = groupIdAtLevel(element, level);
|
||||||
return;
|
if (groupId === undefined) {
|
||||||
}
|
slots.push(element);
|
||||||
if (element.groupIds?.length) {
|
continue;
|
||||||
const topGroup = element.groupIds[element.groupIds.length - 1];
|
|
||||||
const groupElements = origElements.slice(idx).filter((element) => {
|
|
||||||
const ret = element?.groupIds?.some((id) => id === topGroup);
|
|
||||||
if (ret) {
|
|
||||||
groupHandledElements.set(element!.id, true);
|
|
||||||
}
|
|
||||||
return ret;
|
|
||||||
});
|
|
||||||
|
|
||||||
for (const elem of orderInnerGroups(groupElements)) {
|
|
||||||
sortedElements.add(elem);
|
|
||||||
}
|
}
|
||||||
} else {
|
let bucket = buckets.get(groupId);
|
||||||
sortedElements.add(element);
|
if (!bucket) {
|
||||||
|
bucket = [];
|
||||||
|
buckets.set(groupId, bucket);
|
||||||
|
slots.push(groupId);
|
||||||
|
}
|
||||||
|
bucket.push(element);
|
||||||
}
|
}
|
||||||
});
|
|
||||||
|
return slots.flatMap((slot) =>
|
||||||
|
typeof slot === "string"
|
||||||
|
? orderLevel(buckets.get(slot)!, level + 1)
|
||||||
|
: [slot],
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
// `groupIds` is stored innermost-first, so the outermost group is the
|
||||||
|
// last entry. We recurse from level 0 (outermost) inward.
|
||||||
|
const sortedElements = orderLevel(elements, 0);
|
||||||
|
|
||||||
// if there's a bug which resulted in losing some of the elements, return
|
// if there's a bug which resulted in losing some of the elements, return
|
||||||
// original instead as that's better than losing data
|
// original instead as that's better than losing data
|
||||||
if (sortedElements.size !== elements.length) {
|
if (sortedElements.length !== elements.length) {
|
||||||
console.error("normalizeGroupElementOrder: lost some elements... bailing!");
|
console.error("defragmentGroups: lost some elements... bailing!");
|
||||||
return elements;
|
return elements;
|
||||||
}
|
}
|
||||||
|
|
||||||
return [...sortedElements];
|
return sortedElements;
|
||||||
};
|
};
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -68,39 +65,40 @@ const normalizeGroupElementOrder = (elements: readonly ExcalidrawElement[]) => {
|
|||||||
const normalizeBoundElementsOrder = (
|
const normalizeBoundElementsOrder = (
|
||||||
elements: readonly ExcalidrawElement[],
|
elements: readonly ExcalidrawElement[],
|
||||||
) => {
|
) => {
|
||||||
const elementsMap = arrayToMapWithIndex(elements);
|
const elementsMap = arrayToMap(elements);
|
||||||
|
|
||||||
const origElements: (ExcalidrawElement | null)[] = elements.slice();
|
|
||||||
const sortedElements = new Set<ExcalidrawElement>();
|
const sortedElements = new Set<ExcalidrawElement>();
|
||||||
|
|
||||||
origElements.forEach((element, idx) => {
|
for (const element of elements) {
|
||||||
if (!element) {
|
if (sortedElements.has(element)) {
|
||||||
return;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (element.boundElements?.length) {
|
if (element.boundElements?.length) {
|
||||||
sortedElements.add(element);
|
sortedElements.add(element);
|
||||||
origElements[idx] = null;
|
for (const boundElement of element.boundElements) {
|
||||||
element.boundElements.forEach((boundElement) => {
|
|
||||||
const child = elementsMap.get(boundElement.id);
|
const child = elementsMap.get(boundElement.id);
|
||||||
if (child && boundElement.type === "text") {
|
if (child && boundElement.type === "text") {
|
||||||
sortedElements.add(child[0]);
|
sortedElements.add(child);
|
||||||
origElements[child[1]] = null;
|
|
||||||
}
|
}
|
||||||
});
|
|
||||||
} else if (element.type === "text" && element.containerId) {
|
|
||||||
const parent = elementsMap.get(element.containerId);
|
|
||||||
if (!parent?.[0].boundElements?.find((x) => x.id === element.id)) {
|
|
||||||
sortedElements.add(element);
|
|
||||||
origElements[idx] = null;
|
|
||||||
|
|
||||||
// if element has a container and container lists it, skip this element
|
|
||||||
// as it'll be taken care of by the container
|
|
||||||
}
|
}
|
||||||
} else {
|
continue;
|
||||||
sortedElements.add(element);
|
|
||||||
origElements[idx] = null;
|
|
||||||
}
|
}
|
||||||
});
|
|
||||||
|
// if element has a container and container lists it, skip this element
|
||||||
|
// as it'll be taken care of by the container
|
||||||
|
if (
|
||||||
|
element.type === "text" &&
|
||||||
|
element.containerId &&
|
||||||
|
elementsMap
|
||||||
|
.get(element.containerId)
|
||||||
|
?.boundElements?.some((el) => el.id === element.id)
|
||||||
|
) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
sortedElements.add(element);
|
||||||
|
}
|
||||||
|
|
||||||
// if there's a bug which resulted in losing some of the elements, return
|
// if there's a bug which resulted in losing some of the elements, return
|
||||||
// original instead as that's better than losing data
|
// original instead as that's better than losing data
|
||||||
@@ -117,5 +115,5 @@ const normalizeBoundElementsOrder = (
|
|||||||
export const normalizeElementOrder = (
|
export const normalizeElementOrder = (
|
||||||
elements: readonly ExcalidrawElement[],
|
elements: readonly ExcalidrawElement[],
|
||||||
) => {
|
) => {
|
||||||
return normalizeBoundElementsOrder(normalizeGroupElementOrder(elements));
|
return normalizeBoundElementsOrder(defragmentGroups(elements));
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -392,3 +392,23 @@ export const canBecomePolygon = (
|
|||||||
(points.length === 3 && !pointsEqual(points[0], points[points.length - 1]))
|
(points.length === 3 && !pointsEqual(points[0], points[points.length - 1]))
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const isEligibleFrameChildType = (type: ElementOrToolType) => {
|
||||||
|
switch (type) {
|
||||||
|
case "rectangle":
|
||||||
|
case "diamond":
|
||||||
|
case "ellipse":
|
||||||
|
case "arrow":
|
||||||
|
case "line":
|
||||||
|
case "freedraw":
|
||||||
|
case "text":
|
||||||
|
case "image":
|
||||||
|
case "frame":
|
||||||
|
case "embeddable": {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
default: {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|||||||
@@ -1,9 +1,8 @@
|
|||||||
/* eslint-disable no-lone-blocks */
|
/* eslint-disable no-lone-blocks */
|
||||||
import { generateKeyBetween } from "fractional-indexing";
|
|
||||||
|
|
||||||
import { arrayToMap } from "@excalidraw/common";
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
|
InvalidFractionalIndexError,
|
||||||
syncInvalidIndices,
|
syncInvalidIndices,
|
||||||
syncMovedIndices,
|
syncMovedIndices,
|
||||||
validateFractionalIndices,
|
validateFractionalIndices,
|
||||||
@@ -13,13 +12,34 @@ import { deepCopyElement } from "@excalidraw/element";
|
|||||||
|
|
||||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||||
|
|
||||||
|
import {
|
||||||
|
generateKeyBetween,
|
||||||
|
validateOrderKey,
|
||||||
|
} from "@excalidraw/fractional-indexing";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
ElementsMap,
|
ElementsMap,
|
||||||
ExcalidrawElement,
|
ExcalidrawElement,
|
||||||
FractionalIndex,
|
FractionalIndex,
|
||||||
} from "@excalidraw/element/types";
|
} from "@excalidraw/element/types";
|
||||||
|
|
||||||
import { InvalidFractionalIndexError } from "../src/fractionalIndex";
|
describe("fractional index format validation", () => {
|
||||||
|
it("should reject malformed base62 order keys", () => {
|
||||||
|
expect(() => validateOrderKey("a!")).toThrow();
|
||||||
|
expect(() => validateOrderKey("a_")).toThrow();
|
||||||
|
expect(() => validateOrderKey("a1!")).toThrow();
|
||||||
|
expect(() => validateOrderKey("a1_")).toThrow();
|
||||||
|
expect(() => validateOrderKey("zd0032")).toThrow();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should accept valid base62 order keys", () => {
|
||||||
|
expect(() => validateOrderKey("Zz")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("a0")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("a1")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("a1V")).not.toThrow();
|
||||||
|
expect(() => validateOrderKey("z".padEnd(28, "z"))).not.toThrow();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe("sync invalid indices with array order", () => {
|
describe("sync invalid indices with array order", () => {
|
||||||
describe("should NOT sync empty array", () => {
|
describe("should NOT sync empty array", () => {
|
||||||
@@ -104,6 +124,46 @@ describe("sync invalid indices with array order", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("should sync when fractional index is malformed", () => {
|
||||||
|
// "zd0032" has head "z" which requires length 28 per getIntegerLength,
|
||||||
|
// but the string is far too short, so validateOrderKey throws for it
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [{ id: "A", index: "zd0032" }],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: [],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [
|
||||||
|
{ id: "A", index: "a1" },
|
||||||
|
{ id: "B", index: "zd0032" },
|
||||||
|
{ id: "C", index: "a3" },
|
||||||
|
],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: ["A", "C"],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [{ id: "A", index: "a!" }],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: [],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
testInvalidIndicesSync({
|
||||||
|
elements: [
|
||||||
|
{ id: "A", index: "a1" },
|
||||||
|
{ id: "B", index: "a!" },
|
||||||
|
{ id: "C", index: "a2" },
|
||||||
|
],
|
||||||
|
expect: {
|
||||||
|
unchangedElements: ["A", "C"],
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe("should sync when fractional indices are duplicated", () => {
|
describe("should sync when fractional indices are duplicated", () => {
|
||||||
testInvalidIndicesSync({
|
testInvalidIndicesSync({
|
||||||
elements: [
|
elements: [
|
||||||
|
|||||||
@@ -2,15 +2,24 @@ import {
|
|||||||
convertToExcalidrawElements,
|
convertToExcalidrawElements,
|
||||||
Excalidraw,
|
Excalidraw,
|
||||||
} from "@excalidraw/excalidraw";
|
} from "@excalidraw/excalidraw";
|
||||||
|
import { arrayToMap } from "@excalidraw/common";
|
||||||
|
|
||||||
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
|
||||||
import { Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
|
import { Keyboard, Pointer, UI } from "@excalidraw/excalidraw/tests/helpers/ui";
|
||||||
|
import { getTextEditor } from "@excalidraw/excalidraw/tests/queries/dom";
|
||||||
import {
|
import {
|
||||||
getCloneByOrigId,
|
getCloneByOrigId,
|
||||||
render,
|
render,
|
||||||
} from "@excalidraw/excalidraw/tests/test-utils";
|
} from "@excalidraw/excalidraw/tests/test-utils";
|
||||||
|
|
||||||
import type { ExcalidrawElement } from "../src/types";
|
import { getSelectedElements } from "@excalidraw/excalidraw/scene";
|
||||||
|
|
||||||
|
import { elementOverlapsWithFrame } from "../src/frame";
|
||||||
|
|
||||||
|
import type {
|
||||||
|
ExcalidrawElement,
|
||||||
|
ExcalidrawFrameLikeElement,
|
||||||
|
} from "../src/types";
|
||||||
|
|
||||||
const { h } = window;
|
const { h } = window;
|
||||||
const mouse = new Pointer("mouse");
|
const mouse = new Pointer("mouse");
|
||||||
@@ -125,6 +134,250 @@ describe("adding elements to frames", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should treat an element fully containing a frame as overlapping the frame", () => {
|
||||||
|
const containingRect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: -50,
|
||||||
|
y: -50,
|
||||||
|
width: 250,
|
||||||
|
height: 250,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([containingRect, frame]);
|
||||||
|
|
||||||
|
expect(
|
||||||
|
elementOverlapsWithFrame(
|
||||||
|
containingRect,
|
||||||
|
frame as ExcalidrawFrameLikeElement,
|
||||||
|
arrayToMap(h.elements),
|
||||||
|
),
|
||||||
|
).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not add a newly created element to a frame behind a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, cover]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) => element.id !== frame.id && element.id !== cover.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(null);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
cover.id,
|
||||||
|
createdElement?.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should add a newly created element to a frame over a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([cover, frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) => element.id !== frame.id && element.id !== cover.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should highlight the target frame while creating a new element", () => {
|
||||||
|
API.setElements([frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||||
|
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should highlight the target frame while hovering with a creation tool", () => {
|
||||||
|
API.setElements([frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||||
|
|
||||||
|
mouse.moveTo(200, 200);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not add grid-snapped text outside the frame to the clicked frame", async () => {
|
||||||
|
const offsetFrame = API.createElement({
|
||||||
|
id: "offsetFrame",
|
||||||
|
type: "frame",
|
||||||
|
x: 10,
|
||||||
|
y: 0,
|
||||||
|
width: 150,
|
||||||
|
height: 150,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([offsetFrame]);
|
||||||
|
API.setAppState({
|
||||||
|
gridModeEnabled: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
UI.clickTool("text");
|
||||||
|
mouse.clickAt(12, 0);
|
||||||
|
|
||||||
|
await getTextEditor();
|
||||||
|
|
||||||
|
const createdText = h.elements.find(
|
||||||
|
(element) => element.id !== offsetFrame.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdText?.x).toBe(0);
|
||||||
|
expect(createdText?.y).toBe(0);
|
||||||
|
expect(createdText?.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should add a newly created element to a frame behind another frame", () => {
|
||||||
|
const lockedFrame = API.createElement({
|
||||||
|
id: "lockedFrame",
|
||||||
|
type: "frame",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
locked: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, lockedFrame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) => element.id !== frame.id && element.id !== lockedFrame.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should insert a newly created frame child just below its frame", () => {
|
||||||
|
const frameChildUnderCursor = API.createElement({
|
||||||
|
id: "frameChildUnderCursor",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 20,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frameChildUnderCursor, otherFrameChild, frame]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) =>
|
||||||
|
element.id !== frame.id &&
|
||||||
|
element.id !== frameChildUnderCursor.id &&
|
||||||
|
element.id !== otherFrameChild.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frameChildUnderCursor.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
createdElement?.id,
|
||||||
|
frame.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should insert a newly created frame child above the highest frame child", () => {
|
||||||
|
const frameChildUnderCursor = API.createElement({
|
||||||
|
id: "frameChildUnderCursor",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 20,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, frameChildUnderCursor, otherFrameChild]);
|
||||||
|
|
||||||
|
UI.clickTool("rectangle");
|
||||||
|
mouse.downAt(20, 20);
|
||||||
|
mouse.moveTo(40, 40);
|
||||||
|
mouse.upAt(40, 40);
|
||||||
|
|
||||||
|
const createdElement = h.elements.find(
|
||||||
|
(element) =>
|
||||||
|
element.id !== frame.id &&
|
||||||
|
element.id !== frameChildUnderCursor.id &&
|
||||||
|
element.id !== otherFrameChild.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(createdElement?.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChildUnderCursor.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
createdElement?.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
const commonTestCases = async (
|
const commonTestCases = async (
|
||||||
func: typeof resizeFrameOverElement | typeof dragElementIntoFrame,
|
func: typeof resizeFrameOverElement | typeof dragElementIntoFrame,
|
||||||
) => {
|
) => {
|
||||||
@@ -415,6 +668,345 @@ describe("adding elements to frames", () => {
|
|||||||
describe("dragging elements into the frame", async () => {
|
describe("dragging elements into the frame", async () => {
|
||||||
await commonTestCases(dragElementIntoFrame);
|
await commonTestCases(dragElementIntoFrame);
|
||||||
|
|
||||||
|
it("should add a dragged element fully containing the frame", () => {
|
||||||
|
const containingRect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 220,
|
||||||
|
y: 20,
|
||||||
|
width: 300,
|
||||||
|
height: 300,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, containingRect]);
|
||||||
|
|
||||||
|
dragElementIntoFrame(frame, containingRect);
|
||||||
|
|
||||||
|
expect(API.getElement(containingRect).frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should drag an element into a frame", () => {
|
||||||
|
API.setElements([rect2, frame]);
|
||||||
|
|
||||||
|
dragElementIntoFrame(frame, rect2);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should layer a dragged element above the highest frame child", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, frameChild, rect2]);
|
||||||
|
|
||||||
|
dragElementIntoFrame(frame, rect2);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
rect2.id,
|
||||||
|
]);
|
||||||
|
expect(rect2.index! > frameChild.index!).toBe(true);
|
||||||
|
expect(rect2.index! > frame.index!).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should preview a dragged element above the highest frame child before pointerup", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([rect2, frame, frameChild]);
|
||||||
|
API.setSelectedElements([rect2]);
|
||||||
|
API.updateElement(rect2, {
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
});
|
||||||
|
|
||||||
|
const getRenderableElementIds = (
|
||||||
|
selectedElementsAreBeingDragged: boolean,
|
||||||
|
) => {
|
||||||
|
return h.app.renderer
|
||||||
|
.getRenderableElements({
|
||||||
|
zoom: h.state.zoom,
|
||||||
|
offsetLeft: 0,
|
||||||
|
offsetTop: 0,
|
||||||
|
scrollX: 0,
|
||||||
|
scrollY: 0,
|
||||||
|
height: 1000,
|
||||||
|
width: 1000,
|
||||||
|
editingTextElement: h.state.editingTextElement,
|
||||||
|
newElement: h.state.newElement,
|
||||||
|
selectedElements: getSelectedElements(h.elements, h.state),
|
||||||
|
selectedElementsAreBeingDragged,
|
||||||
|
frameToHighlight: frame as ExcalidrawFrameLikeElement,
|
||||||
|
})
|
||||||
|
.visibleElements.map((element) => element.id);
|
||||||
|
};
|
||||||
|
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
rect2.id,
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
]);
|
||||||
|
expect(getRenderableElementIds(false)).toEqual([
|
||||||
|
rect2.id,
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
]);
|
||||||
|
expect(getRenderableElementIds(true)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
rect2.id,
|
||||||
|
]);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
rect2.id,
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
]);
|
||||||
|
expect(rect2.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not preview reorder dragged elements already in the highlighted frame", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 40,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frameChild, frame, otherFrameChild]);
|
||||||
|
API.setSelectedElements([frameChild]);
|
||||||
|
|
||||||
|
const renderableElementIds = h.app.renderer
|
||||||
|
.getRenderableElements({
|
||||||
|
zoom: h.state.zoom,
|
||||||
|
offsetLeft: 0,
|
||||||
|
offsetTop: 0,
|
||||||
|
scrollX: 0,
|
||||||
|
scrollY: 0,
|
||||||
|
height: 1000,
|
||||||
|
width: 1000,
|
||||||
|
editingTextElement: h.state.editingTextElement,
|
||||||
|
newElement: h.state.newElement,
|
||||||
|
selectedElements: getSelectedElements(h.elements, h.state),
|
||||||
|
selectedElementsAreBeingDragged: true,
|
||||||
|
frameToHighlight: frame as ExcalidrawFrameLikeElement,
|
||||||
|
})
|
||||||
|
.visibleElements.map((element) => element.id);
|
||||||
|
|
||||||
|
expect(renderableElementIds).toEqual([
|
||||||
|
frameChild.id,
|
||||||
|
frame.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should put a dragged mixed selection above the highest frame child", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
boundElements: [{ id: "boundText", type: "text" }],
|
||||||
|
});
|
||||||
|
const boundText = API.createElement({
|
||||||
|
id: "boundText",
|
||||||
|
type: "text",
|
||||||
|
x: 50,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
containerId: frameChild.id,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 80,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const nonFrameElement = API.createElement({
|
||||||
|
id: "nonFrameElement",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 155,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([
|
||||||
|
frame,
|
||||||
|
frameChild,
|
||||||
|
boundText,
|
||||||
|
otherFrameChild,
|
||||||
|
nonFrameElement,
|
||||||
|
]);
|
||||||
|
API.setSelectedElements([frameChild, nonFrameElement]);
|
||||||
|
|
||||||
|
mouse.downAt(
|
||||||
|
nonFrameElement.x + nonFrameElement.width / 2,
|
||||||
|
nonFrameElement.y + nonFrameElement.height / 2,
|
||||||
|
);
|
||||||
|
mouse.moveTo(frame.x + frame.width - 5, nonFrameElement.y + 10);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
expect(frameChild.frameId).toBe(frame.id);
|
||||||
|
expect(boundText.frameId).toBe(frame.id);
|
||||||
|
expect(nonFrameElement.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
frameChild.id,
|
||||||
|
boundText.id,
|
||||||
|
nonFrameElement.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not reorder dragged elements already in the highlighted frame", () => {
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const otherFrameChild = API.createElement({
|
||||||
|
id: "otherFrameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 80,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, frameChild, otherFrameChild]);
|
||||||
|
API.setSelectedElements([frameChild]);
|
||||||
|
|
||||||
|
mouse.downAt(
|
||||||
|
frameChild.x + frameChild.width / 2,
|
||||||
|
frameChild.y + frameChild.height / 2,
|
||||||
|
);
|
||||||
|
mouse.moveTo(frameChild.x + frameChild.width / 2 + 5, frameChild.y + 10);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
expect(frameChild.frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frame.id,
|
||||||
|
frameChild.id,
|
||||||
|
otherFrameChild.id,
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should not drag an element into a frame behind a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
API.setElements([frame, cover, rect2]);
|
||||||
|
|
||||||
|
mouse.clickAt(rect2.x, rect2.y);
|
||||||
|
mouse.downAt(rect2.x + rect2.width / 2, rect2.y + rect2.height / 2);
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
mouse.upAt(20, 20);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should drag an element into a frame over a non-frame element", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
API.setElements([cover, rect2, frame]);
|
||||||
|
|
||||||
|
mouse.clickAt(rect2.x, rect2.y);
|
||||||
|
mouse.downAt(rect2.x + rect2.width / 2, rect2.y + rect2.height / 2);
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
mouse.upAt(20, 20);
|
||||||
|
|
||||||
|
expect(rect2.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should keep dragging a frame child over a non-frame element above its frame", () => {
|
||||||
|
const cover = API.createElement({
|
||||||
|
id: "cover",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 80,
|
||||||
|
height: 80,
|
||||||
|
backgroundColor: "#ffc9c9",
|
||||||
|
});
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 20,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frameChild, frame, cover]);
|
||||||
|
API.setSelectedElements([frameChild]);
|
||||||
|
|
||||||
|
mouse.downAt(
|
||||||
|
frameChild.x + frameChild.width / 2,
|
||||||
|
frameChild.y + frameChild.height / 2,
|
||||||
|
);
|
||||||
|
mouse.moveTo(20, 20);
|
||||||
|
|
||||||
|
expect(h.state.frameToHighlight?.id).toBe(frame.id);
|
||||||
|
|
||||||
|
mouse.upAt(20, 20);
|
||||||
|
|
||||||
|
expect(frameChild.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
it.skip("should drag element inside, duplicate it and keep it in frame", () => {
|
it.skip("should drag element inside, duplicate it and keep it in frame", () => {
|
||||||
API.setElements([frame, rect2]);
|
API.setElements([frame, rect2]);
|
||||||
|
|
||||||
|
|||||||
@@ -326,19 +326,59 @@ describe("normalizeElementsOrder", () => {
|
|||||||
]),
|
]),
|
||||||
[
|
[
|
||||||
"BA_rect1",
|
"BA_rect1",
|
||||||
|
"CBA_rect3",
|
||||||
|
"CBA_rect7",
|
||||||
"BA_rect5",
|
"BA_rect5",
|
||||||
"BA_rect6",
|
"BA_rect6",
|
||||||
"A_rect2",
|
"A_rect2",
|
||||||
"A_rect5",
|
"A_rect5",
|
||||||
"CBA_rect3",
|
|
||||||
"CBA_rect7",
|
|
||||||
"rect4",
|
"rect4",
|
||||||
"X_rect8",
|
"X_rect8",
|
||||||
"X_rect11",
|
|
||||||
"YX_rect10",
|
"YX_rect10",
|
||||||
|
"X_rect11",
|
||||||
"rect9",
|
"rect9",
|
||||||
],
|
],
|
||||||
);
|
);
|
||||||
|
assertOrder(
|
||||||
|
normalizeElementOrder([
|
||||||
|
API.createElement({
|
||||||
|
id: "A_rect1",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["A"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "CBA_rect2",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["C", "B", "A"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "A_rect3",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["A"],
|
||||||
|
}),
|
||||||
|
]),
|
||||||
|
["A_rect1", "CBA_rect2", "A_rect3"],
|
||||||
|
);
|
||||||
|
assertOrder(
|
||||||
|
normalizeElementOrder([
|
||||||
|
API.createElement({
|
||||||
|
id: "abcT_rect1",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["ab", "c", "T"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "abcT_rect2",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["a", "bc", "T"],
|
||||||
|
}),
|
||||||
|
API.createElement({
|
||||||
|
id: "abcT_rect3",
|
||||||
|
type: "rectangle",
|
||||||
|
groupIds: ["ab", "c", "T"],
|
||||||
|
}),
|
||||||
|
]),
|
||||||
|
["abcT_rect1", "abcT_rect3", "abcT_rect2"],
|
||||||
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
// TODO
|
// TODO
|
||||||
|
|||||||
@@ -101,6 +101,7 @@ export const actionDeselect = register({
|
|||||||
selectionElement: null,
|
selectionElement: null,
|
||||||
showHyperlinkPopup: false,
|
showHyperlinkPopup: false,
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
|
frameToHighlight: null,
|
||||||
},
|
},
|
||||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||||
};
|
};
|
||||||
@@ -118,6 +119,7 @@ export const actionDeselect = register({
|
|||||||
selectionElement: null,
|
selectionElement: null,
|
||||||
showHyperlinkPopup: false,
|
showHyperlinkPopup: false,
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
|
frameToHighlight: null,
|
||||||
},
|
},
|
||||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -335,8 +335,8 @@ export const actionFinalize = register<FormData>({
|
|||||||
selectionElement: null,
|
selectionElement: null,
|
||||||
multiElement: null,
|
multiElement: null,
|
||||||
editingTextElement: null,
|
editingTextElement: null,
|
||||||
startBoundElement: null,
|
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
|
frameToHighlight: null,
|
||||||
selectedElementIds:
|
selectedElementIds:
|
||||||
element &&
|
element &&
|
||||||
!appState.activeTool.locked &&
|
!appState.activeTool.locked &&
|
||||||
|
|||||||
@@ -205,7 +205,6 @@ export const actionWrapSelectionInFrame = register({
|
|||||||
[...app.scene.getElementsIncludingDeleted(), frame],
|
[...app.scene.getElementsIncludingDeleted(), frame],
|
||||||
selectedElements,
|
selectedElements,
|
||||||
frame,
|
frame,
|
||||||
appState,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
|
|||||||
@@ -277,7 +277,6 @@ export const actionUngroup = register({
|
|||||||
elementsMap,
|
elementsMap,
|
||||||
),
|
),
|
||||||
frame,
|
frame,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
import {
|
import {
|
||||||
isWindows,
|
|
||||||
KEYS,
|
KEYS,
|
||||||
matchKey,
|
matchKey,
|
||||||
arrayToMap,
|
arrayToMap,
|
||||||
@@ -114,7 +113,7 @@ export const createRedoAction: ActionCreator = (history) => ({
|
|||||||
),
|
),
|
||||||
keyTest: (event) =>
|
keyTest: (event) =>
|
||||||
(event[KEYS.CTRL_OR_CMD] && event.shiftKey && matchKey(event, KEYS.Z)) ||
|
(event[KEYS.CTRL_OR_CMD] && event.shiftKey && matchKey(event, KEYS.Z)) ||
|
||||||
(isWindows && event.ctrlKey && !event.shiftKey && matchKey(event, KEYS.Y)),
|
(event[KEYS.CTRL_OR_CMD] && !event.shiftKey && matchKey(event, KEYS.Y)),
|
||||||
PanelComponent: ({ appState, updateData, data, app }) => {
|
PanelComponent: ({ appState, updateData, data, app }) => {
|
||||||
const { isRedoStackEmpty } = useEmitter(
|
const { isRedoStackEmpty } = useEmitter(
|
||||||
history.onHistoryChangedEmitter,
|
history.onHistoryChangedEmitter,
|
||||||
|
|||||||
@@ -100,7 +100,6 @@ export const getDefaultAppState = (): Omit<
|
|||||||
open: false,
|
open: false,
|
||||||
panels: STATS_PANELS.generalStats | STATS_PANELS.elementProperties,
|
panels: STATS_PANELS.generalStats | STATS_PANELS.elementProperties,
|
||||||
},
|
},
|
||||||
startBoundElement: null,
|
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
frameRendering: { enabled: true, clip: true, name: true, outline: true },
|
frameRendering: { enabled: true, clip: true, name: true, outline: true },
|
||||||
frameToHighlight: null,
|
frameToHighlight: null,
|
||||||
@@ -237,7 +236,6 @@ const APP_STATE_STORAGE_CONF = (<
|
|||||||
selectionElement: { browser: false, export: false, server: false },
|
selectionElement: { browser: false, export: false, server: false },
|
||||||
shouldCacheIgnoreZoom: { browser: true, export: false, server: false },
|
shouldCacheIgnoreZoom: { browser: true, export: false, server: false },
|
||||||
stats: { browser: true, export: false, server: false },
|
stats: { browser: true, export: false, server: false },
|
||||||
startBoundElement: { browser: false, export: false, server: false },
|
|
||||||
suggestedBinding: { browser: false, export: false, server: false },
|
suggestedBinding: { browser: false, export: false, server: false },
|
||||||
frameRendering: { browser: false, export: false, server: false },
|
frameRendering: { browser: false, export: false, server: false },
|
||||||
frameToHighlight: { browser: false, export: false, server: false },
|
frameToHighlight: { browser: false, export: false, server: false },
|
||||||
|
|||||||
@@ -28,7 +28,6 @@ import {
|
|||||||
APP_NAME,
|
APP_NAME,
|
||||||
CURSOR_TYPE,
|
CURSOR_TYPE,
|
||||||
DEFAULT_TRANSFORM_HANDLE_SPACING,
|
DEFAULT_TRANSFORM_HANDLE_SPACING,
|
||||||
DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT,
|
|
||||||
DEFAULT_VERTICAL_ALIGN,
|
DEFAULT_VERTICAL_ALIGN,
|
||||||
DRAGGING_THRESHOLD,
|
DRAGGING_THRESHOLD,
|
||||||
ELEMENT_SHIFT_TRANSLATE_AMOUNT,
|
ELEMENT_SHIFT_TRANSLATE_AMOUNT,
|
||||||
@@ -38,7 +37,6 @@ import {
|
|||||||
IMAGE_MIME_TYPES,
|
IMAGE_MIME_TYPES,
|
||||||
IMAGE_RENDER_TIMEOUT,
|
IMAGE_RENDER_TIMEOUT,
|
||||||
LINE_CONFIRM_THRESHOLD,
|
LINE_CONFIRM_THRESHOLD,
|
||||||
MAX_ALLOWED_FILE_BYTES,
|
|
||||||
MIME_TYPES,
|
MIME_TYPES,
|
||||||
MQ_RIGHT_SIDEBAR_MIN_WIDTH,
|
MQ_RIGHT_SIDEBAR_MIN_WIDTH,
|
||||||
POINTER_BUTTON,
|
POINTER_BUTTON,
|
||||||
@@ -176,7 +174,9 @@ import {
|
|||||||
isValidTextContainer,
|
isValidTextContainer,
|
||||||
redrawTextBoundingBox,
|
redrawTextBoundingBox,
|
||||||
hasBoundingBox,
|
hasBoundingBox,
|
||||||
|
getCommonFrameId,
|
||||||
getFrameChildren,
|
getFrameChildren,
|
||||||
|
getFrameChildrenInsertionIndex,
|
||||||
isCursorInFrame,
|
isCursorInFrame,
|
||||||
addElementsToFrame,
|
addElementsToFrame,
|
||||||
replaceAllElementsInFrame,
|
replaceAllElementsInFrame,
|
||||||
@@ -259,6 +259,7 @@ import {
|
|||||||
maybeHandleArrowPointlikeDrag,
|
maybeHandleArrowPointlikeDrag,
|
||||||
getUncroppedWidthAndHeight,
|
getUncroppedWidthAndHeight,
|
||||||
getActiveTextElement,
|
getActiveTextElement,
|
||||||
|
isEligibleFrameChildType,
|
||||||
} from "@excalidraw/element";
|
} from "@excalidraw/element";
|
||||||
|
|
||||||
import type { GlobalPoint, LocalPoint, Radians } from "@excalidraw/math";
|
import type { GlobalPoint, LocalPoint, Radians } from "@excalidraw/math";
|
||||||
@@ -603,6 +604,8 @@ const YOUTUBE_VIDEO_STATES = new Map<
|
|||||||
ValueOf<typeof YOUTUBE_STATES>
|
ValueOf<typeof YOUTUBE_STATES>
|
||||||
>();
|
>();
|
||||||
|
|
||||||
|
const MAX_EMBEDDABLE_VIEWPORT_SCALE = 4;
|
||||||
|
|
||||||
let IS_PLAIN_PASTE = false;
|
let IS_PLAIN_PASTE = false;
|
||||||
let IS_PLAIN_PASTE_TIMER = 0;
|
let IS_PLAIN_PASTE_TIMER = 0;
|
||||||
let PLAIN_PASTE_TOAST_SHOWN = false;
|
let PLAIN_PASTE_TOAST_SHOWN = false;
|
||||||
@@ -1735,6 +1738,18 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
this.state.activeEmbeddable?.element === el &&
|
this.state.activeEmbeddable?.element === el &&
|
||||||
this.state.activeEmbeddable?.state === "hover";
|
this.state.activeEmbeddable?.state === "hover";
|
||||||
|
|
||||||
|
// scale video embeds based on zoom (capped) so that smaller embeds
|
||||||
|
// on canvas when zoomed are still of legible quality
|
||||||
|
// (note: for some embed types like gdrive, the quality is poor when
|
||||||
|
// scaling mid playback and works only when you initially start the
|
||||||
|
// playback at the higher zoom level)
|
||||||
|
const shouldScaleEmbeddableViewport = src?.type === "video";
|
||||||
|
const embeddableViewportScale = clamp(
|
||||||
|
shouldScaleEmbeddableViewport ? scale : 1,
|
||||||
|
0.75,
|
||||||
|
MAX_EMBEDDABLE_VIEWPORT_SCALE,
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
key={el.id}
|
key={el.id}
|
||||||
@@ -1801,31 +1816,42 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
padding: `${el.strokeWidth}px`,
|
padding: `${el.strokeWidth}px`,
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{(isEmbeddableElement(el)
|
<div
|
||||||
? this.props.renderEmbeddable?.(el, this.state)
|
className="excalidraw__embeddable__content"
|
||||||
: null) ?? (
|
style={{
|
||||||
<iframe
|
width: `${embeddableViewportScale * 100}%`,
|
||||||
ref={(ref) => this.cacheEmbeddableRef(el, ref)}
|
height: `${embeddableViewportScale * 100}%`,
|
||||||
className="excalidraw__embeddable"
|
transform: `scale(${1 / embeddableViewportScale})`,
|
||||||
srcDoc={
|
}}
|
||||||
src?.type === "document"
|
>
|
||||||
? src.srcdoc(this.state.theme)
|
{(isEmbeddableElement(el)
|
||||||
: undefined
|
? this.props.renderEmbeddable?.(el, this.state)
|
||||||
}
|
: null) ?? (
|
||||||
src={
|
<iframe
|
||||||
src?.type !== "document" ? src?.link ?? "" : undefined
|
ref={(ref) => this.cacheEmbeddableRef(el, ref)}
|
||||||
}
|
className="excalidraw__embeddable"
|
||||||
// https://stackoverflow.com/q/18470015
|
srcDoc={
|
||||||
scrolling="no"
|
src?.type === "document"
|
||||||
referrerPolicy="no-referrer-when-downgrade"
|
? src.srcdoc(this.state.theme)
|
||||||
title="Excalidraw Embedded Content"
|
: undefined
|
||||||
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
|
}
|
||||||
allowFullScreen={true}
|
src={
|
||||||
sandbox={`${
|
src?.type !== "document" ? src?.link ?? "" : undefined
|
||||||
src?.sandbox?.allowSameOrigin ? "allow-same-origin" : ""
|
}
|
||||||
} allow-scripts allow-forms allow-popups allow-popups-to-escape-sandbox allow-presentation allow-downloads`}
|
// https://stackoverflow.com/q/18470015
|
||||||
/>
|
scrolling="no"
|
||||||
)}
|
referrerPolicy="no-referrer-when-downgrade"
|
||||||
|
title="Excalidraw Embedded Content"
|
||||||
|
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
|
||||||
|
allowFullScreen={true}
|
||||||
|
sandbox={`${
|
||||||
|
src?.sandbox?.allowSameOrigin
|
||||||
|
? "allow-same-origin"
|
||||||
|
: ""
|
||||||
|
} allow-scripts allow-forms allow-popups allow-popups-to-escape-sandbox allow-presentation allow-downloads`}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
@@ -2067,20 +2093,30 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
const selectedElements = this.scene.getSelectedElements(this.state);
|
const selectedElements = this.scene.getSelectedElements(this.state);
|
||||||
const { renderTopRightUI, renderTopLeftUI, renderCustomStats } = this.props;
|
const { renderTopRightUI, renderTopLeftUI, renderCustomStats } = this.props;
|
||||||
|
|
||||||
const sceneNonce = this.scene.getSceneNonce();
|
const {
|
||||||
const { elementsMap, visibleElements } =
|
elementsMap,
|
||||||
this.renderer.getRenderableElements({
|
visibleElements,
|
||||||
sceneNonce,
|
canvasNonce,
|
||||||
zoom: this.state.zoom,
|
/**
|
||||||
offsetLeft: this.state.offsetLeft,
|
* element to draw on the <NewElementCanvas> for optimization purposes.
|
||||||
offsetTop: this.state.offsetTop,
|
* Can be null even if this.state.newElement defined
|
||||||
scrollX: this.state.scrollX,
|
* (e.g. when its zIndex isn't on top) */
|
||||||
scrollY: this.state.scrollY,
|
newElementCanvasElement,
|
||||||
height: this.state.height,
|
} = this.renderer.getRenderableElements({
|
||||||
width: this.state.width,
|
zoom: this.state.zoom,
|
||||||
editingTextElement: this.state.editingTextElement,
|
offsetLeft: this.state.offsetLeft,
|
||||||
newElementId: this.state.newElement?.id,
|
offsetTop: this.state.offsetTop,
|
||||||
});
|
scrollX: this.state.scrollX,
|
||||||
|
scrollY: this.state.scrollY,
|
||||||
|
height: this.state.height,
|
||||||
|
width: this.state.width,
|
||||||
|
editingTextElement: this.state.editingTextElement,
|
||||||
|
newElement: this.state.newElement,
|
||||||
|
selectedElements,
|
||||||
|
selectedElementsAreBeingDragged:
|
||||||
|
this.state.selectedElementsAreBeingDragged,
|
||||||
|
frameToHighlight: this.state.frameToHighlight,
|
||||||
|
});
|
||||||
this.visibleElements = visibleElements;
|
this.visibleElements = visibleElements;
|
||||||
|
|
||||||
const allElementsMap = this.scene.getNonDeletedElementsMap();
|
const allElementsMap = this.scene.getNonDeletedElementsMap();
|
||||||
@@ -2299,7 +2335,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
elementsMap={elementsMap}
|
elementsMap={elementsMap}
|
||||||
allElementsMap={allElementsMap}
|
allElementsMap={allElementsMap}
|
||||||
visibleElements={visibleElements}
|
visibleElements={visibleElements}
|
||||||
sceneNonce={sceneNonce}
|
canvasNonce={canvasNonce}
|
||||||
selectionNonce={
|
selectionNonce={
|
||||||
this.state.selectionElement?.versionNonce
|
this.state.selectionElement?.versionNonce
|
||||||
}
|
}
|
||||||
@@ -2320,9 +2356,10 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
theme: this.state.theme,
|
theme: this.state.theme,
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
{this.state.newElement && (
|
{newElementCanvasElement && (
|
||||||
<NewElementCanvas
|
<NewElementCanvas
|
||||||
appState={this.state}
|
appState={this.state}
|
||||||
|
newElement={newElementCanvasElement}
|
||||||
scale={window.devicePixelRatio}
|
scale={window.devicePixelRatio}
|
||||||
rc={this.rc}
|
rc={this.rc}
|
||||||
elementsMap={elementsMap}
|
elementsMap={elementsMap}
|
||||||
@@ -2350,7 +2387,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
visibleElements={visibleElements}
|
visibleElements={visibleElements}
|
||||||
allElementsMap={allElementsMap}
|
allElementsMap={allElementsMap}
|
||||||
selectedElements={selectedElements}
|
selectedElements={selectedElements}
|
||||||
sceneNonce={sceneNonce}
|
canvasNonce={canvasNonce}
|
||||||
selectionNonce={
|
selectionNonce={
|
||||||
this.state.selectionElement?.versionNonce
|
this.state.selectionElement?.versionNonce
|
||||||
}
|
}
|
||||||
@@ -2662,7 +2699,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
locked: false,
|
locked: false,
|
||||||
});
|
});
|
||||||
|
|
||||||
this.scene.insertElement(frame);
|
this.insertNewElement(frame);
|
||||||
|
|
||||||
for (const child of selectedElements) {
|
for (const child of selectedElements) {
|
||||||
this.scene.mutateElement(child, { frameId: frame.id });
|
this.scene.mutateElement(child, { frameId: frame.id });
|
||||||
@@ -3740,6 +3777,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
position:
|
position:
|
||||||
this.editorInterface.formFactor === "desktop" ? "cursor" : "center",
|
this.editorInterface.formFactor === "desktop" ? "cursor" : "center",
|
||||||
retainSeed: isPlainPaste,
|
retainSeed: isPlainPaste,
|
||||||
|
preserveFrameChildrenOrder: true,
|
||||||
});
|
});
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@@ -3883,6 +3921,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
position: { clientX: number; clientY: number } | "cursor" | "center";
|
position: { clientX: number; clientY: number } | "cursor" | "center";
|
||||||
retainSeed?: boolean;
|
retainSeed?: boolean;
|
||||||
fitToContent?: boolean;
|
fitToContent?: boolean;
|
||||||
|
preserveFrameChildrenOrder?: boolean;
|
||||||
}) => {
|
}) => {
|
||||||
const elements = restoreElements(opts.elements, null, {
|
const elements = restoreElements(opts.elements, null, {
|
||||||
deleteInvisibleElements: true,
|
deleteInvisibleElements: true,
|
||||||
@@ -3924,6 +3963,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
});
|
});
|
||||||
}),
|
}),
|
||||||
randomizeSeed: !opts.retainSeed,
|
randomizeSeed: !opts.retainSeed,
|
||||||
|
preserveFrameChildrenOrder: opts.preserveFrameChildrenOrder,
|
||||||
});
|
});
|
||||||
|
|
||||||
const prevElements = this.scene.getElementsIncludingDeleted();
|
const prevElements = this.scene.getElementsIncludingDeleted();
|
||||||
@@ -3945,11 +3985,10 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
duplicatedElements,
|
duplicatedElements,
|
||||||
topLayerFrame,
|
topLayerFrame,
|
||||||
);
|
);
|
||||||
addElementsToFrame(
|
nextElements = addElementsToFrame(
|
||||||
nextElements,
|
nextElements,
|
||||||
eligibleElements,
|
eligibleElements,
|
||||||
topLayerFrame,
|
topLayerFrame,
|
||||||
this.state,
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -4175,7 +4214,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
this.scene.insertElements(textElements);
|
this.insertNewElements(textElements);
|
||||||
this.store.scheduleCapture();
|
this.store.scheduleCapture();
|
||||||
this.setState({
|
this.setState({
|
||||||
selectedElementIds: makeNextSelectedElementIds(
|
selectedElementIds: makeNextSelectedElementIds(
|
||||||
@@ -5431,7 +5470,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
if (!event[KEYS.CTRL_OR_CMD]) {
|
if (!event[KEYS.CTRL_OR_CMD]) {
|
||||||
if (this.flowChartCreator.isCreatingChart) {
|
if (this.flowChartCreator.isCreatingChart) {
|
||||||
if (this.flowChartCreator.pendingNodes?.length) {
|
if (this.flowChartCreator.pendingNodes?.length) {
|
||||||
this.scene.insertElements(this.flowChartCreator.pendingNodes);
|
this.insertNewElements(this.flowChartCreator.pendingNodes);
|
||||||
}
|
}
|
||||||
|
|
||||||
const firstNode = this.flowChartCreator.pendingNodes?.[0];
|
const firstNode = this.flowChartCreator.pendingNodes?.[0];
|
||||||
@@ -5529,6 +5568,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
selectedLinearElement: isSelectionLikeTool(nextActiveTool.type)
|
selectedLinearElement: isSelectionLikeTool(nextActiveTool.type)
|
||||||
? prevState.selectedLinearElement
|
? prevState.selectedLinearElement
|
||||||
: null,
|
: null,
|
||||||
|
frameToHighlight: null,
|
||||||
} as const;
|
} as const;
|
||||||
|
|
||||||
if (nextActiveTool.type === "freedraw") {
|
if (nextActiveTool.type === "freedraw") {
|
||||||
@@ -6126,6 +6166,12 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
hitElement = elements[index];
|
hitElement = elements[index];
|
||||||
break;
|
break;
|
||||||
} else if (x1 < x && x < x2 && y1 < y && y < y2) {
|
} else if (x1 < x && x < x2 && y1 < y && y < y2) {
|
||||||
|
// to allow binding to containers within frames,
|
||||||
|
// ignore frames in hit testing
|
||||||
|
if (isFrameLikeElement(elements[index])) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
hitElement = elements[index];
|
hitElement = elements[index];
|
||||||
break;
|
break;
|
||||||
}
|
}
|
||||||
@@ -6215,11 +6261,6 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords({
|
|
||||||
x: sceneX,
|
|
||||||
y: sceneY,
|
|
||||||
});
|
|
||||||
|
|
||||||
const textCreationGridPoint = this.getTextCreationGridPoint(sceneX, sceneY);
|
const textCreationGridPoint = this.getTextCreationGridPoint(sceneX, sceneY);
|
||||||
|
|
||||||
const newTextElementPosition = parentCenterPosition
|
const newTextElementPosition = parentCenterPosition
|
||||||
@@ -6241,6 +6282,20 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
y: sceneY,
|
y: sceneY,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const topLayerFrame = this.getTopLayerFrameAtSceneCoords({
|
||||||
|
x: newTextElementPosition.x,
|
||||||
|
y: newTextElementPosition.y,
|
||||||
|
});
|
||||||
|
|
||||||
|
// container has higher priority. Only add to frame if container is in the same frame.
|
||||||
|
const frameId =
|
||||||
|
topLayerFrame &&
|
||||||
|
(!shouldBindToContainer ||
|
||||||
|
!container ||
|
||||||
|
container.frameId === topLayerFrame.id)
|
||||||
|
? topLayerFrame.id
|
||||||
|
: null;
|
||||||
|
|
||||||
const element =
|
const element =
|
||||||
existingTextElement ||
|
existingTextElement ||
|
||||||
newTextElement({
|
newTextElement({
|
||||||
@@ -6270,7 +6325,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
? (0 as Radians)
|
? (0 as Radians)
|
||||||
: container.angle
|
: container.angle
|
||||||
: (0 as Radians),
|
: (0 as Radians),
|
||||||
frameId: topLayerFrame ? topLayerFrame.id : null,
|
frameId,
|
||||||
});
|
});
|
||||||
|
|
||||||
if (!existingTextElement && shouldBindToContainer && container) {
|
if (!existingTextElement && shouldBindToContainer && container) {
|
||||||
@@ -6286,9 +6341,12 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
if (!existingTextElement) {
|
if (!existingTextElement) {
|
||||||
if (container && shouldBindToContainer) {
|
if (container && shouldBindToContainer) {
|
||||||
const containerIndex = this.scene.getElementIndex(container.id);
|
const containerIndex = this.scene.getElementIndex(container.id);
|
||||||
this.scene.insertElementAtIndex(element, containerIndex + 1);
|
// TODO should use insertNewElement, after we update it to handle
|
||||||
|
// elements with containerId + frameId at the same time (containerId
|
||||||
|
// should take precedence when it comes to z-index)
|
||||||
|
this.scene.insertElementsAtIndex([element], containerIndex + 1);
|
||||||
} else {
|
} else {
|
||||||
this.scene.insertElement(element);
|
this.insertNewElement(element);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -6670,19 +6728,161 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
private getTopLayerFrameAtSceneCoords = (sceneCoords: {
|
/**
|
||||||
x: number;
|
* finds candidate frame under cursor (when dragging frame children/elements
|
||||||
y: number;
|
* inside frames)
|
||||||
}) => {
|
*/
|
||||||
|
private getTopLayerFrameAtSceneCoords = (
|
||||||
|
/**
|
||||||
|
* should be already grid aligned (basically should be what the call site
|
||||||
|
* sets the element's coords to, if applicable)
|
||||||
|
*/
|
||||||
|
sceneCoords: {
|
||||||
|
x: number;
|
||||||
|
y: number;
|
||||||
|
},
|
||||||
|
opts?: {
|
||||||
|
/** to exclude selected elements when dragging, etc. */
|
||||||
|
excludeElementIds?: AppState["selectedElementIds"];
|
||||||
|
currentFrameId?: ExcalidrawElement["frameId"];
|
||||||
|
},
|
||||||
|
) => {
|
||||||
const elementsMap = this.scene.getNonDeletedElementsMap();
|
const elementsMap = this.scene.getNonDeletedElementsMap();
|
||||||
const frames = this.scene
|
const framesUnderCursor = this.scene
|
||||||
.getNonDeletedFramesLikes()
|
.getNonDeletedFramesLikes()
|
||||||
.filter(
|
.filter(
|
||||||
(frame): frame is ExcalidrawFrameLikeElement =>
|
(frame): frame is ExcalidrawFrameLikeElement =>
|
||||||
!frame.locked && isCursorInFrame(sceneCoords, frame, elementsMap),
|
!frame.locked && isCursorInFrame(sceneCoords, frame, elementsMap),
|
||||||
);
|
);
|
||||||
|
|
||||||
return frames.length ? frames[frames.length - 1] : null;
|
if (!framesUnderCursor.length) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
const topLayerFrame = framesUnderCursor.at(-1)!;
|
||||||
|
|
||||||
|
const hitElement = this.getElementsAtPosition(
|
||||||
|
sceneCoords.x,
|
||||||
|
sceneCoords.y,
|
||||||
|
{
|
||||||
|
includeLockedElements: true,
|
||||||
|
},
|
||||||
|
).findLast((element) => !opts?.excludeElementIds?.[element.id]);
|
||||||
|
|
||||||
|
if (hitElement) {
|
||||||
|
if (
|
||||||
|
isFrameLikeElement(hitElement) &&
|
||||||
|
// case: we're hitting a locked frame itself (frame's outline
|
||||||
|
// or later its bg once implemented)
|
||||||
|
!hitElement.locked
|
||||||
|
) {
|
||||||
|
return topLayerFrame;
|
||||||
|
}
|
||||||
|
|
||||||
|
const hitElementIndex = this.scene.getElementIndex(hitElement.id);
|
||||||
|
const topLayerFrameIndex = this.scene.getElementIndex(topLayerFrame.id);
|
||||||
|
|
||||||
|
if (
|
||||||
|
hitElementIndex !== -1 &&
|
||||||
|
topLayerFrameIndex !== -1 &&
|
||||||
|
hitElementIndex <= topLayerFrameIndex
|
||||||
|
) {
|
||||||
|
return topLayerFrame;
|
||||||
|
}
|
||||||
|
|
||||||
|
// to support a case of dragging a pre-existing frame child underneath
|
||||||
|
// a non-frame element covering the cursor
|
||||||
|
const currentFrame = opts?.currentFrameId
|
||||||
|
? framesUnderCursor.find((frame) => frame.id === opts.currentFrameId) ??
|
||||||
|
null
|
||||||
|
: null;
|
||||||
|
|
||||||
|
if (currentFrame) {
|
||||||
|
return currentFrame;
|
||||||
|
}
|
||||||
|
|
||||||
|
return hitElement.frameId
|
||||||
|
? framesUnderCursor.find((frame) => frame.id === hitElement.frameId) ??
|
||||||
|
null
|
||||||
|
: null;
|
||||||
|
}
|
||||||
|
|
||||||
|
return topLayerFrame;
|
||||||
|
};
|
||||||
|
|
||||||
|
private updateFrameToHighlight = (
|
||||||
|
frameToHighlight: AppState["frameToHighlight"],
|
||||||
|
) => {
|
||||||
|
if (this.state.frameToHighlight !== frameToHighlight) {
|
||||||
|
this.setState({ frameToHighlight });
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
private maybeUpdateFrameToHighlightOnPointerMove = (
|
||||||
|
sceneCoords: { x: number; y: number },
|
||||||
|
isOverScrollBar: boolean,
|
||||||
|
) => {
|
||||||
|
// currently this function is being called even during pointerdown so we
|
||||||
|
// need to make sure we don't re-set the state when dragging and similar
|
||||||
|
//
|
||||||
|
// But, we still want to reset on pointermove in case the state is stale
|
||||||
|
// so we updte even for non-eligible tool types
|
||||||
|
if (
|
||||||
|
this.state.newElement ||
|
||||||
|
this.state.multiElement ||
|
||||||
|
this.state.selectionElement ||
|
||||||
|
this.state.selectedElementsAreBeingDragged
|
||||||
|
) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
this.updateFrameToHighlight(
|
||||||
|
!isOverScrollBar && isEligibleFrameChildType(this.state.activeTool.type)
|
||||||
|
? this.getTopLayerFrameAtSceneCoords(sceneCoords)
|
||||||
|
: null,
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|
||||||
|
private insertNewElements = (elements: readonly ExcalidrawElement[]) => {
|
||||||
|
if (!elements.length) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const chunkedElements: ExcalidrawElement[][] = [];
|
||||||
|
|
||||||
|
for (const element of elements) {
|
||||||
|
const currentChunk = chunkedElements[chunkedElements.length - 1];
|
||||||
|
|
||||||
|
if (currentChunk?.[0].frameId === element.frameId) {
|
||||||
|
currentChunk.push(element);
|
||||||
|
} else {
|
||||||
|
chunkedElements.push([element]);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
for (const chunk of chunkedElements) {
|
||||||
|
const frameId = chunk[0].frameId;
|
||||||
|
|
||||||
|
const insertionIndex = frameId
|
||||||
|
? getFrameChildrenInsertionIndex(
|
||||||
|
this.scene.getElementsIncludingDeleted(),
|
||||||
|
frameId,
|
||||||
|
)
|
||||||
|
: null;
|
||||||
|
this.scene.insertElementsAtIndex(chunk, insertionIndex);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
private insertNewElement = (element: ExcalidrawElement) => {
|
||||||
|
this.insertNewElements([element]);
|
||||||
|
|
||||||
|
const frame = element.frameId
|
||||||
|
? this.scene.getNonDeletedElement(element.frameId)
|
||||||
|
: null;
|
||||||
|
|
||||||
|
this.updateFrameToHighlight(
|
||||||
|
frame && isFrameLikeElement(frame) ? frame : null,
|
||||||
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
private handleCanvasPointerMove = (
|
private handleCanvasPointerMove = (
|
||||||
@@ -6784,6 +6984,14 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
this.maybeUpdateFrameToHighlightOnPointerMove(
|
||||||
|
{
|
||||||
|
x: scenePointerX,
|
||||||
|
y: scenePointerY,
|
||||||
|
},
|
||||||
|
isOverScrollBar,
|
||||||
|
);
|
||||||
|
|
||||||
if (
|
if (
|
||||||
!this.state.newElement &&
|
!this.state.newElement &&
|
||||||
isActiveToolNonLinearSnappable(this.state.activeTool.type)
|
isActiveToolNonLinearSnappable(this.state.activeTool.type)
|
||||||
@@ -6922,7 +7130,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
y: scenePointerY,
|
y: scenePointerY,
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
this.setState({ suggestedBinding: null, startBoundElement: null });
|
this.setState({ suggestedBinding: null });
|
||||||
if (!this.state.activeTool.locked) {
|
if (!this.state.activeTool.locked) {
|
||||||
resetCursor(this.interactiveCanvas);
|
resetCursor(this.interactiveCanvas);
|
||||||
this.setState((prevState) => ({
|
this.setState((prevState) => ({
|
||||||
@@ -7566,7 +7774,6 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
appState: {
|
appState: {
|
||||||
newElement: null,
|
newElement: null,
|
||||||
editingTextElement: null,
|
editingTextElement: null,
|
||||||
startBoundElement: null,
|
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
selectedElementIds: makeNextSelectedElementIds(
|
selectedElementIds: makeNextSelectedElementIds(
|
||||||
Object.keys(this.state.selectedElementIds)
|
Object.keys(this.state.selectedElementIds)
|
||||||
@@ -8839,7 +9046,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
pressures: [event.pressure],
|
pressures: [event.pressure],
|
||||||
});
|
});
|
||||||
|
|
||||||
this.scene.insertElement(element);
|
this.insertNewElement(element);
|
||||||
|
|
||||||
this.setState((prevState) => {
|
this.setState((prevState) => {
|
||||||
const nextSelectedElementIds = {
|
const nextSelectedElementIds = {
|
||||||
@@ -8854,18 +9061,8 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|
||||||
const boundElement = getHoveredElementForBinding(
|
|
||||||
pointFrom<GlobalPoint>(
|
|
||||||
pointerDownState.origin.x,
|
|
||||||
pointerDownState.origin.y,
|
|
||||||
),
|
|
||||||
this.scene.getNonDeletedElements(),
|
|
||||||
this.scene.getNonDeletedElementsMap(),
|
|
||||||
);
|
|
||||||
|
|
||||||
this.setState({
|
this.setState({
|
||||||
newElement: element,
|
newElement: element,
|
||||||
startBoundElement: boundElement,
|
|
||||||
suggestedBinding: null,
|
suggestedBinding: null,
|
||||||
});
|
});
|
||||||
};
|
};
|
||||||
@@ -8906,7 +9103,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
height,
|
height,
|
||||||
});
|
});
|
||||||
|
|
||||||
this.scene.insertElement(element);
|
this.insertNewElement(element);
|
||||||
|
|
||||||
return element;
|
return element;
|
||||||
};
|
};
|
||||||
@@ -8960,7 +9157,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
link,
|
link,
|
||||||
});
|
});
|
||||||
|
|
||||||
this.scene.insertElement(element);
|
this.insertNewElement(element);
|
||||||
|
|
||||||
return element;
|
return element;
|
||||||
};
|
};
|
||||||
@@ -9204,7 +9401,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
points: [pointFrom<LocalPoint>(0, 0), pointFrom<LocalPoint>(0, 0)],
|
points: [pointFrom<LocalPoint>(0, 0), pointFrom<LocalPoint>(0, 0)],
|
||||||
});
|
});
|
||||||
|
|
||||||
this.scene.insertElement(element);
|
this.insertNewElement(element);
|
||||||
|
|
||||||
if (isBindingElement(element)) {
|
if (isBindingElement(element)) {
|
||||||
// Do the initial binding so the binding strategy has the initial state
|
// Do the initial binding so the binding strategy has the initial state
|
||||||
@@ -9362,7 +9559,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
selectionElement: element,
|
selectionElement: element,
|
||||||
});
|
});
|
||||||
} else {
|
} else {
|
||||||
this.scene.insertElement(element);
|
this.insertNewElement(element);
|
||||||
this.setState({
|
this.setState({
|
||||||
multiElement: null,
|
multiElement: null,
|
||||||
newElement: element,
|
newElement: element,
|
||||||
@@ -9395,7 +9592,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
? newMagicFrameElement(constructorOpts)
|
? newMagicFrameElement(constructorOpts)
|
||||||
: newFrameElement(constructorOpts);
|
: newFrameElement(constructorOpts);
|
||||||
|
|
||||||
this.scene.insertElement(frame);
|
this.insertNewElement(frame);
|
||||||
|
|
||||||
this.setState({
|
this.setState({
|
||||||
multiElement: null,
|
multiElement: null,
|
||||||
@@ -9814,18 +10011,17 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
const selectedElementsHasAFrame = selectedElements.find((e) =>
|
const selectedElementsHasAFrame = selectedElements.some((e) =>
|
||||||
isFrameLikeElement(e),
|
isFrameLikeElement(e),
|
||||||
);
|
);
|
||||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(pointerCoords);
|
const frameToHighlight = selectedElementsHasAFrame
|
||||||
const frameToHighlight =
|
? null
|
||||||
topLayerFrame && !selectedElementsHasAFrame ? topLayerFrame : null;
|
: this.getTopLayerFrameAtSceneCoords(pointerCoords, {
|
||||||
|
currentFrameId: getCommonFrameId(selectedElements),
|
||||||
|
excludeElementIds: this.state.selectedElementIds,
|
||||||
|
});
|
||||||
// Only update the state if there is a difference
|
// Only update the state if there is a difference
|
||||||
if (this.state.frameToHighlight !== frameToHighlight) {
|
this.updateFrameToHighlight(frameToHighlight);
|
||||||
flushSync(() => {
|
|
||||||
this.setState({ frameToHighlight });
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
// Marking that click was used for dragging to check
|
// Marking that click was used for dragging to check
|
||||||
// if elements should be deselected on pointerup
|
// if elements should be deselected on pointerup
|
||||||
@@ -10336,20 +10532,38 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
);
|
);
|
||||||
|
|
||||||
let linearElementEditor = this.state.selectedLinearElement;
|
let linearElementEditor = this.state.selectedLinearElement;
|
||||||
if (!linearElementEditor) {
|
|
||||||
|
if (
|
||||||
|
!linearElementEditor ||
|
||||||
|
linearElementEditor.elementId !== newElement.id
|
||||||
|
) {
|
||||||
linearElementEditor = new LinearElementEditor(
|
linearElementEditor = new LinearElementEditor(
|
||||||
newElement,
|
newElement,
|
||||||
this.scene.getNonDeletedElementsMap(),
|
this.scene.getNonDeletedElementsMap(),
|
||||||
);
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
const lastClickedPointOutOfBounds =
|
||||||
|
linearElementEditor &&
|
||||||
|
(linearElementEditor.initialState.lastClickedPoint < 0 ||
|
||||||
|
linearElementEditor.initialState.lastClickedPoint >=
|
||||||
|
points.length);
|
||||||
|
if (lastClickedPointOutOfBounds) {
|
||||||
|
console.warn(
|
||||||
|
"Last clicked point is out of bounds. Attempting to fix it.",
|
||||||
|
);
|
||||||
linearElementEditor = {
|
linearElementEditor = {
|
||||||
...linearElementEditor,
|
...linearElementEditor,
|
||||||
selectedPointsIndices: [1],
|
selectedPointsIndices: [points.length - 1],
|
||||||
initialState: {
|
initialState: {
|
||||||
...linearElementEditor.initialState,
|
...linearElementEditor.initialState,
|
||||||
lastClickedPoint: 1,
|
prevSelectedPointsIndices: null,
|
||||||
|
lastClickedPoint: points.length - 1,
|
||||||
},
|
},
|
||||||
|
hoverPointIndex: points.length - 1,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
this.setState({
|
this.setState({
|
||||||
newElement,
|
newElement,
|
||||||
...LinearElementEditor.handlePointDragging(
|
...LinearElementEditor.handlePointDragging(
|
||||||
@@ -10858,7 +11072,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
sceneCoords,
|
sceneCoords,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
this.setState({ suggestedBinding: null, startBoundElement: null });
|
this.setState({ suggestedBinding: null });
|
||||||
if (!activeTool.locked) {
|
if (!activeTool.locked) {
|
||||||
resetCursor(this.interactiveCanvas);
|
resetCursor(this.interactiveCanvas);
|
||||||
this.setState((prevState) => ({
|
this.setState((prevState) => ({
|
||||||
@@ -10879,9 +11093,9 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
),
|
),
|
||||||
}));
|
}));
|
||||||
} else {
|
} else {
|
||||||
this.setState((prevState) => ({
|
this.setState({
|
||||||
newElement: null,
|
newElement: null,
|
||||||
}));
|
});
|
||||||
}
|
}
|
||||||
// so that the scene gets rendered again to display the newly drawn linear as well
|
// so that the scene gets rendered again to display the newly drawn linear as well
|
||||||
this.scene.triggerUpdate();
|
this.scene.triggerUpdate();
|
||||||
@@ -10943,7 +11157,6 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
this.scene.getElementsMapIncludingDeleted(),
|
this.scene.getElementsMapIncludingDeleted(),
|
||||||
elementsInsideFrame,
|
elementsInsideFrame,
|
||||||
newElement,
|
newElement,
|
||||||
this.state,
|
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -11003,9 +11216,14 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
// update the relationships between selected elements and frames
|
// update the relationships between selected elements and frames
|
||||||
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(sceneCoords);
|
|
||||||
|
|
||||||
const selectedElements = this.scene.getSelectedElements(this.state);
|
const selectedElements = this.scene.getSelectedElements(this.state);
|
||||||
|
const topLayerFrame = this.getTopLayerFrameAtSceneCoords(
|
||||||
|
sceneCoords,
|
||||||
|
{
|
||||||
|
currentFrameId: getCommonFrameId(selectedElements),
|
||||||
|
excludeElementIds: this.state.selectedElementIds,
|
||||||
|
},
|
||||||
|
);
|
||||||
let nextElements = this.scene.getElementsMapIncludingDeleted();
|
let nextElements = this.scene.getElementsMapIncludingDeleted();
|
||||||
|
|
||||||
const updateGroupIdsAfterEditingGroup = (
|
const updateGroupIdsAfterEditingGroup = (
|
||||||
@@ -11054,10 +11272,8 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
topLayerFrame &&
|
topLayerFrame &&
|
||||||
!this.state.selectedElementIds[topLayerFrame.id]
|
!this.state.selectedElementIds[topLayerFrame.id]
|
||||||
) {
|
) {
|
||||||
const elementsToAdd = selectedElements.filter(
|
const elementsToAdd = selectedElements.filter((element) =>
|
||||||
(element) =>
|
isElementInFrame(element, nextElements, this.state),
|
||||||
element.frameId !== topLayerFrame.id &&
|
|
||||||
isElementInFrame(element, nextElements, this.state),
|
|
||||||
);
|
);
|
||||||
|
|
||||||
if (this.state.editingGroupId) {
|
if (this.state.editingGroupId) {
|
||||||
@@ -11068,7 +11284,6 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
nextElements,
|
nextElements,
|
||||||
elementsToAdd,
|
elementsToAdd,
|
||||||
topLayerFrame,
|
topLayerFrame,
|
||||||
this.state,
|
|
||||||
);
|
);
|
||||||
} else if (!topLayerFrame) {
|
} else if (!topLayerFrame) {
|
||||||
if (this.state.editingGroupId) {
|
if (this.state.editingGroupId) {
|
||||||
@@ -11130,7 +11345,6 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
elementsMap,
|
elementsMap,
|
||||||
),
|
),
|
||||||
frame,
|
frame,
|
||||||
this,
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -11645,9 +11859,11 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
|
|
||||||
const existingFileData = this.files[fileId];
|
const existingFileData = this.files[fileId];
|
||||||
if (!existingFileData?.dataURL) {
|
if (!existingFileData?.dataURL) {
|
||||||
|
const { maxWidthOrHeight, maxFileSizeBytes } = this.props.imageOptions;
|
||||||
|
|
||||||
try {
|
try {
|
||||||
imageFile = await resizeImageFile(imageFile, {
|
imageFile = await resizeImageFile(imageFile, {
|
||||||
maxWidthOrHeight: DEFAULT_MAX_IMAGE_WIDTH_OR_HEIGHT,
|
maxWidthOrHeight,
|
||||||
});
|
});
|
||||||
} catch (error: any) {
|
} catch (error: any) {
|
||||||
console.error(
|
console.error(
|
||||||
@@ -11656,10 +11872,10 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (imageFile.size > MAX_ALLOWED_FILE_BYTES) {
|
if (imageFile.size > maxFileSizeBytes) {
|
||||||
throw new Error(
|
throw new Error(
|
||||||
t("errors.fileTooBig", {
|
t("errors.fileTooBig", {
|
||||||
maxSize: `${Math.trunc(MAX_ALLOWED_FILE_BYTES / 1024 / 1024)}MB`,
|
maxSize: `${Math.trunc(maxFileSizeBytes / 1024 / 1024)}MB`,
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -11946,7 +12162,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
sceneY,
|
sceneY,
|
||||||
gridPadding,
|
gridPadding,
|
||||||
);
|
);
|
||||||
placeholders.forEach((el) => this.scene.insertElement(el));
|
this.insertNewElements(placeholders);
|
||||||
|
|
||||||
// Create, position, insert and select initialized (replacing placeholders)
|
// Create, position, insert and select initialized (replacing placeholders)
|
||||||
const initialized = await Promise.all(
|
const initialized = await Promise.all(
|
||||||
@@ -12074,6 +12290,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||||||
type: "everything",
|
type: "everything",
|
||||||
elements: item.elements,
|
elements: item.elements,
|
||||||
randomizeSeed: true,
|
randomizeSeed: true,
|
||||||
|
preserveFrameChildrenOrder: true,
|
||||||
}).duplicatedElements,
|
}).duplicatedElements,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
|||||||
@@ -650,8 +650,7 @@ const LayerUI = ({
|
|||||||
};
|
};
|
||||||
|
|
||||||
const stripIrrelevantAppStateProps = (appState: AppState): UIAppState => {
|
const stripIrrelevantAppStateProps = (appState: AppState): UIAppState => {
|
||||||
const { startBoundElement, cursorButton, scrollX, scrollY, ...ret } =
|
const { cursorButton, scrollX, scrollY, ...ret } = appState;
|
||||||
appState;
|
|
||||||
return ret;
|
return ret;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@@ -199,6 +199,7 @@ export default function LibraryMenuItems({
|
|||||||
type: "everything",
|
type: "everything",
|
||||||
elements: item.elements,
|
elements: item.elements,
|
||||||
randomizeSeed: true,
|
randomizeSeed: true,
|
||||||
|
preserveFrameChildrenOrder: true,
|
||||||
}).duplicatedElements,
|
}).duplicatedElements,
|
||||||
};
|
};
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -206,7 +206,6 @@ const handleDimensionChange: DragInputCallbackType<
|
|||||||
scene.getElementsIncludingDeleted(),
|
scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
scene.replaceAllElements(updatedElements);
|
scene.replaceAllElements(updatedElements);
|
||||||
@@ -302,7 +301,6 @@ const handleDragFinished: DragFinishedCallbackType = ({
|
|||||||
app.scene.getElementsIncludingDeleted(),
|
app.scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
app.scene.replaceAllElements(updatedElements);
|
app.scene.replaceAllElements(updatedElements);
|
||||||
|
|||||||
@@ -261,7 +261,6 @@ const handleDimensionChange: DragInputCallbackType<
|
|||||||
scene.getElementsIncludingDeleted(),
|
scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
scene.replaceAllElements(updatedElements);
|
scene.replaceAllElements(updatedElements);
|
||||||
@@ -416,7 +415,6 @@ const handleDragFinished: DragFinishedCallbackType = ({
|
|||||||
app.scene.getElementsIncludingDeleted(),
|
app.scene.getElementsIncludingDeleted(),
|
||||||
nextElementsInFrame,
|
nextElementsInFrame,
|
||||||
latestElement,
|
latestElement,
|
||||||
app,
|
|
||||||
);
|
);
|
||||||
|
|
||||||
app.scene.replaceAllElements(updatedElements);
|
app.scene.replaceAllElements(updatedElements);
|
||||||
|
|||||||
@@ -39,7 +39,7 @@ type InteractiveCanvasProps = {
|
|||||||
visibleElements: readonly NonDeletedExcalidrawElement[];
|
visibleElements: readonly NonDeletedExcalidrawElement[];
|
||||||
selectedElements: readonly NonDeletedExcalidrawElement[];
|
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||||
allElementsMap: NonDeletedSceneElementsMap;
|
allElementsMap: NonDeletedSceneElementsMap;
|
||||||
sceneNonce: number | undefined;
|
canvasNonce: string;
|
||||||
selectionNonce: number | undefined;
|
selectionNonce: number | undefined;
|
||||||
scale: number;
|
scale: number;
|
||||||
appState: InteractiveCanvasAppState;
|
appState: InteractiveCanvasAppState;
|
||||||
@@ -279,10 +279,10 @@ const areEqual = (
|
|||||||
// This could be further optimised if needed, as we don't have to render interactive canvas on each scene mutation
|
// This could be further optimised if needed, as we don't have to render interactive canvas on each scene mutation
|
||||||
if (
|
if (
|
||||||
prevProps.selectionNonce !== nextProps.selectionNonce ||
|
prevProps.selectionNonce !== nextProps.selectionNonce ||
|
||||||
prevProps.sceneNonce !== nextProps.sceneNonce ||
|
prevProps.canvasNonce !== nextProps.canvasNonce ||
|
||||||
prevProps.scale !== nextProps.scale ||
|
prevProps.scale !== nextProps.scale ||
|
||||||
// we need to memoize on elementsMap because they may have renewed
|
// we need to memoize on elementsMap because they may have renewed
|
||||||
// even if sceneNonce didn't change (e.g. we filter elements out based
|
// even if canvasNonce didn't change (e.g. we filter elements out based
|
||||||
// on appState)
|
// on appState)
|
||||||
prevProps.elementsMap !== nextProps.elementsMap ||
|
prevProps.elementsMap !== nextProps.elementsMap ||
|
||||||
prevProps.visibleElements !== nextProps.visibleElements ||
|
prevProps.visibleElements !== nextProps.visibleElements ||
|
||||||
|
|||||||
@@ -14,6 +14,7 @@ import type { RoughCanvas } from "roughjs/bin/canvas";
|
|||||||
|
|
||||||
interface NewElementCanvasProps {
|
interface NewElementCanvasProps {
|
||||||
appState: AppState;
|
appState: AppState;
|
||||||
|
newElement: NonNullable<AppState["newElement"]>;
|
||||||
elementsMap: RenderableElementsMap;
|
elementsMap: RenderableElementsMap;
|
||||||
allElementsMap: NonDeletedSceneElementsMap;
|
allElementsMap: NonDeletedSceneElementsMap;
|
||||||
scale: number;
|
scale: number;
|
||||||
@@ -31,7 +32,7 @@ const NewElementCanvas = (props: NewElementCanvasProps) => {
|
|||||||
{
|
{
|
||||||
canvas: canvasRef.current,
|
canvas: canvasRef.current,
|
||||||
scale: props.scale,
|
scale: props.scale,
|
||||||
newElement: props.appState.newElement,
|
newElement: props.newElement,
|
||||||
elementsMap: props.elementsMap,
|
elementsMap: props.elementsMap,
|
||||||
allElementsMap: props.allElementsMap,
|
allElementsMap: props.allElementsMap,
|
||||||
rc: props.rc,
|
rc: props.rc,
|
||||||
|
|||||||
@@ -23,7 +23,7 @@ type StaticCanvasProps = {
|
|||||||
elementsMap: RenderableElementsMap;
|
elementsMap: RenderableElementsMap;
|
||||||
allElementsMap: NonDeletedSceneElementsMap;
|
allElementsMap: NonDeletedSceneElementsMap;
|
||||||
visibleElements: readonly NonDeletedExcalidrawElement[];
|
visibleElements: readonly NonDeletedExcalidrawElement[];
|
||||||
sceneNonce: number | undefined;
|
canvasNonce: string;
|
||||||
selectionNonce: number | undefined;
|
selectionNonce: number | undefined;
|
||||||
scale: number;
|
scale: number;
|
||||||
appState: StaticCanvasAppState;
|
appState: StaticCanvasAppState;
|
||||||
@@ -110,10 +110,10 @@ const areEqual = (
|
|||||||
nextProps: StaticCanvasProps,
|
nextProps: StaticCanvasProps,
|
||||||
) => {
|
) => {
|
||||||
if (
|
if (
|
||||||
prevProps.sceneNonce !== nextProps.sceneNonce ||
|
prevProps.canvasNonce !== nextProps.canvasNonce ||
|
||||||
prevProps.scale !== nextProps.scale ||
|
prevProps.scale !== nextProps.scale ||
|
||||||
// we need to memoize on elementsMap because they may have renewed
|
// we need to memoize on elementsMap because they may have renewed
|
||||||
// even if sceneNonce didn't change (e.g. we filter elements out based
|
// even if canvasNonce didn't change (e.g. we filter elements out based
|
||||||
// on appState)
|
// on appState)
|
||||||
prevProps.elementsMap !== nextProps.elementsMap ||
|
prevProps.elementsMap !== nextProps.elementsMap ||
|
||||||
prevProps.visibleElements !== nextProps.visibleElements
|
prevProps.visibleElements !== nextProps.visibleElements
|
||||||
|
|||||||
@@ -119,15 +119,12 @@ export const SHAPES = [
|
|||||||
export const getToolbarTools = (app: AppClassProperties) => {
|
export const getToolbarTools = (app: AppClassProperties) => {
|
||||||
return app.state.preferredSelectionTool.type === "lasso"
|
return app.state.preferredSelectionTool.type === "lasso"
|
||||||
? ([
|
? ([
|
||||||
|
SHAPES[0],
|
||||||
{
|
{
|
||||||
|
...SHAPES[1],
|
||||||
value: "lasso",
|
value: "lasso",
|
||||||
icon: SelectionIcon,
|
|
||||||
key: KEYS.V,
|
|
||||||
numericKey: KEYS["1"],
|
|
||||||
fillable: true,
|
|
||||||
toolbar: true,
|
|
||||||
},
|
},
|
||||||
...SHAPES.slice(1),
|
...SHAPES.slice(2),
|
||||||
] as const)
|
] as const)
|
||||||
: SHAPES;
|
: SHAPES;
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -814,6 +814,14 @@ body.excalidraw-cursor-resize * {
|
|||||||
.excalidraw__embeddable__outer {
|
.excalidraw__embeddable__outer {
|
||||||
width: 100%;
|
width: 100%;
|
||||||
height: 100%;
|
height: 100%;
|
||||||
|
}
|
||||||
|
|
||||||
|
.excalidraw__embeddable__content {
|
||||||
|
width: 100%;
|
||||||
|
height: 100%;
|
||||||
|
transform-origin: top left;
|
||||||
|
|
||||||
|
&,
|
||||||
& > * {
|
& > * {
|
||||||
border-radius: var(--embeddable-radius);
|
border-radius: var(--embeddable-radius);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -311,6 +311,48 @@ export const dataURLToString = (dataURL: DataURL) => {
|
|||||||
return base64ToString(dataURL.slice(dataURL.indexOf(",") + 1));
|
return base64ToString(dataURL.slice(dataURL.indexOf(",") + 1));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const getImageFileDimensions = async (file: File) => {
|
||||||
|
const browserURL = typeof window !== "undefined" ? window.URL : undefined;
|
||||||
|
let objectURL: string | null = null;
|
||||||
|
let imageSource: string;
|
||||||
|
|
||||||
|
try {
|
||||||
|
imageSource = browserURL?.createObjectURL
|
||||||
|
? (objectURL = browserURL.createObjectURL(file))
|
||||||
|
: await getDataURL(file);
|
||||||
|
} catch {
|
||||||
|
objectURL = null;
|
||||||
|
imageSource = await getDataURL(file);
|
||||||
|
}
|
||||||
|
|
||||||
|
return new Promise<{ width: number; height: number }>((resolve, reject) => {
|
||||||
|
const image = new Image();
|
||||||
|
|
||||||
|
const cleanup = () => {
|
||||||
|
image.onload = null;
|
||||||
|
image.onerror = null;
|
||||||
|
|
||||||
|
if (objectURL && browserURL?.revokeObjectURL) {
|
||||||
|
browserURL.revokeObjectURL(objectURL);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
image.onload = () => {
|
||||||
|
cleanup();
|
||||||
|
resolve({
|
||||||
|
width: image.naturalWidth || image.width,
|
||||||
|
height: image.naturalHeight || image.height,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
image.onerror = (error) => {
|
||||||
|
cleanup();
|
||||||
|
reject(error);
|
||||||
|
};
|
||||||
|
|
||||||
|
image.src = imageSource;
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
export const resizeImageFile = async (
|
export const resizeImageFile = async (
|
||||||
file: File,
|
file: File,
|
||||||
opts: {
|
opts: {
|
||||||
@@ -324,6 +366,20 @@ export const resizeImageFile = async (
|
|||||||
return file;
|
return file;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!isSupportedImageFile(file)) {
|
||||||
|
throw new Error("Error: unsupported file type", { cause: "UNSUPPORTED" });
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!opts.outputType || opts.outputType === file.type) {
|
||||||
|
const dimensions = await getImageFileDimensions(file);
|
||||||
|
|
||||||
|
if (
|
||||||
|
Math.max(dimensions.width, dimensions.height) <= opts.maxWidthOrHeight
|
||||||
|
) {
|
||||||
|
return file;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
const [pica, imageBlobReduce] = await Promise.all([
|
const [pica, imageBlobReduce] = await Promise.all([
|
||||||
import("pica").then((res) => res.default),
|
import("pica").then((res) => res.default),
|
||||||
// a wrapper for pica for better API
|
// a wrapper for pica for better API
|
||||||
@@ -347,10 +403,6 @@ export const resizeImageFile = async (
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!isSupportedImageFile(file)) {
|
|
||||||
throw new Error("Error: unsupported file type", { cause: "UNSUPPORTED" });
|
|
||||||
}
|
|
||||||
|
|
||||||
return new File(
|
return new File(
|
||||||
[await reduce.toBlob(file, { max: opts.maxWidthOrHeight, alpha: true })],
|
[await reduce.toBlob(file, { max: opts.maxWidthOrHeight, alpha: true })],
|
||||||
file.name,
|
file.name,
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { isFiniteNumber, pointFrom } from "@excalidraw/math";
|
import { isFiniteNumber, isValidPoint, pointFrom } from "@excalidraw/math";
|
||||||
|
|
||||||
import {
|
import {
|
||||||
type CombineBrandsIfNeeded,
|
type CombineBrandsIfNeeded,
|
||||||
@@ -96,6 +96,69 @@ type RestoredAppState = Omit<
|
|||||||
"offsetTop" | "offsetLeft" | "width" | "height"
|
"offsetTop" | "offsetLeft" | "width" | "height"
|
||||||
>;
|
>;
|
||||||
|
|
||||||
|
const MAX_ARROW_PX = 75_000;
|
||||||
|
|
||||||
|
const restoreLinearElementPoints = (
|
||||||
|
points: unknown,
|
||||||
|
width: unknown,
|
||||||
|
height: unknown,
|
||||||
|
): LocalPoint[] => {
|
||||||
|
const restoredPoints = Array.isArray(points)
|
||||||
|
? points.reduce<LocalPoint[]>((acc, point) => {
|
||||||
|
if (isValidPoint(point)) {
|
||||||
|
acc.push(pointFrom<LocalPoint>(point[0], point[1]));
|
||||||
|
}
|
||||||
|
return acc;
|
||||||
|
}, [])
|
||||||
|
: [];
|
||||||
|
|
||||||
|
return restoredPoints.length < 2
|
||||||
|
? [
|
||||||
|
pointFrom<LocalPoint>(0, 0),
|
||||||
|
pointFrom<LocalPoint>(
|
||||||
|
isFiniteNumber(width) ? width : 0,
|
||||||
|
isFiniteNumber(height) ? height : 0,
|
||||||
|
),
|
||||||
|
]
|
||||||
|
: restoredPoints;
|
||||||
|
};
|
||||||
|
|
||||||
|
const restoreFreedrawPoints = (
|
||||||
|
points: unknown,
|
||||||
|
pressures: unknown,
|
||||||
|
): {
|
||||||
|
points: LocalPoint[];
|
||||||
|
pressures: number[];
|
||||||
|
} => {
|
||||||
|
if (!Array.isArray(points)) {
|
||||||
|
return {
|
||||||
|
points: [],
|
||||||
|
pressures: [],
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
const pressureValues: readonly unknown[] = Array.isArray(pressures)
|
||||||
|
? pressures
|
||||||
|
: [];
|
||||||
|
const restoredPoints: LocalPoint[] = [];
|
||||||
|
const restoredPressures: number[] = [];
|
||||||
|
|
||||||
|
points.forEach((point, index) => {
|
||||||
|
if (isValidPoint(point)) {
|
||||||
|
restoredPoints.push(pointFrom<LocalPoint>(point[0], point[1]));
|
||||||
|
if (index in pressureValues) {
|
||||||
|
const pressure = pressureValues[index];
|
||||||
|
restoredPressures.push(isFiniteNumber(pressure) ? pressure : 0.5);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
return {
|
||||||
|
points: restoredPoints,
|
||||||
|
pressures: restoredPressures,
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
export const AllowedExcalidrawActiveTools: Record<
|
export const AllowedExcalidrawActiveTools: Record<
|
||||||
AppState["activeTool"]["type"],
|
AppState["activeTool"]["type"],
|
||||||
boolean
|
boolean
|
||||||
@@ -412,10 +475,15 @@ export const restoreElement = (
|
|||||||
|
|
||||||
return element;
|
return element;
|
||||||
case "freedraw": {
|
case "freedraw": {
|
||||||
|
const { points, pressures } = restoreFreedrawPoints(
|
||||||
|
element.points,
|
||||||
|
element.pressures,
|
||||||
|
);
|
||||||
|
|
||||||
return restoreElementWithProperties(element, {
|
return restoreElementWithProperties(element, {
|
||||||
points: element.points,
|
points,
|
||||||
simulatePressure: element.simulatePressure,
|
simulatePressure: element.simulatePressure,
|
||||||
pressures: element.pressures,
|
pressures,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
case "image":
|
case "image":
|
||||||
@@ -433,14 +501,20 @@ export const restoreElement = (
|
|||||||
const endArrowhead = normalizeArrowhead(element.endArrowhead);
|
const endArrowhead = normalizeArrowhead(element.endArrowhead);
|
||||||
let x = element.x;
|
let x = element.x;
|
||||||
let y = element.y;
|
let y = element.y;
|
||||||
let points = // migrate old arrow model to new one
|
let points = restoreLinearElementPoints(
|
||||||
!Array.isArray(element.points) || element.points.length < 2
|
element.points,
|
||||||
? [pointFrom(0, 0), pointFrom(element.width, element.height)]
|
element.width,
|
||||||
: element.points;
|
element.height,
|
||||||
|
);
|
||||||
|
|
||||||
if (points[0][0] !== 0 || points[0][1] !== 0) {
|
if (points[0][0] !== 0 || points[0][1] !== 0) {
|
||||||
({ points, x, y } =
|
({ points, x, y } =
|
||||||
LinearElementEditor.getNormalizeElementPointsAndCoords(element));
|
LinearElementEditor.getNormalizeElementPointsAndCoords({
|
||||||
|
...element,
|
||||||
|
points,
|
||||||
|
x: x ?? 0,
|
||||||
|
y: y ?? 0,
|
||||||
|
} as ExcalidrawLinearElement));
|
||||||
}
|
}
|
||||||
|
|
||||||
return restoreElementWithProperties(element, {
|
return restoreElementWithProperties(element, {
|
||||||
@@ -454,7 +528,7 @@ export const restoreElement = (
|
|||||||
y,
|
y,
|
||||||
...(isLineElement(element)
|
...(isLineElement(element)
|
||||||
? {
|
? {
|
||||||
polygon: isValidPolygon(element.points)
|
polygon: isValidPolygon(points)
|
||||||
? element.polygon ?? false
|
? element.polygon ?? false
|
||||||
: false,
|
: false,
|
||||||
}
|
}
|
||||||
@@ -467,24 +541,31 @@ export const restoreElement = (
|
|||||||
element.endArrowhead === undefined
|
element.endArrowhead === undefined
|
||||||
? "arrow"
|
? "arrow"
|
||||||
: normalizeArrowhead(element.endArrowhead);
|
: normalizeArrowhead(element.endArrowhead);
|
||||||
const x: number | undefined = element.x;
|
const x = element.x as number | undefined;
|
||||||
const y: number | undefined = element.y;
|
const y = element.y as number | undefined;
|
||||||
const points: readonly LocalPoint[] | undefined = // migrate old arrow model to new one
|
const points = restoreLinearElementPoints(
|
||||||
!Array.isArray(element.points) || element.points.length < 2
|
element.points,
|
||||||
? [pointFrom(0, 0), pointFrom(element.width, element.height)]
|
element.width,
|
||||||
: element.points;
|
element.height,
|
||||||
|
);
|
||||||
|
const elementWithRestoredPoints = {
|
||||||
|
...element,
|
||||||
|
points,
|
||||||
|
x: x ?? 0,
|
||||||
|
y: y ?? 0,
|
||||||
|
} as ExcalidrawArrowElement;
|
||||||
|
|
||||||
const base = {
|
const base = {
|
||||||
type: element.type,
|
type: element.type,
|
||||||
startBinding: repairBinding(
|
startBinding: repairBinding(
|
||||||
element as ExcalidrawArrowElement,
|
elementWithRestoredPoints,
|
||||||
element.startBinding,
|
element.startBinding,
|
||||||
targetElementsMap,
|
targetElementsMap,
|
||||||
existingElementsMap,
|
existingElementsMap,
|
||||||
"start",
|
"start",
|
||||||
),
|
),
|
||||||
endBinding: repairBinding(
|
endBinding: repairBinding(
|
||||||
element as ExcalidrawArrowElement,
|
elementWithRestoredPoints,
|
||||||
element.endBinding,
|
element.endBinding,
|
||||||
targetElementsMap,
|
targetElementsMap,
|
||||||
existingElementsMap,
|
existingElementsMap,
|
||||||
@@ -493,8 +574,8 @@ export const restoreElement = (
|
|||||||
startArrowhead,
|
startArrowhead,
|
||||||
endArrowhead,
|
endArrowhead,
|
||||||
points,
|
points,
|
||||||
x,
|
x: x ?? 0,
|
||||||
y,
|
y: y ?? 0,
|
||||||
elbowed: (element as ExcalidrawArrowElement).elbowed,
|
elbowed: (element as ExcalidrawArrowElement).elbowed,
|
||||||
...getSizeFromPoints(points),
|
...getSizeFromPoints(points),
|
||||||
};
|
};
|
||||||
@@ -513,12 +594,44 @@ export const restoreElement = (
|
|||||||
})
|
})
|
||||||
: restoreElementWithProperties(element as ExcalidrawArrowElement, base);
|
: restoreElementWithProperties(element as ExcalidrawArrowElement, base);
|
||||||
|
|
||||||
return {
|
const normalizedRestoredElement = {
|
||||||
...restoredElement,
|
...restoredElement,
|
||||||
...LinearElementEditor.getNormalizeElementPointsAndCoords(
|
...LinearElementEditor.getNormalizeElementPointsAndCoords(
|
||||||
restoredElement,
|
restoredElement,
|
||||||
),
|
),
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Last resort fix for extremely large arrows
|
||||||
|
if (
|
||||||
|
normalizedRestoredElement.width > MAX_ARROW_PX ||
|
||||||
|
normalizedRestoredElement.height > MAX_ARROW_PX
|
||||||
|
) {
|
||||||
|
console.error(
|
||||||
|
`Removing extremely large arrow ${
|
||||||
|
normalizedRestoredElement.id
|
||||||
|
} (type: ${
|
||||||
|
isElbowArrow(normalizedRestoredElement) ? "elbow" : "simple"
|
||||||
|
}, width: ${normalizedRestoredElement.width}, height: ${
|
||||||
|
normalizedRestoredElement.height
|
||||||
|
}, x: ${normalizedRestoredElement.x}, y: ${
|
||||||
|
normalizedRestoredElement.y
|
||||||
|
})`,
|
||||||
|
);
|
||||||
|
return {
|
||||||
|
...normalizedRestoredElement,
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 100,
|
||||||
|
height: 100,
|
||||||
|
points: [
|
||||||
|
pointFrom<LocalPoint>(0, 0),
|
||||||
|
pointFrom<LocalPoint>(100, 100),
|
||||||
|
],
|
||||||
|
isDeleted: true,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
return normalizedRestoredElement;
|
||||||
}
|
}
|
||||||
|
|
||||||
// generic elements
|
// generic elements
|
||||||
@@ -666,6 +779,7 @@ export const restoreElements = <T extends ExcalidrawElement>(
|
|||||||
const existingElementsMap = existingElements
|
const existingElementsMap = existingElements
|
||||||
? arrayToMap(existingElements)
|
? arrayToMap(existingElements)
|
||||||
: null;
|
: null;
|
||||||
|
|
||||||
const restoredElements = syncInvalidIndices(
|
const restoredElements = syncInvalidIndices(
|
||||||
(targetElements || []).reduce((elements, element) => {
|
(targetElements || []).reduce((elements, element) => {
|
||||||
// filtering out selection, which is legacy, no longer kept in elements,
|
// filtering out selection, which is legacy, no longer kept in elements,
|
||||||
@@ -762,7 +876,7 @@ export const restoreElements = <T extends ExcalidrawElement>(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// NOTE (mtolmacs): Temporary fix for extremely large arrows
|
// NOTE (mtolmacs): Temporary fix for invalid/self-bound elbow arrows
|
||||||
// Need to iterate again so we have attached text nodes in elementsMap
|
// Need to iterate again so we have attached text nodes in elementsMap
|
||||||
return restoredElements.map((element) => {
|
return restoredElements.map((element) => {
|
||||||
if (
|
if (
|
||||||
|
|||||||
@@ -6,7 +6,11 @@ import React, {
|
|||||||
useState,
|
useState,
|
||||||
} from "react";
|
} from "react";
|
||||||
|
|
||||||
import { DEFAULT_UI_OPTIONS, isShallowEqual } from "@excalidraw/common";
|
import {
|
||||||
|
DEFAULT_IMAGE_OPTIONS,
|
||||||
|
DEFAULT_UI_OPTIONS,
|
||||||
|
isShallowEqual,
|
||||||
|
} from "@excalidraw/common";
|
||||||
|
|
||||||
import App, {
|
import App, {
|
||||||
ExcalidrawAPIContext,
|
ExcalidrawAPIContext,
|
||||||
@@ -98,6 +102,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
aiEnabled,
|
aiEnabled,
|
||||||
showDeprecatedFonts,
|
showDeprecatedFonts,
|
||||||
renderScrollbars,
|
renderScrollbars,
|
||||||
|
imageOptions,
|
||||||
} = props;
|
} = props;
|
||||||
|
|
||||||
const canvasActions = props.UIOptions?.canvasActions;
|
const canvasActions = props.UIOptions?.canvasActions;
|
||||||
@@ -128,6 +133,13 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
UIOptions.canvasActions.toggleTheme = true;
|
UIOptions.canvasActions.toggleTheme = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const normalizedImageOptions: AppProps["imageOptions"] = {
|
||||||
|
maxFileSizeBytes:
|
||||||
|
imageOptions?.maxFileSizeBytes ?? DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes,
|
||||||
|
maxWidthOrHeight:
|
||||||
|
imageOptions?.maxWidthOrHeight ?? DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight,
|
||||||
|
};
|
||||||
|
|
||||||
const setExcalidrawAPI = useContext(ExcalidrawAPISetContext);
|
const setExcalidrawAPI = useContext(ExcalidrawAPISetContext);
|
||||||
|
|
||||||
const onExcalidrawAPIRef = useRef(onExcalidrawAPI);
|
const onExcalidrawAPIRef = useRef(onExcalidrawAPI);
|
||||||
@@ -208,6 +220,7 @@ const ExcalidrawBase = (props: ExcalidrawProps) => {
|
|||||||
aiEnabled={aiEnabled !== false}
|
aiEnabled={aiEnabled !== false}
|
||||||
showDeprecatedFonts={showDeprecatedFonts}
|
showDeprecatedFonts={showDeprecatedFonts}
|
||||||
renderScrollbars={renderScrollbars}
|
renderScrollbars={renderScrollbars}
|
||||||
|
imageOptions={normalizedImageOptions}
|
||||||
>
|
>
|
||||||
{children}
|
{children}
|
||||||
</App>
|
</App>
|
||||||
@@ -225,11 +238,13 @@ const areEqual = (prevProps: ExcalidrawProps, nextProps: ExcalidrawProps) => {
|
|||||||
const {
|
const {
|
||||||
initialData: prevInitialData,
|
initialData: prevInitialData,
|
||||||
UIOptions: prevUIOptions = {},
|
UIOptions: prevUIOptions = {},
|
||||||
|
imageOptions: prevImageOptions,
|
||||||
...prev
|
...prev
|
||||||
} = prevProps;
|
} = prevProps;
|
||||||
const {
|
const {
|
||||||
initialData: nextInitialData,
|
initialData: nextInitialData,
|
||||||
UIOptions: nextUIOptions = {},
|
UIOptions: nextUIOptions = {},
|
||||||
|
imageOptions: nextImageOptions,
|
||||||
...next
|
...next
|
||||||
} = nextProps;
|
} = nextProps;
|
||||||
|
|
||||||
@@ -273,7 +288,17 @@ const areEqual = (prevProps: ExcalidrawProps, nextProps: ExcalidrawProps) => {
|
|||||||
return prevUIOptions[key] === nextUIOptions[key];
|
return prevUIOptions[key] === nextUIOptions[key];
|
||||||
});
|
});
|
||||||
|
|
||||||
return isUIOptionsSame && isShallowEqual(prev, next);
|
const isImageOptionsSame =
|
||||||
|
(prevImageOptions?.maxWidthOrHeight ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight) ===
|
||||||
|
(nextImageOptions?.maxWidthOrHeight ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxWidthOrHeight) &&
|
||||||
|
(prevImageOptions?.maxFileSizeBytes ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes) ===
|
||||||
|
(nextImageOptions?.maxFileSizeBytes ??
|
||||||
|
DEFAULT_IMAGE_OPTIONS.maxFileSizeBytes);
|
||||||
|
|
||||||
|
return isUIOptionsSame && isImageOptionsSame && isShallowEqual(prev, next);
|
||||||
};
|
};
|
||||||
|
|
||||||
export const Excalidraw = React.memo(ExcalidrawBase, areEqual);
|
export const Excalidraw = React.memo(ExcalidrawBase, areEqual);
|
||||||
|
|||||||
@@ -95,7 +95,6 @@
|
|||||||
"clsx": "1.1.1",
|
"clsx": "1.1.1",
|
||||||
"cross-env": "7.0.3",
|
"cross-env": "7.0.3",
|
||||||
"es6-promise-pool": "2.5.0",
|
"es6-promise-pool": "2.5.0",
|
||||||
"fractional-indexing": "3.2.0",
|
|
||||||
"fuzzy": "0.1.3",
|
"fuzzy": "0.1.3",
|
||||||
"image-blob-reduce": "3.0.1",
|
"image-blob-reduce": "3.0.1",
|
||||||
"jotai": "2.11.0",
|
"jotai": "2.11.0",
|
||||||
|
|||||||
@@ -23,6 +23,94 @@ const polyfill = () => {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!Array.prototype.findLast) {
|
||||||
|
Object.defineProperty(Array.prototype, "findLast", {
|
||||||
|
value: function <T>(
|
||||||
|
this: T[],
|
||||||
|
predicate: (value: T, index: number, array: T[]) => unknown,
|
||||||
|
thisArg?: unknown,
|
||||||
|
) {
|
||||||
|
return this
|
||||||
|
.slice()
|
||||||
|
.reverse()
|
||||||
|
.find((value, index) =>
|
||||||
|
predicate.call(thisArg, value, this.length - index - 1, this),
|
||||||
|
);
|
||||||
|
},
|
||||||
|
writable: true,
|
||||||
|
enumerable: false,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!Array.prototype.findIndex) {
|
||||||
|
Object.defineProperty(Array.prototype, "findIndex", {
|
||||||
|
value: function <T>(
|
||||||
|
this: T[],
|
||||||
|
predicate: (value: T, index: number, array: T[]) => unknown,
|
||||||
|
thisArg?: unknown,
|
||||||
|
) {
|
||||||
|
for (let index = 0; index < this.length; index++) {
|
||||||
|
if (predicate.call(thisArg, this[index], index, this)) {
|
||||||
|
return index;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return -1;
|
||||||
|
},
|
||||||
|
writable: true,
|
||||||
|
enumerable: false,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!Array.prototype.findLastIndex) {
|
||||||
|
Object.defineProperty(Array.prototype, "findLastIndex", {
|
||||||
|
value: function <T>(
|
||||||
|
this: T[],
|
||||||
|
predicate: (value: T, index: number, array: T[]) => unknown,
|
||||||
|
thisArg?: unknown,
|
||||||
|
) {
|
||||||
|
const index = this
|
||||||
|
.slice()
|
||||||
|
.reverse()
|
||||||
|
.findIndex((value, index) =>
|
||||||
|
predicate.call(thisArg, value, this.length - index - 1, this),
|
||||||
|
);
|
||||||
|
|
||||||
|
return index === -1 ? -1 : this.length - index - 1;
|
||||||
|
},
|
||||||
|
writable: true,
|
||||||
|
enumerable: false,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!Array.prototype.toReversed) {
|
||||||
|
Object.defineProperty(Array.prototype, "toReversed", {
|
||||||
|
value: function <T>(this: T[]) {
|
||||||
|
return this.slice().reverse();
|
||||||
|
},
|
||||||
|
writable: true,
|
||||||
|
enumerable: false,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!Array.prototype.toSorted) {
|
||||||
|
Object.defineProperty(Array.prototype, "toSorted", {
|
||||||
|
value: function <T>(
|
||||||
|
this: T[],
|
||||||
|
compareFn?: (a: T, b: T) => number,
|
||||||
|
) {
|
||||||
|
return this.slice().sort(compareFn);
|
||||||
|
},
|
||||||
|
writable: true,
|
||||||
|
enumerable: false,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
if (!Element.prototype.replaceChildren) {
|
if (!Element.prototype.replaceChildren) {
|
||||||
Element.prototype.replaceChildren = function (...nodes) {
|
Element.prototype.replaceChildren = function (...nodes) {
|
||||||
this.innerHTML = "";
|
this.innerHTML = "";
|
||||||
|
|||||||
@@ -1,9 +1,15 @@
|
|||||||
import { isElementInViewport } from "@excalidraw/element";
|
import {
|
||||||
|
getCommonFrameId,
|
||||||
|
getFrameChildrenInsertionIndex,
|
||||||
|
isElementInViewport,
|
||||||
|
} from "@excalidraw/element";
|
||||||
|
|
||||||
import { memoize, toBrandedType } from "@excalidraw/common";
|
import { arrayToMap, memoize, toBrandedType } from "@excalidraw/common";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
ExcalidrawElement,
|
ExcalidrawElement,
|
||||||
|
ExcalidrawFrameLikeElement,
|
||||||
|
NonDeleted,
|
||||||
NonDeletedElementsMap,
|
NonDeletedElementsMap,
|
||||||
NonDeletedExcalidrawElement,
|
NonDeletedExcalidrawElement,
|
||||||
} from "@excalidraw/element/types";
|
} from "@excalidraw/element/types";
|
||||||
@@ -16,6 +22,21 @@ import type { RenderableElementsMap } from "./types";
|
|||||||
|
|
||||||
import type { AppState } from "../types";
|
import type { AppState } from "../types";
|
||||||
|
|
||||||
|
type GetRenderableElementsOpts = {
|
||||||
|
zoom: AppState["zoom"];
|
||||||
|
offsetLeft: AppState["offsetLeft"];
|
||||||
|
offsetTop: AppState["offsetTop"];
|
||||||
|
scrollX: AppState["scrollX"];
|
||||||
|
scrollY: AppState["scrollY"];
|
||||||
|
height: AppState["height"];
|
||||||
|
width: AppState["width"];
|
||||||
|
editingTextElement: AppState["editingTextElement"];
|
||||||
|
newElement: AppState["newElement"];
|
||||||
|
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||||
|
selectedElementsAreBeingDragged: AppState["selectedElementsAreBeingDragged"];
|
||||||
|
frameToHighlight: AppState["frameToHighlight"];
|
||||||
|
};
|
||||||
|
|
||||||
export class Renderer {
|
export class Renderer {
|
||||||
private scene: Scene;
|
private scene: Scene;
|
||||||
|
|
||||||
@@ -23,9 +44,121 @@ export class Renderer {
|
|||||||
this.scene = scene;
|
this.scene = scene;
|
||||||
}
|
}
|
||||||
|
|
||||||
public getRenderableElements = (() => {
|
private getVisibleCanvasElements({
|
||||||
const getVisibleCanvasElements = ({
|
elementsMap,
|
||||||
elementsMap,
|
zoom,
|
||||||
|
offsetLeft,
|
||||||
|
offsetTop,
|
||||||
|
scrollX,
|
||||||
|
scrollY,
|
||||||
|
height,
|
||||||
|
width,
|
||||||
|
}: {
|
||||||
|
elementsMap: NonDeletedElementsMap;
|
||||||
|
zoom: AppState["zoom"];
|
||||||
|
offsetLeft: AppState["offsetLeft"];
|
||||||
|
offsetTop: AppState["offsetTop"];
|
||||||
|
scrollX: AppState["scrollX"];
|
||||||
|
scrollY: AppState["scrollY"];
|
||||||
|
height: AppState["height"];
|
||||||
|
width: AppState["width"];
|
||||||
|
}): readonly NonDeletedExcalidrawElement[] {
|
||||||
|
const visibleElements: NonDeletedExcalidrawElement[] = [];
|
||||||
|
for (const element of elementsMap.values()) {
|
||||||
|
if (
|
||||||
|
isElementInViewport(
|
||||||
|
element,
|
||||||
|
width,
|
||||||
|
height,
|
||||||
|
{
|
||||||
|
zoom,
|
||||||
|
offsetLeft,
|
||||||
|
offsetTop,
|
||||||
|
scrollX,
|
||||||
|
scrollY,
|
||||||
|
},
|
||||||
|
elementsMap,
|
||||||
|
)
|
||||||
|
) {
|
||||||
|
visibleElements.push(element);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return visibleElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
private getRenderableElementsMap({
|
||||||
|
elements,
|
||||||
|
editingTextElement,
|
||||||
|
newElement,
|
||||||
|
}: {
|
||||||
|
elements: readonly NonDeletedExcalidrawElement[];
|
||||||
|
editingTextElement: AppState["editingTextElement"];
|
||||||
|
newElement: AppState["newElement"];
|
||||||
|
}) {
|
||||||
|
const elementsMap = toBrandedType<RenderableElementsMap>(new Map());
|
||||||
|
const newElementCanvasElement = newElement?.frameId ? null : newElement;
|
||||||
|
|
||||||
|
for (const element of elements) {
|
||||||
|
if (newElementCanvasElement?.id === element.id) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
|
// we don't want to render text element that's being currently edited
|
||||||
|
// (it's rendered on remote only)
|
||||||
|
if (
|
||||||
|
!editingTextElement ||
|
||||||
|
editingTextElement.type !== "text" ||
|
||||||
|
element.id !== editingTextElement.id
|
||||||
|
) {
|
||||||
|
elementsMap.set(element.id, element);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return { elementsMap, newElementCanvasElement };
|
||||||
|
}
|
||||||
|
|
||||||
|
private sortSelectedElementsIntoHighlightedFrame<
|
||||||
|
T extends ExcalidrawElement,
|
||||||
|
>({
|
||||||
|
visibleElements,
|
||||||
|
selectedElements,
|
||||||
|
frameToHighlight,
|
||||||
|
}: {
|
||||||
|
selectedElements: readonly NonDeletedExcalidrawElement[];
|
||||||
|
visibleElements: readonly T[];
|
||||||
|
frameToHighlight: NonDeleted<ExcalidrawFrameLikeElement>;
|
||||||
|
}): readonly T[] {
|
||||||
|
if (!selectedElements.length) {
|
||||||
|
return visibleElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
// we assume all selected elements are eligible frame children if
|
||||||
|
// frameToHighlight is defined
|
||||||
|
const selectedElementsMap = arrayToMap(selectedElements);
|
||||||
|
|
||||||
|
// thus, all deselected elements are the ones we won't reorder
|
||||||
|
const deselectedElements = visibleElements.filter(
|
||||||
|
(element) => !selectedElementsMap.has(element.id),
|
||||||
|
);
|
||||||
|
|
||||||
|
const insertionIndex = getFrameChildrenInsertionIndex(
|
||||||
|
deselectedElements,
|
||||||
|
frameToHighlight.id,
|
||||||
|
);
|
||||||
|
|
||||||
|
if (insertionIndex === null) {
|
||||||
|
return visibleElements;
|
||||||
|
}
|
||||||
|
|
||||||
|
return [
|
||||||
|
...deselectedElements.slice(0, insertionIndex),
|
||||||
|
...selectedElements,
|
||||||
|
...deselectedElements.slice(insertionIndex),
|
||||||
|
] as readonly T[];
|
||||||
|
}
|
||||||
|
|
||||||
|
private _getRenderableElements = memoize(
|
||||||
|
({
|
||||||
|
canvasNonce,
|
||||||
zoom,
|
zoom,
|
||||||
offsetLeft,
|
offsetLeft,
|
||||||
offsetTop,
|
offsetTop,
|
||||||
@@ -33,70 +166,27 @@ export class Renderer {
|
|||||||
scrollY,
|
scrollY,
|
||||||
height,
|
height,
|
||||||
width,
|
width,
|
||||||
}: {
|
|
||||||
elementsMap: NonDeletedElementsMap;
|
|
||||||
zoom: AppState["zoom"];
|
|
||||||
offsetLeft: AppState["offsetLeft"];
|
|
||||||
offsetTop: AppState["offsetTop"];
|
|
||||||
scrollX: AppState["scrollX"];
|
|
||||||
scrollY: AppState["scrollY"];
|
|
||||||
height: AppState["height"];
|
|
||||||
width: AppState["width"];
|
|
||||||
}): readonly NonDeletedExcalidrawElement[] => {
|
|
||||||
const visibleElements: NonDeletedExcalidrawElement[] = [];
|
|
||||||
for (const element of elementsMap.values()) {
|
|
||||||
if (
|
|
||||||
isElementInViewport(
|
|
||||||
element,
|
|
||||||
width,
|
|
||||||
height,
|
|
||||||
{
|
|
||||||
zoom,
|
|
||||||
offsetLeft,
|
|
||||||
offsetTop,
|
|
||||||
scrollX,
|
|
||||||
scrollY,
|
|
||||||
},
|
|
||||||
elementsMap,
|
|
||||||
)
|
|
||||||
) {
|
|
||||||
visibleElements.push(element);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return visibleElements;
|
|
||||||
};
|
|
||||||
|
|
||||||
const getRenderableElements = ({
|
|
||||||
elements,
|
|
||||||
editingTextElement,
|
editingTextElement,
|
||||||
newElementId,
|
newElement,
|
||||||
}: {
|
}: Omit<
|
||||||
elements: readonly NonDeletedExcalidrawElement[];
|
GetRenderableElementsOpts,
|
||||||
editingTextElement: AppState["editingTextElement"];
|
| "selectedElements"
|
||||||
newElementId: ExcalidrawElement["id"] | undefined;
|
| "selectedElementsAreBeingDragged"
|
||||||
|
| "frameToHighlight"
|
||||||
|
> & {
|
||||||
|
canvasNonce: string;
|
||||||
}) => {
|
}) => {
|
||||||
const elementsMap = toBrandedType<RenderableElementsMap>(new Map());
|
const elements = this.scene.getNonDeletedElements();
|
||||||
|
|
||||||
for (const element of elements) {
|
const { elementsMap, newElementCanvasElement } =
|
||||||
if (newElementId === element.id) {
|
this.getRenderableElementsMap({
|
||||||
continue;
|
elements,
|
||||||
}
|
editingTextElement,
|
||||||
|
newElement,
|
||||||
|
});
|
||||||
|
|
||||||
// we don't want to render text element that's being currently edited
|
const visibleElements = this.getVisibleCanvasElements({
|
||||||
// (it's rendered on remote only)
|
elementsMap,
|
||||||
if (
|
|
||||||
!editingTextElement ||
|
|
||||||
editingTextElement.type !== "text" ||
|
|
||||||
element.id !== editingTextElement.id
|
|
||||||
) {
|
|
||||||
elementsMap.set(element.id, element);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return elementsMap;
|
|
||||||
};
|
|
||||||
|
|
||||||
return memoize(
|
|
||||||
({
|
|
||||||
zoom,
|
zoom,
|
||||||
offsetLeft,
|
offsetLeft,
|
||||||
offsetTop,
|
offsetTop,
|
||||||
@@ -104,52 +194,69 @@ export class Renderer {
|
|||||||
scrollY,
|
scrollY,
|
||||||
height,
|
height,
|
||||||
width,
|
width,
|
||||||
editingTextElement,
|
});
|
||||||
newElementId,
|
|
||||||
// cache-invalidation nonce
|
|
||||||
sceneNonce: _sceneNonce,
|
|
||||||
}: {
|
|
||||||
zoom: AppState["zoom"];
|
|
||||||
offsetLeft: AppState["offsetLeft"];
|
|
||||||
offsetTop: AppState["offsetTop"];
|
|
||||||
scrollX: AppState["scrollX"];
|
|
||||||
scrollY: AppState["scrollY"];
|
|
||||||
height: AppState["height"];
|
|
||||||
width: AppState["width"];
|
|
||||||
editingTextElement: AppState["editingTextElement"];
|
|
||||||
/** note: first render of newElement will always bust the cache
|
|
||||||
* (we'd have to prefilter elements outside of this function) */
|
|
||||||
newElementId: ExcalidrawElement["id"] | undefined;
|
|
||||||
sceneNonce: ReturnType<InstanceType<typeof Scene>["getSceneNonce"]>;
|
|
||||||
}) => {
|
|
||||||
const elements = this.scene.getNonDeletedElements();
|
|
||||||
|
|
||||||
const elementsMap = getRenderableElements({
|
return {
|
||||||
elements,
|
elementsMap,
|
||||||
editingTextElement,
|
visibleElements,
|
||||||
newElementId,
|
newElementCanvasElement,
|
||||||
|
canvasNonce,
|
||||||
|
};
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
public getRenderableElements = (opts: GetRenderableElementsOpts) => {
|
||||||
|
const { newElement } = opts;
|
||||||
|
const canvasNonce = `${this.scene.getSceneNonce()}${
|
||||||
|
newElement?.frameId ? `:${newElement.versionNonce}` : ""
|
||||||
|
}`;
|
||||||
|
|
||||||
|
const ret = this._getRenderableElements({
|
||||||
|
canvasNonce,
|
||||||
|
|
||||||
|
// don't spread `opts` because we don't want to memoize on some props
|
||||||
|
|
||||||
|
zoom: opts.zoom,
|
||||||
|
offsetLeft: opts.offsetLeft,
|
||||||
|
offsetTop: opts.offsetTop,
|
||||||
|
scrollX: opts.scrollX,
|
||||||
|
scrollY: opts.scrollY,
|
||||||
|
height: opts.height,
|
||||||
|
width: opts.width,
|
||||||
|
editingTextElement: opts.editingTextElement,
|
||||||
|
newElement: opts.newElement,
|
||||||
|
});
|
||||||
|
|
||||||
|
// if we're dragging elements over a frame, reorder the selected elements
|
||||||
|
// inside the frame during render (we don't set the `element.frameId` until
|
||||||
|
// pointerup else we'd have to painstainly restore the orig index if user
|
||||||
|
// didn't end up adding elements to the frame)
|
||||||
|
if (
|
||||||
|
opts.frameToHighlight &&
|
||||||
|
opts.selectedElementsAreBeingDragged &&
|
||||||
|
// if all dragged elements are already in the frame, don't reorder
|
||||||
|
getCommonFrameId(opts.selectedElements) !== opts.frameToHighlight.id
|
||||||
|
) {
|
||||||
|
const reorderedVisibleElements =
|
||||||
|
this.sortSelectedElementsIntoHighlightedFrame({
|
||||||
|
visibleElements: ret.visibleElements,
|
||||||
|
selectedElements: opts.selectedElements,
|
||||||
|
frameToHighlight: opts.frameToHighlight,
|
||||||
});
|
});
|
||||||
|
|
||||||
const visibleElements = getVisibleCanvasElements({
|
return {
|
||||||
elementsMap,
|
...ret,
|
||||||
zoom,
|
visibleElements: reorderedVisibleElements,
|
||||||
offsetLeft,
|
};
|
||||||
offsetTop,
|
}
|
||||||
scrollX,
|
|
||||||
scrollY,
|
|
||||||
height,
|
|
||||||
width,
|
|
||||||
});
|
|
||||||
|
|
||||||
return { elementsMap, visibleElements };
|
return ret;
|
||||||
},
|
};
|
||||||
);
|
|
||||||
})();
|
|
||||||
|
|
||||||
// NOTE Doesn't destroy everything (scene, rc, etc.) because it may not be
|
// NOTE Doesn't destroy everything (scene, rc, etc.) because it may not be
|
||||||
// safe to break TS contract here (for upstream cases)
|
// safe to break TS contract here (for upstream cases)
|
||||||
public destroy() {
|
public destroy() {
|
||||||
renderStaticSceneThrottled.cancel();
|
renderStaticSceneThrottled.cancel();
|
||||||
this.getRenderableElements.clear();
|
this._getRenderableElements.clear();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -980,7 +980,6 @@ exports[`contextMenu element > right-clicking on a group should select whole gro
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -1175,7 +1174,6 @@ exports[`contextMenu element > selecting 'Add to library' in context menu adds e
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -1391,7 +1389,6 @@ exports[`contextMenu element > selecting 'Bring forward' in context menu brings
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -1724,7 +1721,6 @@ exports[`contextMenu element > selecting 'Bring to front' in context menu brings
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2057,7 +2053,6 @@ exports[`contextMenu element > selecting 'Copy styles' in context menu copies st
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2271,7 +2266,6 @@ exports[`contextMenu element > selecting 'Delete' in context menu deletes elemen
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2516,7 +2510,6 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2821,7 +2814,6 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3190,7 +3182,6 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3685,7 +3676,6 @@ exports[`contextMenu element > selecting 'Send backward' in context menu sends e
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4010,7 +4000,6 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4338,7 +4327,6 @@ exports[`contextMenu element > selecting 'Ungroup selection' in context menu ung
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5625,7 +5613,6 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -6846,7 +6833,6 @@ exports[`contextMenu element > shows 'Ungroup selection' in context menu for gro
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7801,7 +7787,6 @@ exports[`contextMenu element > shows context menu for canvas > [end of test] app
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -8802,7 +8787,6 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9798,7 +9782,6 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
|
|||||||
@@ -1296,7 +1296,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -1658,7 +1657,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2022,7 +2020,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2286,7 +2283,40 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
"startBoundElement": {
|
||||||
|
"angle": 0,
|
||||||
|
"backgroundColor": "transparent",
|
||||||
|
"boundElements": [
|
||||||
|
{
|
||||||
|
"id": "id4",
|
||||||
|
"type": "arrow",
|
||||||
|
},
|
||||||
|
],
|
||||||
|
"customData": undefined,
|
||||||
|
"fillStyle": "solid",
|
||||||
|
"frameId": null,
|
||||||
|
"groupIds": [],
|
||||||
|
"height": 100,
|
||||||
|
"id": "id0",
|
||||||
|
"index": "a0",
|
||||||
|
"isDeleted": false,
|
||||||
|
"link": null,
|
||||||
|
"locked": false,
|
||||||
|
"opacity": 100,
|
||||||
|
"roughness": 1,
|
||||||
|
"roundness": null,
|
||||||
|
"seed": 1,
|
||||||
|
"strokeColor": "#1e1e1e",
|
||||||
|
"strokeStyle": "solid",
|
||||||
|
"strokeWidth": 2,
|
||||||
|
"type": "rectangle",
|
||||||
|
"updated": 1,
|
||||||
|
"version": 3,
|
||||||
|
"versionNonce": 493213705,
|
||||||
|
"width": 100,
|
||||||
|
"x": -100,
|
||||||
|
"y": -50,
|
||||||
|
},
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2742,7 +2772,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3047,7 +3076,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3368,7 +3396,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3664,7 +3691,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3952,7 +3978,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4189,7 +4214,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4448,7 +4472,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4721,7 +4744,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4952,7 +4974,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5183,7 +5204,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5432,7 +5452,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5690,7 +5709,6 @@ exports[`history > multiplayer undo/redo > conflicts in frames and their childre
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5949,7 +5967,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -6280,7 +6297,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -6712,7 +6728,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7094,7 +7109,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7691,7 +7705,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7923,7 +7936,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -8277,7 +8289,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -8637,7 +8648,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9039,7 +9049,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9322,7 +9331,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9588,7 +9596,6 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9855,7 +9862,6 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10090,7 +10096,6 @@ exports[`history > multiplayer undo/redo > should override remotely added groups
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10705,7 +10710,6 @@ exports[`history > multiplayer undo/redo > should redistribute deltas when eleme
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10946,7 +10950,6 @@ exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end o
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11389,7 +11392,6 @@ exports[`history > multiplayer undo/redo > should update history entries after r
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11649,7 +11651,6 @@ exports[`history > singleplayer undo/redo > remounting undo/redo buttons should
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": false,
|
"showWelcomeScreen": false,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11888,7 +11889,6 @@ exports[`history > singleplayer undo/redo > should clear the redo stack on eleme
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -12125,7 +12125,6 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -12523,7 +12522,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on e
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -12732,7 +12730,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on e
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -12945,7 +12942,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on i
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -13245,7 +13241,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on i
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -13545,7 +13540,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on s
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": false,
|
"showWelcomeScreen": false,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -13791,7 +13785,6 @@ exports[`history > singleplayer undo/redo > should disable undo/redo buttons whe
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": false,
|
"showWelcomeScreen": false,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14030,7 +14023,6 @@ exports[`history > singleplayer undo/redo > should end up with no history entry
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": false,
|
"showWelcomeScreen": false,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14269,7 +14261,6 @@ exports[`history > singleplayer undo/redo > should iterate through the history w
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14518,7 +14509,6 @@ exports[`history > singleplayer undo/redo > should not clear the redo stack on s
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14852,7 +14842,6 @@ exports[`history > singleplayer undo/redo > should not collapse when applying co
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -15026,7 +15015,6 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -15310,7 +15298,6 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -15575,7 +15562,6 @@ exports[`history > singleplayer undo/redo > should not modify anything on unrela
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": false,
|
"showWelcomeScreen": false,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -15731,7 +15717,6 @@ exports[`history > singleplayer undo/redo > should not override appstate changes
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -16014,7 +15999,6 @@ exports[`history > singleplayer undo/redo > should support appstate name or view
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -19747,7 +19731,6 @@ exports[`history > singleplayer undo/redo > should support changes in elements'
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -20231,7 +20214,6 @@ exports[`history > singleplayer undo/redo > should support duplication of groups
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -20739,7 +20721,6 @@ exports[`history > singleplayer undo/redo > should support element creation, del
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
|
|||||||
@@ -107,7 +107,6 @@ exports[`given element A and group of elements B and given both are selected whe
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -537,7 +536,6 @@ exports[`given element A and group of elements B and given both are selected whe
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -946,7 +944,6 @@ exports[`regression tests > Cmd/Ctrl-click exclusively select element under poin
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -1514,7 +1511,6 @@ exports[`regression tests > Drags selected element when hitting only bounding bo
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -1728,7 +1724,6 @@ exports[`regression tests > adjusts z order when grouping > [end of test] appSta
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2111,7 +2106,6 @@ exports[`regression tests > alt-drag duplicates an element > [end of test] appSt
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2356,7 +2350,6 @@ exports[`regression tests > arrow keys > [end of test] appState 1`] = `
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2540,7 +2533,6 @@ exports[`regression tests > can drag element that covers another element, while
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -2865,7 +2857,6 @@ exports[`regression tests > change the properties of a shape > [end of test] app
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3124,7 +3115,6 @@ exports[`regression tests > click on an element and drag it > [dragged] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3367,7 +3357,6 @@ exports[`regression tests > click on an element and drag it > [end of test] appS
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3605,7 +3594,6 @@ exports[`regression tests > click to select a shape > [end of test] appState 1`]
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -3866,7 +3854,6 @@ exports[`regression tests > click-drag to select a group > [end of test] appStat
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4181,7 +4168,6 @@ exports[`regression tests > deleting last but one element in editing group shoul
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4646,7 +4632,6 @@ exports[`regression tests > deselects group of selected elements on pointer down
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -4903,7 +4888,6 @@ exports[`regression tests > deselects group of selected elements on pointer up w
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5208,7 +5192,6 @@ exports[`regression tests > deselects selected element on pointer down when poin
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5390,7 +5373,6 @@ exports[`regression tests > deselects selected element, on pointer up, when clic
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5592,7 +5574,6 @@ exports[`regression tests > double click to edit a group > [end of test] appStat
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -5991,7 +5972,6 @@ exports[`regression tests > drags selected elements from point inside common bou
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7079,7 +7059,6 @@ exports[`regression tests > given a group of selected elements with an element t
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7415,7 +7394,6 @@ exports[`regression tests > given a selected element A and a not selected elemen
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7695,7 +7673,6 @@ exports[`regression tests > given selected element A with lower z-index than uns
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -7932,7 +7909,6 @@ exports[`regression tests > given selected element A with lower z-index than uns
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -8172,7 +8148,6 @@ exports[`regression tests > key 2 selects rectangle tool > [end of test] appStat
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -8354,7 +8329,6 @@ exports[`regression tests > key 3 selects diamond tool > [end of test] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -8536,7 +8510,6 @@ exports[`regression tests > key 4 selects ellipse tool > [end of test] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9182,7 +9155,6 @@ exports[`regression tests > key 7 selects freedraw tool > [end of test] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -9612,7 +9584,6 @@ exports[`regression tests > key d selects diamond tool > [end of test] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10026,7 +9997,6 @@ exports[`regression tests > key o selects ellipse tool > [end of test] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10206,7 +10176,6 @@ exports[`regression tests > key p selects freedraw tool > [end of test] appState
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10402,7 +10371,6 @@ exports[`regression tests > key r selects rectangle tool > [end of test] appStat
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -10592,7 +10560,6 @@ exports[`regression tests > make a group and duplicate it > [end of test] appSta
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11119,7 +11086,6 @@ exports[`regression tests > noop interaction after undo shouldn't create history
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11397,7 +11363,6 @@ exports[`regression tests > pinch-to-zoom works > [end of test] appState 1`] = `
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11524,7 +11489,6 @@ exports[`regression tests > shift click on selected element should deselect it o
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -11730,7 +11694,6 @@ exports[`regression tests > shift-click to multiselect, then drag > [end of test
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -12053,7 +12016,6 @@ exports[`regression tests > should group elements and ungroup them > [end of tes
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -12488,7 +12450,6 @@ exports[`regression tests > single-clicking on a subgroup of a selected group sh
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -13121,7 +13082,6 @@ exports[`regression tests > spacebar + drag scrolls the canvas > [end of test] a
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -13250,7 +13210,6 @@ exports[`regression tests > supports nested groups > [end of test] appState 1`]
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -13912,7 +13871,6 @@ exports[`regression tests > switches from group of selected elements to another
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14252,7 +14210,6 @@ exports[`regression tests > switches selected element on pointer down > [end of
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14486,7 +14443,6 @@ exports[`regression tests > two-finger scroll works > [end of test] appState 1`]
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -14977,7 +14933,6 @@ exports[`regression tests > updates fontSize & fontFamily appState > [end of tes
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
@@ -15105,7 +15060,6 @@ exports[`regression tests > zoom hotkeys > [end of test] appState 1`] = `
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": true,
|
"showWelcomeScreen": true,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
|
|||||||
@@ -305,8 +305,88 @@ describe("pasting & frames", () => {
|
|||||||
|
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(h.elements.length).toBe(2);
|
expect(h.elements.length).toBe(2);
|
||||||
|
expect(h.elements[0].type).toBe(rect.type);
|
||||||
|
expect(h.elements[0].frameId).toBe(frame.id);
|
||||||
|
expect(h.elements[1].id).toBe(frame.id);
|
||||||
|
expect(h.elements[0].index! < frame.index!).toBe(true);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should layer pasted elements above the highest frame child", async () => {
|
||||||
|
const frame = API.createElement({
|
||||||
|
type: "frame",
|
||||||
|
width: 100,
|
||||||
|
height: 100,
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
});
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
id: "frameChild",
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
const rect = API.createElement({ type: "rectangle" });
|
||||||
|
|
||||||
|
API.setElements([frameChild, frame]);
|
||||||
|
|
||||||
|
const clipboardJSON = await serializeAsClipboardJSON({
|
||||||
|
elements: [rect],
|
||||||
|
files: null,
|
||||||
|
});
|
||||||
|
|
||||||
|
mouse.moveTo(50, 50);
|
||||||
|
|
||||||
|
pasteWithCtrlCmdV(clipboardJSON);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(h.elements.length).toBe(3);
|
||||||
expect(h.elements[1].type).toBe(rect.type);
|
expect(h.elements[1].type).toBe(rect.type);
|
||||||
expect(h.elements[1].frameId).toBe(frame.id);
|
expect(h.elements[1].frameId).toBe(frame.id);
|
||||||
|
expect(h.elements.map((element) => element.id)).toEqual([
|
||||||
|
frameChild.id,
|
||||||
|
h.elements[1].id,
|
||||||
|
frame.id,
|
||||||
|
]);
|
||||||
|
expect(h.elements[1].index! > frameChild.index!).toBe(true);
|
||||||
|
expect(h.elements[1].index! < frame.index!).toBe(true);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should preserve denormalized pasted frame child order", async () => {
|
||||||
|
const frame = API.createElement({
|
||||||
|
type: "frame",
|
||||||
|
width: 100,
|
||||||
|
height: 100,
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
});
|
||||||
|
const frameChild = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 10,
|
||||||
|
width: 20,
|
||||||
|
height: 20,
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
|
||||||
|
const clipboardJSON = await serializeAsClipboardJSON({
|
||||||
|
elements: [frame, frameChild],
|
||||||
|
files: null,
|
||||||
|
});
|
||||||
|
|
||||||
|
mouse.moveTo(200, 200);
|
||||||
|
|
||||||
|
pasteWithCtrlCmdV(clipboardJSON);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(h.elements.length).toBe(2);
|
||||||
|
expect(h.elements[0].type).toBe(frame.type);
|
||||||
|
expect(h.elements[1].type).toBe(frameChild.type);
|
||||||
|
expect(h.elements[1].frameId).toBe(h.elements[0].id);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -379,8 +459,9 @@ describe("pasting & frames", () => {
|
|||||||
|
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(h.elements.length).toBe(3);
|
expect(h.elements.length).toBe(3);
|
||||||
expect(h.elements[1].type).toBe(rect.type);
|
expect(h.elements[0].type).toBe(rect.type);
|
||||||
expect(h.elements[1].frameId).toBe(frame.id);
|
expect(h.elements[0].frameId).toBe(frame.id);
|
||||||
|
expect(h.elements[1].id).toBe(frame.id);
|
||||||
expect(h.elements[2].type).toBe(rect2.type);
|
expect(h.elements[2].type).toBe(rect2.type);
|
||||||
expect(h.elements[2].frameId).toBe(null);
|
expect(h.elements[2].frameId).toBe(null);
|
||||||
});
|
});
|
||||||
@@ -422,10 +503,11 @@ describe("pasting & frames", () => {
|
|||||||
|
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(h.elements.length).toBe(3);
|
expect(h.elements.length).toBe(3);
|
||||||
expect(h.elements[1].type).toBe(rect.type);
|
expect(h.elements[0].type).toBe(rect.type);
|
||||||
|
expect(h.elements[0].frameId).toBe(frame.id);
|
||||||
|
expect(h.elements[1].type).toBe(rect2.type);
|
||||||
expect(h.elements[1].frameId).toBe(frame.id);
|
expect(h.elements[1].frameId).toBe(frame.id);
|
||||||
expect(h.elements[2].type).toBe(rect2.type);
|
expect(h.elements[2].id).toBe(frame.id);
|
||||||
expect(h.elements[2].frameId).toBe(frame.id);
|
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -473,8 +555,9 @@ describe("pasting & frames", () => {
|
|||||||
|
|
||||||
await waitFor(() => {
|
await waitFor(() => {
|
||||||
expect(h.elements.length).toBe(4);
|
expect(h.elements.length).toBe(4);
|
||||||
expect(h.elements[1].type).toBe(rect.type);
|
expect(h.elements[0].type).toBe(rect.type);
|
||||||
expect(h.elements[1].frameId).toBe(frame.id);
|
expect(h.elements[0].frameId).toBe(frame.id);
|
||||||
|
expect(h.elements[1].id).toBe(frame.id);
|
||||||
expect(h.elements[2].type).toBe(rect2.type);
|
expect(h.elements[2].type).toBe(rect2.type);
|
||||||
expect(h.elements[2].frameId).toBe(h.elements[3].id);
|
expect(h.elements[2].frameId).toBe(h.elements[3].id);
|
||||||
expect(h.elements[3].type).toBe(frame2.type);
|
expect(h.elements[3].type).toBe(frame2.type);
|
||||||
|
|||||||
@@ -160,6 +160,39 @@ describe("restoreElements", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should restore only valid freedraw points and keep pressures aligned", () => {
|
||||||
|
const freedrawElement = API.createElement({
|
||||||
|
type: "freedraw",
|
||||||
|
id: "id-freedraw-invalid-points",
|
||||||
|
points: [pointFrom(0, 0), pointFrom(10, 10)],
|
||||||
|
});
|
||||||
|
|
||||||
|
const restoredFreedraw = restore.restoreElements(
|
||||||
|
[
|
||||||
|
{
|
||||||
|
...freedrawElement,
|
||||||
|
simulatePressure: false,
|
||||||
|
points: [
|
||||||
|
pointFrom(0, 0),
|
||||||
|
[Infinity, 10],
|
||||||
|
null,
|
||||||
|
pointFrom(20, 20),
|
||||||
|
[NaN, 30],
|
||||||
|
[40, null],
|
||||||
|
],
|
||||||
|
pressures: [0.1, 0.2, 0.3, 0.4, 0.5, 0.6],
|
||||||
|
} as any,
|
||||||
|
],
|
||||||
|
null,
|
||||||
|
)[0] as ExcalidrawFreeDrawElement;
|
||||||
|
|
||||||
|
expect(restoredFreedraw.points).toEqual([
|
||||||
|
pointFrom(0, 0),
|
||||||
|
pointFrom(20, 20),
|
||||||
|
]);
|
||||||
|
expect(restoredFreedraw.pressures).toEqual([0.1, 0.4]);
|
||||||
|
});
|
||||||
|
|
||||||
it("should restore line and draw elements correctly", () => {
|
it("should restore line and draw elements correctly", () => {
|
||||||
const lineElement = API.createElement({ type: "line", id: "id-line01" });
|
const lineElement = API.createElement({ type: "line", id: "id-line01" });
|
||||||
|
|
||||||
@@ -400,6 +433,52 @@ describe("restoreElements", () => {
|
|||||||
expect(restoredLine.points).toMatchObject(expectedLinePoints);
|
expect(restoredLine.points).toMatchObject(expectedLinePoints);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should restore only valid linear points", () => {
|
||||||
|
const lineElement: any = API.createElement({
|
||||||
|
type: "line",
|
||||||
|
x: 10,
|
||||||
|
y: 20,
|
||||||
|
width: 100,
|
||||||
|
height: 200,
|
||||||
|
});
|
||||||
|
const arrowElement: any = API.createElement({
|
||||||
|
type: "arrow",
|
||||||
|
width: 100,
|
||||||
|
height: 200,
|
||||||
|
});
|
||||||
|
|
||||||
|
lineElement.points = [
|
||||||
|
[2, 3],
|
||||||
|
null,
|
||||||
|
[Infinity, 4],
|
||||||
|
[5, 7],
|
||||||
|
[NaN, 8],
|
||||||
|
[9, null],
|
||||||
|
];
|
||||||
|
arrowElement.points = [
|
||||||
|
[null, 0],
|
||||||
|
[Infinity, 4],
|
||||||
|
];
|
||||||
|
|
||||||
|
const restoredElements = restore.restoreElements(
|
||||||
|
[lineElement, arrowElement],
|
||||||
|
null,
|
||||||
|
);
|
||||||
|
const restoredLine = restoredElements[0] as ExcalidrawLinearElement;
|
||||||
|
const restoredArrow = restoredElements[1] as ExcalidrawArrowElement;
|
||||||
|
|
||||||
|
expect(restoredLine.points).toEqual([pointFrom(0, 0), pointFrom(3, 4)]);
|
||||||
|
expect(restoredLine.x).toBe(12);
|
||||||
|
expect(restoredLine.y).toBe(23);
|
||||||
|
expect(restoredLine.width).toBe(3);
|
||||||
|
expect(restoredLine.height).toBe(4);
|
||||||
|
|
||||||
|
expect(restoredArrow.points).toEqual([
|
||||||
|
pointFrom(0, 0),
|
||||||
|
pointFrom(100, 200),
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
it("when the number of points of a line is greater or equal 2", () => {
|
it("when the number of points of a line is greater or equal 2", () => {
|
||||||
const lineElement_0 = API.createElement({
|
const lineElement_0 = API.createElement({
|
||||||
type: "line",
|
type: "line",
|
||||||
|
|||||||
@@ -94,3 +94,42 @@ export const testPolyfills = {
|
|||||||
// https://github.com/vitest-dev/vitest/pull/4164#issuecomment-2172729965
|
// https://github.com/vitest-dev/vitest/pull/4164#issuecomment-2172729965
|
||||||
URL,
|
URL,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const PolyfillLocalStorage = () => {
|
||||||
|
// Node.js 25+ provides a native localStorage global that shadows jsdom's,
|
||||||
|
// and jsdom's own localStorage also uses the native one -- both are broken
|
||||||
|
// (empty objects without Storage methods). On older Node versions, jsdom
|
||||||
|
// provides a working localStorage. This polyfill replaces localStorage on
|
||||||
|
// all supported versions with a standard Storage implementation backed by
|
||||||
|
// a Map, ensuring consistent behavior regardless of the Node.js version.
|
||||||
|
const storage = new Map<string, string>();
|
||||||
|
const storagePolyfill: Storage = {
|
||||||
|
get length() {
|
||||||
|
return storage.size;
|
||||||
|
},
|
||||||
|
clear() {
|
||||||
|
storage.clear();
|
||||||
|
},
|
||||||
|
key(index) {
|
||||||
|
return Array.from(storage.keys())[index] ?? null;
|
||||||
|
},
|
||||||
|
getItem(key) {
|
||||||
|
return storage.get(key) ?? null;
|
||||||
|
},
|
||||||
|
setItem(key, value) {
|
||||||
|
storage.set(key, value);
|
||||||
|
},
|
||||||
|
removeItem(key) {
|
||||||
|
storage.delete(key);
|
||||||
|
},
|
||||||
|
*[Symbol.iterator]() {
|
||||||
|
yield* storage.entries();
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
Object.defineProperty(window, "localStorage", {
|
||||||
|
value: storagePolyfill,
|
||||||
|
writable: true,
|
||||||
|
configurable: true,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
import { randomId, reseed } from "@excalidraw/common";
|
import { MIME_TYPES, randomId, reseed } from "@excalidraw/common";
|
||||||
|
|
||||||
import type { FileId } from "@excalidraw/element/types";
|
import type { FileId } from "@excalidraw/element/types";
|
||||||
|
|
||||||
@@ -17,18 +17,41 @@ import {
|
|||||||
} from "./fixtures/constants";
|
} from "./fixtures/constants";
|
||||||
import { INITIALIZED_IMAGE_PROPS } from "./helpers/constants";
|
import { INITIALIZED_IMAGE_PROPS } from "./helpers/constants";
|
||||||
|
|
||||||
|
import type { ExcalidrawProps } from "../types";
|
||||||
|
|
||||||
const { h } = window;
|
const { h } = window;
|
||||||
|
|
||||||
export const setupImageTest = async (
|
export const setupImageTest = async (
|
||||||
sizes: { width: number; height: number }[],
|
sizes: { width: number; height: number }[],
|
||||||
|
props?: ExcalidrawProps,
|
||||||
) => {
|
) => {
|
||||||
await render(<Excalidraw autoFocus={true} handleKeyboardGlobally={true} />);
|
await render(
|
||||||
|
<Excalidraw autoFocus={true} handleKeyboardGlobally={true} {...props} />,
|
||||||
|
);
|
||||||
|
|
||||||
h.state.height = 1000;
|
h.state.height = 1000;
|
||||||
|
|
||||||
mockMultipleHTMLImageElements(sizes.map((size) => [size.width, size.height]));
|
mockMultipleHTMLImageElements(sizes.map((size) => [size.width, size.height]));
|
||||||
};
|
};
|
||||||
|
|
||||||
|
describe("resizeImageFile", () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
vi.unstubAllGlobals();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("returns the original file when it already fits the max dimensions", async () => {
|
||||||
|
mockMultipleHTMLImageElements([[100, 100]]);
|
||||||
|
|
||||||
|
const imageFile = new File([new Uint8Array([1, 2, 3])], "image.png", {
|
||||||
|
type: MIME_TYPES.png,
|
||||||
|
});
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
blobModule.resizeImageFile(imageFile, { maxWidthOrHeight: 200 }),
|
||||||
|
).resolves.toBe(imageFile);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
describe("image insertion", () => {
|
describe("image insertion", () => {
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
vi.clearAllMocks();
|
vi.clearAllMocks();
|
||||||
@@ -112,4 +135,42 @@ describe("image insertion", () => {
|
|||||||
|
|
||||||
await assert();
|
await assert();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("passes host-configured max image dimensions to the resize helper", async () => {
|
||||||
|
await setupImageTest([DEER_IMAGE_DIMENSIONS], {
|
||||||
|
imageOptions: { maxWidthOrHeight: 2048 },
|
||||||
|
});
|
||||||
|
|
||||||
|
await API.drop([
|
||||||
|
{ kind: "file", file: await API.loadFile("./fixtures/deer.png") },
|
||||||
|
]);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(blobModule.resizeImageFile).toHaveBeenCalledWith(
|
||||||
|
expect.any(File),
|
||||||
|
{ maxWidthOrHeight: 2048 },
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("enforces host-configured max image file size", async () => {
|
||||||
|
await setupImageTest([DEER_IMAGE_DIMENSIONS], {
|
||||||
|
imageOptions: { maxFileSizeBytes: 1024 * 1024 },
|
||||||
|
});
|
||||||
|
|
||||||
|
await API.drop([
|
||||||
|
{
|
||||||
|
kind: "file",
|
||||||
|
file: new File([new Uint8Array(2 * 1024 * 1024)], "image.png", {
|
||||||
|
type: MIME_TYPES.png,
|
||||||
|
}),
|
||||||
|
},
|
||||||
|
]);
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(h.state.errorMessage).toBe(
|
||||||
|
"File is too big. Maximum allowed size is 1MB.",
|
||||||
|
);
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,8 +1,12 @@
|
|||||||
import React from "react";
|
import React from "react";
|
||||||
import { vi } from "vitest";
|
import { vi } from "vitest";
|
||||||
|
|
||||||
import { KEYS, ROUNDNESS, reseed } from "@excalidraw/common";
|
import { KEYS, ROUNDNESS, arrayToMap, reseed } from "@excalidraw/common";
|
||||||
import { getElementBounds, getElementLineSegments } from "@excalidraw/element";
|
import {
|
||||||
|
getElementBounds,
|
||||||
|
getElementLineSegments,
|
||||||
|
getElementsWithinSelection,
|
||||||
|
} from "@excalidraw/element";
|
||||||
import { pointFrom, pointRotateRads, type LocalPoint } from "@excalidraw/math";
|
import { pointFrom, pointRotateRads, type LocalPoint } from "@excalidraw/math";
|
||||||
|
|
||||||
import { SHAPES } from "../components/shapes";
|
import { SHAPES } from "../components/shapes";
|
||||||
@@ -269,6 +273,145 @@ describe("box-selection overlap mode", () => {
|
|||||||
assertSelectedElements([rect1.id]);
|
assertSelectedElements([rect1.id]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should select the whole group when overlapping one group member", () => {
|
||||||
|
const rect1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["A"],
|
||||||
|
});
|
||||||
|
const rect2 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 100,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["A"],
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([rect1, rect2]);
|
||||||
|
|
||||||
|
boxSelect(25, -20, 75, 70);
|
||||||
|
|
||||||
|
assertSelectedElements([rect1.id, rect2.id]);
|
||||||
|
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should return all group elements when overlapping one group member", () => {
|
||||||
|
const rect1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "rect1",
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["A"],
|
||||||
|
});
|
||||||
|
const rect2 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "rect2",
|
||||||
|
x: 100,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["A"],
|
||||||
|
});
|
||||||
|
const rect3 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "rect3",
|
||||||
|
x: 200,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
});
|
||||||
|
const selection = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 125,
|
||||||
|
y: -10,
|
||||||
|
width: 10,
|
||||||
|
height: 70,
|
||||||
|
});
|
||||||
|
const elements = [rect1, rect2, rect3];
|
||||||
|
|
||||||
|
expect(
|
||||||
|
getElementsWithinSelection(
|
||||||
|
elements,
|
||||||
|
selection,
|
||||||
|
arrayToMap([...elements, selection]),
|
||||||
|
false,
|
||||||
|
"overlap",
|
||||||
|
).map((element) => element.id),
|
||||||
|
).toEqual([rect1.id, rect2.id]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should retain nested and interleaved group element order", () => {
|
||||||
|
const outerNested1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "outerNested1",
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["inner", "outer"],
|
||||||
|
});
|
||||||
|
const other1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "other1",
|
||||||
|
x: 70,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["other"],
|
||||||
|
});
|
||||||
|
const outerOnly = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "outerOnly",
|
||||||
|
x: 140,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["outer"],
|
||||||
|
});
|
||||||
|
const other2 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "other2",
|
||||||
|
x: 210,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["other"],
|
||||||
|
});
|
||||||
|
const outerNested2 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "outerNested2",
|
||||||
|
x: 280,
|
||||||
|
y: 0,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["inner", "outer"],
|
||||||
|
});
|
||||||
|
const selection = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 295,
|
||||||
|
y: -10,
|
||||||
|
width: 10,
|
||||||
|
height: 70,
|
||||||
|
});
|
||||||
|
const elements = [outerNested1, other1, outerOnly, other2, outerNested2];
|
||||||
|
|
||||||
|
expect(
|
||||||
|
getElementsWithinSelection(
|
||||||
|
elements,
|
||||||
|
selection,
|
||||||
|
arrayToMap([...elements, selection]),
|
||||||
|
false,
|
||||||
|
"overlap",
|
||||||
|
).map((element) => element.id),
|
||||||
|
).toEqual([outerNested1.id, outerOnly.id, outerNested2.id]);
|
||||||
|
});
|
||||||
|
|
||||||
it("should not select a transparent rectangle when the selection box stays inside it", () => {
|
it("should not select a transparent rectangle when the selection box stays inside it", () => {
|
||||||
const rect1 = API.createElement({
|
const rect1 = API.createElement({
|
||||||
type: "rectangle",
|
type: "rectangle",
|
||||||
@@ -615,6 +758,32 @@ describe("box-selection overlap mode", () => {
|
|||||||
|
|
||||||
assertSelectedElements([]);
|
assertSelectedElements([]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should not select a framed element when selection only overlaps its clipped-out outline", () => {
|
||||||
|
const frame = API.createElement({
|
||||||
|
type: "frame",
|
||||||
|
x: 100,
|
||||||
|
y: 100,
|
||||||
|
width: 100,
|
||||||
|
height: 100,
|
||||||
|
});
|
||||||
|
const rect1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 50,
|
||||||
|
width: 200,
|
||||||
|
height: 200,
|
||||||
|
frameId: frame.id,
|
||||||
|
backgroundColor: "red",
|
||||||
|
fillStyle: "solid",
|
||||||
|
});
|
||||||
|
|
||||||
|
API.setElements([frame, rect1]);
|
||||||
|
|
||||||
|
boxSelect(40, 170, 70, 220);
|
||||||
|
|
||||||
|
assertSelectedElements([]);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe("inner box-selection", () => {
|
describe("inner box-selection", () => {
|
||||||
@@ -690,11 +859,175 @@ describe("inner box-selection", () => {
|
|||||||
mouse.moveTo(rect2.x + rect2.width + 10, rect2.y + rect2.height + 10);
|
mouse.moveTo(rect2.x + rect2.width + 10, rect2.y + rect2.height + 10);
|
||||||
mouse.up();
|
mouse.up();
|
||||||
|
|
||||||
|
assertSelectedElements([rect1.id]);
|
||||||
|
expect(h.state.selectedGroupIds).toEqual({});
|
||||||
|
});
|
||||||
|
|
||||||
|
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||||
|
mouse.downAt(40, 40);
|
||||||
|
mouse.move(-1000, -1000);
|
||||||
|
mouse.moveTo(rect3.x + rect3.width + 10, rect3.y + rect3.height + 10);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
assertSelectedElements([rect2.id, rect3.id]);
|
assertSelectedElements([rect2.id, rect3.id]);
|
||||||
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("does not select a nested outer group until all members are contained", async () => {
|
||||||
|
const innerRect1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["inner", "outer"],
|
||||||
|
});
|
||||||
|
const innerRect2 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 120,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["inner", "outer"],
|
||||||
|
});
|
||||||
|
const outerRect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 190,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["outer"],
|
||||||
|
});
|
||||||
|
API.setElements([innerRect1, innerRect2, outerRect]);
|
||||||
|
|
||||||
|
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||||
|
mouse.downAt(0, 0);
|
||||||
|
mouse.move(-1000, -1000);
|
||||||
|
mouse.moveTo(
|
||||||
|
innerRect2.x + innerRect2.width + 10,
|
||||||
|
innerRect2.y + innerRect2.height + 10,
|
||||||
|
);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
assertSelectedElements([]);
|
||||||
|
expect(h.state.selectedGroupIds).toEqual({});
|
||||||
|
});
|
||||||
|
|
||||||
|
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||||
|
mouse.downAt(0, 0);
|
||||||
|
mouse.move(-1000, -1000);
|
||||||
|
mouse.moveTo(
|
||||||
|
outerRect.x + outerRect.width + 10,
|
||||||
|
outerRect.y + outerRect.height + 10,
|
||||||
|
);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
assertSelectedElements([innerRect1.id, innerRect2.id, outerRect.id]);
|
||||||
|
expect(h.state.selectedGroupIds).toEqual({ outer: true });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it.skip("checks nested containment against the current editing depth", async () => {
|
||||||
|
const innerRect1 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 50,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["inner", "outer"],
|
||||||
|
});
|
||||||
|
const innerRect2 = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 120,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["inner", "outer"],
|
||||||
|
});
|
||||||
|
const outerRect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 190,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["outer"],
|
||||||
|
});
|
||||||
|
const selection = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 40,
|
||||||
|
y: 40,
|
||||||
|
width: 140,
|
||||||
|
height: 70,
|
||||||
|
});
|
||||||
|
const elements = [innerRect1, innerRect2, outerRect];
|
||||||
|
const elementsMap = arrayToMap([...elements, selection]);
|
||||||
|
|
||||||
|
expect(
|
||||||
|
getElementsWithinSelection(
|
||||||
|
elements,
|
||||||
|
selection,
|
||||||
|
elementsMap,
|
||||||
|
false,
|
||||||
|
"contain",
|
||||||
|
).map((element) => element.id),
|
||||||
|
).toEqual([]);
|
||||||
|
|
||||||
|
expect(
|
||||||
|
getElementsWithinSelection(
|
||||||
|
elements,
|
||||||
|
selection,
|
||||||
|
elementsMap,
|
||||||
|
false,
|
||||||
|
"contain",
|
||||||
|
// "outer", /* editingGroupId - add as param once we implement nested group handling */
|
||||||
|
).map((element) => element.id),
|
||||||
|
).toEqual([innerRect1.id, innerRect2.id]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("ignores grouped bound text when checking box-selection containment", async () => {
|
||||||
|
const container = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
id: "container",
|
||||||
|
x: 50,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["A"],
|
||||||
|
boundElements: [{ type: "text", id: "bound-text" }],
|
||||||
|
});
|
||||||
|
const boundText = API.createElement({
|
||||||
|
type: "text",
|
||||||
|
id: "bound-text",
|
||||||
|
x: 50,
|
||||||
|
y: 50,
|
||||||
|
width: 50,
|
||||||
|
height: 20,
|
||||||
|
containerId: container.id,
|
||||||
|
groupIds: ["A"],
|
||||||
|
});
|
||||||
|
const rect = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 150,
|
||||||
|
y: 150,
|
||||||
|
width: 50,
|
||||||
|
height: 50,
|
||||||
|
groupIds: ["A"],
|
||||||
|
});
|
||||||
|
API.setElements([container, boundText, rect]);
|
||||||
|
|
||||||
|
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||||
|
mouse.downAt(40, 40);
|
||||||
|
mouse.move(-1000, -1000);
|
||||||
|
mouse.moveTo(rect.x + rect.width + 10, rect.y + rect.height + 10);
|
||||||
|
mouse.up();
|
||||||
|
|
||||||
|
expect(h.state.selectedElementIds[container.id]).toBe(true);
|
||||||
|
expect(h.state.selectedElementIds[rect.id]).toBe(true);
|
||||||
|
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
it("selecting & deselecting grouped elements visually nested inside another", async () => {
|
it("selecting & deselecting grouped elements visually nested inside another", async () => {
|
||||||
const rect1 = API.createElement({
|
const rect1 = API.createElement({
|
||||||
type: "rectangle",
|
type: "rectangle",
|
||||||
@@ -725,7 +1058,7 @@ describe("inner box-selection", () => {
|
|||||||
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
Keyboard.withModifierKeys({ ctrl: true }, () => {
|
||||||
mouse.downAt(rect2.x - 20, rect2.y - 20);
|
mouse.downAt(rect2.x - 20, rect2.y - 20);
|
||||||
mouse.move(-1000, -1000);
|
mouse.move(-1000, -1000);
|
||||||
mouse.moveTo(rect2.x + rect2.width + 10, rect2.y + rect2.height + 10);
|
mouse.moveTo(rect3.x + rect3.width + 10, rect3.y + rect3.height + 10);
|
||||||
assertSelectedElements([rect2.id, rect3.id]);
|
assertSelectedElements([rect2.id, rect3.id]);
|
||||||
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
expect(h.state.selectedGroupIds).toEqual({ A: true });
|
||||||
mouse.moveTo(rect2.x - 10, rect2.y - 10);
|
mouse.moveTo(rect2.x - 10, rect2.y - 10);
|
||||||
|
|||||||
@@ -4,10 +4,12 @@ import { resolvablePromise } from "@excalidraw/common";
|
|||||||
|
|
||||||
import { Excalidraw } from "../index";
|
import { Excalidraw } from "../index";
|
||||||
|
|
||||||
|
import { getToolbarTools } from "../components/shapes";
|
||||||
|
|
||||||
import { Pointer } from "./helpers/ui";
|
import { Pointer } from "./helpers/ui";
|
||||||
import { act, render } from "./test-utils";
|
import { act, render } from "./test-utils";
|
||||||
|
|
||||||
import type { ExcalidrawImperativeAPI } from "../types";
|
import type { AppClassProperties, ExcalidrawImperativeAPI } from "../types";
|
||||||
|
|
||||||
describe("setActiveTool()", () => {
|
describe("setActiveTool()", () => {
|
||||||
const h = window.h;
|
const h = window.h;
|
||||||
@@ -66,3 +68,27 @@ describe("setActiveTool()", () => {
|
|||||||
expect(h.state.activeTool.customType).toBe("comment");
|
expect(h.state.activeTool.customType).toBe("comment");
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
describe("getToolbarTools()", () => {
|
||||||
|
const getToolValues = (preferredSelectionTool: "selection" | "lasso") =>
|
||||||
|
getToolbarTools({
|
||||||
|
state: {
|
||||||
|
preferredSelectionTool: {
|
||||||
|
type: preferredSelectionTool,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
} as AppClassProperties).map((tool) => tool.value);
|
||||||
|
|
||||||
|
it("does not include lasso when selection is preferred", () => {
|
||||||
|
const toolValues = getToolValues("selection");
|
||||||
|
|
||||||
|
expect(toolValues.filter((value) => value === "selection")).toHaveLength(1);
|
||||||
|
expect(toolValues.filter((value) => value === "lasso")).toHaveLength(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("replaces selection with lasso when lasso is preferred", () => {
|
||||||
|
const toolValues = getToolValues("lasso");
|
||||||
|
|
||||||
|
expect(toolValues.filter((value) => value === "lasso")).toHaveLength(1);
|
||||||
|
expect(toolValues.filter((value) => value === "selection")).toHaveLength(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -315,7 +315,10 @@ export interface AppState {
|
|||||||
bindingPreference: "enabled" | "disabled";
|
bindingPreference: "enabled" | "disabled";
|
||||||
/** user preference whether arrow snap to midpoints while binding */
|
/** user preference whether arrow snap to midpoints while binding */
|
||||||
isMidpointSnappingEnabled: boolean;
|
isMidpointSnappingEnabled: boolean;
|
||||||
startBoundElement: NonDeleted<ExcalidrawBindableElement> | null;
|
/**
|
||||||
|
* The bindable element the UI highlights for the user when an arrow is
|
||||||
|
* dragged or otherwise its endpoint being close to said element.
|
||||||
|
*/
|
||||||
suggestedBinding: {
|
suggestedBinding: {
|
||||||
element: NonDeleted<ExcalidrawBindableElement>;
|
element: NonDeleted<ExcalidrawBindableElement>;
|
||||||
midPoint?: GlobalPoint;
|
midPoint?: GlobalPoint;
|
||||||
@@ -347,8 +350,11 @@ export interface AppState {
|
|||||||
type: "selection" | "lasso";
|
type: "selection" | "lasso";
|
||||||
initialized: boolean;
|
initialized: boolean;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Pen handling
|
||||||
penMode: boolean;
|
penMode: boolean;
|
||||||
penDetected: boolean;
|
penDetected: boolean;
|
||||||
|
|
||||||
exportBackground: boolean;
|
exportBackground: boolean;
|
||||||
exportEmbedScene: boolean;
|
exportEmbedScene: boolean;
|
||||||
exportWithDarkMode: boolean;
|
exportWithDarkMode: boolean;
|
||||||
@@ -473,6 +479,9 @@ export interface AppState {
|
|||||||
// as elements are unlocked, we remove the groupId from the elements
|
// as elements are unlocked, we remove the groupId from the elements
|
||||||
// and also remove groupId from this map
|
// and also remove groupId from this map
|
||||||
lockedMultiSelections: { [groupId: string]: true };
|
lockedMultiSelections: { [groupId: string]: true };
|
||||||
|
// Stores the current bind mode which is detemined at various points during
|
||||||
|
// a drag operation (like pointer position vs bindable element) but needed
|
||||||
|
// globally for calculating the binding strategy
|
||||||
bindMode: BindMode;
|
bindMode: BindMode;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -488,10 +497,7 @@ export type SearchMatch = {
|
|||||||
}[];
|
}[];
|
||||||
};
|
};
|
||||||
|
|
||||||
export type UIAppState = Omit<
|
export type UIAppState = Omit<AppState, "cursorButton" | "scrollX" | "scrollY">;
|
||||||
AppState,
|
|
||||||
"startBoundElement" | "cursorButton" | "scrollX" | "scrollY"
|
|
||||||
>;
|
|
||||||
|
|
||||||
export type NormalizedZoomValue = number & { _brand: "normalizedZoom" };
|
export type NormalizedZoomValue = number & { _brand: "normalizedZoom" };
|
||||||
|
|
||||||
@@ -640,6 +646,10 @@ export interface ExcalidrawProps {
|
|||||||
appState: UIAppState,
|
appState: UIAppState,
|
||||||
) => JSX.Element;
|
) => JSX.Element;
|
||||||
UIOptions?: Partial<UIOptions>;
|
UIOptions?: Partial<UIOptions>;
|
||||||
|
/**
|
||||||
|
* dimensions and size constraints for inserted images
|
||||||
|
*/
|
||||||
|
imageOptions?: ImageOptions;
|
||||||
detectScroll?: boolean;
|
detectScroll?: boolean;
|
||||||
handleKeyboardGlobally?: boolean;
|
handleKeyboardGlobally?: boolean;
|
||||||
onLibraryChange?: (libraryItems: LibraryItems) => void | Promise<any>;
|
onLibraryChange?: (libraryItems: LibraryItems) => void | Promise<any>;
|
||||||
@@ -726,6 +736,11 @@ export type ExportOpts = {
|
|||||||
) => JSX.Element;
|
) => JSX.Element;
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export type ImageOptions = Partial<{
|
||||||
|
maxWidthOrHeight: number;
|
||||||
|
maxFileSizeBytes: number;
|
||||||
|
}>;
|
||||||
|
|
||||||
// NOTE at the moment, if action name corresponds to canvasAction prop, its
|
// NOTE at the moment, if action name corresponds to canvasAction prop, its
|
||||||
// truthiness value will determine whether the action is rendered or not
|
// truthiness value will determine whether the action is rendered or not
|
||||||
// (see manager renderAction). We also override canvasAction values in
|
// (see manager renderAction). We also override canvasAction values in
|
||||||
@@ -767,6 +782,7 @@ export type AppProps = Merge<
|
|||||||
canvasActions: Required<CanvasActions> & { export: ExportOpts };
|
canvasActions: Required<CanvasActions> & { export: ExportOpts };
|
||||||
}
|
}
|
||||||
>;
|
>;
|
||||||
|
imageOptions: Required<ImageOptions>;
|
||||||
detectScroll: boolean;
|
detectScroll: boolean;
|
||||||
handleKeyboardGlobally: boolean;
|
handleKeyboardGlobally: boolean;
|
||||||
isCollaborating: boolean;
|
isCollaborating: boolean;
|
||||||
@@ -871,8 +887,13 @@ export type PointerDownState = Readonly<{
|
|||||||
// Whether selected element(s) were duplicated, might change during the
|
// Whether selected element(s) were duplicated, might change during the
|
||||||
// pointer interaction
|
// pointer interaction
|
||||||
hasBeenDuplicated: boolean;
|
hasBeenDuplicated: boolean;
|
||||||
|
// Whether the pointer is hitting the common bounding box of selected
|
||||||
|
// elements, which is useful for discriminating between selecitng
|
||||||
|
// the entire selection vs a specific element
|
||||||
hasHitCommonBoundingBoxOfSelectedElements: boolean;
|
hasHitCommonBoundingBoxOfSelectedElements: boolean;
|
||||||
};
|
};
|
||||||
|
// This is determined on the initial pointer down event to
|
||||||
|
// set various interaction modalities
|
||||||
withCmdOrCtrl: boolean;
|
withCmdOrCtrl: boolean;
|
||||||
drag: {
|
drag: {
|
||||||
// Might change during the pointer interaction
|
// Might change during the pointer interaction
|
||||||
@@ -901,6 +922,7 @@ export type PointerDownState = Readonly<{
|
|||||||
onKeyUp: null | ((event: KeyboardEvent) => void);
|
onKeyUp: null | ((event: KeyboardEvent) => void);
|
||||||
};
|
};
|
||||||
boxSelection: {
|
boxSelection: {
|
||||||
|
// If the box selection tool is activated on pointer down
|
||||||
hasOccurred: boolean;
|
hasOccurred: boolean;
|
||||||
};
|
};
|
||||||
}>;
|
}>;
|
||||||
|
|||||||
@@ -769,6 +769,63 @@ describe("textWysiwyg", () => {
|
|||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("should not add bound text to a frame when its container is not a frame child", async () => {
|
||||||
|
const frame = API.createElement({
|
||||||
|
type: "frame",
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 200,
|
||||||
|
height: 200,
|
||||||
|
});
|
||||||
|
const rectangle = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 20,
|
||||||
|
width: 90,
|
||||||
|
height: 75,
|
||||||
|
backgroundColor: "red",
|
||||||
|
});
|
||||||
|
API.setElements([frame, rectangle]);
|
||||||
|
|
||||||
|
mouse.doubleClickAt(rectangle.x + 10, rectangle.y + 10);
|
||||||
|
|
||||||
|
const text = h.elements[2] as ExcalidrawTextElementWithContainer;
|
||||||
|
expect(text.type).toBe("text");
|
||||||
|
expect(text.containerId).toBe(rectangle.id);
|
||||||
|
expect(text.frameId).toBe(null);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("should bind text to a frame child container when single clicking its center", async () => {
|
||||||
|
const frame = API.createElement({
|
||||||
|
type: "frame",
|
||||||
|
x: 0,
|
||||||
|
y: 0,
|
||||||
|
width: 200,
|
||||||
|
height: 200,
|
||||||
|
});
|
||||||
|
const rectangle = API.createElement({
|
||||||
|
type: "rectangle",
|
||||||
|
x: 10,
|
||||||
|
y: 20,
|
||||||
|
width: 90,
|
||||||
|
height: 75,
|
||||||
|
backgroundColor: "red",
|
||||||
|
frameId: frame.id,
|
||||||
|
});
|
||||||
|
API.setElements([rectangle, frame]);
|
||||||
|
|
||||||
|
UI.clickTool("text");
|
||||||
|
mouse.clickAt(
|
||||||
|
rectangle.x + rectangle.width / 2,
|
||||||
|
rectangle.y + rectangle.height / 2,
|
||||||
|
);
|
||||||
|
|
||||||
|
const text = h.elements[1] as ExcalidrawTextElementWithContainer;
|
||||||
|
expect(text.type).toBe("text");
|
||||||
|
expect(text.containerId).toBe(rectangle.id);
|
||||||
|
expect(text.frameId).toBe(frame.id);
|
||||||
|
});
|
||||||
|
|
||||||
it("should set the text element angle to same as container angle when binding to rotated container", async () => {
|
it("should set the text element angle to same as container angle when binding to rotated container", async () => {
|
||||||
const rectangle = API.createElement({
|
const rectangle = API.createElement({
|
||||||
type: "rectangle",
|
type: "rectangle",
|
||||||
|
|||||||
@@ -0,0 +1,45 @@
|
|||||||
|
{
|
||||||
|
"name": "@excalidraw/fractional-indexing",
|
||||||
|
"version": "3.3.0",
|
||||||
|
"description": "Provides functions for generating ordering strings",
|
||||||
|
"type": "module",
|
||||||
|
"types": "./dist/types/fractional-indexing/src/index.d.ts",
|
||||||
|
"main": "./dist/prod/index.js",
|
||||||
|
"module": "./dist/prod/index.js",
|
||||||
|
"engines": {
|
||||||
|
"node": "^14.13.1 || >=16.0.0"
|
||||||
|
},
|
||||||
|
"scripts": {
|
||||||
|
"gen:types": "rimraf types && tsc",
|
||||||
|
"build:esm": "rimraf dist && node ../../scripts/buildBase.js && yarn gen:types"
|
||||||
|
},
|
||||||
|
"keywords": [
|
||||||
|
"fractional",
|
||||||
|
"indexing",
|
||||||
|
"ordering",
|
||||||
|
"order"
|
||||||
|
],
|
||||||
|
"homepage": "https://github.com/rocicorp/fractional-indexing#readme",
|
||||||
|
"bugs": "https://github.com/excalidraw/excalidraw/issues",
|
||||||
|
"repository": "https://github.com/excalidraw/excalidraw",
|
||||||
|
"author": "arv@rocicorp.dev",
|
||||||
|
"license": "CC0-1.0",
|
||||||
|
"devDependencies": {
|
||||||
|
"prettier": "^2.6.0",
|
||||||
|
"typescript": "5.9.3"
|
||||||
|
},
|
||||||
|
"exports": {
|
||||||
|
".": {
|
||||||
|
"types": "./dist/types/fractional-indexing/src/index.d.ts",
|
||||||
|
"development": "./dist/dev/index.js",
|
||||||
|
"production": "./dist/prod/index.js",
|
||||||
|
"default": "./dist/prod/index.js"
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"publishConfig": {
|
||||||
|
"access": "public"
|
||||||
|
},
|
||||||
|
"files": [
|
||||||
|
"dist/*"
|
||||||
|
]
|
||||||
|
}
|
||||||
@@ -0,0 +1,322 @@
|
|||||||
|
// Vendored from https://www.npmjs.com/package/fractional-indexing
|
||||||
|
// License: CC0 (no rights reserved).
|
||||||
|
// This is based on https://observablehq.com/@dgreensp/implementing-fractional-indexing
|
||||||
|
|
||||||
|
export const BASE_62_DIGITS =
|
||||||
|
"0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
|
||||||
|
|
||||||
|
// `a` may be empty string, `b` is null or non-empty string.
|
||||||
|
// `a < b` lexicographically if `b` is non-null.
|
||||||
|
// no trailing zeros allowed.
|
||||||
|
// digits is a string such as '0123456789' for base 10. Digits must be in
|
||||||
|
// ascending character code order!
|
||||||
|
/**
|
||||||
|
* @param {string} a
|
||||||
|
* @param {string | null | undefined} b
|
||||||
|
* @param {string} digits
|
||||||
|
* @returns {string}
|
||||||
|
*/
|
||||||
|
function midpoint(
|
||||||
|
a: string,
|
||||||
|
b: string | null | undefined,
|
||||||
|
digits: string,
|
||||||
|
): string {
|
||||||
|
const zero = digits[0];
|
||||||
|
if (b != null && a >= b) {
|
||||||
|
throw new Error(`${a} >= ${b}`);
|
||||||
|
}
|
||||||
|
if (a.slice(-1) === zero || (b && b.slice(-1) === zero)) {
|
||||||
|
throw new Error("trailing zero");
|
||||||
|
}
|
||||||
|
if (b) {
|
||||||
|
// remove longest common prefix. pad `a` with 0s as we
|
||||||
|
// go. note that we don't need to pad `b`, because it can't
|
||||||
|
// end before `a` while traversing the common prefix.
|
||||||
|
let n = 0;
|
||||||
|
while ((a[n] || zero) === b[n]) {
|
||||||
|
n++;
|
||||||
|
}
|
||||||
|
if (n > 0) {
|
||||||
|
return b.slice(0, n) + midpoint(a.slice(n), b.slice(n), digits);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// first digits (or lack of digit) are different
|
||||||
|
const digitA = a ? digits.indexOf(a[0]) : 0;
|
||||||
|
const digitB = b != null ? digits.indexOf(b[0]) : digits.length;
|
||||||
|
if (digitB - digitA > 1) {
|
||||||
|
const midDigit = Math.round(0.5 * (digitA + digitB));
|
||||||
|
return digits[midDigit];
|
||||||
|
}
|
||||||
|
// first digits are consecutive
|
||||||
|
if (b && b.length > 1) {
|
||||||
|
return b.slice(0, 1);
|
||||||
|
}
|
||||||
|
|
||||||
|
// `b` is null or has length 1 (a single digit).
|
||||||
|
// the first digit of `a` is the previous digit to `b`,
|
||||||
|
// or 9 if `b` is null.
|
||||||
|
// given, for example, midpoint('49', '5'), return
|
||||||
|
// '4' + midpoint('9', null), which will become
|
||||||
|
// '4' + '9' + midpoint('', null), which is '495'
|
||||||
|
return digits[digitA] + midpoint(a.slice(1), null, digits);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param {string} int
|
||||||
|
* @return {void}
|
||||||
|
*/
|
||||||
|
|
||||||
|
function validateInteger(int: string): void {
|
||||||
|
if (int.length !== getIntegerLength(int[0])) {
|
||||||
|
throw new Error(`invalid integer part of order key: ${int}`);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param {string} head
|
||||||
|
* @return {number}
|
||||||
|
*/
|
||||||
|
|
||||||
|
function getIntegerLength(head: string): number {
|
||||||
|
if (head >= "a" && head <= "z") {
|
||||||
|
return head.charCodeAt(0) - "a".charCodeAt(0) + 2;
|
||||||
|
} else if (head >= "A" && head <= "Z") {
|
||||||
|
return "Z".charCodeAt(0) - head.charCodeAt(0) + 2;
|
||||||
|
}
|
||||||
|
|
||||||
|
throw new Error(`invalid order key head: ${head}`);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param {string} key
|
||||||
|
* @return {string}
|
||||||
|
*/
|
||||||
|
|
||||||
|
function getIntegerPart(key: string): string {
|
||||||
|
const integerPartLength = getIntegerLength(key[0]);
|
||||||
|
|
||||||
|
if (integerPartLength > key.length) {
|
||||||
|
throw new Error(`invalid order key: ${key}`);
|
||||||
|
}
|
||||||
|
return key.slice(0, integerPartLength);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @param {string} key
|
||||||
|
* @param {string} digits
|
||||||
|
* @return {void}
|
||||||
|
*/
|
||||||
|
export function validateOrderKey(
|
||||||
|
key: string,
|
||||||
|
digits: string = BASE_62_DIGITS,
|
||||||
|
): void {
|
||||||
|
const validChars = key.split("").every((char) => digits.includes(char));
|
||||||
|
if (key === `A${digits[0].repeat(26)}` || !validChars) {
|
||||||
|
throw new Error(`invalid order key: ${key}`);
|
||||||
|
}
|
||||||
|
// getIntegerPart will throw if the first character is bad,
|
||||||
|
// or the key is too short. we'd call it to check these things
|
||||||
|
// even if we didn't need the result
|
||||||
|
const i = getIntegerPart(key);
|
||||||
|
const f = key.slice(i.length);
|
||||||
|
if (f.slice(-1) === digits[0]) {
|
||||||
|
throw new Error(`invalid order key: ${key}`);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// note that this may return null, as there is a largest integer
|
||||||
|
/**
|
||||||
|
* @param {string} x
|
||||||
|
* @param {string} digits
|
||||||
|
* @return {string | null}
|
||||||
|
*/
|
||||||
|
function incrementInteger(x: string, digits: string): string | null {
|
||||||
|
validateInteger(x);
|
||||||
|
const [head, ...digs] = x.split("");
|
||||||
|
let carry = true;
|
||||||
|
for (let i = digs.length - 1; carry && i >= 0; i--) {
|
||||||
|
const d = digits.indexOf(digs[i]) + 1;
|
||||||
|
if (d === digits.length) {
|
||||||
|
digs[i] = digits[0];
|
||||||
|
} else {
|
||||||
|
digs[i] = digits[d];
|
||||||
|
carry = false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (carry) {
|
||||||
|
if (head === "Z") {
|
||||||
|
return `a${digits[0]}`;
|
||||||
|
}
|
||||||
|
if (head === "z") {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
const h = String.fromCharCode(head.charCodeAt(0) + 1);
|
||||||
|
if (h > "a") {
|
||||||
|
digs.push(digits[0]);
|
||||||
|
} else {
|
||||||
|
digs.pop();
|
||||||
|
}
|
||||||
|
return h + digs.join("");
|
||||||
|
}
|
||||||
|
return head + digs.join("");
|
||||||
|
}
|
||||||
|
|
||||||
|
// note that this may return null, as there is a smallest integer
|
||||||
|
/**
|
||||||
|
* @param {string} x
|
||||||
|
* @param {string} digits
|
||||||
|
* @return {string | null}
|
||||||
|
*/
|
||||||
|
function decrementInteger(x: string, digits: string): string | null {
|
||||||
|
validateInteger(x);
|
||||||
|
const [head, ...digs] = x.split("");
|
||||||
|
let borrow = true;
|
||||||
|
for (let i = digs.length - 1; borrow && i >= 0; i--) {
|
||||||
|
const d = digits.indexOf(digs[i]) - 1;
|
||||||
|
if (d === -1) {
|
||||||
|
digs[i] = digits.slice(-1);
|
||||||
|
} else {
|
||||||
|
digs[i] = digits[d];
|
||||||
|
borrow = false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if (borrow) {
|
||||||
|
if (head === "a") {
|
||||||
|
return `Z${digits.slice(-1)}`;
|
||||||
|
}
|
||||||
|
if (head === "A") {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
const h = String.fromCharCode(head.charCodeAt(0) - 1);
|
||||||
|
if (h < "Z") {
|
||||||
|
digs.push(digits.slice(-1));
|
||||||
|
} else {
|
||||||
|
digs.pop();
|
||||||
|
}
|
||||||
|
return h + digs.join("");
|
||||||
|
}
|
||||||
|
return head + digs.join("");
|
||||||
|
}
|
||||||
|
|
||||||
|
// `a` is an order key or null (START).
|
||||||
|
// `b` is an order key or null (END).
|
||||||
|
// `a < b` lexicographically if both are non-null.
|
||||||
|
// digits is a string such as '0123456789' for base 10. Digits must be in
|
||||||
|
// ascending character code order!
|
||||||
|
/**
|
||||||
|
* @param {string | null | undefined} a
|
||||||
|
* @param {string | null | undefined} b
|
||||||
|
* @param {string=} digits
|
||||||
|
* @return {string}
|
||||||
|
*/
|
||||||
|
export function generateKeyBetween(
|
||||||
|
a: string | null | undefined,
|
||||||
|
b: string | null | undefined,
|
||||||
|
digits = BASE_62_DIGITS,
|
||||||
|
): string {
|
||||||
|
if (a != null) {
|
||||||
|
validateOrderKey(a, digits);
|
||||||
|
}
|
||||||
|
if (b != null) {
|
||||||
|
validateOrderKey(b, digits);
|
||||||
|
}
|
||||||
|
if (a != null && b != null && a >= b) {
|
||||||
|
throw new Error(`${a} >= ${b}`);
|
||||||
|
}
|
||||||
|
if (a == null) {
|
||||||
|
if (b == null) {
|
||||||
|
return `a${digits[0]}`;
|
||||||
|
}
|
||||||
|
|
||||||
|
const ib = getIntegerPart(b);
|
||||||
|
const fb = b.slice(ib.length);
|
||||||
|
if (ib === `A${digits[0].repeat(26)}`) {
|
||||||
|
return ib + midpoint("", fb, digits);
|
||||||
|
}
|
||||||
|
if (ib < b) {
|
||||||
|
return ib;
|
||||||
|
}
|
||||||
|
const res = decrementInteger(ib, digits);
|
||||||
|
if (res == null) {
|
||||||
|
throw new Error("cannot decrement any more");
|
||||||
|
}
|
||||||
|
return res;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (b == null) {
|
||||||
|
const ia = getIntegerPart(a);
|
||||||
|
const fa = a.slice(ia.length);
|
||||||
|
const i = incrementInteger(ia, digits);
|
||||||
|
return i == null ? ia + midpoint(fa, null, digits) : i;
|
||||||
|
}
|
||||||
|
|
||||||
|
const ia = getIntegerPart(a);
|
||||||
|
const fa = a.slice(ia.length);
|
||||||
|
const ib = getIntegerPart(b);
|
||||||
|
const fb = b.slice(ib.length);
|
||||||
|
if (ia === ib) {
|
||||||
|
return ia + midpoint(fa, fb, digits);
|
||||||
|
}
|
||||||
|
const i = incrementInteger(ia, digits);
|
||||||
|
if (i == null) {
|
||||||
|
throw new Error("cannot increment any more");
|
||||||
|
}
|
||||||
|
if (i < b) {
|
||||||
|
return i;
|
||||||
|
}
|
||||||
|
return ia + midpoint(fa, null, digits);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* same preconditions as generateKeysBetween.
|
||||||
|
* n >= 0.
|
||||||
|
* Returns an array of n distinct keys in sorted order.
|
||||||
|
* If a and b are both null, returns [a0, a1, ...]
|
||||||
|
* If one or the other is null, returns consecutive "integer"
|
||||||
|
* keys. Otherwise, returns relatively short keys between
|
||||||
|
* a and b.
|
||||||
|
* @param {string | null | undefined} a
|
||||||
|
* @param {string | null | undefined} b
|
||||||
|
* @param {number} n
|
||||||
|
* @param {string} digits
|
||||||
|
* @return {string[]}
|
||||||
|
*/
|
||||||
|
export function generateNKeysBetween(
|
||||||
|
a: string | null | undefined,
|
||||||
|
b: string | null | undefined,
|
||||||
|
n: number,
|
||||||
|
digits = BASE_62_DIGITS,
|
||||||
|
): string[] {
|
||||||
|
if (n === 0) {
|
||||||
|
return [];
|
||||||
|
}
|
||||||
|
if (n === 1) {
|
||||||
|
return [generateKeyBetween(a, b, digits)];
|
||||||
|
}
|
||||||
|
if (b == null) {
|
||||||
|
let c = generateKeyBetween(a, b, digits);
|
||||||
|
const result = [c];
|
||||||
|
for (let i = 0; i < n - 1; i++) {
|
||||||
|
c = generateKeyBetween(c, b, digits);
|
||||||
|
result.push(c);
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
if (a == null) {
|
||||||
|
let c = generateKeyBetween(a, b, digits);
|
||||||
|
const result = [c];
|
||||||
|
for (let i = 0; i < n - 1; i++) {
|
||||||
|
c = generateKeyBetween(a, c, digits);
|
||||||
|
result.push(c);
|
||||||
|
}
|
||||||
|
result.reverse();
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
const mid = Math.floor(n / 2);
|
||||||
|
const c = generateKeyBetween(a, b, digits);
|
||||||
|
return [
|
||||||
|
...generateNKeysBetween(a, c, mid, digits),
|
||||||
|
c,
|
||||||
|
...generateNKeysBetween(c, b, n - mid - 1, digits),
|
||||||
|
];
|
||||||
|
}
|
||||||
@@ -0,0 +1,8 @@
|
|||||||
|
{
|
||||||
|
"extends": "../tsconfig.base.json",
|
||||||
|
"compilerOptions": {
|
||||||
|
"outDir": "./dist/types"
|
||||||
|
},
|
||||||
|
"include": ["src/**/*", "global.d.ts"],
|
||||||
|
"exclude": ["**/*.test.*", "tests", "types", "examples", "dist"]
|
||||||
|
}
|
||||||
@@ -1,5 +1,3 @@
|
|||||||
export const PRECISION = 10e-5;
|
|
||||||
|
|
||||||
// Legendre-Gauss abscissae (x values) and weights for n=24
|
// Legendre-Gauss abscissae (x values) and weights for n=24
|
||||||
// Refeerence: https://pomax.github.io/bezierinfo/legendre-gauss.html
|
// Refeerence: https://pomax.github.io/bezierinfo/legendre-gauss.html
|
||||||
export const LegendreGaussN24TValues = [
|
export const LegendreGaussN24TValues = [
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
import { degreesToRadians } from "./angle";
|
import { degreesToRadians } from "./angle";
|
||||||
import { PRECISION } from "./utils";
|
import { isFiniteNumber, PRECISION } from "./utils";
|
||||||
import { vectorFromPoint, vectorScale } from "./vector";
|
import { vectorFromPoint, vectorScale } from "./vector";
|
||||||
|
|
||||||
import type {
|
import type {
|
||||||
@@ -253,3 +253,12 @@ export const isPointWithinBounds = <P extends GlobalPoint | LocalPoint>(
|
|||||||
q[1] >= Math.min(p[1], r[1])
|
q[1] >= Math.min(p[1], r[1])
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
export const isValidPoint = (point: unknown): point is LocalPoint => {
|
||||||
|
return (
|
||||||
|
Array.isArray(point) &&
|
||||||
|
point.length === 2 &&
|
||||||
|
isFiniteNumber(point[0]) &&
|
||||||
|
isFiniteNumber(point[1])
|
||||||
|
);
|
||||||
|
};
|
||||||
|
|||||||
@@ -20,7 +20,9 @@
|
|||||||
"@excalidraw/math": ["./math/src/index.ts"],
|
"@excalidraw/math": ["./math/src/index.ts"],
|
||||||
"@excalidraw/math/*": ["./math/src/*"],
|
"@excalidraw/math/*": ["./math/src/*"],
|
||||||
"@excalidraw/utils": ["./utils/src/index.ts"],
|
"@excalidraw/utils": ["./utils/src/index.ts"],
|
||||||
"@excalidraw/utils/*": ["./utils/src/*"]
|
"@excalidraw/utils/*": ["./utils/src/*"],
|
||||||
|
"@excalidraw/fractional-indexing": ["./fractional-indexing/src/index.ts"],
|
||||||
|
"@excalidraw/fractional-indexing/*": ["./fractional-indexing/src/*"]
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -99,7 +99,6 @@ exports[`exportToSvg > with default arguments 1`] = `
|
|||||||
"showHyperlinkPopup": false,
|
"showHyperlinkPopup": false,
|
||||||
"showWelcomeScreen": false,
|
"showWelcomeScreen": false,
|
||||||
"snapLines": [],
|
"snapLines": [],
|
||||||
"startBoundElement": null,
|
|
||||||
"stats": {
|
"stats": {
|
||||||
"open": false,
|
"open": false,
|
||||||
"panels": 3,
|
"panels": 3,
|
||||||
|
|||||||
@@ -13,7 +13,12 @@ const getConfig = (outdir) => ({
|
|||||||
alias: {
|
alias: {
|
||||||
"@excalidraw/utils": path.resolve(__dirname, "../packages/utils/src"),
|
"@excalidraw/utils": path.resolve(__dirname, "../packages/utils/src"),
|
||||||
},
|
},
|
||||||
external: ["@excalidraw/common", "@excalidraw/element", "@excalidraw/math"],
|
external: [
|
||||||
|
"@excalidraw/common",
|
||||||
|
"@excalidraw/element",
|
||||||
|
"@excalidraw/math",
|
||||||
|
"@excalidraw/fractional-indexing",
|
||||||
|
],
|
||||||
});
|
});
|
||||||
|
|
||||||
function buildDev(config) {
|
function buildDev(config) {
|
||||||
|
|||||||
@@ -74,7 +74,12 @@ const getConfig = (outdir) => ({
|
|||||||
alias: {
|
alias: {
|
||||||
"@excalidraw/utils": path.resolve(__dirname, "../packages/utils/src"),
|
"@excalidraw/utils": path.resolve(__dirname, "../packages/utils/src"),
|
||||||
},
|
},
|
||||||
external: ["@excalidraw/common", "@excalidraw/element", "@excalidraw/math"],
|
external: [
|
||||||
|
"@excalidraw/common",
|
||||||
|
"@excalidraw/element",
|
||||||
|
"@excalidraw/math",
|
||||||
|
"@excalidraw/fractional-indexing",
|
||||||
|
],
|
||||||
loader: {
|
loader: {
|
||||||
".woff2": "file",
|
".woff2": "file",
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -18,6 +18,10 @@ const getConfig = (outdir) => ({
|
|||||||
"@excalidraw/element": path.resolve(__dirname, "../packages/element/src"),
|
"@excalidraw/element": path.resolve(__dirname, "../packages/element/src"),
|
||||||
"@excalidraw/excalidraw": path.resolve(__dirname, "../packages/excalidraw"),
|
"@excalidraw/excalidraw": path.resolve(__dirname, "../packages/excalidraw"),
|
||||||
"@excalidraw/math": path.resolve(__dirname, "../packages/math/src"),
|
"@excalidraw/math": path.resolve(__dirname, "../packages/math/src"),
|
||||||
|
"@excalidraw/fractional-indexing": path.resolve(
|
||||||
|
__dirname,
|
||||||
|
"../packages/fractional-indexing/src",
|
||||||
|
),
|
||||||
"@excalidraw/utils": path.resolve(__dirname, "../packages/utils/src"),
|
"@excalidraw/utils": path.resolve(__dirname, "../packages/utils/src"),
|
||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|||||||
+7
-1
@@ -6,7 +6,13 @@ const { execSync } = require("child_process");
|
|||||||
const updateChangelog = require("./updateChangelog");
|
const updateChangelog = require("./updateChangelog");
|
||||||
|
|
||||||
// skipping utils for now, as it has independent release process
|
// skipping utils for now, as it has independent release process
|
||||||
const PACKAGES = ["common", "math", "element", "excalidraw"];
|
const PACKAGES = [
|
||||||
|
"common",
|
||||||
|
"fractional-indexing",
|
||||||
|
"math",
|
||||||
|
"element",
|
||||||
|
"excalidraw",
|
||||||
|
];
|
||||||
const PACKAGES_DIR = path.resolve(__dirname, "../packages");
|
const PACKAGES_DIR = path.resolve(__dirname, "../packages");
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|||||||
+7
-3
@@ -8,7 +8,13 @@ import { vi } from "vitest";
|
|||||||
import polyfill from "./packages/excalidraw/polyfill";
|
import polyfill from "./packages/excalidraw/polyfill";
|
||||||
import { mockThrottleRAF } from "./packages/excalidraw/tests/helpers/mocks";
|
import { mockThrottleRAF } from "./packages/excalidraw/tests/helpers/mocks";
|
||||||
import { yellow } from "./packages/excalidraw/tests/helpers/colorize";
|
import { yellow } from "./packages/excalidraw/tests/helpers/colorize";
|
||||||
import { testPolyfills } from "./packages/excalidraw/tests/helpers/polyfills";
|
import {
|
||||||
|
PolyfillLocalStorage,
|
||||||
|
testPolyfills,
|
||||||
|
} from "./packages/excalidraw/tests/helpers/polyfills";
|
||||||
|
|
||||||
|
Object.assign(globalThis, testPolyfills);
|
||||||
|
PolyfillLocalStorage();
|
||||||
|
|
||||||
vi.mock("@excalidraw/common", async (importOriginal) => {
|
vi.mock("@excalidraw/common", async (importOriginal) => {
|
||||||
const module = await importOriginal<typeof import("@excalidraw/common")>();
|
const module = await importOriginal<typeof import("@excalidraw/common")>();
|
||||||
@@ -22,8 +28,6 @@ vi.mock("@excalidraw/common", async (importOriginal) => {
|
|||||||
// mock for pep.js not working with setPointerCapture()
|
// mock for pep.js not working with setPointerCapture()
|
||||||
HTMLElement.prototype.setPointerCapture = vi.fn();
|
HTMLElement.prototype.setPointerCapture = vi.fn();
|
||||||
|
|
||||||
Object.assign(globalThis, testPolyfills);
|
|
||||||
|
|
||||||
require("fake-indexeddb/auto");
|
require("fake-indexeddb/auto");
|
||||||
|
|
||||||
polyfill();
|
polyfill();
|
||||||
|
|||||||
@@ -25,6 +25,8 @@
|
|||||||
"@excalidraw/excalidraw/*": ["./packages/excalidraw/*"],
|
"@excalidraw/excalidraw/*": ["./packages/excalidraw/*"],
|
||||||
"@excalidraw/element": ["./packages/element/src/index.ts"],
|
"@excalidraw/element": ["./packages/element/src/index.ts"],
|
||||||
"@excalidraw/element/*": ["./packages/element/src/*"],
|
"@excalidraw/element/*": ["./packages/element/src/*"],
|
||||||
|
"@excalidraw/fractional-indexing": ["./packages/fractional-indexing/src/index.ts"],
|
||||||
|
"@excalidraw/fractional-indexing/*": ["./packages/fractional-indexing/src/*"],
|
||||||
"@excalidraw/math": ["./packages/math/src/index.ts"],
|
"@excalidraw/math": ["./packages/math/src/index.ts"],
|
||||||
"@excalidraw/math/*": ["./packages/math/src/*"],
|
"@excalidraw/math/*": ["./packages/math/src/*"],
|
||||||
"@excalidraw/utils": ["./packages/utils/src/index.ts"],
|
"@excalidraw/utils": ["./packages/utils/src/index.ts"],
|
||||||
|
|||||||
@@ -45,6 +45,20 @@ export default defineConfig({
|
|||||||
find: /^@excalidraw\/utils\/(.*?)/,
|
find: /^@excalidraw\/utils\/(.*?)/,
|
||||||
replacement: path.resolve(__dirname, "./packages/utils/src/$1"),
|
replacement: path.resolve(__dirname, "./packages/utils/src/$1"),
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
find: /^@excalidraw\/fractional-indexing$/,
|
||||||
|
replacement: path.resolve(
|
||||||
|
__dirname,
|
||||||
|
"./packages/fractional-indexing/src/index.ts",
|
||||||
|
),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
find: /^@excalidraw\/fractional-indexing\/(.*?)/,
|
||||||
|
replacement: path.resolve(
|
||||||
|
__dirname,
|
||||||
|
"./packages/fractional-indexing/src/$1",
|
||||||
|
),
|
||||||
|
},
|
||||||
],
|
],
|
||||||
},
|
},
|
||||||
//@ts-ignore
|
//@ts-ignore
|
||||||
|
|||||||
@@ -6572,11 +6572,6 @@ fraction.js@^4.2.0:
|
|||||||
resolved "https://registry.yarnpkg.com/fraction.js/-/fraction.js-4.3.7.tgz#06ca0085157e42fda7f9e726e79fefc4068840f7"
|
resolved "https://registry.yarnpkg.com/fraction.js/-/fraction.js-4.3.7.tgz#06ca0085157e42fda7f9e726e79fefc4068840f7"
|
||||||
integrity sha512-ZsDfxO51wGAXREY55a7la9LScWpwv9RxIrYABrlvOFBlH/ShPnrtsXeuUIfXKKOVicNxQ+o8JTbJvjS4M89yew==
|
integrity sha512-ZsDfxO51wGAXREY55a7la9LScWpwv9RxIrYABrlvOFBlH/ShPnrtsXeuUIfXKKOVicNxQ+o8JTbJvjS4M89yew==
|
||||||
|
|
||||||
fractional-indexing@3.2.0:
|
|
||||||
version "3.2.0"
|
|
||||||
resolved "https://registry.yarnpkg.com/fractional-indexing/-/fractional-indexing-3.2.0.tgz#1193e63d54ff4e0cbe0c79a9ed6cfbab25d91628"
|
|
||||||
integrity sha512-PcOxmqwYCW7O2ovKRU8OoQQj2yqTfEB/yeTYk4gPid6dN5ODRfU1hXd9tTVZzax/0NkO7AxpHykvZnT1aYp/BQ==
|
|
||||||
|
|
||||||
fs-constants@^1.0.0:
|
fs-constants@^1.0.0:
|
||||||
version "1.0.0"
|
version "1.0.0"
|
||||||
resolved "https://registry.yarnpkg.com/fs-constants/-/fs-constants-1.0.0.tgz#6be0de9be998ce16af8afc24497b9ee9b7ccd9ad"
|
resolved "https://registry.yarnpkg.com/fs-constants/-/fs-constants-1.0.0.tgz#6be0de9be998ce16af8afc24497b9ee9b7ccd9ad"
|
||||||
@@ -8520,6 +8515,11 @@ prettier@2.6.2:
|
|||||||
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.6.2.tgz#e26d71a18a74c3d0f0597f55f01fb6c06c206032"
|
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.6.2.tgz#e26d71a18a74c3d0f0597f55f01fb6c06c206032"
|
||||||
integrity sha512-PkUpF+qoXTqhOeWL9fu7As8LXsIUZ1WYaJiY/a7McAQzxjk82OF0tibkFXVCDImZtWxbvojFjerkiLb0/q8mew==
|
integrity sha512-PkUpF+qoXTqhOeWL9fu7As8LXsIUZ1WYaJiY/a7McAQzxjk82OF0tibkFXVCDImZtWxbvojFjerkiLb0/q8mew==
|
||||||
|
|
||||||
|
prettier@^2.6.0:
|
||||||
|
version "2.8.8"
|
||||||
|
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.8.8.tgz#e8c5d7e98a4305ffe3de2e1fc4aca1a71c28b1da"
|
||||||
|
integrity sha512-tdN8qQGvNjw4CHbY+XXk0JgCXn9QiF21a55rBe5LJAU+kDyC4WQn4+awm2Xfk2lQMk5fKup9XgzTZtGkjBdP9Q==
|
||||||
|
|
||||||
pretty-bytes@^5.3.0:
|
pretty-bytes@^5.3.0:
|
||||||
version "5.6.0"
|
version "5.6.0"
|
||||||
resolved "https://registry.yarnpkg.com/pretty-bytes/-/pretty-bytes-5.6.0.tgz#356256f643804773c82f64723fe78c92c62beaeb"
|
resolved "https://registry.yarnpkg.com/pretty-bytes/-/pretty-bytes-5.6.0.tgz#356256f643804773c82f64723fe78c92c62beaeb"
|
||||||
|
|||||||
Reference in New Issue
Block a user