gilles/excalidraw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: hex8 regression #10578 (#10773)

Browse Source
This commit is contained in:
zsviczian
2026-02-12 22:03:13 +01:00
committed by GitHub
parent a70417f23f
commit 8b3e149db6
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/common/src/colors.ts
+1 -1
View File
@@ -346,7 +346,7 @@ export const normalizeInputColor = (color: string): string | null => {
if (tc.isValid()) { if (tc.isValid()) {
// testing for `#` first fixes a bug on Electron (more specfically, an // testing for `#` first fixes a bug on Electron (more specfically, an
// Obsidian popout window), where a hex color without `#` is considered valid // Obsidian popout window), where a hex color without `#` is considered valid
if (tc.getFormat() === "hex" && !color.startsWith("#")) { if (["hex", "hex8"].includes(tc.getFormat()) && !color.startsWith("#")) {
return `#${color}`; return `#${color}`;
} }
return color; return color;
packages/excalidraw/tests/colorInput.test.ts
+2 -3
View File
@@ -22,9 +22,8 @@ describe("normalizeInputColor", () => {
}); });
it("does NOT add hash to hexa without hash (tinycolor detects as hex8, not hex)", () => { it("does NOT add hash to hexa without hash (tinycolor detects as hex8, not hex)", () => {
// Note: tinycolor detects 8-digit hex as "hex8" format, not "hex", // Note: tinycolor detects 8-digit hex as "hex8" format, not "hex"
// so the hash prefix logic doesn't apply expect(normalizeInputColor("ff000080")).toBe("#ff000080");
expect(normalizeInputColor("ff000080")).toBe("ff000080");
}); });
}); });