gilles/excalidraw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: do not finalize multi-point lines if binding not enabled (#10410)

Browse Source 
* fix: do not finalize multi-point lines if binding not enabled

* refactor
This commit is contained in:
David Luzar
2025-11-26 21:02:36 +01:00
committed by GitHub
parent 019ce4c52c
commit 210dc85c8c
1 changed files with 21 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/excalidraw/components/App.tsx
+21 -16
View File
@@ -6396,12 +6396,15 @@ class App extends React.Component<AppProps, AppState> {
setCursorForShape(this.interactiveCanvas, this.state); setCursorForShape(this.interactiveCanvas, this.state);
if (lastPoint === lastCommittedPoint) { if (lastPoint === lastCommittedPoint) {
const hoveredElement = getHoveredElementForBinding( const hoveredElement =
pointFrom<GlobalPoint>(scenePointerX, scenePointerY), isArrowElement(this.state.newElement) &&
this.scene.getNonDeletedElements(), isBindingEnabled(this.state) &&
this.scene.getNonDeletedElementsMap(), getHoveredElementForBinding(
(el) => maxBindingDistance_simple(this.state.zoom), pointFrom<GlobalPoint>(scenePointerX, scenePointerY),
); this.scene.getNonDeletedElements(),
this.scene.getNonDeletedElementsMap(),
(el) => maxBindingDistance_simple(this.state.zoom),
);
if (hoveredElement) { if (hoveredElement) {
this.actionManager.executeAction(actionFinalize, "ui", { this.actionManager.executeAction(actionFinalize, "ui", {
event: event.nativeEvent, event: event.nativeEvent,
@@ -8464,16 +8467,18 @@ class App extends React.Component<AppProps, AppState> {
const { x: rx, y: ry } = multiElement; const { x: rx, y: ry } = multiElement;
const { lastCommittedPoint } = selectedLinearElement; const { lastCommittedPoint } = selectedLinearElement;
const hoveredElementForBinding = getHoveredElementForBinding( const hoveredElementForBinding =
pointFrom<GlobalPoint>( isBindingEnabled(this.state) &&
this.lastPointerMoveCoords?.x ?? getHoveredElementForBinding(
rx + multiElement.points[multiElement.points.length - 1][0], pointFrom<GlobalPoint>(
this.lastPointerMoveCoords?.y ?? this.lastPointerMoveCoords?.x ??
ry + multiElement.points[multiElement.points.length - 1][1], rx + multiElement.points[multiElement.points.length - 1][0],
), this.lastPointerMoveCoords?.y ??
this.scene.getNonDeletedElements(), ry + multiElement.points[multiElement.points.length - 1][1],
this.scene.getNonDeletedElementsMap(), ),
); this.scene.getNonDeletedElements(),
this.scene.getNonDeletedElementsMap(),
);
// clicking inside commit zone → finalize arrow // clicking inside commit zone → finalize arrow
if ( if (