fix: add max attempts to incremental routes to prevent infinite loop
This commit is contained in:
@@ -15,6 +15,8 @@ import (
|
|||||||
// Route that should never be a constructor default.
|
// Route that should never be a constructor default.
|
||||||
const dummyRoute = "/0x8b6c42"
|
const dummyRoute = "/0x8b6c42"
|
||||||
|
|
||||||
|
const maxIncrementalRouteAttempts = 32
|
||||||
|
|
||||||
// Dictionary provides dictionaries for routes, usernames and passwords.
|
// Dictionary provides dictionaries for routes, usernames and passwords.
|
||||||
type Dictionary interface {
|
type Dictionary interface {
|
||||||
Routes() []string
|
Routes() []string
|
||||||
@@ -401,7 +403,13 @@ func (a Attacker) tryIncrementalRoutes(ctx context.Context,
|
|||||||
}
|
}
|
||||||
|
|
||||||
nextNumber := match.number + 1
|
nextNumber := match.number + 1
|
||||||
|
attempts := 0
|
||||||
for {
|
for {
|
||||||
|
if attempts >= maxIncrementalRouteAttempts {
|
||||||
|
a.reporter.Debug(cameradar.StepAttackRoutes, fmt.Sprintf("incremental route attempts capped at %d for %s:%d", maxIncrementalRouteAttempts, target.Address.String(), target.Port))
|
||||||
|
return target, nil
|
||||||
|
}
|
||||||
|
|
||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
return target, ctx.Err()
|
return target, ctx.Err()
|
||||||
@@ -431,6 +439,7 @@ func (a Attacker) tryIncrementalRoutes(ctx context.Context,
|
|||||||
))
|
))
|
||||||
return target, nil
|
return target, nil
|
||||||
}
|
}
|
||||||
|
attempts++
|
||||||
if !ok {
|
if !ok {
|
||||||
return target, nil
|
return target, nil
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user