Release: fuck fedora

Feat: Added support for G635L* models. Lightbar, Logo, Matrix

See merge request asus-linux/asusctl!233

.gitlab-ci.yml

@@ -1,22 +1,26 @@
 image: rust:latest
 
+# Use shallow clone to reduce checkout size
+variables:
+  GIT_DEPTH: "1"
+  # Put cargo home and target under project dir so we can clean them easily
+  CARGO_HOME: "$CI_PROJECT_DIR/.cargo"
+  CARGO_TARGET_DIR: "$CI_PROJECT_DIR/ci-target"
+  GIT_SUBMODULE_STRATEGY: normal
+
+# Cache only cargo registries/git metadata to speed dependency fetches.
+# Avoid caching compiled `target` artifacts which are large and easily fill disk.
 .rust_cache: &rust_cache
   cache:
-    # key: $CI_COMMIT_REF_SLUG
+    key: "$CI_JOB_NAME-$CI_COMMIT_REF_SLUG"
     paths:
-      # Don't include `incremental` to save space
+      - .cargo/registry
-      # Debug
+      - .cargo/git
-      - target/debug/build/
-      - target/debug/deps/
-      - target/debug/.fingerprint/
-      - target/debug/.cargo-lock
-      # Release
-      - target/release/build/
-      - target/release/deps/
-      - target/release/.fingerprint/
-      - target/release/.cargo-lock
 
 before_script:
+  - df -h
+  - echo "Cleaning stale targets to free space if present"
+  - rm -rf "$CI_PROJECT_DIR/target" "$CI_PROJECT_DIR/ci-target" || true
   - apt-get update -qq && apt-get install -y -qq libudev-dev libgtk-3-dev grep llvm clang libclang-dev libsdl2-dev libsdl2-gfx-dev
 
 stages:
@@ -33,6 +37,9 @@ format:
   script:
     - rustup component add rustfmt || true
     - cargo fmt --check
+  after_script:
+    - du -sh "$CI_PROJECT_DIR/ci-target" || true
+    - rm -rf "$CI_PROJECT_DIR/ci-target" || true
 
 check:
   except:
@@ -44,6 +51,8 @@ check:
     # deny currently catches too much
     #- cargo install cargo-deny && cargo deny
     - cargo install cargo-cranky && cargo cranky
+  after_script:
+    - rm -rf "$CI_PROJECT_DIR/ci-target" || true
 
 test:
   except:
@@ -52,6 +61,8 @@ test:
   script:
     - mkdir -p .git/hooks > /dev/null
     - cargo test --locked --all
+  after_script:
+    - rm -rf "$CI_PROJECT_DIR/ci-target" || true
 
 release:
   only:
@@ -59,11 +70,15 @@ release:
   <<: *rust_cache
   script:
     - cargo install cargo-vendor-filterer
+    - cargo fetch
     - make FROZEN=1 && make vendor
   artifacts:
     paths:
       - vendor_asusctl*.tar.xz
       - cargo-config
+    expire_in: 1 week
+  after_script:
+    - rm -rf vendor vendor_asusctl*.tar.xz "$CI_PROJECT_DIR/ci-target" || true
 
 pages:
   stage: deploy
@@ -74,11 +89,11 @@ pages:
     - cargo doc --locked --document-private-items --no-deps --workspace
     - rm -rf public
     - mkdir public
-    - cp -R target/doc/* public
+    - cp -R ci-target/doc/* public
     - cp extra/index.html public
   artifacts:
     paths:
       - public
-
+    expire_in: 1 week
-variables:
+  after_script:
-  GIT_SUBMODULE_STRATEGY: normal
+    - rm -rf "$CI_PROJECT_DIR/ci-target" || true

CHANGELOG.md

@@ -2,10 +2,25 @@
 
 ## [Unreleased]
 
+## [6.1.21]
+
 ### Changed
-- Make the boot process more reliable
+- Kill Fedora: screw your cursed cargo bullshit
-- tie nv_ properties to power profiles
+- Restore CI building
-- Better support nv_tgp
+
+## [6.1.20]
+
+### Changed
+- Addded support for G635L: thanks @luca_pisl !
+- Suppress verbose output in applications too, not just daemon
+
+## [6.1.18]
+
+### Changed
+- Add aura support for G614FR (ROG Strix G16 2025)
+- all notifications now respects the timeout 
+- improve udev daemon-starting rule
+- reduce log noise
 
 ## [v6.1.17]
 

Cargo.toml

@@ -1,5 +1,5 @@
 [workspace.package]
-version = "6.1.17"
+version = "6.1.21"
 rust-version = "1.82"
 license = "MPL-2.0"
 readme = "README.md"

Makefile

@@ -59,10 +59,17 @@ clean:
 distclean:
 	rm -rf .cargo vendor vendor.tar.xz
 
-target/$(TARGET)/$(BIN_D): build
+target/$(TARGET)/$(BIN_D): $(SRC)
-target/$(TARGET)/$(BIN_C): build
+	$(MAKE) build
-target/$(TARGET)/$(BIN_U): build
+
-target/$(TARGET)/$(BIN_ROG): build
+target/$(TARGET)/$(BIN_C): $(SRC)
+	$(MAKE) build
+
+target/$(TARGET)/$(BIN_U): $(SRC)
+	$(MAKE) build
+
+target/$(TARGET)/$(BIN_ROG): $(SRC)
+	$(MAKE) build
 
 install-asusd: target/$(TARGET)/$(BIN_D)
 	$(INSTALL_PROGRAM) "./target/$(TARGET)/$(BIN_D)" "$(DESTDIR)$(bindir)/$(BIN_D)"

asusctl/src/aura_cli.rs

@@ -180,8 +180,8 @@ pub struct TwoColourSpeed {
     pub zone: AuraZone,
 }
 
-#[allow(dead_code)]
 #[derive(Debug, Clone, Default, Options)]
+#[allow(dead_code)]
 pub struct MultiZone {
     #[options(help = "print help message")]
     help: bool,
@@ -195,8 +195,8 @@ pub struct MultiZone {
     pub colour4: Colour,
 }
 
-#[allow(dead_code)]
 #[derive(Debug, Clone, Default, Options)]
+#[allow(dead_code)]
 pub struct MultiColourSpeed {
     #[options(help = "print help message")]
     help: bool,

asusctl/src/main.rs

@@ -9,7 +9,7 @@ use aura_cli::{LedPowerCommand1, LedPowerCommand2};
 use dmi_id::DMIID;
 use fan_curve_cli::FanCurveCommand;
 use gumdrop::{Opt, Options};
-use log::{error, info};
+use log::{error, info, LevelFilter};
 use rog_anime::usb::get_anime_type;
 use rog_anime::{AnimTime, AnimeDataBuffer, AnimeDiagonal, AnimeGif, AnimeImage, AnimeType, Vec2};
 use rog_aura::keyboard::{AuraPowerState, LaptopAuraPower};
@@ -44,12 +44,16 @@ mod scsi_cli;
 mod slash_cli;
 
 fn main() {
+    // Ensure tracing spans are quiet by default unless user overrides
+    if std::env::var_os("RUST_LOG").is_none() {
+        std::env::set_var("RUST_LOG", "warn,tracing=error,zbus=error");
+    }
     let mut logger = env_logger::Builder::new();
     logger
         .parse_default_env()
-        .target(env_logger::Target::Stdout)
+        .filter_level(LevelFilter::Info)
+        .target(env_logger::Target::Stderr)
         .format_timestamp(None)
-        .filter_level(log::LevelFilter::Debug)
         .init();
 
     let self_version = env!("CARGO_PKG_VERSION");
@@ -1184,15 +1188,12 @@ fn print_firmware_attr(attr: &AsusArmouryProxyBlocking) -> Result<(), Box<dyn st
     Ok(())
 }
 
-#[allow(clippy::manual_is_multiple_of)]
+#[allow(clippy::manual_is_multiple_of, clippy::nonminimal_bool)]
 fn handle_armoury_command(cmd: &ArmouryCommand) -> Result<(), Box<dyn std::error::Error>> {
     {
-        // Avoid using `.is_multiple_of(2)` to satisfy the request. Use modulus check
+        if cmd.free.is_empty() || (cmd.free.len() % 2 != 0) || cmd.help {
-        // and simplify the boolean expression.
-        let odd_len = cmd.free.len() % 2 != 0;
-        if cmd.free.is_empty() || odd_len || cmd.help {
             const USAGE: &str = "Usage: asusctl platform panel_overdrive 1 nv_dynamic_boost 5";
-            if odd_len {
+            if cmd.free.len() % 2 != 0 {
                 println!(
                     "Incorrect number of args, each attribute label must be paired with a setting:"
                 );

asusd/Cargo.toml

@@ -45,7 +45,6 @@ concat-idents.workspace = true
 
 [dev-dependencies]
 cargo-husky.workspace = true
-tempfile = "3"
 
 [package.metadata.deb]
 license-file = ["../LICENSE", "4"]

asusd/src/asus_armoury.rs

@@ -27,28 +27,6 @@ fn dbus_path_for_attr(attr_name: &str) -> OwnedObjectPath {
     ObjectPath::from_str_unchecked(&format!("{ASUS_ZBUS_PATH}/{MOD_NAME}/{attr_name}")).into()
 }
 
-// Helper: return true when the attribute is effectively unsupported for
-// the current power mode/device. We consider an attribute unsupported when
-// its resolved min and max are equal (no available range), which indicates
-// writes would be invalid. When true, callers should avoid attempting writes.
-fn attr_unsupported(attr: &Attribute) -> bool {
-    let min = attr
-        .refresh_min_value()
-        .or(match attr.min_value() {
-            AttrValue::Integer(i) => Some(*i),
-            _ => None,
-        })
-        .unwrap_or(-1);
-    let max = attr
-        .refresh_max_value()
-        .or(match attr.max_value() {
-            AttrValue::Integer(i) => Some(*i),
-            _ => None,
-        })
-        .unwrap_or(-2); // different default so equality is false unless both present
-    min == max
-}
-
 #[derive(Clone)]
 pub struct AsusArmouryAttribute {
     attr: Attribute,
@@ -168,14 +146,6 @@ impl ArmouryAttributeRegistry {
         self.attrs.push(attr);
     }
 
-    pub fn is_empty(&self) -> bool {
-        self.attrs.is_empty()
-    }
-
-    pub fn iter(&self) -> std::slice::Iter<'_, AsusArmouryAttribute> {
-        self.attrs.iter()
-    }
-
     pub async fn emit_limits(&self, connection: &Connection) -> Result<(), RogError> {
         let mut last_err: Option<RogError> = None;
         for attr in &self.attrs {
@@ -200,7 +170,7 @@ impl crate::Reloadable for AsusArmouryAttribute {
         info!("Reloading {}", self.attr.name());
         let name: FirmwareAttribute = self.attr.name().into();
 
-        if name.is_ppt() || name.is_dgpu() {
+        if name.is_ppt() {
             let profile: PlatformProfile = self.platform.get_platform_profile()?.into();
             let power_plugged = self
                 .power
@@ -226,24 +196,14 @@ impl crate::Reloadable for AsusArmouryAttribute {
             };
 
             if let Some(tune) = apply_value {
-                // Don't attempt writes for attributes that report min==0 and max==0
+                self.attr
-                // (commonly means not supported in this power mode/device); skip
+                    .set_current_value(&AttrValue::Integer(tune))
-                // applying stored tune in that case.
+                    .map_err(|e| {
-                if self.attr.base_path_exists() && !attr_unsupported(&self.attr) {
+                        error!("Could not set {} value: {e:?}", self.attr.name());
-                    self.attr
+                        self.attr.base_path_exists();
-                        .set_current_value(&AttrValue::Integer(tune))
+                        e
-                        .map_err(|e| {
+                    })?;
-                            error!("Could not set {} value: {e:?}", self.attr.name());
+                info!("Set {} to {:?}", self.attr.name(), tune);
-                            self.attr.base_path_exists();
-                            e
-                        })?;
-                    info!("Set {} to {:?}", self.attr.name(), tune);
-                } else {
-                    debug!(
-                        "Skipping apply for {} because attribute missing or unsupported (min==max)",
-                        self.attr.name()
-                    );
-                }
             }
         } else {
             // Handle non-PPT attributes (boolean and other settings)
@@ -317,7 +277,7 @@ impl AsusArmouryAttribute {
 
     async fn restore_default(&self) -> fdo::Result<()> {
         self.attr.restore_default()?;
-        if self.name().is_ppt() || self.name().is_dgpu() {
+        if self.name().is_ppt() {
             let profile: PlatformProfile = self.platform.get_platform_profile()?.into();
             let power_plugged = self
                 .power
@@ -376,7 +336,7 @@ impl AsusArmouryAttribute {
 
     #[zbus(property)]
     async fn current_value(&self) -> fdo::Result<i32> {
-        if self.name().is_ppt() || self.name().is_dgpu() {
+        if self.name().is_ppt() {
             let profile: PlatformProfile = self.platform.get_platform_profile()?.into();
             let power_plugged = self
                 .power
@@ -410,9 +370,9 @@ impl AsusArmouryAttribute {
     }
 
     async fn stored_value_for_power(&self, on_ac: bool) -> fdo::Result<i32> {
-        if !(self.name().is_ppt() || self.name().is_dgpu()) {
+        if !self.name().is_ppt() {
             return Err(fdo::Error::NotSupported(
-                "Stored values are only available for PPT/dGPU tunable attributes".to_string(),
+                "Stored values are only available for PPT attributes".to_string(),
             ));
         }
 
@@ -433,10 +393,9 @@ impl AsusArmouryAttribute {
     }
 
     async fn set_value_for_power(&mut self, on_ac: bool, value: i32) -> fdo::Result<()> {
-        if !(self.name().is_ppt() || self.name().is_dgpu()) {
+        if !self.name().is_ppt() {
             return Err(fdo::Error::NotSupported(
-                "Setting stored values is only supported for PPT/dGPU tunable attributes"
+                "Setting stored values is only supported for PPT attributes".to_string(),
-                    .to_string(),
             ));
         }
 
@@ -474,23 +433,13 @@ impl AsusArmouryAttribute {
                 .unwrap_or_default()
                 != 0;
 
-            // Don't attempt writes for attributes that report min==0 and max==0
+            if power_plugged == on_ac {
-            // (commonly means not supported in this power mode/device); skip
+                self.attr
-            // applying stored value in that case.
+                    .set_current_value(&AttrValue::Integer(value))
-            if self.attr.base_path_exists() && !attr_unsupported(&self.attr) {
+                    .map_err(|e| {
-                if power_plugged == on_ac {
+                        error!("Could not set value: {e:?}");
-                    self.attr
+                        e
-                        .set_current_value(&AttrValue::Integer(value))
+                    })?;
-                        .map_err(|e| {
-                            error!("Could not set value: {e:?}");
-                            e
-                        })?;
-                }
-            } else {
-                debug!(
-                    "Skipping immediate apply for {} because attribute missing or unsupported (min==max)",
-                    self.attr.name()
-                );
             }
         }
 
@@ -499,7 +448,7 @@ impl AsusArmouryAttribute {
 
     #[zbus(property)]
     async fn set_current_value(&mut self, value: i32) -> fdo::Result<()> {
-        if self.name().is_ppt() || self.name().is_dgpu() {
+        if self.name().is_ppt() {
             let profile: PlatformProfile = self.platform.get_platform_profile()?.into();
             let power_plugged = self
                 .power
@@ -520,22 +469,12 @@ impl AsusArmouryAttribute {
                 debug!("Store tuning config for {} = {:?}", self.attr.name(), value);
             }
             if tuning.enabled {
-                // Don't attempt writes for attributes that report min==0 and max==0
+                self.attr
-                // (commonly means not supported in this power mode/device); skip
+                    .set_current_value(&AttrValue::Integer(value))
-                // applying stored value in that case.
+                    .map_err(|e| {
-                if self.attr.base_path_exists() && !attr_unsupported(&self.attr) {
+                        error!("Could not set value: {e:?}");
-                    self.attr
+                        e
-                        .set_current_value(&AttrValue::Integer(value))
+                    })?;
-                        .map_err(|e| {
-                            error!("Could not set value: {e:?}");
-                            e
-                        })?;
-                } else {
-                    debug!(
-                        "Skipping apply for {} on set_current_value because attribute missing or unsupported (min==max)",
-                        self.attr.name()
-                    );
-                }
             }
         } else {
             self.attr
@@ -576,16 +515,12 @@ impl AsusArmouryAttribute {
     }
 }
 
-#[allow(clippy::too_many_arguments)]
 pub async fn start_attributes_zbus(
-    conn: Option<&Connection>,
+    conn: &Connection,
     platform: RogPlatform,
     power: AsusPower,
     attributes: FirmwareAttributes,
     config: Arc<Mutex<Config>>,
-    enable_zbus: bool,
-    profile_override: Option<rog_platform::platform::PlatformProfile>,
-    power_plugged_override: Option<bool>,
 ) -> Result<ArmouryAttributeRegistry, RogError> {
     let mut registry = ArmouryAttributeRegistry::default();
     for attr in attributes.attributes() {
@@ -598,115 +533,35 @@ pub async fn start_attributes_zbus(
 
         let registry_attr = attr.clone();
 
-        // Only perform the full reload (which may query the platform/power sysfs)
+        if let Err(e) = attr.reload().await {
-        // when zbus is enabled. Tests using the no-zbus mode skip the reload and
+            error!(
-        // emulate the reload/apply behavior to avoid depending on udev/sysfs.
+                "Skipping attribute '{}' due to reload error: {e:?}",
-        if enable_zbus {
+                attr.attr.name()
-            if let Err(e) = attr.reload().await {
+            );
-                error!(
+            // continue with others
-                    "Skipping attribute '{}' due to reload error: {e:?}",
+            continue;
-                    attr.attr.name()
-                );
-                // continue with others
-                continue;
-            }
         }
 
         let attr_name = attr.attribute_name();
 
-        // If zbus is enabled and a connection is provided, create the SignalEmitter,
+        let path = dbus_path_for_attr(attr_name.as_str());
-        // start watchers and register the object on zbus. Tests can call this function
+        match zbus::object_server::SignalEmitter::new(conn, path) {
-        // with enable_zbus=false and conn=None to skip DBus registration and watchers.
+            Ok(sig) => {
-        if !enable_zbus {
+                if let Err(e) = attr.watch_and_notify(sig).await {
-            // Emulate reload logic but prefer overrides when provided to avoid dependency on udev/sysfs in tests
+                    error!("Failed to start watcher for '{}': {e:?}", attr.attr.name());
-            let name: rog_platform::asus_armoury::FirmwareAttribute = attr.attr.name().into();
-            if name.is_ppt() || name.is_dgpu() {
-                // determine profile
-                let profile = if let Some(p) = profile_override {
-                    p
-                } else {
-                    match attr.platform.get_platform_profile() {
-                        Ok(p) => p.into(),
-                        Err(_) => rog_platform::platform::PlatformProfile::Balanced,
-                    }
-                };
-
-                // determine power plugged
-                let power_plugged = if let Some(v) = power_plugged_override {
-                    v
-                } else {
-                    match attr.power.get_online() {
-                        Ok(v) => v == 1,
-                        Err(_) => false,
-                    }
-                };
-
-                let apply_value = {
-                    let config = attr.config.lock().await;
-                    config
-                        .select_tunings_ref(power_plugged, profile)
-                        .and_then(|tuning| {
-                            if tuning.enabled {
-                                tuning.group.get(&attr.name()).copied()
-                            } else {
-                                None
-                            }
-                        })
-                };
-
-                if let Some(tune) = apply_value {
-                    attr.attr
-                        .set_current_value(&AttrValue::Integer(tune))
-                        .map_err(|e| {
-                            error!("Could not set {} value: {e:?}", attr.attr.name());
-                            e
-                        })?;
                 }
-            } else if let Some(saved_value) = attr.config.lock().await.armoury_settings.get(&name) {
+            }
-                attr.attr
+            Err(e) => {
-                    .set_current_value(&AttrValue::Integer(*saved_value))
+                error!(
-                    .map_err(|e| {
+                    "Failed to create SignalEmitter for '{}': {e:?}",
-                        error!("Could not set {} value: {e:?}", attr.attr.name());
+                    attr.attr.name()
-                        e
-                    })?;
-                info!(
-                    "Restored armoury setting {} to {:?}",
-                    attr.attr.name(),
-                    saved_value
                 );
             }
-
-            registry.push(registry_attr);
-            continue;
         }
 
-        // If zbus is enabled and a connection is provided, create the SignalEmitter,
+        if let Err(e) = attr.move_to_zbus(conn).await {
-        // start watchers and register the object on zbus. Tests can call this function
+            error!("Failed to register attribute '{attr_name}' on zbus: {e:?}");
-        // with enable_zbus=false and conn=None to skip DBus registration and watchers.
+            continue;
-        if enable_zbus {
-            if let Some(connection) = conn {
-                let path = dbus_path_for_attr(attr_name.as_str());
-                match zbus::object_server::SignalEmitter::new(connection, path) {
-                    Ok(sig) => {
-                        if let Err(e) = attr.watch_and_notify(sig).await {
-                            error!("Failed to start watcher for '{}': {e:?}", attr.attr.name());
-                        }
-                    }
-                    Err(e) => {
-                        error!(
-                            "Failed to create SignalEmitter for '{}': {e:?}",
-                            attr.attr.name()
-                        );
-                    }
-                }
-
-                if let Err(e) = attr.move_to_zbus(connection).await {
-                    error!("Failed to register attribute '{attr_name}' on zbus: {e:?}");
-                    continue;
-                }
-            } else {
-                error!("zbus enabled but no Connection provided for attribute registration");
-            }
         }
 
         registry.push(registry_attr);
@@ -722,50 +577,34 @@ pub async fn set_config_or_default(
 ) {
     for attr in attrs.attributes().iter() {
         let name: FirmwareAttribute = attr.name().into();
-        if name.is_ppt() || name.is_dgpu() {
+        if name.is_ppt() {
             let tuning = config.select_tunings(power_plugged, profile);
             if !tuning.enabled {
                 debug!("Tuning group is not enabled, skipping");
-                continue;
+                return;
             }
-            // Determine once whether attribute is present and supports a writable range
+
-            let supported = attr.base_path_exists() && !attr_unsupported(attr);
             if let Some(tune) = tuning.group.get(&name) {
-                if supported {
+                attr.set_current_value(&AttrValue::Integer(*tune))
-                    attr.set_current_value(&AttrValue::Integer(*tune))
+                    .map_err(|e| {
-                        .map_err(|e| {
+                        error!("Failed to set {}: {e}", <&str>::from(name));
-                            error!("Failed to set {}: {e}", <&str>::from(name));
+                    })
-                        })
+                    .ok();
-                        .ok();
-                } else {
-                    debug!(
-                        "Skipping apply for {} in set_config_or_default because attribute missing or unsupported",
-                        <&str>::from(name)
-                    );
-                }
             } else {
-                // Only attempt to apply defaults when the attribute supports a range
+                let default = attr.default_value();
-                if supported {
+                attr.set_current_value(default)
-                    let default = attr.default_value();
+                    .map_err(|e| {
-                    attr.set_current_value(default)
+                        error!("Failed to set {}: {e}", <&str>::from(name));
-                        .map_err(|e| {
+                    })
-                            error!("Failed to set {}: {e}", <&str>::from(name));
+                    .ok();
-                        })
+                if let AttrValue::Integer(i) = default {
-                        .ok();
+                    tuning.group.insert(name, *i);
-                    if let AttrValue::Integer(i) = default {
+                    info!(
-                        tuning.group.insert(name, *i);
+                        "Set default tuning config for {} = {:?}",
-                        info!(
+                        <&str>::from(name),
-                            "Set default tuning config for {} = {:?}",
+                        i
-                            <&str>::from(name),
-                            i
-                        );
-                        // config.write();
-                    }
-                } else {
-                    debug!(
-                        "Skipping default apply for {} in set_config_or_default because attribute missing or unsupported",
-                        <&str>::from(name)
                     );
+                    // config.write();
                 }
             }
         } else {
@@ -785,69 +624,3 @@ pub async fn set_config_or_default(
         }
     }
 }
-
-// Internal helper to store a tuning value into the correct per-profile, per-power map.
-// This centralizes the behavior so tests can validate storage semantics.
-#[allow(dead_code)]
-fn insert_tuning_value(
-    config: &mut Config,
-    on_ac: bool,
-    profile: PlatformProfile,
-    name: rog_platform::asus_armoury::FirmwareAttribute,
-    value: i32,
-) {
-    let tuning = config.select_tunings(on_ac, profile);
-    if let Some(t) = tuning.group.get_mut(&name) {
-        *t = value;
-    } else {
-        tuning.group.insert(name, value);
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-    use crate::config::Config;
-    use rog_platform::asus_armoury::FirmwareAttribute;
-    use rog_platform::platform::PlatformProfile;
-
-    #[test]
-    fn insert_nv_tuning_is_per_profile_and_power() {
-        let mut cfg = Config::default();
-        let profile = PlatformProfile::Performance;
-
-        // Insert value for AC
-        insert_tuning_value(
-            &mut cfg,
-            true,
-            profile,
-            FirmwareAttribute::NvDynamicBoost,
-            7,
-        );
-
-        // Value should be present in ac_profile_tunings
-        let t_ac = cfg.select_tunings_ref(true, profile).unwrap();
-        assert_eq!(t_ac.group.get(&FirmwareAttribute::NvDynamicBoost), Some(&7));
-
-        // Insert separate value for DC
-        insert_tuning_value(
-            &mut cfg,
-            false,
-            profile,
-            FirmwareAttribute::NvDynamicBoost,
-            3,
-        );
-        let t_dc = cfg.select_tunings_ref(false, profile).unwrap();
-        assert_eq!(t_dc.group.get(&FirmwareAttribute::NvDynamicBoost), Some(&3));
-    }
-
-    #[test]
-    fn non_ppt_attribute_stores_in_armoury_settings() {
-        let mut cfg = Config::default();
-        // Non-PPT/dGPU attribute, e.g., BootSound
-        let name = FirmwareAttribute::BootSound;
-        // Simulate setting armoury setting
-        cfg.armoury_settings.insert(name, 1);
-        assert_eq!(cfg.armoury_settings.get(&name), Some(&1));
-    }
-}

asusd/src/aura_manager.rs

@@ -96,17 +96,15 @@ pub struct AsusDevice {
     hid_key: Option<String>,
 }
 
-/// Shared alias for the HidRaw handle map used throughout this module.
-type HidHandleMap = Arc<Mutex<HashMap<String, Arc<Mutex<HidRaw>>>>>;
-
 pub struct DeviceManager {
     _dbus_connection: Connection,
-    _hid_handles: HidHandleMap,
+    _hid_handles: Arc<Mutex<HashMap<String, Arc<Mutex<HidRaw>>>>>,
 }
 
 impl DeviceManager {
+    #[allow(clippy::type_complexity)]
     async fn get_or_create_hid_handle(
-        handles: &HidHandleMap,
+        handles: &Arc<Mutex<HashMap<String, Arc<Mutex<HidRaw>>>>>,
         endpoint: &Device,
     ) -> Result<(Arc<Mutex<HidRaw>>, String), RogError> {
         let dev_node = endpoint
@@ -127,7 +125,7 @@ impl DeviceManager {
     async fn init_hid_devices(
         connection: &Connection,
         device: Device,
-        handles: HidHandleMap,
+        handles: Arc<Mutex<HashMap<String, Arc<Mutex<HidRaw>>>>>,
     ) -> Result<Vec<AsusDevice>, RogError> {
         let mut devices = Vec::new();
         if let Some(usb_device) = device.parent_with_subsystem_devtype("usb", "usb_device")? {
@@ -215,7 +213,7 @@ impl DeviceManager {
     /// To be called on daemon startup
     async fn init_all_hid(
         connection: &Connection,
-        handles: HidHandleMap,
+        handles: Arc<Mutex<HashMap<String, Arc<Mutex<HidRaw>>>>>,
     ) -> Result<Vec<AsusDevice>, RogError> {
         // track and ensure we use only one hidraw per prod_id
         // let mut interfaces = HashSet::new();

asusd/src/config.rs

@@ -225,8 +225,6 @@ pub struct Config601 {
     pub nv_dynamic_boost: Option<u8>,
     #[serde(skip_serializing_if = "Option::is_none", default)]
     pub nv_temp_target: Option<u8>,
-    #[serde(skip_serializing_if = "Option::is_none", default)]
-    pub nv_tgp: Option<u8>,
     #[serde(skip)]
     pub last_power_plugged: u8,
 }

asusd/src/ctrl_platform.rs

@@ -295,16 +295,39 @@ impl CtrlPlatform {
 
     #[zbus(property)]
     fn charge_control_end_threshold(&self) -> Result<u8, FdoErr> {
-        let limit = self.power.get_charge_control_end_threshold()?;
+        if !self.power.has_charge_control_end_threshold() {
+            return Err(FdoErr::NotSupported(
+                "RogPlatform: charge_control_end_threshold not supported".to_owned(),
+            ));
+        }
+
+        let limit = self.power.get_charge_control_end_threshold().map_err(|e| {
+            FdoErr::Failed(format!(
+                "Could not read charge_control_end_threshold: {e:?}"
+            ))
+        })?;
+
         Ok(limit)
     }
 
     #[zbus(property)]
     async fn set_charge_control_end_threshold(&mut self, limit: u8) -> Result<(), FdoErr> {
+        if !self.power.has_charge_control_end_threshold() {
+            return Err(FdoErr::NotSupported(
+                "RogPlatform: charge_control_end_threshold not supported".to_owned(),
+            ));
+        }
+
         if !(20..=100).contains(&limit) {
             return Err(RogError::ChargeLimit(limit))?;
         }
-        self.power.set_charge_control_end_threshold(limit)?;
+
+        self.power
+            .set_charge_control_end_threshold(limit)
+            .map_err(|e| {
+                FdoErr::Failed(format!("Could not set charge_control_end_threshold: {e:?}"))
+            })?;
+
         self.config.lock().await.charge_control_end_threshold = limit;
         self.config.lock().await.base_charge_control_end_threshold = limit;
         self.config.lock().await.write();
@@ -312,12 +335,22 @@ impl CtrlPlatform {
     }
 
     async fn one_shot_full_charge(&self) -> Result<(), FdoErr> {
+        if !self.power.has_charge_control_end_threshold() {
+            return Err(FdoErr::NotSupported(
+                "RogPlatform: charge_control_end_threshold not supported".to_owned(),
+            ));
+        }
+
         let base_limit = std::mem::replace(
             &mut self.config.lock().await.charge_control_end_threshold,
             100,
         );
         if base_limit != 100 {
-            self.power.set_charge_control_end_threshold(100)?;
+            self.power
+                .set_charge_control_end_threshold(100)
+                .map_err(|e| {
+                    FdoErr::Failed(format!("Could not set one_shot_full_charge: {e:?}"))
+                })?;
             self.config.lock().await.base_charge_control_end_threshold = base_limit;
             self.config.lock().await.write();
         }
@@ -566,7 +599,7 @@ impl CtrlPlatform {
 
             for attr in self.attributes.attributes() {
                 let name: FirmwareAttribute = attr.name().into();
-                if name.is_ppt() || name.is_dgpu() {
+                if name.is_ppt() {
                     // reset stored value
                     if let Some(tune) = self
                         .config

asusd/src/daemon.rs

@@ -77,14 +77,11 @@ async fn start_daemon() -> Result<(), Box<dyn Error>> {
     let power = AsusPower::new()?; // TODO: maybe needs async mutex?
     let attributes = FirmwareAttributes::new();
     let armoury_registry = match start_attributes_zbus(
-        Some(&server),
+        &server,
         platform.clone(),
         power.clone(),
         attributes.clone(),
         config.clone(),
-        true,
-        None,
-        None,
     )
     .await
     {

asusd/tests/attr_unsupported_min_eq_max.rs

@@ -1,68 +0,0 @@
-use std::fs::{create_dir_all, File};
-use std::io::Write;
-use std::path::PathBuf;
-
-use tempfile::tempdir;
-
-use asusd::asus_armoury::set_config_or_default;
-use asusd::config::Config;
-use rog_platform::asus_armoury::FirmwareAttributes;
-use rog_platform::platform::PlatformProfile;
-
-fn write_attr_dir_with_min_max(base: &PathBuf, name: &str, default: &str, min: &str, max: &str) {
-    let attr_dir = base.join(name);
-    create_dir_all(&attr_dir).unwrap();
-
-    let mut f = File::create(attr_dir.join("default_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-    let mut f = File::create(attr_dir.join("display_name")).unwrap();
-    write!(f, "{}", name).unwrap();
-    // create current_value file so set_current_value can open for write
-    let mut f = File::create(attr_dir.join("current_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-    // write explicit min and max
-    let mut f = File::create(attr_dir.join("min_value")).unwrap();
-    write!(f, "{}", min).unwrap();
-    let mut f = File::create(attr_dir.join("max_value")).unwrap();
-    write!(f, "{}", max).unwrap();
-}
-
-#[test]
-fn attribute_with_min_eq_max_is_unsupported_and_skipped() {
-    let td = tempdir().unwrap();
-    let base = td.path().join("attributes");
-    create_dir_all(&base).unwrap();
-
-    // create an attribute where min == max (no range)
-    write_attr_dir_with_min_max(&base, "nv_dynamic_boost", "5", "10", "10");
-
-    let attrs = FirmwareAttributes::from_dir(&base);
-
-    let mut cfg = Config::default();
-    let profile = PlatformProfile::Performance;
-
-    // set stored tuning that would normally be applied
-    {
-        let ac = cfg.select_tunings(true, profile);
-        ac.enabled = true;
-        ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::NvDynamicBoost,
-            9,
-        );
-    }
-
-    let rt = tokio::runtime::Runtime::new().unwrap();
-
-    // apply AC
-    rt.block_on(async {
-        set_config_or_default(&attrs, &mut cfg, true, profile).await;
-    });
-
-    // Since min==max the attribute is considered unsupported and the current_value should remain the default (5)
-    assert_eq!(
-        std::fs::read_to_string(base.join("nv_dynamic_boost").join("current_value"))
-            .unwrap()
-            .trim(),
-        "5"
-    );
-}

asusd/tests/sysfs_full_service.rs

@@ -1,173 +0,0 @@
-use std::fs::{create_dir_all, File};
-use std::io::Write;
-use std::path::PathBuf;
-use std::sync::Arc;
-
-use tempfile::tempdir;
-
-use asusd::asus_armoury::start_attributes_zbus;
-use asusd::config::Config;
-use rog_platform::asus_armoury::FirmwareAttributes;
-use rog_platform::platform::PlatformProfile;
-use rog_platform::platform::RogPlatform;
-use rog_platform::power::AsusPower;
-use tokio::runtime::Runtime;
-use tokio::sync::Mutex as TokioMutex;
-
-fn write_attr_dir(base: &PathBuf, name: &str, default: &str, display: &str) {
-    let attr_dir = base.join(name);
-    create_dir_all(&attr_dir).unwrap();
-
-    let mut f = File::create(attr_dir.join("default_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-    let mut f = File::create(attr_dir.join("display_name")).unwrap();
-    write!(f, "{}", display).unwrap();
-    // create current_value file so set_current_value can open for write
-    let mut f = File::create(attr_dir.join("current_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-}
-
-#[test]
-fn full_service_handles_boot_sound_and_nv_tgp() {
-    let td = tempdir().unwrap();
-    let base = td.path().join("attributes");
-    create_dir_all(&base).unwrap();
-
-    // create fake attributes (ppt and nv related)
-    write_attr_dir(&base, "boot_sound", "0", "boot_sound");
-    write_attr_dir(&base, "ppt_pl1_spl", "25", "ppt_pl1_spl");
-    write_attr_dir(&base, "ppt_pl2_sppt", "50", "ppt_pl2_sppt");
-    write_attr_dir(&base, "ppt_pl3_fppt", "75", "ppt_pl3_fppt");
-    write_attr_dir(&base, "ppt_apu_sppt", "20", "ppt_apu_sppt");
-    write_attr_dir(&base, "ppt_platform_sppt", "30", "ppt_platform_sppt");
-    write_attr_dir(&base, "nv_dynamic_boost", "0", "nv_dynamic_boost");
-    write_attr_dir(&base, "nv_temp_target", "0", "nv_temp_target");
-    write_attr_dir(&base, "nv_base_tgp", "10", "nv_base_tgp");
-    write_attr_dir(&base, "nv_tgp", "0", "nv_tgp");
-
-    // Ensure FirmwareAttributes reads from our fake sysfs
-    let attrs = FirmwareAttributes::from_dir(&base);
-
-    // Build config and set nv_tgp tuning for the platform default (Balanced) on AC
-    let mut cfg = Config::default();
-    let profile = PlatformProfile::Balanced;
-    {
-        let tuning_ac = cfg.select_tunings(true, profile);
-        tuning_ac.enabled = true;
-        tuning_ac
-            .group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::PptPl1Spl, 42);
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl2Sppt,
-            43,
-        );
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl3Fppt,
-            44,
-        );
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptApuSppt,
-            45,
-        );
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPlatformSppt,
-            46,
-        );
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::NvDynamicBoost,
-            11,
-        );
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::NvTempTarget,
-            66,
-        );
-        tuning_ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::DgpuBaseTgp,
-            12,
-        );
-        tuning_ac
-            .group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::DgpuTgp, 77);
-    }
-
-    // Use default platform/power stubs (they expect to find udev sysfs, so use Defaults)
-    let platform = RogPlatform::default();
-    let power = AsusPower::default();
-
-    // Start attributes without DBus
-    let rt = Runtime::new().unwrap();
-    let cfg_arc = Arc::new(TokioMutex::new(cfg));
-    let attrs_clone = attrs.clone();
-    rt.block_on(async {
-        let registry = start_attributes_zbus(
-            None,
-            platform,
-            power,
-            attrs_clone,
-            cfg_arc.clone(),
-            false,
-            Some(PlatformProfile::Balanced),
-            Some(true),
-        )
-        .await
-        .unwrap();
-        // registry now contains AsusArmouryAttribute objects that have been reloaded and applied
-        assert!(!registry.is_empty());
-
-        // verify registry contains expected attribute names
-        let names: std::collections::HashSet<String> =
-            registry.iter().map(|a| a.attribute_name()).collect();
-
-        let expected = [
-            "boot_sound", "ppt_pl1_spl", "ppt_pl2_sppt", "ppt_pl3_fppt", "ppt_apu_sppt",
-            "ppt_platform_sppt", "nv_dynamic_boost", "nv_temp_target", "nv_base_tgp", "nv_tgp",
-        ];
-
-        for &e in &expected {
-            assert!(names.contains(e), "Registry missing expected attr: {}", e);
-        }
-
-        // Check that PPT and NV attributes current_value exist and were applied
-        let nv_tgp_val_path = base.join("nv_tgp").join("current_value");
-        let boot_val_path = base.join("boot_sound").join("current_value");
-        let ppt1_val_path = base.join("ppt_pl1_spl").join("current_value");
-        let ppt2_val_path = base.join("ppt_pl2_sppt").join("current_value");
-        let ppt3_val_path = base.join("ppt_pl3_fppt").join("current_value");
-        let apu_val_path = base.join("ppt_apu_sppt").join("current_value");
-        let plat_val_path = base.join("ppt_platform_sppt").join("current_value");
-        let nv_dyn_path = base.join("nv_dynamic_boost").join("current_value");
-        let nv_temp_path = base.join("nv_temp_target").join("current_value");
-        let nv_base_path = base.join("nv_base_tgp").join("current_value");
-
-        let nv = std::fs::read_to_string(&nv_tgp_val_path).unwrap();
-        assert_eq!(nv.trim(), "77");
-
-        // PPTs
-        assert_eq!(
-            std::fs::read_to_string(&ppt1_val_path).unwrap().trim(),
-            "42"
-        );
-        assert_eq!(
-            std::fs::read_to_string(&ppt2_val_path).unwrap().trim(),
-            "43"
-        );
-        assert_eq!(
-            std::fs::read_to_string(&ppt3_val_path).unwrap().trim(),
-            "44"
-        );
-        assert_eq!(std::fs::read_to_string(&apu_val_path).unwrap().trim(), "45");
-        assert_eq!(
-            std::fs::read_to_string(&plat_val_path).unwrap().trim(),
-            "46"
-        );
-
-        // NVs
-        assert_eq!(std::fs::read_to_string(&nv_dyn_path).unwrap().trim(), "11");
-        assert_eq!(std::fs::read_to_string(&nv_temp_path).unwrap().trim(), "66");
-        assert_eq!(std::fs::read_to_string(&nv_base_path).unwrap().trim(), "12");
-
-        // boot_sound default was 0, it should remain 0 unless config.armoury_settings stored something
-        let boot = std::fs::read_to_string(&boot_val_path).unwrap();
-        assert_eq!(boot.trim(), "0");
-    });
-}

asusd/tests/sysfs_integration.rs

@@ -1,97 +0,0 @@
-use std::fs::{create_dir_all, File};
-use std::io::Write;
-use std::path::PathBuf;
-
-use tempfile::tempdir;
-
-use asusd::asus_armoury::set_config_or_default;
-use asusd::config::Config;
-use rog_platform::asus_armoury::{AttrValue, FirmwareAttributes};
-use rog_platform::platform::PlatformProfile;
-
-fn write_attr_dir(base: &PathBuf, name: &str, default: &str, display: &str) {
-    let attr_dir = base.join(name);
-    create_dir_all(&attr_dir).unwrap();
-
-    let mut f = File::create(attr_dir.join("default_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-    let mut f = File::create(attr_dir.join("display_name")).unwrap();
-    write!(f, "{}", display).unwrap();
-    // create current_value file so set_current_value can open for write
-    let mut f = File::create(attr_dir.join("current_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-}
-
-#[test]
-fn sysfs_set_config_or_default_writes_nv_and_ppt() {
-    let td = tempdir().unwrap();
-    let base = td.path().join("attributes");
-    create_dir_all(&base).unwrap();
-
-    // create mock attributes: ppt_pl1_spl and nv_dynamic_boost
-    write_attr_dir(&base, "ppt_pl1_spl", "25", "ppt");
-    write_attr_dir(&base, "nv_dynamic_boost", "0", "nv");
-    write_attr_dir(&base, "nv_tgp", "0", "nv_tgp");
-
-    // Build FirmwareAttributes from this dir
-    let attrs = FirmwareAttributes::from_dir(&base);
-
-    // Create a config with a tuning enabled for Performance on AC
-    let mut cfg = Config::default();
-    let profile = PlatformProfile::Performance;
-    {
-        let tuning = cfg.select_tunings(true, profile);
-        tuning.enabled = true;
-        tuning
-            .group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::PptPl1Spl, 42);
-        tuning.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::NvDynamicBoost,
-            11,
-        );
-        tuning
-            .group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::DgpuTgp, 99);
-    }
-
-    // Apply
-    // set_config_or_default is async, call in a small runtime
-    let rt = tokio::runtime::Runtime::new().unwrap();
-    rt.block_on(async {
-        set_config_or_default(&attrs, &mut cfg, true, profile).await;
-    });
-
-    // Now read files to verify values were written
-    let ppt_val_path = base.join("ppt_pl1_spl").join("current_value");
-    let nv_val_path = base.join("nv_dynamic_boost").join("current_value");
-    let nv_tgp_val_path = base.join("nv_tgp").join("current_value");
-    let ppt_val = std::fs::read_to_string(&ppt_val_path).unwrap();
-    let mut nv_val = std::fs::read_to_string(&nv_val_path).unwrap();
-
-    assert_eq!(ppt_val.trim(), "42");
-
-    // If NV not updated by set_config_or_default, try applying directly to ensure attribute write works.
-    if nv_val.trim() != "11" {
-        // find the attribute and set it directly
-        for attr in attrs.attributes() {
-            if attr.name() == "nv_dynamic_boost" {
-                attr.set_current_value(&AttrValue::Integer(11)).unwrap();
-            }
-        }
-        nv_val = std::fs::read_to_string(&nv_val_path).unwrap();
-    }
-
-    assert_eq!(nv_val.trim(), "11");
-
-    // Verify nv_tgp updated
-    let mut nv_tgp_val = std::fs::read_to_string(&nv_tgp_val_path).unwrap();
-    if nv_tgp_val.trim() != "99" {
-        for attr in attrs.attributes() {
-            if attr.name() == "nv_tgp" {
-                attr.set_current_value(&AttrValue::Integer(99)).unwrap();
-            }
-        }
-        nv_tgp_val = std::fs::read_to_string(&nv_tgp_val_path).unwrap();
-    }
-    assert_eq!(nv_tgp_val.trim(), "99");
-}

asusd/tests/sysfs_nv_and_ppt_acdc.rs

@@ -1,144 +0,0 @@
-use std::fs::{create_dir_all, File};
-use std::io::Write;
-use std::path::PathBuf;
-
-use tempfile::tempdir;
-
-use asusd::asus_armoury::set_config_or_default;
-use asusd::config::Config;
-use rog_platform::asus_armoury::FirmwareAttributes;
-use rog_platform::platform::PlatformProfile;
-
-fn write_attr_dir(base: &PathBuf, name: &str, default: &str, display: &str) {
-    let attr_dir = base.join(name);
-    create_dir_all(&attr_dir).unwrap();
-
-    let mut f = File::create(attr_dir.join("default_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-    let mut f = File::create(attr_dir.join("display_name")).unwrap();
-    write!(f, "{}", display).unwrap();
-    // create current_value file so set_current_value can open for write
-    let mut f = File::create(attr_dir.join("current_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-}
-
-#[test]
-fn nv_dynamic_boost_and_ppt_acdc() {
-    let td = tempdir().unwrap();
-    let base = td.path().join("attributes");
-    create_dir_all(&base).unwrap();
-
-    // create mock attributes: several PPTs and nv_dynamic_boost
-    write_attr_dir(&base, "ppt_pl1_spl", "25", "ppt_pl1_spl");
-    write_attr_dir(&base, "ppt_pl2_sppt", "50", "ppt_pl2_sppt");
-    write_attr_dir(&base, "ppt_pl3_fppt", "75", "ppt_pl3_fppt");
-    write_attr_dir(&base, "nv_dynamic_boost", "0", "nv_dynamic_boost");
-
-    let attrs = FirmwareAttributes::from_dir(&base);
-
-    let mut cfg = Config::default();
-    let profile = PlatformProfile::Performance;
-
-    // set different values for AC and DC
-    {
-        let ac = cfg.select_tunings(true, profile);
-        ac.enabled = true;
-        ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl1Spl,
-            100,
-        );
-        ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl2Sppt,
-            101,
-        );
-        ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl3Fppt,
-            102,
-        );
-        ac.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::NvDynamicBoost,
-            9,
-        );
-    }
-
-    {
-        let dc = cfg.select_tunings(false, profile);
-        dc.enabled = true;
-        dc.group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::PptPl1Spl, 10);
-        dc.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl2Sppt,
-            11,
-        );
-        dc.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::PptPl3Fppt,
-            12,
-        );
-        dc.group.insert(
-            rog_platform::asus_armoury::FirmwareAttribute::NvDynamicBoost,
-            3,
-        );
-    }
-
-    let rt = tokio::runtime::Runtime::new().unwrap();
-
-    // apply AC
-    rt.block_on(async {
-        set_config_or_default(&attrs, &mut cfg, true, profile).await;
-    });
-
-    assert_eq!(
-        std::fs::read_to_string(base.join("ppt_pl1_spl").join("current_value"))
-            .unwrap()
-            .trim(),
-        "100"
-    );
-    assert_eq!(
-        std::fs::read_to_string(base.join("ppt_pl2_sppt").join("current_value"))
-            .unwrap()
-            .trim(),
-        "101"
-    );
-    assert_eq!(
-        std::fs::read_to_string(base.join("ppt_pl3_fppt").join("current_value"))
-            .unwrap()
-            .trim(),
-        "102"
-    );
-    assert_eq!(
-        std::fs::read_to_string(base.join("nv_dynamic_boost").join("current_value"))
-            .unwrap()
-            .trim(),
-        "9"
-    );
-
-    // apply DC
-    rt.block_on(async {
-        set_config_or_default(&attrs, &mut cfg, false, profile).await;
-    });
-
-    assert_eq!(
-        std::fs::read_to_string(base.join("ppt_pl1_spl").join("current_value"))
-            .unwrap()
-            .trim(),
-        "10"
-    );
-    assert_eq!(
-        std::fs::read_to_string(base.join("ppt_pl2_sppt").join("current_value"))
-            .unwrap()
-            .trim(),
-        "11"
-    );
-    assert_eq!(
-        std::fs::read_to_string(base.join("ppt_pl3_fppt").join("current_value"))
-            .unwrap()
-            .trim(),
-        "12"
-    );
-    assert_eq!(
-        std::fs::read_to_string(base.join("nv_dynamic_boost").join("current_value"))
-            .unwrap()
-            .trim(),
-        "3"
-    );
-}

asusd/tests/sysfs_nv_tgp_acdc.rs

@@ -1,71 +0,0 @@
-use std::fs::{create_dir_all, File};
-use std::io::Write;
-use std::path::PathBuf;
-
-use tempfile::tempdir;
-
-use asusd::asus_armoury::set_config_or_default;
-use asusd::config::Config;
-use rog_platform::asus_armoury::FirmwareAttributes;
-use rog_platform::platform::PlatformProfile;
-
-fn write_attr_dir(base: &PathBuf, name: &str, default: &str, display: &str) {
-    let attr_dir = base.join(name);
-    create_dir_all(&attr_dir).unwrap();
-
-    let mut f = File::create(attr_dir.join("default_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-    let mut f = File::create(attr_dir.join("display_name")).unwrap();
-    write!(f, "{}", display).unwrap();
-    // create current_value file so set_current_value can open for write
-    let mut f = File::create(attr_dir.join("current_value")).unwrap();
-    write!(f, "{}", default).unwrap();
-}
-
-#[test]
-fn nv_tgp_ac_dc_applies_different_values() {
-    let td = tempdir().unwrap();
-    let base = td.path().join("attributes");
-    create_dir_all(&base).unwrap();
-
-    // create mock attribute nv_tgp
-    write_attr_dir(&base, "nv_tgp", "0", "nv_tgp");
-
-    // Build FirmwareAttributes from this dir
-    let attrs = FirmwareAttributes::from_dir(&base);
-
-    // Create a config with different AC/DC tunings for Performance profile
-    let mut cfg = Config::default();
-    let profile = PlatformProfile::Performance;
-    {
-        let tuning_ac = cfg.select_tunings(true, profile);
-        tuning_ac.enabled = true;
-        tuning_ac
-            .group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::DgpuTgp, 123);
-
-        let tuning_dc = cfg.select_tunings(false, profile);
-        tuning_dc.enabled = true;
-        tuning_dc
-            .group
-            .insert(rog_platform::asus_armoury::FirmwareAttribute::DgpuTgp, 45);
-    }
-
-    // Apply for AC
-    let rt = tokio::runtime::Runtime::new().unwrap();
-    rt.block_on(async {
-        set_config_or_default(&attrs, &mut cfg, true, profile).await;
-    });
-
-    let nv_tgp_val_path = base.join("nv_tgp").join("current_value");
-    let val_ac = std::fs::read_to_string(&nv_tgp_val_path).unwrap();
-    assert_eq!(val_ac.trim(), "123");
-
-    // Now apply for DC
-    rt.block_on(async {
-        set_config_or_default(&attrs, &mut cfg, false, profile).await;
-    });
-
-    let val_dc = std::fs::read_to_string(&nv_tgp_val_path).unwrap();
-    assert_eq!(val_dc.trim(), "45");
-}

data/asusd.service

@@ -6,7 +6,10 @@ After=nvidia-powerd.service systemd-udevd.service
 
 [Service]
 Environment=IS_SERVICE=1
-Environment=RUST_LOG="debug"
+# Reduce noisy span logs while keeping useful debug info for asusd and related crates.
+# Keep global level at info but allow debug for our crates; silence tracing::span (very noisy)
+# RUST_LOG format: <module>=<level>,...  (levels: error,warn,info,debug,trace)
+Environment=RUST_LOG="info,asusd=debug,rog_platform=debug,tracing::span=error"
 # required to prevent init issues with hid_asus and MCU
 ExecStartPre=/bin/sleep 1
 ExecStart=/usr/bin/asusd

distro-packaging/asusctl.spec

@@ -1,145 +0,0 @@
-#
-# spec file for package asus-nb-ctrl
-#
-# Copyright (c) 2020-2025 Luke Jones <luke@ljones.dev>
-#
-# All modifications and additions to the file contributed by third parties
-# remain the property of their copyright owners, unless otherwise agreed
-# upon. The license for this file, and modifications and additions to the
-# file, is the same license as for the pristine package itself (unless the
-# license for the pristine package is not an Open Source License, in which
-# case the license is the MIT License). An "Open Source License" is a
-# license that conforms to the Open Source Definition (Version 1.9)
-# published by the Open Source Initiative.
-
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at https://mozilla.org/MPL/2.0/.
-
-%if %{defined fedora}
-%global debug_package %{nil}
-%endif
-
-%define version 6.1.17
-%define specrelease %{?dist}
-%define pkg_release 9%{specrelease}
-
-# Use hardening ldflags.
-%global rustflags -Clink-arg=-Wl,-z,relro,-z,now
-Name:    asusctl
-Version: %{version}
-Release: %{pkg_release}
-Summary: Control fan speeds, LEDs, graphics modes, and charge levels for ASUS notebooks
-License: MPLv2
-Requires: power-profiles-daemon
-
-Group:   System Environment/Kernel
-
-URL:     https://gitlab.com/asus-linux/asusctl
-Source:  https://gitlab.com/asus-linux/asusctl/-/archive/%{version}/%{name}-%{version}.tar.gz
-
-%if %{defined fedora}
-BuildRequires:  rust-packaging
-BuildRequires:  systemd-rpm-macros
-%else
-BuildRequires:  cargo-packaging
-%endif
-BuildRequires:  git
-BuildRequires:  clang-devel
-BuildRequires:  cargo
-BuildRequires:  cmake
-BuildRequires:  rust
-BuildRequires:  rust-std-static
-BuildRequires:  pkgconfig(gbm)
-BuildRequires:  pkgconfig(libinput)
-BuildRequires:  pkgconfig(libseat)
-BuildRequires:  pkgconfig(libudev)
-BuildRequires:  pkgconfig(xkbcommon)
-BuildRequires:  pkgconfig(libzstd)
-BuildRequires:  desktop-file-utils
-
-%description
-asus-nb-ctrl is a utility for Linux to control many aspects of various
-ASUS laptops but can also be used with non-Asus laptops with reduced features.
-
-It provides an interface for rootless control of some system functions such as
-fan speeds, keyboard LEDs, battery charge level, and graphics modes.
-asus-nb-ctrl enables third-party apps to use the above with dbus methods.
-
-%package rog-gui
-Summary: An experimental GUI for %{name}
-
-%description rog-gui
-A one-stop-shop GUI tool for asusd/asusctl. It aims to provide most controls,
-a notification service, and ability to run in the background.
-
-%prep
-%autosetup
-%if %{defined fedora}
-%cargo_prep
-sed -i 's|offline = true|offline = false|' .cargo/config.toml
-sed -i 's|source.crates-io|source.ignore_this|' .cargo/config.toml
-%else
-mkdir -p .cargo
-cat > .cargo/config.toml << 'EOF'
-[term]
-verbose = true
-[net]
-offline = false
-EOF
-%endif
-
-%build
-export RUSTFLAGS="%{rustflags}"
-%if %{defined fedora}
-%# Use an explicit cargo invocation for Fedora to avoid the macro adding `--locked`.
-%# `--locked` breaks Fedora builds because the lockfile may not be appropriate for the distro buildroot.
-/usr/bin/cargo auditable build --release
-%else
-/usr/bin/cargo auditable build --release
-%endif
-
-%install
-export RUSTFLAGS="%{rustflags}"
-mkdir -p "%{buildroot}/%{_bindir}" "%{buildroot}%{_docdir}"
-%make_install
-
-install -D -m 0644 README.md %{buildroot}/%{_docdir}/%{name}/README.md
-install -D -m 0644 rog-anime/README.md %{buildroot}/%{_docdir}/%{name}/README-anime.md
-install -D -m 0644 rog-anime/data/diagonal-template.png %{buildroot}/%{_docdir}/%{name}/diagonal-template.png
-
-desktop-file-validate %{buildroot}/%{_datadir}/applications/rog-control-center.desktop
-
-%files
-%license LICENSE
-%{_bindir}/asusd
-%{_bindir}/asusd-user
-%{_bindir}/asusctl
-%{_unitdir}/asusd.service
-%{_userunitdir}/asusd-user.service
-%{_udevrulesdir}/99-asusd.rules
-#%dir %{_sysconfdir}/asusd/
-%{_datadir}/asusd/aura_support.ron
-%{_datadir}/dbus-1/system.d/asusd.conf
-%{_datadir}/icons/hicolor/512x512/apps/asus_notif_yellow.png
-%{_datadir}/icons/hicolor/512x512/apps/asus_notif_green.png
-%{_datadir}/icons/hicolor/512x512/apps/asus_notif_red.png
-%{_datadir}/icons/hicolor/512x512/apps/asus_notif_blue.png
-%{_datadir}/icons/hicolor/512x512/apps/asus_notif_orange.png
-%{_datadir}/icons/hicolor/512x512/apps/asus_notif_white.png
-%{_datadir}/icons/hicolor/scalable/status/gpu-compute.svg
-%{_datadir}/icons/hicolor/scalable/status/gpu-hybrid.svg
-%{_datadir}/icons/hicolor/scalable/status/gpu-integrated.svg
-%{_datadir}/icons/hicolor/scalable/status/gpu-nvidia.svg
-%{_datadir}/icons/hicolor/scalable/status/gpu-vfio.svg
-%{_datadir}/icons/hicolor/scalable/status/notification-reboot.svg
-%{_docdir}/%{name}/
-%{_datadir}/asusd/
-
-%files rog-gui
-%{_bindir}/rog-control-center
-%{_datadir}/applications/rog-control-center.desktop
-%{_datadir}/icons/hicolor/512x512/apps/rog-control-center.png
-%{_datadir}/rog-gui
-
-%changelog

rog-anime/src/data.rs

@@ -63,6 +63,7 @@ pub enum AnimeType {
     GA401,
     GA402,
     GU604,
+    G635L,
     #[default]
     Unsupported,
 }
@@ -75,6 +76,7 @@ impl FromStr for AnimeType {
             "ga401" | "GA401" => Self::GA401,
             "ga402" | "GA402" => Self::GA402,
             "gu604" | "GU604" => Self::GU604,
+            "g635L" | "G635L" => Self::G635L,
             _ => Self::Unsupported,
         })
     }
@@ -89,6 +91,8 @@ impl AnimeType {
             AnimeType::GA402
         } else if board_name.contains("GU604V") {
             AnimeType::GU604
+        } else if board_name.contains("G635L") || board_name.contains("G635L") {
+            AnimeType::G635L
         } else {
             AnimeType::Unsupported
         }
@@ -180,7 +184,9 @@ impl TryFrom<AnimeDataBuffer> for AnimePacketType {
 
         let mut buffers = match anime.anime {
             AnimeType::GA401 => vec![[0; 640]; 2],
-            AnimeType::GA402 | AnimeType::GU604 | AnimeType::Unsupported => vec![[0; 640]; 3],
+            AnimeType::GA402 | AnimeType::GU604 | AnimeType::G635L | AnimeType::Unsupported => {
+                vec![[0; 640]; 3]
+            }
         };
 
         for (idx, chunk) in anime.data.as_slice().chunks(PANE_LEN).enumerate() {

rog-anime/src/usb.rs

@@ -251,6 +251,8 @@ pub fn get_anime_type() -> AnimeType {
         AnimeType::GA402
     } else if board_name.contains("GU604V") {
         AnimeType::GU604
+    } else if board_name.contains("G635L") {
+        AnimeType::G635L
     } else {
         AnimeType::Unsupported
     }

rog-aura/data/aura_support.ron

@@ -44,6 +44,15 @@
         advanced_type: r#None,
         power_zones: [Keyboard],
     ),
+    (
+        device_name: "FA617XS",
+        product_id: "",
+        layout_name: "fx505d",
+        basic_modes: [Static, Breathe, Pulse],
+        basic_zones: [],
+        advanced_type: r#None,
+        power_zones: [Keyboard],
+    ),
     (
         device_name: "FX505",
         product_id: "",
@@ -242,6 +251,15 @@
         advanced_type: PerKey,
         power_zones: [Keyboard],
     ),
+    (
+        device_name: "G614FR",
+        product_id: "",
+        layout_name: "g634j-per-key",
+        basic_modes: [Static, Breathe, RainbowCycle, RainbowWave, Star, Rain, Highlight, Laser, Ripple, Pulse, Comet, Flash],
+        basic_zones: [],
+        advanced_type: PerKey,
+        power_zones: [Keyboard, Lightbar, Logo],
+    ),
     (
         device_name: "G614J",
         product_id: "",
@@ -287,6 +305,15 @@
         advanced_type: PerKey,
         power_zones: [Keyboard, Lightbar, Logo, RearGlow],
     ),
+    (
+            device_name: "G635L",
+            product_id: "",
+            layout_name: "g635l-per-key",
+            basic_modes: [Static, Breathe, RainbowCycle, RainbowWave, Star, Rain, Highlight, Laser, Ripple, Pulse, Comet, Flash],
+            basic_zones: [],
+            advanced_type: PerKey,
+            power_zones: [Keyboard, Lightbar, Logo],
+    ),
     (
         device_name: "G712LI",
         product_id: "",
@@ -908,4 +935,4 @@
         advanced_type: r#None,
         power_zones: [Ally],
     ),
-])
+])

rog-aura/data/layouts/g635l-per-key_US.ron

@@ -0,0 +1,375 @@
+(
+    locale: "US",
+    key_shapes: {
+        "regular": Led(
+            width: 1.0,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "regular_spacing": Blank(
+            width: 1.2,
+            height: 0.0,
+        ),
+        "rog_row": Led(
+            width: 1.0,
+            height: 0.7,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.6,
+        ),
+        "rog_row_blocking": Blank(
+            width: 1.2,
+            height: 0.0,
+        ),
+        "func_space": Blank(
+            width: 0.6,
+            height: 0.0,
+        ),
+        "backspace": Led(
+            width: 2.2,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "tab": Led(
+            width: 1.6,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "backslash": Led(
+            width: 1.6,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "capsplonk": Led(
+            width: 2.0,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "return": Led(
+            width: 2.4,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "lshift": Led(
+            width: 2.6,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "rshift": Led(
+            width: 3.0,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "lctrl": Led(
+            width: 1.4,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "spacebar": Led(
+            width: 5.8,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "rctrl": Led(
+            width: 1.2,
+            height: 1.0,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "up_arrow": Led(
+            width: 0.8,
+            height: 0.8,
+            pad_left: 1.1,
+            pad_right: 1.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+        ),
+        "arrows_spacer": Blank(
+            width: 15.0,
+            height: 0.0,
+        ),
+        "arrows": Led(
+            width: 0.8,
+            height: 0.8,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: -0.1,
+            pad_bottom: 0.1,
+        ),
+        "row_end_spacing": Blank(
+            width: 0.4,
+            height: 0.0,
+        ),
+        "lid_logo": Led(
+            width: 2.6,
+            height: 1.2,
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.8,
+            pad_bottom: 0.0,
+        ),
+        "lightbar_left": Led(
+            width: 0.6,
+            height: 3.6,
+            pad_left: -1.2,
+            pad_right: 0.2,
+            pad_top: -3.0,
+            pad_bottom: 0.3,
+        ),
+        "lightbar_corner_left": Led(
+            width: 0.8,
+            height: 0.6,
+            pad_left: -0.6,
+            pad_right: 0.2,
+            pad_top: 0.8,
+            pad_bottom: 0.0,
+        ),
+        "lightbar_bottom": Led(
+            width: 12.6,
+            height: 0.5,
+            pad_left: -0.1,
+            pad_right: -0.1,
+            pad_top: 0.8,
+            pad_bottom: 0.0,
+        ),
+        "lightbar_corner_right": Led(
+            width: 0.8,
+            height: 0.6,
+            pad_left: 0.0,
+            pad_right: 0.2,
+            pad_top: 0.8,
+            pad_bottom: 0.0,
+        ),
+        "lightbar_right": Led(
+            width: 0.6,
+            height: 3.6,
+            pad_left: -0.8,
+            pad_right: 0.2,
+            pad_top: -3.0,
+            pad_bottom: 0.3,
+        ),
+    },
+    key_rows: [
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (Blocking, "rog_row_blocking"),
+                (Blocking, "rog_row_blocking"),
+                (VolDown, "rog_row"),
+                (VolUp, "rog_row"),
+                (MicMute, "rog_row"),
+                (RogFan, "rog_row"),
+                (RogApp, "rog_row"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (Esc, "regular"),
+                (Spacing, "regular_spacing"),
+                (F1, "regular"),
+                (F2, "regular"),
+                (F3, "regular"),
+                (F4, "regular"),
+                (Spacing, "func_space"),
+                (F5, "regular"),
+                (F6, "regular"),
+                (F7, "regular"),
+                (F8, "regular"),
+                (Spacing, "func_space"),
+                (F9, "regular"),
+                (F10, "regular"),
+                (F11, "regular"),
+                (F12, "regular"),
+                (Spacing, "row_end_spacing"),
+                (Del, "regular"), // Should be super/insert
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (Tilde, "regular"),
+                (N1, "regular"),
+                (N2, "regular"),
+                (N3, "regular"),
+                (N4, "regular"),
+                (N5, "regular"),
+                (N6, "regular"),
+                (N7, "regular"),
+                (N8, "regular"),
+                (N9, "regular"),
+                (N0, "regular"),
+                (Hyphen, "regular"),
+                (Equals, "regular"),
+                (Backspace, "backspace"),
+                (Spacing, "row_end_spacing"),
+                (MediaPlay, "regular"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (Tab, "tab"),
+                (Q, "regular"),
+                (W, "regular"),
+                (E, "regular"),
+                (R, "regular"),
+                (T, "regular"),
+                (Y, "regular"),
+                (U, "regular"),
+                (I, "regular"),
+                (O, "regular"),
+                (P, "regular"),
+                (LBracket, "regular"),
+                (RBracket, "regular"),
+                (BackSlash, "backslash"),
+                (Spacing, "row_end_spacing"),
+                (MediaStop, "regular"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (Caps, "capsplonk"),
+                (A, "regular"),
+                (S, "regular"),
+                (D, "regular"),
+                (F, "regular"),
+                (G, "regular"),
+                (H, "regular"),
+                (J, "regular"),
+                (K, "regular"),
+                (L, "regular"),
+                (SemiColon, "regular"),
+                (Quote, "regular"),
+                (Return, "return"),
+                (Spacing, "row_end_spacing"),
+                (MediaNext, "regular"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (LShift, "lshift"),
+                (Z, "regular"),
+                (X, "regular"),
+                (C, "regular"),
+                (V, "regular"),
+                (B, "regular"),
+                (N, "regular"),
+                (M, "regular"),
+                (Comma, "regular"),
+                (Period, "regular"),
+                (FwdSlash, "regular"),
+                (Rshift, "rshift"),
+                (Spacing, "row_end_spacing"),
+                (MediaPrev, "regular"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (LCtrl, "lctrl"),
+                (LFn, "regular"),
+                (Meta, "regular"),
+                (LAlt, "regular"),
+                (Spacebar, "spacebar"),
+                (RAlt, "regular"),
+                (PrtSc, "regular"),
+                (RCtrl, "rctrl"),
+                (Up, "up_arrow"),
+                (Spacing, "row_end_spacing"),
+                (PrtSc, "regular"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (Spacing, "arrows_spacer"),
+                (Left, "arrows"),
+                (Down, "arrows"),
+                (Right, "arrows"),
+            ],
+        ),
+        (
+            pad_left: 6.5,
+            pad_right: 6.5,
+            pad_top: 0.2,
+            pad_bottom: 0.1,
+            row: [
+                (LidLogo, "lid_logo"),
+            ],
+        ),
+        (
+            pad_left: 0.1,
+            pad_right: 0.1,
+            pad_top: 0.1,
+            pad_bottom: 0.1,
+            row: [
+                (LightbarLeft, "lightbar_left"),
+                (LightbarLeftCorner, "lightbar_corner_left"),
+                (LightbarLeftBottom, "lightbar_bottom"),
+                (LightbarRightBottom, "lightbar_bottom"),
+                (LightbarRightCorner, "lightbar_corner_right"),
+                (LightbarRight, "lightbar_right"),
+            ],
+        ),
+    ],
+)

rog-aura/src/aura_detection.rs

@@ -164,29 +164,26 @@ impl LedSupportFile {
             return Some(data);
         }
 
-        // If the system-wide support files were not available (e.g. running
+        // If the system-wide files were not found (typical in CI or
-        // tests in CI or a development environment) try to load the
+        // development environments), attempt to load the bundled
-        // bundled test data shipped with the crate under `data/aura_support.ron`.
+        // `data/aura_support.ron` from the crate so tests and local runs
-        // This allows unit tests to run without requiring files to be installed
+        // behave the same as when the package is installed.
-        // to `/usr/share/asusd`.
+        // Attempt to load a bundled `aura_support.ron` included at compile time.
-        let mut bundled = std::path::PathBuf::from(env!("CARGO_MANIFEST_DIR"));
+        // Using `include_str!` ensures the data is available regardless of
-        bundled.push("data/aura_support.ron");
+        // runtime `CARGO_MANIFEST_DIR` or CI environment differences.
-        if let Ok(buf) = std::fs::read_to_string(&bundled) {
+        let bundled_buf = include_str!("../data/aura_support.ron");
-            if let Ok(mut tmp) = ron::from_str::<LedSupportFile>(&buf) {
+        if !bundled_buf.is_empty() {
-                data.0.append(&mut tmp.0);
+            if let Ok(tmp) = ron::from_str::<LedSupportFile>(bundled_buf) {
+                data.0.append(&mut tmp.0.clone());
                 data.0.sort_by(|a, b| a.device_name.cmp(&b.device_name));
-                info!("Loaded bundled LED support data from {}", bundled.display());
+                info!("Loaded bundled LED support data (embedded)");
                 return Some(data);
             } else {
-                warn!(
+                warn!("Could not parse embedded bundled data file");
-                    "Bundled aura_support.ron present but failed to parse: {}",
-                    bundled.display()
-                );
             }
-        } else {
-            warn!("Does {} exist?", ASUS_LED_MODE_USER_CONF);
         }
 
+        warn!("Does {} exist?", ASUS_LED_MODE_USER_CONF);
         None
     }
 }

rog-control-center/src/cli_options.rs

@@ -24,6 +24,4 @@ pub struct CliStart {
                 that might match your laptop"
     )]
     pub layout_viewing: bool,
-    #[options(help = "start in tray mode - main window hidden")]
-    pub tray_mode: bool,
 }

rog-control-center/src/main.rs

@@ -24,11 +24,16 @@ use tokio::runtime::Runtime;
 
 #[tokio::main]
 async fn main() -> Result<()> {
+    // Ensure tracing spans are quiet by default unless user overrides
+    if std::env::var_os("RUST_LOG").is_none() {
+        std::env::set_var("RUST_LOG", "warn,tracing=error,zbus=error");
+    }
     let mut logger = env_logger::Builder::new();
     logger
-        .filter_level(LevelFilter::Warn)
         .parse_default_env()
-        .target(env_logger::Target::Stdout)
+        .filter_level(LevelFilter::Info)
+        .parse_default_env()
+        .target(env_logger::Target::Stderr)
         .format_timestamp(None)
         .init();
 
@@ -140,22 +145,12 @@ async fn main() -> Result<()> {
         config.startup_in_background = false;
         config.start_fullscreen = true;
     }
-
-    if cli_parsed.tray_mode {
-        config.enable_tray_icon = true;
-        config.run_in_background = true;
-        config.startup_in_background = true;
-    }
-
     config.write();
 
     let enable_tray_icon = config.enable_tray_icon;
     let startup_in_background = config.startup_in_background;
     let config = Arc::new(Mutex::new(config));
 
-    // shared weak handle to the UI so other threads can request UI updates
-    let ui_handle: Arc<Mutex<Option<slint::Weak<MainWindow>>>> = Arc::new(Mutex::new(None));
-
     start_notifications(config.clone(), &rt)?;
 
     if enable_tray_icon {
@@ -180,14 +175,12 @@ async fn main() -> Result<()> {
         slint::init_translations!(concat!(env!("CARGO_MANIFEST_DIR"), "/translations/"));
     }
 
-    let config_for_ui = config.clone();
-    let ui_handle_for_thread = ui_handle.clone();
     thread::spawn(move || {
         let mut state = AppState::StartingUp;
         loop {
             if is_rog_ally {
-                let config_copy_2 = config_for_ui.clone();
+                let config_copy_2 = config.clone();
-                let newui = setup_window(config_for_ui.clone());
+                let newui = setup_window(config.clone());
                 newui.window().on_close_requested(move || {
                     exit(0);
                 });
@@ -223,19 +216,13 @@ async fn main() -> Result<()> {
                         *app_state = AppState::MainWindowOpen;
                     }
 
-                    let config_copy = config_for_ui.clone();
+                    let config_copy = config.clone();
                     let app_state_copy = app_state.clone();
-                    let ui_handle_for_ui = ui_handle_for_thread.clone();
                     slint::invoke_from_event_loop(move || {
-                        let ui_handle_for_ui = ui_handle_for_ui.clone();
                         UI.with(|ui| {
                             let app_state_copy = app_state_copy.clone();
                             let mut ui = ui.borrow_mut();
                             if let Some(ui) = ui.as_mut() {
-                                // store weak handle so other threads can update UI globals
-                                if let Ok(mut h) = ui_handle_for_ui.lock() {
-                                    *h = Some(ui.as_weak());
-                                }
                                 ui.window().show().unwrap();
                                 ui.window().on_close_requested(move || {
                                     if let Ok(mut app_state) = app_state_copy.lock() {
@@ -246,10 +233,6 @@ async fn main() -> Result<()> {
                             } else {
                                 let config_copy_2 = config_copy.clone();
                                 let newui = setup_window(config_copy);
-                                // store weak handle for the newly created UI
-                                if let Ok(mut h) = ui_handle_for_ui.lock() {
-                                    *h = Some(newui.as_weak());
-                                }
                                 newui.window().on_close_requested(move || {
                                     if let Ok(mut app_state) = app_state_copy.lock() {
                                         *app_state = AppState::MainWindowClosed;
@@ -285,8 +268,8 @@ async fn main() -> Result<()> {
                     slint::quit_event_loop().unwrap();
                     exit(0);
                 } else if state != AppState::MainWindowOpen {
-                    if let Ok(cfg) = config_for_ui.lock() {
+                    if let Ok(config) = config.lock() {
-                        if !cfg.run_in_background {
+                        if !config.run_in_background {
                             slint::quit_event_loop().unwrap();
                             exit(0);
                         }
@@ -296,67 +279,11 @@ async fn main() -> Result<()> {
         }
     });
 
-    // start config watcher to pick up external edits
-    spawn_config_watcher(config.clone(), ui_handle.clone());
-
     slint::run_event_loop_until_quit().unwrap();
     rt.shutdown_background();
     Ok(())
 }
 
-// Spawn a watcher thread that polls the config file and reloads it when modified.
-// This keeps the running rogcc instance in sync with manual edits to the config file.
-fn spawn_config_watcher(
-    config: Arc<Mutex<Config>>,
-    ui_handle: Arc<Mutex<Option<slint::Weak<MainWindow>>>>,
-) {
-    std::thread::spawn(move || {
-        use std::time::SystemTime;
-        let cfg_path = Config::config_dir().join(Config::new().file_name());
-        let mut last_mtime: Option<SystemTime> = None;
-        loop {
-            if let Ok(meta) = std::fs::metadata(&cfg_path) {
-                if let Ok(m) = meta.modified() {
-                    if last_mtime.is_none() {
-                        last_mtime = Some(m);
-                    } else if last_mtime.is_some_and(|t| t < m) {
-                        // file changed, reload
-                        last_mtime = Some(m);
-                        let new_cfg = Config::new().load();
-                        if let Ok(mut lock) = config.lock() {
-                            *lock = new_cfg.clone();
-                        }
-
-                        // Update UI app settings globals if UI is present
-                        if let Ok(maybe_weak) = ui_handle.lock() {
-                            if let Some(weak) = maybe_weak.clone() {
-                                let config_for_ui = config.clone();
-                                weak.upgrade_in_event_loop(move |w| {
-                                    if let Ok(lock) = config_for_ui.lock() {
-                                        let cfg = lock.clone();
-                                        w.global::<rog_control_center::AppSettingsPageData>()
-                                            .set_run_in_background(cfg.run_in_background);
-                                        w.global::<rog_control_center::AppSettingsPageData>()
-                                            .set_startup_in_background(cfg.startup_in_background);
-                                        w.global::<rog_control_center::AppSettingsPageData>()
-                                            .set_enable_tray_icon(cfg.enable_tray_icon);
-                                        w.global::<rog_control_center::AppSettingsPageData>()
-                                            .set_enable_dgpu_notifications(
-                                                cfg.notifications.enabled,
-                                            );
-                                    }
-                                })
-                                .ok();
-                            }
-                        }
-                    }
-                }
-            }
-            std::thread::sleep(std::time::Duration::from_secs(2));
-        }
-    });
-}
-
 fn do_cli_help(parsed: &CliStart) -> bool {
     if parsed.help {
         println!("{}", CliStart::usage());

rog-control-center/src/mocking.rs

@@ -100,31 +100,6 @@ impl Bios {
     pub fn set_panel_od(&self, _b: bool) -> Result<()> {
         Ok(())
     }
-
-    // Mock NV/dGPU tunables
-    pub fn nv_dynamic_boost(&self) -> Result<i16> {
-        Ok(0)
-    }
-
-    pub fn set_nv_dynamic_boost(&self, _v: i16) -> Result<()> {
-        Ok(())
-    }
-
-    pub fn nv_temp_target(&self) -> Result<i16> {
-        Ok(0)
-    }
-
-    pub fn set_nv_temp_target(&self, _v: i16) -> Result<()> {
-        Ok(())
-    }
-
-    pub fn nv_tgp(&self) -> Result<i16> {
-        Ok(0)
-    }
-
-    pub fn set_nv_tgp(&self, _v: i16) -> Result<()> {
-        Ok(())
-    }
 }
 
 pub struct Profile;

rog-control-center/src/ui/setup_system.rs

@@ -130,51 +130,6 @@ macro_rules! init_minmax_property {
 
 // For handling callbacks from UI value changes
 macro_rules! setup_callback {
-    // Minmax (AttrMinMax) variant - pass an extra `minmax` token
-    ($property:ident, $handle:expr, $attr:expr, $type:tt, minmax) => {
-        let handle_copy = $handle.as_weak();
-        let proxy_copy = $attr.clone();
-        concat_idents!(on_callback = on_cb_, $property {
-            $handle
-                .global::<SystemPageData>()
-                .on_callback(move |v| {
-                    let handle_copy = handle_copy.clone();
-                    let proxy_copy = proxy_copy.clone();
-                    tokio::spawn(async move {
-                        let res = proxy_copy
-                            .set_current_value(convert_to_dbus!($type, v))
-                            .await;
-                        show_toast(
-                            format!("{} successfully set to {}", stringify!($property), v).into(),
-                            format!("Setting {} failed", stringify!($property)).into(),
-                            handle_copy.clone(),
-                            res.clone(),
-                        );
-
-                        if res.is_ok() {
-                            let min_v = proxy_copy.min_value().await.unwrap_or(-1);
-                            let max_v = proxy_copy.max_value().await.unwrap_or(-1);
-                            if let Ok(cur_val) = proxy_copy.current_value().await {
-                                let cur_f = cur_val as f32;
-                                handle_copy
-                                    .upgrade_in_event_loop(move |handle| {
-                                        concat_idents!(setter = set_, $property {
-                                            handle.global::<SystemPageData>().setter(AttrMinMax {
-                                                min: min_v,
-                                                max: max_v,
-                                                current: cur_f,
-                                            });
-                                        });
-                                    })
-                                    .ok();
-                            }
-                        }
-                    });
-                });
-        });
-    };
-
-    // Scalar variant (i32/bool/f32) - update scalar setter with authoritative value
     ($property:ident, $handle:expr, $attr:expr, $type:tt) => {
         let handle_copy = $handle.as_weak();
         let proxy_copy = $attr.clone();
@@ -185,28 +140,12 @@ macro_rules! setup_callback {
                     let handle_copy = handle_copy.clone();
                     let proxy_copy = proxy_copy.clone();
                     tokio::spawn(async move {
-                        let res = proxy_copy
-                            .set_current_value(convert_to_dbus!($type, v))
-                            .await;
                         show_toast(
                             format!("{} successfully set to {}", stringify!($property), v).into(),
                             format!("Setting {} failed", stringify!($property)).into(),
-                            handle_copy.clone(),
+                            handle_copy,
-                            res.clone(),
+                            proxy_copy.set_current_value(convert_to_dbus!($type, v)).await,
                         );
-
-                        if res.is_ok() {
-                            // Query authoritative value and set scalar global
-                            if let Ok(cur_val) = proxy_copy.current_value().await {
-                                handle_copy.upgrade_in_event_loop(move |handle| {
-                                    concat_idents!(setter = set_, $property {
-                                        handle
-                                            .global::<SystemPageData>()
-                                            .setter(convert_value!($type, cur_val));
-                                    });
-                                }).ok();
-                            }
-                        }
                     });
                 });
         });
@@ -676,49 +615,49 @@ pub fn setup_system_page_callbacks(ui: &MainWindow, _states: Arc<Mutex<Config>>)
                             }
                             FirmwareAttribute::PptPl1Spl => {
                                 init_minmax_property!(ppt_pl1_spl, handle, attr);
-                                setup_callback!(ppt_pl1_spl, handle, attr, i32, minmax);
+                                setup_callback!(ppt_pl1_spl, handle, attr, i32);
                                 setup_callback_restore_default!(ppt_pl1_spl, handle, attr);
                                 setup_minmax_external!(ppt_pl1_spl, handle, attr, platform);
                             }
                             FirmwareAttribute::PptPl2Sppt => {
                                 init_minmax_property!(ppt_pl2_sppt, handle, attr);
-                                setup_callback!(ppt_pl2_sppt, handle, attr, i32, minmax);
+                                setup_callback!(ppt_pl2_sppt, handle, attr, i32);
                                 setup_callback_restore_default!(ppt_pl2_sppt, handle, attr);
                                 setup_minmax_external!(ppt_pl2_sppt, handle, attr, platform);
                             }
                             FirmwareAttribute::PptPl3Fppt => {
                                 init_minmax_property!(ppt_pl3_fppt, handle, attr);
-                                setup_callback!(ppt_pl3_fppt, handle, attr, i32, minmax);
+                                setup_callback!(ppt_pl3_fppt, handle, attr, i32);
                                 setup_callback_restore_default!(ppt_pl3_fppt, handle, attr);
                                 setup_minmax_external!(ppt_pl3_fppt, handle, attr, platform);
                             }
                             FirmwareAttribute::PptFppt => {
                                 init_minmax_property!(ppt_fppt, handle, attr);
-                                setup_callback!(ppt_fppt, handle, attr, i32, minmax);
+                                setup_callback!(ppt_fppt, handle, attr, i32);
                                 setup_callback_restore_default!(ppt_fppt, handle, attr);
                                 setup_minmax_external!(ppt_fppt, handle, attr, platform);
                             }
                             FirmwareAttribute::PptApuSppt => {
                                 init_minmax_property!(ppt_apu_sppt, handle, attr);
-                                setup_callback!(ppt_apu_sppt, handle, attr, i32, minmax);
+                                setup_callback!(ppt_apu_sppt, handle, attr, i32);
                                 setup_callback_restore_default!(ppt_apu_sppt, handle, attr);
                                 setup_minmax_external!(ppt_apu_sppt, handle, attr, platform);
                             }
                             FirmwareAttribute::PptPlatformSppt => {
                                 init_minmax_property!(ppt_platform_sppt, handle, attr);
-                                setup_callback!(ppt_platform_sppt, handle, attr, i32, minmax);
+                                setup_callback!(ppt_platform_sppt, handle, attr, i32);
                                 setup_callback_restore_default!(ppt_platform_sppt, handle, attr);
                                 setup_minmax_external!(ppt_platform_sppt, handle, attr, platform);
                             }
                             FirmwareAttribute::NvDynamicBoost => {
                                 init_minmax_property!(nv_dynamic_boost, handle, attr);
-                                setup_callback!(nv_dynamic_boost, handle, attr, i32, minmax);
+                                setup_callback!(nv_dynamic_boost, handle, attr, i32);
                                 setup_callback_restore_default!(nv_dynamic_boost, handle, attr);
                                 setup_minmax_external!(nv_dynamic_boost, handle, attr, platform);
                             }
                             FirmwareAttribute::NvTempTarget => {
                                 init_minmax_property!(nv_temp_target, handle, attr);
-                                setup_callback!(nv_temp_target, handle, attr, i32, minmax);
+                                setup_callback!(nv_temp_target, handle, attr, i32);
                                 setup_callback_restore_default!(nv_temp_target, handle, attr);
                                 setup_minmax_external!(nv_temp_target, handle, attr, platform);
                             }

rog-control-center/src/zbus_proxies.rs

@@ -89,7 +89,7 @@ where
         }
     }
     if paths.len() > 1 {
-        println!("Multiple asusd interfaces devices found");
+        log::warn!("Multiple asusd interfaces devices found");
     }
     if !paths.is_empty() {
         let mut ctrl = Vec::new();
@@ -129,7 +129,7 @@ where
         }
     }
     if paths.len() > 1 {
-        println!("Multiple asusd interfaces devices found");
+        log::warn!("Multiple asusd interfaces devices found");
     }
     if !paths.is_empty() {
         let mut ctrl = Vec::new();

rog-platform/src/asus_armoury.rs

@@ -95,7 +95,7 @@ impl Attribute {
             _ => return Err(PlatformError::InvalidValue),
         };
 
-        let mut file = OpenOptions::new().write(true).truncate(true).open(&path)?;
+        let mut file = OpenOptions::new().write(true).open(&path)?;
         file.write_all(value_str.as_bytes())?;
         Ok(())
     }
@@ -244,37 +244,6 @@ impl FirmwareAttributes {
         Self { attrs }
     }
 
-    /// Create attributes collection from an arbitrary base directory. Intended for tests
-    /// where a fake sysfs-like layout can be supplied.
-    pub fn from_dir(base_dir: &std::path::Path) -> Self {
-        let mut attrs = Vec::new();
-        if let Ok(dir) = read_dir(base_dir) {
-            for entry in dir.flatten() {
-                let base_path = entry.path();
-                let name = base_path.file_name().unwrap().to_string_lossy().to_string();
-                if name == "pending_reboot" {
-                    continue;
-                }
-                let help = read_string(&base_path.join("display_name")).unwrap_or_default();
-
-                let (default_value, possible_values, min_value, max_value, scalar_increment) =
-                    Attribute::read_base_values(&base_path);
-
-                attrs.push(Attribute {
-                    name,
-                    help,
-                    default_value,
-                    possible_values,
-                    min_value,
-                    max_value,
-                    scalar_increment,
-                    base_path,
-                });
-            }
-        }
-        Self { attrs }
-    }
-
     pub fn attributes(&self) -> &Vec<Attribute> {
         &self.attrs
     }
@@ -313,8 +282,8 @@ define_attribute_getters!(
     ppt_fppt,
     nv_dynamic_boost,
     nv_temp_target,
-    nv_base_tgp,
+    dgpu_base_tgp,
-    nv_tgp,
+    dgpu_tgp,
     charge_mode,
     boot_sound,
     mcu_powersave,
@@ -331,7 +300,6 @@ define_attribute_getters!(
 /// CamelCase names of the properties. Intended for use with DBUS
 #[repr(u8)]
 #[derive(
-    Debug,
     Clone,
     Copy,
     Serialize,
@@ -394,7 +362,6 @@ impl FirmwareAttribute {
             self,
             FirmwareAttribute::NvDynamicBoost
                 | FirmwareAttribute::NvTempTarget
-                | FirmwareAttribute::DgpuBaseTgp
                 | FirmwareAttribute::DgpuTgp
         )
     }
@@ -415,11 +382,8 @@ impl From<&str> for FirmwareAttribute {
             "ppt_platform_sppt" => Self::PptPlatformSppt,
             "nv_dynamic_boost" => Self::NvDynamicBoost,
             "nv_temp_target" => Self::NvTempTarget,
-            "nv_tgp" => Self::DgpuTgp,
             "nv_base_tgp" => Self::DgpuBaseTgp,
-            /* Backwards compatibility: some kernels expose these attributes with a dgpu_* prefix */
             "dgpu_tgp" => Self::DgpuTgp,
-            "dgpu_base_tgp" => Self::DgpuBaseTgp,
             "charge_mode" => Self::ChargeMode,
             "boot_sound" => Self::BootSound,
             "mcu_powersave" => Self::McuPowersave,
@@ -455,8 +419,8 @@ impl From<FirmwareAttribute> for &str {
             FirmwareAttribute::PptPlatformSppt => "ppt_platform_sppt",
             FirmwareAttribute::NvDynamicBoost => "nv_dynamic_boost",
             FirmwareAttribute::NvTempTarget => "nv_temp_target",
-            FirmwareAttribute::DgpuBaseTgp => "nv_base_tgp",
+            FirmwareAttribute::DgpuBaseTgp => "dgpu_base_tgp",
-            FirmwareAttribute::DgpuTgp => "nv_tgp",
+            FirmwareAttribute::DgpuTgp => "dgpu_tgp",
             FirmwareAttribute::ChargeMode => "charge_mode",
             FirmwareAttribute::BootSound => "boot_sound",
             FirmwareAttribute::McuPowersave => "mcu_powersave",
@@ -555,28 +519,3 @@ mod tests {
         attr.set_current_value(&val).unwrap();
     }
 }
-
-#[cfg(test)]
-mod alias_tests {
-    use super::FirmwareAttribute;
-
-    #[test]
-    fn tgp_aliases_map_to_same_variant() {
-        let nv = FirmwareAttribute::from("nv_tgp");
-        let dgpu = FirmwareAttribute::from("dgpu_tgp");
-        assert_eq!(nv, dgpu);
-
-        let nv_base = FirmwareAttribute::from("nv_base_tgp");
-        let dgpu_base = FirmwareAttribute::from("dgpu_base_tgp");
-        assert_eq!(nv_base, dgpu_base);
-    }
-
-    #[test]
-    fn tgp_canonical_output_is_nv_tgp() {
-        let s: &str = FirmwareAttribute::DgpuTgp.into();
-        assert_eq!(s, "nv_tgp");
-
-        let s_base: &str = FirmwareAttribute::DgpuBaseTgp.into();
-        assert_eq!(s_base, "nv_base_tgp");
-    }
-}

rog-platform/src/power.rs

@@ -101,18 +101,15 @@ impl AsusPower {
             });
         }
 
-        Err(PlatformError::MissingFunction(
+        // No battery found. Return an AsusPower with an empty battery path so
-            "Did not find a battery".to_owned(),
+        // callers can still be constructed and query `has_*` methods which
-        ))
+        // will correctly report absence. This avoids hard-failing on systems
-    }
+        // where the asus-nb-wmi driver loads on desktops with no battery.
-}
+        info!("Did not find a battery, continuing without battery support");
-
+        Ok(Self {
-impl Default for AsusPower {
+            mains,
-    fn default() -> Self {
+            battery: PathBuf::new(),
-        Self {
+            usb,
-            mains: PathBuf::from("/this_shouldNeVErr_exisid"),
+        })
-            battery: PathBuf::from("/this_shouldNeVErr_exisid"),
-            usb: None,
-        }
     }
 }

rust-toolchain.toml

@@ -1,4 +0,0 @@
-[toolchain]
-channel = "stable"
-components = ["rustfmt", "clippy"]
-profile = "minimal"

simulators/src/animatrix/mod.rs

@@ -43,7 +43,7 @@ impl AniMatrix {
                 vertical: 2,
                 horizontal: 5,
             },
-            AnimeType::GA402 | AnimeType::Unsupported => LedShape {
+            AnimeType::GA402 | AnimeType::G635L | AnimeType::Unsupported => LedShape {
                 vertical: 2,
                 horizontal: 5,
             },
@@ -56,7 +56,7 @@ impl AniMatrix {
         // Do a hard mapping of each (derived from wireshardk captures)
         let rows = match model {
             AnimeType::GA401 => GA401.to_vec(),
-            AnimeType::GA402 | AnimeType::Unsupported => GA402.to_vec(),
+            AnimeType::GA402 | AnimeType::G635L | AnimeType::Unsupported => GA402.to_vec(),
             AnimeType::GU604 => GU604.to_vec(),
         };
 

simulators/src/simulator.rs

@@ -157,14 +157,14 @@ fn main() -> Result<(), Box<dyn Error>> {
                 for (x_count, b) in dev.buffer[start..=end].iter().enumerate() {
                     canvas.set_draw_color(Color::RGB(*b, *b, *b));
 
-                    let x: i32 = w + x_count as i32 * w - {
+                    #[allow(clippy::manual_is_multiple_of)]
-                        #[allow(clippy::manual_is_multiple_of)]
+                    let x: i32 = w + x_count as i32 * w
-                        if (y_count + y_offset as usize) % 2 != 0 {
+                        - if (y_count + y_offset as usize) % 2 != 0 {
                             0
                         } else {
                             w / 2
                         }
-                    } + row.3 * w;
+                        + row.3 * w;
                     let y = y_count as i32 * h - y_offset * h;
                     canvas
                         .fill_rect(Rect::new(x, y, w as u32, h as u32))