CLI args for bios. Cleanup and improve

- dbus method for 'supported modes'
- add dedicated gfx safety
- bring ctrl-gfx back in to main control for better integration
- safely upgrade config files

asus-nb/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "asus-nb"
-version = "2.1.2"
+version = "2.2.0"
 license = "MPL-2.0"
 readme = "README.md"
 authors = ["Luke <luke@ljones.dev>"]
@@ -19,7 +19,6 @@ yansi-term = "^0.1"
 rog_fan_curve = { version = "0.1", features = ["serde"] }
 zbus = "^1.8.0"
 zvariant = "^2.4.0"
-ctrl-gfx = { path = "../ctrl-gfx" } 
 
 [dev-dependencies]
 tinybmp = "^0.2.3"

asus-nb/src/core_dbus.rs

@@ -2,7 +2,6 @@ use super::*;
 use crate::cli_options::LedBrightness;
 use crate::fancy::KeyColourArray;
 use crate::profile::ProfileEvent;
-use ctrl_gfx::vendors::GfxVendors;
 use dbus::{blocking::Connection, Message};
 use std::error::Error;
 use std::sync::{
@@ -24,6 +23,8 @@ use crate::dbus_ledmode::{
 use crate::dbus_profile::{
     OrgAsuslinuxDaemon as OrgAsuslinuxDaemonProfile, OrgAsuslinuxDaemonNotifyProfile,
 };
+use crate::dbus_rogbios::OrgAsuslinuxDaemon as OrgAsuslinuxDaemonRogBios;
+use crate::dbus_supported::OrgAsuslinuxDaemon as OrgAsuslinuxDaemonSupported;
 
 // Signals separated out
 pub struct CtrlSignals {
@@ -278,13 +279,13 @@ impl AuraDbusClient {
     }
 
     #[inline]
-    pub fn write_gfx_mode(&self, vendor: GfxVendors) -> Result<(), Box<dyn std::error::Error>> {
+    pub fn write_gfx_mode(&self, vendor: String) -> Result<(), Box<dyn std::error::Error>> {
         let proxy = self.connection.with_proxy(
             "org.asuslinux.Daemon",
             "/org/asuslinux/Gfx",
             Duration::from_secs(30),
         );
-        proxy.set_vendor(<&str>::from(&vendor))?;
+        proxy.set_vendor(&vendor)?;
         Ok(())
     }
 
@@ -358,4 +359,60 @@ impl AuraDbusClient {
         self.write_keyboard_leds(&AuraModes::LedBrightness(level))?;
         Ok(())
     }
+
+    //
+    #[inline]
+    pub fn get_bios_dedicated_gfx(&self) -> Result<i16, Box<dyn std::error::Error>> {
+        let proxy = self.connection.with_proxy(
+            "org.asuslinux.Daemon",
+            "/org/asuslinux/RogBios",
+            Duration::from_secs(2),
+        );
+        let x = proxy.dedicated_graphic_mode()?;
+        Ok(x)
+    }
+
+    #[inline]
+    pub fn set_bios_dedicated_gfx(&self, on: bool) -> Result<(), Box<dyn std::error::Error>> {
+        let proxy = self.connection.with_proxy(
+            "org.asuslinux.Daemon",
+            "/org/asuslinux/RogBios",
+            Duration::from_secs(2),
+        );
+        proxy.set_dedicated_graphic_mode(<bool>::from(on))?;
+        Ok(())
+    }
+
+    #[inline]
+    pub fn get_bios_post_sound(&self) -> Result<i16, Box<dyn std::error::Error>> {
+        let proxy = self.connection.with_proxy(
+            "org.asuslinux.Daemon",
+            "/org/asuslinux/RogBios",
+            Duration::from_secs(2),
+        );
+        let x = proxy.post_boot_sound()?;
+        Ok(x)
+    }
+
+    #[inline]
+    pub fn set_bios_post_sound(&self, on: bool) -> Result<(), Box<dyn std::error::Error>> {
+        let proxy = self.connection.with_proxy(
+            "org.asuslinux.Daemon",
+            "/org/asuslinux/RogBios",
+            Duration::from_secs(2),
+        );
+        proxy.set_post_boot_sound(<bool>::from(on))?;
+        Ok(())
+    }
+
+    #[inline]
+    pub fn get_supported_functions(&self) -> Result<String, Box<dyn std::error::Error>> {
+        let proxy = self.connection.with_proxy(
+            "org.asuslinux.Daemon",
+            "/org/asuslinux/Supported",
+            Duration::from_secs(2),
+        );
+        let x = proxy.supported_functions()?;
+        Ok(x)
+    }
 }

asus-nb/src/dbus_rogbios.rs

@@ -0,0 +1,86 @@
+// This code was autogenerated with `dbus-codegen-rust -s -d org.asuslinux.Daemon -f org.asuslinux.Daemon -c blocking -p /org/asuslinux/RogBios -m None -o asus-nb/src/dbus_rogbios.rs`, see https://github.com/diwic/dbus-rs
+use dbus;
+#[allow(unused_imports)]
+use dbus::arg;
+use dbus::blocking;
+
+pub trait OrgAsuslinuxDaemon {
+    fn set_dedicated_graphic_mode(&self, dedicated: bool) -> Result<(), dbus::Error>;
+    fn dedicated_graphic_mode(&self) -> Result<i16, dbus::Error>;
+    fn set_post_boot_sound(&self, on: bool) -> Result<(), dbus::Error>;
+    fn post_boot_sound(&self) -> Result<i16, dbus::Error>;
+}
+
+impl<'a, T: blocking::BlockingSender, C: ::std::ops::Deref<Target = T>> OrgAsuslinuxDaemon
+    for blocking::Proxy<'a, C>
+{
+    fn set_dedicated_graphic_mode(&self, dedicated: bool) -> Result<(), dbus::Error> {
+        self.method_call(
+            "org.asuslinux.Daemon",
+            "SetDedicatedGraphicMode",
+            (dedicated,),
+        )
+    }
+
+    fn dedicated_graphic_mode(&self) -> Result<i16, dbus::Error> {
+        self.method_call("org.asuslinux.Daemon", "DedicatedGraphicMode", ())
+            .and_then(|r: (i16,)| Ok(r.0))
+    }
+
+    fn set_post_boot_sound(&self, on: bool) -> Result<(), dbus::Error> {
+        self.method_call("org.asuslinux.Daemon", "SetPostBootSound", (on,))
+    }
+
+    fn post_boot_sound(&self) -> Result<i16, dbus::Error> {
+        self.method_call("org.asuslinux.Daemon", "PostBootSound", ())
+            .and_then(|r: (i16,)| Ok(r.0))
+    }
+}
+
+#[derive(Debug)]
+pub struct OrgAsuslinuxDaemonNotifyDedicatedGraphicMode {
+    pub dedicated: bool,
+}
+
+impl arg::AppendAll for OrgAsuslinuxDaemonNotifyDedicatedGraphicMode {
+    fn append(&self, i: &mut arg::IterAppend) {
+        arg::RefArg::append(&self.dedicated, i);
+    }
+}
+
+impl arg::ReadAll for OrgAsuslinuxDaemonNotifyDedicatedGraphicMode {
+    fn read(i: &mut arg::Iter) -> Result<Self, arg::TypeMismatchError> {
+        Ok(OrgAsuslinuxDaemonNotifyDedicatedGraphicMode {
+            dedicated: i.read()?,
+        })
+    }
+}
+
+impl dbus::message::SignalArgs for OrgAsuslinuxDaemonNotifyDedicatedGraphicMode {
+    const NAME: &'static str = "NotifyDedicatedGraphicMode";
+    const INTERFACE: &'static str = "org.asuslinux.Daemon";
+}
+
+#[derive(Debug)]
+pub struct OrgAsuslinuxDaemonNotifyPostBootSound {
+    pub dedicated: bool,
+}
+
+impl arg::AppendAll for OrgAsuslinuxDaemonNotifyPostBootSound {
+    fn append(&self, i: &mut arg::IterAppend) {
+        arg::RefArg::append(&self.dedicated, i);
+    }
+}
+
+impl arg::ReadAll for OrgAsuslinuxDaemonNotifyPostBootSound {
+    fn read(i: &mut arg::Iter) -> Result<Self, arg::TypeMismatchError> {
+        Ok(OrgAsuslinuxDaemonNotifyPostBootSound {
+            dedicated: i.read()?,
+        })
+    }
+}
+
+impl dbus::message::SignalArgs for OrgAsuslinuxDaemonNotifyPostBootSound {
+    const NAME: &'static str = "NotifyPostBootSound";
+    const INTERFACE: &'static str = "org.asuslinux.Daemon";
+}

asus-nb/src/dbus_supported.rs

@@ -0,0 +1,18 @@
+// This code was autogenerated with `dbus-codegen-rust -s -d org.asuslinux.Daemon -f org.asuslinux.Daemon -c blocking -p /org/asuslinux/Supported -m None -o asus-nb/src/dbus_supported.rs`, see https://github.com/diwic/dbus-rs
+use dbus;
+#[allow(unused_imports)]
+use dbus::arg;
+use dbus::blocking;
+
+pub trait OrgAsuslinuxDaemon {
+    fn supported_functions(&self) -> Result<String, dbus::Error>;
+}
+
+impl<'a, T: blocking::BlockingSender, C: ::std::ops::Deref<Target = T>> OrgAsuslinuxDaemon
+    for blocking::Proxy<'a, C>
+{
+    fn supported_functions(&self) -> Result<String, dbus::Error> {
+        self.method_call("org.asuslinux.Daemon", "SupportedFunctions", ())
+            .and_then(|r: (String,)| Ok(r.0))
+    }
+}

asus-nb/src/lib.rs

@@ -23,13 +23,15 @@ pub mod anime_dbus;
 /// Helper functions for the AniMe display
 pub mod anime_matrix;
 
+pub mod error;
+
 pub mod dbus_anime;
 pub mod dbus_charge;
 pub mod dbus_gfx;
 pub mod dbus_ledmode;
 pub mod dbus_profile;
-
-pub mod error;
+pub mod dbus_rogbios;
+pub mod dbus_supported;
 
 // static LED_INIT1: [u8; 2] = [0x5d, 0xb9];
 // static LED_INIT2: &str = "]ASUS Tech.Inc."; // ] == 0x5d

asus-nb/src/profile.rs

@@ -75,7 +75,7 @@ fn parse_fan_curve(data: &str) -> Result<Curve, String> {
 #[derive(Debug, Clone, Options, Serialize, Deserialize)]
 pub struct ProfileCommand {
     #[options(help = "print help message")]
-    help: bool,
+    pub help: bool,
     #[options(help = "toggle to next profile in list")]
     pub next: bool,
     #[options(help = "create the profile if it doesn't exist")]