Fix incorrect stop/start order of nvidia-powerd on AC plug/unplug

This commit is contained in:
Luke D. Jones
2022-12-28 21:30:29 +13:00
parent c2aa81bfe3
commit 29b22cd18e
4 changed files with 16 additions and 12 deletions

View File

@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased] ## [Unreleased]
## [v4.5.8]
### Changed
- Fix incorrect stop/start order of nvidia-powerd on AC plug/unplug
## [v4.5.7] ## [v4.5.7]
### Changed ### Changed
- ROGCC: Don't notify user if changing to same mux mode - ROGCC: Don't notify user if changing to same mux mode

18
Cargo.lock generated
View File

@@ -149,7 +149,7 @@ checksum = "8da52d66c7071e2e3fa2a1e5c6d088fec47b593032b254f5e980de8ea54454d6"
[[package]] [[package]]
name = "asusctl" name = "asusctl"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"daemon", "daemon",
"gif", "gif",
@@ -772,7 +772,7 @@ checksum = "b365fabc795046672053e29c954733ec3b05e4be654ab130fe8f1f94d7051f35"
[[package]] [[package]]
name = "daemon" name = "daemon"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"async-trait", "async-trait",
"concat-idents", "concat-idents",
@@ -796,7 +796,7 @@ dependencies = [
[[package]] [[package]]
name = "daemon-user" name = "daemon-user"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"dirs", "dirs",
"rog_anime", "rog_anime",
@@ -2696,7 +2696,7 @@ dependencies = [
[[package]] [[package]]
name = "rog-control-center" name = "rog-control-center"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"daemon", "daemon",
"dirs", "dirs",
@@ -2726,7 +2726,7 @@ dependencies = [
[[package]] [[package]]
name = "rog_anime" name = "rog_anime"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"gif", "gif",
"glam", "glam",
@@ -2742,7 +2742,7 @@ dependencies = [
[[package]] [[package]]
name = "rog_aura" name = "rog_aura"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"serde", "serde",
"serde_derive", "serde_derive",
@@ -2753,7 +2753,7 @@ dependencies = [
[[package]] [[package]]
name = "rog_dbus" name = "rog_dbus"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"rog_anime", "rog_anime",
"rog_aura", "rog_aura",
@@ -2764,7 +2764,7 @@ dependencies = [
[[package]] [[package]]
name = "rog_platform" name = "rog_platform"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"concat-idents", "concat-idents",
"inotify", "inotify",
@@ -2780,7 +2780,7 @@ dependencies = [
[[package]] [[package]]
name = "rog_profiles" name = "rog_profiles"
version = "4.5.7" version = "4.5.8"
dependencies = [ dependencies = [
"serde", "serde",
"serde_derive", "serde_derive",

View File

@@ -2,7 +2,7 @@
members = ["asusctl", "daemon", "daemon-user", "rog-platform", "rog-dbus", "rog-anime", "rog-aura", "rog-profiles", "rog-control-center"] members = ["asusctl", "daemon", "daemon-user", "rog-platform", "rog-dbus", "rog-anime", "rog-aura", "rog-profiles", "rog-control-center"]
[workspace.package] [workspace.package]
version = "4.5.7" version = "4.5.8"
[workspace.dependencies] [workspace.dependencies]
async-trait = "^0.1" async-trait = "^0.1"

View File

@@ -262,13 +262,13 @@ async fn do_nvidia_powerd_action(proxy: &SystemdProxy<'_>, ac_on: bool) {
if res == UnitFileState::Enabled { if res == UnitFileState::Enabled {
if ac_on { if ac_on {
proxy proxy
.stop_unit(NVIDIA_POWERD, Mode::Replace) .start_unit(NVIDIA_POWERD, Mode::Replace)
.await .await
.map_err(|e| error!("Error stopping {NVIDIA_POWERD}, {e:?}")) .map_err(|e| error!("Error stopping {NVIDIA_POWERD}, {e:?}"))
.ok(); .ok();
} else { } else {
proxy proxy
.start_unit(NVIDIA_POWERD, Mode::Replace) .stop_unit(NVIDIA_POWERD, Mode::Replace)
.await .await
.map_err(|e| error!("Error stopping {NVIDIA_POWERD}, {e:?}")) .map_err(|e| error!("Error stopping {NVIDIA_POWERD}, {e:?}"))
.ok(); .ok();